)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"53e8fe43f96443d65e3254be433900310364cffa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"53c5e88b_33030d5e","updated":"2024-02-01 09:48:42.000000000","message":"recheck unrelated failure","commit_id":"a0dad381a41c806c0f80372f98f359727b7c1636"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5242a9197b3cfaaf86cef227f3332cca64b3308e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9fb24f2e_1da0354b","updated":"2024-02-02 06:51:25.000000000","message":"recheck unrelated failure","commit_id":"a0dad381a41c806c0f80372f98f359727b7c1636"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"eda15ebfc5e922bd698990d31099e9224dcf7e28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"07627b5a_a0549748","updated":"2024-02-04 03:06:18.000000000","message":"LGTM.","commit_id":"67a1d6ad13edb9de33db5b4540bb7d7ac0c41b2d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"717eaddedf2c4ea85cc21954972311c5327f8a6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2a9728e5_9436a71c","updated":"2024-02-13 03:27:22.000000000","message":"Good catch by Eric!","commit_id":"ec99fb636633563587c6625d5a45cffa1a9381d2"}],"cinder/volume/drivers/prophetstor/dplcommon.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"10c490547e953d86134fa9365879dbef4df27bf7","unresolved":true,"context_lines":[{"line_number":141,"context_line":"                raise exception.NotAuthorized"},{"line_number":142,"context_line":"            else:"},{"line_number":143,"context_line":"                retcode \u003d errno.EIO"},{"line_number":144,"context_line":"        elif r.status_code is HTTPStatus.NOT_FOUND:"},{"line_number":145,"context_line":"            retcode \u003d errno.ENODATA"},{"line_number":146,"context_line":"        elif r.status_code is HTTPStatus.ACCEPTED:"},{"line_number":147,"context_line":"            retcode \u003d errno.EAGAIN"}],"source_content_type":"text/x-python","patch_set":3,"id":"6c634c83_d45b0e0e","line":144,"range":{"start_line":144,"start_character":27,"end_line":144,"end_character":50},"updated":"2024-02-12 22:38:04.000000000","message":"Use of \"is\" here instead of \"\u003d\u003d\" looks like a potential latent bug.  Does this work?","commit_id":"67a1d6ad13edb9de33db5b4540bb7d7ac0c41b2d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e0115ab3f3619d757940cf1cc213b6f50b34c71e","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                raise exception.NotAuthorized"},{"line_number":142,"context_line":"            else:"},{"line_number":143,"context_line":"                retcode \u003d errno.EIO"},{"line_number":144,"context_line":"        elif r.status_code is HTTPStatus.NOT_FOUND:"},{"line_number":145,"context_line":"            retcode \u003d errno.ENODATA"},{"line_number":146,"context_line":"        elif r.status_code is HTTPStatus.ACCEPTED:"},{"line_number":147,"context_line":"            retcode \u003d errno.EAGAIN"}],"source_content_type":"text/x-python","patch_set":3,"id":"bd4dd05c_af9e5655","line":144,"range":{"start_line":144,"start_character":27,"end_line":144,"end_character":50},"in_reply_to":"6c634c83_d45b0e0e","updated":"2024-02-13 00:54:54.000000000","message":"These are class constants so the logic may work as long as the underlying library is using the same, but I agree mixed usage of is and \u003d\u003d is quite confusing and it\u0027s better to switch to \u0027\u003d\u003d\u0027","commit_id":"67a1d6ad13edb9de33db5b4540bb7d7ac0c41b2d"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"10c490547e953d86134fa9365879dbef4df27bf7","unresolved":true,"context_lines":[{"line_number":143,"context_line":"                retcode \u003d errno.EIO"},{"line_number":144,"context_line":"        elif r.status_code is HTTPStatus.NOT_FOUND:"},{"line_number":145,"context_line":"            retcode \u003d errno.ENODATA"},{"line_number":146,"context_line":"        elif r.status_code is HTTPStatus.ACCEPTED:"},{"line_number":147,"context_line":"            retcode \u003d errno.EAGAIN"},{"line_number":148,"context_line":"            try:"},{"line_number":149,"context_line":"                data \u003d r.json()"}],"source_content_type":"text/x-python","patch_set":3,"id":"09c68d04_29a96f08","line":146,"range":{"start_line":146,"start_character":27,"end_line":146,"end_character":29},"updated":"2024-02-12 22:38:04.000000000","message":"ditto ^","commit_id":"67a1d6ad13edb9de33db5b4540bb7d7ac0c41b2d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e0115ab3f3619d757940cf1cc213b6f50b34c71e","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                retcode \u003d errno.EIO"},{"line_number":144,"context_line":"        elif r.status_code is HTTPStatus.NOT_FOUND:"},{"line_number":145,"context_line":"            retcode \u003d errno.ENODATA"},{"line_number":146,"context_line":"        elif r.status_code is HTTPStatus.ACCEPTED:"},{"line_number":147,"context_line":"            retcode \u003d errno.EAGAIN"},{"line_number":148,"context_line":"            try:"},{"line_number":149,"context_line":"                data \u003d r.json()"}],"source_content_type":"text/x-python","patch_set":3,"id":"085fa625_29ac2bfd","line":146,"range":{"start_line":146,"start_character":27,"end_line":146,"end_character":29},"in_reply_to":"09c68d04_29a96f08","updated":"2024-02-13 00:54:54.000000000","message":"Done","commit_id":"67a1d6ad13edb9de33db5b4540bb7d7ac0c41b2d"}]}
