)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"675a5768b40926636f9db53e7774094b4d772724","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"594c481f_a8b383e4","updated":"2024-02-03 21:08:57.000000000","message":"One question inline, otherwise this patch LGTM.","commit_id":"8b3b9404a7ee91681bd00434d17c081cc030c6ae"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4395fef06cf9ee729c75cece2497865c4bb2cd54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f9d953e6_c3d3deb6","updated":"2024-02-05 18:50:57.000000000","message":"Revisions LGTM.","commit_id":"337adf9a128e2897c73d2b91c2961649e38a95ca"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"cbe8be29aa9651ca75bafdcdacbbf452a83641ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"01cf44d0_9330f4f7","updated":"2024-02-04 08:41:02.000000000","message":"recheck unrelated","commit_id":"337adf9a128e2897c73d2b91c2961649e38a95ca"}],"cinder/tests/unit/volume/drivers/nexenta/test_nexenta5_jsonrpc.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"675a5768b40926636f9db53e7774094b4d772724","unresolved":true,"context_lines":[{"line_number":1185,"context_line":"        get_settings.return_value \u003d settings"},{"line_number":1186,"context_line":"        self.assertIsNone(self.proxy.update_lock())"},{"line_number":1187,"context_line":"        path \u003d \u0027%s:%s\u0027 % (guid, self.proxy.path)"},{"line_number":1188,"context_line":"        if isinstance(path, str):"},{"line_number":1189,"context_line":"            path \u003d path.encode(\u0027utf-8\u0027)"},{"line_number":1190,"context_line":"        expected \u003d md5(path, usedforsecurity\u003dFalse).hexdigest()"},{"line_number":1191,"context_line":"        self.assertEqual(expected, self.proxy.lock)"}],"source_content_type":"text/x-python","patch_set":1,"id":"b2fed359_48b5943e","line":1188,"range":{"start_line":1188,"start_character":8,"end_line":1188,"end_character":33},"updated":"2024-02-03 21:08:57.000000000","message":"I wonder if we really need this check ... given line 1188, I don\u0027t see how it could be possible for path *not* to be a string in py3","commit_id":"8b3b9404a7ee91681bd00434d17c081cc030c6ae"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0d270ea4d84fd166372aadd7442cdb83b3583391","unresolved":false,"context_lines":[{"line_number":1185,"context_line":"        get_settings.return_value \u003d settings"},{"line_number":1186,"context_line":"        self.assertIsNone(self.proxy.update_lock())"},{"line_number":1187,"context_line":"        path \u003d \u0027%s:%s\u0027 % (guid, self.proxy.path)"},{"line_number":1188,"context_line":"        if isinstance(path, str):"},{"line_number":1189,"context_line":"            path \u003d path.encode(\u0027utf-8\u0027)"},{"line_number":1190,"context_line":"        expected \u003d md5(path, usedforsecurity\u003dFalse).hexdigest()"},{"line_number":1191,"context_line":"        self.assertEqual(expected, self.proxy.lock)"}],"source_content_type":"text/x-python","patch_set":1,"id":"26274f3b_4d428c39","line":1188,"range":{"start_line":1188,"start_character":8,"end_line":1188,"end_character":33},"in_reply_to":"b2fed359_48b5943e","updated":"2024-02-04 06:02:11.000000000","message":"I agree. Probably this was added to behave like six.PY3 check...","commit_id":"8b3b9404a7ee91681bd00434d17c081cc030c6ae"}]}
