)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"52cc7ab7bb66f0efac1eefa5fcb370efe0b90758","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8fa9c8b5_b9fc6798","updated":"2024-04-05 05:18:21.000000000","message":"run-HPE Nimble Storage CI","commit_id":"a1c6bb446244e730f4c7083ad14cf6524ae87d1e"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"53e2808b288a5ca399366a9e79b53f1f35860a31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"e4114ad8_3c723bfe","updated":"2024-04-05 06:11:55.000000000","message":"run-HPE Nimble Storage CI","commit_id":"a1c6bb446244e730f4c7083ad14cf6524ae87d1e"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"50ab559ed11ccbcad4c755c00a43116fa6ce4d8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f1cf8981_ef7ed21d","updated":"2024-04-05 08:53:51.000000000","message":"run-HPE Nimble Storage CI","commit_id":"a1c6bb446244e730f4c7083ad14cf6524ae87d1e"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"7d58ea8d49866e097746bd6b4ed788246504073d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"6e9e8e86_a756287d","updated":"2024-04-16 06:41:27.000000000","message":"run-HPE Nimble Storage CI","commit_id":"b44584ec07ba4481e51ce8ae360987bfd81bb0c8"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"f13849cdf9b5f50847944cbc7c95df601cf3e7e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"aff2405d_90c8eba5","updated":"2024-05-28 09:10:40.000000000","message":"run-HPE Nimble Storage CI","commit_id":"b44584ec07ba4481e51ce8ae360987bfd81bb0c8"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"49354d5c65545b7898e8b3813e8d68dd84db4d9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"badc0588_02910f3a","updated":"2024-05-28 10:22:01.000000000","message":"run-HPE Nimble Storage CI","commit_id":"296664f230af0f8e24ee131aaa4044857f623b8a"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"5966b93febccf121536bce27027750c94584eddf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"24d82a53_a8320466","updated":"2024-07-30 23:42:31.000000000","message":"-1: don\u0027t forget to update the driver support matrix in\n`doc/source/reference/support-matrix.ini`.\n\nI think the code looks good overall.","commit_id":"8d99519ac26d2cc41d61e71a59aa657fbc330b89"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"4648db2a081fa41f4ab0c3b7d27f2b9d3133c5f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"c3d53f1d_01dcf40b","updated":"2024-07-04 03:59:33.000000000","message":"Thank you Hemna","commit_id":"8d99519ac26d2cc41d61e71a59aa657fbc330b89"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"1e35064288669e1fca180b509d8844a84f5474c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"0bbc5f43_715c4870","updated":"2024-06-18 05:30:41.000000000","message":"Zuul and HPE Nimble Storage CI have passed (on 17th june)","commit_id":"8d99519ac26d2cc41d61e71a59aa657fbc330b89"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"bd506a21ffa9b297a91506f68f020de5dd7de941","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"146d8226_9e783f8c","in_reply_to":"24d82a53_a8320466","updated":"2024-07-31 06:08:01.000000000","message":"Done","commit_id":"8d99519ac26d2cc41d61e71a59aa657fbc330b89"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"a13e3c46ac6134beaf55a8ad916a6f0fac9529b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"4053d7ae_045bc538","updated":"2024-08-02 05:52:01.000000000","message":"Hi Jon/Hemna,\nIt would be great if you can revisit this patch \u0026 provide feedback.\n\nThanks.","commit_id":"5e7f37f316eaf04b9ea90e6dd45330035bdad4c5"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"29e65b06c85664179b053c5f0bb17173535b1b76","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"e72cd5f5_aa7b9cb7","updated":"2024-08-27 06:24:17.000000000","message":"Hi Jon/Hemna,\nWe are close to feature freeze deadline (Aug 30).\nMay i please request your feedback.\n\nThanks.","commit_id":"5e7f37f316eaf04b9ea90e6dd45330035bdad4c5"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"a2bedeb48de15ef26c71ebdfa64c034f63c9e883","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"c7146f7e_669fb0ed","updated":"2024-08-29 16:37:11.000000000","message":"My issues are addressed, looks good to me.","commit_id":"5e7f37f316eaf04b9ea90e6dd45330035bdad4c5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"711b88ce4cada054151163220af673b1798c545c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"f5ac8f32_f97ac99c","updated":"2024-08-30 15:30:12.000000000","message":"See comments inline for some things you could address.","commit_id":"5e7f37f316eaf04b9ea90e6dd45330035bdad4c5"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"1a8817595a9336fa0dd3b9eb67f959e228e76ac1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"d636b10b_ff23573d","updated":"2024-08-30 15:36:23.000000000","message":"Thank you Brian for the feedback.\nI will check.","commit_id":"5e7f37f316eaf04b9ea90e6dd45330035bdad4c5"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"cb7f549309031979366bd385c90301f3c6685d14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"8fcdc457_26e5b5ff","updated":"2024-09-02 06:16:58.000000000","message":"Thank you Hemna and Nilesh","commit_id":"5e7f37f316eaf04b9ea90e6dd45330035bdad4c5"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"3b8ba08374d52bdbce2d525ce9c2963641b2b3a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"9333ec0d_302d137d","updated":"2024-08-30 05:47:00.000000000","message":"Thank you Jon","commit_id":"5e7f37f316eaf04b9ea90e6dd45330035bdad4c5"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"985142570dae612f7985f8652ef255c4067a4b45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"1c8f931a_127419d3","updated":"2024-09-02 14:29:44.000000000","message":"Thank you Jon, Hemna and Brian. The patch has merged.","commit_id":"5e7f37f316eaf04b9ea90e6dd45330035bdad4c5"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"bd506a21ffa9b297a91506f68f020de5dd7de941","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"51e9da1c_96cf6f5e","updated":"2024-07-31 06:08:01.000000000","message":"Thank you Jon. Now the support-matrix.ini is updated.","commit_id":"5e7f37f316eaf04b9ea90e6dd45330035bdad4c5"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"e603f8a2dc311ca6d3506a7ecd64fbdb88586cc5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"ef08349e_c50c7724","updated":"2024-07-31 09:33:23.000000000","message":"Zuul and HPE Nimble Storage CI have passed on latest patchset","commit_id":"5e7f37f316eaf04b9ea90e6dd45330035bdad4c5"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"e5c3b230d251e8747db90f3439f9863fa87f4d60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"29fd48a7_54e22993","updated":"2024-09-03 09:43:49.000000000","message":"i submitted a follow up patch. tried to address remaining comments.\nhttps://review.opendev.org/c/openstack/cinder/+/927782","commit_id":"5e7f37f316eaf04b9ea90e6dd45330035bdad4c5"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"9b6faaffed7ea596a89687320d17cd69fde66368","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"facd3f68_792a7a53","updated":"2024-09-02 05:11:07.000000000","message":"recheck - openstack-tox-py311 is failing.","commit_id":"5e7f37f316eaf04b9ea90e6dd45330035bdad4c5"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"3c83e3ae1d210353e1b640c99db4e41431db9abe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"6089182b_7ffa1401","updated":"2024-09-02 08:38:07.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican","commit_id":"5e7f37f316eaf04b9ea90e6dd45330035bdad4c5"}],"cinder/tests/unit/volume/drivers/hpe/test_nimble.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"711b88ce4cada054151163220af673b1798c545c","unresolved":true,"context_lines":[{"line_number":1282,"context_line":"        \u0027default\u0027, \u0027*\u0027, devices\u003dREPL_DEVICES))"},{"line_number":1283,"context_line":"    def test_time_to_secs(self):"},{"line_number":1284,"context_line":"        time_secs \u003d [(\u002701:05\u0027, 3900), (\u002701:02:15am\u0027, 3735),"},{"line_number":1285,"context_line":"                     (\u002703:07:20pm\u0027, 54440)]"},{"line_number":1286,"context_line":"        for time, seconds in time_secs:"},{"line_number":1287,"context_line":"            ret_secs \u003d self.driver._time_to_secs(time)"},{"line_number":1288,"context_line":"            self.assertEqual(ret_secs, seconds)"}],"source_content_type":"text/x-python","patch_set":15,"id":"307d4e15_24361ab8","line":1285,"updated":"2024-08-30 15:30:12.000000000","message":"I think you should beef up the test data.  For example, your function is supposed to be able to handle 24 hour format, but you don\u0027t test that here.  Also, would be good to check the boundary conditions, e.g., 00:00:00 and 12:59:59pm and 23:59:59, a few like that.","commit_id":"5e7f37f316eaf04b9ea90e6dd45330035bdad4c5"}],"cinder/volume/drivers/hpe/nimble.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"711b88ce4cada054151163220af673b1798c545c","unresolved":true,"context_lines":[{"line_number":1010,"context_line":"            raise NimbleAPIException(msg)"},{"line_number":1011,"context_line":"        return None, None"},{"line_number":1012,"context_line":""},{"line_number":1013,"context_line":"    def _time_to_secs(self, time):"},{"line_number":1014,"context_line":"        # time is specified as \u0027HH:MM\u0027 or \u0027HH:MM:SS\u0027"},{"line_number":1015,"context_line":"        # qualified with am or pm, or in 24-hour clock"},{"line_number":1016,"context_line":"        time \u003d time.strip(\"\u0027\")"}],"source_content_type":"text/x-python","patch_set":15,"id":"8d9b5f1c_d6afa87a","line":1013,"updated":"2024-08-30 15:30:12.000000000","message":"This kind of function worries me, because it\u0027s easy to miss some corner cases.  Are there really no python stdlib functions you can use/adapt in writing this function?\n\nAlso, would be good to say in your docstring for this function exactly what seconds we\u0027re talking about here, because the standard unix time is seconds-since-the-epoch, but this function is computing seconds after midnight.  (Just want to make sure someone doesn\u0027t come along and \"fix\" your function.)","commit_id":"5e7f37f316eaf04b9ea90e6dd45330035bdad4c5"}],"doc/source/configuration/block-storage/drivers/nimble-volume-driver.rst":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"711b88ce4cada054151163220af673b1798c545c","unresolved":true,"context_lines":[{"line_number":271,"context_line":""},{"line_number":272,"context_line":"To enable consistency group replication, follow below steps:"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"1. Add `replication_device` to storage backend settings in `cinder.conf`, then"},{"line_number":275,"context_line":"   restart Cinder Volume service."},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"   Example of `cinder.conf` for volume replications:"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5035f84b_8e2819bd","line":274,"range":{"start_line":274,"start_character":7,"end_line":274,"end_character":8},"updated":"2024-08-30 15:30:12.000000000","message":"Note: you need to use double-backticks (\\`\\`) to get monospace font; single backticks will be rendered in italics (which I don\u0027t think is what you\u0027re going for here)","commit_id":"5e7f37f316eaf04b9ea90e6dd45330035bdad4c5"}]}