)]}'
{"id":"openstack%2Fcinder~908808","triplet_id":"openstack%2Fcinder~stable%2F2023.1~I5be7eaba68a5b8e1c43f0d95486b5c79c14e1b95","project":"openstack/cinder","branch":"stable/2023.1","attention_set":{},"removed_from_attention_set":{"27615":{"account":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"last_update":"2024-02-21 16:57:25.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I5be7eaba68a5b8e1c43f0d95486b5c79c14e1b95","subject":"Skip sparse copy during volume reimage","status":"MERGED","created":"2024-02-13 05:31:06.000000000","updated":"2024-02-21 16:58:31.000000000","submitted":"2024-02-21 16:57:25.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"908808","cherry_pick_of_change":905536,"cherry_pick_of_patch_set":1,"meta_rev_id":"b52142b5b86b7635c838993870a82ec07cece7cc","_number":908808,"virtual_id_number":908808,"owner":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-02-21 16:57:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2024-02-21 15:08:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":2,"date":"2024-02-14 14:20:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2024-02-21 15:08:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"recommended":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":1,"date":"2024-02-14 14:20:39.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","value":1,"default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":21863,"name":"Infinidat CI","email":"jenkins@infinidat.com","username":"infinidat-openstack"},{"_account_id":22248,"name":"HPE AlletraMP iSCSI CI","email":"hp.cinder.blr.ci@groups.ext.hpe.com","username":"hp-storage-blr-ci","tags":["SERVICE_USER"]},{"_account_id":28801,"name":"Cisco Cinder CI","email":"cisco-cinder-ci@cisco.com","username":"cisco-cinder-ci"},{"_account_id":33746,"name":"YADRO TATLIN CI","email":"tatlin_ci@yadro.com","username":"tatlin-ci"}],"REVIEWER":[{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-02-13 05:42:13.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-02-13 05:57:19.000000000","updated_by":{"_account_id":28801,"name":"Cisco Cinder CI","email":"cisco-cinder-ci@cisco.com","username":"cisco-cinder-ci"},"reviewer":{"_account_id":28801,"name":"Cisco Cinder CI","email":"cisco-cinder-ci@cisco.com","username":"cisco-cinder-ci"},"state":"CC"},{"updated":"2024-02-13 06:16:17.000000000","updated_by":{"_account_id":22248,"name":"HPE AlletraMP iSCSI CI","email":"hp.cinder.blr.ci@groups.ext.hpe.com","username":"hp-storage-blr-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22248,"name":"HPE AlletraMP iSCSI CI","email":"hp.cinder.blr.ci@groups.ext.hpe.com","username":"hp-storage-blr-ci","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-02-13 06:54:17.000000000","updated_by":{"_account_id":33746,"name":"YADRO TATLIN CI","email":"tatlin_ci@yadro.com","username":"tatlin-ci"},"reviewer":{"_account_id":33746,"name":"YADRO TATLIN CI","email":"tatlin_ci@yadro.com","username":"tatlin-ci"},"state":"CC"},{"updated":"2024-02-13 07:24:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-02-13 07:51:08.000000000","updated_by":{"_account_id":21863,"name":"Infinidat CI","email":"jenkins@infinidat.com","username":"infinidat-openstack"},"reviewer":{"_account_id":21863,"name":"Infinidat CI","email":"jenkins@infinidat.com","username":"infinidat-openstack"},"state":"CC"},{"updated":"2024-02-14 14:20:39.000000000","updated_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"reviewer":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"state":"REVIEWER"},{"updated":"2024-02-21 15:08:49.000000000","updated_by":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"reviewer":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"state":"REVIEWER"}],"messages":[{"id":"a78b97ebf20df7e058006f6ba7063a2cf48dd9d5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2024-02-13 05:31:06.000000000","message":"Patch Set 1: Cherry Picked from branch stable/2023.2.","accounts_in_message":[],"_revision_number":1},{"id":"36cd5eacc2e9d2fa54ee688bf7bd1a4ae79d0a04","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-02-13 05:42:13.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/341df8f64db04dcca7798cf8b9385803\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/0a6474fa39b14165a1e2c4da3340dc46 : SUCCESS in 8m 32s (non-voting)\n- openstack-tox-py310-arm64 https://zuul.opendev.org/t/openstack/build/6b1e44a0576c47b8b0f5fa620fc1e2e8 : SUCCESS in 10m 07s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f0685a7a5235104b3dbd1c2e7469c5bbed8292c1","author":{"_account_id":28801,"name":"Cisco Cinder CI","email":"cisco-cinder-ci@cisco.com","username":"cisco-cinder-ci"},"date":"2024-02-13 05:57:19.000000000","message":"Patch Set 1:\n\nBuild failed.\nhttps://127.0.0.1:9000/t/openstack/buildset/3e54645d3079480cabed7244a1e14181\n\n- dsvm-tempest-cisco-zonemanager-job https://127.0.0.1:9000/t/openstack/build/8b363d355b8d4d118d7d9e8162c77316 : POST_FAILURE in 22m 53s","accounts_in_message":[],"_revision_number":1},{"id":"aee023e5037dcb541b07aee66d9edc15dad420aa","author":{"_account_id":22248,"name":"HPE AlletraMP iSCSI CI","email":"hp.cinder.blr.ci@groups.ext.hpe.com","username":"hp-storage-blr-ci","tags":["SERVICE_USER"]},"date":"2024-02-13 06:16:17.000000000","message":"Patch Set 1:\n\nBuild failed.\n\n- 3par-iscsi-driver-master-client-pip-ssa02-dsvm https://github.com/hpe-storage/hpe_cinder_logs/tree/master/new_logs/908808 : FAILURE in 43m 30s","accounts_in_message":[],"_revision_number":1},{"id":"43bc65376e26626c538cfc9574c09f2f49bf9673","author":{"_account_id":33746,"name":"YADRO TATLIN CI","email":"tatlin_ci@yadro.com","username":"tatlin-ci"},"date":"2024-02-13 06:54:17.000000000","message":"Patch Set 1:\n\nBuild succeeded (iSCSI).\nLogs: http://tempest-openstack.spb.yadro.com/openstack-gerrit-trigger-iscsi/694/.","accounts_in_message":[],"_revision_number":1},{"id":"4b5c5079441452cf10996555f20374887e5135ee","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-02-13 07:24:35.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/961d4fe5028d494a9d80b36439ecf8e7\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5abecde17dcc4308be42c28a65ebce18 : SUCCESS in 6m 32s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/6cb651f2dfe7484bb1944a97c46c7c68 : SUCCESS in 11m 07s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d190a8c92b7340718c341b49e9623925 : SUCCESS in 13m 12s\n- grenade https://zuul.opendev.org/t/openstack/build/da5b19223f2642a9873f1d28274de9b4 : SUCCESS in 52m 59s\n- grenade-skip-level https://zuul.opendev.org/t/openstack/build/819ad4f2799749888ced837590da65a4 : FAILURE in 32m 13s (non-voting)\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/c09285504e0e4d7f9a77c45f17929393 : SUCCESS in 52m 25s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/0145c12d7eb640aaa2e8acfb958984d6 : SUCCESS in 41m 51s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/c4e9c0d340f848b8851ffa6729c6e33d : SUCCESS in 11m 16s\n- cinder-code-coverage https://zuul.opendev.org/t/openstack/build/cf5f7fdbe0c44e08be12d0d15ece69d4 : SUCCESS in 13m 48s (non-voting)\n- cinder-mypy https://zuul.opendev.org/t/openstack/build/b7daf64805744190a12cb4fd512bebac : SUCCESS in 4m 44s\n- cinder-tox-bandit-baseline https://zuul.opendev.org/t/openstack/build/048daec44ae14d03adacd410628d8735 : SUCCESS in 6m 36s (non-voting)\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/093cca86cc9a4d3797337a4d288df61b : SUCCESS in 5m 15s\n- openstack-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/4c76e45c8dc245108bb16459d46a474a : SUCCESS in 5m 06s\n- cinder-rally-task https://zuul.opendev.org/t/openstack/build/81453b6deb2f4799883ca2a71b2fc47c : SUCCESS in 35m 19s (non-voting)\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/445f9e71c3994f75b2f4f25faf08f476 : FAILURE in 5m 55s (non-voting)\n- cinder-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/1cb5f9f246ab4d9fbf2d38e57f62dea7 : SUCCESS in 1h 24m 48s\n- cinder-plugin-ceph-tempest-mn-aa https://zuul.opendev.org/t/openstack/build/e481ef684e7c41749950281342bb1a9c : SUCCESS in 1h 30m 42s (non-voting)\n- cinder-tempest-plugin-lvm-lio-barbican https://zuul.opendev.org/t/openstack/build/f3c5a15685a2422aa454287d1b9a9000 : SUCCESS in 1h 21m 02s\n- cinder-grenade-mn-sub-volbak https://zuul.opendev.org/t/openstack/build/09d187e19fee4707b6600c3c6ace20b5 : SUCCESS in 1h 05m 12s\n- cinder-tempest-lvm-multibackend https://zuul.opendev.org/t/openstack/build/1c29faa54ebf420ea854268f25f94f04 : SUCCESS in 1h 14m 21s (non-voting)\n- cinder-for-glance-optimized https://zuul.opendev.org/t/openstack/build/93e4bd136b8740628966a5e2d0188a55 : SUCCESS in 42m 37s (non-voting)\n- devstack-plugin-nfs-tempest-full https://zuul.opendev.org/t/openstack/build/5e3d44153ad1425abcf19fe56452386f : SUCCESS in 1h 19m 02s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/1bbcec949dd44c5482ae361f3d4cbade : SUCCESS in 1h 17m 29s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/c772134e056c448689d72115d3e3c3c5 : SUCCESS in 53m 24s\n- tempest-integrated-storage-ubuntu-focal https://zuul.opendev.org/t/openstack/build/93bb58bd0cce4713891dd82420df9e38 : SUCCESS in 1h 05m 16s","accounts_in_message":[],"_revision_number":1},{"id":"d20815c0a3751e791a00123e28b208ffefb600c1","author":{"_account_id":21863,"name":"Infinidat CI","email":"jenkins@infinidat.com","username":"infinidat-openstack"},"date":"2024-02-13 07:51:08.000000000","message":"Patch Set 1:\n\nBuild succeeded. For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n* Infinidat FC http://openstack-ci-logs.aws.infinidat.com#logs/refs-changes-08-908808-1/FC/ : SUCCESS in 2h 10m 12s\n* Infinidat iSCSI http://openstack-ci-logs.aws.infinidat.com#logs/refs-changes-08-908808-1/iSCSI/ : SUCCESS in 1h 38m 4s\n\nLeave a comment with run-INFINIDAT to trigger a recheck. For more information about Infinidat CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/INFINIDAT_CI","accounts_in_message":[],"_revision_number":1},{"id":"018766a6c93361cab22b8a96e370c80afc809c25","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2024-02-14 14:20:39.000000000","message":"Patch Set 1: Code-Review+2 Review-Priority+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2fe1c1558d855db4175c000b667519057447c140","author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"date":"2024-02-21 15:08:49.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"34b724690c82813ed22df91120a818567a3a4c2a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-02-21 15:09:32.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"421a9ed4e46fb0743ea183cfa699b00de0260424","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-02-21 16:57:25.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/ca0fab6092864dc085c8b026b17fc2e6\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/89fa927536094f629c400f847f90fed2 : SUCCESS in 6m 02s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/3ce4400c05c444239c18f073b48bb9a7 : SUCCESS in 10m 10s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4e5f5dfdeeae48dd988e415c734111af : SUCCESS in 12m 30s\n- grenade https://zuul.opendev.org/t/openstack/build/86cfec10bd8f45e491480359ceee70a7 : SUCCESS in 1h 02m 27s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/88945ad086394954988b6a0f54ff6561 : SUCCESS in 1h 24m 57s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/4f211ea07b494d7c949494488107eb74 : SUCCESS in 53m 22s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/9713994c300d48e2a8215ac2e935e421 : SUCCESS in 10m 57s\n- cinder-grenade-mn-sub-volbak https://zuul.opendev.org/t/openstack/build/afe18e9aed3b4b8783549eb762139e04 : SUCCESS in 1h 12m 16s\n- cinder-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/0e019cc31a444b1eb18f64a54d20d432 : SUCCESS in 1h 47m 10s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/52ad90121277448e99ab15135a06d5b9 : SUCCESS in 46m 33s\n- tempest-integrated-storage-ubuntu-focal https://zuul.opendev.org/t/openstack/build/bf2fd8aa310b4020977b2b3ed527cb4f : SUCCESS in 1h 18m 27s","accounts_in_message":[],"_revision_number":1},{"id":"ffa3783d7becbdc3785093c7a8c70baa0730a367","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-02-21 16:57:25.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"b52142b5b86b7635c838993870a82ec07cece7cc","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-02-21 16:58:31.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a896510731e648ceb9c069e62f2b98e4\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6b0bed55b14c4802a8083f8ad155534f : SUCCESS in 48s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/74719408e73f45498d862535604a2c21 : SUCCESS in 42s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"8d7e292bcd9ae610ac6341de2d00b8990252c24c","revisions":{"8d7e292bcd9ae610ac6341de2d00b8990252c24c":{"kind":"REWORK","_number":1,"created":"2024-02-13 05:31:06.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/08/908808/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder","ref":"refs/changes/08/908808/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder refs/changes/08/908808/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder refs/changes/08/908808/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder refs/changes/08/908808/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder refs/changes/08/908808/1"}}},"commit":{"parents":[{"commit":"e848c7cfc75c549b22be2b02a9f8360f5db2b246","subject":"Merge \"Revert \"Driver assisted migration on retype when it\u0027s safe\"\" into stable/2023.1","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/e848c7cfc75c549b22be2b02a9f8360f5db2b246"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2023-09-25 16:17:49.000000000","tz":0},"committer":{"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","date":"2024-02-13 05:31:06.000000000","tz":0},"subject":"Skip sparse copy during volume reimage","message":"Skip sparse copy during volume reimage\n\nWhen rebuilding a volume backed instance, while copying the new\nimage to the existing volume, we preserve sparseness.\nThis could be problematic since we don\u0027t write the zero blocks of\nthe new image and the data in the old image can still persist\nleading to a data leak scenario.\n\nTo prevent this, we are using `-S 0`[1][2] option with the `qemu-img convert`\ncommand to write all the zero bytes into the volume.\n\nIn the testing done, this doesn\u0027t seem to be a problem with known \u0027raw\u0027\nimages but good to handle the case anyway.\n\nFollowing is the testing performed with 3 images:\n\n1. CIRROS QCOW2 to RAW\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\nVolume size: 1 GiB\nImage size (raw): 112 MiB\n\nCREATE VOLUME FROM IMAGE (without -S 0)\n\nLVS (10.94% allocated)\n  volume-91ea43ef-684c-402f-896e-63e45e5f4fff stack-volumes-lvmdriver-1 Vwi-a-tz-- 1.00g stack-volumes-lvmdriver-1-pool 10.94\n\nREBUILD (with -S 0)\n\nLVS (10.94% allocated)\n  volume-91ea43ef-684c-402f-896e-63e45e5f4fff stack-volumes-lvmdriver-1 Vwi-aotz-- 1.00g stack-volumes-lvmdriver-1-pool 10.94\n\nConclusion:\nSame space is consumed on the disk with and without preserving sparseness.\n\n2. DEBIAN QCOW2 to RAW\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\nVolume size: 3 GiB\nImage size (raw): 2 GiB\n\nCREATE VOLUME FROM IMAGE (without -S 0)\n\nLVS (66.67% allocated)\n  volume-edc42b6a-df5d-420e-85d3-b3e52bcb735e stack-volumes-lvmdriver-1 Vwi-a-tz-- 3.00g stack-volumes-lvmdriver-1-pool 66.67\n\nREBUILD (with -S 0)\n\nLVS (66.67% allocated)\n  volume-edc42b6a-df5d-420e-85d3-b3e52bcb735e stack-volumes-lvmdriver-1 Vwi-aotz-- 3.00g stack-volumes-lvmdriver-1-pool 66.67\n\nConclusion:\nSame space is consumed on the disk with and without preserving sparseness.\n\n3. FEDORA QCOW2 TO RAW\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\nCREATE VOLUME FROM IMAGE (without -S 0)\n\nVolume size: 6 GiB\nImage size (raw): 5 GiB\n\nLVS (83.33% allocated)\n  volume-efa1a227-a30d-4385-867a-db22a3e80ad7 stack-volumes-lvmdriver-1 Vwi-a-tz-- 6.00g stack-volumes-lvmdriver-1-pool 83.33\n\nREBUILD (with -S 0)\n\nLVS (83.33% allocated)\n  volume-efa1a227-a30d-4385-867a-db22a3e80ad7 stack-volumes-lvmdriver-1 Vwi-aotz-- 6.00g stack-volumes-lvmdriver-1-pool 83.33\n\nConclusion:\nSame space is consumed on the disk with and without preserving sparseness.\n\nAnother testing was done to check if the `-S 0` option actually\nworks in OpenStack setup.\nNote that we are converting qcow2 to qcow2 image which won\u0027t\nhappen in a real world deployment and only for test purposes.\n\nDEBIAN QCOW2 TO QCOW2\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\nCREATE VOLUME FROM IMAGE (without -S 0)\n\nLVS (52.61% allocated)\n  volume-de581f84-e722-4f4a-94fb-10f767069f50 stack-volumes-lvmdriver-1 Vwi-a-tz-- 3.00g stack-volumes-lvmdriver-1-pool 52.61\n\nREBUILD (with -S 0)\n\nLVS (66.68% allocated)\n  volume-de581f84-e722-4f4a-94fb-10f767069f50 stack-volumes-lvmdriver-1 Vwi-aotz-- 3.00g stack-volumes-lvmdriver-1-pool 66.68\n\nConclusion:\nWe can see that the space allocation increased hence we are not preserving sparseness when using the -S 0 option.\n\n[1] https://qemu-project.gitlab.io/qemu/tools/qemu-img.html#cmdoption-qemu-img-common-opts-S\n[2] https://github.com/qemu/qemu/blob/abf635ddfe3242df907f58967f3c1e6763bbca2d/qemu-img.c#L182-L186\n\nCloses-Bug: #2045431\n\nChange-Id: I5be7eaba68a5b8e1c43f0d95486b5c79c14e1b95\n(cherry picked from commit 1a8ea0eac4f449c09c4da70302be1bacc29a9b79)\n(cherry picked from commit 85857a19ab7e3f6a331aa12615a874a4b4759c28)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/8d7e292bcd9ae610ac6341de2d00b8990252c24c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/8d7e292bcd9ae610ac6341de2d00b8990252c24c"}]},"branch":"refs/heads/stable/2023.1"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"}},{"label":"Review-Priority","status":"MAY","applied_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}