)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8f3c2bf106ca854d1f342374dc93324eb16b6717","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5429b146_f4092cc3","updated":"2024-02-26 14:20:11.000000000","message":"Code \u0026 tests LGTM; PowerFlex CI is showing green.","commit_id":"cf83449bbd786f13ffa8b531e1126d02e83f7560"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"d995f8962979d8ff50e04178a6254b00d1527095","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"180e41e1_96ae5574","updated":"2024-02-28 05:10:24.000000000","message":"Code and UT look good. Zuul and PowerFlex CI have passed.","commit_id":"cf83449bbd786f13ffa8b531e1126d02e83f7560"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"873413320dbec6fc11f213ca4ddf5729d6b3c13d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a2d77e75_ed6d0fdf","updated":"2024-02-22 15:14:29.000000000","message":"OK, so this is different from the PowerMax patch in that with PowerMax, you can set the timeouts in the config, but they can be overridden by values coming back from the Unisphere API array_info.  So with PowerMax you have to worry about converting strings to ints, but not here.  Is that general analysis correct?","commit_id":"cf83449bbd786f13ffa8b531e1126d02e83f7560"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e19fde1bb8ac06d18fe74360197693bcee63ec4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"760977c0_1972a75a","updated":"2024-02-28 04:54:35.000000000","message":"core team please review","commit_id":"cf83449bbd786f13ffa8b531e1126d02e83f7560"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"dfaed3a5d5b06f62aed90adee805644f8118c863","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"117e0e0e_48c82ce9","updated":"2024-02-29 07:49:07.000000000","message":"one question inline but i won\u0027t hold the patch for that, powerflex ci is passing, LGTM.","commit_id":"cf83449bbd786f13ffa8b531e1126d02e83f7560"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"d654a0600d3eda1caf87cda09f4e205e5809b574","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b3a316d8_6eb6a974","updated":"2024-02-22 11:31:44.000000000","message":"please do review","commit_id":"cf83449bbd786f13ffa8b531e1126d02e83f7560"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e875faed7a8f0b1c77a7722d3311d619281307d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"120a4520_de521c19","updated":"2024-02-23 06:30:25.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"cf83449bbd786f13ffa8b531e1126d02e83f7560"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"a2ef8b798cb2e37be90283a97ff72d6c2b18e2a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d27aa69c_12c7276d","updated":"2024-02-23 04:24:31.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"cf83449bbd786f13ffa8b531e1126d02e83f7560"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"ea1d424733e73fe148d4934832275bb66dd06c58","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a36d3a50_48410a97","in_reply_to":"a2d77e75_ed6d0fdf","updated":"2024-02-23 05:21:33.000000000","message":"right but for safer side i have added.","commit_id":"cf83449bbd786f13ffa8b531e1126d02e83f7560"}],"cinder/volume/drivers/dell_emc/powerflex/rest_client.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"dfaed3a5d5b06f62aed90adee805644f8118c863","unresolved":true,"context_lines":[{"line_number":108,"context_line":"        self.rest_password \u003d get_config_value(\"san_password\")"},{"line_number":109,"context_line":"        self.rest_api_connect_timeout \u003d ("},{"line_number":110,"context_line":"            get_config_value(flex_utils.POWERFLEX_REST_CONNECT_TIMEOUT)"},{"line_number":111,"context_line":"            or self.rest_api_connect_timeout)"},{"line_number":112,"context_line":"        self.rest_api_read_timeout \u003d ("},{"line_number":113,"context_line":"            get_config_value(flex_utils.POWERFLEX_REST_READ_TIMEOUT)"},{"line_number":114,"context_line":"            or self.rest_api_read_timeout)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e353e46e_1c767290","line":111,"range":{"start_line":111,"start_character":12,"end_line":111,"end_character":44},"updated":"2024-02-29 07:49:07.000000000","message":"i don\u0027t understand why we are doing this, the default value of the config option is already 30, is there a case where get_config_value(flex_utils.POWERFLEX_REST_CONNECT_TIMEOUT) can return None?","commit_id":"cf83449bbd786f13ffa8b531e1126d02e83f7560"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"1fb43814733c8ac5e95ac464e154f885acd8d609","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        self.rest_password \u003d get_config_value(\"san_password\")"},{"line_number":109,"context_line":"        self.rest_api_connect_timeout \u003d ("},{"line_number":110,"context_line":"            get_config_value(flex_utils.POWERFLEX_REST_CONNECT_TIMEOUT)"},{"line_number":111,"context_line":"            or self.rest_api_connect_timeout)"},{"line_number":112,"context_line":"        self.rest_api_read_timeout \u003d ("},{"line_number":113,"context_line":"            get_config_value(flex_utils.POWERFLEX_REST_READ_TIMEOUT)"},{"line_number":114,"context_line":"            or self.rest_api_read_timeout)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3353cea5_d270c91d","line":111,"range":{"start_line":111,"start_character":12,"end_line":111,"end_character":44},"in_reply_to":"e353e46e_1c767290","updated":"2024-02-29 07:56:50.000000000","message":"No it will not.\nI do not know that if we do not specify key into cinder.conf file it will return default value will key.\nWill make sure in upcoming patch.","commit_id":"cf83449bbd786f13ffa8b531e1126d02e83f7560"}]}