)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"03331935d28fa2b0de9c5fa6dc293f1a77561e92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2a617fd7_1dfc1073","updated":"2024-03-18 09:39:23.000000000","message":"recheck tempest-slow-py3","commit_id":"fed8599eb735477c520c01ad373c3360572fc00c"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"ec1403d1c269909877fb3aac354fb980a7a6a929","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"222e0d69_dc925d62","updated":"2024-02-28 07:21:38.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"fed8599eb735477c520c01ad373c3360572fc00c"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"c992f11f1e27028cc65a7fc1cd2c8c72a56cb78d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"91671822_02755f94","updated":"2024-03-20 01:18:04.000000000","message":"recheck cinder-grenade-mn-sub-volbak","commit_id":"26e529904c7a381d75f0040211942bc1ede23873"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"3751f884c5ae69b92ed6a99bbe551ca1b88bdeb8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"61ff9cb7_e0fd4438","updated":"2024-03-19 09:36:53.000000000","message":"recheck tempest-integrated-storage","commit_id":"26e529904c7a381d75f0040211942bc1ede23873"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"5c94255c28ec22129d75e396d29154680bf1438e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6e12663a_a7623547","updated":"2024-03-22 10:04:30.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"26e529904c7a381d75f0040211942bc1ede23873"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"5cfc37fa74db6dbfe311dc63f51cdf32d472190f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"86cde5ec_9656b96d","updated":"2024-06-13 06:07:25.000000000","message":"recheck cinder-plugin-ceph-tempest","commit_id":"6ff73b157e7bc1a800a6e94627644219d6d12c7c"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"055449ac985c20a1c6d4667b0983c5b7b1fd9b64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4b6357c9_e87daafb","updated":"2024-06-06 01:38:17.000000000","message":"recheck openstacksdk-functional-devstack","commit_id":"6ff73b157e7bc1a800a6e94627644219d6d12c7c"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"24def3d6c5786024cd54bd7a0309a081ee18b4a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e5fd26e5_ef9a2979","updated":"2024-06-20 07:42:22.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican","commit_id":"524b50ec00cacbf6d490aef72c89f518a2901528"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"221eb18c5947e29e96728cb04ef524095f2b5d90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"36424b88_bbdffea1","updated":"2024-06-18 07:54:14.000000000","message":"recheck tempest-slow-py3","commit_id":"524b50ec00cacbf6d490aef72c89f518a2901528"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"6a385b8621760aa8b59787cce5e48377920f884d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"69f45bf0_f4dc194b","updated":"2024-06-14 09:33:06.000000000","message":"recheck tempest-slow-py3","commit_id":"524b50ec00cacbf6d490aef72c89f518a2901528"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"63a9bb0d8089bd3e3090d8958198e67c0c81754b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"bf95e952_ba555b2c","updated":"2024-06-21 02:30:20.000000000","message":"recheck tempest-slow-py3","commit_id":"524b50ec00cacbf6d490aef72c89f518a2901528"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"2903692f2d91e0ae45a6d7a969dce801b00df5e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"11c44bd5_39e506c6","updated":"2024-09-06 09:05:10.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"f9549a2b8547a462cc2bc6de6a192a308fe156b1"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"3941b5a48fc4be8eb7a3777bb1c7b0871c46dd17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8c9501f1_25a130b5","updated":"2024-10-09 08:17:18.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"f9549a2b8547a462cc2bc6de6a192a308fe156b1"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"e691723a6d64de0c777c7ec9abd84ed7eec067d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e66e2a40_5593ff16","updated":"2024-10-09 06:14:57.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"f9549a2b8547a462cc2bc6de6a192a308fe156b1"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"a7d541f66c241c492e2a6986cf0039f9da8d7e1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9018e7cd_06706efb","updated":"2025-01-14 01:54:59.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"7f4a10829ea34d275a575125ac97e2ba1ea6437b"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"a91cd9759af421c773b171586408094f6b4eefa0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c3bbe1c2_68e75f31","updated":"2025-01-13 01:38:34.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"7f4a10829ea34d275a575125ac97e2ba1ea6437b"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"0dab4af709887ad7ebd491d9b5d7b97f4135a022","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"df8254a6_bca54c8b","updated":"2025-01-13 09:20:22.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"7f4a10829ea34d275a575125ac97e2ba1ea6437b"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"7120310933b8cd9b75eaa82a33dfd3b9f98e3911","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f65a3696_b5829add","updated":"2025-01-08 01:41:07.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"7f4a10829ea34d275a575125ac97e2ba1ea6437b"},{"author":{"_account_id":37834,"name":"Masahiko Eba","display_name":"Eba","email":"eba.masahiko@fujitsu.com","username":"m-eba"},"change_message_id":"bfe40bb899abd9d2add45f3708eb437386b77227","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"63b28243_2ea81ef8","updated":"2025-03-25 04:52:07.000000000","message":"recheck","commit_id":"34036243c589dea40163cfe18a63c72cd9c69b76"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"ad920f716bf1badf78d9ae3a7f7d1a6d2e99258a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d95c8d86_43fce384","updated":"2025-11-12 04:37:00.000000000","message":"Like the last Fujitsu patch I reviewed this is a nice, cleanly written patch.\n\nIn terms of the tests, I am wondering if there should be a test that mocks both ```_is_qos_or_format_support``` and ```get_format_property``` (i.e. an end-to-end test for deletion with formatting)?  \n\nThe -1 is for the release note typo \u0026 copyright update.","commit_id":"71dcce7ff1abbcf7e5c19be7b96e2a94e36c73ae"},{"author":{"_account_id":37834,"name":"Masahiko Eba","display_name":"Eba","email":"eba.masahiko@fujitsu.com","username":"m-eba"},"change_message_id":"66c161f416be32881f9689b7d2c8b780eaaedf68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"31d655e5_83070b88","updated":"2025-03-28 06:59:08.000000000","message":"recheck","commit_id":"71dcce7ff1abbcf7e5c19be7b96e2a94e36c73ae"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"a469f0254bed3f8f1692c0c4391ae8fbe112d529","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"1b30782b_c60f5e28","in_reply_to":"c7a8f326_e9a4bbc3","updated":"2026-02-03 21:09:43.000000000","message":"No problem!  Just so you know, it is possible that a core will come along and require these kinds of changes (i.e. testing coverage) over merely making suggestions. \n\nAlso, just for your information, you should probably mark comments Resolved as you reply to them.  Leaving the comments open might dissuade others from offering a review as well since they may think comments are still left unadressed (especially Core, who will often rely on some community reviews to get things moving).  I originally thought it wasn\u0027t my place to mark things resolved as well, but I\u0027d get in the habit of doing that.  If someone has a problem with your resolution, they can always come and reopen the comment chain.","commit_id":"71dcce7ff1abbcf7e5c19be7b96e2a94e36c73ae"},{"author":{"_account_id":38554,"name":"Lucas Lafontaine","display_name":"Lucas","email":"l.lafontaine@jp.fujitsu.com","username":"ftilucas"},"change_message_id":"d0eeb1d801f6c717ef3a4dbd7c63e0c0e73e368d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"c7a8f326_e9a4bbc3","in_reply_to":"d95c8d86_43fce384","updated":"2026-02-03 06:37:18.000000000","message":"Thank you for your valuable feedback on this patch. I really appreciate your positive comments on the code quality.\n\nRegarding the -1 vote, I have addressed both the release note typo(\u0027tim\u0027 -\u003e \u0027time\u0027 typo.) and the copyright update as requested.\n\nFor the test suggestion regarding end-to-end testing for deletion with formatting and the naming suggestion for vendor-specific keys:\n\n- On the testing suggestion, I agree on the importance of comprehensive tests. However, to keep this patch focused on its primary functionality and ensure a quicker merge for the urgent fixes, I would like to defer adding this new end-to-end test to a follow-up patch. I will create a story/task to track this.\n- For the naming suggestion, I understand the benefits of tagging vendor-specific keys. For this patch, I have decided to keep the current naming  to maintain consistency with existing implementations. I will consider adopting the vendor-prefix format for future new keys.\n\nPlease let me know if there are any further issues.","commit_id":"71dcce7ff1abbcf7e5c19be7b96e2a94e36c73ae"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"a469f0254bed3f8f1692c0c4391ae8fbe112d529","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"58bd181a_dc07e717","updated":"2026-02-03 21:09:43.000000000","message":"LGTM.  My minor issues were addressed.  Core can determine if they want a bit more comprehensive testing added before a merge.","commit_id":"5d3148239a1db9e3e8b99c8fddfbe9f645da9114"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"ad037fc07a539e5967e9de1a602a2fac5efb86b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"aa06abc4_1c45b815","updated":"2026-02-03 21:10:46.000000000","message":"Marking back to neutral just because of the Zuul failure.\n\n@l.lafontaine@jp.fujitsu.com make sure you get the pep8 tests passing (formatting and whantot).","commit_id":"5d3148239a1db9e3e8b99c8fddfbe9f645da9114"}],"cinder/volume/drivers/fujitsu/eternus_dx/constants.py":[{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"ad920f716bf1badf78d9ae3a7f7d1a6d2e99258a","unresolved":true,"context_lines":[{"line_number":45,"context_line":"STOR_CONF \u003d \"FUJITSU_StorageConfigurationService\""},{"line_number":46,"context_line":"CTRL_CONF \u003d \"FUJITSU_ControllerConfigurationService\""},{"line_number":47,"context_line":"UNDEF_MSG \u003d \u0027Undefined Error!!\u0027"},{"line_number":48,"context_line":"FJ_DEL_VOL_FORMAT_KEY \u003d \"type:delete_with_volume_format\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"MAX_IOPS \u003d 4294967295"},{"line_number":51,"context_line":"MAX_THROUGHPUT \u003d 2097151"}],"source_content_type":"text/x-python","patch_set":11,"id":"3533c6b7_6a5414a3","line":48,"updated":"2025-11-12 04:37:00.000000000","message":"I\u0027m wondering if you should make your format key be something like \"fujitsu:delete_with_volume_format instead of using the generic word \u0027type\u0027.\n\nNot requesting a change per se, but I think it makes sense to tag your vendor-specific keys.","commit_id":"71dcce7ff1abbcf7e5c19be7b96e2a94e36c73ae"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"a469f0254bed3f8f1692c0c4391ae8fbe112d529","unresolved":false,"context_lines":[{"line_number":45,"context_line":"STOR_CONF \u003d \"FUJITSU_StorageConfigurationService\""},{"line_number":46,"context_line":"CTRL_CONF \u003d \"FUJITSU_ControllerConfigurationService\""},{"line_number":47,"context_line":"UNDEF_MSG \u003d \u0027Undefined Error!!\u0027"},{"line_number":48,"context_line":"FJ_DEL_VOL_FORMAT_KEY \u003d \"type:delete_with_volume_format\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"MAX_IOPS \u003d 4294967295"},{"line_number":51,"context_line":"MAX_THROUGHPUT \u003d 2097151"}],"source_content_type":"text/x-python","patch_set":11,"id":"3d4ac3a0_913cd7c2","line":48,"in_reply_to":"3533c6b7_6a5414a3","updated":"2026-02-03 21:09:43.000000000","message":"Done","commit_id":"71dcce7ff1abbcf7e5c19be7b96e2a94e36c73ae"}],"cinder/volume/drivers/fujitsu/eternus_dx/eternus_dx_utils.py":[{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"ad920f716bf1badf78d9ae3a7f7d1a6d2e99258a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2023 FUJITSU LIMITED"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":11,"id":"a1d41b8a_2092ebdc","line":1,"updated":"2025-11-12 04:37:00.000000000","message":"Probably need to update copyright","commit_id":"71dcce7ff1abbcf7e5c19be7b96e2a94e36c73ae"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"a469f0254bed3f8f1692c0c4391ae8fbe112d529","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2023 FUJITSU LIMITED"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":11,"id":"4c901012_7abb1632","line":1,"in_reply_to":"a1d41b8a_2092ebdc","updated":"2026-02-03 21:09:43.000000000","message":"Done","commit_id":"71dcce7ff1abbcf7e5c19be7b96e2a94e36c73ae"}],"doc/source/configuration/block-storage/drivers/fujitsu-eternus-dx-driver.rst":[{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"ad920f716bf1badf78d9ae3a7f7d1a6d2e99258a","unresolved":true,"context_lines":[{"line_number":607,"context_line":""},{"line_number":608,"context_line":".. note::"},{"line_number":609,"context_line":""},{"line_number":610,"context_line":"   For the required tim, use the following examples as a reference for"},{"line_number":611,"context_line":"   initialization."},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"   Examples of the required time to initialize a RAID1+0 volume:"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ab7cc2d6_4147f5fb","line":610,"updated":"2025-11-12 04:37:00.000000000","message":"tim -\u003e time","commit_id":"71dcce7ff1abbcf7e5c19be7b96e2a94e36c73ae"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"a469f0254bed3f8f1692c0c4391ae8fbe112d529","unresolved":false,"context_lines":[{"line_number":607,"context_line":""},{"line_number":608,"context_line":".. note::"},{"line_number":609,"context_line":""},{"line_number":610,"context_line":"   For the required tim, use the following examples as a reference for"},{"line_number":611,"context_line":"   initialization."},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"   Examples of the required time to initialize a RAID1+0 volume:"}],"source_content_type":"text/x-rst","patch_set":11,"id":"f9a824c1_aff3ca1f","line":610,"in_reply_to":"ab7cc2d6_4147f5fb","updated":"2026-02-03 21:09:43.000000000","message":"Done","commit_id":"71dcce7ff1abbcf7e5c19be7b96e2a94e36c73ae"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"ad920f716bf1badf78d9ae3a7f7d1a6d2e99258a","unresolved":true,"context_lines":[{"line_number":621,"context_line":""},{"line_number":622,"context_line":"   .. code-block:: ini"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"      $ cinder type-key \u003cvolume_type_id\u003e set type:delete_with_volume_format\u003dTrue"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"   For \u003cvolume_type_id\u003e, specify the ID of the volume type that is to be"},{"line_number":627,"context_line":"   deleted."}],"source_content_type":"text/x-rst","patch_set":11,"id":"f91129bb_77cea127","line":624,"updated":"2025-11-12 04:37:00.000000000","message":"Remember to update this as well (and the release notes) if you choose to rename your extra spec.","commit_id":"71dcce7ff1abbcf7e5c19be7b96e2a94e36c73ae"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"a469f0254bed3f8f1692c0c4391ae8fbe112d529","unresolved":false,"context_lines":[{"line_number":621,"context_line":""},{"line_number":622,"context_line":"   .. code-block:: ini"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"      $ cinder type-key \u003cvolume_type_id\u003e set type:delete_with_volume_format\u003dTrue"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"   For \u003cvolume_type_id\u003e, specify the ID of the volume type that is to be"},{"line_number":627,"context_line":"   deleted."}],"source_content_type":"text/x-rst","patch_set":11,"id":"99899c22_f1e1ee37","line":624,"in_reply_to":"f91129bb_77cea127","updated":"2026-02-03 21:09:43.000000000","message":"Done","commit_id":"71dcce7ff1abbcf7e5c19be7b96e2a94e36c73ae"}]}