)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36345,"name":"saikrishna","display_name":"saikrishna","email":"gksaikrishna@gmail.com"},"change_message_id":"8f2421cb5a84fbb23264da64ada83be54d43800d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e9d311ee_31e411f4","updated":"2024-03-24 17:50:09.000000000","message":"LGTM","commit_id":"de6a4ab2ffaaa97e3f12975b3cdf5c36e333dbe9"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"6242ee1675360fad2221eab044e8fcf6e4f15189","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6a6320c1_52ca1661","updated":"2024-03-19 08:41:43.000000000","message":"recheck tempest-slow-py3","commit_id":"de6a4ab2ffaaa97e3f12975b3cdf5c36e333dbe9"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"21254d1ec85628f2ed3d3a218b93ccb6cb363782","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"69d87999_d28fce87","updated":"2024-03-26 06:49:03.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"de6a4ab2ffaaa97e3f12975b3cdf5c36e333dbe9"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"9668640797b72701ead8e1db94f0362c40c791f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f4ecffd5_ee3f1329","updated":"2024-03-25 08:32:50.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"de6a4ab2ffaaa97e3f12975b3cdf5c36e333dbe9"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"7458afd5ae65a7d54749532e082468a52326f129","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7470b2a8_727bd061","updated":"2024-06-13 06:08:44.000000000","message":"recheck tempest-slow-py3","commit_id":"670c9c3a5d1e75358ff3733cf9de9afd5572bd36"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"02d4859b24897431d6a507132a2633297b885b10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"72b9bb27_d98ec314","updated":"2024-06-21 07:21:45.000000000","message":"Code changes look good. Zuul has passed.\nHopefully the Fujitsu ETERNUS CI would pass soon.","commit_id":"a9f619388f1f086a4d3167144175b9a20587a502"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"fcaa736174a3fbf6a320416117df37a4cb691852","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2bd5aada_f3155f97","updated":"2024-06-28 09:00:32.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"a9f619388f1f086a4d3167144175b9a20587a502"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"955d5a9cf38a0405d98721197fa470bec412aca7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"423ec126_a01fd617","updated":"2024-06-28 05:36:34.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"a9f619388f1f086a4d3167144175b9a20587a502"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"52c15dc08adcb2c25b0ace9d67a94f1c4cc3380c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0dfaa51b_6e6f7572","updated":"2024-12-16 06:36:54.000000000","message":"recheck tempest-integrated-storage-ubuntu-jammy","commit_id":"76c4c762ed47cb10069038ef721b04b91fe76424"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"eab1020b8a18d67c36928a0024016a4097ceb005","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"02291a2d_164124dc","updated":"2025-02-11 06:58:48.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"76c4c762ed47cb10069038ef721b04b91fe76424"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"325dbc1b4a4b5e173aec18b5f4f331c2fa60f3b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0a03b6bf_a9dec47e","updated":"2025-01-24 05:55:49.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"76c4c762ed47cb10069038ef721b04b91fe76424"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"0da6bf75c09afa0e03d77a1354eb6df283ac43f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0d5d8d5c_260dce5c","updated":"2025-02-12 02:22:49.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"76c4c762ed47cb10069038ef721b04b91fe76424"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"b8b252b802b4b9d8f4dd86f06a2a95fb62da333b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0f6b2626_0b3f7b45","updated":"2025-01-22 10:00:06.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"76c4c762ed47cb10069038ef721b04b91fe76424"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"7d377fcac984ba0c486dc50362f1aefa396cb01e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"28f54aa0_3df93631","updated":"2025-02-07 06:23:54.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"76c4c762ed47cb10069038ef721b04b91fe76424"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"033578dcdfac9ec6c2336e4b9432ffbf67f677fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"31996199_a3134676","updated":"2025-02-08 05:08:35.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"76c4c762ed47cb10069038ef721b04b91fe76424"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"2e4b2a36262a877df3486538c3f2a4a4c9d43b28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"3dab9181_92f1cf82","updated":"2024-12-18 02:20:27.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"76c4c762ed47cb10069038ef721b04b91fe76424"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"6ccd7fe879acac02e09641a3b6ebbb624daf4f57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"4529a7b5_eb4e9157","updated":"2025-02-12 05:51:30.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"76c4c762ed47cb10069038ef721b04b91fe76424"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"901ff0a602c9f82a0a05e6323fef2b0ef31cfc4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"714d0804_92cc31a1","updated":"2024-12-17 01:32:22.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"76c4c762ed47cb10069038ef721b04b91fe76424"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"cf5456a04a42303c05ea2291932b3076c9947d6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"93075cc1_98ac1087","updated":"2025-02-07 01:51:15.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"76c4c762ed47cb10069038ef721b04b91fe76424"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"1863566c30467fa7a02ab4fc2e048bab1f52ea4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"e6008074_d2ecd576","updated":"2026-08-15 10:51:59.000000000","message":"Several nitpicks that can be ignored, but the -1 is because I\u0027m not sure you should change the default driver behavior in this way.  I think if the user has set up that snapshot pool they will want to use it.","commit_id":"fedfbc9f821e81f474b1175ca9c6c3126ab7d7b2"},{"author":{"_account_id":37834,"name":"Masahiko Eba","display_name":"Eba","email":"eba.masahiko@fujitsu.com","username":"m-eba"},"change_message_id":"2ce0eade71966adb67e8bb3551beea5ab7ce980c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"52cc9703_9b11a948","updated":"2025-04-01 01:01:38.000000000","message":"recheck devstack-plugin-nfs-tempest-full","commit_id":"fedfbc9f821e81f474b1175ca9c6c3126ab7d7b2"},{"author":{"_account_id":37834,"name":"Masahiko Eba","display_name":"Eba","email":"eba.masahiko@fujitsu.com","username":"m-eba"},"change_message_id":"f47d6fb021f806c70307c1465aad70661692a08e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"719e5bc0_c4a15fd0","updated":"2025-03-31 07:15:02.000000000","message":"recheck devstack-plugin-nfs-tempest-full","commit_id":"fedfbc9f821e81f474b1175ca9c6c3126ab7d7b2"},{"author":{"_account_id":37834,"name":"Masahiko Eba","display_name":"Eba","email":"eba.masahiko@fujitsu.com","username":"m-eba"},"change_message_id":"7070d3baa63e2c35f35962d4c9d3906976de1bc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"c6431033_2150c2c3","updated":"2025-04-01 04:21:13.000000000","message":"recheck devstack-plugin-nfs-tempest-full","commit_id":"fedfbc9f821e81f474b1175ca9c6c3126ab7d7b2"}],"cinder/tests/unit/volume/drivers/test_fujitsu_dx.py":[{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"1863566c30467fa7a02ab4fc2e048bab1f52ea4e","unresolved":true,"context_lines":[{"line_number":3488,"context_line":"    def test_create_snapshot_with_use_eternus_snappool("},{"line_number":3489,"context_line":"            self, mock_get_eternus_connection,"},{"line_number":3490,"context_line":"            mock_get_format_property):"},{"line_number":3491,"context_line":"        self.configuration.fujitsu_use_eternus_snap_pool \u003d True"},{"line_number":3492,"context_line":"        driver \u003d dx_iscsi.FJDXISCSIDriver(configuration\u003dself.configuration)"},{"line_number":3493,"context_line":"        self.driver \u003d driver"},{"line_number":3494,"context_line":"        self.driver.common.qos_support \u003d True"}],"source_content_type":"text/x-python","patch_set":13,"id":"13ab306c_3d217755","line":3491,"updated":"2026-08-15 10:51:59.000000000","message":"You need to use override_config to avoid MT issues in UT.","commit_id":"fedfbc9f821e81f474b1175ca9c6c3126ab7d7b2"}],"cinder/volume/drivers/fujitsu/eternus_dx/eternus_dx_common.py":[{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"1863566c30467fa7a02ab4fc2e048bab1f52ea4e","unresolved":true,"context_lines":[{"line_number":78,"context_line":"    cfg.BoolOpt(\u0027fujitsu_use_cli_copy\u0027,"},{"line_number":79,"context_line":"                default\u003dFalse,"},{"line_number":80,"context_line":"                help\u003d\u0027If True use CLI command to create snapshot.\u0027),"},{"line_number":81,"context_line":"    cfg.BoolOpt(\u0027fujitsu_use_eternus_snap_pool\u0027,"},{"line_number":82,"context_line":"                default\u003dFalse,"},{"line_number":83,"context_line":"                help\u003d\u0027If True create snapshot on EternusSnapPool \u0027"},{"line_number":84,"context_line":"                     \u0027Else create snapshot on the same pool as source volume\u0027),"}],"source_content_type":"text/x-python","patch_set":13,"id":"a991349c_f3e2b6c8","line":81,"updated":"2026-08-15 10:51:59.000000000","message":"I don\u0027t think you can default this to False.  It will change the behavior for existing users that are using the EternusSnapPool already.\n\nI would think it would be better to have the opposite option: ``fujitsu_do_not_use_eternus_snap_pool``","commit_id":"fedfbc9f821e81f474b1175ca9c6c3126ab7d7b2"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"b419b44692c899eae49dfe86fcbe05bbf8081ddf","unresolved":true,"context_lines":[{"line_number":78,"context_line":"    cfg.BoolOpt(\u0027fujitsu_use_cli_copy\u0027,"},{"line_number":79,"context_line":"                default\u003dFalse,"},{"line_number":80,"context_line":"                help\u003d\u0027If True use CLI command to create snapshot.\u0027),"},{"line_number":81,"context_line":"    cfg.BoolOpt(\u0027fujitsu_use_eternus_snap_pool\u0027,"},{"line_number":82,"context_line":"                default\u003dFalse,"},{"line_number":83,"context_line":"                help\u003d\u0027If True create snapshot on EternusSnapPool \u0027"},{"line_number":84,"context_line":"                     \u0027Else create snapshot on the same pool as source volume\u0027),"}],"source_content_type":"text/x-python","patch_set":13,"id":"a9ab6088_5d62598d","line":81,"in_reply_to":"a991349c_f3e2b6c8","updated":"2026-08-16 09:26:44.000000000","message":"Agreed..Existing XML EternusSnapPool is an implicit contract. Default False is a silent upgrade break: dedicated snap RAID groups stop being used, production pools take SDVs, and the RG 128 limit is shared with volumes.\n\nKeep current behavior as the default:\n- fujitsu_use_eternus_snap_pool\u003dTrue, or\n- an opt-in such as fujitsu_snapshot_use_volume_pool default False.","commit_id":"fedfbc9f821e81f474b1175ca9c6c3126ab7d7b2"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"b419b44692c899eae49dfe86fcbe05bbf8081ddf","unresolved":true,"context_lines":[{"line_number":1013,"context_line":"                       % {\u0027volume\u0027: volume,"},{"line_number":1014,"context_line":"                          \u0027volumename\u0027: volumename})"},{"line_number":1015,"context_line":"                LOG.error(msg)"},{"line_number":1016,"context_line":"                raise exception.VolumeBackendAPIException(msg)"},{"line_number":1017,"context_line":""},{"line_number":1018,"context_line":"        poollen \u003d len(pool_name_list)"},{"line_number":1019,"context_line":"        for i in range(poollen):"}],"source_content_type":"text/x-python","patch_set":13,"id":"27fff751_fa8e8898","line":1016,"updated":"2026-08-16 09:26:44.000000000","message":"Please use data\u003dmsg like the rest of this file:\n\n    raise exception.VolumeBackendAPIException(data\u003dmsg)\n\nVolumeBackendAPIException formats %(data)s. A positional message skips that template (_should_format() is false) and is inconsistent with every other raise in this module. Also look at https://docs.openstack.org/oslo.i18n/2025.2/user/guidelines.html","commit_id":"fedfbc9f821e81f474b1175ca9c6c3126ab7d7b2"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"1863566c30467fa7a02ab4fc2e048bab1f52ea4e","unresolved":true,"context_lines":[{"line_number":3179,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":3180,"context_line":""},{"line_number":3181,"context_line":"        # Get poolname from driver configuration file."},{"line_number":3182,"context_line":"        if manage_type \u003d\u003d \u0027volume\u0027:"},{"line_number":3183,"context_line":"            cfgpool_list \u003d list(self._get_drvcfg(\u0027EternusPool\u0027,"},{"line_number":3184,"context_line":"                                                 filename\u003dfilename,"},{"line_number":3185,"context_line":"                                                 multiple\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":13,"id":"9ed9875c_3e846111","line":3182,"updated":"2026-08-15 10:51:59.000000000","message":"I wonder if you should also just check ``manage_type \u003d\u003d \u0027snapshot\u0027 and not self.use_eternus_snap_pool`` here instead of duplicating the ``_get_drvcfg`` call, but this is really just a nitpick. No need to change it if you don\u0027t like that.","commit_id":"fedfbc9f821e81f474b1175ca9c6c3126ab7d7b2"}],"doc/source/configuration/block-storage/drivers/fujitsu-eternus-dx-driver.rst":[{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"1863566c30467fa7a02ab4fc2e048bab1f52ea4e","unresolved":true,"context_lines":[{"line_number":367,"context_line":""},{"line_number":368,"context_line":"  When creating snapshots, Cinder Scheduler selects a pool where the source"},{"line_number":369,"context_line":"  volumes are created by default. However, ETERNUS Openstack Volume Driver"},{"line_number":370,"context_line":"  creates snapshots in the pool that is specified by EternusSnapPool as before."},{"line_number":371,"context_line":"  To match the snap pool with one selected by Cinder Scheduler, add this"},{"line_number":372,"context_line":"  parameter to allow specification of a pool where snapshots are created."},{"line_number":373,"context_line":"  The default value is ``False``."}],"source_content_type":"text/x-rst","patch_set":13,"id":"0c701ef3_c85a51c9","line":370,"updated":"2026-08-15 10:51:59.000000000","message":"nitpick: remove \"as before\".","commit_id":"fedfbc9f821e81f474b1175ca9c6c3126ab7d7b2"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"1863566c30467fa7a02ab4fc2e048bab1f52ea4e","unresolved":true,"context_lines":[{"line_number":368,"context_line":"  When creating snapshots, Cinder Scheduler selects a pool where the source"},{"line_number":369,"context_line":"  volumes are created by default. However, ETERNUS Openstack Volume Driver"},{"line_number":370,"context_line":"  creates snapshots in the pool that is specified by EternusSnapPool as before."},{"line_number":371,"context_line":"  To match the snap pool with one selected by Cinder Scheduler, add this"},{"line_number":372,"context_line":"  parameter to allow specification of a pool where snapshots are created."},{"line_number":373,"context_line":"  The default value is ``False``."},{"line_number":374,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"64106ad3_5bd34ead","line":371,"updated":"2026-08-15 10:51:59.000000000","message":"Isn\u0027t this saying the opposite?  i.e. you need to add the parameter in order to NOT match the pool.","commit_id":"fedfbc9f821e81f474b1175ca9c6c3126ab7d7b2"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"1863566c30467fa7a02ab4fc2e048bab1f52ea4e","unresolved":true,"context_lines":[{"line_number":377,"context_line":""},{"line_number":378,"context_line":"  If ``True`` is specified and snapshots are created, even if the pool that is"},{"line_number":379,"context_line":"  specified by ``EternusSnapPool`` has a capacity margin, snapshot creation"},{"line_number":380,"context_line":"  will fail because Cinder Scheduler may judge that the capacity of the pool"},{"line_number":381,"context_line":"  where the source volumes are created is insufficient."},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"  If unspecified or if ``False`` is specified for"}],"source_content_type":"text/x-rst","patch_set":13,"id":"b4b52b90_f6d76684","line":380,"updated":"2026-08-15 10:51:59.000000000","message":"may fail?","commit_id":"fedfbc9f821e81f474b1175ca9c6c3126ab7d7b2"}],"releasenotes/notes/fujitsu-improve-snappool-selection-4da8255377b1a3d7.yaml":[{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"b419b44692c899eae49dfe86fcbe05bbf8081ddf","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fujitsu ETERNUS DX Driver: Improve the selection of pools for creating"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"daae483b_1e35ab24","line":1,"updated":"2026-08-16 09:26:44.000000000","message":"This is an upgrade behavior change, not only a feature. Please use upgrade: (and issues: if you keep a default flip).","commit_id":"fedfbc9f821e81f474b1175ca9c6c3126ab7d7b2"}]}