)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"b2c57eb96174118f52374d9f5d018a6a48c6472c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"249a2df7_151ebd6d","updated":"2024-03-27 05:24:36.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"8f025b8bfaa10a13f6df0df4d79e5490abd204ff"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"84496a20efe4c3c5aad597290aaa1da0a173fe24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5eb09be2_058bf9c4","updated":"2024-03-28 01:14:44.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"8f025b8bfaa10a13f6df0df4d79e5490abd204ff"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"605c603f9a3792c590d105f075b983796826cfd3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"83dd1171_06ac87de","updated":"2024-03-27 01:22:04.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"8f025b8bfaa10a13f6df0df4d79e5490abd204ff"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"0413c28ccba1c07531c5845221b37e6f61ff390a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8b4647b0_a1b1749a","updated":"2024-03-27 07:56:42.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"8f025b8bfaa10a13f6df0df4d79e5490abd204ff"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"9fee00c5b768f38ad23f43689e2ba44d785fb8fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fec3df41_c489be78","updated":"2024-05-17 01:01:03.000000000","message":"recheck openstack-tox-py39","commit_id":"61108da258f6856989e4ff8ef771030b4b9a71ff"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"be52456025c84fdf13f1e6c7994e4534dddd6b08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"64909c23_40f8f006","updated":"2024-05-17 03:34:25.000000000","message":"tempest-integrated-storage cinder-sqlalchemy-2x","commit_id":"61108da258f6856989e4ff8ef771030b4b9a71ff"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"2bd8ecadf9c095df3a429080a7bbd7443a3e7a8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"09e91410_47683607","updated":"2024-05-22 08:07:47.000000000","message":"recheck tempest-integrated-storage openstacksdk-functional-devstack","commit_id":"7a76cf77a8e6706ede84940e4e3056d1a48477be"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"c87a82b30290bb54ff8be18c9e43c692ea1f8275","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a66ee61b_f04e9071","updated":"2024-05-22 05:49:18.000000000","message":"recheck tempest-slow-py3","commit_id":"7a76cf77a8e6706ede84940e4e3056d1a48477be"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"1b96db9267e5fd3268822365bacb2c3df9e4a70d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"bd90a624_869e4bd8","updated":"2024-06-13 06:09:37.000000000","message":"recheck openstack-tox-py311","commit_id":"13169081428fc9ce9d6e87187130549b7407e35a"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"e776edd67c536fd33327b84ce91dcfd257ff5313","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2cb4e8fc_be9c6802","updated":"2024-07-02 06:06:59.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"3bc08c4fd00f97996711b90d1adf5ed66563b9eb"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"413da3a44c21334b93e12ec3ee66db878e056786","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3ec72df5_5d19a978","updated":"2024-07-03 08:56:09.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"3bc08c4fd00f97996711b90d1adf5ed66563b9eb"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"36f911c214afc88ff4785e072c9746156d5136e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5c3ee290_fa5e6d6a","updated":"2024-07-02 01:31:58.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"3bc08c4fd00f97996711b90d1adf5ed66563b9eb"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"0f9418c1cc58c0bce46ce865e194f0359a3b4436","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"685a55f0_0c8e5390","updated":"2024-07-01 09:43:00.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"3bc08c4fd00f97996711b90d1adf5ed66563b9eb"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"c6606ce38c6c4680b361e864c726aa40c6a355cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7c1b59b6_922671cc","updated":"2024-07-02 07:27:52.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"3bc08c4fd00f97996711b90d1adf5ed66563b9eb"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"d97d8f12fff2edc8cd23a17d4d062d1549834e4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8d521cc6_0c906e9b","updated":"2024-07-03 04:01:44.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"3bc08c4fd00f97996711b90d1adf5ed66563b9eb"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"8338827d0e3b9e250857c91845dc3dfd94e37646","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"958044e9_9a6a910b","updated":"2024-07-01 06:54:29.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"3bc08c4fd00f97996711b90d1adf5ed66563b9eb"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"6cf55ab8b712cd5da772d774a581669aa8a3716f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d6dd0c6c_5e5927f0","updated":"2024-07-03 01:39:56.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"3bc08c4fd00f97996711b90d1adf5ed66563b9eb"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"aa8014b4fe807d570ffcee05de74054892c17f46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"decc9fe1_233beb40","updated":"2024-07-01 02:38:13.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"3bc08c4fd00f97996711b90d1adf5ed66563b9eb"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"2e861ca575c85cf9bc0cbd7b6f868a70b4be4c43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"702e8e90_6272609c","updated":"2024-08-03 07:15:57.000000000","message":"recheck openstack-tox-py39","commit_id":"bcda8ed698b166a40d54b5a2f93854d5d8a51dc3"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"a7b491b02562566e38da0fdc09b646fdca6a1b32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"561b36da_31c01bca","updated":"2024-08-05 01:40:28.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"bcda8ed698b166a40d54b5a2f93854d5d8a51dc3"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"6b5b7e2c622be09f2ffdf31ccdc6eb0e1010e448","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c843abe5_0d290f28","updated":"2024-08-05 06:12:50.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"bcda8ed698b166a40d54b5a2f93854d5d8a51dc3"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"e2330c860f23c0b404676ff628c0a0874fee1cee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ccc05e21_b8cef21f","updated":"2024-09-06 09:13:23.000000000","message":"recheck openstack-tox-py39","commit_id":"831930f72ae572c66241bd26b832dc50d04f44ae"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"00c3e513810b5855dd256617937baa3e22943e1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"5cebcdef_1a0ac6d7","updated":"2025-02-14 13:42:58.000000000","message":"Comment inline about the do_setup() check that addresses a comment on change I204f3889e3401b142dd7c9a6e11585639585abfc (that\u0027s all I\u0027ve reviewed on this patch so far).","commit_id":"d111c074c368b643732e925c2828b403af6e718c"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"62e470f39b1dc1a3dbc8d6775df6d48d65a72992","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"994d572e_cdd6f178","updated":"2024-12-17 01:32:39.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"d111c074c368b643732e925c2828b403af6e718c"},{"author":{"_account_id":37834,"name":"Masahiko Eba","display_name":"Eba","email":"eba.masahiko@fujitsu.com","username":"m-eba"},"change_message_id":"ad1060f6f28f2da11079c14eaeea5d81f8fe535c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"84a4293a_78d341b7","updated":"2025-04-02 01:11:18.000000000","message":"recheck openstack-tox-py39","commit_id":"8e0ee389993681cdeb81d25a8eb6e4aa50471937"},{"author":{"_account_id":37834,"name":"Masahiko Eba","display_name":"Eba","email":"eba.masahiko@fujitsu.com","username":"m-eba"},"change_message_id":"f48e095bc0843e565a99b20c4ce1e9654c5f7990","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"a9a43a1d_383fead0","updated":"2025-04-02 06:08:06.000000000","message":"recheck tempest-integrated-storage","commit_id":"8e0ee389993681cdeb81d25a8eb6e4aa50471937"},{"author":{"_account_id":37834,"name":"Masahiko Eba","display_name":"Eba","email":"eba.masahiko@fujitsu.com","username":"m-eba"},"change_message_id":"ce5bd91678dda09cd172cb1da6e6f322f8544d6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"859b62c8_70d4f7cc","updated":"2025-04-02 08:48:52.000000000","message":"recheck tempest-slow-py3","commit_id":"8e0ee389993681cdeb81d25a8eb6e4aa50471937"}],"cinder/volume/drivers/fujitsu/eternus_dx/eternus_dx_common.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"683eea465b1e00a74bb4b2cb6357f7daac089a82","unresolved":true,"context_lines":[{"line_number":163,"context_line":"            self.configuration.fujitsu_use_eternus_snap_pool"},{"line_number":164,"context_line":"        self.fjdxcli \u003d {}"},{"line_number":165,"context_line":"        self.use_ipv6 \u003d False"},{"line_number":166,"context_line":"        self.model_name \u003d self._get_eternus_model()"},{"line_number":167,"context_line":"        self._check_user()"},{"line_number":168,"context_line":"        local_model_info \u003d self._get_model_supplement_info()"},{"line_number":169,"context_line":"        self.local_ce_support \u003d False"},{"line_number":170,"context_line":"        if (local_model_info.get(\u0027machine_info\u0027) \u003d\u003d CONSTANTS.DOLPHIN and"},{"line_number":171,"context_line":"                local_model_info.get(\u0027model_info\u0027) in CONSTANTS.BELUGA):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9d3bb418_e2ca3e54","line":168,"range":{"start_line":166,"start_character":0,"end_line":168,"end_character":60},"updated":"2024-08-01 21:02:18.000000000","message":"Calls that contact the storage backend should be in do_setup() or check_for_setup_error() rather than in the driver\u0027s __init__() method.  (FJDXISCSIDriver calls this __init__ from its __init__.)","commit_id":"3bc08c4fd00f97996711b90d1adf5ed66563b9eb"},{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"10894d3a448ee0ff8e03f43c8a33e5d1808fd7b1","unresolved":false,"context_lines":[{"line_number":163,"context_line":"            self.configuration.fujitsu_use_eternus_snap_pool"},{"line_number":164,"context_line":"        self.fjdxcli \u003d {}"},{"line_number":165,"context_line":"        self.use_ipv6 \u003d False"},{"line_number":166,"context_line":"        self.model_name \u003d self._get_eternus_model()"},{"line_number":167,"context_line":"        self._check_user()"},{"line_number":168,"context_line":"        local_model_info \u003d self._get_model_supplement_info()"},{"line_number":169,"context_line":"        self.local_ce_support \u003d False"},{"line_number":170,"context_line":"        if (local_model_info.get(\u0027machine_info\u0027) \u003d\u003d CONSTANTS.DOLPHIN and"},{"line_number":171,"context_line":"                local_model_info.get(\u0027model_info\u0027) in CONSTANTS.BELUGA):"}],"source_content_type":"text/x-python","patch_set":8,"id":"6b4c97a2_50d0327c","line":168,"range":{"start_line":166,"start_character":0,"end_line":168,"end_character":60},"in_reply_to":"9d3bb418_e2ca3e54","updated":"2024-08-02 09:48:59.000000000","message":"Done","commit_id":"3bc08c4fd00f97996711b90d1adf5ed66563b9eb"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"00c3e513810b5855dd256617937baa3e22943e1f","unresolved":true,"context_lines":[{"line_number":171,"context_line":"        self.need_port_num \u003d self.configuration.fujitsu_target_port_use_number"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def do_setup(self):"},{"line_number":174,"context_line":"        if self.passwordless and not os.path.exists(self.private_key_path):"},{"line_number":175,"context_line":"            msg \u003d (_(\u0027file of private key %(path)s does not exist.\u0027)"},{"line_number":176,"context_line":"                   % {\u0027path\u0027: self.private_key_path})"},{"line_number":177,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":13,"id":"e2d5d8af_18466d0c","line":174,"range":{"start_line":174,"start_character":37,"end_line":174,"end_character":51},"updated":"2025-02-14 13:42:58.000000000","message":"It would be better to use os.access(path, os.R_OK) here to make sure cinder can actually read the file; a deployer is going to want to restrict access to this file, and they might have made it unreadable to whatever user is running the c-vol service.  (If you change this, don\u0027t forget to update the error message at line 175.)","commit_id":"d111c074c368b643732e925c2828b403af6e718c"},{"author":{"_account_id":38554,"name":"Lucas Lafontaine","display_name":"Lucas","email":"l.lafontaine@jp.fujitsu.com","username":"ftilucas"},"change_message_id":"145c82d9521b436b8db1ba37b2e4e6f76a62c81c","unresolved":true,"context_lines":[{"line_number":171,"context_line":"        self.need_port_num \u003d self.configuration.fujitsu_target_port_use_number"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def do_setup(self):"},{"line_number":174,"context_line":"        if self.passwordless and not os.path.exists(self.private_key_path):"},{"line_number":175,"context_line":"            msg \u003d (_(\u0027file of private key %(path)s does not exist.\u0027)"},{"line_number":176,"context_line":"                   % {\u0027path\u0027: self.private_key_path})"},{"line_number":177,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":13,"id":"93ff1462_eec4d763","line":174,"range":{"start_line":174,"start_character":37,"end_line":174,"end_character":51},"in_reply_to":"1c7ac73a_bcf7f927","updated":"2026-02-03 05:41:52.000000000","message":"My apologies, I marked this as \u0027Resolved\u0027 by mistake.","commit_id":"d111c074c368b643732e925c2828b403af6e718c"},{"author":{"_account_id":38554,"name":"Lucas Lafontaine","display_name":"Lucas","email":"l.lafontaine@jp.fujitsu.com","username":"ftilucas"},"change_message_id":"79682f24ef52980963f90d446b7ac32e1dc8c164","unresolved":true,"context_lines":[{"line_number":171,"context_line":"        self.need_port_num \u003d self.configuration.fujitsu_target_port_use_number"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def do_setup(self):"},{"line_number":174,"context_line":"        if self.passwordless and not os.path.exists(self.private_key_path):"},{"line_number":175,"context_line":"            msg \u003d (_(\u0027file of private key %(path)s does not exist.\u0027)"},{"line_number":176,"context_line":"                   % {\u0027path\u0027: self.private_key_path})"},{"line_number":177,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":13,"id":"f8144211_0ef4ae46","line":174,"range":{"start_line":174,"start_character":37,"end_line":174,"end_character":51},"in_reply_to":"93ff1462_eec4d763","updated":"2026-02-03 05:43:10.000000000","message":"My intention was for the reviewer to confirm the fix.","commit_id":"d111c074c368b643732e925c2828b403af6e718c"},{"author":{"_account_id":38554,"name":"Lucas Lafontaine","display_name":"Lucas","email":"l.lafontaine@jp.fujitsu.com","username":"ftilucas"},"change_message_id":"4fd0d80f63466f402159931091d4b5d7e85c68e4","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        self.need_port_num \u003d self.configuration.fujitsu_target_port_use_number"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def do_setup(self):"},{"line_number":174,"context_line":"        if self.passwordless and not os.path.exists(self.private_key_path):"},{"line_number":175,"context_line":"            msg \u003d (_(\u0027file of private key %(path)s does not exist.\u0027)"},{"line_number":176,"context_line":"                   % {\u0027path\u0027: self.private_key_path})"},{"line_number":177,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":13,"id":"1c7ac73a_bcf7f927","line":174,"range":{"start_line":174,"start_character":37,"end_line":174,"end_character":51},"in_reply_to":"e2d5d8af_18466d0c","updated":"2026-02-03 05:34:31.000000000","message":"Done","commit_id":"d111c074c368b643732e925c2828b403af6e718c"}]}