)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f7a21a9fea2156363517693f8552ee03c12896ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d1a7513e_af84b127","updated":"2024-03-13 02:55:44.000000000","message":"Small nit about the option help string, otherwise code \u0026 tests LGTM.","commit_id":"0bf0c07479610b30685dedbcffe9ce8fe0a0e0c6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"0e9bb6958a0e81d57b15fb86211391dd4469e530","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"575c4e04_dea5174c","updated":"2024-03-26 05:31:58.000000000","message":"core team please do a review.","commit_id":"0bf0c07479610b30685dedbcffe9ce8fe0a0e0c6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"ca516422fd63939455400d75227c5aa57a27895a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6c189721_a097b82b","updated":"2024-03-20 04:47:28.000000000","message":"core team please do a review.","commit_id":"0bf0c07479610b30685dedbcffe9ce8fe0a0e0c6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"d7bf6602c0b00b720edc2b3198a25e24a96797c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"66991331_f8aa850e","updated":"2024-03-18 10:04:11.000000000","message":"core team please do review.","commit_id":"0bf0c07479610b30685dedbcffe9ce8fe0a0e0c6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"51940e6dd401d894639f9dcf4d297f253011bcc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8a12b8d1_3c882c23","updated":"2024-03-07 05:51:57.000000000","message":"please do a code review.","commit_id":"0bf0c07479610b30685dedbcffe9ce8fe0a0e0c6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"b4752c96a4cf7983fbc485dd989aff41e747fe77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0b67e9b2_bd45dba1","updated":"2024-03-11 08:54:59.000000000","message":"run-DellEMC PowerStore CI","commit_id":"0bf0c07479610b30685dedbcffe9ce8fe0a0e0c6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"ad09fd183b5dc4871fb6f96a2eb8667868bd7d59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8d53e885_e2d3c66e","updated":"2024-03-08 08:10:38.000000000","message":"run-DellEMC PowerStore CI","commit_id":"0bf0c07479610b30685dedbcffe9ce8fe0a0e0c6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"a48a2c26bac98ee359b3398bb54a21185aa2a587","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1fbee637_04db0dec","updated":"2024-07-08 06:51:39.000000000","message":"Please do a code review.","commit_id":"9d1b49530301ff042d476c116c44f509ec068dcf"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"be833b251b58021f5fc84d669b3e23babd548400","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5651a162_2d9106ab","updated":"2024-08-01 17:43:37.000000000","message":"Hello,\nzaitcev@kotori.zaitcev.us, rosmaita.fossdev@gmail.com,geguileo@redhat.com,rajatdhasmana@gmail.com.\nplease review this patch.","commit_id":"0bda86dc55bebe99ea702e689407d4782a07afeb"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"bb15eaa079f3f7b94f4c7e188a92300d985274e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e39136dc_ca761003","updated":"2024-08-27 10:05:41.000000000","message":"Hi @sean.mcginnis@gmail.com,\n\nThank you for the review. I understand that third-party CI tests should pass before the review request. I wanted to inform you that there is a bug raised for the NFS CI test case failure, and the community is already aware of it.\n\nBug: https://bugs.launchpad.net/cinder/+bug/2073503","commit_id":"0bda86dc55bebe99ea702e689407d4782a07afeb"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"42e06809fa362d4cdc27e704443844a9b8444b2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"704b20ca_1618fa2a","updated":"2024-08-02 04:39:36.000000000","message":"LGTM. My comments are addressed.","commit_id":"0bda86dc55bebe99ea702e689407d4782a07afeb"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"80a6b8da8c427389a41767e74805c51ad78b02f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"75a69fe6_d985a056","updated":"2024-08-19 04:59:28.000000000","message":"Team,\nPlease review the patch. I’ve been requesting reviews for a while now, so your feedback is much appreciated.","commit_id":"0bda86dc55bebe99ea702e689407d4782a07afeb"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"7724e82ac9917db848816a12dddfb8c5117b423f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b0e3f71e_253d80e4","updated":"2024-07-26 12:20:39.000000000","message":"recheck","commit_id":"0bda86dc55bebe99ea702e689407d4782a07afeb"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3b8e47a82d5505d5b456032f39afa79e8c693df3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7c5147b5_0ce13dd7","in_reply_to":"75a69fe6_d985a056","updated":"2024-08-27 09:52:50.000000000","message":"First make sure the third party CI is passing before requesting reviews. That will make it more likely folks will be willing to take the time to review if it doesn\u0027t look like there is a problem that will need more updates.","commit_id":"0bda86dc55bebe99ea702e689407d4782a07afeb"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"ab82795e92e06457225d2544d9cca04ce80c11d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d9712108_67f1f8c7","updated":"2024-08-27 11:45:35.000000000","message":"Have done a review comment. Please do a code review.","commit_id":"efc6516c827054a055db5a8ef858d579b1c9eeb1"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"b7d264d3e280b75dc1bbc6192f2b2ef480bbd3a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"26ff7aab_4dc22b52","updated":"2024-08-27 12:03:04.000000000","message":"Have updated the patch.","commit_id":"4dcf92787072c502fa54b11a5008fabcef587046"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"2b4737b89fe8ae658987ef8a584864b942e3ac45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"34817e39_d3568479","updated":"2024-08-28 04:31:19.000000000","message":"PowerStore-NFS is failing, and a bug report has been filed: https://bugs.launchpad.net/cinder/+bug/2073503. @rosmaita.fossdev@gmail.com is aware about it.","commit_id":"4dcf92787072c502fa54b11a5008fabcef587046"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"6f109ad618336c0effa7df17debec9305631bb37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"bd00a00a_202826f0","updated":"2024-08-27 14:33:13.000000000","message":"recheck","commit_id":"4dcf92787072c502fa54b11a5008fabcef587046"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e605d38fe5a348c23301cfa99435dc488660a99b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6bc16d66_01ab96fe","updated":"2024-08-29 20:36:24.000000000","message":"run-DellEMC PowerStore CI","commit_id":"4dcf92787072c502fa54b11a5008fabcef587046"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"80725493c22ddf094cdec6100cda9689f14b6f68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6da329fe_111b59d4","updated":"2024-08-29 10:22:54.000000000","message":"run-DellEMC PowerStore CI","commit_id":"4dcf92787072c502fa54b11a5008fabcef587046"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"3acc33b6cf070a47509fb601763d5733791e5eec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"93fea2c0_15638904","updated":"2024-08-30 02:36:24.000000000","message":"run-DellEMC PowerStore CI","commit_id":"4dcf92787072c502fa54b11a5008fabcef587046"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"be86d286e285782bbcd1bc91cdfaf8335a67ed5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ce609f78_042de79e","updated":"2024-08-30 10:09:32.000000000","message":"run-DellEMC PowerStore CI","commit_id":"4dcf92787072c502fa54b11a5008fabcef587046"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"8e15a23be2a3011450ece41985cc15ca5aa3adc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"9d100b62_215e05f3","updated":"2024-09-03 18:26:16.000000000","message":"All the cinder builds are failing due to the below error\n``/home/zuul/src/opendev.org/openstack/cinder/doc/source/configuration/block-storage/drivers/dell-emc-vnx-driver.rst:1083: D001 Line too long\n/home/zuul/src/opendev.org/openstack/cinder/doc/source/configuration/block-storage/drivers/hpe-3par-driver.rst:348: D001 Line too long``.","commit_id":"897980b252b4dad21651e95c24a501fa995c0eba"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b7bf75c6d70f8eed995933b04e5d1ef643c3de8e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"631fb33e_f5ca37a8","updated":"2024-09-03 16:53:46.000000000","message":"Looks good!","commit_id":"897980b252b4dad21651e95c24a501fa995c0eba"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a8a2e0f4b038c9021dc57fc18d957e548df93417","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"8eea2096_6dc269ca","updated":"2024-09-03 16:37:24.000000000","message":"Revisions LGTM.","commit_id":"897980b252b4dad21651e95c24a501fa995c0eba"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"2b275200b0acd5feb353f290413522668b47bede","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"4a2554e8_dc1d76ef","updated":"2024-09-03 18:34:07.000000000","message":"Thank you @rosmaita.fossdev@gmail.com and sean.mcginnis@gmail.com for reviewing the patch.","commit_id":"897980b252b4dad21651e95c24a501fa995c0eba"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"0836c5b15cbd8aeb034be1fc0abb6e56fa647d36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"198fb896_59ac900b","updated":"2024-09-04 13:13:55.000000000","message":"You will need to wait for https://review.opendev.org/c/openstack/cinder/+/927825 to merge before rechecking will be useful.","commit_id":"897980b252b4dad21651e95c24a501fa995c0eba"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e72ac67615e10774c45660f6c7fe05fb5155b9bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"eae44380_1f5dd5ee","updated":"2024-09-04 07:17:25.000000000","message":"recheck","commit_id":"897980b252b4dad21651e95c24a501fa995c0eba"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f9b6d5d271a7be60c684c33e34d0ef20bd9e52ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"76cce7f0_1edc16d6","updated":"2024-09-04 13:44:27.000000000","message":"recheck - Doc8 fix has merged.","commit_id":"897980b252b4dad21651e95c24a501fa995c0eba"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"c53e71f01604eaa04d7ad0118307b404b022c3ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"d070b7a3_1b17f795","updated":"2024-09-04 16:36:02.000000000","message":"recheck - now pep8 is fixed.","commit_id":"897980b252b4dad21651e95c24a501fa995c0eba"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"76b6ed5c997d60a4cd44d8cf36d7ed4b9cc96984","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"18ec06e4_fd297e0c","updated":"2024-09-03 18:23:35.000000000","message":"recheck - openstack-tox-pep8 failed - some rst files errors that are not related to this changes.","commit_id":"897980b252b4dad21651e95c24a501fa995c0eba"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"d1b203902606c028c2f84ded640a99e94c8e211d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"0c88f8e9_a92a9b22","updated":"2024-09-04 19:42:25.000000000","message":"recheck - openstack-tox-py311 failed.","commit_id":"897980b252b4dad21651e95c24a501fa995c0eba"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"0146732cd02d8cce120bbc37b86a43c585f95009","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"82b7ce08_9fa278da","updated":"2024-09-04 13:25:26.000000000","message":"yes @sean.mcginnis@gmail.com. I have checked the same.","commit_id":"897980b252b4dad21651e95c24a501fa995c0eba"}],"cinder/volume/drivers/dell_emc/powerstore/client.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3b8e47a82d5505d5b456032f39afa79e8c693df3","unresolved":true,"context_lines":[{"line_number":21,"context_line":"from oslo_log import log as logging"},{"line_number":22,"context_line":"from oslo_utils import strutils"},{"line_number":23,"context_line":"import requests"},{"line_number":24,"context_line":"from requests.exceptions import Timeout"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from cinder import exception"},{"line_number":27,"context_line":"from cinder.i18n import _"}],"source_content_type":"text/x-python","patch_set":6,"id":"37f4894e_5f2e12cb","line":24,"updated":"2024-08-27 09:52:50.000000000","message":"Coding convention is to only import modules, not specific classes. So change this to `from requests import exceptions`, then below use `exceptions.Timeout`.","commit_id":"0bda86dc55bebe99ea702e689407d4782a07afeb"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"ab82795e92e06457225d2544d9cca04ce80c11d7","unresolved":true,"context_lines":[{"line_number":21,"context_line":"from oslo_log import log as logging"},{"line_number":22,"context_line":"from oslo_utils import strutils"},{"line_number":23,"context_line":"import requests"},{"line_number":24,"context_line":"from requests.exceptions import Timeout"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from cinder import exception"},{"line_number":27,"context_line":"from cinder.i18n import _"}],"source_content_type":"text/x-python","patch_set":6,"id":"9098dcd1_95090f39","line":24,"in_reply_to":"37f4894e_5f2e12cb","updated":"2024-08-27 11:45:35.000000000","message":"I am not getting it. The same thing is also done at line no:21,22.\nWhat is the purpose of importing the whole Module instead of the class?","commit_id":"0bda86dc55bebe99ea702e689407d4782a07afeb"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"b7d264d3e280b75dc1bbc6192f2b2ef480bbd3a8","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from oslo_log import log as logging"},{"line_number":22,"context_line":"from oslo_utils import strutils"},{"line_number":23,"context_line":"import requests"},{"line_number":24,"context_line":"from requests.exceptions import Timeout"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from cinder import exception"},{"line_number":27,"context_line":"from cinder.i18n import _"}],"source_content_type":"text/x-python","patch_set":6,"id":"27512048_73f532c5","line":24,"in_reply_to":"3bb9a217_ad7b0d45","updated":"2024-08-27 12:03:04.000000000","message":"Got it, thanks. I\u0027ve made the changes accordingly and will refer to the same documentation in the future.","commit_id":"0bda86dc55bebe99ea702e689407d4782a07afeb"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c2d65e9ef83741d1e262e0b1f8c5071caf6a7178","unresolved":true,"context_lines":[{"line_number":21,"context_line":"from oslo_log import log as logging"},{"line_number":22,"context_line":"from oslo_utils import strutils"},{"line_number":23,"context_line":"import requests"},{"line_number":24,"context_line":"from requests.exceptions import Timeout"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from cinder import exception"},{"line_number":27,"context_line":"from cinder.i18n import _"}],"source_content_type":"text/x-python","patch_set":6,"id":"3bb9a217_ad7b0d45","line":24,"in_reply_to":"9098dcd1_95090f39","updated":"2024-08-27 11:47:31.000000000","message":"https://docs.openstack.org/hacking/latest/user/hacking.html#imports","commit_id":"0bda86dc55bebe99ea702e689407d4782a07afeb"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3b8e47a82d5505d5b456032f39afa79e8c693df3","unresolved":true,"context_lines":[{"line_number":131,"context_line":"                response \u003d None"},{"line_number":132,"context_line":"        except Timeout as e:"},{"line_number":133,"context_line":"            r.status_code \u003d requests.codes.internal_server_error"},{"line_number":134,"context_line":"            msg \u003d _(\"The request to URL %s failed with timeout \""},{"line_number":135,"context_line":"                    \"exception %s\" % (url, str(e)))"},{"line_number":136,"context_line":"            LOG.error(msg)"},{"line_number":137,"context_line":"        return r, response"}],"source_content_type":"text/x-python","patch_set":6,"id":"7084d561_0a2df877","line":134,"updated":"2024-08-27 09:52:50.000000000","message":"Do not do translation on log messages (remove the _() for the message). Also probably better then just moving the text into the LOG.error() call instead of creating a variable for it.","commit_id":"0bda86dc55bebe99ea702e689407d4782a07afeb"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"ab82795e92e06457225d2544d9cca04ce80c11d7","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                response \u003d None"},{"line_number":132,"context_line":"        except Timeout as e:"},{"line_number":133,"context_line":"            r.status_code \u003d requests.codes.internal_server_error"},{"line_number":134,"context_line":"            msg \u003d _(\"The request to URL %s failed with timeout \""},{"line_number":135,"context_line":"                    \"exception %s\" % (url, str(e)))"},{"line_number":136,"context_line":"            LOG.error(msg)"},{"line_number":137,"context_line":"        return r, response"}],"source_content_type":"text/x-python","patch_set":6,"id":"f70091fb_2666a288","line":134,"in_reply_to":"7084d561_0a2df877","updated":"2024-08-27 11:45:35.000000000","message":"Done","commit_id":"0bda86dc55bebe99ea702e689407d4782a07afeb"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3b8e47a82d5505d5b456032f39afa79e8c693df3","unresolved":true,"context_lines":[{"line_number":132,"context_line":"        except Timeout as e:"},{"line_number":133,"context_line":"            r.status_code \u003d requests.codes.internal_server_error"},{"line_number":134,"context_line":"            msg \u003d _(\"The request to URL %s failed with timeout \""},{"line_number":135,"context_line":"                    \"exception %s\" % (url, str(e)))"},{"line_number":136,"context_line":"            LOG.error(msg)"},{"line_number":137,"context_line":"        return r, response"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1db43398_e3aa6f23","line":135,"updated":"2024-08-27 09:52:50.000000000","message":"Don\u0027t explicitly convert to string with `str()` when you are formatting into a `%s` that will do that anyway.","commit_id":"0bda86dc55bebe99ea702e689407d4782a07afeb"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"ab82795e92e06457225d2544d9cca04ce80c11d7","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        except Timeout as e:"},{"line_number":133,"context_line":"            r.status_code \u003d requests.codes.internal_server_error"},{"line_number":134,"context_line":"            msg \u003d _(\"The request to URL %s failed with timeout \""},{"line_number":135,"context_line":"                    \"exception %s\" % (url, str(e)))"},{"line_number":136,"context_line":"            LOG.error(msg)"},{"line_number":137,"context_line":"        return r, response"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5271519d_65a6c5b6","line":135,"in_reply_to":"1db43398_e3aa6f23","updated":"2024-08-27 11:45:35.000000000","message":"Done","commit_id":"0bda86dc55bebe99ea702e689407d4782a07afeb"}],"cinder/volume/drivers/dell_emc/powerstore/driver.py":[{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"6be2e4ee99cb2b9c501a813dcd38e09ee1c7a766","unresolved":true,"context_lines":[{"line_number":266,"context_line":"        conf[\"rest_password\"] \u003d get_value(\"san_password\")"},{"line_number":267,"context_line":"        conf[\"verify_certificate\"] \u003d get_value(\"driver_ssl_cert_verify\")"},{"line_number":268,"context_line":"        conf[\"certificate_path\"] \u003d get_value(\"driver_ssl_cert_path\")"},{"line_number":269,"context_line":"        conf[\"rest_api_connect_timeout\"] \u003d ("},{"line_number":270,"context_line":"            get_value(utils.POWERSTORE_REST_CONNECT_TIMEOUT))"},{"line_number":271,"context_line":"        conf[\"rest_api_read_timeout\"] \u003d ("},{"line_number":272,"context_line":"            get_value(utils.POWERSTORE_REST_READ_TIMEOUT))"},{"line_number":273,"context_line":"        return conf"}],"source_content_type":"text/x-python","patch_set":1,"id":"4e414acb_e7db5598","line":272,"range":{"start_line":269,"start_character":8,"end_line":272,"end_character":58},"updated":"2024-07-05 09:01:17.000000000","message":"With replication configured, are you planning to get timeout form the \u0027replication_device\u0027 field for the secondary array?","commit_id":"0bf0c07479610b30685dedbcffe9ce8fe0a0e0c6"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"4e9f51013122ca9082587901203560884c5644bb","unresolved":true,"context_lines":[{"line_number":266,"context_line":"        conf[\"rest_password\"] \u003d get_value(\"san_password\")"},{"line_number":267,"context_line":"        conf[\"verify_certificate\"] \u003d get_value(\"driver_ssl_cert_verify\")"},{"line_number":268,"context_line":"        conf[\"certificate_path\"] \u003d get_value(\"driver_ssl_cert_path\")"},{"line_number":269,"context_line":"        conf[\"rest_api_connect_timeout\"] \u003d ("},{"line_number":270,"context_line":"            get_value(utils.POWERSTORE_REST_CONNECT_TIMEOUT))"},{"line_number":271,"context_line":"        conf[\"rest_api_read_timeout\"] \u003d ("},{"line_number":272,"context_line":"            get_value(utils.POWERSTORE_REST_READ_TIMEOUT))"},{"line_number":273,"context_line":"        return conf"}],"source_content_type":"text/x-python","patch_set":1,"id":"d5267c93_4e7cdd66","line":272,"range":{"start_line":269,"start_character":8,"end_line":272,"end_character":58},"in_reply_to":"3f170260_19804ee9","updated":"2024-07-08 07:19:31.000000000","message":"For common settings, you need to use:\n        conf[\"rest_api_connect_timeout\"] \u003d (\n            self.configuration.safe_get(utils.POWERSTORE_REST_CONNECT_TIMEOUT))\n        conf[\"rest_api_read_timeout\"] \u003d (\n            self.configuration.safe_get(utils.POWERSTORE_REST_READ_TIMEOUT))\nOtherwise, it reads from \u0027replication_device\u0027 field for the secondary array.","commit_id":"0bf0c07479610b30685dedbcffe9ce8fe0a0e0c6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"a48a2c26bac98ee359b3398bb54a21185aa2a587","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        conf[\"rest_password\"] \u003d get_value(\"san_password\")"},{"line_number":267,"context_line":"        conf[\"verify_certificate\"] \u003d get_value(\"driver_ssl_cert_verify\")"},{"line_number":268,"context_line":"        conf[\"certificate_path\"] \u003d get_value(\"driver_ssl_cert_path\")"},{"line_number":269,"context_line":"        conf[\"rest_api_connect_timeout\"] \u003d ("},{"line_number":270,"context_line":"            get_value(utils.POWERSTORE_REST_CONNECT_TIMEOUT))"},{"line_number":271,"context_line":"        conf[\"rest_api_read_timeout\"] \u003d ("},{"line_number":272,"context_line":"            get_value(utils.POWERSTORE_REST_READ_TIMEOUT))"},{"line_number":273,"context_line":"        return conf"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f170260_19804ee9","line":272,"range":{"start_line":269,"start_character":8,"end_line":272,"end_character":58},"in_reply_to":"4e414acb_e7db5598","updated":"2024-07-08 06:51:39.000000000","message":"It will be common for primary and secondary arrays.","commit_id":"0bf0c07479610b30685dedbcffe9ce8fe0a0e0c6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e0997788d60a359f77fa94e0763de8d3528ab845","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        conf[\"rest_password\"] \u003d get_value(\"san_password\")"},{"line_number":267,"context_line":"        conf[\"verify_certificate\"] \u003d get_value(\"driver_ssl_cert_verify\")"},{"line_number":268,"context_line":"        conf[\"certificate_path\"] \u003d get_value(\"driver_ssl_cert_path\")"},{"line_number":269,"context_line":"        conf[\"rest_api_connect_timeout\"] \u003d ("},{"line_number":270,"context_line":"            get_value(utils.POWERSTORE_REST_CONNECT_TIMEOUT))"},{"line_number":271,"context_line":"        conf[\"rest_api_read_timeout\"] \u003d ("},{"line_number":272,"context_line":"            get_value(utils.POWERSTORE_REST_READ_TIMEOUT))"},{"line_number":273,"context_line":"        return conf"}],"source_content_type":"text/x-python","patch_set":1,"id":"4f5e11fe_f643d712","line":272,"range":{"start_line":269,"start_character":8,"end_line":272,"end_character":58},"in_reply_to":"d5267c93_4e7cdd66","updated":"2024-07-08 08:40:16.000000000","message":"Yes got it thanks.","commit_id":"0bf0c07479610b30685dedbcffe9ce8fe0a0e0c6"}],"cinder/volume/drivers/dell_emc/powerstore/options.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f7a21a9fea2156363517693f8552ee03c12896ae","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    cfg.IntOpt(store_utils.POWERSTORE_REST_CONNECT_TIMEOUT,"},{"line_number":46,"context_line":"               default\u003d30, min\u003d1,"},{"line_number":47,"context_line":"               help\u003d\u0027Use this value to specify connect \u0027"},{"line_number":48,"context_line":"                    \u0027timeout value (in seconds) for rest call.\u0027),"},{"line_number":49,"context_line":"    cfg.IntOpt(store_utils.POWERSTORE_REST_READ_TIMEOUT,"},{"line_number":50,"context_line":"               default\u003d30, min\u003d1,"},{"line_number":51,"context_line":"               help\u003d\u0027Use this value to specify read \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"97a131be_afc9c4ce","line":48,"range":{"start_line":48,"start_character":52,"end_line":48,"end_character":57},"updated":"2024-03-13 02:55:44.000000000","message":"nit: would be more clear if you said something like \"REST API call to the PowerStore backend\" (same at line 52)","commit_id":"0bf0c07479610b30685dedbcffe9ce8fe0a0e0c6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"a48a2c26bac98ee359b3398bb54a21185aa2a587","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    cfg.IntOpt(store_utils.POWERSTORE_REST_CONNECT_TIMEOUT,"},{"line_number":46,"context_line":"               default\u003d30, min\u003d1,"},{"line_number":47,"context_line":"               help\u003d\u0027Use this value to specify connect \u0027"},{"line_number":48,"context_line":"                    \u0027timeout value (in seconds) for rest call.\u0027),"},{"line_number":49,"context_line":"    cfg.IntOpt(store_utils.POWERSTORE_REST_READ_TIMEOUT,"},{"line_number":50,"context_line":"               default\u003d30, min\u003d1,"},{"line_number":51,"context_line":"               help\u003d\u0027Use this value to specify read \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"b1adbe79_6debad91","line":48,"range":{"start_line":48,"start_character":52,"end_line":48,"end_character":57},"in_reply_to":"97a131be_afc9c4ce","updated":"2024-07-08 06:51:39.000000000","message":"Changed.","commit_id":"0bf0c07479610b30685dedbcffe9ce8fe0a0e0c6"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3b8e47a82d5505d5b456032f39afa79e8c693df3","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    cfg.IntOpt(store_utils.POWERSTORE_REST_CONNECT_TIMEOUT,"},{"line_number":46,"context_line":"               default\u003d30, min\u003d1,"},{"line_number":47,"context_line":"               help\u003d\u0027Use this value to specify connect \u0027"},{"line_number":48,"context_line":"                    \u0027timeout value (in seconds) for REST API call \u0027"},{"line_number":49,"context_line":"                    \u0027to the PowerStore backend.\u0027),"},{"line_number":50,"context_line":"    cfg.IntOpt(store_utils.POWERSTORE_REST_READ_TIMEOUT,"},{"line_number":51,"context_line":"               default\u003d30, min\u003d1,"}],"source_content_type":"text/x-python","patch_set":6,"id":"a21c6eeb_1ca62efa","line":48,"range":{"start_line":48,"start_character":61,"end_line":48,"end_character":65},"updated":"2024-08-27 09:52:50.000000000","message":"s/call/calls/","commit_id":"0bda86dc55bebe99ea702e689407d4782a07afeb"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"ab82795e92e06457225d2544d9cca04ce80c11d7","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    cfg.IntOpt(store_utils.POWERSTORE_REST_CONNECT_TIMEOUT,"},{"line_number":46,"context_line":"               default\u003d30, min\u003d1,"},{"line_number":47,"context_line":"               help\u003d\u0027Use this value to specify connect \u0027"},{"line_number":48,"context_line":"                    \u0027timeout value (in seconds) for REST API call \u0027"},{"line_number":49,"context_line":"                    \u0027to the PowerStore backend.\u0027),"},{"line_number":50,"context_line":"    cfg.IntOpt(store_utils.POWERSTORE_REST_READ_TIMEOUT,"},{"line_number":51,"context_line":"               default\u003d30, min\u003d1,"}],"source_content_type":"text/x-python","patch_set":6,"id":"167d9105_f9a77579","line":48,"range":{"start_line":48,"start_character":61,"end_line":48,"end_character":65},"in_reply_to":"a21c6eeb_1ca62efa","updated":"2024-08-27 11:45:35.000000000","message":"Done","commit_id":"0bda86dc55bebe99ea702e689407d4782a07afeb"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3b8e47a82d5505d5b456032f39afa79e8c693df3","unresolved":true,"context_lines":[{"line_number":50,"context_line":"    cfg.IntOpt(store_utils.POWERSTORE_REST_READ_TIMEOUT,"},{"line_number":51,"context_line":"               default\u003d30, min\u003d1,"},{"line_number":52,"context_line":"               help\u003d\u0027Use this value to specify read \u0027"},{"line_number":53,"context_line":"                    \u0027timeout value (in seconds) for REST API call \u0027"},{"line_number":54,"context_line":"                    \u0027to the PowerStore backend.\u0027)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":6,"id":"dfd78dd6_7e9d162f","line":53,"range":{"start_line":53,"start_character":61,"end_line":53,"end_character":65},"updated":"2024-08-27 09:52:50.000000000","message":"s/call/calls/\n\nAlso, just a nit, it would be more grammatically correct to say \"the read timeout value\".","commit_id":"0bda86dc55bebe99ea702e689407d4782a07afeb"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"ab82795e92e06457225d2544d9cca04ce80c11d7","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    cfg.IntOpt(store_utils.POWERSTORE_REST_READ_TIMEOUT,"},{"line_number":51,"context_line":"               default\u003d30, min\u003d1,"},{"line_number":52,"context_line":"               help\u003d\u0027Use this value to specify read \u0027"},{"line_number":53,"context_line":"                    \u0027timeout value (in seconds) for REST API call \u0027"},{"line_number":54,"context_line":"                    \u0027to the PowerStore backend.\u0027)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":6,"id":"8c507278_4af9039a","line":53,"range":{"start_line":53,"start_character":61,"end_line":53,"end_character":65},"in_reply_to":"dfd78dd6_7e9d162f","updated":"2024-08-27 11:45:35.000000000","message":"Done","commit_id":"0bda86dc55bebe99ea702e689407d4782a07afeb"}],"releasenotes/notes/bug-2055022-dell-powerstore-rest-api-timeout-51b3ae19266757f9.yaml":[{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"060fdd4ce6b24af0d0376ab835ff85e549682e31","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    PowerStore Driver `bug #2055022"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2055022\u003e`_: REST"},{"line_number":6,"context_line":"    API calls to the PowerStore backend did not have a timeout"},{"line_number":7,"context_line":"    set, which could result in cinder waiting forever."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c7676952_c03366db","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":35},"updated":"2024-07-05 09:13:05.000000000","message":"nit: Dell PowerStore Driver","commit_id":"0bf0c07479610b30685dedbcffe9ce8fe0a0e0c6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"a48a2c26bac98ee359b3398bb54a21185aa2a587","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    PowerStore Driver `bug #2055022"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2055022\u003e`_: REST"},{"line_number":6,"context_line":"    API calls to the PowerStore backend did not have a timeout"},{"line_number":7,"context_line":"    set, which could result in cinder waiting forever."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"895d7384_0e14cbaa","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":35},"in_reply_to":"c7676952_c03366db","updated":"2024-07-08 06:51:39.000000000","message":"Changed to Dell PowerStore Driver","commit_id":"0bf0c07479610b30685dedbcffe9ce8fe0a0e0c6"}]}