)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"a530f7a0e9b2138d2a2eb63447df6b207c26713e","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Create encrypted volumes directly to RBD"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This fix slow on create encrypted volumes with temp file import."},{"line_number":10,"context_line":"Encrypted volume create is now directly upload to RBD with qemu-img"},{"line_number":11,"context_line":"command without temprory image file generated."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"30e1c349_779a9874","line":9,"updated":"2026-04-08 17:12:48.000000000","message":"Fix slow creation of encrypted volumes?","commit_id":"10377d240542c9832dcbde8cd0a1d168f9603343"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"415302a9c6f60dfc4dc470a01c0110febf920921","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Create encrypted volumes directly to RBD"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This fix slow on create encrypted volumes with temp file import."},{"line_number":10,"context_line":"Encrypted volume create is now directly upload to RBD with qemu-img"},{"line_number":11,"context_line":"command without temprory image file generated."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"464a4dd9_f667f02f","line":9,"in_reply_to":"30e1c349_779a9874","updated":"2026-04-21 06:58:18.000000000","message":"Done","commit_id":"10377d240542c9832dcbde8cd0a1d168f9603343"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"a530f7a0e9b2138d2a2eb63447df6b207c26713e","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Create encrypted volumes directly to RBD"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This fix slow on create encrypted volumes with temp file import."},{"line_number":10,"context_line":"Encrypted volume create is now directly upload to RBD with qemu-img"},{"line_number":11,"context_line":"command without temprory image file generated."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #2055517"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"95d0af3c_5ef4a186","line":10,"updated":"2026-04-08 17:12:48.000000000","message":"\"temprory\" → \"temporary\" and \"directly upload\" → \"directly uploaded\"","commit_id":"10377d240542c9832dcbde8cd0a1d168f9603343"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"415302a9c6f60dfc4dc470a01c0110febf920921","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Create encrypted volumes directly to RBD"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This fix slow on create encrypted volumes with temp file import."},{"line_number":10,"context_line":"Encrypted volume create is now directly upload to RBD with qemu-img"},{"line_number":11,"context_line":"command without temprory image file generated."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #2055517"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"eaafb6db_9ea5520f","line":10,"in_reply_to":"95d0af3c_5ef4a186","updated":"2026-04-21 06:58:18.000000000","message":"Done","commit_id":"10377d240542c9832dcbde8cd0a1d168f9603343"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"b8d1890c5d8980bce8ebc21a4123640d88225ebe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"79d003af_db11e530","updated":"2024-03-01 08:21:29.000000000","message":"For time improvement reference:\nbefore this patch\ncreating a 100G encrypted volume takes 85 seconds\ncreating a 500G encrypted volume takes 420 seconds\nafter:\ncreating a 100G encrypted volume takes 8 seconds\ncreating a 500G encrypted volume takes 5 seconds\n\nThese test on new build devstack(ceph+cinder) + ubuntu-v22.04.20240110 on virutal instance (32 VCPUS,131072 RAM)","commit_id":"bd9a3db2dd78b482713d69cae9eb7fbb5cf246d7"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"53aee1b97b4b2de7416b5c30a87adb07541c5dea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e6527aca_0a8d1656","updated":"2024-03-04 14:58:47.000000000","message":"recheck","commit_id":"bd9a3db2dd78b482713d69cae9eb7fbb5cf246d7"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"38cb32c5e9567a2c06ff4339abf548a4c539a58b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"737d8825_5be51abd","updated":"2024-10-17 06:31:31.000000000","message":"bump","commit_id":"0fcac334f0ad0cd91a049d5f420261a28c374eab"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"752da5b7d28ad0eb5ced52c10d399252d62aa8e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"08dd6797_4715ff66","updated":"2024-03-06 13:10:43.000000000","message":"recheck","commit_id":"0fcac334f0ad0cd91a049d5f420261a28c374eab"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"6f2a2a8adf78475752f5529dc6b75960b19667a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9dc83e1d_a0df381e","updated":"2024-10-24 05:26:13.000000000","message":"recheck","commit_id":"d1f1a7f235bf493a5e9980aa965474a8ed33a048"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d7f152e986f08d16d6d3b1adb98aa5448a9e7233","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7dd1a567_d1399dbc","updated":"2025-04-09 14:57:05.000000000","message":"Are the volumes identical before and after this change, especially w.r.t. size in bytes of the rbd image and size in bytes available inside the encryption layer?","commit_id":"3de2a4fdd92e2bc3b2129d0ab84a12c72309d965"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"b20b2f309540ea110e074e29154b07783b78d2e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ff51986d_3a425374","updated":"2025-04-07 05:38:53.000000000","message":"bump","commit_id":"3de2a4fdd92e2bc3b2129d0ab84a12c72309d965"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"e9e969411b2bdb4a8864169bf264ce35442b86ff","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c092154a_4e6c4fb1","in_reply_to":"6e9f4ad1_9a099154","updated":"2025-06-03 16:59:31.000000000","message":"As they are same files for either import from rbd or qemu-img, I don\u0027t think there will be different.\nThe encryption layer are both done with same qemu-img command for before and after this change","commit_id":"3de2a4fdd92e2bc3b2129d0ab84a12c72309d965"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"fc47fc0c78df492662f8a54c02ea5680f2faf834","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6e9f4ad1_9a099154","in_reply_to":"7dd1a567_d1399dbc","updated":"2025-04-23 18:21:17.000000000","message":"I didn\u0027t mean to mark this one as resolved, would still like to test/confirm this.","commit_id":"3de2a4fdd92e2bc3b2129d0ab84a12c72309d965"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"39edd6b811de0b2956bd411517729efcaad0ff4f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d48b7706_db29fb7a","in_reply_to":"c092154a_4e6c4fb1","updated":"2025-06-03 17:13:29.000000000","message":"Also the only place I can think of the different here might be metadata, but it\u0027s not affect how ceph or cinder(or glance) works with the volume IMO.\n\nAlso, this encrypted volume creation only involves a brand new volume, so I\u0027m not actually sure what the concerns here.","commit_id":"3de2a4fdd92e2bc3b2129d0ab84a12c72309d965"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"7c1687c00344f0aaaff7da780aa0ae96bb151773","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b0213e26_801d7927","in_reply_to":"d48b7706_db29fb7a","updated":"2026-01-30 00:14:58.000000000","message":"Done","commit_id":"3de2a4fdd92e2bc3b2129d0ab84a12c72309d965"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"573422451e31487557163cc760db0a363c5daf41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1024f584_7d94b6b6","updated":"2025-06-30 07:33:21.000000000","message":"That is a huge improvement in encrypted volumes behavior for RBD and I\u0027d love to see that merged by the project","commit_id":"0b2b4da98429a9b67e6f13209a9237a83dd24070"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"fdd717b50f49decf3697fafc9ebb206347acaff2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"cc0ce00e_40ae18f7","updated":"2025-07-30 08:31:34.000000000","message":"bump","commit_id":"0b2b4da98429a9b67e6f13209a9237a83dd24070"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0d99f36aa77a3183e4d0c249ae8517e229e18788","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d3048cae_4df8f40f","updated":"2026-04-08 17:19:35.000000000","message":"From the question I had on patchset 8: I\u0027d still like to see confirmation that the volumes created are exactly the same as they were before - i.e. same rbd image size, same usable size inside of the luks container (i.e. when attached to a vm), same rbd order parameters etc.","commit_id":"10377d240542c9832dcbde8cd0a1d168f9603343"},{"author":{"_account_id":35467,"name":"Luan Utimura","display_name":"Luan Utimura","email":"luan.utimura@luizalabs.com","username":"lutimura"},"change_message_id":"6b64e080d7837ac9755725b8d9ee9f519cb22cae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"e404db65_174ead39","updated":"2026-04-06 14:29:50.000000000","message":"This is an incredible improvement for creating encrypted volumes. For reference, a 1TB encrypted volume that used to be thick provisioned in 1 hour and 44 seconds now takes 5 seconds to provision.","commit_id":"10377d240542c9832dcbde8cd0a1d168f9603343"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"a27d618913262a8f3b530107e7b1c3113e098f8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"2ff026b5_40312a56","updated":"2026-04-06 15:03:32.000000000","message":"We\u0027ve been running this in production since around the time we proposed it, unfortunately it\u0027s been 2 years and it hasn\u0027t been merged since we contributed it.\n\nWe\u0027d love to see this make it\u0027s way to upstream.","commit_id":"10377d240542c9832dcbde8cd0a1d168f9603343"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"a530f7a0e9b2138d2a2eb63447df6b207c26713e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"dfc05a24_516c8ae3","updated":"2026-04-08 17:12:48.000000000","message":"fix typos in commit message \"temprory\" → \"temporary\"; \"virutal instance\" → \"virtual instance\"","commit_id":"10377d240542c9832dcbde8cd0a1d168f9603343"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f8a6dcb570c474e2d31a8c74d3462b35a6bad550","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"49dfca80_6b62f3bf","in_reply_to":"410129cc_f7de019b","updated":"2026-04-21 13:07:29.000000000","message":"Thanks for looking into this!","commit_id":"10377d240542c9832dcbde8cd0a1d168f9603343"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"415302a9c6f60dfc4dc470a01c0110febf920921","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"410129cc_f7de019b","in_reply_to":"d3048cae_4df8f40f","updated":"2026-04-21 06:58:18.000000000","message":"here\u0027s my test result,\nresult: size is identical, but speed up hugely.\n```\n\nBoth volumes: 1 GiB, created from the same cirros-0.6.3-x86_64-disk image, same luks-ceph volume type (LUKS/aes-xts-256, ceph\nbackend).\n\n┌───────────────────────┬────────────────────────────────────────┬────────────────────────────────────────────────────────────┐\n│ Metric                │ Before patches                         │ After patches                                              │\n├───────────────────────┼────────────────────────────────────────┼────────────────────────────────────────────────────────────┤\n│ Volume ID             │ ffeee87d-4bf2-426e-a25f-8480b50a6c48   │ f9474146-fced-420c-9c1a-6c1db02981f4                       │\n├───────────────────────┼────────────────────────────────────────┼────────────────────────────────────────────────────────────┤\n│ rbd info size         │ 1 GiB / 256 objects (4 MiB)            │ 1 GiB / 256 objects (4 MiB)                                │\n├───────────────────────┼────────────────────────────────────────┼────────────────────────────────────────────────────────────┤\n│ rbd du USED           │ 116 MiB                                │ 116 MiB                                                    │\n├───────────────────────┼────────────────────────────────────────┼────────────────────────────────────────────────────────────┤\n│ Wall-clock create     │ ~28 s                                  │ ~22 s                                                      │\n│ time (c-vol flow)     │                                        │                                                            │\n├───────────────────────┼────────────────────────────────────────┼────────────────────────────────────────────────────────────┤\n│ Code path             │ qemu-img convert -O luks … → temp file │ qemu-img create -f luks rbd:volumes/\u003cvol\u003e (direct LUKS     │\n│                       │ → rbd import                           │ header in RBD) + subsequent conversion                     │\n└───────────────────────┴────────────────────────────────────────┴────────────────────────────────────────────────────────────┘\nwhich is byte-for-byte identical in this test\n┌───────────────────────────┬─────────────────────────┬─────────────────────────┐\n│ Metric                    │ Before                  │ After                   │\n├───────────────────────────┼─────────────────────────┼─────────────────────────┤\n│ used_size (rbd du)        │ 121,634,816 B (116 MiB) │ 121,634,816 B (116 MiB) │\n├───────────────────────────┼─────────────────────────┼─────────────────────────┤\n│ RADOS object count        │ 29                      │ 29                      │\n├───────────────────────────┼─────────────────────────┼─────────────────────────┤\n│ Sum of RADOS object bytes │ 119,508,992 B           │ 119,508,992 B           │\n├───────────────────────────┼─────────────────────────┼─────────────────────────┤\n│ Provisioned               │ 1,073,741,824 B         │ 1,073,741,824 B         │\n└───────────────────────────┴─────────────────────────┴─────────────────────────┘\n```","commit_id":"10377d240542c9832dcbde8cd0a1d168f9603343"}],"cinder/volume/drivers/rbd.py":[{"author":{"_account_id":31746,"name":"Oleksandr Kozachenko","email":"okozachenko1203@gmail.com","username":"okozachenko"},"change_message_id":"aa8faa9a8a8bb408fd0e07b3a946a6e588666a2e","unresolved":true,"context_lines":[{"line_number":1106,"context_line":"        \"\"\"Create an encrypted volume."},{"line_number":1107,"context_line":""},{"line_number":1108,"context_line":"        This works by creating an encrypted image locally,"},{"line_number":1109,"context_line":"        and then uploading it to the volume."},{"line_number":1110,"context_line":"        \"\"\""},{"line_number":1111,"context_line":"        encryption \u003d volume_utils.check_encryption_provider(volume, context)"},{"line_number":1112,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"8bedb975_b6b1a9dc","line":1109,"updated":"2024-03-01 09:54:25.000000000","message":"This comment can be updated properly","commit_id":"bd9a3db2dd78b482713d69cae9eb7fbb5cf246d7"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"752da5b7d28ad0eb5ced52c10d399252d62aa8e6","unresolved":false,"context_lines":[{"line_number":1106,"context_line":"        \"\"\"Create an encrypted volume."},{"line_number":1107,"context_line":""},{"line_number":1108,"context_line":"        This works by creating an encrypted image locally,"},{"line_number":1109,"context_line":"        and then uploading it to the volume."},{"line_number":1110,"context_line":"        \"\"\""},{"line_number":1111,"context_line":"        encryption \u003d volume_utils.check_encryption_provider(volume, context)"},{"line_number":1112,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"08bd2ac7_e6c6da91","line":1109,"in_reply_to":"8bedb975_b6b1a9dc","updated":"2024-03-06 13:10:43.000000000","message":"Done","commit_id":"bd9a3db2dd78b482713d69cae9eb7fbb5cf246d7"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d7f152e986f08d16d6d3b1adb98aa5448a9e7233","unresolved":true,"context_lines":[{"line_number":1143,"context_line":""},{"line_number":1144,"context_line":"            cmd \u003d [\u0027rbd\u0027, \u0027import\u0027,"},{"line_number":1145,"context_line":"                   \u0027--dest-pool\u0027, self.configuration.rbd_pool,"},{"line_number":1146,"context_line":"                   \u0027--order\u0027, order,"},{"line_number":1147,"context_line":"                   tmp_image.name, volume.name]"},{"line_number":1148,"context_line":"            cmd.extend(self._ceph_args())"},{"line_number":1149,"context_line":"            self._execute(*cmd)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fce1db8_1cf9b850","side":"PARENT","line":1146,"updated":"2025-04-09 14:57:05.000000000","message":"What does it mean that the order parameter is no longer supplied?","commit_id":"b0662ce5cad6abfb7f9f3426686eeebcbdfc1ea4"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"e9e969411b2bdb4a8864169bf264ce35442b86ff","unresolved":false,"context_lines":[{"line_number":1143,"context_line":""},{"line_number":1144,"context_line":"            cmd \u003d [\u0027rbd\u0027, \u0027import\u0027,"},{"line_number":1145,"context_line":"                   \u0027--dest-pool\u0027, self.configuration.rbd_pool,"},{"line_number":1146,"context_line":"                   \u0027--order\u0027, order,"},{"line_number":1147,"context_line":"                   tmp_image.name, volume.name]"},{"line_number":1148,"context_line":"            cmd.extend(self._ceph_args())"},{"line_number":1149,"context_line":"            self._execute(*cmd)"}],"source_content_type":"text/x-python","patch_set":8,"id":"e182c18f_6d160ec1","side":"PARENT","line":1146,"in_reply_to":"9fce1db8_1cf9b850","updated":"2025-06-03 16:59:31.000000000","message":"I added back now in https://review.opendev.org/c/openstack/cinder/+/910700/9/cinder/volume/drivers/rbd.py#1142\nwith cluster_size. Also tested from my side too.","commit_id":"b0662ce5cad6abfb7f9f3426686eeebcbdfc1ea4"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"378e100a611df3b4d09a8e0074cf4c61c5beef33","unresolved":true,"context_lines":[{"line_number":1139,"context_line":"            if conf:"},{"line_number":1140,"context_line":"                rbd_options +\u003d \u0027:conf\u003d%(conf)s\u0027 % {\u0027conf\u0027: conf}"},{"line_number":1141,"context_line":"            chunk_size \u003d self.configuration.rbd_store_chunk_size * units.Mi"},{"line_number":1142,"context_line":"            create_cmd \u003d ("},{"line_number":1143,"context_line":"                \u0027qemu-img\u0027, \u0027create\u0027, \u0027-f\u0027, \u0027luks\u0027,"},{"line_number":1144,"context_line":"                \u0027-o\u0027, \u0027cipher-alg\u003d%(cipher_alg)s,\u0027"},{"line_number":1145,"context_line":"                \u0027cipher-mode\u003d%(cipher_mode)s,\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"d8051aa3_e22c8207","line":1142,"updated":"2026-02-03 13:46:14.000000000","message":"I stumbled upon this patch randomly when I was searching for something else. We created basically the same patch downstream, so I will provide an important finding we had on this topic, copied directly from our code:\n\nNote: for ec-enabled ceph clusters you need to provide\nrbd_default_data_pool in client section of ceph.conf\nThis is because qemu-img cannot take 2 pools in parameters,\nbut librbd is clever enough to properly target both\ndata and metadata pools when present in the config","commit_id":"10377d240542c9832dcbde8cd0a1d168f9603343"},{"author":{"_account_id":36805,"name":"Mateusz Klejn","display_name":"Mateusz Klejn","email":"mateusz.klejn@ovhcloud.com","username":"mateusz.klejn","status":"Employee @ OVH"},"change_message_id":"f3af7eaa58f6412156f9b13269f7a523d40e459f","unresolved":true,"context_lines":[{"line_number":1139,"context_line":"            if conf:"},{"line_number":1140,"context_line":"                rbd_options +\u003d \u0027:conf\u003d%(conf)s\u0027 % {\u0027conf\u0027: conf}"},{"line_number":1141,"context_line":"            chunk_size \u003d self.configuration.rbd_store_chunk_size * units.Mi"},{"line_number":1142,"context_line":"            create_cmd \u003d ("},{"line_number":1143,"context_line":"                \u0027qemu-img\u0027, \u0027create\u0027, \u0027-f\u0027, \u0027luks\u0027,"},{"line_number":1144,"context_line":"                \u0027-o\u0027, \u0027cipher-alg\u003d%(cipher_alg)s,\u0027"},{"line_number":1145,"context_line":"                \u0027cipher-mode\u003d%(cipher_mode)s,\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"de42f0a0_25397d09","line":1142,"in_reply_to":"d8051aa3_e22c8207","updated":"2026-02-12 14:50:50.000000000","message":"also: it is required to install qemu-block-extra for this to work properly","commit_id":"10377d240542c9832dcbde8cd0a1d168f9603343"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"415302a9c6f60dfc4dc470a01c0110febf920921","unresolved":true,"context_lines":[{"line_number":1139,"context_line":"            if conf:"},{"line_number":1140,"context_line":"                rbd_options +\u003d \u0027:conf\u003d%(conf)s\u0027 % {\u0027conf\u0027: conf}"},{"line_number":1141,"context_line":"            chunk_size \u003d self.configuration.rbd_store_chunk_size * units.Mi"},{"line_number":1142,"context_line":"            create_cmd \u003d ("},{"line_number":1143,"context_line":"                \u0027qemu-img\u0027, \u0027create\u0027, \u0027-f\u0027, \u0027luks\u0027,"},{"line_number":1144,"context_line":"                \u0027-o\u0027, \u0027cipher-alg\u003d%(cipher_alg)s,\u0027"},{"line_number":1145,"context_line":"                \u0027cipher-mode\u003d%(cipher_mode)s,\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"08be5e79_2eed56e2","line":1142,"in_reply_to":"de42f0a0_25397d09","updated":"2026-04-21 06:58:18.000000000","message":"Done, but I think we can discuss more if this need to be a check or simply words in releasenote is fine","commit_id":"10377d240542c9832dcbde8cd0a1d168f9603343"}],"releasenotes/notes/improve-create-encrypted-volume-c1bb6b44b85c0242.yaml":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"5e2356b825d11dff934b7c7bd8a8b54b4540edf1","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug 255517 https://bugs.launchpad.net/cinder/+bug/2055517`_: Fix slow"},{"line_number":5,"context_line":"    on create encrypted volumes with temp file import. Encrypted volume create"},{"line_number":6,"context_line":"    is now directly upload to rbd with qemu-img command without temprory image"},{"line_number":7,"context_line":"    file generated."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d2d26226_2e5ef5bf","line":4,"range":{"start_line":4,"start_character":9,"end_line":4,"end_character":15},"updated":"2024-03-05 21:17:10.000000000","message":"typo in bug number, caused releasenotes job to fail.","commit_id":"d084fced172920c33777dcaaa40ffa55fd8ab27d"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"752da5b7d28ad0eb5ced52c10d399252d62aa8e6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug 255517 https://bugs.launchpad.net/cinder/+bug/2055517`_: Fix slow"},{"line_number":5,"context_line":"    on create encrypted volumes with temp file import. Encrypted volume create"},{"line_number":6,"context_line":"    is now directly upload to rbd with qemu-img command without temprory image"},{"line_number":7,"context_line":"    file generated."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"15cc23c8_2f202eed","line":4,"range":{"start_line":4,"start_character":9,"end_line":4,"end_character":15},"in_reply_to":"d2d26226_2e5ef5bf","updated":"2024-03-06 13:10:43.000000000","message":"Done","commit_id":"d084fced172920c33777dcaaa40ffa55fd8ab27d"}]}