)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35916,"name":"Pham Le Gia Dai","display_name":"Dai","email":"daipham.3213@gmail.com","username":"daiplg","status":"Full Stack Dev"},"change_message_id":"2a0b1b30e491757434343c9aa64c7d14e5a17dc0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e99033b6_ec3b02aa","updated":"2024-03-07 04:09:47.000000000","message":"please, have a look","commit_id":"311ed7c76fdc9f7d9920eac1b947b7258600424a"},{"author":{"_account_id":35916,"name":"Pham Le Gia Dai","display_name":"Dai","email":"daipham.3213@gmail.com","username":"daiplg","status":"Full Stack Dev"},"change_message_id":"2fed7c1536266650a3ba139869d0196bbb254399","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0ce31af7_52dd26aa","updated":"2024-03-27 01:52:28.000000000","message":"Hello guys! Please help me review this commit","commit_id":"ec2b1e1ce91039fc3b85b6ee78980ebec312e8fe"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c51d2f8c1c498ec386326628589be0d7204c75d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a7318b1d_f0323201","updated":"2024-04-10 09:13:19.000000000","message":"Python 3.8 support may be removed in D release but assuming that this needs backport to stable branches I think merging this fix in master first still makes sense.","commit_id":"ec2b1e1ce91039fc3b85b6ee78980ebec312e8fe"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"4e3537b311871f2904fc7980640926516d9105ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c82efdfc_5dd653e4","updated":"2024-07-28 05:30:50.000000000","message":"I\u0027m inclined to agree.\n\nWhy is this still not merged in July?\n\nIf someone demands the tests, add a -1, don\u0027t just sit on it please.","commit_id":"f9209de081dcb11d8f257008cd046388589fd667"},{"author":{"_account_id":35916,"name":"Pham Le Gia Dai","display_name":"Dai","email":"daipham.3213@gmail.com","username":"daiplg","status":"Full Stack Dev"},"change_message_id":"7552909e1aa8e310e8e4f4b27699669f56c3ad15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a0ea3706_b246404b","updated":"2024-05-22 10:09:09.000000000","message":"recheck","commit_id":"f9209de081dcb11d8f257008cd046388589fd667"}],"releasenotes/notes/bug-2038280-read-large-backup-metadata-file-9952671831ab533b.yaml":[{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"db1803696ee582509882b28f992a507ffb663929","unresolved":true,"context_lines":[{"line_number":5,"context_line":"     reading 2 or more GiB of a backup metadata file at a time. This was"},{"line_number":6,"context_line":"     causing the backup service to fail when reading large backup metadata"},{"line_number":7,"context_line":"     files. The fix is to read the file in smaller chunks whenever content"},{"line_number":8,"context_line":"     size is greater than 2 GiB. This bug only affects on python 3.8 and older"},{"line_number":9,"context_line":"     versions. Root cause: https://github.com/urllib3/urllib3/pull/2657"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8085cf71_dda191fe","line":8,"updated":"2024-04-12 13:02:20.000000000","message":"If this \"only\" affects Python \u003c\u003d 3.8 this patch will have to target being backported since 2024.2 already requires Python 3.9 according to [1].\n\n\n[1] https://review.opendev.org/c/openstack/governance/+/908862","commit_id":"ec2b1e1ce91039fc3b85b6ee78980ebec312e8fe"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"505e336a496bd9de504fa110eb7fcdcbbcfefe13","unresolved":true,"context_lines":[{"line_number":5,"context_line":"     reading 2 or more GiB of a backup metadata file at a time. This was"},{"line_number":6,"context_line":"     causing the backup service to fail when reading large backup metadata"},{"line_number":7,"context_line":"     files. The fix is to read the file in smaller chunks whenever content"},{"line_number":8,"context_line":"     size is greater than 2 GiB. This bug only affects on python 3.8 and older"},{"line_number":9,"context_line":"     versions. Root cause: https://github.com/urllib3/urllib3/pull/2657"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"2d53190b_f8fcb171","line":8,"in_reply_to":"6deca6e5_3d21d171","updated":"2024-05-22 09:49:24.000000000","message":"Yepp, the basic approach is to fix every bug on master. IF a bug fix is not applicable on master, then the bug fix can be proposed on the most recent stable branch where it is applicable, usually signing with [stable-only] or something like this. Nevertheless, py38 (tests) is not yet dropped (however it is not among the supported runtimes [1]), I agree with Takashi, that this patch is probably good to merge first on master.\n\n[1] https://governance.openstack.org/tc/reference/runtimes/2024.2.html","commit_id":"ec2b1e1ce91039fc3b85b6ee78980ebec312e8fe"},{"author":{"_account_id":35916,"name":"Pham Le Gia Dai","display_name":"Dai","email":"daipham.3213@gmail.com","username":"daiplg","status":"Full Stack Dev"},"change_message_id":"05e79e75f579975bbcd82d29efafd84e792ad2b3","unresolved":true,"context_lines":[{"line_number":5,"context_line":"     reading 2 or more GiB of a backup metadata file at a time. This was"},{"line_number":6,"context_line":"     causing the backup service to fail when reading large backup metadata"},{"line_number":7,"context_line":"     files. The fix is to read the file in smaller chunks whenever content"},{"line_number":8,"context_line":"     size is greater than 2 GiB. This bug only affects on python 3.8 and older"},{"line_number":9,"context_line":"     versions. Root cause: https://github.com/urllib3/urllib3/pull/2657"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6deca6e5_3d21d171","line":8,"in_reply_to":"8085cf71_dda191fe","updated":"2024-05-17 07:05:59.000000000","message":"yes, but this patch must be merged into master first and then backports to stable branches afterward","commit_id":"ec2b1e1ce91039fc3b85b6ee78980ebec312e8fe"}]}