)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32912,"name":"Pure Storage Third-Party CI","display_name":"Pure Storage Third-Party CI","email":"openstack-third-party-ci@purestorage.com","username":"purestorage-thirdparty-ci","status":"Doing CI things"},"change_message_id":"4c1ff54b4227152cfefd60019b236e0a8067f6fe","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Eric Harney \u003ceharney@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-04-11 13:59:17 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dell PowerFlex: add NVMe-oF support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds NVMe-oF support in Dell PowerFlex driver."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"c3b9c110_76df599d","line":7,"updated":"2024-08-07 14:36:10.000000000","message":"NVMe-TCP","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"205a7552cce66cc847a9d6cf3d954f331e0da0f1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Eric Harney \u003ceharney@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-04-11 13:59:17 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dell PowerFlex: add NVMe-oF support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds NVMe-oF support in Dell PowerFlex driver."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"c3cee0a4_f283c570","line":7,"in_reply_to":"c3b9c110_76df599d","updated":"2024-08-19 09:54:02.000000000","message":"Done","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":32912,"name":"Pure Storage Third-Party CI","display_name":"Pure Storage Third-Party CI","email":"openstack-third-party-ci@purestorage.com","username":"purestorage-thirdparty-ci","status":"Doing CI things"},"change_message_id":"4c1ff54b4227152cfefd60019b236e0a8067f6fe","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dell PowerFlex: add NVMe-oF support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds NVMe-oF support in Dell PowerFlex driver."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Implements: blueprint dell-powerflex-nvmeof"},{"line_number":12,"context_line":"Change-Id: Ic22add411b594d90d12b94e85055a33db40c197d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"c899779a_710e7aba","line":9,"updated":"2024-08-07 14:36:10.000000000","message":"NVMe-TCP","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"205a7552cce66cc847a9d6cf3d954f331e0da0f1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dell PowerFlex: add NVMe-oF support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds NVMe-oF support in Dell PowerFlex driver."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Implements: blueprint dell-powerflex-nvmeof"},{"line_number":12,"context_line":"Change-Id: Ic22add411b594d90d12b94e85055a33db40c197d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"0261eff2_7735b5a6","line":9,"in_reply_to":"c899779a_710e7aba","updated":"2024-08-19 09:54:02.000000000","message":"Done","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"39e59bf0d606998b7e897136c7c4eca6e39e3d22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"64874b51_a74f1f95","updated":"2024-03-15 03:19:44.000000000","message":"recheck","commit_id":"213352009026dc807763755e33282520e33dc3a7"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"467850c445f44532c2f5c26f13bdb7166bb1a0a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"24d4764d_c084e88f","updated":"2024-03-19 03:01:14.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"213352009026dc807763755e33282520e33dc3a7"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"ae3f937ab0428ad8a3fb3a4747a174b8de4b2134","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"582cc976_f196b39a","updated":"2024-03-15 09:48:58.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"213352009026dc807763755e33282520e33dc3a7"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"3f4c6ab4d09e745b21e1876521d261c956b41ffa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"93144dc0_6fbd83ce","updated":"2024-03-15 09:46:41.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"213352009026dc807763755e33282520e33dc3a7"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"6fb7a2c715133d86cb289540aa57bb037363e78b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9cd2edc9_9f9ed53a","updated":"2024-03-19 02:57:04.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"213352009026dc807763755e33282520e33dc3a7"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"90b15b38871341a7984615be7f6d8e65ce3779a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a2d0db8c_a4925024","updated":"2024-03-15 06:08:44.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"213352009026dc807763755e33282520e33dc3a7"},{"author":{"_account_id":31016,"name":"Ivan Pchelintsev","email":"i.pchelintsev@yadro.com","username":"pcheli"},"change_message_id":"2254baede7438971aa73ee833f1d8f3f913421cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ae6c800a_b2924433","updated":"2024-03-22 08:58:27.000000000","message":"Small misspelling","commit_id":"198405c7c2b862351d1470e2a3ba3554e7e811cf"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"bd50d2be700964628ac52ba00fdea0aee92b1e9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"07daf073_21f2f9fa","updated":"2024-03-22 11:32:02.000000000","message":"recheck tempest-integrated-storage cinder-plugin-ceph-tempest","commit_id":"198405c7c2b862351d1470e2a3ba3554e7e811cf"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"4fc4273164d20b9c4a8d3a6009b39ce0dcb6f19b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"320e14b8_bc9a11c3","updated":"2024-03-25 05:03:56.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"198405c7c2b862351d1470e2a3ba3554e7e811cf"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"c433942ec0b65c948c309aae7c30ccd3d649700a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3aa3b8c1_78ed43fe","updated":"2024-03-25 04:12:44.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"198405c7c2b862351d1470e2a3ba3554e7e811cf"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"25d6d9efd5752d1e222e6175babc028befe133c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6320254c_6251e380","updated":"2024-03-29 03:10:07.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"198405c7c2b862351d1470e2a3ba3554e7e811cf"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"374340c67344a1f09eb26d99a9c8bf38fa899820","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9f0367e4_cd6e1898","updated":"2024-03-25 03:51:54.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"198405c7c2b862351d1470e2a3ba3554e7e811cf"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"08058ca5fc93641e5b4e504919552bee7b0666e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a3180acd_1673e200","updated":"2024-03-26 06:09:05.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"198405c7c2b862351d1470e2a3ba3554e7e811cf"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"ed7b90ab3f5eebe50118cc69f0b0e5fb1e886c4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a6061c48_b59ad18a","updated":"2024-03-26 11:34:10.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"198405c7c2b862351d1470e2a3ba3554e7e811cf"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"11717d70fbbda23048d837adeee0f3d43217df6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c28bd33a_7981bdc1","updated":"2024-03-25 04:15:48.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"198405c7c2b862351d1470e2a3ba3554e7e811cf"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"a533ba60d7ec6a9e6041964a60e51e51e5f3c316","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d16bc170_119edf28","updated":"2024-03-25 03:48:52.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"198405c7c2b862351d1470e2a3ba3554e7e811cf"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"e3477886b33fe4739d4c5dfd6fa35b2f18ea672a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ec777546_2df01b0e","updated":"2024-03-27 02:18:27.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"198405c7c2b862351d1470e2a3ba3554e7e811cf"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"7a864562912f131d6a7b313e7dbcbe33880068f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ffa66af8_8872752b","updated":"2024-03-25 04:18:29.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"198405c7c2b862351d1470e2a3ba3554e7e811cf"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"ee92020f6af4d30516c9699c8e5037bc3ee8eb5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"092a64c7_ef1b6f51","updated":"2024-04-03 11:28:37.000000000","message":"recheck","commit_id":"40b33523c555bea1451b1432e9515a3cbc45856b"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"70c3c5ae8c190e71754200fa821dbac6e8d1f10b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"61c4c1b7_24d28207","updated":"2024-04-02 11:35:52.000000000","message":"recheck","commit_id":"40b33523c555bea1451b1432e9515a3cbc45856b"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"681ab380bc53152f713d1c789f3fc887bdf7ca72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e56ee01a_9a8909ff","updated":"2024-04-02 07:10:06.000000000","message":"recheck","commit_id":"40b33523c555bea1451b1432e9515a3cbc45856b"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"b93cc0d440f8921ce9d49079018689c6e77c9ed0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7c180cb6_4f858bf9","updated":"2024-04-03 07:31:27.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"40b33523c555bea1451b1432e9515a3cbc45856b"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"c42ad5c0926f530eba60a6c8116fbc583ff98d30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"83d93142_14287e78","updated":"2024-04-03 02:17:00.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"40b33523c555bea1451b1432e9515a3cbc45856b"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"7f8b1e80dc6fdaf76700d4c0fdb2fbeccb0b1ca4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"78c4b1b3_4ce283a6","updated":"2024-04-07 06:43:59.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"04ddcc5ba5e28edea549e8bb876d6a1574b2d455"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"f88d133d6fe70993125e9dc5ad3db12fcdd9ddbf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"48b26e21_534bad23","updated":"2024-04-08 09:44:30.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"c5264d0b187945cf6c308aa4ff08f3cb28815551"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"937651b5e27731568b6dc54fe30f9b9960f9d70b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4f75d4b3_17568c64","updated":"2024-04-08 09:40:46.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"c5264d0b187945cf6c308aa4ff08f3cb28815551"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e2bb0613c2f98a91b1d3a972721f2d927c91ab0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ef890a99_4924cc2b","updated":"2024-04-07 13:56:46.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"c5264d0b187945cf6c308aa4ff08f3cb28815551"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"bb99370609358fae9c3b7cbc98377c796cf008fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f3cde3dc_3ec95f70","updated":"2024-04-10 07:45:30.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"c5264d0b187945cf6c308aa4ff08f3cb28815551"},{"author":{"_account_id":32912,"name":"Pure Storage Third-Party CI","display_name":"Pure Storage Third-Party CI","email":"openstack-third-party-ci@purestorage.com","username":"purestorage-thirdparty-ci","status":"Doing CI things"},"change_message_id":"4c1ff54b4227152cfefd60019b236e0a8067f6fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c82f4d39_cd927edc","updated":"2024-08-07 14:36:10.000000000","message":"You keep referencing NVMe-oF which is a generic term for all the NVMe protocols. \nAs you are actually only adding NVMe-TCP support, please ensure that is what you are referencing throughout the code, comments and docs.","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"dfa60aab30e2c668c16aa369c04a29616935fdd3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2055ed47_9c17cab8","updated":"2024-04-12 03:36:24.000000000","message":"recheck tempest-slow-py3","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"bfa6fdd3090bcce81f048258ee97a5d88333bfeb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"186defde_eb5fcf71","updated":"2024-04-12 06:09:45.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"d4ca1a90e5d8a5e5a8185ed62e9cd242c625d7c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1c487a17_2a129ade","updated":"2024-04-12 10:11:04.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"5730e5809a2f52618a895f95f14a051e80d73053","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"249521a8_5d57bd92","updated":"2024-04-15 02:09:50.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"442e49cec07acf92aad39dc6a59fc0bf1d3c21d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2eed21ab_50eec3fe","updated":"2024-04-15 06:55:30.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"574e46cddc03438623cc8e266b7a30c6456e60ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7a2ee72c_90417555","updated":"2024-04-12 08:14:09.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"a570e078e95762859703ca2aae9ad78bbd1edcfe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"96772323_3112b0ee","updated":"2024-04-12 02:21:11.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"77dd98ca236a98b1e9c8c87bd87d4cc343a9e958","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ba331f17_f9ca1203","updated":"2024-04-12 02:19:03.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"a37f776b4c4a773427452df65f8bf53a74ca604f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e7daff32_3164784d","updated":"2024-04-16 02:10:40.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e0ce057745695c59e68f86a3e827cd1a81feaa60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"bbb513f8_11195750","updated":"2024-08-19 13:05:10.000000000","message":"recheck \ntempest.api.compute.servers.test_server_actions.ServerActionsTestOtherA SSHTimeout","commit_id":"7f1753cc64b0c6e63e83ae76a9de177cc503c1f7"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"563b5099c007511e9fb9d78f0842c2bd3f3c4d1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1b741936_a7c64e87","updated":"2024-08-22 09:44:38.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"4f3c6b6ec9932e0bfa627eae7b166a8b225b2ad7"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"61ed9a18677ef82c75190df11f75f27d0f9f9a53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b52e10ab_03fec4b6","updated":"2024-08-21 02:27:27.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"4f3c6b6ec9932e0bfa627eae7b166a8b225b2ad7"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"86c42621b21375f0a8a6b4281fcbcb011813c6e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"cd66a719_b7d35487","updated":"2024-08-20 13:46:42.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"4f3c6b6ec9932e0bfa627eae7b166a8b225b2ad7"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"99e081d566fd6b8cc8bfc0b2653e9eed84250b7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"d6063b79_d949af3a","updated":"2024-08-21 03:18:00.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"4f3c6b6ec9932e0bfa627eae7b166a8b225b2ad7"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"5676218ccf1ccc7a12b5376053641b488a524c70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f7c4f045_e68a2ebc","updated":"2024-08-20 07:42:16.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"4f3c6b6ec9932e0bfa627eae7b166a8b225b2ad7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"398f1524a1138e2048e415eba0d90d3bec1c6980","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"6d501daf_61ac17b1","updated":"2024-08-30 22:39:49.000000000","message":"Code and tests look OK.  Question inline about the way you\u0027re representing the storage_protocol.  (-1 to get your attention.)","commit_id":"bca14743cbf7dcfd9283ba77120a025217cc43a6"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"5805d079b9a078f358c05725ec24e9885bcc1654","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"47f36ca6_fb52b23b","updated":"2024-08-30 19:05:38.000000000","message":"Even though the PowerFlex CI reports success, when i look at the test summary for NVMe-TCP (https://elab-os-logsrv.delllabs.net/58/912058/12/check/DellEMC_PowerFlex_4.x_NVMeTCP/04ce6ad/DellEMC_PowerFlex_4.x_NVMeTCP/828/logs/ci_log/testr_results.html) I see there are 9 failures.  I\u0027m not sure if the failures are related, but the failing tests do include volume attach/detach... Can you clarify how to interpret these results?","commit_id":"bca14743cbf7dcfd9283ba77120a025217cc43a6"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"b26418872c62d112b5e2e4dee9a999b652fbad86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"71c379c1_a27c40f2","updated":"2024-08-27 06:23:52.000000000","message":"recheck pep8","commit_id":"bca14743cbf7dcfd9283ba77120a025217cc43a6"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"6c77c58e76105af847a6e3d9a2f5ab3abcdc2442","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"0ab5ee0a_3af95294","updated":"2024-08-23 05:04:37.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"bca14743cbf7dcfd9283ba77120a025217cc43a6"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"8995a9c0ee40e7eb346190f069b42d00227c7a02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"7943f0f0_4e7d80d3","updated":"2024-08-23 08:10:45.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"bca14743cbf7dcfd9283ba77120a025217cc43a6"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"a5a9ff5cfb8b8dc9d691a294fbe09299eed3a8bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"809d5318_60b5024b","updated":"2024-08-23 07:59:03.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"bca14743cbf7dcfd9283ba77120a025217cc43a6"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"8e8f28575f952602ce2ad45ac67c1c2174040153","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"8b391297_016979b0","updated":"2024-08-25 10:22:28.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"bca14743cbf7dcfd9283ba77120a025217cc43a6"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"b23f73a243a773752742931bff068fe1f8ef9482","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"9b2bfed1_ea5a56b1","updated":"2024-08-26 09:12:46.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"bca14743cbf7dcfd9283ba77120a025217cc43a6"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"a58dfbfba6c364c61cdeb864ac2700f935bef84b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"9ca415bf_116acb0a","updated":"2024-08-26 04:40:44.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"bca14743cbf7dcfd9283ba77120a025217cc43a6"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"ece05e26dde544f7747d07de6c2954d9fc4afbf2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"aae046d3_d9435821","updated":"2024-08-26 12:48:30.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"bca14743cbf7dcfd9283ba77120a025217cc43a6"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"a14f1870f35aa3279b3375f8f203e6fc0a9cfbaa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"ad68fe5c_9614134c","updated":"2024-08-23 05:03:45.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"bca14743cbf7dcfd9283ba77120a025217cc43a6"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"fadf616d88db204c7e0091d1e11135d3967d9dae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"c893871e_7420c039","updated":"2024-08-24 16:46:02.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"bca14743cbf7dcfd9283ba77120a025217cc43a6"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"5448d1cc5eb3d20d37fa2604278ddcec947191e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f44d40a9_ecb517ef","updated":"2024-08-25 07:14:14.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"bca14743cbf7dcfd9283ba77120a025217cc43a6"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"a7f39c8171e6f7840cfa082913c5f9614ba5cd07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"931dce85_0545fe23","in_reply_to":"47f36ca6_fb52b23b","updated":"2024-08-31 01:29:02.000000000","message":"Hi @jobernar@redhat.com,\nThank you for reviewing!\nI can explain:\n\n(1) The CI tempest concurrency is set to 8.\nWhen running concurrently, test cases compete for resources, e.g. host, port, connection etc. Those couldn\u0027t acquire the resources will fail.\nAmong the 9 failed cases:\n4 failed due to \u0027Exhausted all hosts available for retrying build failures for instance\u0027;\n2 failed due to \u0027There are one or more ports still in use on the network\u0027;\n1 failed due to \u0027HTTPConnectionPool(host\u003d\u0027\u0027, port\u003d80): Read timed out\u0027;\n2 teardown tests failed to delete volume.\nNone is related to attach/detach operation. Also, the \u0027n-cpu\u0027 log [1] can prove it.\n\n(2) After completed running of all test cases, Zuul re-run the failed tests once.\nZuul reported success on the condition that all the failed test cases passed.\n\n[1] https://elab-os-logsrv.delllabs.net/58/912058/12/check/DellEMC_PowerFlex_4.x_NVMeTCP/04ce6ad/DellEMC_PowerFlex_4.x_NVMeTCP/828/logs/ci_log/screen-n-cpu.txt.gz","commit_id":"bca14743cbf7dcfd9283ba77120a025217cc43a6"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"268630976a1d4059135a8c72a832216a679e2c77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"343ef2d8_39cd1513","updated":"2024-09-04 10:41:21.000000000","message":"Hi @rosmaita.fossdev@gmail.com and @jobernar@redhat.com,\n\nComments are resolved. Please kindly review it again.\nThank you!","commit_id":"292c2f103d86771f77339dec16cf9cfea6ccf50a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d18c286c1ce126dbed92f3f0bd427d82aba16f2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"cb18c610_50573b51","updated":"2024-12-06 09:45:40.000000000","message":"Thanks for proposing this. Few comments inline.","commit_id":"292c2f103d86771f77339dec16cf9cfea6ccf50a"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"41eb1dd2db8071cbc4a91281f0474517a48122ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"2ab3ad69_c72263ed","updated":"2024-12-31 09:45:16.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"292c2f103d86771f77339dec16cf9cfea6ccf50a"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"b44c8c7f65fcd07d1689f0d671452be6b4b07c3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"320eb65b_792da176","updated":"2024-12-30 10:17:27.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"292c2f103d86771f77339dec16cf9cfea6ccf50a"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"a90d5ed1947e209fab3c2ac5c764a04a9d64ab6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"46b7695e_4fc96860","updated":"2025-01-02 13:44:18.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"292c2f103d86771f77339dec16cf9cfea6ccf50a"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"cda7aa0d555080b20006b4c8755bfe46f9b1d3b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"4e621705_5cd1dc76","updated":"2024-12-31 09:39:19.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"292c2f103d86771f77339dec16cf9cfea6ccf50a"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"c887b2f4b12d4da2633afa6bbdd1b1986514ebea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"6a5e1765_01eb59d9","updated":"2025-01-02 13:46:52.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"292c2f103d86771f77339dec16cf9cfea6ccf50a"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"d52fe5cd6b247f799b085637cf5309dece9a43b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"7b6b9a6b_5a56f9fd","updated":"2025-01-08 20:24:52.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"292c2f103d86771f77339dec16cf9cfea6ccf50a"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"a0f3ca83792b6c2262a0930226ebb7bcd34d2894","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"a7028138_f3b90133","updated":"2025-01-02 13:07:29.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"292c2f103d86771f77339dec16cf9cfea6ccf50a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"d9c4ae4bf1db4ee876fe5bb869fe04c8f450d56c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"aa7e0115_7628173e","updated":"2024-08-31 12:15:42.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"292c2f103d86771f77339dec16cf9cfea6ccf50a"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"d2c64499d3f2fd32d27f49771abf0107fa718861","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"b72da1d7_b357a1f6","updated":"2025-01-02 13:51:38.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"292c2f103d86771f77339dec16cf9cfea6ccf50a"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"d835557c12b41239667c6a8fea0e32e05be303ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"c2200995_c02ec3b5","updated":"2024-12-16 13:17:37.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"292c2f103d86771f77339dec16cf9cfea6ccf50a"},{"author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"change_message_id":"4a229a94c10e0055debeb415810f548bf98c1fac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"cdd8b08c_cc0bed08","updated":"2025-01-07 13:48:26.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"292c2f103d86771f77339dec16cf9cfea6ccf50a"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"86c7080658f27b849f7951cbca2d908f5dfbf228","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"ecfbc9ca_4e851fb5","updated":"2025-01-10 13:55:42.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"292c2f103d86771f77339dec16cf9cfea6ccf50a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"86e7933bf48bd156f9317c8cbe34123e033f17de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"eedf13a1_42ff4b55","updated":"2024-08-31 15:33:27.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"292c2f103d86771f77339dec16cf9cfea6ccf50a"},{"author":{"_account_id":37328,"name":"Nimesh Desai","display_name":"Nimesh Desai","email":"nimesh.desai@ibm.com","username":"nimeshdesai"},"change_message_id":"b121fe812e6e136089e39d935d2bdd6e6753172c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"2d9a872f_0085c4ba","updated":"2025-08-25 10:19:23.000000000","message":"LGTM","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"8e54812d7b93e77e6bdf39a1d3c5d85005fc15c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"97a49f69_88698f47","updated":"2025-08-25 10:02:48.000000000","message":"Reviewed the code. LGTM","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"29b4d2f3f1f2ce10b5ad37ded3489cec5b232740","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"ea87c4c7_da37b5bd","updated":"2025-08-26 21:29:32.000000000","message":"Several questions need to be clarified before I look at the unit tests.","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"ab7a5ef2766d77919d438cef469b9693c02967e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"af00a248_f22112d0","updated":"2025-03-07 16:53:11.000000000","message":"n","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"615df59f887378579f6683d598b58ec2c3a351fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"0cd447f2_6a35c9ef","updated":"2025-01-27 15:07:09.000000000","message":"recheck cinder-plugin-ceph-tempest ServerFault","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"365625e5cd59ae8a1a05a121523c901f04717a31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"7140b9b5_b899f5a8","updated":"2025-01-26 08:22:08.000000000","message":"recheck cinder-plugin-ceph-tempest ServerFault devstack-plugin-nfs-tempest-full timeout","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"67b96f3dd148bd84042119d3deab6a6af14ba5a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"017469d7_7ab0fdec","updated":"2025-03-24 14:08:28.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"4d4988a93d3eb724a7b50c9bd26375aa010b508f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"0412edf1_f1a146b9","updated":"2025-05-13 09:07:20.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"6b5cad13f6ae04dcc4d799ee5d6acbe1f31f1d85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"0b5a3b87_bfbdd8d3","updated":"2025-05-11 18:19:02.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"5444c522c4dc57fd227ce6d5caed6fcb4078046b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"1021fbe2_be9d7708","updated":"2025-03-13 06:46:54.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"6e3eea0095775547269ceb6c1bb57f59fefa117b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"1041fa7b_f5e15f20","updated":"2025-07-08 11:24:30.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"4d2f0afb447ad6238ebbb31fa845f4b9fbec9794","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"15369bb2_ef37169f","updated":"2025-06-23 13:23:45.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"90f8955cb7dd74fea9bd8bca280d6c6188b99bed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"177ced49_4fdc1a07","updated":"2025-03-26 12:37:08.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"ce997fb305ba199f2316572f3e911ec012def9ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"1ac618fd_320d7aa7","updated":"2025-03-13 10:03:28.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"7cfea8e04f9177d6f66e14e2bb124c6927663b44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"1c1d99e0_7b7c0440","updated":"2025-06-03 17:02:31.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"b3992df52e980516505562df1a09c99fbcf13caa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"1f5de723_be30e93b","updated":"2025-03-10 16:40:23.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"6404856448c0a7f001d602d293595d0fca4e7ba5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"201aa0c7_793a0eeb","updated":"2025-03-07 08:05:52.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"5cd22003e953d6761b5a9feaac36cdf6e6b6c8e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"249a09fe_84c18b99","updated":"2025-03-13 14:01:29.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"58c677a5a0afe72163873dd41586b18f0ef0ca69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"2cc7b561_276294fb","updated":"2025-04-17 16:18:29.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"1f630f234d3f6bd16d8ebc888604eaf23b3f42ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"2edf070e_74fd34a5","updated":"2025-03-07 17:41:05.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37822,"name":"Atanu Sikder","email":"atanu_sikder@dell.com"},"change_message_id":"602431573849b3715ce88199cd9cf07567e571a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"314acc35_901bbdde","updated":"2025-05-14 05:08:12.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"e049ea233219ecb0d90dd4b00eeee6780b6e037d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"3c4f5ab1_e60e4923","updated":"2025-03-18 09:42:35.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"b9439dcd7164e3059d7e99acc2e99e6c7f91c5b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"3e3c2533_6d66ec58","updated":"2025-05-29 07:13:02.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"d694d63b1783eda4d03417fea12761b699f1940e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"413ab683_9c1a7b47","updated":"2025-03-17 13:36:03.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"677a0ed3b541e1ae149116fa292041ec9444dea8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"44993c4f_aad094d5","updated":"2025-03-24 20:00:34.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"4419404752292bc066dee6d96a3db9df7fa7e8af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"4770bdb8_673d6636","updated":"2025-03-21 13:22:01.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"28b60a37eb5e139b77cd154f4a6d0aa96d320d44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"501ae3b8_d62bb7c9","updated":"2025-03-17 15:26:09.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"0f9645cc994f30a90009b9d494441b252f1e223b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"506d78e7_2f94ecde","updated":"2025-07-09 11:41:08.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"a56c7792af67f49fd48fd27cd19c62c184826b83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"50ab49ef_de91f734","updated":"2025-05-16 04:39:38.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"51f855a9f79d900ddf377a3f1ec785a01f24faa4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"592a8f66_0e62ef5e","updated":"2025-05-19 07:22:55.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"790723f869de6bc1a2c8d7f32ebc8fadbd0c6b26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"5d3a3e20_afa8eefc","updated":"2025-07-01 11:18:39.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"08357f91cdc1251c4e9cf9287cbaad4405801386","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"7b7c203b_b0589b16","updated":"2025-05-22 18:56:06.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"38fa24d1f5d32a71c9b95ade46a75da19ab014d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"7eaffec0_367d7c33","updated":"2025-03-12 08:20:42.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"0a7b49afdf5aed3429202a88f921fce7cac85d6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"822f4dbf_ddc237d6","updated":"2025-03-20 19:43:16.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"13c55187663f77df2589a9201043a031918632ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"865ede80_8679a1b5","updated":"2025-03-07 11:07:43.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"6ec2ec6d028d57fffc8f09fe1aa346c58d5a4194","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"871f2cec_77b98a69","updated":"2025-03-07 14:15:09.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"305aa9af50d4f422d43d0bb6eb2023a9d56af677","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"8a7a823f_5981ae9a","updated":"2025-04-10 14:27:39.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"bd06dbe6a158ba6e7143f1be64acf4c31aa11b23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"8e542516_4aa839b8","updated":"2025-07-08 11:31:41.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"ef29961ce7167fcf4cab482ab93abfb03ff3a32e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"918ab87f_807d8a23","updated":"2025-04-10 19:11:43.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"222c284c1fb6a2dcee505283e4c88bdb88d12356","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"9809c6a5_26320536","updated":"2025-05-29 09:28:03.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"f26fde65711abb7dd327a168ca87fbb2d192aa8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"a398185a_4fa89506","updated":"2025-03-07 08:33:10.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"7dda01a41ebdf2b5dfcb7cba00d3515920ed7322","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"ae86acdf_1a1f2ee0","updated":"2025-06-11 07:45:21.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"a21f782efc7e8dbd0564077a7f93d0bb706314bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"c754fe3a_c24961af","updated":"2025-03-20 11:02:50.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"22a374c7b16ca088483fd728538ff5a9a5f8ee57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"ce08b502_d2cf1e22","updated":"2025-03-21 09:08:44.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"688f77ad36e7cff92e997487f1c2bb71426c2b85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"d274893c_5c93c98f","updated":"2025-07-18 04:59:37.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"b87d66bec1265ef33510fab36086c46fee704bc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"d695deff_ac9dc95c","updated":"2025-03-21 16:20:51.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"dbe1a50897089e3b17795f0aa703e66561cec060","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"e0ab3e8b_3dced884","updated":"2025-03-11 15:46:53.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"eee53b126e89a450b0d04d7185ed63779c6bf9dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"e19d3dc2_7f53026c","updated":"2025-03-26 16:44:30.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"de3536cfee3463e77aabdc5b0f16139439d19849","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"eade1490_a82d0096","updated":"2025-03-17 15:20:21.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"3fa3fa48ba3b696f9885efce5f12f7b7b656da19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"ecaf48fa_1a4d64af","updated":"2025-03-12 14:46:31.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"ea287e3083dcf2bcefc3a60e88f38a3f01740fd1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"ed18bc4b_8ae2981d","updated":"2025-06-11 07:50:50.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"e955db49ae00e68dcd439de03a83e9a76025214d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"f11acb47_466f0e5d","updated":"2025-03-24 10:04:55.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"ba37329c12ba692c0c50bd386ab9e5bda1423405","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"f99916c4_200148cd","updated":"2025-03-26 08:44:08.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"ba633fc41ce14a1501d2dffd423b6d6dd1322a29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"850ba0be_3645b8e8","updated":"2025-05-13 08:48:29.000000000","message":"run-DellEMC PowerFlex CI 1","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"93a027093b571211585266d285b95016cdaae928","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"e9fb17ee_91e7b3a8","updated":"2025-05-13 08:53:46.000000000","message":"run-DellEMC PowerFlex CI 1","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"6fb11fe6ea42c12811db3945d3ed73f5002b43cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"05265d1f_4fbbc33e","updated":"2025-10-13 20:44:21.000000000","message":"The patch is trending in a good direction!","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"ec8cc16d8bd08329358cf30eaf9697405fe111b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"0c0c5f71_3d831dfb","updated":"2025-09-30 12:45:11.000000000","message":"recheck devstack-plugin-nfs-tempest-full timed_out","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"edf5457364bd0cbc459192150ed1c68fa54be753","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"09550e08_cd36bb6b","updated":"2025-10-15 06:14:08.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"7db0f5cbde475e2b7f64bc8721866884c99dde57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"0cbca43d_25e36399","updated":"2025-10-14 08:15:22.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"375a6039daaf63ead249caa76286cd0aad439c9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"8575099a_3993b3e5","updated":"2025-10-13 09:26:04.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"3acf8d8e14cb57ddd1f1cad236f20e2049e629d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"9bb65528_e2b471eb","updated":"2025-10-13 06:18:39.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"27701a7325e109cc457053c0e82e218017b0d49a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"aa553403_73eee757","updated":"2025-10-09 13:51:01.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"6dfffbbb3b8e7427c1bcfda1f1442a772d1e7c64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"cf875907_fbf467b1","updated":"2025-10-09 12:07:47.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"7d71640d0f4a5a5bf63bd8f52ef4df5b1aa748ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"d99016ee_97ef1fd6","updated":"2025-10-17 06:47:31.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"237d3fcb533ff511659f5b071c9c4da2f163f16a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"e0ba0bb7_506ecf45","updated":"2025-10-09 11:31:02.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"e8b43fd39294605ea88a2cdacd2713c177d277b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"ef8ba5e0_a0497d2d","updated":"2025-10-10 07:01:52.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"ed40f8fdd4322463664895d16851c4082057e53c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"f66831ed_8c8774e3","updated":"2025-10-09 11:17:00.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"5d0c1f1598d33d314fffaecf26a166cda2f0d1b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"fa586100_9b56d75e","updated":"2025-10-09 11:20:01.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"a030e62ed9a2b5f60e890f7371c1d6cff9288ba0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"b9c32846_475eab5f","updated":"2025-10-22 20:06:48.000000000","message":"I think this patch is fine as is, with the storage_protocol specifying the generic NVMEOF value (\"NVMe-oF\").\n\nAn alternative, in case other reviewers have an opinion, would be to:\n- Wait for https://review.opendev.org/c/openstack/cinder/+/964492 to merge and rebase on top of it\n- Change the storage_protocol to NVME_TCP","commit_id":"6421669833f88feda25fee2ce048d1f93a9a8208"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"b25dad83f810dc8b9ee5f6685811170ae84807a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"24747765_30fe79e6","updated":"2025-10-22 20:31:55.000000000","message":"What are the actual CI results? The reports keep saying everything failed, and it would also be good to know if your CI is testing NVMe-TCP.","commit_id":"6421669833f88feda25fee2ce048d1f93a9a8208"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"7149a458d9a6b483183b20e984db60ba8fd7830d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"5f10df1b_126b7f09","updated":"2025-10-20 10:08:14.000000000","message":"recheck Timed_Out","commit_id":"6421669833f88feda25fee2ce048d1f93a9a8208"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"a0e7ba9de897ae5947b8f0cd23e67a6c3f8e1119","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"3ff2e786_cc1b26bc","updated":"2025-10-21 08:26:03.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"6421669833f88feda25fee2ce048d1f93a9a8208"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"d718424efc24125ebc7ea8f73aeda5cd7a7da3de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"54032ba9_cf68b240","updated":"2025-10-27 12:21:18.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"6421669833f88feda25fee2ce048d1f93a9a8208"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"da566270eeb896a94f3fe208f9fc2427d85a135d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"c9bed42e_a87161be","updated":"2025-10-24 06:32:54.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"6421669833f88feda25fee2ce048d1f93a9a8208"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"65cacb351ef26b79922f5e15460dd2c703a49f45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"f9a228a2_c889eb2f","updated":"2025-10-29 09:08:16.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"6421669833f88feda25fee2ce048d1f93a9a8208"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"45f104589511aa25e79e80d660dca804619ba9f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"417fd97e_2fbf5d7e","updated":"2025-10-24 09:18:59.000000000","message":"run-DellEMC PowerMax CI","commit_id":"6421669833f88feda25fee2ce048d1f93a9a8208"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"bf6379939c91688116035dff8fad818a78305abb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"9414d5a6_c770531b","updated":"2025-10-24 07:35:15.000000000","message":"run-DellEMC PowerMax CI","commit_id":"6421669833f88feda25fee2ce048d1f93a9a8208"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"ef75913b4ec8bf807f1d4749d5447b54c663af16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"ae3eb92d_0696ed1c","updated":"2026-01-09 18:21:26.000000000","message":"recheck","commit_id":"f2b09161cb86262ebfad79ee0766cdf70dd44f95"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"f8745e801c9bef9bc45e218523d3febe4a1de4a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"14f46624_b93634b5","updated":"2026-03-18 05:48:38.000000000","message":"run-DellEMC PowerFlex-v4 CI","commit_id":"f2b09161cb86262ebfad79ee0766cdf70dd44f95"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"9018213793dc4b31c0e175113d0ff6ab20748e4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"5c314ae0_5e098d8b","updated":"2026-03-17 10:42:28.000000000","message":"run-DellEMC PowerFlex-v4 CI","commit_id":"f2b09161cb86262ebfad79ee0766cdf70dd44f95"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"1507e5d38761f1d1fbfa6b8589373bacef31f9e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"e52502a9_436ae983","updated":"2026-03-18 08:51:18.000000000","message":"run-DellEMC PowerFlex-v5 CI","commit_id":"f2b09161cb86262ebfad79ee0766cdf70dd44f95"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"5657b8ca36e3be797ce2a19c973fbfd18b4c38ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"ae2832e5_e3d9ea1a","updated":"2026-03-20 05:00:03.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"72d2de8ce2ffeb8f51ebcd99747731f70475b5f5"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"cd9a5107ccf29f24a71fb3ae1e2832deb1cbc2d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"59c4518c_239ee68a","updated":"2026-03-23 10:12:08.000000000","message":"run-DellEMC PowerFlex-v4 CI","commit_id":"72d2de8ce2ffeb8f51ebcd99747731f70475b5f5"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e6a942e05c538eb616bc98368eea27de9c1d3573","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"b7948b0c_d0de7c58","updated":"2026-03-20 05:05:24.000000000","message":"run-DellEMC PowerFlex-v4 CI","commit_id":"72d2de8ce2ffeb8f51ebcd99747731f70475b5f5"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"9e0fc2f59be336bbbc6d4984886700e866c781e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"72f05c24_8f56e465","updated":"2026-03-20 04:58:17.000000000","message":"run-DellEMC PowerFlex-v5 CI","commit_id":"72d2de8ce2ffeb8f51ebcd99747731f70475b5f5"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"9f855086bf220114e3f695944de2019fbc70018e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"cbdf4528_5fa7f3a3","updated":"2026-03-20 08:00:51.000000000","message":"run-DellEMC PowerFlex-v5 CI","commit_id":"72d2de8ce2ffeb8f51ebcd99747731f70475b5f5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0112369a92c8eea1ac4ab5a4e5a2e4858e1b8f07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"d4b9ef87_1587fbfe","updated":"2026-05-11 21:02:36.000000000","message":"Just one minor change, but I think it\u0027s important.  You\u0027ve had to use NVMe-OF as the storage_protocol even thought you\u0027re only supporting NVMe-TCP because cinder didn\u0027t recognize NVMe-TCP properly.  This is now supported properly in cinder with the merge of https://review.opendev.org/c/openstack/cinder/+/964492 , so it would be good to rebase your patch on master and change the new driver\u0027s storage_protocol to report properly.  I think we should do this now (instead of in a followup).\n\nOtherwise, the code and tests look good and zuul and the third party CI are reporting green, so after the change mentioned above, I\u0027m +2 on this patch.","commit_id":"5412f203cab3db87efa63ab9273360a7293fce12"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"1723e1bded0aff3e95a56e1a374ae13ddb7a0192","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"eb252569_2db7b98b","updated":"2026-04-29 06:06:55.000000000","message":"recheck","commit_id":"5412f203cab3db87efa63ab9273360a7293fce12"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"ca908dace25f1a3d042684db85187d0f695f38d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"235a6b9e_69d011e9","updated":"2026-04-20 11:29:08.000000000","message":"run-DellEMC PowerFlex-v4 CI","commit_id":"5412f203cab3db87efa63ab9273360a7293fce12"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"5eb07783c76eeff960a8a7421a1ff43880a3ae3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"e7212f9a_a2902a7c","updated":"2026-04-20 11:28:06.000000000","message":"run-DellEMC PowerFlex-v5 CI","commit_id":"5412f203cab3db87efa63ab9273360a7293fce12"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"91a5a3f66d9981c3b0e18319787f36093c215632","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"afceb049_7c481405","updated":"2026-05-12 06:42:28.000000000","message":"@rosmaita.fossdev@gmail.com thanks for the review, have updated code, please do a review.","commit_id":"7d5f250e1a43b8a7d25761bcb843e5a42cccba6b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"34fff2798aef3b57ac8535b0a780bed21e5918ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"5e0d221f_0e9bf3c1","updated":"2026-05-12 12:47:17.000000000","message":"Revisions LGTM; I think this is ready now.\n\nDellEMC PowerFlex-v4 CI failed on first try, but looks like the issue was not being able to ssh into an instance, so not related to this patch.","commit_id":"7d5f250e1a43b8a7d25761bcb843e5a42cccba6b"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"611d76afe284f5fab28eedc80d3ed40bba889466","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"6c3bb6a5_d999d84a","updated":"2026-05-12 06:42:50.000000000","message":"run-DellEMC PowerFlex-v4 CI","commit_id":"7d5f250e1a43b8a7d25761bcb843e5a42cccba6b"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"081967364e2b6a3dc713d821e3b2b63a298c21e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"fd231e43_8f165cae","updated":"2026-05-12 10:44:29.000000000","message":"run-DellEMC PowerFlex-v4 CI","commit_id":"7d5f250e1a43b8a7d25761bcb843e5a42cccba6b"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"b3838ccf8fc08b4a6d756918d879401bf0ce245a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"609a7eff_a6c2c4cc","updated":"2026-05-12 15:00:46.000000000","message":"run-DellEMC PowerFlex-v4 CI","commit_id":"24a0db57e9c665dc3c23ee7c6195c42e3fae06d6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"a978da909a70266124efd435c51af59387d47f1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"09496174_46de3eac","updated":"2026-05-12 15:00:12.000000000","message":"thanks for the review @eharney@redhat.com, have updated the code ,please do a review.\n\n@rosmaita.fossdev@gmail.com your vote also gets rested please do review as well.","commit_id":"24a0db57e9c665dc3c23ee7c6195c42e3fae06d6"}],"cinder/tests/unit/volume/drivers/dell_emc/powerflex/__init__.py":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"6fb11fe6ea42c12811db3945d3ed73f5002b43cd","unresolved":true,"context_lines":[{"line_number":234,"context_line":"            configuration\u003dself.configuration)"},{"line_number":235,"context_line":"        self.driver.do_setup({})"},{"line_number":236,"context_line":"        self.driver.primary_client \u003d mocks.PowerFlexClient(self.configuration)"},{"line_number":237,"context_line":"        self.driver.secondary_client \u003d mocks.PowerFlexClient("},{"line_number":238,"context_line":"            self.configuration,"},{"line_number":239,"context_line":"            is_primary\u003dFalse)"},{"line_number":240,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"a180cd11_d29983cb","line":237,"updated":"2025-10-13 20:44:21.000000000","message":"Is this secondary client for replication? If the NVMe driver doesn\u0027t support it then can it be eliminated from the test class?","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"ef942218133fa4c510ba67c998706d3b668f2660","unresolved":false,"context_lines":[{"line_number":234,"context_line":"            configuration\u003dself.configuration)"},{"line_number":235,"context_line":"        self.driver.do_setup({})"},{"line_number":236,"context_line":"        self.driver.primary_client \u003d mocks.PowerFlexClient(self.configuration)"},{"line_number":237,"context_line":"        self.driver.secondary_client \u003d mocks.PowerFlexClient("},{"line_number":238,"context_line":"            self.configuration,"},{"line_number":239,"context_line":"            is_primary\u003dFalse)"},{"line_number":240,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"f106c330_18b10987","line":237,"in_reply_to":"a180cd11_d29983cb","updated":"2025-10-20 06:39:15.000000000","message":"Done","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"}],"cinder/tests/unit/volume/drivers/dell_emc/powerflex/test_nvme.py":[{"author":{"_account_id":32912,"name":"Pure Storage Third-Party CI","display_name":"Pure Storage Third-Party CI","email":"openstack-third-party-ci@purestorage.com","username":"purestorage-thirdparty-ci","status":"Doing CI things"},"change_message_id":"4c1ff54b4227152cfefd60019b236e0a8067f6fe","unresolved":true,"context_lines":[{"line_number":27,"context_line":"        \"\"\"Setup a test case environment.\"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        super(TestNvme, self).setUp()"},{"line_number":30,"context_line":"        self.driver.storage_protocol \u003d constants.NVMEOF_VARIANT_2"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        self.client_mock \u003d mock.MagicMock()"},{"line_number":33,"context_line":"        self.driver._get_client \u003d mock.MagicMock(return_value\u003dself.client_mock)"}],"source_content_type":"text/x-python","patch_set":8,"id":"f0b77b14_f45f3054","line":30,"range":{"start_line":30,"start_character":49,"end_line":30,"end_character":65},"updated":"2024-08-07 14:36:10.000000000","message":"NVME_TCP","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"205a7552cce66cc847a9d6cf3d954f331e0da0f1","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        \"\"\"Setup a test case environment.\"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        super(TestNvme, self).setUp()"},{"line_number":30,"context_line":"        self.driver.storage_protocol \u003d constants.NVMEOF_VARIANT_2"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        self.client_mock \u003d mock.MagicMock()"},{"line_number":33,"context_line":"        self.driver._get_client \u003d mock.MagicMock(return_value\u003dself.client_mock)"}],"source_content_type":"text/x-python","patch_set":8,"id":"cf9fe2b9_c5a7f69b","line":30,"range":{"start_line":30,"start_character":49,"end_line":30,"end_character":65},"in_reply_to":"f0b77b14_f45f3054","updated":"2024-08-19 09:54:02.000000000","message":"Done","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":32912,"name":"Pure Storage Third-Party CI","display_name":"Pure Storage Third-Party CI","email":"openstack-third-party-ci@purestorage.com","username":"purestorage-thirdparty-ci","status":"Doing CI things"},"change_message_id":"4c1ff54b4227152cfefd60019b236e0a8067f6fe","unresolved":true,"context_lines":[{"line_number":51,"context_line":"                             override\u003dTrue, group\u003dconf.SHARED_CONF_GROUP)"},{"line_number":52,"context_line":"        self.driver.do_setup({})"},{"line_number":53,"context_line":"        self.assertEqual(self.driver.storage_protocol,"},{"line_number":54,"context_line":"                         constants.NVMEOF_VARIANT_2)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_validate_nvme_version_valid(self):"},{"line_number":57,"context_line":"        self.driver.configuration \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":8,"id":"c7306fa8_461823f9","line":54,"updated":"2024-08-07 14:36:10.000000000","message":"NVME_TCP","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"205a7552cce66cc847a9d6cf3d954f331e0da0f1","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                             override\u003dTrue, group\u003dconf.SHARED_CONF_GROUP)"},{"line_number":52,"context_line":"        self.driver.do_setup({})"},{"line_number":53,"context_line":"        self.assertEqual(self.driver.storage_protocol,"},{"line_number":54,"context_line":"                         constants.NVMEOF_VARIANT_2)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_validate_nvme_version_valid(self):"},{"line_number":57,"context_line":"        self.driver.configuration \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":8,"id":"29c133d9_bda72f95","line":54,"in_reply_to":"c7306fa8_461823f9","updated":"2024-08-19 09:54:02.000000000","message":"Done","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":32912,"name":"Pure Storage Third-Party CI","display_name":"Pure Storage Third-Party CI","email":"openstack-third-party-ci@purestorage.com","username":"purestorage-thirdparty-ci","status":"Doing CI things"},"change_message_id":"4c1ff54b4227152cfefd60019b236e0a8067f6fe","unresolved":true,"context_lines":[{"line_number":63,"context_line":"        ex \u003d self.assertRaises(exception.InvalidInput,"},{"line_number":64,"context_line":"                               self.driver._validate_nvme)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        self.assertIn(\"PowerFlex version 3.9 do not support NVMe-OF.\", ex.msg)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def test_validate_nvme_version_invalid_and_secondary_configured(self):"},{"line_number":69,"context_line":"        self.driver.configuration \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":8,"id":"5ffd1a45_9b9cd6cd","line":66,"updated":"2024-08-07 14:36:10.000000000","message":"NVMe-TCP","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"205a7552cce66cc847a9d6cf3d954f331e0da0f1","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        ex \u003d self.assertRaises(exception.InvalidInput,"},{"line_number":64,"context_line":"                               self.driver._validate_nvme)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        self.assertIn(\"PowerFlex version 3.9 do not support NVMe-OF.\", ex.msg)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def test_validate_nvme_version_invalid_and_secondary_configured(self):"},{"line_number":69,"context_line":"        self.driver.configuration \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":8,"id":"f798d8a7_b0a0319c","line":66,"in_reply_to":"5ffd1a45_9b9cd6cd","updated":"2024-08-19 09:54:02.000000000","message":"Done","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":32912,"name":"Pure Storage Third-Party CI","display_name":"Pure Storage Third-Party CI","email":"openstack-third-party-ci@purestorage.com","username":"purestorage-thirdparty-ci","status":"Doing CI things"},"change_message_id":"4c1ff54b4227152cfefd60019b236e0a8067f6fe","unresolved":true,"context_lines":[{"line_number":77,"context_line":"            self.driver._validate_nvme()"},{"line_number":78,"context_line":"        self.assertIn("},{"line_number":79,"context_line":"            \"PowerFlex do not support attaching \""},{"line_number":80,"context_line":"            \"replicated volumes to NVMe-OF hosts.\","},{"line_number":81,"context_line":"            str(logs.output))"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def test_initialize_connection(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"d4f66c1b_8ea3786a","line":80,"updated":"2024-08-07 14:36:10.000000000","message":"NVMe-TCP","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"205a7552cce66cc847a9d6cf3d954f331e0da0f1","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            self.driver._validate_nvme()"},{"line_number":78,"context_line":"        self.assertIn("},{"line_number":79,"context_line":"            \"PowerFlex do not support attaching \""},{"line_number":80,"context_line":"            \"replicated volumes to NVMe-OF hosts.\","},{"line_number":81,"context_line":"            str(logs.output))"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def test_initialize_connection(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"fc0efb29_facde59a","line":80,"in_reply_to":"d4f66c1b_8ea3786a","updated":"2024-08-19 09:54:02.000000000","message":"Done","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"6fb11fe6ea42c12811db3945d3ed73f5002b43cd","unresolved":true,"context_lines":[{"line_number":59,"context_line":"        self.driver.check_for_setup_error()"},{"line_number":60,"context_line":"        self.driver._validate_nvme.assert_called_once_with()"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def test__validate_nvme_version_success(self):"},{"line_number":63,"context_line":"        self.driver.configuration \u003d mock.MagicMock()"},{"line_number":64,"context_line":"        self.driver.configuration.safe_get.return_value \u003d True"},{"line_number":65,"context_line":"        self.driver.primary_client \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":17,"id":"721fa56e_a8bb6244","line":62,"range":{"start_line":62,"start_character":12,"end_line":62,"end_character":14},"updated":"2025-10-13 20:44:21.000000000","message":"Why two underscores in many of the test names?","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"ef942218133fa4c510ba67c998706d3b668f2660","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self.driver.check_for_setup_error()"},{"line_number":60,"context_line":"        self.driver._validate_nvme.assert_called_once_with()"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def test__validate_nvme_version_success(self):"},{"line_number":63,"context_line":"        self.driver.configuration \u003d mock.MagicMock()"},{"line_number":64,"context_line":"        self.driver.configuration.safe_get.return_value \u003d True"},{"line_number":65,"context_line":"        self.driver.primary_client \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":17,"id":"8d077f14_f3eed9c1","line":62,"range":{"start_line":62,"start_character":12,"end_line":62,"end_character":14},"in_reply_to":"721fa56e_a8bb6244","updated":"2025-10-20 06:39:15.000000000","message":"Those tests are for private method starting with `_`.","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"6fb11fe6ea42c12811db3945d3ed73f5002b43cd","unresolved":true,"context_lines":[{"line_number":102,"context_line":"        self.driver._initialize_connection.assert_called_once_with("},{"line_number":103,"context_line":"            self.volume, self.connector)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def test__initialize_connection(self):"},{"line_number":106,"context_line":"        self.driver._get_nvme_connection_properties \u003d mock.MagicMock("},{"line_number":107,"context_line":"            return_value\u003d\"connection_info\")"},{"line_number":108,"context_line":"        self.driver._create_host_and_attach \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":17,"id":"7cb4c288_df9177dd","line":105,"updated":"2025-10-13 20:44:21.000000000","message":"This test has the same name as the one on L97 (dup?).","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"ef942218133fa4c510ba67c998706d3b668f2660","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        self.driver._initialize_connection.assert_called_once_with("},{"line_number":103,"context_line":"            self.volume, self.connector)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def test__initialize_connection(self):"},{"line_number":106,"context_line":"        self.driver._get_nvme_connection_properties \u003d mock.MagicMock("},{"line_number":107,"context_line":"            return_value\u003d\"connection_info\")"},{"line_number":108,"context_line":"        self.driver._create_host_and_attach \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":17,"id":"ec457d3b_82f7e568","line":105,"in_reply_to":"7cb4c288_df9177dd","updated":"2025-10-20 06:39:15.000000000","message":"Not duplicate. They are testing methods `_initialize_connection` and `initialize_connection` respectively.","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"6fb11fe6ea42c12811db3945d3ed73f5002b43cd","unresolved":true,"context_lines":[{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    def test__terminate_connection_multiattached(self):"},{"line_number":255,"context_line":"        self.driver._is_multiattached_to_host \u003d mock.MagicMock("},{"line_number":256,"context_line":"            return_valure\u003dFalse)"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        self.driver._terminate_connection(self.volume, self.connector)"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"a3a07827_6b062b38","line":256,"range":{"start_line":256,"start_character":12,"end_line":256,"end_character":25},"updated":"2025-10-13 20:44:21.000000000","message":"First, this is a typo.\n\nI also think there\u0027s a mismatch between when _is_multiattached_to_host returns True or False, and whether L260 should assert query_host_by_nqn is called or NOT called. I think it should assert_not_called when _is_multiattached_to_host is True. You should also test both scenarios.","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"ef942218133fa4c510ba67c998706d3b668f2660","unresolved":false,"context_lines":[{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    def test__terminate_connection_multiattached(self):"},{"line_number":255,"context_line":"        self.driver._is_multiattached_to_host \u003d mock.MagicMock("},{"line_number":256,"context_line":"            return_valure\u003dFalse)"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        self.driver._terminate_connection(self.volume, self.connector)"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"8ebd94ef_a3b46915","line":256,"range":{"start_line":256,"start_character":12,"end_line":256,"end_character":25},"in_reply_to":"a3a07827_6b062b38","updated":"2025-10-20 06:39:15.000000000","message":"Corrected: `return_value\u003dTrue`.\n\nThe case that `_is_multiattached_to_host` returns False is covered by L225 `test__terminate_connection_success`.","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"}],"cinder/volume/drivers/dell_emc/powerflex/driver.py":[{"author":{"_account_id":31016,"name":"Ivan Pchelintsev","email":"i.pchelintsev@yadro.com","username":"pcheli"},"change_message_id":"2254baede7438971aa73ee833f1d8f3f913421cf","unresolved":true,"context_lines":[{"line_number":72,"context_line":"VOLUME_ALREADY_MAPPED_ERROR \u003d 81"},{"line_number":73,"context_line":"MIN_BWS_SCALING_SIZE \u003d 128"},{"line_number":74,"context_line":"POWERFLEX_MAX_OVERSUBSCRIPTION_RATIO \u003d 10.0"},{"line_number":75,"context_line":"POWERFLEX_VENDER_ID \u003d \"0x64B94E\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"@interface.volumedriver"}],"source_content_type":"text/x-python","patch_set":3,"id":"bba90adb_5efbfeef","line":75,"range":{"start_line":75,"start_character":10,"end_line":75,"end_character":16},"updated":"2024-03-22 08:58:27.000000000","message":"VENDOR","commit_id":"198405c7c2b862351d1470e2a3ba3554e7e811cf"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"b97a17e8958c4a03964785f0040e50230c26a2c2","unresolved":false,"context_lines":[{"line_number":72,"context_line":"VOLUME_ALREADY_MAPPED_ERROR \u003d 81"},{"line_number":73,"context_line":"MIN_BWS_SCALING_SIZE \u003d 128"},{"line_number":74,"context_line":"POWERFLEX_MAX_OVERSUBSCRIPTION_RATIO \u003d 10.0"},{"line_number":75,"context_line":"POWERFLEX_VENDER_ID \u003d \"0x64B94E\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"@interface.volumedriver"}],"source_content_type":"text/x-python","patch_set":3,"id":"aba1d2e7_19ff4124","line":75,"range":{"start_line":75,"start_character":10,"end_line":75,"end_character":16},"in_reply_to":"bba90adb_5efbfeef","updated":"2024-04-02 05:00:34.000000000","message":"Done","commit_id":"198405c7c2b862351d1470e2a3ba3554e7e811cf"},{"author":{"_account_id":32912,"name":"Pure Storage Third-Party CI","display_name":"Pure Storage Third-Party CI","email":"openstack-third-party-ci@purestorage.com","username":"purestorage-thirdparty-ci","status":"Doing CI things"},"change_message_id":"4c1ff54b4227152cfefd60019b236e0a8067f6fe","unresolved":true,"context_lines":[{"line_number":99,"context_line":"                  conversion of its type."},{"line_number":100,"context_line":"          3.5.7 - Report trim/discard support."},{"line_number":101,"context_line":"          3.5.8 - Added Cinder active/active support."},{"line_number":102,"context_line":"          4.0.0 - Add NVMe-OF support."},{"line_number":103,"context_line":"    \"\"\""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    VERSION \u003d \"4.0.0\""}],"source_content_type":"text/x-python","patch_set":8,"id":"96721a34_e7ed7b0b","line":102,"updated":"2024-08-07 14:36:10.000000000","message":"there are at least 3 variants of NVMe-oF (which is a generic term). I assume you are using NVMe-TCP based on the later changes. Please specify NVMe-TCP","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"205a7552cce66cc847a9d6cf3d954f331e0da0f1","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                  conversion of its type."},{"line_number":100,"context_line":"          3.5.7 - Report trim/discard support."},{"line_number":101,"context_line":"          3.5.8 - Added Cinder active/active support."},{"line_number":102,"context_line":"          4.0.0 - Add NVMe-OF support."},{"line_number":103,"context_line":"    \"\"\""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    VERSION \u003d \"4.0.0\""}],"source_content_type":"text/x-python","patch_set":8,"id":"b00c1f9d_786611fe","line":102,"in_reply_to":"96721a34_e7ed7b0b","updated":"2024-08-19 09:54:02.000000000","message":"Done","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":32912,"name":"Pure Storage Third-Party CI","display_name":"Pure Storage Third-Party CI","email":"openstack-third-party-ci@purestorage.com","username":"purestorage-thirdparty-ci","status":"Doing CI things"},"change_message_id":"4c1ff54b4227152cfefd60019b236e0a8067f6fe","unresolved":true,"context_lines":[{"line_number":211,"context_line":"                self.configuration.num_volume_device_scan_tries"},{"line_number":212,"context_line":"            )"},{"line_number":213,"context_line":"        else:"},{"line_number":214,"context_line":"            self.storage_protocol \u003d constants.NVMEOF_VARIANT_2"},{"line_number":215,"context_line":"        LOG.info(\"Storage protocol: %s.\", self.storage_protocol)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        self.primary_client \u003d rest_client.RestClient(self.configuration)"}],"source_content_type":"text/x-python","patch_set":8,"id":"e47878a2_5d945327","line":214,"updated":"2024-08-07 14:36:10.000000000","message":"There are more specific NVMe protocols available in ``constants``,ie NVME_TCP, NVME_ROCE and NVME_FC, so use NVME_TCP as that is the protocol you are supporting","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"205a7552cce66cc847a9d6cf3d954f331e0da0f1","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                self.configuration.num_volume_device_scan_tries"},{"line_number":212,"context_line":"            )"},{"line_number":213,"context_line":"        else:"},{"line_number":214,"context_line":"            self.storage_protocol \u003d constants.NVMEOF_VARIANT_2"},{"line_number":215,"context_line":"        LOG.info(\"Storage protocol: %s.\", self.storage_protocol)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        self.primary_client \u003d rest_client.RestClient(self.configuration)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9bf8c7e8_6a81befd","line":214,"in_reply_to":"e47878a2_5d945327","updated":"2024-08-19 09:54:02.000000000","message":"Done","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":32912,"name":"Pure Storage Third-Party CI","display_name":"Pure Storage Third-Party CI","email":"openstack-third-party-ci@purestorage.com","username":"purestorage-thirdparty-ci","status":"Doing CI things"},"change_message_id":"4c1ff54b4227152cfefd60019b236e0a8067f6fe","unresolved":true,"context_lines":[{"line_number":293,"context_line":"        if self.configuration.safe_get(options.POWERFLEX_NVME):"},{"line_number":294,"context_line":"            primary_version \u003d self.primary_client.query_rest_api_version()"},{"line_number":295,"context_line":"            if not flex_utils.version_gte(primary_version, \"4.0\"):"},{"line_number":296,"context_line":"                msg \u003d (_(\"PowerFlex version %s do not support NVMe-OF.\""},{"line_number":297,"context_line":"                         ) % primary_version)"},{"line_number":298,"context_line":"                raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":299,"context_line":"            if self.secondary_client.is_configured:"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f6f6603_1ce33d09","line":296,"updated":"2024-08-07 14:36:10.000000000","message":"nit: does not do\nnit: NVMe-TCP","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"205a7552cce66cc847a9d6cf3d954f331e0da0f1","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        if self.configuration.safe_get(options.POWERFLEX_NVME):"},{"line_number":294,"context_line":"            primary_version \u003d self.primary_client.query_rest_api_version()"},{"line_number":295,"context_line":"            if not flex_utils.version_gte(primary_version, \"4.0\"):"},{"line_number":296,"context_line":"                msg \u003d (_(\"PowerFlex version %s do not support NVMe-OF.\""},{"line_number":297,"context_line":"                         ) % primary_version)"},{"line_number":298,"context_line":"                raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":299,"context_line":"            if self.secondary_client.is_configured:"}],"source_content_type":"text/x-python","patch_set":8,"id":"61e6507a_cb80a5fc","line":296,"in_reply_to":"7f6f6603_1ce33d09","updated":"2024-08-19 09:54:02.000000000","message":"Done","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":32912,"name":"Pure Storage Third-Party CI","display_name":"Pure Storage Third-Party CI","email":"openstack-third-party-ci@purestorage.com","username":"purestorage-thirdparty-ci","status":"Doing CI things"},"change_message_id":"4c1ff54b4227152cfefd60019b236e0a8067f6fe","unresolved":true,"context_lines":[{"line_number":297,"context_line":"                         ) % primary_version)"},{"line_number":298,"context_line":"                raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":299,"context_line":"            if self.secondary_client.is_configured:"},{"line_number":300,"context_line":"                LOG.warning(\"PowerFlex do not support attaching \""},{"line_number":301,"context_line":"                            \"replicated volumes to NVMe-OF hosts.\")"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":8,"id":"648baf72_68c2c8eb","line":300,"updated":"2024-08-07 14:36:10.000000000","message":"nit: does not do\nnit: NVMe-TCP","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"205a7552cce66cc847a9d6cf3d954f331e0da0f1","unresolved":false,"context_lines":[{"line_number":297,"context_line":"                         ) % primary_version)"},{"line_number":298,"context_line":"                raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":299,"context_line":"            if self.secondary_client.is_configured:"},{"line_number":300,"context_line":"                LOG.warning(\"PowerFlex do not support attaching \""},{"line_number":301,"context_line":"                            \"replicated volumes to NVMe-OF hosts.\")"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":8,"id":"969bcbb5_d2f0ab35","line":300,"in_reply_to":"648baf72_68c2c8eb","updated":"2024-08-19 09:54:02.000000000","message":"Done","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":32912,"name":"Pure Storage Third-Party CI","display_name":"Pure Storage Third-Party CI","email":"openstack-third-party-ci@purestorage.com","username":"purestorage-thirdparty-ci","status":"Doing CI things"},"change_message_id":"4c1ff54b4227152cfefd60019b236e0a8067f6fe","unresolved":true,"context_lines":[{"line_number":960,"context_line":"    def _initialize_nvme_connection(self, vol_or_snap, connector):"},{"line_number":961,"context_line":"        \"\"\"Initialize connection and return connection info."},{"line_number":962,"context_line":""},{"line_number":963,"context_line":"        PowerFlex driver returns a driver_volume_type of \u0027nvmeof\u0027."},{"line_number":964,"context_line":"        \"\"\""},{"line_number":965,"context_line":"        nqn \u003d connector[\"nqn\"]"},{"line_number":966,"context_line":"        LOG.info("}],"source_content_type":"text/x-python","patch_set":8,"id":"37baab8e_bf4ff519","line":963,"updated":"2024-08-07 14:36:10.000000000","message":"nvme-tcp","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"205a7552cce66cc847a9d6cf3d954f331e0da0f1","unresolved":false,"context_lines":[{"line_number":960,"context_line":"    def _initialize_nvme_connection(self, vol_or_snap, connector):"},{"line_number":961,"context_line":"        \"\"\"Initialize connection and return connection info."},{"line_number":962,"context_line":""},{"line_number":963,"context_line":"        PowerFlex driver returns a driver_volume_type of \u0027nvmeof\u0027."},{"line_number":964,"context_line":"        \"\"\""},{"line_number":965,"context_line":"        nqn \u003d connector[\"nqn\"]"},{"line_number":966,"context_line":"        LOG.info("}],"source_content_type":"text/x-python","patch_set":8,"id":"81bc0f03_338528bf","line":963,"in_reply_to":"37baab8e_bf4ff519","updated":"2024-08-19 09:54:02.000000000","message":"Done","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":32912,"name":"Pure Storage Third-Party CI","display_name":"Pure Storage Third-Party CI","email":"openstack-third-party-ci@purestorage.com","username":"purestorage-thirdparty-ci","status":"Doing CI things"},"change_message_id":"4c1ff54b4227152cfefd60019b236e0a8067f6fe","unresolved":true,"context_lines":[{"line_number":1112,"context_line":"        \"\"\"Generate PowerFlex host name for connector."},{"line_number":1113,"context_line":""},{"line_number":1114,"context_line":"        :param connector: connection properties"},{"line_number":1115,"context_line":"        :param protocol: storage protocol (scaleio or nvmeof)"},{"line_number":1116,"context_line":"        :return: unique host name"},{"line_number":1117,"context_line":"        \"\"\""},{"line_number":1118,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"c77be3a6_a370fc56","line":1115,"updated":"2024-08-07 14:36:10.000000000","message":"nvme-tcp","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"205a7552cce66cc847a9d6cf3d954f331e0da0f1","unresolved":false,"context_lines":[{"line_number":1112,"context_line":"        \"\"\"Generate PowerFlex host name for connector."},{"line_number":1113,"context_line":""},{"line_number":1114,"context_line":"        :param connector: connection properties"},{"line_number":1115,"context_line":"        :param protocol: storage protocol (scaleio or nvmeof)"},{"line_number":1116,"context_line":"        :return: unique host name"},{"line_number":1117,"context_line":"        \"\"\""},{"line_number":1118,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc04c81_8a1fbe92","line":1115,"in_reply_to":"c77be3a6_a370fc56","updated":"2024-08-19 09:54:02.000000000","message":"Done","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"398f1524a1138e2048e415eba0d90d3bec1c6980","unresolved":true,"context_lines":[{"line_number":211,"context_line":"                self.configuration.num_volume_device_scan_tries"},{"line_number":212,"context_line":"            )"},{"line_number":213,"context_line":"        else:"},{"line_number":214,"context_line":"            self.storage_protocol \u003d constants.NVMEOF_VARIANT_2"},{"line_number":215,"context_line":"        LOG.info(\"Storage protocol: %s.\", self.storage_protocol)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        self.primary_client \u003d rest_client.RestClient(self.configuration)"}],"source_content_type":"text/x-python","patch_set":12,"id":"3c2f41dd_a6f8ef2c","line":214,"range":{"start_line":214,"start_character":36,"end_line":214,"end_character":62},"updated":"2024-08-30 22:39:49.000000000","message":"Is there a reason why you\u0027re using VARIANT_2 instead of just constants.NVMEOF ?  The option to enable it is a boolean, and I think you\u0027re mostly checking self.storage_protocol !\u003d constants.SCALEIO.  Not sure it really matters, since the manager checks for the variants, but it would be good to use the canonical form if possible.  I can\u0027t tell from the comment at line 963 whether the backend expects this form or not.\n\nAlso ... you had a discussion with Simon on PS8, and it looked like you agreed that you should be using constants.NVMEOF_TCP here, but apparently you decided not to.  Could you explain the reasoning behind your decision?","commit_id":"bca14743cbf7dcfd9283ba77120a025217cc43a6"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e0cb7a8835eb7e4e5eaaf0375097f79f30d2b9df","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                self.configuration.num_volume_device_scan_tries"},{"line_number":212,"context_line":"            )"},{"line_number":213,"context_line":"        else:"},{"line_number":214,"context_line":"            self.storage_protocol \u003d constants.NVMEOF_VARIANT_2"},{"line_number":215,"context_line":"        LOG.info(\"Storage protocol: %s.\", self.storage_protocol)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        self.primary_client \u003d rest_client.RestClient(self.configuration)"}],"source_content_type":"text/x-python","patch_set":12,"id":"ad4ea631_793aa282","line":214,"range":{"start_line":214,"start_character":36,"end_line":214,"end_character":62},"in_reply_to":"3c2f41dd_a6f8ef2c","updated":"2024-08-31 03:12:57.000000000","message":"Hi @rosmaita.fossdev@gmail.com,\n\nThanks for the comments!\n\n#1. It\u0027s just because VARIANT_2 is letters in lowercase and looks like a match for constants.SCALEIO.\nWill use the canonical form instead.\n\n#2. By design, OpenStack is using the storage type of NVMe-oF defined in constants.NVMEOF_VARIANTS. And the fabric being used is indicated by the transport type of NVMe-oF.\nThe constants.NVMEOF_TCP is not recognized as NVMe-oF by the manager.\nWhen I recalled above things, I reverted the change to \u0027storage_protocol\u0027.","commit_id":"bca14743cbf7dcfd9283ba77120a025217cc43a6"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"f2ed8fe3aef2bc17610df45062dc10a0654aaa49","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                self.configuration.num_volume_device_scan_tries"},{"line_number":212,"context_line":"            )"},{"line_number":213,"context_line":"        else:"},{"line_number":214,"context_line":"            self.storage_protocol \u003d constants.NVMEOF_VARIANT_2"},{"line_number":215,"context_line":"        LOG.info(\"Storage protocol: %s.\", self.storage_protocol)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        self.primary_client \u003d rest_client.RestClient(self.configuration)"}],"source_content_type":"text/x-python","patch_set":12,"id":"10e35af0_d55f2418","line":214,"range":{"start_line":214,"start_character":36,"end_line":214,"end_character":62},"in_reply_to":"ad4ea631_793aa282","updated":"2024-08-31 09:32:20.000000000","message":"Hi @rosmaita.fossdev@gmail.com,\n\nSorry, I forgot another constrain on protocol -- the \u0027driver_volume_type\u0027 in the connection properties returned by the volume driver.\nLine 982:             \"driver_volume_type\": self.storage_protocol,\n\nIn os-brick, the value of \u0027driver_volume_type\u0027 is the input parameter \u0027protocol\u0027 of InitiatorConnector factory method [1]. \nIn the factory method, it gets the mapped connector by protocol.upper() [2]. \nThe valid protocol value for NVMeOFConnector are \u0027NVME\u0027 and \u0027NVMEOF\u0027[3].\n\nAmong the values of constants.NVMEOF_VARIANTS, VARIANT_2 is the best choice for both \u0027storage_protocol\u0027 and \u0027driver_volume_type\u0027.\n\nI will revert the patchset 13. Hope you don\u0027t mind.\n\n[1] https://opendev.org/openstack/os-brick/src/branch/master/os_brick/initiator/connector.py#L272\n[2] https://opendev.org/openstack/os-brick/src/branch/master/os_brick/initiator/connector.py#L301\n[3] https://opendev.org/openstack/os-brick/src/branch/master/os_brick/initiator/connector.py#L111","commit_id":"bca14743cbf7dcfd9283ba77120a025217cc43a6"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d18c286c1ce126dbed92f3f0bd427d82aba16f2f","unresolved":true,"context_lines":[{"line_number":73,"context_line":"VOLUME_ALREADY_MAPPED_ERROR \u003d 81"},{"line_number":74,"context_line":"MIN_BWS_SCALING_SIZE \u003d 128"},{"line_number":75,"context_line":"POWERFLEX_MAX_OVERSUBSCRIPTION_RATIO \u003d 10.0"},{"line_number":76,"context_line":"POWERFLEX_VENDOR_ID \u003d \"0x64B94E\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"@interface.volumedriver"}],"source_content_type":"text/x-python","patch_set":14,"id":"125c92b9_422386d6","line":76,"range":{"start_line":76,"start_character":23,"end_line":76,"end_character":31},"updated":"2024-12-06 09:45:40.000000000","message":"is this going to be a constant during upgrades on storage side? otherwise we can make it configurable","commit_id":"292c2f103d86771f77339dec16cf9cfea6ccf50a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"41c2013d167b2c422d91bd0668c01b6a76798d99","unresolved":false,"context_lines":[{"line_number":73,"context_line":"VOLUME_ALREADY_MAPPED_ERROR \u003d 81"},{"line_number":74,"context_line":"MIN_BWS_SCALING_SIZE \u003d 128"},{"line_number":75,"context_line":"POWERFLEX_MAX_OVERSUBSCRIPTION_RATIO \u003d 10.0"},{"line_number":76,"context_line":"POWERFLEX_VENDOR_ID \u003d \"0x64B94E\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"@interface.volumedriver"}],"source_content_type":"text/x-python","patch_set":14,"id":"33dad1ba_e3dc6ab9","line":76,"range":{"start_line":76,"start_character":23,"end_line":76,"end_character":31},"in_reply_to":"125c92b9_422386d6","updated":"2025-01-07 09:12:06.000000000","message":"It\u0027s a constant and won\u0027t change.","commit_id":"292c2f103d86771f77339dec16cf9cfea6ccf50a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d18c286c1ce126dbed92f3f0bd427d82aba16f2f","unresolved":true,"context_lines":[{"line_number":211,"context_line":"                self.configuration.num_volume_device_scan_tries"},{"line_number":212,"context_line":"            )"},{"line_number":213,"context_line":"        else:"},{"line_number":214,"context_line":"            self.storage_protocol \u003d constants.NVMEOF_VARIANT_2"},{"line_number":215,"context_line":"        LOG.info(\"Storage protocol: %s.\", self.storage_protocol)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        self.primary_client \u003d rest_client.RestClient(self.configuration)"}],"source_content_type":"text/x-python","patch_set":14,"id":"2b6e3173_0df44f0a","line":214,"range":{"start_line":214,"start_character":46,"end_line":214,"end_character":62},"updated":"2024-12-06 09:45:40.000000000","message":"IIUC we are going to support NVMe over TCP so isn\u0027t NVMEOF_TCP more accurate?","commit_id":"292c2f103d86771f77339dec16cf9cfea6ccf50a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"41c2013d167b2c422d91bd0668c01b6a76798d99","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                self.configuration.num_volume_device_scan_tries"},{"line_number":212,"context_line":"            )"},{"line_number":213,"context_line":"        else:"},{"line_number":214,"context_line":"            self.storage_protocol \u003d constants.NVMEOF_VARIANT_2"},{"line_number":215,"context_line":"        LOG.info(\"Storage protocol: %s.\", self.storage_protocol)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        self.primary_client \u003d rest_client.RestClient(self.configuration)"}],"source_content_type":"text/x-python","patch_set":14,"id":"65581052_8198bee9","line":214,"range":{"start_line":214,"start_character":46,"end_line":214,"end_character":62},"in_reply_to":"2b6e3173_0df44f0a","updated":"2025-01-07 09:12:06.000000000","message":"Cinder volume manager[1] and scheduler[2] can only recognize storage protocol NVMe-oF in one of below forms[3]: \n    NVMEOF_VARIANTS \u003d [NVMEOF, NVMEOF_VARIANT_1, NVMEOF_VARIANT_2]\n\n    \n[1] https://opendev.org/openstack/cinder/src/branch/master/cinder/volume/manager.py#L897\n\n[2] https://opendev.org/openstack/cinder/src/branch/master/cinder/scheduler/host_manager.py#L390\n\n[3] https://opendev.org/openstack/cinder/src/branch/master/cinder/common/constants.py#L62","commit_id":"292c2f103d86771f77339dec16cf9cfea6ccf50a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d18c286c1ce126dbed92f3f0bd427d82aba16f2f","unresolved":true,"context_lines":[{"line_number":902,"context_line":"        self._get_client().remove_volume(snapshot.provider_id)"},{"line_number":903,"context_line":""},{"line_number":904,"context_line":"    def initialize_connection(self, volume, connector, **kwargs):"},{"line_number":905,"context_line":"        if self.storage_protocol \u003d\u003d constants.SCALEIO:"},{"line_number":906,"context_line":"            res \u003d self._initialize_connection(volume, connector, volume.size)"},{"line_number":907,"context_line":"        else:"},{"line_number":908,"context_line":"            res \u003d self._initialize_nvme_connection(volume, connector)"},{"line_number":909,"context_line":"        # TODO: Should probably be enabled for SSDs as well"},{"line_number":910,"context_line":"        # It is recommended not to trim volumes that contain snapshots as the"},{"line_number":911,"context_line":"        # logical capacity may not shrink."}],"source_content_type":"text/x-python","patch_set":14,"id":"adcca2af_b4576257","line":908,"range":{"start_line":905,"start_character":8,"end_line":908,"end_character":69},"updated":"2024-12-06 09:45:40.000000000","message":"is it really necessary to embed this logic in the same driver class?\nGenerally we create a new driver per protocol i.e. a new PowerFlexNVMeDriver class like Pure[1] did\n\nAlthough the idea is not new as storpool also wants similar implementation[2] but it is generally discouraged by our design and should only be done for specific use cases.\n\n[1] https://github.com/openstack/cinder/commit/dfbcca0d8b03050d2ca56984605c1dc27353ecc3\n[2] https://review.opendev.org/c/openstack/cinder/+/847536","commit_id":"292c2f103d86771f77339dec16cf9cfea6ccf50a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"34df4332c1e14ee4dcd2fa76119e21ea8fe98d3f","unresolved":false,"context_lines":[{"line_number":902,"context_line":"        self._get_client().remove_volume(snapshot.provider_id)"},{"line_number":903,"context_line":""},{"line_number":904,"context_line":"    def initialize_connection(self, volume, connector, **kwargs):"},{"line_number":905,"context_line":"        if self.storage_protocol \u003d\u003d constants.SCALEIO:"},{"line_number":906,"context_line":"            res \u003d self._initialize_connection(volume, connector, volume.size)"},{"line_number":907,"context_line":"        else:"},{"line_number":908,"context_line":"            res \u003d self._initialize_nvme_connection(volume, connector)"},{"line_number":909,"context_line":"        # TODO: Should probably be enabled for SSDs as well"},{"line_number":910,"context_line":"        # It is recommended not to trim volumes that contain snapshots as the"},{"line_number":911,"context_line":"        # logical capacity may not shrink."}],"source_content_type":"text/x-python","patch_set":14,"id":"7ff50c9f_92765f10","line":908,"range":{"start_line":905,"start_character":8,"end_line":908,"end_character":69},"in_reply_to":"adcca2af_b4576257","updated":"2025-01-28 04:13:58.000000000","message":"Done","commit_id":"292c2f103d86771f77339dec16cf9cfea6ccf50a"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"29b4d2f3f1f2ce10b5ad37ded3489cec5b232740","unresolved":true,"context_lines":[{"line_number":1780,"context_line":"    def initialize_connection_snapshot(self, snapshot, connector, **kwargs):"},{"line_number":1781,"context_line":"        \"\"\"Initialize connection and return connection info.\"\"\""},{"line_number":1782,"context_line":""},{"line_number":1783,"context_line":"        return self._initialize_connection(snapshot, connector, )"},{"line_number":1784,"context_line":""},{"line_number":1785,"context_line":"    def terminate_connection_snapshot(self, snapshot, connector, **kwargs):"},{"line_number":1786,"context_line":"        \"\"\"Terminate connection to snapshot.\"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"d247d7b1_53b60a9a","line":1783,"range":{"start_line":1783,"start_character":62,"end_line":1783,"end_character":64},"updated":"2025-08-26 21:29:32.000000000","message":"nit: the \", \" should be removed.\n\nAlso, could you handle this like the \u0027terminate_connection_snapshot\u0027 function on L1785 and not use separate private \u0027_initialize_connection\u0027 functions in the derived classes? In other words, change L1783 to raise NotImplementedError and have the derived classes override it instead of switching to private function names (with leading \u0027_\u0027 underscore).","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"52ed00131589709a5461ea4c0a811a085d9732df","unresolved":false,"context_lines":[{"line_number":1780,"context_line":"    def initialize_connection_snapshot(self, snapshot, connector, **kwargs):"},{"line_number":1781,"context_line":"        \"\"\"Initialize connection and return connection info.\"\"\""},{"line_number":1782,"context_line":""},{"line_number":1783,"context_line":"        return self._initialize_connection(snapshot, connector, )"},{"line_number":1784,"context_line":""},{"line_number":1785,"context_line":"    def terminate_connection_snapshot(self, snapshot, connector, **kwargs):"},{"line_number":1786,"context_line":"        \"\"\"Terminate connection to snapshot.\"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"6747fcf0_db10c239","line":1783,"range":{"start_line":1783,"start_character":62,"end_line":1783,"end_character":64},"in_reply_to":"d247d7b1_53b60a9a","updated":"2025-09-30 09:42:52.000000000","message":"1. The \",\" was removed.\n\n2. \nThe private method \u0027_initialize_connection\u0027 is invoked by \u0027initialize_connection\u0027 and \u0027initialize_connection_snapshot\u0027. And now, the private method \u0027_terminate_connection\u0027 is invoked by \u0027terminate_connection\u0027 and \u0027terminate_connection_snapshot\u0027. It seems we still need to override the private methods.","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"29b4d2f3f1f2ce10b5ad37ded3489cec5b232740","unresolved":true,"context_lines":[{"line_number":1933,"context_line":"        LOG.info(\"Terminate connection for %(vol_id)s to SDC at %(sdc)s.\","},{"line_number":1934,"context_line":"                 {\"vol_id\": volume_or_snap.id, \"sdc\": ip})"},{"line_number":1935,"context_line":""},{"line_number":1936,"context_line":"    def copy_image_to_volume(self, context, volume, image_service, image_id,"},{"line_number":1937,"context_line":"                             disable_sparse\u003dFalse):"},{"line_number":1938,"context_line":"        \"\"\"Fetch image from image service and write it to volume.\"\"\""},{"line_number":1939,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"80bba56a_e9a63d4b","line":1936,"updated":"2025-08-26 21:29:32.000000000","message":"You moved this and L1958 from the base class, but I don\u0027t see any mention of the functions in the PowerFlexNVMeDriver class. In fact, I can\u0027t find any code that calls either of the functions, which suggests the functions could be eliminated.","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"52ed00131589709a5461ea4c0a811a085d9732df","unresolved":false,"context_lines":[{"line_number":1933,"context_line":"        LOG.info(\"Terminate connection for %(vol_id)s to SDC at %(sdc)s.\","},{"line_number":1934,"context_line":"                 {\"vol_id\": volume_or_snap.id, \"sdc\": ip})"},{"line_number":1935,"context_line":""},{"line_number":1936,"context_line":"    def copy_image_to_volume(self, context, volume, image_service, image_id,"},{"line_number":1937,"context_line":"                             disable_sparse\u003dFalse):"},{"line_number":1938,"context_line":"        \"\"\"Fetch image from image service and write it to volume.\"\"\""},{"line_number":1939,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"7d7c5269_73d6086b","line":1936,"in_reply_to":"80bba56a_e9a63d4b","updated":"2025-09-30 09:42:52.000000000","message":"The functions were removed in patch [1].\n\n[1] https://review.opendev.org/c/openstack/cinder/+/952800","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"29b4d2f3f1f2ce10b5ad37ded3489cec5b232740","unresolved":true,"context_lines":[{"line_number":1996,"context_line":"    def do_setup(self, context):"},{"line_number":1997,"context_line":"        super(PowerFlexNVMeDriver, self).do_setup(context)"},{"line_number":1998,"context_line":""},{"line_number":1999,"context_line":"        self.storage_protocol \u003d constants.NVMEOF_VARIANT_2"},{"line_number":2000,"context_line":"        LOG.info(\"Storage protocol: %s.\", self.storage_protocol)"},{"line_number":2001,"context_line":""},{"line_number":2002,"context_line":"    def check_for_setup_error(self):"}],"source_content_type":"text/x-python","patch_set":15,"id":"b8be3429_dff471f0","line":1999,"updated":"2025-08-26 21:29:32.000000000","message":"Why this one? I would think you\u0027d want to specify something more specific, like NVMEOF_TCP, especially because you mention it in other log messages. And if you really want to use the generic NVMe-oF name, then why choose VARIANT_2?","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"a5f2fdcbace7ef84b7d12a4f3343ef8988dfa609","unresolved":false,"context_lines":[{"line_number":1996,"context_line":"    def do_setup(self, context):"},{"line_number":1997,"context_line":"        super(PowerFlexNVMeDriver, self).do_setup(context)"},{"line_number":1998,"context_line":""},{"line_number":1999,"context_line":"        self.storage_protocol \u003d constants.NVMEOF_VARIANT_2"},{"line_number":2000,"context_line":"        LOG.info(\"Storage protocol: %s.\", self.storage_protocol)"},{"line_number":2001,"context_line":""},{"line_number":2002,"context_line":"    def check_for_setup_error(self):"}],"source_content_type":"text/x-python","patch_set":15,"id":"d19940c5_0b2825b8","line":1999,"in_reply_to":"b8be3429_dff471f0","updated":"2025-09-30 12:44:31.000000000","message":"The value \u0027NVMe-TCP\u0027 for \u0027storage_protocol\u0027 is not recognized as \u0027NVMe-oF\u0027 by codes like [1][2], which should be ruled out.\n\nPreviously, I chose \u0027NVMEOF_VARIANT_2\u0027 to be consistent with \u0027driver_volume_type\u0027 returned to \u0027os-brick\u0027.\n\nNow per the notes[3], we must use non variant versions.\n\n[1] https://opendev.org/openstack/cinder/src/branch/master/cinder/volume/manager.py#L897\n[2] https://opendev.org/openstack/cinder/src/branch/master/cinder/scheduler/host_manager.py#L392\n[3] https://opendev.org/openstack/cinder/src/branch/master/cinder/interface/volume_driver.py#L91","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"29b4d2f3f1f2ce10b5ad37ded3489cec5b232740","unresolved":true,"context_lines":[{"line_number":2009,"context_line":"        if not flex_utils.version_gte(primary_version, \"4.0\"):"},{"line_number":2010,"context_line":"            msg \u003d (_(\"PowerFlex version %s does not support NVMe-TCP.\""},{"line_number":2011,"context_line":"                     ) % primary_version)"},{"line_number":2012,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":2013,"context_line":"        if self.secondary_client.is_configured:"},{"line_number":2014,"context_line":"            LOG.warning(\"PowerFlex does not support attaching \""},{"line_number":2015,"context_line":"                        \"replicated volumes to NVMe-TCP hosts.\")"}],"source_content_type":"text/x-python","patch_set":15,"id":"40e77899_5b77665f","line":2012,"updated":"2025-08-26 21:29:32.000000000","message":"Raising VolumeDriverException feels more appropriate then InvalidInput, especially when it\u0027s not an input supplied by the configuration.","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"52ed00131589709a5461ea4c0a811a085d9732df","unresolved":false,"context_lines":[{"line_number":2009,"context_line":"        if not flex_utils.version_gte(primary_version, \"4.0\"):"},{"line_number":2010,"context_line":"            msg \u003d (_(\"PowerFlex version %s does not support NVMe-TCP.\""},{"line_number":2011,"context_line":"                     ) % primary_version)"},{"line_number":2012,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":2013,"context_line":"        if self.secondary_client.is_configured:"},{"line_number":2014,"context_line":"            LOG.warning(\"PowerFlex does not support attaching \""},{"line_number":2015,"context_line":"                        \"replicated volumes to NVMe-TCP hosts.\")"}],"source_content_type":"text/x-python","patch_set":15,"id":"c11e21fe_1be056b2","line":2012,"in_reply_to":"40e77899_5b77665f","updated":"2025-09-30 09:42:52.000000000","message":"Done","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"29b4d2f3f1f2ce10b5ad37ded3489cec5b232740","unresolved":true,"context_lines":[{"line_number":2011,"context_line":"                     ) % primary_version)"},{"line_number":2012,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":2013,"context_line":"        if self.secondary_client.is_configured:"},{"line_number":2014,"context_line":"            LOG.warning(\"PowerFlex does not support attaching \""},{"line_number":2015,"context_line":"                        \"replicated volumes to NVMe-TCP hosts.\")"},{"line_number":2016,"context_line":""},{"line_number":2017,"context_line":"    def _initialize_connection(self, vol_or_snap, connector):"}],"source_content_type":"text/x-python","patch_set":15,"id":"48fa4320_679a4ac2","line":2014,"updated":"2025-08-26 21:29:32.000000000","message":"This sounds like an invalid configuration, so wouldn\u0027t this be an appropriate place to raise InvalidInput?","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"52ed00131589709a5461ea4c0a811a085d9732df","unresolved":false,"context_lines":[{"line_number":2011,"context_line":"                     ) % primary_version)"},{"line_number":2012,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":2013,"context_line":"        if self.secondary_client.is_configured:"},{"line_number":2014,"context_line":"            LOG.warning(\"PowerFlex does not support attaching \""},{"line_number":2015,"context_line":"                        \"replicated volumes to NVMe-TCP hosts.\")"},{"line_number":2016,"context_line":""},{"line_number":2017,"context_line":"    def _initialize_connection(self, vol_or_snap, connector):"}],"source_content_type":"text/x-python","patch_set":15,"id":"8682743b_ee58bf75","line":2014,"in_reply_to":"48fa4320_679a4ac2","updated":"2025-09-30 09:42:52.000000000","message":"Done","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"29b4d2f3f1f2ce10b5ad37ded3489cec5b232740","unresolved":true,"context_lines":[{"line_number":2021,"context_line":"        \"\"\""},{"line_number":2022,"context_line":"        nqn \u003d connector[\"nqn\"]"},{"line_number":2023,"context_line":"        LOG.info("},{"line_number":2024,"context_line":"            \"Initialize connection for %(vol_id)s \""},{"line_number":2025,"context_line":"            \"to initiator %(initiator)s.\","},{"line_number":2026,"context_line":"            {\"vol_id\": vol_or_snap.id, \"initiator\": nqn})"},{"line_number":2027,"context_line":"        self._create_host_and_attach(connector, vol_or_snap)"}],"source_content_type":"text/x-python","patch_set":15,"id":"6f265704_8954ff88","line":2024,"updated":"2025-08-26 21:29:32.000000000","message":"This is just a minor suggestion, but it might be useful to mention \"NVMe\" in the log message for any operation related to volume attachments.","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"52ed00131589709a5461ea4c0a811a085d9732df","unresolved":false,"context_lines":[{"line_number":2021,"context_line":"        \"\"\""},{"line_number":2022,"context_line":"        nqn \u003d connector[\"nqn\"]"},{"line_number":2023,"context_line":"        LOG.info("},{"line_number":2024,"context_line":"            \"Initialize connection for %(vol_id)s \""},{"line_number":2025,"context_line":"            \"to initiator %(initiator)s.\","},{"line_number":2026,"context_line":"            {\"vol_id\": vol_or_snap.id, \"initiator\": nqn})"},{"line_number":2027,"context_line":"        self._create_host_and_attach(connector, vol_or_snap)"}],"source_content_type":"text/x-python","patch_set":15,"id":"b2eda75a_4bb15320","line":2024,"in_reply_to":"6f265704_8954ff88","updated":"2025-09-30 09:42:52.000000000","message":"Done","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"29b4d2f3f1f2ce10b5ad37ded3489cec5b232740","unresolved":true,"context_lines":[{"line_number":2034,"context_line":"        :return: connection properties"},{"line_number":2035,"context_line":"        \"\"\""},{"line_number":2036,"context_line":"        portals, system_id, system_nqn \u003d self._get_nvme_targets()"},{"line_number":2037,"context_line":"        target_portals \u003d [(portal, 4420, \"tcp\") for portal in portals]"},{"line_number":2038,"context_line":"        return {"},{"line_number":2039,"context_line":"            \"driver_volume_type\": self.storage_protocol,"},{"line_number":2040,"context_line":"            \"data\": {"}],"source_content_type":"text/x-python","patch_set":15,"id":"15904390_011908de","line":2037,"range":{"start_line":2037,"start_character":35,"end_line":2037,"end_character":39},"updated":"2025-08-26 21:29:32.000000000","message":"This is OK as long as you agree it isn\u0027t configurable on the PowerFlex itself.","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"52ed00131589709a5461ea4c0a811a085d9732df","unresolved":false,"context_lines":[{"line_number":2034,"context_line":"        :return: connection properties"},{"line_number":2035,"context_line":"        \"\"\""},{"line_number":2036,"context_line":"        portals, system_id, system_nqn \u003d self._get_nvme_targets()"},{"line_number":2037,"context_line":"        target_portals \u003d [(portal, 4420, \"tcp\") for portal in portals]"},{"line_number":2038,"context_line":"        return {"},{"line_number":2039,"context_line":"            \"driver_volume_type\": self.storage_protocol,"},{"line_number":2040,"context_line":"            \"data\": {"}],"source_content_type":"text/x-python","patch_set":15,"id":"25c3712b_5ad65f93","line":2037,"range":{"start_line":2037,"start_character":35,"end_line":2037,"end_character":39},"in_reply_to":"15904390_011908de","updated":"2025-09-30 09:42:52.000000000","message":"Done","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"29b4d2f3f1f2ce10b5ad37ded3489cec5b232740","unresolved":true,"context_lines":[{"line_number":2209,"context_line":"        self._detach_volume_from_host(volume_or_snap, host_id)"},{"line_number":2210,"context_line":""},{"line_number":2211,"context_line":"    @staticmethod"},{"line_number":2212,"context_line":"    def _is_multiattached_to_host(volume_attachment, host_name):"},{"line_number":2213,"context_line":"        \"\"\"Check if volume is attached to multiple instances on one host."},{"line_number":2214,"context_line":""},{"line_number":2215,"context_line":"        When multiattach is enabled, a volume could be attached to two or more"}],"source_content_type":"text/x-python","patch_set":15,"id":"80a7a9d9_c8542d01","line":2212,"updated":"2025-08-26 21:29:32.000000000","message":"This should have a synchronization lock or else you\u0027ll have a race condition when multiple connections are being terminated at the same time.","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"52ed00131589709a5461ea4c0a811a085d9732df","unresolved":false,"context_lines":[{"line_number":2209,"context_line":"        self._detach_volume_from_host(volume_or_snap, host_id)"},{"line_number":2210,"context_line":""},{"line_number":2211,"context_line":"    @staticmethod"},{"line_number":2212,"context_line":"    def _is_multiattached_to_host(volume_attachment, host_name):"},{"line_number":2213,"context_line":"        \"\"\"Check if volume is attached to multiple instances on one host."},{"line_number":2214,"context_line":""},{"line_number":2215,"context_line":"        When multiattach is enabled, a volume could be attached to two or more"}],"source_content_type":"text/x-python","patch_set":15,"id":"83dcf042_4c281e6b","line":2212,"in_reply_to":"80a7a9d9_c8542d01","updated":"2025-09-30 09:42:52.000000000","message":"Done","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"6fb11fe6ea42c12811db3945d3ed73f5002b43cd","unresolved":true,"context_lines":[{"line_number":2040,"context_line":"        \"\"\"Initialize connection and return connection info.\"\"\""},{"line_number":2041,"context_line":""},{"line_number":2042,"context_line":"        try:"},{"line_number":2043,"context_line":"            vol_size \u003d snapshot.volume_size"},{"line_number":2044,"context_line":"        except Exception:"},{"line_number":2045,"context_line":"            vol_size \u003d None"},{"line_number":2046,"context_line":"        return self._initialize_connection(snapshot, connector, vol_size)"}],"source_content_type":"text/x-python","patch_set":17,"id":"c4a51afe_41487bae","side":"PARENT","line":2043,"updated":"2025-10-13 20:44:21.000000000","message":"Why might this throw an exception? If it might be AttributeError then this should work:\n\n        vol_size \u003d getattr(snapshot, \u0027volume_size\u0027, None)","commit_id":"8064195521f9f511f630ff63b5dde1e88ff53e18"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"b692ddb09f363fd3ea9fa420c4ab0230bc66d4e5","unresolved":false,"context_lines":[{"line_number":2040,"context_line":"        \"\"\"Initialize connection and return connection info.\"\"\""},{"line_number":2041,"context_line":""},{"line_number":2042,"context_line":"        try:"},{"line_number":2043,"context_line":"            vol_size \u003d snapshot.volume_size"},{"line_number":2044,"context_line":"        except Exception:"},{"line_number":2045,"context_line":"            vol_size \u003d None"},{"line_number":2046,"context_line":"        return self._initialize_connection(snapshot, connector, vol_size)"}],"source_content_type":"text/x-python","patch_set":17,"id":"3ab896c0_4d5f9651","side":"PARENT","line":2043,"in_reply_to":"c4a51afe_41487bae","updated":"2025-10-20 06:41:52.000000000","message":"Done","commit_id":"8064195521f9f511f630ff63b5dde1e88ff53e18"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"6fb11fe6ea42c12811db3945d3ed73f5002b43cd","unresolved":true,"context_lines":[{"line_number":949,"context_line":"        raise NotImplementedError"},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"    @staticmethod"},{"line_number":952,"context_line":"    @coordination.synchronized(\"PowerFlex-multiattached-{host_name}\")"},{"line_number":953,"context_line":"    def _is_multiattached_to_host(volume_attachment, host_name):"},{"line_number":954,"context_line":"        \"\"\"Check if volume is attached to multiple instances on one host."},{"line_number":955,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"995e47de_40c7e4ac","line":952,"updated":"2025-10-13 20:44:21.000000000","message":"This alone is not sufficient to address my original concern. First, the lock should be unique to the volume, not the host. But the lock needs to span the entire terminate_connection process.\n\nThe scenario we\u0027re worried about is when a nova compute node has multiple instances each attached to the same multiattach volume, and the volume is detached from both instances simultaneously.\n- The first request to arrive should NOT terminate the connection, but the volume detachment needs to proceed to completion. The call to _is_multiattached_to_host should return True\n- The second request needs to block long enough for the first request to complete in order for the call to _is_multiattached_to_host to return False.\n\nJust locking the _is_multiattached_to_host function itself won\u0027t work because it\u0027s possible for both requests to get a True response because the first request hasn\u0027t finished removing its attachment. And if both calls to _is_multiattached_to_host return True then the volume\u0027s host connection won\u0027t be terminated.\n\nNow, having said all that ^^, I looked at other drivers and think some may be vulnerable to this problem. We may need to investigate a general (non driver specific) solution to a general problem, in which case I wouldn\u0027t want to hold up this patch. I\u0027d like to hear more on this from the core team.","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"a030e62ed9a2b5f60e890f7371c1d6cff9288ba0","unresolved":false,"context_lines":[{"line_number":949,"context_line":"        raise NotImplementedError"},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"    @staticmethod"},{"line_number":952,"context_line":"    @coordination.synchronized(\"PowerFlex-multiattached-{host_name}\")"},{"line_number":953,"context_line":"    def _is_multiattached_to_host(volume_attachment, host_name):"},{"line_number":954,"context_line":"        \"\"\"Check if volume is attached to multiple instances on one host."},{"line_number":955,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"85146254_12bcef9b","line":952,"in_reply_to":"369a7778_613c419d","updated":"2025-10-22 20:06:48.000000000","message":"Ah, I somehow forgot about that lock, thanks.","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"e7c85339529444ab68d0824bc91cc84126d7d8ef","unresolved":true,"context_lines":[{"line_number":949,"context_line":"        raise NotImplementedError"},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"    @staticmethod"},{"line_number":952,"context_line":"    @coordination.synchronized(\"PowerFlex-multiattached-{host_name}\")"},{"line_number":953,"context_line":"    def _is_multiattached_to_host(volume_attachment, host_name):"},{"line_number":954,"context_line":"        \"\"\"Check if volume is attached to multiple instances on one host."},{"line_number":955,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"b8f6eb57_1399458f","line":952,"in_reply_to":"995e47de_40c7e4ac","updated":"2025-10-16 14:15:04.000000000","message":"Hi @abishop@redhat.com,\n\nI think the volume detach lock[1] in cinder manager is what you are looking for.\n\n[1] https://opendev.org/openstack/cinder/src/commit/eb3666620dc455a39f005b95d7f286ba17896a9f/cinder/volume/manager.py#L1487","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"ef942218133fa4c510ba67c998706d3b668f2660","unresolved":false,"context_lines":[{"line_number":949,"context_line":"        raise NotImplementedError"},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"    @staticmethod"},{"line_number":952,"context_line":"    @coordination.synchronized(\"PowerFlex-multiattached-{host_name}\")"},{"line_number":953,"context_line":"    def _is_multiattached_to_host(volume_attachment, host_name):"},{"line_number":954,"context_line":"        \"\"\"Check if volume is attached to multiple instances on one host."},{"line_number":955,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"369a7778_613c419d","line":952,"in_reply_to":"b8f6eb57_1399458f","updated":"2025-10-20 06:39:15.000000000","message":"Done","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"6fb11fe6ea42c12811db3945d3ed73f5002b43cd","unresolved":true,"context_lines":[{"line_number":2099,"context_line":"    def do_setup(self, context):"},{"line_number":2100,"context_line":"        super(PowerFlexNVMeDriver, self).do_setup(context)"},{"line_number":2101,"context_line":""},{"line_number":2102,"context_line":"        self.storage_protocol \u003d constants.NVMEOF"},{"line_number":2103,"context_line":"        LOG.info(\"Storage protocol: %s.\", self.storage_protocol)"},{"line_number":2104,"context_line":""},{"line_number":2105,"context_line":"    def check_for_setup_error(self):"}],"source_content_type":"text/x-python","patch_set":17,"id":"37fea60c_f712799a","line":2102,"updated":"2025-10-13 20:44:21.000000000","message":"We need to return to an earlier topic, and that is I think the storage_protocol should be constants.NVMEOF_TCP. I understand os-brick doesn\u0027t recognize this value, but see my comment at L2149. Basically, the storage_protocol and driver_volume_type are similar but not identical.","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"6f2c26e9aca7455b48f3bc4d67a9b2eb0e0af960","unresolved":false,"context_lines":[{"line_number":2099,"context_line":"    def do_setup(self, context):"},{"line_number":2100,"context_line":"        super(PowerFlexNVMeDriver, self).do_setup(context)"},{"line_number":2101,"context_line":""},{"line_number":2102,"context_line":"        self.storage_protocol \u003d constants.NVMEOF"},{"line_number":2103,"context_line":"        LOG.info(\"Storage protocol: %s.\", self.storage_protocol)"},{"line_number":2104,"context_line":""},{"line_number":2105,"context_line":"    def check_for_setup_error(self):"}],"source_content_type":"text/x-python","patch_set":17,"id":"e9a5fa9d_e272cea2","line":2102,"in_reply_to":"37fea60c_f712799a","updated":"2025-10-14 13:29:41.000000000","message":"Hi @abishop@redhat.com,\n\nThe value \u0027constants.NVMEOF_TCP\u0027 of \u0027storage_protocol\u0027 is not recognized by cinder volume manager[1] and scheduler[2]: \n\n[1] https://opendev.org/openstack/cinder/src/branch/master/cinder/volume/manager.py#L897\n[2] https://opendev.org/openstack/cinder/src/branch/master/cinder/scheduler/host_manager.py#L392","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"a030e62ed9a2b5f60e890f7371c1d6cff9288ba0","unresolved":true,"context_lines":[{"line_number":2099,"context_line":"    def do_setup(self, context):"},{"line_number":2100,"context_line":"        super(PowerFlexNVMeDriver, self).do_setup(context)"},{"line_number":2101,"context_line":""},{"line_number":2102,"context_line":"        self.storage_protocol \u003d constants.NVMEOF"},{"line_number":2103,"context_line":"        LOG.info(\"Storage protocol: %s.\", self.storage_protocol)"},{"line_number":2104,"context_line":""},{"line_number":2105,"context_line":"    def check_for_setup_error(self):"}],"source_content_type":"text/x-python","patch_set":17,"id":"6286848c_44cd6a49","line":2102,"in_reply_to":"5c8f23d7_4188228e","updated":"2025-10-22 20:06:48.000000000","message":"I did more research and that led me to put a hold on my first patch [1] in favor of [2]. The second patch fixes the problem that Rajat pointed out.\n\n[1] https://review.opendev.org/c/openstack/cinder/+/964180\n[2] https://review.opendev.org/c/openstack/cinder/+/964492\n\nAs for the scheduler, it\u0027s OK to set the storage_protocol to NVMEOF_TCP because it will be handled by [3]. The NVMEOF_VARIANTS are just variations of spelling.\n\n[3] https://opendev.org/openstack/cinder/src/branch/master/cinder/scheduler/host_manager.py#L394","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"d082ed45b4cdcd12028b084236d782b9f553690f","unresolved":false,"context_lines":[{"line_number":2099,"context_line":"    def do_setup(self, context):"},{"line_number":2100,"context_line":"        super(PowerFlexNVMeDriver, self).do_setup(context)"},{"line_number":2101,"context_line":""},{"line_number":2102,"context_line":"        self.storage_protocol \u003d constants.NVMEOF"},{"line_number":2103,"context_line":"        LOG.info(\"Storage protocol: %s.\", self.storage_protocol)"},{"line_number":2104,"context_line":""},{"line_number":2105,"context_line":"    def check_for_setup_error(self):"}],"source_content_type":"text/x-python","patch_set":17,"id":"68b510f4_1c6c5bdf","line":2102,"in_reply_to":"6286848c_44cd6a49","updated":"2026-04-20 11:27:01.000000000","message":"Keeping the patch as it for constant, once this patch https://review.opendev.org/c/openstack/cinder/+/964492 gets merge will update the patch according to it.","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"ef942218133fa4c510ba67c998706d3b668f2660","unresolved":false,"context_lines":[{"line_number":2099,"context_line":"    def do_setup(self, context):"},{"line_number":2100,"context_line":"        super(PowerFlexNVMeDriver, self).do_setup(context)"},{"line_number":2101,"context_line":""},{"line_number":2102,"context_line":"        self.storage_protocol \u003d constants.NVMEOF"},{"line_number":2103,"context_line":"        LOG.info(\"Storage protocol: %s.\", self.storage_protocol)"},{"line_number":2104,"context_line":""},{"line_number":2105,"context_line":"    def check_for_setup_error(self):"}],"source_content_type":"text/x-python","patch_set":17,"id":"5c8f23d7_4188228e","line":2102,"in_reply_to":"9ae8cbf6_28133c04","updated":"2025-10-20 06:39:15.000000000","message":"Done","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"fc7ced3f18e7b40ae32ce3c3a63d7a08ef2fc24f","unresolved":true,"context_lines":[{"line_number":2099,"context_line":"    def do_setup(self, context):"},{"line_number":2100,"context_line":"        super(PowerFlexNVMeDriver, self).do_setup(context)"},{"line_number":2101,"context_line":""},{"line_number":2102,"context_line":"        self.storage_protocol \u003d constants.NVMEOF"},{"line_number":2103,"context_line":"        LOG.info(\"Storage protocol: %s.\", self.storage_protocol)"},{"line_number":2104,"context_line":""},{"line_number":2105,"context_line":"    def check_for_setup_error(self):"}],"source_content_type":"text/x-python","patch_set":17,"id":"bc515b4f_e8910b85","line":2102,"in_reply_to":"9c7d259c_b2beaaea","updated":"2025-10-15 04:05:51.000000000","message":"Hi @rajatdhasmana@gmail.com,\n\nI agree that a separate patch to add NVMEOF_TCP in variants is required for those 3 drivers using NVMEOF_TCP.\n\nPer the note [1], \"New drivers must use non variant versions\", constants.NVMEOF is the right one for this patch.\n\n\n[1] https://opendev.org/openstack/cinder/src/branch/master/cinder/interface/volume_driver.py#L91","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"281aa95396ea2e601e4e91cef65b2f564dd5f9db","unresolved":true,"context_lines":[{"line_number":2099,"context_line":"    def do_setup(self, context):"},{"line_number":2100,"context_line":"        super(PowerFlexNVMeDriver, self).do_setup(context)"},{"line_number":2101,"context_line":""},{"line_number":2102,"context_line":"        self.storage_protocol \u003d constants.NVMEOF"},{"line_number":2103,"context_line":"        LOG.info(\"Storage protocol: %s.\", self.storage_protocol)"},{"line_number":2104,"context_line":""},{"line_number":2105,"context_line":"    def check_for_setup_error(self):"}],"source_content_type":"text/x-python","patch_set":17,"id":"9ae8cbf6_28133c04","line":2102,"in_reply_to":"bc515b4f_e8910b85","updated":"2025-10-15 18:46:51.000000000","message":"I just submitted https://review.opendev.org/c/openstack/cinder/+/964180","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"5a037816f006ce38cb56e7efe15f3538027a1ebf","unresolved":true,"context_lines":[{"line_number":2099,"context_line":"    def do_setup(self, context):"},{"line_number":2100,"context_line":"        super(PowerFlexNVMeDriver, self).do_setup(context)"},{"line_number":2101,"context_line":""},{"line_number":2102,"context_line":"        self.storage_protocol \u003d constants.NVMEOF"},{"line_number":2103,"context_line":"        LOG.info(\"Storage protocol: %s.\", self.storage_protocol)"},{"line_number":2104,"context_line":""},{"line_number":2105,"context_line":"    def check_for_setup_error(self):"}],"source_content_type":"text/x-python","patch_set":17,"id":"fbc54fd1_88e472a0","line":2102,"in_reply_to":"e9a5fa9d_e272cea2","updated":"2025-10-14 19:15:59.000000000","message":"Well that\u0027s the problem! [1] defined protocol specific NVMe constants, but they weren\u0027t added to the list of NVME_VARIANTS!\n\n[1] https://review.opendev.org/c/openstack/cinder/+/849690\n\n@rajatdhasmana@gmail.com, I think it\u0027s OK if this patch updates NVME_VARIANTS. What are your thoughts?","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"11b9947e13ba996b8fb5789dd159b79753c518a7","unresolved":true,"context_lines":[{"line_number":2099,"context_line":"    def do_setup(self, context):"},{"line_number":2100,"context_line":"        super(PowerFlexNVMeDriver, self).do_setup(context)"},{"line_number":2101,"context_line":""},{"line_number":2102,"context_line":"        self.storage_protocol \u003d constants.NVMEOF"},{"line_number":2103,"context_line":"        LOG.info(\"Storage protocol: %s.\", self.storage_protocol)"},{"line_number":2104,"context_line":""},{"line_number":2105,"context_line":"    def check_for_setup_error(self):"}],"source_content_type":"text/x-python","patch_set":17,"id":"9c7d259c_b2beaaea","line":2102,"in_reply_to":"fbc54fd1_88e472a0","updated":"2025-10-14 20:05:04.000000000","message":"Currently a lot of drivers use the NVMEOF_TCP constant, namely:\n1. Pure[1]\n2. Fungible[2]\n3. Dell PowerMax[3]\n\nRegarding the above concerns, I don\u0027t think it\u0027s an issue with the scheduler since we return the storage_protocol eventually[4] and user just needs to be accurate with the exact string to make the capability scheduling work\n\nIt is really a problem with the shared_targets workflow in cinder-volume and os-brick.\nShared targets make disconnect/connect decisions based on the value of shared_targets (None for NVMe) that we match against NVMEOF_VARIANTS.\nSo if we have shared targets with dell powerflex and protocol is nvme TCP then we might see all sorts of issues on the os-brick side related to stale devices being leftover due to the subsystem not being disconnected properly.\n\nThere are two ways i see this:\n1. Fix the issue separately (adding NVMEOF_TCP and probably RoCE in variants) and make this patch depends on it\n2. Fix it in the same patch itself\n\nDoing 2 disallows us from proposing any backport for the fix so I would much rather prefer 1, if Alan or the author here can propose the patch, I can review and provide my vote. Then this patch can depend upon it.\nLet me know if you have any other thoughts.\n\n[1] https://opendev.org/openstack/cinder/src/branch/master/cinder/volume/drivers/pure.py#L4478\n[2] https://opendev.org/openstack/cinder/src/branch/master/cinder/volume/drivers/fungible/driver.py#L1142\n[3] https://opendev.org/openstack/cinder/src/branch/master/cinder/volume/drivers/dell_emc/powermax/nvme_tcp.py#L216\n[4] https://opendev.org/openstack/cinder/src/branch/master/cinder/scheduler/host_manager.py#L394\n[5] https://opendev.org/openstack/cinder/src/branch/master/cinder/common/constants.py#L51","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"6fb11fe6ea42c12811db3945d3ed73f5002b43cd","unresolved":true,"context_lines":[{"line_number":2146,"context_line":"        \"\"\""},{"line_number":2147,"context_line":"        portals, system_id, system_nqn \u003d self._get_nvme_targets()"},{"line_number":2148,"context_line":"        return {"},{"line_number":2149,"context_line":"            \"driver_volume_type\": constants.NVMEOF_VARIANT_2,"},{"line_number":2150,"context_line":"            \"data\": {"},{"line_number":2151,"context_line":"                \"portals\": portals,"},{"line_number":2152,"context_line":"                \"target_nqn\": system_nqn,"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa619cef_675987be","line":2149,"updated":"2025-10-13 20:44:21.000000000","message":"I think this is the only place where it\u0027s important to set the driver_volume_type to one of the values recognized by os-brick, which are \"nvme\" or \"nvmeof\" (technically, os-brick recogizes \"NVME\" or \"NVMEOF\" but it converts the requested protocol string to upper case [1]).\n\nLooking at other cinder drivers, they seem to specify the raw \"nvmeof\" string for the driver_volume_type. I\u0027d be OK doing there here on L2149 if for no other reason than it avoids people asking \"why variant 2?\"\n\n[1] https://opendev.org/openstack/os-brick/src/branch/master/os_brick/initiator/connector.py#L283","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"ef942218133fa4c510ba67c998706d3b668f2660","unresolved":false,"context_lines":[{"line_number":2146,"context_line":"        \"\"\""},{"line_number":2147,"context_line":"        portals, system_id, system_nqn \u003d self._get_nvme_targets()"},{"line_number":2148,"context_line":"        return {"},{"line_number":2149,"context_line":"            \"driver_volume_type\": constants.NVMEOF_VARIANT_2,"},{"line_number":2150,"context_line":"            \"data\": {"},{"line_number":2151,"context_line":"                \"portals\": portals,"},{"line_number":2152,"context_line":"                \"target_nqn\": system_nqn,"}],"source_content_type":"text/x-python","patch_set":17,"id":"8e5b9bba_ee68e237","line":2149,"in_reply_to":"fa619cef_675987be","updated":"2025-10-20 06:39:15.000000000","message":"Acknowledged","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"ec0be2ce43a8b0bd52c8b4ab453d640713041e03","unresolved":true,"context_lines":[{"line_number":2189,"context_line":"        for sdt in sdts:"},{"line_number":2190,"context_line":"            port \u003d sdt.get(\"nvmePort\", 4420)"},{"line_number":2191,"context_line":"            for ip in sdt[\"ipList\"]:"},{"line_number":2192,"context_line":"                if ip[\"ip\"] not in portals:"},{"line_number":2193,"context_line":"                    portals.append((ip[\"ip\"], port, \"tcp\"))"},{"line_number":2194,"context_line":"        if not portals:"},{"line_number":2195,"context_line":"            msg \u003d _(\"There are no accessible NVMe targets on the \""}],"source_content_type":"text/x-python","patch_set":22,"id":"ddb23a79_5da4fa6e","line":2192,"updated":"2026-03-23 13:31:16.000000000","message":"look like portals are tuple of array and ip[\"ip\"] return str resulting in False always. Can you check this?portals.append((ip[\"ip\"], port, \"tcp\"))","commit_id":"72d2de8ce2ffeb8f51ebcd99747731f70475b5f5"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"d082ed45b4cdcd12028b084236d782b9f553690f","unresolved":false,"context_lines":[{"line_number":2189,"context_line":"        for sdt in sdts:"},{"line_number":2190,"context_line":"            port \u003d sdt.get(\"nvmePort\", 4420)"},{"line_number":2191,"context_line":"            for ip in sdt[\"ipList\"]:"},{"line_number":2192,"context_line":"                if ip[\"ip\"] not in portals:"},{"line_number":2193,"context_line":"                    portals.append((ip[\"ip\"], port, \"tcp\"))"},{"line_number":2194,"context_line":"        if not portals:"},{"line_number":2195,"context_line":"            msg \u003d _(\"There are no accessible NVMe targets on the \""}],"source_content_type":"text/x-python","patch_set":22,"id":"9c5b3330_d29f835a","line":2192,"in_reply_to":"ddb23a79_5da4fa6e","updated":"2026-04-20 11:27:01.000000000","message":"Done","commit_id":"72d2de8ce2ffeb8f51ebcd99747731f70475b5f5"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"ec0be2ce43a8b0bd52c8b4ab453d640713041e03","unresolved":true,"context_lines":[{"line_number":2208,"context_line":"        self._attach_volume_to_host(volume, host_id)"},{"line_number":2209,"context_line":"        self._check_volume_mapped(host_id, volume.provider_id)"},{"line_number":2210,"context_line":""},{"line_number":2211,"context_line":"    @coordination.synchronized(\"PowerFlex-create-host\")"},{"line_number":2212,"context_line":"    def _create_host_if_not_exist(self, connector):"},{"line_number":2213,"context_line":"        \"\"\"Create PowerFlex host if it does not exist."},{"line_number":2214,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"dab6ce70_c60404e6","line":2211,"updated":"2026-03-23 13:31:16.000000000","message":"Serialises host-create across all PowerFlex backends on the host. is this expected?","commit_id":"72d2de8ce2ffeb8f51ebcd99747731f70475b5f5"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"d082ed45b4cdcd12028b084236d782b9f553690f","unresolved":false,"context_lines":[{"line_number":2208,"context_line":"        self._attach_volume_to_host(volume, host_id)"},{"line_number":2209,"context_line":"        self._check_volume_mapped(host_id, volume.provider_id)"},{"line_number":2210,"context_line":""},{"line_number":2211,"context_line":"    @coordination.synchronized(\"PowerFlex-create-host\")"},{"line_number":2212,"context_line":"    def _create_host_if_not_exist(self, connector):"},{"line_number":2213,"context_line":"        \"\"\"Create PowerFlex host if it does not exist."},{"line_number":2214,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"20fbc044_5da7bfc5","line":2211,"in_reply_to":"dab6ce70_c60404e6","updated":"2026-04-20 11:27:01.000000000","message":"Done","commit_id":"72d2de8ce2ffeb8f51ebcd99747731f70475b5f5"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"ec0be2ce43a8b0bd52c8b4ab453d640713041e03","unresolved":true,"context_lines":[{"line_number":2216,"context_line":"        :return: PowerFlex host id"},{"line_number":2217,"context_line":"        \"\"\""},{"line_number":2218,"context_line":"        nqn \u003d connector[\"nqn\"]"},{"line_number":2219,"context_line":"        host_id \u003d self._get_client().query_host_by_nqn(nqn)"},{"line_number":2220,"context_line":"        if not host_id:"},{"line_number":2221,"context_line":"            host_name \u003d self._powerflex_host_name("},{"line_number":2222,"context_line":"                connector,"}],"source_content_type":"text/x-python","patch_set":22,"id":"dc8d6c7c_1aed3f8a","line":2219,"updated":"2026-03-23 13:31:16.000000000","message":"this can return None? unmap all?","commit_id":"72d2de8ce2ffeb8f51ebcd99747731f70475b5f5"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"d082ed45b4cdcd12028b084236d782b9f553690f","unresolved":false,"context_lines":[{"line_number":2216,"context_line":"        :return: PowerFlex host id"},{"line_number":2217,"context_line":"        \"\"\""},{"line_number":2218,"context_line":"        nqn \u003d connector[\"nqn\"]"},{"line_number":2219,"context_line":"        host_id \u003d self._get_client().query_host_by_nqn(nqn)"},{"line_number":2220,"context_line":"        if not host_id:"},{"line_number":2221,"context_line":"            host_name \u003d self._powerflex_host_name("},{"line_number":2222,"context_line":"                connector,"}],"source_content_type":"text/x-python","patch_set":22,"id":"66febc78_fb01ddbf","line":2219,"in_reply_to":"dc8d6c7c_1aed3f8a","updated":"2026-04-20 11:27:01.000000000","message":"Yes this can return None when host is not available on PowerFlex side and this has no relation of unmap all.","commit_id":"72d2de8ce2ffeb8f51ebcd99747731f70475b5f5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0112369a92c8eea1ac4ab5a4e5a2e4858e1b8f07","unresolved":true,"context_lines":[{"line_number":117,"context_line":"        self.statisticProperties \u003d None"},{"line_number":118,"context_line":"        self.storage_pools \u003d None"},{"line_number":119,"context_line":"        self.provisioning_type \u003d None"},{"line_number":120,"context_line":"        # storage protocol: scaleio or NVMe-oF"},{"line_number":121,"context_line":"        self.storage_protocol \u003d None"},{"line_number":122,"context_line":"        self.replication_enabled \u003d None"},{"line_number":123,"context_line":"        self.replication_device \u003d None"}],"source_content_type":"text/x-python","patch_set":23,"id":"cd64d70e_454608e0","line":120,"range":{"start_line":120,"start_character":39,"end_line":120,"end_character":46},"updated":"2026-05-11 21:02:36.000000000","message":"NVMe-TCP","commit_id":"5412f203cab3db87efa63ab9273360a7293fce12"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"91a5a3f66d9981c3b0e18319787f36093c215632","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        self.statisticProperties \u003d None"},{"line_number":118,"context_line":"        self.storage_pools \u003d None"},{"line_number":119,"context_line":"        self.provisioning_type \u003d None"},{"line_number":120,"context_line":"        # storage protocol: scaleio or NVMe-oF"},{"line_number":121,"context_line":"        self.storage_protocol \u003d None"},{"line_number":122,"context_line":"        self.replication_enabled \u003d None"},{"line_number":123,"context_line":"        self.replication_device \u003d None"}],"source_content_type":"text/x-python","patch_set":23,"id":"38b4be6b_e5b94847","line":120,"range":{"start_line":120,"start_character":39,"end_line":120,"end_character":46},"in_reply_to":"cd64d70e_454608e0","updated":"2026-05-12 06:42:28.000000000","message":"Done","commit_id":"5412f203cab3db87efa63ab9273360a7293fce12"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0112369a92c8eea1ac4ab5a4e5a2e4858e1b8f07","unresolved":true,"context_lines":[{"line_number":2121,"context_line":"    def do_setup(self, context):"},{"line_number":2122,"context_line":"        super(PowerFlexNVMeDriver, self).do_setup(context)"},{"line_number":2123,"context_line":""},{"line_number":2124,"context_line":"        self.storage_protocol \u003d constants.NVMEOF"},{"line_number":2125,"context_line":"        LOG.info(\"Storage protocol: %s.\", self.storage_protocol)"},{"line_number":2126,"context_line":""},{"line_number":2127,"context_line":"    def check_for_setup_error(self):"}],"source_content_type":"text/x-python","patch_set":23,"id":"c12ac562_3a1e6ca5","line":2124,"range":{"start_line":2124,"start_character":32,"end_line":2124,"end_character":48},"updated":"2026-05-11 21:02:36.000000000","message":"constants.NVMEOF_TCP","commit_id":"5412f203cab3db87efa63ab9273360a7293fce12"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"91a5a3f66d9981c3b0e18319787f36093c215632","unresolved":false,"context_lines":[{"line_number":2121,"context_line":"    def do_setup(self, context):"},{"line_number":2122,"context_line":"        super(PowerFlexNVMeDriver, self).do_setup(context)"},{"line_number":2123,"context_line":""},{"line_number":2124,"context_line":"        self.storage_protocol \u003d constants.NVMEOF"},{"line_number":2125,"context_line":"        LOG.info(\"Storage protocol: %s.\", self.storage_protocol)"},{"line_number":2126,"context_line":""},{"line_number":2127,"context_line":"    def check_for_setup_error(self):"}],"source_content_type":"text/x-python","patch_set":23,"id":"5f6ccad3_67ab15fd","line":2124,"range":{"start_line":2124,"start_character":32,"end_line":2124,"end_character":48},"in_reply_to":"c12ac562_3a1e6ca5","updated":"2026-05-12 06:42:28.000000000","message":"Done","commit_id":"5412f203cab3db87efa63ab9273360a7293fce12"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"ef76ed73ddf2a04b7c4629a50de4d7e825a69773","unresolved":true,"context_lines":[{"line_number":2084,"context_line":"            LOG.info(\"Terminate connection for %(vol_id)s to SDC %(sdc)s.\","},{"line_number":2085,"context_line":"                     {\"vol_id\": volume_or_snap.id, \"sdc\": sdc_guid})"},{"line_number":2086,"context_line":"            if isinstance(volume_or_snap, Volume):"},{"line_number":2087,"context_line":"                is_multiattached \u003d self._is_multiattached_to_host("},{"line_number":2088,"context_line":"                    volume_or_snap.volume_attachment,"},{"line_number":2089,"context_line":"                    connector[\"host\"]"},{"line_number":2090,"context_line":"                )"},{"line_number":2091,"context_line":"                if is_multiattached:"},{"line_number":2092,"context_line":"                    # Do not detach volume if it is attached to more than one"},{"line_number":2093,"context_line":"                    # instance on the same host."},{"line_number":2094,"context_line":"                    LOG.info(\"Will not terminate %(protocol)s connection for \""}],"source_content_type":"text/x-python","patch_set":24,"id":"49a96c35_629c94d4","line":2091,"range":{"start_line":2087,"start_character":0,"end_line":2091,"end_character":36},"updated":"2026-05-12 13:18:49.000000000","message":"This will race when multiple terminate_connection calls happen at the same time. Please add a lock on the volume id.  (Probably for the method.)","commit_id":"7d5f250e1a43b8a7d25761bcb843e5a42cccba6b"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"a978da909a70266124efd435c51af59387d47f1b","unresolved":false,"context_lines":[{"line_number":2084,"context_line":"            LOG.info(\"Terminate connection for %(vol_id)s to SDC %(sdc)s.\","},{"line_number":2085,"context_line":"                     {\"vol_id\": volume_or_snap.id, \"sdc\": sdc_guid})"},{"line_number":2086,"context_line":"            if isinstance(volume_or_snap, Volume):"},{"line_number":2087,"context_line":"                is_multiattached \u003d self._is_multiattached_to_host("},{"line_number":2088,"context_line":"                    volume_or_snap.volume_attachment,"},{"line_number":2089,"context_line":"                    connector[\"host\"]"},{"line_number":2090,"context_line":"                )"},{"line_number":2091,"context_line":"                if is_multiattached:"},{"line_number":2092,"context_line":"                    # Do not detach volume if it is attached to more than one"},{"line_number":2093,"context_line":"                    # instance on the same host."},{"line_number":2094,"context_line":"                    LOG.info(\"Will not terminate %(protocol)s connection for \""}],"source_content_type":"text/x-python","patch_set":24,"id":"c9814e27_ebc7b30e","line":2091,"range":{"start_line":2087,"start_character":0,"end_line":2091,"end_character":36},"in_reply_to":"49a96c35_629c94d4","updated":"2026-05-12 15:00:12.000000000","message":"Done, fixed at base function at #L964.","commit_id":"7d5f250e1a43b8a7d25761bcb843e5a42cccba6b"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"ef76ed73ddf2a04b7c4629a50de4d7e825a69773","unresolved":true,"context_lines":[{"line_number":2286,"context_line":"                volume_or_snap.volume_attachment,"},{"line_number":2287,"context_line":"                connector[\"host\"]"},{"line_number":2288,"context_line":"            )"},{"line_number":2289,"context_line":"            if is_multiattached:"},{"line_number":2290,"context_line":"                # Do not detach volume if it is attached to more than one"},{"line_number":2291,"context_line":"                # instance on the same host."},{"line_number":2292,"context_line":"                LOG.info(\"Will not terminate %(protocol)s connection for \""}],"source_content_type":"text/x-python","patch_set":24,"id":"2f67c4ae_81523dda","line":2289,"updated":"2026-05-12 13:18:49.000000000","message":"Same concern as above","commit_id":"7d5f250e1a43b8a7d25761bcb843e5a42cccba6b"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"a978da909a70266124efd435c51af59387d47f1b","unresolved":false,"context_lines":[{"line_number":2286,"context_line":"                volume_or_snap.volume_attachment,"},{"line_number":2287,"context_line":"                connector[\"host\"]"},{"line_number":2288,"context_line":"            )"},{"line_number":2289,"context_line":"            if is_multiattached:"},{"line_number":2290,"context_line":"                # Do not detach volume if it is attached to more than one"},{"line_number":2291,"context_line":"                # instance on the same host."},{"line_number":2292,"context_line":"                LOG.info(\"Will not terminate %(protocol)s connection for \""}],"source_content_type":"text/x-python","patch_set":24,"id":"406067b3_791e9a1b","line":2289,"in_reply_to":"2f67c4ae_81523dda","updated":"2026-05-12 15:00:12.000000000","message":"Done, fixed at base function at #L964","commit_id":"7d5f250e1a43b8a7d25761bcb843e5a42cccba6b"}],"cinder/volume/drivers/dell_emc/powerflex/options.py":[{"author":{"_account_id":32912,"name":"Pure Storage Third-Party CI","display_name":"Pure Storage Third-Party CI","email":"openstack-third-party-ci@purestorage.com","username":"purestorage-thirdparty-ci","status":"Doing CI things"},"change_message_id":"4c1ff54b4227152cfefd60019b236e0a8067f6fe","unresolved":true,"context_lines":[{"line_number":160,"context_line":"                    \u0027timeout value (in seconds) for rest call.\u0027),"},{"line_number":161,"context_line":"    cfg.BoolOpt(POWERFLEX_NVME,"},{"line_number":162,"context_line":"                default\u003dFalse,"},{"line_number":163,"context_line":"                help\u003d\"Connect PowerFlex volumes using NVMe-OF.\"),"},{"line_number":164,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":8,"id":"160100cc_4f34f939","line":163,"updated":"2024-08-07 14:36:10.000000000","message":"NVMe-TCP (as that is the actual protocol you are employing)","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"205a7552cce66cc847a9d6cf3d954f331e0da0f1","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                    \u0027timeout value (in seconds) for rest call.\u0027),"},{"line_number":161,"context_line":"    cfg.BoolOpt(POWERFLEX_NVME,"},{"line_number":162,"context_line":"                default\u003dFalse,"},{"line_number":163,"context_line":"                help\u003d\"Connect PowerFlex volumes using NVMe-OF.\"),"},{"line_number":164,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":8,"id":"9645f206_85838cbf","line":163,"in_reply_to":"160100cc_4f34f939","updated":"2024-08-19 09:54:02.000000000","message":"Done","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d18c286c1ce126dbed92f3f0bd427d82aba16f2f","unresolved":true,"context_lines":[{"line_number":158,"context_line":"               default\u003d30, min\u003d1,"},{"line_number":159,"context_line":"               help\u003d\u0027Use this value to specify read \u0027"},{"line_number":160,"context_line":"                    \u0027timeout value (in seconds) for rest call.\u0027),"},{"line_number":161,"context_line":"    cfg.BoolOpt(POWERFLEX_NVME,"},{"line_number":162,"context_line":"                default\u003dFalse,"},{"line_number":163,"context_line":"                help\u003d\"Connect PowerFlex volumes using NVMe-TCP.\"),"},{"line_number":164,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":14,"id":"aad9b6c8_2461c35c","line":161,"range":{"start_line":161,"start_character":16,"end_line":161,"end_character":30},"updated":"2024-12-06 09:45:40.000000000","message":"this naming might be an issue if later powerflex starts supporting NVMe over RDMA or FC. We have 2 options here,\n1. Make this NVMe TCP specific: POWERFLEX_NVME_TCP\n2. instead of a bool, make it string: POWERFLEX_NVME\u003dnvme_tcp\n\nuseful reference: https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/pure.py#L114-L115","commit_id":"292c2f103d86771f77339dec16cf9cfea6ccf50a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"34df4332c1e14ee4dcd2fa76119e21ea8fe98d3f","unresolved":false,"context_lines":[{"line_number":158,"context_line":"               default\u003d30, min\u003d1,"},{"line_number":159,"context_line":"               help\u003d\u0027Use this value to specify read \u0027"},{"line_number":160,"context_line":"                    \u0027timeout value (in seconds) for rest call.\u0027),"},{"line_number":161,"context_line":"    cfg.BoolOpt(POWERFLEX_NVME,"},{"line_number":162,"context_line":"                default\u003dFalse,"},{"line_number":163,"context_line":"                help\u003d\"Connect PowerFlex volumes using NVMe-TCP.\"),"},{"line_number":164,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":14,"id":"8f47aac4_12948d0a","line":161,"range":{"start_line":161,"start_character":16,"end_line":161,"end_character":30},"in_reply_to":"aad9b6c8_2461c35c","updated":"2025-01-28 04:13:58.000000000","message":"Introduced PowerFlexNVMeDriver and this option is not needed.","commit_id":"292c2f103d86771f77339dec16cf9cfea6ccf50a"}],"cinder/volume/drivers/dell_emc/powerflex/rest_client.py":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"29b4d2f3f1f2ce10b5ad37ded3489cec5b232740","unresolved":true,"context_lines":[{"line_number":748,"context_line":"                                                 \"err\": response[\"message\"]})"},{"line_number":749,"context_line":"            LOG.error(msg)"},{"line_number":750,"context_line":"            raise exception.VolumeBackendAPIException(msg)"},{"line_number":751,"context_line":""},{"line_number":752,"context_line":"    def query_system_id_nqn(self):"},{"line_number":753,"context_line":"        url \u003d \"/types/System/instances\""},{"line_number":754,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"ac288447_d1be09e4","line":751,"updated":"2025-08-26 21:29:32.000000000","message":"I gather all of these new functions are required for the new PowerFlexNVMeDriver. I don\u0027t know if you need to go as far as creating an nvme-specific derived class for the nvme client, but even a large comment here might help inform reviewers and future code readers that these new functions are not required by SDC connections.","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"52ed00131589709a5461ea4c0a811a085d9732df","unresolved":false,"context_lines":[{"line_number":748,"context_line":"                                                 \"err\": response[\"message\"]})"},{"line_number":749,"context_line":"            LOG.error(msg)"},{"line_number":750,"context_line":"            raise exception.VolumeBackendAPIException(msg)"},{"line_number":751,"context_line":""},{"line_number":752,"context_line":"    def query_system_id_nqn(self):"},{"line_number":753,"context_line":"        url \u003d \"/types/System/instances\""},{"line_number":754,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"7313f4d3_73e292d9","line":751,"in_reply_to":"ac288447_d1be09e4","updated":"2025-09-30 09:42:52.000000000","message":"Done","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"}],"doc/source/configuration/block-storage/drivers/dell-emc-powerflex-driver.rst":[{"author":{"_account_id":32912,"name":"Pure Storage Third-Party CI","display_name":"Pure Storage Third-Party CI","email":"openstack-third-party-ci@purestorage.com","username":"purestorage-thirdparty-ci","status":"Doing CI things"},"change_message_id":"4c1ff54b4227152cfefd60019b236e0a8067f6fe","unresolved":true,"context_lines":[{"line_number":198,"context_line":"NVMe-oF configuration"},{"line_number":199,"context_line":"~~~~~~~~~~~~~~~~~~~~~"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"PowerFlex supports NVMe over Fabrics and NVMe over TCP"},{"line_number":202,"context_line":"since version 4.0."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":".. note:: PowerFlex does not support replication of volumes mapped to NVMe hosts."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fffe3ca2_6aa575d0","line":201,"updated":"2024-08-07 14:36:10.000000000","message":"NVMe over Fabrics and NVMe over TCP doesn\u0027t men anything. One is a subset of the other (generic) term. \nBe specific and say supports NVMe-TCP","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"205a7552cce66cc847a9d6cf3d954f331e0da0f1","unresolved":false,"context_lines":[{"line_number":198,"context_line":"NVMe-oF configuration"},{"line_number":199,"context_line":"~~~~~~~~~~~~~~~~~~~~~"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"PowerFlex supports NVMe over Fabrics and NVMe over TCP"},{"line_number":202,"context_line":"since version 4.0."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":".. note:: PowerFlex does not support replication of volumes mapped to NVMe hosts."}],"source_content_type":"text/x-rst","patch_set":8,"id":"832b3791_79fdca31","line":201,"in_reply_to":"fffe3ca2_6aa575d0","updated":"2024-08-19 09:54:02.000000000","message":"Done","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":32912,"name":"Pure Storage Third-Party CI","display_name":"Pure Storage Third-Party CI","email":"openstack-third-party-ci@purestorage.com","username":"purestorage-thirdparty-ci","status":"Doing CI things"},"change_message_id":"4c1ff54b4227152cfefd60019b236e0a8067f6fe","unresolved":true,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":".. note:: PowerFlex does not support replication of volumes mapped to NVMe hosts."},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"The driver NVMe-oF configuration is by default disabled."},{"line_number":207,"context_line":"To enable NVMe-oF, set the ``powerflex_nvme`` option to"},{"line_number":208,"context_line":"``True`` in the configuration file, as follows:"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"c52440af_714dcab8","line":206,"updated":"2024-08-07 14:36:10.000000000","message":"Again NVMe-TCP (twice)","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"205a7552cce66cc847a9d6cf3d954f331e0da0f1","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":".. note:: PowerFlex does not support replication of volumes mapped to NVMe hosts."},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"The driver NVMe-oF configuration is by default disabled."},{"line_number":207,"context_line":"To enable NVMe-oF, set the ``powerflex_nvme`` option to"},{"line_number":208,"context_line":"``True`` in the configuration file, as follows:"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"2fcd6dbb_c0e90919","line":206,"in_reply_to":"c52440af_714dcab8","updated":"2024-08-19 09:54:02.000000000","message":"Done","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"29b4d2f3f1f2ce10b5ad37ded3489cec5b232740","unresolved":true,"context_lines":[{"line_number":54,"context_line":"  :ref:`powerflex_docs`."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* PowerFlex Storage Data Client (SDC) must be installed"},{"line_number":57,"context_line":"  on all OpenStack nodes when using SDC connectivity."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":".. note:: Ubuntu users must follow the specific instructions in the PowerFlex"},{"line_number":60,"context_line":"          OS Deployment Guide for Ubuntu environments. See the ``Deploying"}],"source_content_type":"text/x-rst","patch_set":15,"id":"28e90bac_f246b033","line":57,"updated":"2025-08-26 21:29:32.000000000","message":"\"SDC connectivity\" may not make sense to some readers. I think what you mean is the SDC is required only when using the original ScaleIO protocol, and that it\u0027s not required when using NVMe-TCP. Is that correct?","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"a5f2fdcbace7ef84b7d12a4f3343ef8988dfa609","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  :ref:`powerflex_docs`."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* PowerFlex Storage Data Client (SDC) must be installed"},{"line_number":57,"context_line":"  on all OpenStack nodes when using SDC connectivity."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":".. note:: Ubuntu users must follow the specific instructions in the PowerFlex"},{"line_number":60,"context_line":"          OS Deployment Guide for Ubuntu environments. See the ``Deploying"}],"source_content_type":"text/x-rst","patch_set":15,"id":"74068caf_44faef1b","line":57,"in_reply_to":"28e90bac_f246b033","updated":"2025-09-30 12:44:31.000000000","message":"\u0027ScaleIO\u0027 is the former brand name of PowerFlex, which is deprecated.\nPer [1], PowerFlex supports host type \u0027SDC host\u0027 and \u0027NVMe host\u0027.\n\n[1] https://www.dell.com/support/manuals/en-us/scaleio/powerflex_sw_admin_guide_46/hosts?guid\u003dguid-c487a5c9-ab9d-4d17-9c73-4eaedfc96b77\u0026lang\u003den-us","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"ef942218133fa4c510ba67c998706d3b668f2660","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  :ref:`powerflex_docs`."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* PowerFlex Storage Data Client (SDC) must be installed"},{"line_number":57,"context_line":"  on all OpenStack nodes when using SDC connectivity."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":".. note:: Ubuntu users must follow the specific instructions in the PowerFlex"},{"line_number":60,"context_line":"          OS Deployment Guide for Ubuntu environments. See the ``Deploying"}],"source_content_type":"text/x-rst","patch_set":15,"id":"1608338a_f1a8fc89","line":57,"in_reply_to":"6648a7b1_fee7b902","updated":"2025-10-20 06:39:15.000000000","message":"Done","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"6fb11fe6ea42c12811db3945d3ed73f5002b43cd","unresolved":true,"context_lines":[{"line_number":54,"context_line":"  :ref:`powerflex_docs`."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* PowerFlex Storage Data Client (SDC) must be installed"},{"line_number":57,"context_line":"  on all OpenStack nodes when using SDC connectivity."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":".. note:: Ubuntu users must follow the specific instructions in the PowerFlex"},{"line_number":60,"context_line":"          OS Deployment Guide for Ubuntu environments. See the ``Deploying"}],"source_content_type":"text/x-rst","patch_set":15,"id":"6648a7b1_fee7b902","line":57,"in_reply_to":"74068caf_44faef1b","updated":"2025-10-13 20:44:21.000000000","message":"Yes, I understand the ScaleIO name is deprecated. What I mean is the sentence doesn\u0027t make it clear that \"using SDC connectivity\" doesn\u0027t pertain to NVMe. I think this can be addressed by something like this:\n\n\"PowerFlex supports ``SDC`` and ``NVMe`` connectivity. The PowerFlex Storage Data Client (SDC) must be installed on all OpenStack nodes when using SDC connectivity.\"","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"29b4d2f3f1f2ce10b5ad37ded3489cec5b232740","unresolved":true,"context_lines":[{"line_number":246,"context_line":"   powerflex_storage_pools \u003d Domain1:Pool1,Domain2:Pool2"},{"line_number":247,"context_line":"   san_login \u003d POWERFLEX_USER"},{"line_number":248,"context_line":"   san_password \u003d POWERFLEX_PASSWD"},{"line_number":249,"context_line":"   san_thin_provision \u003d false"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"Connector configuration"},{"line_number":252,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":15,"id":"9ebdbbe3_af05d1da","line":249,"updated":"2025-08-26 21:29:32.000000000","message":"Is this a requirement? Does the NVMe variant NOT support thin provisioning?","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"a5f2fdcbace7ef84b7d12a4f3343ef8988dfa609","unresolved":false,"context_lines":[{"line_number":246,"context_line":"   powerflex_storage_pools \u003d Domain1:Pool1,Domain2:Pool2"},{"line_number":247,"context_line":"   san_login \u003d POWERFLEX_USER"},{"line_number":248,"context_line":"   san_password \u003d POWERFLEX_PASSWD"},{"line_number":249,"context_line":"   san_thin_provision \u003d false"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"Connector configuration"},{"line_number":252,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":15,"id":"f0225fc0_f26c40e1","line":249,"in_reply_to":"9ebdbbe3_af05d1da","updated":"2025-09-30 12:44:31.000000000","message":"PowerFlex NVMe supports both thin and thick.\nI copied it from the configuration for SDC.","commit_id":"2fdc2b84ee0afbe31ae5e72f05d24513d2376c0d"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"6fb11fe6ea42c12811db3945d3ed73f5002b43cd","unresolved":true,"context_lines":[{"line_number":250,"context_line":"   powerflex_storage_pools \u003d Domain1:Pool1,Domain2:Pool2"},{"line_number":251,"context_line":"   san_login \u003d POWERFLEX_USER"},{"line_number":252,"context_line":"   san_password \u003d POWERFLEX_PASSWD"},{"line_number":253,"context_line":"   san_thin_provision \u003d false"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"Connector configuration"},{"line_number":256,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":17,"id":"49d0aece_2cddb21f","line":253,"updated":"2025-10-13 20:44:21.000000000","message":"This suggests the NVMe driver doesn\u0027t support thin provisioning, but I thought I read your response in another comment that it DOES support it. If it does then I think L253 should be removed (not sure about L234).","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"ef942218133fa4c510ba67c998706d3b668f2660","unresolved":false,"context_lines":[{"line_number":250,"context_line":"   powerflex_storage_pools \u003d Domain1:Pool1,Domain2:Pool2"},{"line_number":251,"context_line":"   san_login \u003d POWERFLEX_USER"},{"line_number":252,"context_line":"   san_password \u003d POWERFLEX_PASSWD"},{"line_number":253,"context_line":"   san_thin_provision \u003d false"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"Connector configuration"},{"line_number":256,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":17,"id":"8441e244_ce517b3d","line":253,"in_reply_to":"49d0aece_2cddb21f","updated":"2025-10-20 06:39:15.000000000","message":"Removed both.\nThe configuration `san_thin_provision` is covered in the section `Default provisioning type`.","commit_id":"baa5a5a6e3d54e658bb5ef460ff543bac49323ae"}],"doc/source/reference/support-matrix.ini":[{"author":{"_account_id":32912,"name":"Pure Storage Third-Party CI","display_name":"Pure Storage Third-Party CI","email":"openstack-third-party-ci@purestorage.com","username":"purestorage-thirdparty-ci","status":"Doing CI things"},"change_message_id":"4c1ff54b4227152cfefd60019b236e0a8067f6fe","unresolved":true,"context_lines":[{"line_number":37,"context_line":"title\u003dDell SC Series Storage Driver (iSCSI, FC)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"[driver.dell_emc_powerflex]"},{"line_number":40,"context_line":"title\u003dDell PowerFlex (ScaleIO) Storage Driver (ScaleIO, NVMe-oF)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"[driver.dell_emc_powervault]"},{"line_number":43,"context_line":"title\u003dDell PowerVault ME Series (iSCSI, FC)"}],"source_content_type":"text/x-properties","patch_set":8,"id":"8ab15aaa_ad0d2bda","line":40,"updated":"2024-08-07 14:36:10.000000000","message":"NVMe-TCP","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"205a7552cce66cc847a9d6cf3d954f331e0da0f1","unresolved":false,"context_lines":[{"line_number":37,"context_line":"title\u003dDell SC Series Storage Driver (iSCSI, FC)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"[driver.dell_emc_powerflex]"},{"line_number":40,"context_line":"title\u003dDell PowerFlex (ScaleIO) Storage Driver (ScaleIO, NVMe-oF)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"[driver.dell_emc_powervault]"},{"line_number":43,"context_line":"title\u003dDell PowerVault ME Series (iSCSI, FC)"}],"source_content_type":"text/x-properties","patch_set":8,"id":"63619209_f387e521","line":40,"in_reply_to":"8ab15aaa_ad0d2bda","updated":"2024-08-19 09:54:02.000000000","message":"Done","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"}],"releasenotes/notes/bp-dell-powerflex-nvmeof-049116b1802d7b0e.yaml":[{"author":{"_account_id":32912,"name":"Pure Storage Third-Party CI","display_name":"Pure Storage Third-Party CI","email":"openstack-third-party-ci@purestorage.com","username":"purestorage-thirdparty-ci","status":"Doing CI things"},"change_message_id":"4c1ff54b4227152cfefd60019b236e0a8067f6fe","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerFlex driver: Added NVMe-oF support."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"8ffe5c8e_e176c29d","line":4,"updated":"2024-08-07 14:36:10.000000000","message":"NVMe-TCP","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"205a7552cce66cc847a9d6cf3d954f331e0da0f1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerFlex driver: Added NVMe-oF support."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"33ef2cea_a986e7c0","line":4,"in_reply_to":"8ffe5c8e_e176c29d","updated":"2024-08-19 09:54:02.000000000","message":"Done","commit_id":"c3fa549746ba1dba18d3000198cc26b9127838c9"}]}