)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"2ce0682b6985abc99670abbe5341c447d79b4473","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e79c4ef3_01ae3283","updated":"2024-03-15 04:01:36.000000000","message":"address comments and fix pep8 errors","commit_id":"3ce9f834db54dc0d158844a825aa9d006a762550"},{"author":{"_account_id":36897,"name":"Girish Chilukuri","display_name":"Girish Chilukuri","email":"Girish.Chilukuri1@partner.ibm.com","username":"girishchilukuri1"},"change_message_id":"315dfe9e7e4cfd2dbe1d01249b27a3847af6245a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"826ce322_590110f6","updated":"2024-03-18 07:45:00.000000000","message":"Please find the comments inline.","commit_id":"58cb5392db54a3b43bde8d04e6e4d8d1daa75edf"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"cf1a6ca8220c0c31e8b0e3ffbe3cd268763c59fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"e18fdeed_62d9faa1","updated":"2024-04-02 12:54:02.000000000","message":"UT code can be added.\nCouple of minor comments inline.","commit_id":"04438849879497a1219b33ac53b77d9f69b7bc1b"},{"author":{"_account_id":36897,"name":"Girish Chilukuri","display_name":"Girish Chilukuri","email":"Girish.Chilukuri1@partner.ibm.com","username":"girishchilukuri1"},"change_message_id":"777115ef260740103976b17f6615e4d51f783e95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"f2826b64_9dbab242","updated":"2025-05-21 07:40:08.000000000","message":"Please find comments inline.","commit_id":"60a12796f65a759805212234077f0f443a07c603"},{"author":{"_account_id":37470,"name":"Dakshina Purohit","display_name":"Dakshina","email":"Dakshina.Purohit@ibm.com","username":"dakshina"},"change_message_id":"50d2a8bf107adea8872403d4396ded5bddaba667","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"9b2e3644_18c5427d","updated":"2025-07-25 06:30:08.000000000","message":"run-IBM-CI","commit_id":"9ade36e9e039d986deb7d4db88bbef91b48924c1"},{"author":{"_account_id":37328,"name":"Nimesh Desai","display_name":"Nimesh Desai","email":"nimesh.desai@ibm.com","username":"nimeshdesai"},"change_message_id":"7226d070975b3f552a6cca1a15b85fc2afc98a71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"b3f2686a_85e893d4","updated":"2025-07-22 14:08:53.000000000","message":"run-IBM-CI","commit_id":"9ade36e9e039d986deb7d4db88bbef91b48924c1"},{"author":{"_account_id":37328,"name":"Nimesh Desai","display_name":"Nimesh Desai","email":"nimesh.desai@ibm.com","username":"nimeshdesai"},"change_message_id":"b4a52cf96be83cfab43bbc5ae013e1a8adbfa083","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"0decac03_e11263dd","updated":"2025-08-08 05:21:58.000000000","message":"run-IBM-CI","commit_id":"7de012f3d2ce6f2084413a4c9f1840bd6e9f6d4f"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"123f7d2daae727071652e615d65ee480add47e5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"cc7b98a7_8ba11d60","updated":"2025-08-29 04:36:46.000000000","message":"LGTM","commit_id":"ed48542f1154682f5a738d3703443af10a3af64d"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"3c902185e010568830c516eaff1daf99f22f227a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"ca481706_2477ea2c","updated":"2026-03-02 09:42:23.000000000","message":"Please mark that IBM CI is also passed on this.\n\n@rosmaita.fossdev@gmail.com @jobernar@redhat.com\nRequesting for Review Priority and +2s for this defect","commit_id":"ed48542f1154682f5a738d3703443af10a3af64d"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"96a1553783870883760d9f238cbf050ee0e0f94d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":23,"id":"837bee8b_b0459d6f","updated":"2025-11-07 16:15:09.000000000","message":"This looks like it will solve the problem, but I wanted to add two comments for possible changes to aid debugging in the future.  I will issue +1 once these are resolved (even if just acknowledged and no changes are made).","commit_id":"ed48542f1154682f5a738d3703443af10a3af64d"},{"author":{"_account_id":37923,"name":"anthony gamboa","display_name":"Anthony Gamboa","email":"anthony.gamboa@hitachivantara.com","username":"anthonygamboa","status":"Hitachi Vantara Software Developer"},"change_message_id":"e5b0d629d93fff27879a6577e83687456871939a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"e3ddb39c_b330bb57","updated":"2025-10-30 19:44:58.000000000","message":"looks good to me. all","commit_id":"ed48542f1154682f5a738d3703443af10a3af64d"},{"author":{"_account_id":37923,"name":"anthony gamboa","display_name":"Anthony Gamboa","email":"anthony.gamboa@hitachivantara.com","username":"anthonygamboa","status":"Hitachi Vantara Software Developer"},"change_message_id":"e5b0d629d93fff27879a6577e83687456871939a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"1c6b2e39_eb641176","updated":"2025-10-30 19:44:58.000000000","message":"reviewed code and comments, looks good to me","commit_id":"ed48542f1154682f5a738d3703443af10a3af64d"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"c8f2df1b866e3c2e89b51b81ee827a6e0b0c66de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"d8893409_5faa343a","in_reply_to":"837bee8b_b0459d6f","updated":"2025-12-19 10:12:44.000000000","message":"Done","commit_id":"ed48542f1154682f5a738d3703443af10a3af64d"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"3c106fca74ea718f1310d5daadb87330cfe3205f","unresolved":true,"context_lines":[{"line_number":5835,"context_line":"                    raise exception.VolumeDriverException(message\u003dmsg)"},{"line_number":5836,"context_line":"            else:"},{"line_number":5837,"context_line":"                retype_iogrp_property(volume, new_io_grp, old_io_grp)"},{"line_number":5838,"context_line":"                model_update[\u0027metadata\u0027][\u0027pending_retype_iogrps\u0027] \u003d old_io_grp"},{"line_number":5839,"context_line":""},{"line_number":5840,"context_line":"                self._helpers.change_vdisk_options(volume[\u0027name\u0027],"},{"line_number":5841,"context_line":"                                                   vdisk_changes,"}],"source_content_type":"text/x-python","patch_set":1,"id":"f90b888c_9fd05aaf","line":5838,"updated":"2024-03-15 06:05:02.000000000","message":"this should be only set if old_groups are not part of new_iogrps.\nold_grp\u003d0\nnew_grp\u003d1 --\u003e metadata should be set\n\nold_grp\u003d0\nnew_grp\u003d0,1 --\u003e metadata should not be set\n\n\nchanging from iogrp0,1 to iogrp1 -\u003e it will update metadata should have iogrp1\n(0, 1) -\u003e (1)\n difference 0 -\u003e rmvdiskaccess\n (0) -\u003e (0,1) \n old should be subset of new then no need to remove","commit_id":"3ce9f834db54dc0d158844a825aa9d006a762550"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"430f7cbffd1f19911ca82922dec832e73c129f03","unresolved":false,"context_lines":[{"line_number":5835,"context_line":"                    raise exception.VolumeDriverException(message\u003dmsg)"},{"line_number":5836,"context_line":"            else:"},{"line_number":5837,"context_line":"                retype_iogrp_property(volume, new_io_grp, old_io_grp)"},{"line_number":5838,"context_line":"                model_update[\u0027metadata\u0027][\u0027pending_retype_iogrps\u0027] \u003d old_io_grp"},{"line_number":5839,"context_line":""},{"line_number":5840,"context_line":"                self._helpers.change_vdisk_options(volume[\u0027name\u0027],"},{"line_number":5841,"context_line":"                                                   vdisk_changes,"}],"source_content_type":"text/x-python","patch_set":1,"id":"29a0f7d7_51e3f37a","line":5838,"in_reply_to":"f90b888c_9fd05aaf","updated":"2025-05-14 15:12:15.000000000","message":"Addressed the comment as per suggestions from Girish. He has already tested these changes.","commit_id":"3ce9f834db54dc0d158844a825aa9d006a762550"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"2ce0682b6985abc99670abbe5341c447d79b4473","unresolved":true,"context_lines":[{"line_number":5946,"context_line":"        model_update[\u0027metadata\u0027] \u003d db_metadata if db_metadata else None"},{"line_number":5947,"context_line":""},{"line_number":5948,"context_line":"        # Check if the volume has access to multiple IO_groups"},{"line_number":5949,"context_line":"        if model_update[\u0027metadata\u0027][\u0027pending_retype_iogrps\u0027]:"},{"line_number":5950,"context_line":"            vol_pending_retype_iogrps \u003d str(model_update[\u0027metadata\u0027][\u0027pending_retype_iogrps\u0027])"},{"line_number":5951,"context_line":"            vol_attrs \u003d self.get_vdisk_attributes(volume[\u0027name\u0027])"},{"line_number":5952,"context_line":"            vol_current_iogrp \u003d vol_attrs[\u0027IO_group_name\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9daed9e0_9356e09b","line":5949,"updated":"2024-03-15 04:01:36.000000000","message":"if \u0027pending_retype_iogrps\u0027 in model_update[\u0027metadata\u0027] and model_update[\u0027metadata\u0027][\u0027pending_retype_iogrps\u0027]:","commit_id":"3ce9f834db54dc0d158844a825aa9d006a762550"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"3e377ac79f29c68b7a40f4f91cdc95644ac36a24","unresolved":false,"context_lines":[{"line_number":5946,"context_line":"        model_update[\u0027metadata\u0027] \u003d db_metadata if db_metadata else None"},{"line_number":5947,"context_line":""},{"line_number":5948,"context_line":"        # Check if the volume has access to multiple IO_groups"},{"line_number":5949,"context_line":"        if model_update[\u0027metadata\u0027][\u0027pending_retype_iogrps\u0027]:"},{"line_number":5950,"context_line":"            vol_pending_retype_iogrps \u003d str(model_update[\u0027metadata\u0027][\u0027pending_retype_iogrps\u0027])"},{"line_number":5951,"context_line":"            vol_attrs \u003d self.get_vdisk_attributes(volume[\u0027name\u0027])"},{"line_number":5952,"context_line":"            vol_current_iogrp \u003d vol_attrs[\u0027IO_group_name\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"e91e2b70_25266efe","line":5949,"in_reply_to":"9daed9e0_9356e09b","updated":"2024-03-18 07:55:33.000000000","message":"Resolved.","commit_id":"3ce9f834db54dc0d158844a825aa9d006a762550"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"2ce0682b6985abc99670abbe5341c447d79b4473","unresolved":true,"context_lines":[{"line_number":5948,"context_line":"        # Check if the volume has access to multiple IO_groups"},{"line_number":5949,"context_line":"        if model_update[\u0027metadata\u0027][\u0027pending_retype_iogrps\u0027]:"},{"line_number":5950,"context_line":"            vol_pending_retype_iogrps \u003d str(model_update[\u0027metadata\u0027][\u0027pending_retype_iogrps\u0027])"},{"line_number":5951,"context_line":"            vol_attrs \u003d self.get_vdisk_attributes(volume[\u0027name\u0027])"},{"line_number":5952,"context_line":"            vol_current_iogrp \u003d vol_attrs[\u0027IO_group_name\u0027]"},{"line_number":5953,"context_line":"            if (vol_attrs[\u0027access_IO_group_count\u0027] \u003e 1) and (vol_pending_retype_iogrps not in vol_current_iogrp):"},{"line_number":5954,"context_line":"                # Remove the access to the old IO_groups"}],"source_content_type":"text/x-python","patch_set":1,"id":"a747ad00_5a31ee37","line":5951,"updated":"2024-03-15 04:01:36.000000000","message":"do we need to make get_vdisk_attributes, isn\u0027t it alredy fetched during retype earlier. We don\u0027t need these changes to have additional performance impact","commit_id":"3ce9f834db54dc0d158844a825aa9d006a762550"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"3c106fca74ea718f1310d5daadb87330cfe3205f","unresolved":false,"context_lines":[{"line_number":5948,"context_line":"        # Check if the volume has access to multiple IO_groups"},{"line_number":5949,"context_line":"        if model_update[\u0027metadata\u0027][\u0027pending_retype_iogrps\u0027]:"},{"line_number":5950,"context_line":"            vol_pending_retype_iogrps \u003d str(model_update[\u0027metadata\u0027][\u0027pending_retype_iogrps\u0027])"},{"line_number":5951,"context_line":"            vol_attrs \u003d self.get_vdisk_attributes(volume[\u0027name\u0027])"},{"line_number":5952,"context_line":"            vol_current_iogrp \u003d vol_attrs[\u0027IO_group_name\u0027]"},{"line_number":5953,"context_line":"            if (vol_attrs[\u0027access_IO_group_count\u0027] \u003e 1) and (vol_pending_retype_iogrps not in vol_current_iogrp):"},{"line_number":5954,"context_line":"                # Remove the access to the old IO_groups"}],"source_content_type":"text/x-python","patch_set":1,"id":"3c7051cb_fce3003b","line":5951,"in_reply_to":"a747ad00_5a31ee37","updated":"2024-03-15 06:05:02.000000000","message":"Acknowledged","commit_id":"3ce9f834db54dc0d158844a825aa9d006a762550"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"3c106fca74ea718f1310d5daadb87330cfe3205f","unresolved":true,"context_lines":[{"line_number":5955,"context_line":"                try:"},{"line_number":5956,"context_line":"                    self.ssh.rmvdiskaccess(volume[\u0027name\u0027], vol_pending_retype_iogrps)"},{"line_number":5957,"context_line":"                    # Update model_update to update the volume metadata"},{"line_number":5958,"context_line":"                    del model_update[\u0027metadata\u0027][\u0027pending_retype_iogrps\u0027]"},{"line_number":5959,"context_line":"                except exception.VolumeBackendAPIException as err:"},{"line_number":5960,"context_line":"                    msg \u003d (_(\u0027Failed to remove volume %(volume)s from IO_groups %(iogrps)s.\u0027"},{"line_number":5961,"context_line":"                             \u0027Exception %(err)s\u0027), {\u0027volume\u0027: volume[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"cc807fa4_ffa237f7","line":5958,"updated":"2024-03-15 06:05:02.000000000","message":"db.volume_metadata_delete(context, volume_id, pending_retype_iogrps):","commit_id":"3ce9f834db54dc0d158844a825aa9d006a762550"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"3e377ac79f29c68b7a40f4f91cdc95644ac36a24","unresolved":false,"context_lines":[{"line_number":5955,"context_line":"                try:"},{"line_number":5956,"context_line":"                    self.ssh.rmvdiskaccess(volume[\u0027name\u0027], vol_pending_retype_iogrps)"},{"line_number":5957,"context_line":"                    # Update model_update to update the volume metadata"},{"line_number":5958,"context_line":"                    del model_update[\u0027metadata\u0027][\u0027pending_retype_iogrps\u0027]"},{"line_number":5959,"context_line":"                except exception.VolumeBackendAPIException as err:"},{"line_number":5960,"context_line":"                    msg \u003d (_(\u0027Failed to remove volume %(volume)s from IO_groups %(iogrps)s.\u0027"},{"line_number":5961,"context_line":"                             \u0027Exception %(err)s\u0027), {\u0027volume\u0027: volume[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"ed183c29_cef142cc","line":5958,"in_reply_to":"cc807fa4_ffa237f7","updated":"2024-03-18 07:55:33.000000000","message":"Resolved","commit_id":"3ce9f834db54dc0d158844a825aa9d006a762550"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"3c106fca74ea718f1310d5daadb87330cfe3205f","unresolved":true,"context_lines":[{"line_number":5968,"context_line":"                               \u0027volume %(volume)s is not in multiple IO_groups.\u0027),"},{"line_number":5969,"context_line":"                             {\u0027volume\u0027: volume[\u0027name\u0027]})"},{"line_number":5970,"context_line":"                LOG.error(error_msg)"},{"line_number":5971,"context_line":"                raise exception.InvalidInput(message\u003derror_msg)"},{"line_number":5972,"context_line":""},{"line_number":5973,"context_line":"        return model_update"},{"line_number":5974,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5d18b873_559e5681","line":5971,"updated":"2024-03-15 06:05:02.000000000","message":"It should just reset the pending iogrp metadata and not fail.","commit_id":"3ce9f834db54dc0d158844a825aa9d006a762550"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"3e377ac79f29c68b7a40f4f91cdc95644ac36a24","unresolved":false,"context_lines":[{"line_number":5968,"context_line":"                               \u0027volume %(volume)s is not in multiple IO_groups.\u0027),"},{"line_number":5969,"context_line":"                             {\u0027volume\u0027: volume[\u0027name\u0027]})"},{"line_number":5970,"context_line":"                LOG.error(error_msg)"},{"line_number":5971,"context_line":"                raise exception.InvalidInput(message\u003derror_msg)"},{"line_number":5972,"context_line":""},{"line_number":5973,"context_line":"        return model_update"},{"line_number":5974,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"74469903_149b3aea","line":5971,"in_reply_to":"5d18b873_559e5681","updated":"2024-03-18 07:55:33.000000000","message":"Resolved.","commit_id":"3ce9f834db54dc0d158844a825aa9d006a762550"},{"author":{"_account_id":36897,"name":"Girish Chilukuri","display_name":"Girish Chilukuri","email":"Girish.Chilukuri1@partner.ibm.com","username":"girishchilukuri1"},"change_message_id":"315dfe9e7e4cfd2dbe1d01249b27a3847af6245a","unresolved":true,"context_lines":[{"line_number":5952,"context_line":"        model_update[\u0027metadata\u0027] \u003d db_metadata if db_metadata else None"},{"line_number":5953,"context_line":""},{"line_number":5954,"context_line":"        # Check if the volume has access to multiple IO_groups"},{"line_number":5955,"context_line":"        if (\u0027pending_retype_iogrps\u0027 in model_update[\u0027metadata\u0027]"},{"line_number":5956,"context_line":"            and model_update[\u0027metadata\u0027][\u0027pending_retype_iogrps\u0027]):"},{"line_number":5957,"context_line":"            vol_pending_retype_iogrps \u003d ("},{"line_number":5958,"context_line":"              str(model_update[\u0027metadata\u0027][\u0027pending_retype_iogrps\u0027]))"},{"line_number":5959,"context_line":"            vol_attrs \u003d self.get_vdisk_attributes(volume[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"db6f5da4_ffdd9dac","line":5956,"range":{"start_line":5955,"start_character":12,"end_line":5956,"end_character":65},"updated":"2024-03-18 07:45:00.000000000","message":"This can be changed to model_update[\u0027metadata\u0027].get(\"pending_retype_iogrps\", None)","commit_id":"58cb5392db54a3b43bde8d04e6e4d8d1daa75edf"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"3e377ac79f29c68b7a40f4f91cdc95644ac36a24","unresolved":false,"context_lines":[{"line_number":5952,"context_line":"        model_update[\u0027metadata\u0027] \u003d db_metadata if db_metadata else None"},{"line_number":5953,"context_line":""},{"line_number":5954,"context_line":"        # Check if the volume has access to multiple IO_groups"},{"line_number":5955,"context_line":"        if (\u0027pending_retype_iogrps\u0027 in model_update[\u0027metadata\u0027]"},{"line_number":5956,"context_line":"            and model_update[\u0027metadata\u0027][\u0027pending_retype_iogrps\u0027]):"},{"line_number":5957,"context_line":"            vol_pending_retype_iogrps \u003d ("},{"line_number":5958,"context_line":"              str(model_update[\u0027metadata\u0027][\u0027pending_retype_iogrps\u0027]))"},{"line_number":5959,"context_line":"            vol_attrs \u003d self.get_vdisk_attributes(volume[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"af07c15d_4f03783d","line":5956,"range":{"start_line":5955,"start_character":12,"end_line":5956,"end_character":65},"in_reply_to":"db6f5da4_ffdd9dac","updated":"2024-03-18 07:55:33.000000000","message":"Resolved","commit_id":"58cb5392db54a3b43bde8d04e6e4d8d1daa75edf"},{"author":{"_account_id":36897,"name":"Girish Chilukuri","display_name":"Girish Chilukuri","email":"Girish.Chilukuri1@partner.ibm.com","username":"girishchilukuri1"},"change_message_id":"315dfe9e7e4cfd2dbe1d01249b27a3847af6245a","unresolved":true,"context_lines":[{"line_number":5957,"context_line":"            vol_pending_retype_iogrps \u003d ("},{"line_number":5958,"context_line":"              str(model_update[\u0027metadata\u0027][\u0027pending_retype_iogrps\u0027]))"},{"line_number":5959,"context_line":"            vol_attrs \u003d self.get_vdisk_attributes(volume[\u0027name\u0027])"},{"line_number":5960,"context_line":"            vol_current_iogrp \u003d vol_attrs[\u0027IO_group_name\u0027]"},{"line_number":5961,"context_line":"            if (vol_attrs[\u0027access_IO_group_count\u0027] \u003e 1)"},{"line_number":5962,"context_line":"              and (vol_pending_retype_iogrps not in vol_current_iogrp):"},{"line_number":5963,"context_line":"                # Remove the access to the old IO_groups"}],"source_content_type":"text/x-python","patch_set":5,"id":"f2a1aec7_cd15bd7f","line":5960,"updated":"2024-03-18 07:45:00.000000000","message":"\"IO_group_id\" should be used instead of \"IO_group_name\".","commit_id":"58cb5392db54a3b43bde8d04e6e4d8d1daa75edf"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"3e377ac79f29c68b7a40f4f91cdc95644ac36a24","unresolved":false,"context_lines":[{"line_number":5957,"context_line":"            vol_pending_retype_iogrps \u003d ("},{"line_number":5958,"context_line":"              str(model_update[\u0027metadata\u0027][\u0027pending_retype_iogrps\u0027]))"},{"line_number":5959,"context_line":"            vol_attrs \u003d self.get_vdisk_attributes(volume[\u0027name\u0027])"},{"line_number":5960,"context_line":"            vol_current_iogrp \u003d vol_attrs[\u0027IO_group_name\u0027]"},{"line_number":5961,"context_line":"            if (vol_attrs[\u0027access_IO_group_count\u0027] \u003e 1)"},{"line_number":5962,"context_line":"              and (vol_pending_retype_iogrps not in vol_current_iogrp):"},{"line_number":5963,"context_line":"                # Remove the access to the old IO_groups"}],"source_content_type":"text/x-python","patch_set":5,"id":"a46682b8_ef9990f7","line":5960,"in_reply_to":"f2a1aec7_cd15bd7f","updated":"2024-03-18 07:55:33.000000000","message":"In def retype_iogrp_property() new and old arguments represent the iogroup_name and not iogrpup_id. Hence i took the IO_group_name as the vol_attribute to do the validation.","commit_id":"58cb5392db54a3b43bde8d04e6e4d8d1daa75edf"},{"author":{"_account_id":36897,"name":"Girish Chilukuri","display_name":"Girish Chilukuri","email":"Girish.Chilukuri1@partner.ibm.com","username":"girishchilukuri1"},"change_message_id":"315dfe9e7e4cfd2dbe1d01249b27a3847af6245a","unresolved":true,"context_lines":[{"line_number":5958,"context_line":"              str(model_update[\u0027metadata\u0027][\u0027pending_retype_iogrps\u0027]))"},{"line_number":5959,"context_line":"            vol_attrs \u003d self.get_vdisk_attributes(volume[\u0027name\u0027])"},{"line_number":5960,"context_line":"            vol_current_iogrp \u003d vol_attrs[\u0027IO_group_name\u0027]"},{"line_number":5961,"context_line":"            if (vol_attrs[\u0027access_IO_group_count\u0027] \u003e 1)"},{"line_number":5962,"context_line":"              and (vol_pending_retype_iogrps not in vol_current_iogrp):"},{"line_number":5963,"context_line":"                # Remove the access to the old IO_groups"},{"line_number":5964,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"d76ffc45_fc0f0df5","line":5961,"range":{"start_line":5961,"start_character":16,"end_line":5961,"end_character":50},"updated":"2024-03-18 07:45:00.000000000","message":"vol_attrs[\u0027access_IO_group_count\u0027] should be converted to int before comparing.","commit_id":"58cb5392db54a3b43bde8d04e6e4d8d1daa75edf"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"3e377ac79f29c68b7a40f4f91cdc95644ac36a24","unresolved":false,"context_lines":[{"line_number":5958,"context_line":"              str(model_update[\u0027metadata\u0027][\u0027pending_retype_iogrps\u0027]))"},{"line_number":5959,"context_line":"            vol_attrs \u003d self.get_vdisk_attributes(volume[\u0027name\u0027])"},{"line_number":5960,"context_line":"            vol_current_iogrp \u003d vol_attrs[\u0027IO_group_name\u0027]"},{"line_number":5961,"context_line":"            if (vol_attrs[\u0027access_IO_group_count\u0027] \u003e 1)"},{"line_number":5962,"context_line":"              and (vol_pending_retype_iogrps not in vol_current_iogrp):"},{"line_number":5963,"context_line":"                # Remove the access to the old IO_groups"},{"line_number":5964,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"e7a80a75_96c73201","line":5961,"range":{"start_line":5961,"start_character":16,"end_line":5961,"end_character":50},"in_reply_to":"d76ffc45_fc0f0df5","updated":"2024-03-18 07:55:33.000000000","message":"Resolved.","commit_id":"58cb5392db54a3b43bde8d04e6e4d8d1daa75edf"},{"author":{"_account_id":24005,"name":"prashkre","email":"prashkre@in.ibm.com","username":"prashkre"},"change_message_id":"459826cdc0516d113062c910c276b466cefe5953","unresolved":true,"context_lines":[{"line_number":5820,"context_line":""},{"line_number":5821,"context_line":"                retype_iogrp_property(volume,"},{"line_number":5822,"context_line":"                                      new_io_grp, old_io_grp)"},{"line_number":5823,"context_line":"                model_update[\u0027metadata\u0027] \u003d {"},{"line_number":5824,"context_line":"                  \u0027pending_retype_iogrps\u0027: old_io_grp}"},{"line_number":5825,"context_line":"                try:"},{"line_number":5826,"context_line":"                    if self._state[\u0027code_level\u0027] \u003c (7, 6, 0, 0):"}],"source_content_type":"text/x-python","patch_set":7,"id":"b5e7d840_5feaa4a7","line":5823,"updated":"2024-03-20 10:32:48.000000000","message":"Need to add below metadata properties to know about host details.\n\nmetadata : { pending_retype: true, old_iogrp: \u003c\u003cold_iogrp\u003e\u003e, current_iogrp: \u003c\u003ccurrent_iogrp\u003e\u003e, hostname: “vm_name” }","commit_id":"e6f35de0dfc144448cd2972e955a3d3792c9f2d1"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"ebe07e5de2a55b4a2a957b65b6082d9c3147a694","unresolved":false,"context_lines":[{"line_number":5820,"context_line":""},{"line_number":5821,"context_line":"                retype_iogrp_property(volume,"},{"line_number":5822,"context_line":"                                      new_io_grp, old_io_grp)"},{"line_number":5823,"context_line":"                model_update[\u0027metadata\u0027] \u003d {"},{"line_number":5824,"context_line":"                  \u0027pending_retype_iogrps\u0027: old_io_grp}"},{"line_number":5825,"context_line":"                try:"},{"line_number":5826,"context_line":"                    if self._state[\u0027code_level\u0027] \u003c (7, 6, 0, 0):"}],"source_content_type":"text/x-python","patch_set":7,"id":"20860e2d_3ce67c5f","line":5823,"in_reply_to":"b3f44b97_f6f69404","updated":"2024-03-27 13:02:09.000000000","message":"Acknowledged.","commit_id":"e6f35de0dfc144448cd2972e955a3d3792c9f2d1"},{"author":{"_account_id":24005,"name":"prashkre","email":"prashkre@in.ibm.com","username":"prashkre"},"change_message_id":"58d3a1c86b99448a59f0e53700246c09f755ded5","unresolved":true,"context_lines":[{"line_number":5820,"context_line":""},{"line_number":5821,"context_line":"                retype_iogrp_property(volume,"},{"line_number":5822,"context_line":"                                      new_io_grp, old_io_grp)"},{"line_number":5823,"context_line":"                model_update[\u0027metadata\u0027] \u003d {"},{"line_number":5824,"context_line":"                  \u0027pending_retype_iogrps\u0027: old_io_grp}"},{"line_number":5825,"context_line":"                try:"},{"line_number":5826,"context_line":"                    if self._state[\u0027code_level\u0027] \u003c (7, 6, 0, 0):"}],"source_content_type":"text/x-python","patch_set":7,"id":"b3f44b97_f6f69404","line":5823,"in_reply_to":"b5e7d840_5feaa4a7","updated":"2024-03-21 06:47:49.000000000","message":"@Harsh, here is the ask from customer\n\npending retype, volume-name, hostname, storagename,from_temp(old template),to-template(new template), time and date.","commit_id":"e6f35de0dfc144448cd2972e955a3d3792c9f2d1"},{"author":{"_account_id":36897,"name":"Girish Chilukuri","display_name":"Girish Chilukuri","email":"Girish.Chilukuri1@partner.ibm.com","username":"girishchilukuri1"},"change_message_id":"03f74782c5edc6ae4093c95ca0e2e1b085f5b91a","unresolved":true,"context_lines":[{"line_number":5724,"context_line":"                     host[\u0027host\u0027] is its name, and host[\u0027capabilities\u0027] is a"},{"line_number":5725,"context_line":"                     dictionary of its reported capabilities."},{"line_number":5726,"context_line":"        \"\"\""},{"line_number":5727,"context_line":"        def retype_iogrp_property(volume, new, old, host_attached):"},{"line_number":5728,"context_line":"            if new !\u003d old:"},{"line_number":5729,"context_line":"                host_attached \u003d False"},{"line_number":5730,"context_line":"                pending_retype \u003d False"}],"source_content_type":"text/x-python","patch_set":10,"id":"195d6146_c70141cc","line":5727,"range":{"start_line":5727,"start_character":52,"end_line":5727,"end_character":65},"updated":"2024-03-29 08:47:53.000000000","message":"host_attached can be removed","commit_id":"11759e34e1dc41a4a04848f6214efe42fbe5a8f0"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"6d5dffa258d3f1d118bf9c12e8f8762bbaabdd84","unresolved":false,"context_lines":[{"line_number":5724,"context_line":"                     host[\u0027host\u0027] is its name, and host[\u0027capabilities\u0027] is a"},{"line_number":5725,"context_line":"                     dictionary of its reported capabilities."},{"line_number":5726,"context_line":"        \"\"\""},{"line_number":5727,"context_line":"        def retype_iogrp_property(volume, new, old, host_attached):"},{"line_number":5728,"context_line":"            if new !\u003d old:"},{"line_number":5729,"context_line":"                host_attached \u003d False"},{"line_number":5730,"context_line":"                pending_retype \u003d False"}],"source_content_type":"text/x-python","patch_set":10,"id":"5ba930b0_bc96f6f6","line":5727,"range":{"start_line":5727,"start_character":52,"end_line":5727,"end_character":65},"in_reply_to":"195d6146_c70141cc","updated":"2024-03-29 09:26:30.000000000","message":"Resolved","commit_id":"11759e34e1dc41a4a04848f6214efe42fbe5a8f0"},{"author":{"_account_id":36897,"name":"Girish Chilukuri","display_name":"Girish Chilukuri","email":"Girish.Chilukuri1@partner.ibm.com","username":"girishchilukuri1"},"change_message_id":"03f74782c5edc6ae4093c95ca0e2e1b085f5b91a","unresolved":true,"context_lines":[{"line_number":6008,"context_line":"        del model_update[\u0027metadata\u0027][\u0027pending_retype\u0027]"},{"line_number":6009,"context_line":"        del model_update[\u0027metadata\u0027][\u0027old_iogroup\u0027]"},{"line_number":6010,"context_line":"        del model_update[\u0027metadata\u0027][\u0027iogrp_retype_date_time\u0027]"},{"line_number":6011,"context_line":"        self.db.volume_metadata_delete(context.get_admin_context(),"},{"line_number":6012,"context_line":"                                       volume[\u0027id\u0027],"},{"line_number":6013,"context_line":"                                       \u0027pending_retype\u0027)"},{"line_number":6014,"context_line":"        self.db.volume_metadata_delete(context.get_admin_context(),"}],"source_content_type":"text/x-python","patch_set":10,"id":"75ee3de1_0e023255","line":6011,"updated":"2024-03-29 08:47:53.000000000","message":"Delete all the metadata properties which are added during retype.","commit_id":"11759e34e1dc41a4a04848f6214efe42fbe5a8f0"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"6d5dffa258d3f1d118bf9c12e8f8762bbaabdd84","unresolved":false,"context_lines":[{"line_number":6008,"context_line":"        del model_update[\u0027metadata\u0027][\u0027pending_retype\u0027]"},{"line_number":6009,"context_line":"        del model_update[\u0027metadata\u0027][\u0027old_iogroup\u0027]"},{"line_number":6010,"context_line":"        del model_update[\u0027metadata\u0027][\u0027iogrp_retype_date_time\u0027]"},{"line_number":6011,"context_line":"        self.db.volume_metadata_delete(context.get_admin_context(),"},{"line_number":6012,"context_line":"                                       volume[\u0027id\u0027],"},{"line_number":6013,"context_line":"                                       \u0027pending_retype\u0027)"},{"line_number":6014,"context_line":"        self.db.volume_metadata_delete(context.get_admin_context(),"}],"source_content_type":"text/x-python","patch_set":10,"id":"8f87e8ae_c119348b","line":6011,"in_reply_to":"75ee3de1_0e023255","updated":"2024-03-29 09:26:30.000000000","message":"Resolved","commit_id":"11759e34e1dc41a4a04848f6214efe42fbe5a8f0"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"cf1a6ca8220c0c31e8b0e3ffbe3cd268763c59fe","unresolved":true,"context_lines":[{"line_number":5731,"context_line":"                vol_host_info_list \u003d []"},{"line_number":5732,"context_line":"                # Check if the volume is in \u0027in-use\u0027 state"},{"line_number":5733,"context_line":"                if volume.previous_status \u003d\u003d \u0027in-use\u0027:"},{"line_number":5734,"context_line":"                    LOG.info(\"retype_iogrp_property for \u0027in-use\u0027\""},{"line_number":5735,"context_line":"                             \"volume %(id)s\", {\u0027id\u0027: volume[\u0027id\u0027]})"},{"line_number":5736,"context_line":"                    vol_host_info \u003d self._helpers.ssh.lsvdiskhostmap("},{"line_number":5737,"context_line":"                        volume.name)"}],"source_content_type":"text/x-python","patch_set":14,"id":"b40f6f81_d2f5e293","line":5734,"range":{"start_line":5734,"start_character":63,"end_line":5734,"end_character":65},"updated":"2024-04-02 12:54:02.000000000","message":"nit: space can be added at end","commit_id":"04438849879497a1219b33ac53b77d9f69b7bc1b"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"564ca763e53b09427811c925114ad119c4e9bcec","unresolved":false,"context_lines":[{"line_number":5731,"context_line":"                vol_host_info_list \u003d []"},{"line_number":5732,"context_line":"                # Check if the volume is in \u0027in-use\u0027 state"},{"line_number":5733,"context_line":"                if volume.previous_status \u003d\u003d \u0027in-use\u0027:"},{"line_number":5734,"context_line":"                    LOG.info(\"retype_iogrp_property for \u0027in-use\u0027\""},{"line_number":5735,"context_line":"                             \"volume %(id)s\", {\u0027id\u0027: volume[\u0027id\u0027]})"},{"line_number":5736,"context_line":"                    vol_host_info \u003d self._helpers.ssh.lsvdiskhostmap("},{"line_number":5737,"context_line":"                        volume.name)"}],"source_content_type":"text/x-python","patch_set":14,"id":"20f393ec_35926bd7","line":5734,"range":{"start_line":5734,"start_character":63,"end_line":5734,"end_character":65},"in_reply_to":"b40f6f81_d2f5e293","updated":"2024-12-26 08:49:36.000000000","message":"Resolved.","commit_id":"04438849879497a1219b33ac53b77d9f69b7bc1b"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"cf1a6ca8220c0c31e8b0e3ffbe3cd268763c59fe","unresolved":true,"context_lines":[{"line_number":5989,"context_line":"                                           old_iogroup)"},{"line_number":5990,"context_line":"                except exception.VolumeBackendAPIException as err:"},{"line_number":5991,"context_line":"                    msg \u003d (_(\u0027Failed to remove volume %(volume)s from \u0027"},{"line_number":5992,"context_line":"                             \u0027IO_groups %(iogrps)s.\u0027"},{"line_number":5993,"context_line":"                             \u0027Exception %(err)s\u0027), {\u0027volume\u0027: volume[\u0027name\u0027],"},{"line_number":5994,"context_line":"                                                    \u0027iogrps\u0027: old_iogroup,"},{"line_number":5995,"context_line":"                                                    \u0027err\u0027: err})"}],"source_content_type":"text/x-python","patch_set":14,"id":"adc4cf54_48d4e98b","line":5992,"range":{"start_line":5992,"start_character":50,"end_line":5992,"end_character":52},"updated":"2024-04-02 12:54:02.000000000","message":"nit: space can be added here also.","commit_id":"04438849879497a1219b33ac53b77d9f69b7bc1b"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"564ca763e53b09427811c925114ad119c4e9bcec","unresolved":false,"context_lines":[{"line_number":5989,"context_line":"                                           old_iogroup)"},{"line_number":5990,"context_line":"                except exception.VolumeBackendAPIException as err:"},{"line_number":5991,"context_line":"                    msg \u003d (_(\u0027Failed to remove volume %(volume)s from \u0027"},{"line_number":5992,"context_line":"                             \u0027IO_groups %(iogrps)s.\u0027"},{"line_number":5993,"context_line":"                             \u0027Exception %(err)s\u0027), {\u0027volume\u0027: volume[\u0027name\u0027],"},{"line_number":5994,"context_line":"                                                    \u0027iogrps\u0027: old_iogroup,"},{"line_number":5995,"context_line":"                                                    \u0027err\u0027: err})"}],"source_content_type":"text/x-python","patch_set":14,"id":"2659cfa3_f8d6ce5e","line":5992,"range":{"start_line":5992,"start_character":50,"end_line":5992,"end_character":52},"in_reply_to":"adc4cf54_48d4e98b","updated":"2024-12-26 08:49:36.000000000","message":"Resolved","commit_id":"04438849879497a1219b33ac53b77d9f69b7bc1b"},{"author":{"_account_id":36897,"name":"Girish Chilukuri","display_name":"Girish Chilukuri","email":"Girish.Chilukuri1@partner.ibm.com","username":"girishchilukuri1"},"change_message_id":"777115ef260740103976b17f6615e4d51f783e95","unresolved":true,"context_lines":[{"line_number":5836,"context_line":""},{"line_number":5837,"context_line":"                try:"},{"line_number":5838,"context_line":"                    pending_retype, vol_host_info_list \u003d ("},{"line_number":5839,"context_line":"                        retype_iogrp_property(ctxt, volume,"},{"line_number":5840,"context_line":"                                              new_io_grp, old_io_grp,"},{"line_number":5841,"context_line":"                                              new_type))"},{"line_number":5842,"context_line":"                    if pending_retype:"}],"source_content_type":"text/x-python","patch_set":18,"id":"59efd714_170fe141","line":5839,"updated":"2025-05-21 07:40:08.000000000","message":"self.retype_iogrp_property","commit_id":"60a12796f65a759805212234077f0f443a07c603"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"056a8b99f282f4fa5166f7c28fde08913d327bd6","unresolved":false,"context_lines":[{"line_number":5836,"context_line":""},{"line_number":5837,"context_line":"                try:"},{"line_number":5838,"context_line":"                    pending_retype, vol_host_info_list \u003d ("},{"line_number":5839,"context_line":"                        retype_iogrp_property(ctxt, volume,"},{"line_number":5840,"context_line":"                                              new_io_grp, old_io_grp,"},{"line_number":5841,"context_line":"                                              new_type))"},{"line_number":5842,"context_line":"                    if pending_retype:"}],"source_content_type":"text/x-python","patch_set":18,"id":"9b771208_7037837d","line":5839,"in_reply_to":"59efd714_170fe141","updated":"2025-06-09 15:20:42.000000000","message":"Resolved","commit_id":"60a12796f65a759805212234077f0f443a07c603"},{"author":{"_account_id":36897,"name":"Girish Chilukuri","display_name":"Girish Chilukuri","email":"Girish.Chilukuri1@partner.ibm.com","username":"girishchilukuri1"},"change_message_id":"777115ef260740103976b17f6615e4d51f783e95","unresolved":true,"context_lines":[{"line_number":5890,"context_line":"                    msg \u003d (_(\u0027Unable to retype volume %(vol)s to iogrp\u0027"},{"line_number":5891,"context_line":"                             \u0027 %(iogrp)s, error is %(err)s\u0027),"},{"line_number":5892,"context_line":"                           dict(vol\u003dvolume[\u0027id\u0027], iogrp\u003dnew_io_grp,"},{"line_number":5893,"context_line":"                               err\u003dsix.text_type(ex)))"},{"line_number":5894,"context_line":"                    raise exception.VolumeDriverException(message\u003dmsg)"},{"line_number":5895,"context_line":""},{"line_number":5896,"context_line":"                self._helpers.change_vdisk_options(volume[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":18,"id":"d6810f99_e5ba92e8","line":5893,"updated":"2025-05-21 07:40:08.000000000","message":"import six module","commit_id":"60a12796f65a759805212234077f0f443a07c603"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"056a8b99f282f4fa5166f7c28fde08913d327bd6","unresolved":false,"context_lines":[{"line_number":5890,"context_line":"                    msg \u003d (_(\u0027Unable to retype volume %(vol)s to iogrp\u0027"},{"line_number":5891,"context_line":"                             \u0027 %(iogrp)s, error is %(err)s\u0027),"},{"line_number":5892,"context_line":"                           dict(vol\u003dvolume[\u0027id\u0027], iogrp\u003dnew_io_grp,"},{"line_number":5893,"context_line":"                               err\u003dsix.text_type(ex)))"},{"line_number":5894,"context_line":"                    raise exception.VolumeDriverException(message\u003dmsg)"},{"line_number":5895,"context_line":""},{"line_number":5896,"context_line":"                self._helpers.change_vdisk_options(volume[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":18,"id":"45e1f412_e99ed80a","line":5893,"in_reply_to":"d6810f99_e5ba92e8","updated":"2025-06-09 15:20:42.000000000","message":"Resolved","commit_id":"60a12796f65a759805212234077f0f443a07c603"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c5a0c808133ad44e4362f5aaf34ff3739a7be30a","unresolved":true,"context_lines":[{"line_number":19,"context_line":"import re"},{"line_number":20,"context_line":"import time"},{"line_number":21,"context_line":"import unicodedata"},{"line_number":22,"context_line":"import six"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from eventlet import greenthread"},{"line_number":25,"context_line":"from oslo_concurrency import processutils"}],"source_content_type":"text/x-python","patch_set":22,"id":"8284883c_a755449f","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":10},"updated":"2025-08-18 14:43:26.000000000","message":"we have removed the six support as we only support python3 (so no need of py2 compatibility) so it is strongly discouraged to use six in favor of py3 syntax","commit_id":"7de012f3d2ce6f2084413a4c9f1840bd6e9f6d4f"},{"author":{"_account_id":37328,"name":"Nimesh Desai","display_name":"Nimesh Desai","email":"nimesh.desai@ibm.com","username":"nimeshdesai"},"change_message_id":"f934174876d370c782eb6ac2c9f3be5a777483ef","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import re"},{"line_number":20,"context_line":"import time"},{"line_number":21,"context_line":"import unicodedata"},{"line_number":22,"context_line":"import six"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from eventlet import greenthread"},{"line_number":25,"context_line":"from oslo_concurrency import processutils"}],"source_content_type":"text/x-python","patch_set":22,"id":"f6a001cd_82d9c9f5","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":10},"in_reply_to":"8284883c_a755449f","updated":"2025-08-20 13:55:38.000000000","message":"Done","commit_id":"7de012f3d2ce6f2084413a4c9f1840bd6e9f6d4f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c5a0c808133ad44e4362f5aaf34ff3739a7be30a","unresolved":true,"context_lines":[{"line_number":5912,"context_line":"                    msg \u003d (_(\u0027Unable to retype volume %(vol)s to iogrp\u0027"},{"line_number":5913,"context_line":"                             \u0027 %(iogrp)s, error is %(err)s\u0027),"},{"line_number":5914,"context_line":"                           dict(vol\u003dvolume[\u0027id\u0027], iogrp\u003dnew_io_grp,"},{"line_number":5915,"context_line":"                                err\u003dsix.text_type(ex)))"},{"line_number":5916,"context_line":"                    raise exception.VolumeDriverException(message\u003dmsg)"},{"line_number":5917,"context_line":""},{"line_number":5918,"context_line":"                self._helpers.change_vdisk_options(volume[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":22,"id":"c113d270_d65375f6","line":5915,"range":{"start_line":5915,"start_character":36,"end_line":5915,"end_character":53},"updated":"2025-08-18 14:43:26.000000000","message":"just do str(ex) and remove the six import","commit_id":"7de012f3d2ce6f2084413a4c9f1840bd6e9f6d4f"},{"author":{"_account_id":37328,"name":"Nimesh Desai","display_name":"Nimesh Desai","email":"nimesh.desai@ibm.com","username":"nimeshdesai"},"change_message_id":"f934174876d370c782eb6ac2c9f3be5a777483ef","unresolved":false,"context_lines":[{"line_number":5912,"context_line":"                    msg \u003d (_(\u0027Unable to retype volume %(vol)s to iogrp\u0027"},{"line_number":5913,"context_line":"                             \u0027 %(iogrp)s, error is %(err)s\u0027),"},{"line_number":5914,"context_line":"                           dict(vol\u003dvolume[\u0027id\u0027], iogrp\u003dnew_io_grp,"},{"line_number":5915,"context_line":"                                err\u003dsix.text_type(ex)))"},{"line_number":5916,"context_line":"                    raise exception.VolumeDriverException(message\u003dmsg)"},{"line_number":5917,"context_line":""},{"line_number":5918,"context_line":"                self._helpers.change_vdisk_options(volume[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":22,"id":"c6df4003_61828975","line":5915,"range":{"start_line":5915,"start_character":36,"end_line":5915,"end_character":53},"in_reply_to":"c113d270_d65375f6","updated":"2025-08-20 13:55:38.000000000","message":"Done","commit_id":"7de012f3d2ce6f2084413a4c9f1840bd6e9f6d4f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c5a0c808133ad44e4362f5aaf34ff3739a7be30a","unresolved":true,"context_lines":[{"line_number":6033,"context_line":"                                                   \u0027host\u0027: host[\u0027host\u0027]})"},{"line_number":6034,"context_line":"        return True, model_update"},{"line_number":6035,"context_line":""},{"line_number":6036,"context_line":"    def retype_volume_completion(self, ctxt, volume):"},{"line_number":6037,"context_line":"        \"\"\"Perform post-retype operations."},{"line_number":6038,"context_line":""},{"line_number":6039,"context_line":"        :param ctxt: The context used to run the method retype_completion"}],"source_content_type":"text/x-python","patch_set":22,"id":"27d42f01_88575611","line":6036,"range":{"start_line":6036,"start_character":8,"end_line":6036,"end_character":32},"updated":"2025-08-18 14:43:26.000000000","message":"i don\u0027t see either cinder or storwize driver calling this method, what\u0027s the purpose exactly and did we verify if it\u0027s even being called?\nwe have a migrate_volume_completion method but that\u0027s part of volume manager and also doesn\u0027t call driver so not sure what we are trying to achieve here.","commit_id":"7de012f3d2ce6f2084413a4c9f1840bd6e9f6d4f"},{"author":{"_account_id":37328,"name":"Nimesh Desai","display_name":"Nimesh Desai","email":"nimesh.desai@ibm.com","username":"nimeshdesai"},"change_message_id":"f934174876d370c782eb6ac2c9f3be5a777483ef","unresolved":false,"context_lines":[{"line_number":6033,"context_line":"                                                   \u0027host\u0027: host[\u0027host\u0027]})"},{"line_number":6034,"context_line":"        return True, model_update"},{"line_number":6035,"context_line":""},{"line_number":6036,"context_line":"    def retype_volume_completion(self, ctxt, volume):"},{"line_number":6037,"context_line":"        \"\"\"Perform post-retype operations."},{"line_number":6038,"context_line":""},{"line_number":6039,"context_line":"        :param ctxt: The context used to run the method retype_completion"}],"source_content_type":"text/x-python","patch_set":22,"id":"efb13007_5cc62d50","line":6036,"range":{"start_line":6036,"start_character":8,"end_line":6036,"end_character":32},"in_reply_to":"27d42f01_88575611","updated":"2025-08-20 13:55:38.000000000","message":"Acknowledged, added comment to make the usage clear","commit_id":"7de012f3d2ce6f2084413a4c9f1840bd6e9f6d4f"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"96a1553783870883760d9f238cbf050ee0e0f94d","unresolved":true,"context_lines":[{"line_number":5884,"context_line":"                            ctxt, volume.volume_type_id))"},{"line_number":5885,"context_line":"                    self.retype_iogrp_property("},{"line_number":5886,"context_line":"                        ctxt, volume, old_io_grp, new_io_grp, old_type)"},{"line_number":5887,"context_line":"                    msg \u003d (_(\u0027Unable to retype: A copy of volume %s exists. \u0027"},{"line_number":5888,"context_line":"                             \u0027Retyping would exceed the limit of 2 copies.\u0027),"},{"line_number":5889,"context_line":"                           volume[\u0027id\u0027])"},{"line_number":5890,"context_line":"                    raise exception.VolumeDriverException(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":23,"id":"54b6a8e5_cda8b32a","line":5887,"updated":"2025-11-07 16:15:09.000000000","message":"I wonder if this message should be logged before the attempted re-retyping in case that also fails and throws.","commit_id":"ed48542f1154682f5a738d3703443af10a3af64d"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"c8f2df1b866e3c2e89b51b81ee827a6e0b0c66de","unresolved":false,"context_lines":[{"line_number":5884,"context_line":"                            ctxt, volume.volume_type_id))"},{"line_number":5885,"context_line":"                    self.retype_iogrp_property("},{"line_number":5886,"context_line":"                        ctxt, volume, old_io_grp, new_io_grp, old_type)"},{"line_number":5887,"context_line":"                    msg \u003d (_(\u0027Unable to retype: A copy of volume %s exists. \u0027"},{"line_number":5888,"context_line":"                             \u0027Retyping would exceed the limit of 2 copies.\u0027),"},{"line_number":5889,"context_line":"                           volume[\u0027id\u0027])"},{"line_number":5890,"context_line":"                    raise exception.VolumeDriverException(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":23,"id":"62c3d81c_315de9b1","line":5887,"in_reply_to":"54b6a8e5_cda8b32a","updated":"2025-12-19 10:12:44.000000000","message":"Even if that fails, it would roll back and print this message and raise the exception.","commit_id":"ed48542f1154682f5a738d3703443af10a3af64d"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"96a1553783870883760d9f238cbf050ee0e0f94d","unresolved":true,"context_lines":[{"line_number":5908,"context_line":"                            ctxt, volume.volume_type_id))"},{"line_number":5909,"context_line":"                    self.retype_iogrp_property("},{"line_number":5910,"context_line":"                        ctxt, volume, old_io_grp, new_io_grp, old_type)"},{"line_number":5911,"context_line":"                    msg \u003d (_(\u0027Unable to retype volume %(vol)s to iogrp\u0027"},{"line_number":5912,"context_line":"                             \u0027 %(iogrp)s, error is %(err)s\u0027),"},{"line_number":5913,"context_line":"                           dict(vol\u003dvolume[\u0027id\u0027], iogrp\u003dnew_io_grp,"},{"line_number":5914,"context_line":"                                err\u003dstr(ex)))"}],"source_content_type":"text/x-python","patch_set":23,"id":"d00973d7_d92bcaf9","line":5911,"updated":"2025-11-07 16:15:09.000000000","message":"Same as above - I wonder if we should log this before trying to undo.","commit_id":"ed48542f1154682f5a738d3703443af10a3af64d"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"c8f2df1b866e3c2e89b51b81ee827a6e0b0c66de","unresolved":false,"context_lines":[{"line_number":5908,"context_line":"                            ctxt, volume.volume_type_id))"},{"line_number":5909,"context_line":"                    self.retype_iogrp_property("},{"line_number":5910,"context_line":"                        ctxt, volume, old_io_grp, new_io_grp, old_type)"},{"line_number":5911,"context_line":"                    msg \u003d (_(\u0027Unable to retype volume %(vol)s to iogrp\u0027"},{"line_number":5912,"context_line":"                             \u0027 %(iogrp)s, error is %(err)s\u0027),"},{"line_number":5913,"context_line":"                           dict(vol\u003dvolume[\u0027id\u0027], iogrp\u003dnew_io_grp,"},{"line_number":5914,"context_line":"                                err\u003dstr(ex)))"}],"source_content_type":"text/x-python","patch_set":23,"id":"4a43607a_9b078819","line":5911,"in_reply_to":"d00973d7_d92bcaf9","updated":"2025-12-19 10:12:44.000000000","message":"Same as above i believe.","commit_id":"ed48542f1154682f5a738d3703443af10a3af64d"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"3edb5471006af1cd916059ca24e96c35a764964a","unresolved":true,"context_lines":[{"line_number":6080,"context_line":""},{"line_number":6081,"context_line":"        # Update the volume metadata"},{"line_number":6082,"context_line":"        model_update[\u0027metadata\u0027].pop(\u0027pending_retype\u0027)"},{"line_number":6083,"context_line":"        self.db.volume_metadata_delete(ctxt, volume[\u0027id\u0027], \u0027pending_retype\u0027)"},{"line_number":6084,"context_line":""},{"line_number":6085,"context_line":"        return model_update"},{"line_number":6086,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"43aa6e32_b57072a6","line":6083,"updated":"2026-03-06 19:11:46.000000000","message":"can you try volume.metadata.get. you are doing direct db access. Can you check other places and correct if required.","commit_id":"ed48542f1154682f5a738d3703443af10a3af64d"}]}