)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b82cf2ffde2d28dc085c3e7d710296a19ef0da0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3e1e44c6_00ab92df","updated":"2024-04-25 18:04:12.000000000","message":"recheck\n\nlvm-lio-barbican failed in tempest.api.volume.test_volumes_actions.VolumesActionsTest.test_volume_upload","commit_id":"67d3bb3408a9352c16729d907ed537c2bc94ee48"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c5ec2b926a4e7481c2a7bdcc9550a7e87828ced1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a2a3afab_2bd31d72","updated":"2024-04-19 15:04:59.000000000","message":"recheck\n\ntempest-integrated-storage failed because oom-killer activated","commit_id":"67d3bb3408a9352c16729d907ed537c2bc94ee48"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"cce54b231462d82d9f67997ff824f22d63982d63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c906fd79_4422a183","updated":"2024-07-29 17:20:56.000000000","message":"So, just enable it and done? Sounds good to me!","commit_id":"26d2d1dffebecac3baedfcaacb0d19c3beddb927"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"188c3cdfaa4598b523e769e22ec9d30b9c195121","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1b35fa55_8a5ae308","updated":"2025-08-18 18:52:53.000000000","message":"Let\u0027s get this merged before the code changes and we have to fix it.","commit_id":"4e8b260583ff55276c82d420681c18fad9a335c2"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"8eb7e51d988e75e1d2072d529168d523aef32f48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"67caf65d_4cfd24d8","updated":"2025-08-19 14:59:48.000000000","message":"OK","commit_id":"4e8b260583ff55276c82d420681c18fad9a335c2"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0708cd76224a360c8d30a211124da20191736aa3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"91fed284_a870c670","updated":"2025-08-28 13:37:09.000000000","message":"recheck\n\nThe patch this patch depends on has merged","commit_id":"4e8b260583ff55276c82d420681c18fad9a335c2"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a0e79614d371b36f24e0741c51ed69abf0d11d9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0ad80db7_4254bc79","updated":"2025-08-28 18:57:42.000000000","message":"recheck\n\ngrenade-skip-level-always usermod segfault","commit_id":"4e8b260583ff55276c82d420681c18fad9a335c2"}],"cinder/volume/volume_types.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"8448a1cdbf069e24fb2992fa8f0dce7d225d61d5","unresolved":true,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"@overload"},{"line_number":244,"context_line":"def get_volume_type_extra_specs(volume_type_id: str, key: None) -\u003e dict:"},{"line_number":245,"context_line":"    ..."},{"line_number":246,"context_line":""},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"@overload"}],"source_content_type":"text/x-python","patch_set":1,"id":"e5a96f76_675b478d","line":245,"updated":"2024-05-18 03:08:22.000000000","message":"Not sure how this @overload thing works, but would it not be simpler to change the code to use a more conventional \u003dNone default? Would it knock down 1 @overload out of 3 cases?","commit_id":"67d3bb3408a9352c16729d907ed537c2bc94ee48"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"7c20907dfa63c6b468c020e502f2907656d6a6cc","unresolved":true,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"@overload"},{"line_number":244,"context_line":"def get_volume_type_extra_specs(volume_type_id: str, key: None) -\u003e dict:"},{"line_number":245,"context_line":"    ..."},{"line_number":246,"context_line":""},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"@overload"}],"source_content_type":"text/x-python","patch_set":1,"id":"43c82a5d_09d966f8","line":245,"in_reply_to":"1289d283_a1ae7ecb","updated":"2024-05-22 12:56:19.000000000","message":"Refactoring this is definitely a good idea, my aim with most of the patches to add type coverage is just to annotate w/ as little change as possible.  I like 919993.","commit_id":"67d3bb3408a9352c16729d907ed537c2bc94ee48"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"9f5c6f67c99396d98e9b9b5d8d9328c87e9c7925","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"@overload"},{"line_number":244,"context_line":"def get_volume_type_extra_specs(volume_type_id: str, key: None) -\u003e dict:"},{"line_number":245,"context_line":"    ..."},{"line_number":246,"context_line":""},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"@overload"}],"source_content_type":"text/x-python","patch_set":1,"id":"6e366c44_56364cdb","line":245,"in_reply_to":"43c82a5d_09d966f8","updated":"2024-07-29 17:09:58.000000000","message":"Done","commit_id":"67d3bb3408a9352c16729d907ed537c2bc94ee48"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a755ee85392c99ab2909061fc1158496a3e1b251","unresolved":true,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"@overload"},{"line_number":244,"context_line":"def get_volume_type_extra_specs(volume_type_id: str, key: None) -\u003e dict:"},{"line_number":245,"context_line":"    ..."},{"line_number":246,"context_line":""},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"@overload"}],"source_content_type":"text/x-python","patch_set":1,"id":"1289d283_a1ae7ecb","line":245,"in_reply_to":"77a69868_26e381c1","updated":"2024-05-18 16:43:53.000000000","message":"See https://review.opendev.org/c/openstack/cinder/+/919993 .\n\nI noticed there are a few more usages with the key argument but these can be replaced.","commit_id":"67d3bb3408a9352c16729d907ed537c2bc94ee48"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"84e73eec3e781d20ff3ae636abe7b882a9b3e73f","unresolved":true,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"@overload"},{"line_number":244,"context_line":"def get_volume_type_extra_specs(volume_type_id: str, key: None) -\u003e dict:"},{"line_number":245,"context_line":"    ..."},{"line_number":246,"context_line":""},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"@overload"}],"source_content_type":"text/x-python","patch_set":1,"id":"77a69868_26e381c1","line":245,"in_reply_to":"e5a96f76_675b478d","updated":"2024-05-18 06:26:29.000000000","message":"If we fix the code then I\u0027m wondering if we can fix the signature of get_volume_type_extra_specs . The key argument is quite confusing because it makesthe function return \"a spec\", although the name says it returns \"specs\"\n\nThe key argument is only used by vmdk driver so the impact would be minimum.","commit_id":"67d3bb3408a9352c16729d907ed537c2bc94ee48"}]}