)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"dc07e74291043d9af5f4e5e8d5c6c941ba1972e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5fe530b4_e36548b7","updated":"2025-03-12 14:47:11.000000000","message":"Thanks for making the options verbose Brian! LGTM.","commit_id":"13b007f8175015fd61601083181a91e5952721d7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2c3be2cd0606e45e213fab5053da193fded06c85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c18e9d7c_20b6f397","updated":"2025-03-13 12:52:38.000000000","message":"The sample config file looks great:\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_1ca/915903/2/check/openstack-tox-docs/1caf780/docs/_static/cinder.conf.sample\n\n... but we extract the help text into a template to generate doc/source/drivers.rst, and that can\u0027t handle the new text.","commit_id":"876b0304864f41d060537b8fc687f380cb316b39"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"132440dccdbee20d264ac8242a065c80ed5eaf5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a8ec86ea_58816475","updated":"2025-04-10 12:34:44.000000000","message":"Just want to indicate clearly that I approve of Eric\u0027s revision.","commit_id":"2b1801f1e5caabb91bcd3235ab3ff1d1a7fc43a7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f7c5010c13a45d4156bdc3c2e67c6bf948f187d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"eb0e33c3_86eeab29","updated":"2025-04-11 15:46:21.000000000","message":"The main visible change from last review is explicitly mentioning some options are for LVM thick volumes only.\nRevision LGTM.","commit_id":"2b1801f1e5caabb91bcd3235ab3ff1d1a7fc43a7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0684429f96ec79a1d1a1e6aed1b1378cf8a5bafa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"50f84eeb_39211d2d","updated":"2025-04-03 19:45:54.000000000","message":"doc job has finished, Eric\u0027s revision looks fine in both the sample config file and in the drivers.html listing of all drivers and their options","commit_id":"2b1801f1e5caabb91bcd3235ab3ff1d1a7fc43a7"}],"cinder/volume/driver.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"76a4cd6b59b0c92dba017e9291b6e48840ba1070","unresolved":true,"context_lines":[{"line_number":75,"context_line":"    cfg.StrOpt(\u0027volume_clear\u0027,"},{"line_number":76,"context_line":"               default\u003d\u0027zero\u0027,"},{"line_number":77,"context_line":"               choices\u003d[(\u0027none\u0027, \u0027Do not wipe volumes on deletion\u0027),"},{"line_number":78,"context_line":"                        (\u0027zero\u0027, \u0027(default) Zero out volumes on deletion\u0027)],"},{"line_number":79,"context_line":"               help\u003d\u0027For LVM: Method used to wipe old volumes.\u0027),"},{"line_number":80,"context_line":"    cfg.IntOpt(\u0027volume_clear_size\u0027,"},{"line_number":81,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":1,"id":"eb058e82_9bb20b65","line":78,"updated":"2025-03-12 15:05:27.000000000","message":"This should clarify that it is only applicable for thick LVM - this option tends to cause confusion about its intent and what this is for.","commit_id":"13b007f8175015fd61601083181a91e5952721d7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5f7bf89158c3aca3c6a4f85a37862b9123025942","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    cfg.StrOpt(\u0027volume_clear\u0027,"},{"line_number":76,"context_line":"               default\u003d\u0027zero\u0027,"},{"line_number":77,"context_line":"               choices\u003d[(\u0027none\u0027, \u0027Do not wipe volumes on deletion\u0027),"},{"line_number":78,"context_line":"                        (\u0027zero\u0027, \u0027(default) Zero out volumes on deletion\u0027)],"},{"line_number":79,"context_line":"               help\u003d\u0027For LVM: Method used to wipe old volumes.\u0027),"},{"line_number":80,"context_line":"    cfg.IntOpt(\u0027volume_clear_size\u0027,"},{"line_number":81,"context_line":"               default\u003d0,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ee0589b3_13777b2f","line":78,"in_reply_to":"eb058e82_9bb20b65","updated":"2025-03-12 16:34:23.000000000","message":"Done","commit_id":"13b007f8175015fd61601083181a91e5952721d7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"dc07e74291043d9af5f4e5e8d5c6c941ba1972e3","unresolved":true,"context_lines":[{"line_number":87,"context_line":"                    \u0027of the process used to zero a volume after deletion, \u0027"},{"line_number":88,"context_line":"                    \u0027for example \"-c3\" for idle only priority.\u0027),"},{"line_number":89,"context_line":"    cfg.StrOpt(\u0027target_helper\u0027,"},{"line_number":90,"context_line":"               default\u003d\u0027tgtadm\u0027,"},{"line_number":91,"context_line":"               choices\u003d[(\u0027tgtadm\u0027,"},{"line_number":92,"context_line":"                         (\u0027(default) \u0027"},{"line_number":93,"context_line":"                          \u0027Linux SCSI Target Administration Utility\u0027)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"866745af_93a08f29","line":90,"range":{"start_line":90,"start_character":24,"end_line":90,"end_character":30},"updated":"2025-03-12 14:47:11.000000000","message":"we should really change this to lioadm given all our jobs are using lioadm now.","commit_id":"13b007f8175015fd61601083181a91e5952721d7"}]}