)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"dfe1b556a2e1430d8f7777cc6501bdf2cbb31f53","unresolved":true,"context_lines":[{"line_number":18,"context_line":"removed. This incurs an unnecessary performance penalty that is"},{"line_number":19,"context_line":"resolved by this change."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Implements: blueprint dell-powermax-srdf-exempt"},{"line_number":22,"context_line":"Change-Id: Ic81f2055bae7653226010f0fdfd3aba30897abc1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"248cc7c2_8dca7563","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":47},"updated":"2024-08-20 06:03:45.000000000","message":"It looks like a bugfix rather than a feature.\nIf so, you need to file launchpad bug[1], and replace this line with:\nCloses-Bug: #\u003cbug_id\u003e\n\n[1] https://bugs.launchpad.net/cinder/+filebug","commit_id":"f2b93366b4ff36d42604a5bfe5e52a50e1e3de4f"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"d124a1c9f4aff604a87ad30d3415f5d8b707f39d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"removed. This incurs an unnecessary performance penalty that is"},{"line_number":19,"context_line":"resolved by this change."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Implements: blueprint dell-powermax-srdf-exempt"},{"line_number":22,"context_line":"Change-Id: Ic81f2055bae7653226010f0fdfd3aba30897abc1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ba191c54_ee53b579","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":47},"in_reply_to":"248cc7c2_8dca7563","updated":"2024-08-20 14:47:04.000000000","message":"Hi Yian Zong,\n\nI was initially thinking the same, but the guidance I received was due to the addition of the \"Exempt\" configuration flag, it would be consider an enhancement.","commit_id":"f2b93366b4ff36d42604a5bfe5e52a50e1e3de4f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"c0ee39e35a43f47c621886515314107c8f523bd4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"64e63345_dc4aa32b","updated":"2024-04-17 09:12:35.000000000","message":"Code and tests look good. Zuul also passed.\nHopefully DellEMC PowerMAX CI would also get passed soon.","commit_id":"534f78d5e0a02afafc6704301d7ed2f10ff1aa86"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"8b4c8e0db79312696e3a5799f021c1428010c8bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b9135cbd_4c70314c","in_reply_to":"64e63345_dc4aa32b","updated":"2024-04-18 14:54:55.000000000","message":"Thank you @Raghavendra Tilay.","commit_id":"534f78d5e0a02afafc6704301d7ed2f10ff1aa86"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"594e0f9ee29d73ee03181e7627d112f9eacf64fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0eacb0f9_3bf1aea5","updated":"2024-08-19 19:42:19.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"f2b93366b4ff36d42604a5bfe5e52a50e1e3de4f"},{"author":{"_account_id":17450,"name":"Chongchong Lei","email":"Nathaniel.Lei@dell.com","username":"Chongchong","status":"Dell EMC"},"change_message_id":"3d802e0be224fa0f241312097e2f5017a6eb4b87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"647ffea5_802a8d39","updated":"2024-08-20 05:02:52.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"f2b93366b4ff36d42604a5bfe5e52a50e1e3de4f"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"d124a1c9f4aff604a87ad30d3415f5d8b707f39d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2df45f63_0ab4f5bf","updated":"2024-08-20 14:47:04.000000000","message":"\"run-DellEMC PowerMAX CI\"","commit_id":"e1d7ea19662a5b4d51da1f952b0cb9bbec61e41f"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"b39fdd0764397b373a09218e547fe79faf9d882d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"681feb6a_9329da8b","updated":"2024-08-20 15:00:36.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"558671421950bcf6e1ca84944a072ef3ae19dce7"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"c7614c423b1600a6aac688ed2b04f288589cbcf9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"a2e06613_18261ca0","updated":"2024-08-21 19:02:11.000000000","message":"Fixed release notes typo.","commit_id":"7409510462e3caf0f870c18cb40e578a093ff0bd"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"56c12b18612b1b433d1688c5715f1f848441a5c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"1138dcc3_01bee2c9","updated":"2024-08-21 21:37:35.000000000","message":"run build-openstack-releasenotes","commit_id":"7409510462e3caf0f870c18cb40e578a093ff0bd"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c3f763577d8cca6c0f611a51f8d3099404502bae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"05ae0c0b_97fe3731","updated":"2024-09-03 16:57:17.000000000","message":"Question inline.","commit_id":"992d373e361d1f2f1e9b19cb3463e2ff4c11dd51"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"468fc5d950277f0125c9b3a3110e9e154ce7ae73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"aa00994d_4c51f588","updated":"2024-08-23 02:29:41.000000000","message":"recheck tempest-slow-py3 no log","commit_id":"992d373e361d1f2f1e9b19cb3463e2ff4c11dd51"},{"author":{"_account_id":17450,"name":"Chongchong Lei","email":"Nathaniel.Lei@dell.com","username":"Chongchong","status":"Dell EMC"},"change_message_id":"f3bf48eab4cb76b0b39de0d1258437c3e66870e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"3204679e_e6d57ba0","updated":"2024-09-02 12:33:40.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"992d373e361d1f2f1e9b19cb3463e2ff4c11dd51"},{"author":{"_account_id":17450,"name":"Chongchong Lei","email":"Nathaniel.Lei@dell.com","username":"Chongchong","status":"Dell EMC"},"change_message_id":"b170ca4499fce4123010fbbe3c6e9d967d445ee8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"385bf66d_361a813f","updated":"2024-09-02 12:29:09.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"992d373e361d1f2f1e9b19cb3463e2ff4c11dd51"},{"author":{"_account_id":17450,"name":"Chongchong Lei","email":"Nathaniel.Lei@dell.com","username":"Chongchong","status":"Dell EMC"},"change_message_id":"32a676f6d9492ba568afd159b975777afbd942f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"7c287af1_a001ebea","updated":"2024-09-03 00:36:21.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"992d373e361d1f2f1e9b19cb3463e2ff4c11dd51"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"01b826d330755e3a097f5b290523b41d92dc8507","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"67fd9bdf_ac7fa353","in_reply_to":"aa00994d_4c51f588","updated":"2024-08-27 20:18:37.000000000","message":"Thanks!","commit_id":"992d373e361d1f2f1e9b19cb3463e2ff4c11dd51"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"b9e157fbd6272a83f0555dc0fa5bc215449521a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"d3ba1a3e_492f9000","updated":"2024-09-05 21:59:24.000000000","message":"recheck tempest-slow-py3 no log","commit_id":"7af4576ec92ddb4b6acadb54173a649647f533a2"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"68fbb8bea351436a23e77b1aa3d7da277b2167f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"38ce588e_2d841573","updated":"2024-09-06 19:48:19.000000000","message":"run openstack-tox-py311","commit_id":"7af4576ec92ddb4b6acadb54173a649647f533a2"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"6b8bf7bcccd994fd507a6ec68cd6040e03e31584","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"312e7793_5e01bf61","updated":"2025-03-17 09:13:44.000000000","message":"@rajatdhasmana@gmail.com @jobernar@redhat.com,@eharney@redhat.com,\nCan you help review this patch? Thanks in advance.","commit_id":"1354d997c030dcc1b8aa93e2852a0876114c4976"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"575cc020808661ba6f79d53b08a1b0766f292593","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"2e2b4e8f_fbda3f8d","updated":"2024-09-12 22:25:13.000000000","message":"Revisions LTTM.  Don\u0027t think I\u0027ve seen PowerMax CI respond on PS 17, though.","commit_id":"1354d997c030dcc1b8aa93e2852a0876114c4976"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b70f0273735c08301eea708ae9509a7a970c0d3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"d5eeea77_8de2b8d9","updated":"2024-09-12 22:24:29.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"1354d997c030dcc1b8aa93e2852a0876114c4976"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"384184c399facbf459bb31d9eb589b2524113a01","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"98a071b2_6e9f3d73","updated":"2025-07-17 11:07:41.000000000","message":"run-DellEMC PowerMax CI","commit_id":"1354d997c030dcc1b8aa93e2852a0876114c4976"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"05e82a254eabe54bdfb05769747ab6882c4bc511","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"f3151186_e7af6872","updated":"2025-07-16 08:07:41.000000000","message":"run-DellEMC PowerMax CI","commit_id":"1354d997c030dcc1b8aa93e2852a0876114c4976"},{"author":{"_account_id":37437,"name":"Amit Zauber","display_name":"Zaubea","email":"amit.zauber@dell.com","username":"amit.zauber@dell.com"},"change_message_id":"f949fe3a3a7b8e98b12ef0eaa174962757641d94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"2a711024_5d882853","updated":"2025-07-29 09:21:53.000000000","message":"run-DellEMC PowerMax CI","commit_id":"46a5911c1e3dad1523227ff11120777a71c96f3b"},{"author":{"_account_id":37437,"name":"Amit Zauber","display_name":"Zaubea","email":"amit.zauber@dell.com","username":"amit.zauber@dell.com"},"change_message_id":"b3e29981315d1a644032f8a9d80ea824d499224c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"92165db5_b70e5468","updated":"2025-07-28 11:35:07.000000000","message":"run-DellEMC PowerMax CI","commit_id":"46a5911c1e3dad1523227ff11120777a71c96f3b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2740cf0022b880bfd5558fae78108a040eacc078","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"356b3164_e9eee8e8","updated":"2025-07-31 16:06:55.000000000","message":"See comments inline.  Also, I think you committed the unit_output.txt file by mistake on this commit.  Please remove it.","commit_id":"393b4d2b820926ebe2ad554df73147c7a6dd13ea"},{"author":{"_account_id":37437,"name":"Amit Zauber","display_name":"Zaubea","email":"amit.zauber@dell.com","username":"amit.zauber@dell.com"},"change_message_id":"4dbd5e176c7546fd9a6f14ae605c23e20329d08b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"1b48d9d8_f0bab8d4","updated":"2025-07-30 10:40:01.000000000","message":"run-DellEMC PowerMax CI","commit_id":"393b4d2b820926ebe2ad554df73147c7a6dd13ea"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2fccb41bbb0a48186219c1e0efd43a02f1bf07ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"83ca6ea3_0110a715","updated":"2025-09-03 13:27:29.000000000","message":"Comments addressed in this follow up patch https://review.opendev.org/c/openstack/cinder/+/959229","commit_id":"ad3493c91a67cbdb911a506da3f2c1c2fdca60dc"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fbd2eccec581df534b9450c4a1915dc50e0a6561","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"77d1074c_88b22f46","updated":"2025-08-29 09:06:28.000000000","message":"I\u0027ve way too many nits that this should be considered a -1 but since we\u0027re close to deadline, it can be addressed as a followup.\nThe iSCSI and FC CI are passing, even though nvme-tcp is not passing which i can consider a intermittent issue. LGTM.","commit_id":"ad3493c91a67cbdb911a506da3f2c1c2fdca60dc"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7ae6e448d129df4f9dcbaf5e975b63c789006827","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"d76ec831_ba93911d","updated":"2025-08-14 12:34:40.000000000","message":"Revisions LGTM.  I\u0027m going to +2 to signal other reviewers that this is ready, but it shouldn\u0027t be approved until it passes the dell powermax CI.","commit_id":"ad3493c91a67cbdb911a506da3f2c1c2fdca60dc"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"8cad5674337051d8b5ff2628e256f06fac5913c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"41f88539_6c2df625","updated":"2025-08-29 14:40:45.000000000","message":"recheck","commit_id":"ad3493c91a67cbdb911a506da3f2c1c2fdca60dc"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"81c4628db436d31b47c86af1ec4c662a0e2b4054","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"3fef54fd_d2d4ac06","updated":"2025-08-29 14:16:49.000000000","message":"recheck - cinder-plugin-ceph-tempest got failed.","commit_id":"ad3493c91a67cbdb911a506da3f2c1c2fdca60dc"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"18520abdef38dcdbd2d379795f368e5640a0464d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"19cc6434_cef4deaf","updated":"2025-08-19 06:46:10.000000000","message":"run-DellEMC PowerMax CI","commit_id":"ad3493c91a67cbdb911a506da3f2c1c2fdca60dc"},{"author":{"_account_id":37437,"name":"Amit Zauber","display_name":"Zaubea","email":"amit.zauber@dell.com","username":"amit.zauber@dell.com"},"change_message_id":"1612d45217ba8008ec41bb34a4b097803aec2d44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"248d6d0a_8003c4df","updated":"2025-08-17 07:30:44.000000000","message":"run-DellEMC PowerMax CI","commit_id":"ad3493c91a67cbdb911a506da3f2c1c2fdca60dc"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"c1b5a8bd828085c2e78f7b8d7bfa8eead7c26fbc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"6e606bdf_5ce6a6e3","updated":"2025-08-19 18:10:22.000000000","message":"run-DellEMC PowerMax CI","commit_id":"ad3493c91a67cbdb911a506da3f2c1c2fdca60dc"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"0949b426b2d7c40dc1091b4e58711863e3922eb0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"760383c9_8c4e84aa","updated":"2025-08-19 18:13:51.000000000","message":"run-DellEMC PowerMax CI","commit_id":"ad3493c91a67cbdb911a506da3f2c1c2fdca60dc"},{"author":{"_account_id":37437,"name":"Amit Zauber","display_name":"Zaubea","email":"amit.zauber@dell.com","username":"amit.zauber@dell.com"},"change_message_id":"21036b01fc9bbb55b4ae27ce64a12e6f5be10267","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"a4c1a745_9249ae9f","updated":"2025-08-14 08:39:43.000000000","message":"run-DellEMC PowerMax CI","commit_id":"ad3493c91a67cbdb911a506da3f2c1c2fdca60dc"},{"author":{"_account_id":37437,"name":"Amit Zauber","display_name":"Zaubea","email":"amit.zauber@dell.com","username":"amit.zauber@dell.com"},"change_message_id":"5c9dbb91e511a9ac7b6ed5747ee6935458e35cfa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"a88d4382_26ab2245","updated":"2025-08-10 12:24:25.000000000","message":"run-DellEMC PowerMax CI","commit_id":"ad3493c91a67cbdb911a506da3f2c1c2fdca60dc"},{"author":{"_account_id":37437,"name":"Amit Zauber","display_name":"Zaubea","email":"amit.zauber@dell.com","username":"amit.zauber@dell.com"},"change_message_id":"919e331f1f0137d632fd9e6f4005f605e3fb2e8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"fde0d364_66178b59","updated":"2025-08-14 05:09:30.000000000","message":"run-DellEMC PowerMax CI","commit_id":"ad3493c91a67cbdb911a506da3f2c1c2fdca60dc"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"026d641ecd61b367dcae7cd5d954b81b908e51e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"fa555d59_f50c43ae","in_reply_to":"d76ec831_ba93911d","updated":"2025-08-29 09:12:16.000000000","message":"The information which i got from dell team is that the nvme-tcp driver is not merged yet so the CI will fail. The iSCSI and FC CI are passing so it\u0027s good to go.\nWe can see that the nvme-tcp CI is passing on that patch.\nhttps://review.opendev.org/c/openstack/cinder/+/924902","commit_id":"ad3493c91a67cbdb911a506da3f2c1c2fdca60dc"}],"cinder/tests/unit/volume/drivers/dell_emc/powermax/test_powermax_rest.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fbd2eccec581df534b9450c4a1915dc50e0a6561","unresolved":true,"context_lines":[{"line_number":2086,"context_line":"        rep_extra_specs \u003d self.data.rep_extra_specs"},{"line_number":2087,"context_line":"        self.rest.srdf_suspend_replication("},{"line_number":2088,"context_line":"            array_id, sg_name, rdf_group_no, rep_extra_specs)"},{"line_number":2089,"context_line":"        # Replication mode in this test is synchronous, so the expecation"},{"line_number":2090,"context_line":"        # is that the consistency exempt flag is false."},{"line_number":2091,"context_line":"        mck_modify.assert_called_once_with("},{"line_number":2092,"context_line":"            array_id, rdf_group_no, sg_name,"}],"source_content_type":"text/x-python","patch_set":21,"id":"4a25970f_a9d72df5","line":2089,"range":{"start_line":2089,"start_character":63,"end_line":2089,"end_character":73},"updated":"2025-08-29 09:06:28.000000000","message":"expectation","commit_id":"ad3493c91a67cbdb911a506da3f2c1c2fdca60dc"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2fccb41bbb0a48186219c1e0efd43a02f1bf07ee","unresolved":false,"context_lines":[{"line_number":2086,"context_line":"        rep_extra_specs \u003d self.data.rep_extra_specs"},{"line_number":2087,"context_line":"        self.rest.srdf_suspend_replication("},{"line_number":2088,"context_line":"            array_id, sg_name, rdf_group_no, rep_extra_specs)"},{"line_number":2089,"context_line":"        # Replication mode in this test is synchronous, so the expecation"},{"line_number":2090,"context_line":"        # is that the consistency exempt flag is false."},{"line_number":2091,"context_line":"        mck_modify.assert_called_once_with("},{"line_number":2092,"context_line":"            array_id, rdf_group_no, sg_name,"}],"source_content_type":"text/x-python","patch_set":21,"id":"875b8867_ca841203","line":2089,"range":{"start_line":2089,"start_character":63,"end_line":2089,"end_character":73},"in_reply_to":"4a25970f_a9d72df5","updated":"2025-09-03 13:27:29.000000000","message":"Done","commit_id":"ad3493c91a67cbdb911a506da3f2c1c2fdca60dc"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fbd2eccec581df534b9450c4a1915dc50e0a6561","unresolved":true,"context_lines":[{"line_number":2105,"context_line":"        rep_extra_specs \u003d self.data.rep_extra_specs"},{"line_number":2106,"context_line":"        self.rest.srdf_suspend_replication("},{"line_number":2107,"context_line":"            array_id, sg_name, rdf_group_no, rep_extra_specs)"},{"line_number":2108,"context_line":"        # Replication mode in this test is synchronous, so the expecation"},{"line_number":2109,"context_line":"        # is that the consistency exempt flag is false."},{"line_number":2110,"context_line":"        mck_modify.assert_called_once_with("},{"line_number":2111,"context_line":"            array_id, rdf_group_no, sg_name,"}],"source_content_type":"text/x-python","patch_set":21,"id":"44326d5d_031d4853","line":2108,"range":{"start_line":2108,"start_character":63,"end_line":2108,"end_character":73},"updated":"2025-08-29 09:06:28.000000000","message":"nit: expectation","commit_id":"ad3493c91a67cbdb911a506da3f2c1c2fdca60dc"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2fccb41bbb0a48186219c1e0efd43a02f1bf07ee","unresolved":false,"context_lines":[{"line_number":2105,"context_line":"        rep_extra_specs \u003d self.data.rep_extra_specs"},{"line_number":2106,"context_line":"        self.rest.srdf_suspend_replication("},{"line_number":2107,"context_line":"            array_id, sg_name, rdf_group_no, rep_extra_specs)"},{"line_number":2108,"context_line":"        # Replication mode in this test is synchronous, so the expecation"},{"line_number":2109,"context_line":"        # is that the consistency exempt flag is false."},{"line_number":2110,"context_line":"        mck_modify.assert_called_once_with("},{"line_number":2111,"context_line":"            array_id, rdf_group_no, sg_name,"}],"source_content_type":"text/x-python","patch_set":21,"id":"ae00ecea_63513d52","line":2108,"range":{"start_line":2108,"start_character":63,"end_line":2108,"end_character":73},"in_reply_to":"44326d5d_031d4853","updated":"2025-09-03 13:27:29.000000000","message":"Done","commit_id":"ad3493c91a67cbdb911a506da3f2c1c2fdca60dc"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fbd2eccec581df534b9450c4a1915dc50e0a6561","unresolved":true,"context_lines":[{"line_number":2112,"context_line":"            {\u0027suspend\u0027: {\u0027force\u0027: \u0027true\u0027, \u0027consExempt\u0027: \u0027false\u0027},"},{"line_number":2113,"context_line":"             \u0027action\u0027: \u0027Suspend\u0027},"},{"line_number":2114,"context_line":"            rep_extra_specs, \u0027Suspend SRDF Group Replication\u0027)"},{"line_number":2115,"context_line":""},{"line_number":2116,"context_line":"    @mock.patch.object(rest.PowerMaxRest, \u0027srdf_modify_group\u0027)"},{"line_number":2117,"context_line":"    @mock.patch.object(rest.PowerMaxRest, \u0027get_storage_group_rdf_group_state\u0027,"},{"line_number":2118,"context_line":"                       return_value\u003d[utils.RDF_SUSPENDED_STATE])"}],"source_content_type":"text/x-python","patch_set":21,"id":"f229c4bd_abcd2184","line":2115,"updated":"2025-08-29 09:06:28.000000000","message":"I don\u0027t see any test when the consExempt is \"true\"","commit_id":"ad3493c91a67cbdb911a506da3f2c1c2fdca60dc"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2fccb41bbb0a48186219c1e0efd43a02f1bf07ee","unresolved":false,"context_lines":[{"line_number":2112,"context_line":"            {\u0027suspend\u0027: {\u0027force\u0027: \u0027true\u0027, \u0027consExempt\u0027: \u0027false\u0027},"},{"line_number":2113,"context_line":"             \u0027action\u0027: \u0027Suspend\u0027},"},{"line_number":2114,"context_line":"            rep_extra_specs, \u0027Suspend SRDF Group Replication\u0027)"},{"line_number":2115,"context_line":""},{"line_number":2116,"context_line":"    @mock.patch.object(rest.PowerMaxRest, \u0027srdf_modify_group\u0027)"},{"line_number":2117,"context_line":"    @mock.patch.object(rest.PowerMaxRest, \u0027get_storage_group_rdf_group_state\u0027,"},{"line_number":2118,"context_line":"                       return_value\u003d[utils.RDF_SUSPENDED_STATE])"}],"source_content_type":"text/x-python","patch_set":21,"id":"22a068b4_9177dc73","line":2115,"in_reply_to":"f229c4bd_abcd2184","updated":"2025-09-03 13:27:29.000000000","message":"Done","commit_id":"ad3493c91a67cbdb911a506da3f2c1c2fdca60dc"}],"cinder/volume/drivers/dell_emc/powermax/rest.py":[{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"c26e74e5af045b6f815efa9bb413c579c4ca9948","unresolved":true,"context_lines":[{"line_number":69,"context_line":"QUAL_CODE \u003d \u0027v\u0027"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"class PowerMaxRest(object, metaclass\u003dvolume_utils.TraceWrapperMetaclass):"},{"line_number":73,"context_line":"    \"\"\"Rest class based on Unisphere for PowerMax Rest API.\"\"\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"04bc528f_4e5b751f","line":72,"range":{"start_line":72,"start_character":0,"end_line":72,"end_character":73},"updated":"2024-08-20 06:26:59.000000000","message":"The \u0027TraceWrapperMetaclass\u0027 added here and in \u0027class PowerMaxCommon\u0027 are not related to the bugfix.\nYou might need to point out the purpose in the commit message and release notes.","commit_id":"f2b93366b4ff36d42604a5bfe5e52a50e1e3de4f"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"d124a1c9f4aff604a87ad30d3415f5d8b707f39d","unresolved":false,"context_lines":[{"line_number":69,"context_line":"QUAL_CODE \u003d \u0027v\u0027"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"class PowerMaxRest(object, metaclass\u003dvolume_utils.TraceWrapperMetaclass):"},{"line_number":73,"context_line":"    \"\"\"Rest class based on Unisphere for PowerMax Rest API.\"\"\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"806ca035_ad715c84","line":72,"range":{"start_line":72,"start_character":0,"end_line":72,"end_character":73},"in_reply_to":"04bc528f_4e5b751f","updated":"2024-08-20 14:47:04.000000000","message":"Thank you, Yian Zong, for the feedback. I did not intend to keep the metaclass addition in common.py and rest.py, so have removed changes to those 2 lines.","commit_id":"f2b93366b4ff36d42604a5bfe5e52a50e1e3de4f"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"089026ebf29ca62ea3d2ef7d94a49e873416acc2","unresolved":false,"context_lines":[{"line_number":2877,"context_line":"                number \u003d None"},{"line_number":2878,"context_line":"        return number"},{"line_number":2879,"context_line":""},{"line_number":2880,"context_line":"    def _get_async_payload_info(self, array, rdf_group_no):"},{"line_number":2881,"context_line":"        \"\"\"Get the payload details for an async create pair."},{"line_number":2882,"context_line":""},{"line_number":2883,"context_line":"        :param array: the array serial number"}],"source_content_type":"text/x-python","patch_set":10,"id":"011ac169_2818b07e","side":"PARENT","line":2880,"updated":"2024-08-20 17:37:43.000000000","message":"This function is not called from anywhere.","commit_id":"1a0694a833e72ea9d31a4d37eef62ff0475ae32f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c3f763577d8cca6c0f611a51f8d3099404502bae","unresolved":true,"context_lines":[{"line_number":3003,"context_line":""},{"line_number":3004,"context_line":"        :param array_id: array serial number"},{"line_number":3005,"context_line":"        :param storage_group: storage group name"},{"line_number":3006,"context_line":"        :param rdf_group_no: RDF group number"},{"line_number":3007,"context_line":"        \"\"\""},{"line_number":3008,"context_line":"        resource \u003d (\u0027storagegroup/%(sg)s/rdf_group/%(rdfg)s\u0027 % {"},{"line_number":3009,"context_line":"            \u0027sg\u0027: storage_group, \u0027rdfg\u0027: rdf_group_no})"}],"source_content_type":"text/x-python","patch_set":13,"id":"e48179ad_4bf85c45","line":3006,"updated":"2024-09-03 16:57:17.000000000","message":"nit: should doc rep_mode here too, particularly can it be None?","commit_id":"992d373e361d1f2f1e9b19cb3463e2ff4c11dd51"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"15cb1abcb64898956b416e151d1136797437b8f2","unresolved":false,"context_lines":[{"line_number":3003,"context_line":""},{"line_number":3004,"context_line":"        :param array_id: array serial number"},{"line_number":3005,"context_line":"        :param storage_group: storage group name"},{"line_number":3006,"context_line":"        :param rdf_group_no: RDF group number"},{"line_number":3007,"context_line":"        \"\"\""},{"line_number":3008,"context_line":"        resource \u003d (\u0027storagegroup/%(sg)s/rdf_group/%(rdfg)s\u0027 % {"},{"line_number":3009,"context_line":"            \u0027sg\u0027: storage_group, \u0027rdfg\u0027: rdf_group_no})"}],"source_content_type":"text/x-python","patch_set":13,"id":"cfa343fd_9f9fe002","line":3006,"in_reply_to":"e48179ad_4bf85c45","updated":"2024-09-03 20:02:24.000000000","message":"@rosmaita.fossdev@gmail.com, thanks for catching that; updated.","commit_id":"992d373e361d1f2f1e9b19cb3463e2ff4c11dd51"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c3f763577d8cca6c0f611a51f8d3099404502bae","unresolved":true,"context_lines":[{"line_number":3009,"context_line":"            \u0027sg\u0027: storage_group, \u0027rdfg\u0027: rdf_group_no})"},{"line_number":3010,"context_line":"        rdf_group \u003d self.get_resource(array_id, REPLICATION, resource)"},{"line_number":3011,"context_line":"        modes \u003d list()"},{"line_number":3012,"context_line":"        modes.append(rep_mode)"},{"line_number":3013,"context_line":"        if rep_mode:"},{"line_number":3014,"context_line":"            modes.append(rep_mode)"},{"line_number":3015,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"857be2c7_8907c054","line":3012,"range":{"start_line":3012,"start_character":8,"end_line":3012,"end_character":30},"updated":"2024-09-03 16:57:17.000000000","message":"-1: This line seems a bit odd given lines 3013-3014","commit_id":"992d373e361d1f2f1e9b19cb3463e2ff4c11dd51"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"15cb1abcb64898956b416e151d1136797437b8f2","unresolved":false,"context_lines":[{"line_number":3009,"context_line":"            \u0027sg\u0027: storage_group, \u0027rdfg\u0027: rdf_group_no})"},{"line_number":3010,"context_line":"        rdf_group \u003d self.get_resource(array_id, REPLICATION, resource)"},{"line_number":3011,"context_line":"        modes \u003d list()"},{"line_number":3012,"context_line":"        modes.append(rep_mode)"},{"line_number":3013,"context_line":"        if rep_mode:"},{"line_number":3014,"context_line":"            modes.append(rep_mode)"},{"line_number":3015,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"2fb8ff93_ba7332b0","line":3012,"range":{"start_line":3012,"start_character":8,"end_line":3012,"end_character":30},"in_reply_to":"857be2c7_8907c054","updated":"2024-09-03 20:02:24.000000000","message":"@rosmaita.fossdev@gmail.com, I agree thanks for pointing this out. I documented the rep_mode parameter and added None handling.","commit_id":"992d373e361d1f2f1e9b19cb3463e2ff4c11dd51"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"1ebbbf6bfcc5eec761a199b5b988ffd288e1617a","unresolved":true,"context_lines":[{"line_number":2990,"context_line":"                array_id, storage_group, rdf_group_no,"},{"line_number":2991,"context_line":"                rep_extra_specs[\u0027rep_mode\u0027])"},{"line_number":2992,"context_line":"            payload \u003d {\"suspend\": {\"force\": \"true\"}, \"action\": \"Suspend\"}"},{"line_number":2993,"context_line":"            if cons_exempt:"},{"line_number":2994,"context_line":"                payload[\"suspend\"][\"consExempt\"] \u003d cons_exempt"},{"line_number":2995,"context_line":"            self.srdf_modify_group("},{"line_number":2996,"context_line":"                array_id, rdf_group_no, storage_group,"}],"source_content_type":"text/x-python","patch_set":17,"id":"8b99b9f2_afe45160","line":2993,"updated":"2025-07-21 13:46:17.000000000","message":"Here you\u0027re treating cons_exempt as a boolean, but _get_cons_exempt() returns a string (see L3011 and L3024). As written, this will always evaluate as True, and so the payload will always include the \"consExempt\" value. The value will be \"true\" or \"false\" (i.e. strings) so it covers both cases, but this needs to be cleaned up. You could eliminate the L2993 boolean, or modify _get_cons_exempt() to return a boolean, and change L2994 to this:\n\n                payload[\"suspend\"][\"consExempt\"] \u003d \"True\"","commit_id":"1354d997c030dcc1b8aa93e2852a0876114c4976"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"ee12acf71eaa3724b325a9d34c4804a46b198ed8","unresolved":true,"context_lines":[{"line_number":2990,"context_line":"                array_id, storage_group, rdf_group_no,"},{"line_number":2991,"context_line":"                rep_extra_specs[\u0027rep_mode\u0027])"},{"line_number":2992,"context_line":"            payload \u003d {\"suspend\": {\"force\": \"true\"}, \"action\": \"Suspend\"}"},{"line_number":2993,"context_line":"            if cons_exempt is True:"},{"line_number":2994,"context_line":"                payload[\"suspend\"][\"consExempt\"] \u003d \"true\""},{"line_number":2995,"context_line":"            elif cons_exempt is False:"},{"line_number":2996,"context_line":"                payload[\"suspend\"][\"consExempt\"] \u003d \"false\""},{"line_number":2997,"context_line":"            self.srdf_modify_group("},{"line_number":2998,"context_line":"                array_id, rdf_group_no, storage_group,"},{"line_number":2999,"context_line":"                payload, rep_extra_specs,"},{"line_number":3000,"context_line":"                \u0027Suspend SRDF Group Replication\u0027)"}],"source_content_type":"text/x-python","patch_set":19,"id":"ea1e6faf_0c15f683","line":2997,"range":{"start_line":2993,"start_character":0,"end_line":2997,"end_character":0},"updated":"2025-07-30 13:51:11.000000000","message":"I won\u0027t downvote this code, but if you have to update the patch for another reason then I suggest simplifying L2993..L2996 like this:\n\n        payload[\"suspend\"][\"consExempt\"] \u003d \"true\" if cons_exempt else \"false\"","commit_id":"393b4d2b820926ebe2ad554df73147c7a6dd13ea"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2740cf0022b880bfd5558fae78108a040eacc078","unresolved":true,"context_lines":[{"line_number":2990,"context_line":"                array_id, storage_group, rdf_group_no,"},{"line_number":2991,"context_line":"                rep_extra_specs[\u0027rep_mode\u0027])"},{"line_number":2992,"context_line":"            payload \u003d {\"suspend\": {\"force\": \"true\"}, \"action\": \"Suspend\"}"},{"line_number":2993,"context_line":"            if cons_exempt is True:"},{"line_number":2994,"context_line":"                payload[\"suspend\"][\"consExempt\"] \u003d \"true\""},{"line_number":2995,"context_line":"            elif cons_exempt is False:"},{"line_number":2996,"context_line":"                payload[\"suspend\"][\"consExempt\"] \u003d \"false\""},{"line_number":2997,"context_line":"            self.srdf_modify_group("},{"line_number":2998,"context_line":"                array_id, rdf_group_no, storage_group,"},{"line_number":2999,"context_line":"                payload, rep_extra_specs,"},{"line_number":3000,"context_line":"                \u0027Suspend SRDF Group Replication\u0027)"}],"source_content_type":"text/x-python","patch_set":19,"id":"4ef0cb60_762ab8e6","line":2997,"range":{"start_line":2993,"start_character":0,"end_line":2997,"end_character":0},"in_reply_to":"ea1e6faf_0c15f683","updated":"2025-07-31 16:06:55.000000000","message":"-1: I\u0027m going to downvote because the code is confusing.  I think you should follow Alan\u0027s suggestion because it makes it obvious that your intent is to include consExempt in the payload no matter what its value is (which is your intent, right?).","commit_id":"393b4d2b820926ebe2ad554df73147c7a6dd13ea"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"ac31271012d8e31f8657c5a83ae369d43496e4d0","unresolved":true,"context_lines":[{"line_number":2990,"context_line":"                array_id, storage_group, rdf_group_no,"},{"line_number":2991,"context_line":"                rep_extra_specs[\u0027rep_mode\u0027])"},{"line_number":2992,"context_line":"            payload \u003d {\"suspend\": {\"force\": \"true\"}, \"action\": \"Suspend\"}"},{"line_number":2993,"context_line":"            payload[\"suspend\"][\"consExempt\"] \u003d \"true\" if cons_exempt else \"false\""},{"line_number":2994,"context_line":"            self.srdf_modify_group("},{"line_number":2995,"context_line":"                array_id, rdf_group_no, storage_group,"},{"line_number":2996,"context_line":"                payload, rep_extra_specs,"}],"source_content_type":"text/x-python","patch_set":20,"id":"54e42aad_b74b80b6","line":2993,"updated":"2025-08-05 20:13:13.000000000","message":"Sorry, I didn\u0027t check the line length before suggesting it. Here\u0027s a better version:\n\n            payload[\"suspend\"][\"consExempt\"] \u003d (\n                \"true\" if cons_exempt else \"false\")","commit_id":"2d435b6b382222a34fc08ae1c4d078ac521aa146"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fbd2eccec581df534b9450c4a1915dc50e0a6561","unresolved":true,"context_lines":[{"line_number":2877,"context_line":"                number \u003d None"},{"line_number":2878,"context_line":"        return number"},{"line_number":2879,"context_line":""},{"line_number":2880,"context_line":"    def _get_async_payload_info(self, array, rdf_group_no):"},{"line_number":2881,"context_line":"        \"\"\"Get the payload details for an async create pair."},{"line_number":2882,"context_line":""},{"line_number":2883,"context_line":"        :param array: the array serial number"},{"line_number":2884,"context_line":"        :param rdf_group_no: the rdf group number"},{"line_number":2885,"context_line":"        :returns: payload_update"},{"line_number":2886,"context_line":"        \"\"\""},{"line_number":2887,"context_line":"        num_vols, payload_update \u003d 0, {}"},{"line_number":2888,"context_line":"        rdfg_details \u003d self.get_rdf_group(array, rdf_group_no)"},{"line_number":2889,"context_line":"        if rdfg_details is not None and rdfg_details.get(\u0027numDevices\u0027):"},{"line_number":2890,"context_line":"            num_vols \u003d int(rdfg_details[\u0027numDevices\u0027])"},{"line_number":2891,"context_line":"        if num_vols \u003e 0:"},{"line_number":2892,"context_line":"            payload_update \u003d {\u0027exempt\u0027: \u0027true\u0027}"},{"line_number":2893,"context_line":"        return payload_update"},{"line_number":2894,"context_line":""},{"line_number":2895,"context_line":"    def get_metro_payload_info(self, array, payload,"},{"line_number":2896,"context_line":"                               rdf_group_no, extra_specs, next_gen):"}],"source_content_type":"text/x-python","patch_set":21,"id":"136b223e_33b7fb54","side":"PARENT","line":2893,"range":{"start_line":2880,"start_character":0,"end_line":2893,"end_character":29},"updated":"2025-08-29 09:06:28.000000000","message":"I\u0027m surprised that this method isn\u0027t called from anywhere. Also removing such a method comes under refactoring which shouldn\u0027t be done along with any feature/bugfix changes.","commit_id":"8dce75e1d0752134b90b30212678665170f1804d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fbd2eccec581df534b9450c4a1915dc50e0a6561","unresolved":true,"context_lines":[{"line_number":2991,"context_line":"                rep_extra_specs[\u0027rep_mode\u0027])"},{"line_number":2992,"context_line":"            payload \u003d {\"suspend\": {\"force\": \"true\"}, \"action\": \"Suspend\"}"},{"line_number":2993,"context_line":"            payload[\"suspend\"][\"consExempt\"] \u003d ("},{"line_number":2994,"context_line":"                \"true\" if cons_exempt else \"false\")"},{"line_number":2995,"context_line":"            self.srdf_modify_group("},{"line_number":2996,"context_line":"                array_id, rdf_group_no, storage_group,"},{"line_number":2997,"context_line":"                payload, rep_extra_specs,"}],"source_content_type":"text/x-python","patch_set":21,"id":"aa20bbdf_d9c27d81","line":2994,"range":{"start_line":2994,"start_character":16,"end_line":2994,"end_character":50},"updated":"2025-08-29 09:06:28.000000000","message":"Since this is a single occurrence, it makes sense to do it like this otherwise we can standardize this with a bool_to_str method\n\n    def _bool_to_str(self, param):\n        return \"true\" if param else \"false\"\n        \nThis would improve the methods\n\n    cons_exempt \u003d self._get_cons_exempt(\n                array_id, storage_group, rdf_group_no,\n                rep_extra_specs[\u0027rep_mode\u0027])\n    payload \u003d {\"suspend\": {\"force\": \"true\", \"consExempt\": cons_exempt}, \"action\": \"Suspend\"}","commit_id":"ad3493c91a67cbdb911a506da3f2c1c2fdca60dc"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2fccb41bbb0a48186219c1e0efd43a02f1bf07ee","unresolved":false,"context_lines":[{"line_number":2991,"context_line":"                rep_extra_specs[\u0027rep_mode\u0027])"},{"line_number":2992,"context_line":"            payload \u003d {\"suspend\": {\"force\": \"true\"}, \"action\": \"Suspend\"}"},{"line_number":2993,"context_line":"            payload[\"suspend\"][\"consExempt\"] \u003d ("},{"line_number":2994,"context_line":"                \"true\" if cons_exempt else \"false\")"},{"line_number":2995,"context_line":"            self.srdf_modify_group("},{"line_number":2996,"context_line":"                array_id, rdf_group_no, storage_group,"},{"line_number":2997,"context_line":"                payload, rep_extra_specs,"}],"source_content_type":"text/x-python","patch_set":21,"id":"bdbbda22_d0d711bf","line":2994,"range":{"start_line":2994,"start_character":16,"end_line":2994,"end_character":50},"in_reply_to":"aa20bbdf_d9c27d81","updated":"2025-09-03 13:27:29.000000000","message":"Done","commit_id":"ad3493c91a67cbdb911a506da3f2c1c2fdca60dc"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fbd2eccec581df534b9450c4a1915dc50e0a6561","unresolved":true,"context_lines":[{"line_number":3008,"context_line":"        :returns: A boolean indicating if consistency is exempt"},{"line_number":3009,"context_line":"        \"\"\""},{"line_number":3010,"context_line":"        if not rep_mode:"},{"line_number":3011,"context_line":"            return False"},{"line_number":3012,"context_line":""},{"line_number":3013,"context_line":"        resource \u003d (\u0027storagegroup/%(sg)s/rdf_group/%(rdfg)s\u0027 % {"},{"line_number":3014,"context_line":"            \u0027sg\u0027: storage_group, \u0027rdfg\u0027: rdf_group_no})"}],"source_content_type":"text/x-python","patch_set":21,"id":"0ce1da57_9a435725","line":3011,"range":{"start_line":3011,"start_character":19,"end_line":3011,"end_character":24},"updated":"2025-08-29 09:06:28.000000000","message":"If the above changes are made then this will be,\n\n    \"false\"","commit_id":"ad3493c91a67cbdb911a506da3f2c1c2fdca60dc"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2fccb41bbb0a48186219c1e0efd43a02f1bf07ee","unresolved":false,"context_lines":[{"line_number":3008,"context_line":"        :returns: A boolean indicating if consistency is exempt"},{"line_number":3009,"context_line":"        \"\"\""},{"line_number":3010,"context_line":"        if not rep_mode:"},{"line_number":3011,"context_line":"            return False"},{"line_number":3012,"context_line":""},{"line_number":3013,"context_line":"        resource \u003d (\u0027storagegroup/%(sg)s/rdf_group/%(rdfg)s\u0027 % {"},{"line_number":3014,"context_line":"            \u0027sg\u0027: storage_group, \u0027rdfg\u0027: rdf_group_no})"}],"source_content_type":"text/x-python","patch_set":21,"id":"8af98d75_d8ae20b0","line":3011,"range":{"start_line":3011,"start_character":19,"end_line":3011,"end_character":24},"in_reply_to":"0ce1da57_9a435725","updated":"2025-09-03 13:27:29.000000000","message":"Done","commit_id":"ad3493c91a67cbdb911a506da3f2c1c2fdca60dc"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fbd2eccec581df534b9450c4a1915dc50e0a6561","unresolved":true,"context_lines":[{"line_number":3023,"context_line":"        # asynchronous mode\""},{"line_number":3024,"context_line":"        cons_exempt \u003d utils.REP_ASYNC in modes"},{"line_number":3025,"context_line":"        LOG.debug(\"Consistency exempt: %s\", cons_exempt)"},{"line_number":3026,"context_line":"        return cons_exempt"},{"line_number":3027,"context_line":""},{"line_number":3028,"context_line":"    def srdf_resume_replication(self, array_id, storage_group, rdf_group_no,"},{"line_number":3029,"context_line":"                                rep_extra_specs, async_call\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":21,"id":"242f0c73_ed720424","line":3026,"range":{"start_line":3026,"start_character":8,"end_line":3026,"end_character":26},"updated":"2025-08-29 09:06:28.000000000","message":"If the above changes are made then this will be,\n\n    return self._bool_to_str(self, cons_exempt)","commit_id":"ad3493c91a67cbdb911a506da3f2c1c2fdca60dc"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2fccb41bbb0a48186219c1e0efd43a02f1bf07ee","unresolved":false,"context_lines":[{"line_number":3023,"context_line":"        # asynchronous mode\""},{"line_number":3024,"context_line":"        cons_exempt \u003d utils.REP_ASYNC in modes"},{"line_number":3025,"context_line":"        LOG.debug(\"Consistency exempt: %s\", cons_exempt)"},{"line_number":3026,"context_line":"        return cons_exempt"},{"line_number":3027,"context_line":""},{"line_number":3028,"context_line":"    def srdf_resume_replication(self, array_id, storage_group, rdf_group_no,"},{"line_number":3029,"context_line":"                                rep_extra_specs, async_call\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":21,"id":"10faf709_efcb1f5e","line":3026,"range":{"start_line":3026,"start_character":8,"end_line":3026,"end_character":26},"in_reply_to":"242f0c73_ed720424","updated":"2025-09-03 13:27:29.000000000","message":"Done","commit_id":"ad3493c91a67cbdb911a506da3f2c1c2fdca60dc"}],"releasenotes/notes/bp-dell-powermax-consistency-exempt.yaml":[{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"9158eaebe6b68ebe085da570a26d610ae484f221","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerMax Driver `Bug #2061025"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2061025\u003e`_: Fixed"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"dbe84bb1_bafac76f","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":6},"updated":"2024-08-21 05:04:37.000000000","message":"nit: features\n\nNo matter it\u0027s a bugfix or feature, the release notes need to be consistent with the commit message on that.\nPlease refer to [1] for example of driver\u0027s release notes.\n\n[1] https://docs.openstack.org/cinder/latest/contributor/releasenotes.html#drivers","commit_id":"eb8ca15b30f59855393b7a83741b5c67853cbcad"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"7c1d6a90e072cc2294b951380aa048374c6aad1a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerMax Driver `Bug #2061025"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2061025\u003e`_: Fixed"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"d2be724d_ed68079b","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":6},"in_reply_to":"dbe84bb1_bafac76f","updated":"2024-08-21 15:23:39.000000000","message":"Thanks Yian, I\u0027ve updated the release notes and commit message.","commit_id":"eb8ca15b30f59855393b7a83741b5c67853cbcad"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"de1c90734f72d80c44a28b1e0a02cf96341d84c9","unresolved":true,"context_lines":[{"line_number":15,"context_line":"    removed. This incurs an unnecessary performance penalty that is"},{"line_number":16,"context_line":"    resolved by this change."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    Blueprint: dell-powermax-srdf-exempt"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7b0ed0b2_1f761ee9","line":18,"range":{"start_line":18,"start_character":4,"end_line":18,"end_character":40},"updated":"2024-09-03 16:48:56.000000000","message":"nit: remove this line (I\u0027d say make it a hyperlink to the blueprint, but your release note explains everything that\u0027s there in the bp)","commit_id":"992d373e361d1f2f1e9b19cb3463e2ff4c11dd51"},{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"15cb1abcb64898956b416e151d1136797437b8f2","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    removed. This incurs an unnecessary performance penalty that is"},{"line_number":16,"context_line":"    resolved by this change."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    Blueprint: dell-powermax-srdf-exempt"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"6a016ff5_ab85fe9f","line":18,"range":{"start_line":18,"start_character":4,"end_line":18,"end_character":40},"in_reply_to":"7b0ed0b2_1f761ee9","updated":"2024-09-03 20:02:24.000000000","message":"@rosmaita.fossdev@gmail.com, resolved, thank you!","commit_id":"992d373e361d1f2f1e9b19cb3463e2ff4c11dd51"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"1ebbbf6bfcc5eec761a199b5b988ffd288e1617a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerMax Driver: Add support for consistency exempt flag"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"54b6db53_52870f92","line":2,"updated":"2025-07-21 13:46:17.000000000","message":"This feels more like a bug fix/refinement than a feature. If I understand correctly, this \"consistency exempt flag\" is purely an internal driver concept, and the patch resolves a performance penalty.\n\nI mention this because bug fixes are eligible to be backported to stable branches, but features can\u0027t be backported.","commit_id":"1354d997c030dcc1b8aa93e2852a0876114c4976"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2740cf0022b880bfd5558fae78108a040eacc078","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerMax Driver: Add support for consistency exempt flag"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"71d8df99_dee5341b","line":2,"in_reply_to":"54b6db53_52870f92","updated":"2025-07-31 16:06:55.000000000","message":"Alan has a good point.  If you want to backport this, I suggest changing line 4 to something like:\n\nDell PowerMax Driver: Use consistency exempt flag consistently","commit_id":"1354d997c030dcc1b8aa93e2852a0876114c4976"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"1a6afffeecbbedbe26638638bf3f00f706001e1e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerMax Driver: Add support for consistency exempt flag"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"941cfe37_0a50c772","line":2,"in_reply_to":"71d8df99_dee5341b","updated":"2025-07-31 16:26:03.000000000","message":"And if you do hope to backport this, then you should file a launchpad bug and reference in this commit message.","commit_id":"1354d997c030dcc1b8aa93e2852a0876114c4976"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fbd2eccec581df534b9450c4a1915dc50e0a6561","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    removed. This incurs an unnecessary performance penalty that is"},{"line_number":15,"context_line":"    resolved by this change."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    Blueprint: dell-powermax-srdf-exempt"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"bfd7766c_5db69689","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":40},"updated":"2025-08-29 09:06:28.000000000","message":"I don\u0027t think we need the blueprint in the releaesnote, it is a dev thing to track a feature.","commit_id":"ad3493c91a67cbdb911a506da3f2c1c2fdca60dc"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2fccb41bbb0a48186219c1e0efd43a02f1bf07ee","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    removed. This incurs an unnecessary performance penalty that is"},{"line_number":15,"context_line":"    resolved by this change."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    Blueprint: dell-powermax-srdf-exempt"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"8e22392a_0d33a517","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":40},"in_reply_to":"bfd7766c_5db69689","updated":"2025-09-03 13:27:29.000000000","message":"Done","commit_id":"ad3493c91a67cbdb911a506da3f2c1c2fdca60dc"}]}