)]}'
{".pre-commit-config.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"01e8e7ada01f81e6f03fc7ed7942318376bbc238","unresolved":false,"context_lines":[{"line_number":8,"context_line":"        args: [\u0027--fix\u0027, \u0027lf\u0027]"},{"line_number":9,"context_line":"        exclude: \u0027.*\\.(svg)$\u0027"},{"line_number":10,"context_line":"      - id: check-byte-order-marker"},{"line_number":11,"context_line":"      - id: check-executables-have-shebangs"},{"line_number":12,"context_line":"      - id: check-merge-conflict"},{"line_number":13,"context_line":"      - id: debug-statements"},{"line_number":14,"context_line":"      - id: check-json"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d1bed3ba_5b2b6eb7","line":11,"updated":"2024-04-25 09:32:00.000000000","message":"Note that this isn\u0027t a 1:1 replacement for the `check_exec` script it\u0027s replacing. The `check_exec` script checked if there were any executable files in the repo. This hook checks that any executables must have a shebang and fails if not. We can implement the current `check_exec` behaviour as a custom hook but tbh I think what the pre-commit hook is doing here is good enough: if someone went as far as sticking a shebang in to a file _and_ making it executable, they probably want it to be executable.","commit_id":"44f07694582e11e98554c198228feebb91bca1c1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fdc9dae6f67d9452b4ef73e67da4d2f31bce2b13","unresolved":true,"context_lines":[{"line_number":30,"context_line":"  - repo: https://github.com/PyCQA/doc8"},{"line_number":31,"context_line":"    rev: v2.0.0"},{"line_number":32,"context_line":"    hooks:"},{"line_number":33,"context_line":"      - id: doc8"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fc5e643_ba9196dd","line":33,"updated":"2025-10-24 13:10:30.000000000","message":"This runs doc8 and addresses Eric\u0027s objection.","commit_id":"41eee5c2191ba6cb3af30ef2d2a93d1287df5ad7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5c4a6d94c5c7b5b515ce8c028b85805c355da806","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  - repo: https://github.com/PyCQA/doc8"},{"line_number":31,"context_line":"    rev: v2.0.0"},{"line_number":32,"context_line":"    hooks:"},{"line_number":33,"context_line":"      - id: doc8"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"62284964_45f491cf","line":33,"in_reply_to":"3fc5e643_ba9196dd","updated":"2025-10-30 15:09:51.000000000","message":"Acknowledged","commit_id":"41eee5c2191ba6cb3af30ef2d2a93d1287df5ad7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"299a5c8f99c38423ed6cc2c7bc98b79e5dbcadc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"78b133c4_e6614937","updated":"2024-04-24 16:17:42.000000000","message":"https://review.opendev.org/c/openstack/cinder/+/848759\n    \nwas checking for CRLF line endings in code -- can one of the pre-commit hooks do that?  (I see there is one that detects mixed CRLF/LF line endings, but doesn\u0027t seem to reject CRLF altogether.)","commit_id":"44f07694582e11e98554c198228feebb91bca1c1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"799cabb84e68fef942af20ca1bc9b204e7c41b1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a3802b31_a40737ab","updated":"2024-04-24 13:14:03.000000000","message":"recheck unrelated eventlet-related timeout","commit_id":"44f07694582e11e98554c198228feebb91bca1c1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"999e9c5726ccb7052b2296fa24651ded1fd66166","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5fec1a01_dde1fd85","updated":"2024-04-26 16:03:13.000000000","message":"recheck unrelated tempest failure","commit_id":"44f07694582e11e98554c198228feebb91bca1c1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d4b05c6c69ead7f97a6b3a8b86a169197a72a4ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ba2891d1_ae074822","in_reply_to":"78b133c4_e6614937","updated":"2024-04-25 09:26:48.000000000","message":"Yes, it does. The `mixed-line-ending` does that. You\u0027ll note I\u0027m passing the `--fix lf` argument to the hook. This ensures we always convert to LF, even if a file is currently solely CRLF.","commit_id":"44f07694582e11e98554c198228feebb91bca1c1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7c72a4a86a7051beddabbea3956197ab84374f14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a5e0a999_79e8f4c1","updated":"2024-05-20 16:04:55.000000000","message":"recheck unrelated timeout in tempest","commit_id":"33204d6f37b6d433099f0c3d98bc729c912a1e25"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"73380f561445ed1792c715f21b139cae7ad922ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"442babbe_9c7f3b3a","updated":"2025-02-21 16:52:19.000000000","message":"I like it!","commit_id":"841fad272c17fbf502e2c5d888d5914d1b65dd2a"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"05b29b6bb2b578f63c74c7b8e34ca3cefb341583","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fde4aa44_876fd03d","updated":"2025-04-10 15:35:59.000000000","message":"I think this should still run doc8 checks along w/ hacking.","commit_id":"841fad272c17fbf502e2c5d888d5914d1b65dd2a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d8a914a494bf583b40b21292c2f0b8563997b755","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cf0ce8aa_854e5659","in_reply_to":"fde4aa44_876fd03d","updated":"2025-04-10 16:27:22.000000000","message":"Good catch. I pushed a follow-up here:\n\nhttps://review.opendev.org/c/openstack/cinder/+/946940\n\nPlease let me know if you\u0027d rather I squashed this in and rebased the whole series.","commit_id":"841fad272c17fbf502e2c5d888d5914d1b65dd2a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1f8cfdefc112657e718f911424372cc09800efac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a08fdcab_dcc7e3d9","updated":"2025-10-24 13:28:29.000000000","message":"Makes sense to me.  pre-commit is listed as a dependency directly in the tox env, not test-requirements.txt, but that seems OK to me since we\u0027re not currently expressing any constraints on the version.  If we need to constrain pre-commit, we can move it to test-requirements at that point.","commit_id":"41eee5c2191ba6cb3af30ef2d2a93d1287df5ad7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fdc9dae6f67d9452b4ef73e67da4d2f31bce2b13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7d445051_c11bb7fa","updated":"2025-10-24 13:10:30.000000000","message":"Note that this patch now handles running doc8 (so the follow-up patch mentioned in an earlier comment is no longer necessary).","commit_id":"41eee5c2191ba6cb3af30ef2d2a93d1287df5ad7"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1bf016491f8adea2c9c2d21b563b4545ac3e3df0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5edf3891_cd92382a","updated":"2025-10-24 16:20:15.000000000","message":"Oh, you must be right. It\u0027s not showing up in the release notes job:","commit_id":"41eee5c2191ba6cb3af30ef2d2a93d1287df5ad7"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3a59bf10d8e64438d621271de93675cfeab496b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6ad573de_5de6ff35","updated":"2025-10-24 16:20:39.000000000","message":"https://d56539e91a35c54e5e51-e84faa2b407329d2b0da24e899449f42.ssl.cf5.rackcdn.com/openstack/a20b418ff0c540faaaa740f8e6c17304/docs/unreleased.html","commit_id":"41eee5c2191ba6cb3af30ef2d2a93d1287df5ad7"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"85fbda6e8eae023b126092199e26fa056f4bf159","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4c606a42_46e4f846","updated":"2025-10-30 14:58:38.000000000","message":"recheck devstack-plugin-nfs-tempest-full unrelated","commit_id":"41eee5c2191ba6cb3af30ef2d2a93d1287df5ad7"}],"releasenotes/notes/bug-2103742-fix-fail-resize-nfs-volumes-with-snapshots-e861d69b1ae6f97d.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"deb1cae567adfb0b1c88eb35aa8cdf2416e6789e","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NFS driver `bug #2103742"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2103742\u003e`_: Fixed issue"},{"line_number":6,"context_line":"    preventing the volume resize operation from properly updating the NFS"},{"line_number":7,"context_line":"    image virtual size with the new size when volume has snapshots."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"c29d3b35_e9b2a42d","line":5,"range":{"start_line":5,"start_character":62,"end_line":5,"end_character":67},"updated":"2025-10-24 15:06:14.000000000","message":"Editing this will cause this release note to show up again in the rendered 2026.1 release notes. Unless things have changed since I was more involved, which could very well be.","commit_id":"41eee5c2191ba6cb3af30ef2d2a93d1287df5ad7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a204d16cfe12bbdd1b7d8c45d1fe255329130f16","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NFS driver `bug #2103742"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2103742\u003e`_: Fixed issue"},{"line_number":6,"context_line":"    preventing the volume resize operation from properly updating the NFS"},{"line_number":7,"context_line":"    image virtual size with the new size when volume has snapshots."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"e9047881_2c9fc7e1","line":5,"range":{"start_line":5,"start_character":62,"end_line":5,"end_character":67},"in_reply_to":"c29d3b35_e9b2a42d","updated":"2025-10-24 16:08:00.000000000","message":"Pretty sure this was fixed, though at a quick look at the commits to reno, the fix patch didn\u0027t jump out at me.","commit_id":"41eee5c2191ba6cb3af30ef2d2a93d1287df5ad7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"393a231baf505bc229902b900225c1180237bb3a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NFS driver `bug #2103742"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2103742\u003e`_: Fixed issue"},{"line_number":6,"context_line":"    preventing the volume resize operation from properly updating the NFS"},{"line_number":7,"context_line":"    image virtual size with the new size when volume has snapshots."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"04ef3e43_75122e5d","line":5,"range":{"start_line":5,"start_character":62,"end_line":5,"end_character":67},"in_reply_to":"e9047881_2c9fc7e1","updated":"2025-10-24 18:12:13.000000000","message":"\u003e Pretty sure this was fixed, though at a quick look at the commits to reno, the fix patch didn\u0027t jump out at me.\n\nIt was. You want this commit https://opendev.org/openstack/reno/commit/bcc65c9e846c829158671ccfbcd0308284f2092a","commit_id":"41eee5c2191ba6cb3af30ef2d2a93d1287df5ad7"}]}