)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"7d4a6d79d008ab8db4262463c31c95890b5b49e5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9ca9fea9_f4b724a0","updated":"2025-10-31 16:34:31.000000000","message":"I am giving a -1 as you may need release notes if this is customer-facing (it seems to be due to a potential conf flag no longer working): \nhttps://docs.openstack.org/cinder/latest/contributor/releasenotes.html\n\nAnd I have some questions:\n- are we removing functionality that does not have an equivalent?\n- can this break customers in the wild that have used this feature in the past?","commit_id":"04f2749460b5d204a549a25a33096646c1f751e8"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"5e94ea9ab95998e55195ae852ebf617323ff55f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"810969e3_47323600","updated":"2025-11-03 21:12:39.000000000","message":"This patch looks good to me after concerns were explained.","commit_id":"04f2749460b5d204a549a25a33096646c1f751e8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"26b391da523163d6e3c95c74e1d2c9806bec9fb9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"df7cbdd0_084ac74e","in_reply_to":"9ca9fea9_f4b724a0","updated":"2025-11-03 14:24:42.000000000","message":"(side note) as a open source project we have no \"customers\"\n\nAs I described in the commit message these logics were added to fix the usage in cinderlib, which imports cinder.\nAgain as I described in the commit message cinderlib was retired so we expect no one may attempt to use it in recent version of OpenStack. Theoretically anyone can write their own lib to import any modules from OpenStack services, but we don\u0027t support such usage unless the deliverable is marked as a library (such as os-brick).","commit_id":"04f2749460b5d204a549a25a33096646c1f751e8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"40d5295abdd48dd40587606ade623a22c7d16620","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e05ac94e_e3d69f7f","in_reply_to":"df7cbdd0_084ac74e","updated":"2025-11-03 14:26:45.000000000","message":"So basically what you are asking is whether any use may have their own library which import some logics from cinder. It is technically possible but that is not officially supported. We created cinderlib for that usage but it was retired so I feel release note or keeping these hacks for \"potential external hack\" is expanding the scope of cinder too much.","commit_id":"04f2749460b5d204a549a25a33096646c1f751e8"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"5e94ea9ab95998e55195ae852ebf617323ff55f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8088d60c_705bd363","in_reply_to":"e05ac94e_e3d69f7f","updated":"2025-11-03 21:12:39.000000000","message":"Gotcha, understood.  I just wanted to better understand why it was being removed and the effect it could have.  I agree you probably do not need release notes.","commit_id":"04f2749460b5d204a549a25a33096646c1f751e8"}]}
