)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"5a1a1c83438d61cd91ce02cdb1c845afe49c8983","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"6e6ba7d2_e73ccd15","line":13,"updated":"2024-12-18 08:04:36.000000000","message":"I think it is worth adding `Partial-Implements` or `Implements` to refer to the blueprint this patch aims to implement.\n\n```\nPartial-Implements: blueprint user-visible-information-in-volume-types\n```","commit_id":"06879e4db26eef5444c9e3ba2fff2940d6e4cc70"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"f03bb10385101faa8c73e15cadd68a8b3fc171d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"7b0c18b2_1f8f5384","line":13,"in_reply_to":"6e6ba7d2_e73ccd15","updated":"2025-01-06 12:05:48.000000000","message":"Done","commit_id":"06879e4db26eef5444c9e3ba2fff2940d6e4cc70"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"5a1a1c83438d61cd91ce02cdb1c845afe49c8983","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"4e0401ef_73df576d","updated":"2024-12-18 08:04:36.000000000","message":"Hi Josephine! Adding a few suggestions in comments.","commit_id":"06879e4db26eef5444c9e3ba2fff2940d6e4cc70"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"8c0e5be1e1b64978ca39a8bd1397b35142e5dec0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"dc8ff413_22c2d9a1","updated":"2024-11-12 13:36:14.000000000","message":"Hi Josephine! Is this patch ready for reviews? If so I will take a look later this week.","commit_id":"06879e4db26eef5444c9e3ba2fff2940d6e4cc70"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"7b190dafaf6a5115f899e1ba2e7186a3ed827457","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"0ebedcf4_c66868c8","updated":"2024-11-06 10:07:42.000000000","message":"recheck - unrelated mypy error","commit_id":"06879e4db26eef5444c9e3ba2fff2940d6e4cc70"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"f03bb10385101faa8c73e15cadd68a8b3fc171d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"25b52b6e_665e4b40","updated":"2025-01-06 12:05:48.000000000","message":"Thank you for the review. I addressed your comments.","commit_id":"3511c9f36224a549ab7cff5a42feb93ac47dce3f"}],"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"5a1a1c83438d61cd91ce02cdb1c845afe49c8983","unresolved":true,"context_lines":[{"line_number":1207,"context_line":"    }"},{"line_number":1208,"context_line":"    inst_type_dict[\u0027extra_specs\u0027] \u003d extra_specs"},{"line_number":1209,"context_line":""},{"line_number":1210,"context_line":"    metadata \u003d {"},{"line_number":1211,"context_line":"        x[\u0027key\u0027]: x[\u0027value\u0027] for x in inst_type_query[\u0027volume_type_metadata\u0027]"},{"line_number":1212,"context_line":"    }"},{"line_number":1213,"context_line":"    inst_type_dict[\u0027metadata\u0027] \u003d metadata"}],"source_content_type":"text/x-python","patch_set":18,"id":"d59f8b97_002a45b7","line":1210,"updated":"2024-12-18 08:04:36.000000000","message":"This could be formatted in the same way as other cinder volume objects (such as Volumes and Snapshots) that make use of metadata key pairs [1][2].   \n\nI\u0027m not really sure about this but I guess the extra_specs field in particular is transformed earlier because it is also used internally by drivers or other components not related to Cinder\u0027s API. \n\nI don\u0027t think the way you implement is wrong, actually I\u0027m just a bit worried that we might be diverting the function `_dict_with_extra_specs_if_authorized` from its purpose. If we intend to keep this way (have the metadata getting transformed in `_dict_with_extra_specs_if_authorized`), then I would recommend to update the functon\u0027s docstring to also add a mention to metadata entries.\n\n[1] https://github.com/openstack/cinder/blob/01f7c97376e09fd3b46fbf84d8771d30ef9b8060/cinder/objects/volume.py#L287\n[2] https://github.com/openstack/cinder/blob/01f7c97376e09fd3b46fbf84d8771d30ef9b8060/cinder/objects/snapshot.py#L153","commit_id":"06879e4db26eef5444c9e3ba2fff2940d6e4cc70"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"f03bb10385101faa8c73e15cadd68a8b3fc171d0","unresolved":false,"context_lines":[{"line_number":1207,"context_line":"    }"},{"line_number":1208,"context_line":"    inst_type_dict[\u0027extra_specs\u0027] \u003d extra_specs"},{"line_number":1209,"context_line":""},{"line_number":1210,"context_line":"    metadata \u003d {"},{"line_number":1211,"context_line":"        x[\u0027key\u0027]: x[\u0027value\u0027] for x in inst_type_query[\u0027volume_type_metadata\u0027]"},{"line_number":1212,"context_line":"    }"},{"line_number":1213,"context_line":"    inst_type_dict[\u0027metadata\u0027] \u003d metadata"}],"source_content_type":"text/x-python","patch_set":18,"id":"8c9b79f4_cc5f092a","line":1210,"in_reply_to":"d59f8b97_002a45b7","updated":"2025-01-06 12:05:48.000000000","message":"I rephrased the docstring to include the metadata.","commit_id":"06879e4db26eef5444c9e3ba2fff2940d6e4cc70"}]}