)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"b92deb6ad3fc40251e710df35277f7e258bb8885","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Yian Zong \u003cyian.zong@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-09-09 07:32:46 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dell PowerStore: add  FC zone manager support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add FC zone manager support for Dell PowerStore driver, which"},{"line_number":10,"context_line":"enables FC SAN auto zoning for the driver."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"b8acb75c_183ddf54","line":7,"updated":"2025-09-03 18:02:31.000000000","message":"nit: there is an additional space between add and FC words that can be removed","commit_id":"cb0e9842f24943ca1a6b6ee4d120a0dd17a24875"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"c17f5f467fde203e078191ac5480830e14a9b799","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yian Zong \u003cyian.zong@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-09-09 07:32:46 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dell PowerStore: add  FC zone manager support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add FC zone manager support for Dell PowerStore driver, which"},{"line_number":10,"context_line":"enables FC SAN auto zoning for the driver."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3c933b70_fd52c4fb","line":7,"in_reply_to":"b8acb75c_183ddf54","updated":"2025-10-27 04:30:15.000000000","message":"Done","commit_id":"cb0e9842f24943ca1a6b6ee4d120a0dd17a24875"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"ce57ce17ff533417ff08a595b6453bea1cef8e3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d37f3ceb_8e267192","updated":"2024-08-01 13:17:27.000000000","message":"As you are changing Brocade FCZM code you should really get the Brocade CI to report a success.\nAlso you probably need to update the unit tests.\nIt appears the Brocade CI has not been responding in a few years, so you may want to speak to Broadcom about this, or spin up your own replacement (as Pure did a while ago for the Cisco FCZM CI)","commit_id":"2bd31840ea8097c5b7c22f3174e605ee05ed8ede"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"b49fb09b64c397b5c454f6d866f819c9a0f2cf79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dc51d66e_da18e10e","updated":"2024-05-14 00:27:09.000000000","message":"recheck tempest-integrated-storage cinder-sqlalchemy-2x timeout","commit_id":"2bd31840ea8097c5b7c22f3174e605ee05ed8ede"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"cc397608a99bf80f0f996c8f14263b17c80505c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a3063c82_33018a7d","updated":"2024-05-14 06:28:38.000000000","message":"recheck tempest-integrated-storage timeout","commit_id":"2bd31840ea8097c5b7c22f3174e605ee05ed8ede"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"42d388a81e98bff179caa68ee1c794a5367f7c0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"00985403_5c5b0531","updated":"2024-05-15 05:51:36.000000000","message":"run-DellEMC PowerStore CI","commit_id":"2bd31840ea8097c5b7c22f3174e605ee05ed8ede"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"50286a93dfd22088fdb25f0d65b450292408cafe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"13c18527_62d767cd","updated":"2024-05-16 09:28:19.000000000","message":"run-DellEMC PowerStore CI","commit_id":"2bd31840ea8097c5b7c22f3174e605ee05ed8ede"},{"author":{"_account_id":36625,"name":"Rick Liu","email":"rick.liu@dell.com"},"change_message_id":"08d93bd254b45fa339b0d49bdbb73c3d532f4926","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"37d3a7e0_f84e26e0","updated":"2024-05-20 03:03:03.000000000","message":"run-DellEMC PowerStore CI","commit_id":"2bd31840ea8097c5b7c22f3174e605ee05ed8ede"},{"author":{"_account_id":36625,"name":"Rick Liu","email":"rick.liu@dell.com"},"change_message_id":"a2cb4b316ea30485287f57b3b04e51969cda0379","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3c7bad5b_39f8107c","updated":"2024-05-16 08:07:15.000000000","message":"run-DellEMC PowerStore CI","commit_id":"2bd31840ea8097c5b7c22f3174e605ee05ed8ede"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"a763ea37f5fcdfd7e186ee2c34fefe1a62df493d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f0190bfb_fd233084","updated":"2024-05-24 04:17:47.000000000","message":"run-DellEMC PowerStore CI","commit_id":"2bd31840ea8097c5b7c22f3174e605ee05ed8ede"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"4deaca67b71b933f39cfb140010abb66408ff83d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f2922e92_2923743d","updated":"2024-05-15 00:54:24.000000000","message":"run-DellEMC PowerStore CI","commit_id":"2bd31840ea8097c5b7c22f3174e605ee05ed8ede"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"6e4cfd7c126ae89fab66696beb7c96562fe201bb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"69130476_0cb7dc0a","in_reply_to":"6282746f_ac1e1236","updated":"2024-08-26 10:39:26.000000000","message":"The code change in `update_zones` function is to prevent sending rest call to update the zone with exact the same members as current. By observation, the rest call responses error when updating zone without actual changes.\nI don\u0027t insist to changing the Brocade driver as I have no bandwidth to maintain a switch driver.\nThus, it\u0027s ok for me to remove the changes of brcd_rest_fc_zone_client.py in this patch.","commit_id":"2bd31840ea8097c5b7c22f3174e605ee05ed8ede"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"732ce700dd9f342c1696f553d440dc4fc23d23c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3a5958bc_7b3ffc7e","in_reply_to":"69130476_0cb7dc0a","updated":"2024-08-27 03:31:47.000000000","message":"Reverted brcd_rest_fc_zone_client.py\nThanks!","commit_id":"2bd31840ea8097c5b7c22f3174e605ee05ed8ede"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"c2a8d63224bd1d5471a77c36653b93d0439bcb05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d9d876b7_c5718344","in_reply_to":"d37f3ceb_8e267192","updated":"2024-08-01 14:10:46.000000000","message":"The Brocade driver is deprecated long time ago. I\u0027m not sure if cinder core team still want it to be updated although I push the changes.\nThe PowerStore driver\u0027s code invokes FCZM interfaces, which is decoupled from the implementation of Brocade or Cisco driver. Ideally, if it works with Broadcom, it should also work with Cisco.\n\nIs the Cisco FCZM CI [1] is maintained by Pure? It\u0027s pointing to local host.\n\n[1] https://127.0.0.1:9000/t/openstack/buildset/456e5be7df134027bdaee662451a699b","commit_id":"2bd31840ea8097c5b7c22f3174e605ee05ed8ede"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"45cac3a9850da1911384e7a3ccfc087e1011b4c1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6282746f_ac1e1236","in_reply_to":"d9d876b7_c5718344","updated":"2024-08-23 15:23:24.000000000","message":"Pure no longer maintains the Cisco CI. They took it back but seemed to have dropped the ball with their links.\nWhat concerns me is the changes you have made to the ``update_zones` function.","commit_id":"2bd31840ea8097c5b7c22f3174e605ee05ed8ede"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"1cbea6b871f078d4c519d5af2a40a469b71f8e94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"26e5c4b8_cab524b8","updated":"2024-08-27 09:33:46.000000000","message":"recheck pep8","commit_id":"cc77a82276d8d2dd49257d815c585dbe9b8691ff"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"18b0b3ce97c25a64c38ea25cdf9fee16b028898e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9ddf0304_618103bb","updated":"2025-09-03 18:03:25.000000000","message":"Signed-off-by is missing in the commit message.","commit_id":"cb0e9842f24943ca1a6b6ee4d120a0dd17a24875"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"b92deb6ad3fc40251e710df35277f7e258bb8885","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2b81ff6b_7a1d1dad","updated":"2025-09-03 18:02:31.000000000","message":"hello @yian.zong@dell.com, I\u0027ve mentioned some nits that could be addressed. Regarding the \"return\" in docstrings it would make more sense to me have it written in a more descriptive way as in the rest of the file, but this is not a big deal.","commit_id":"cb0e9842f24943ca1a6b6ee4d120a0dd17a24875"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"5f7d3ab4530226a39d36d5a8f19eda1c3b9348b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"91241588_b9b9cae6","updated":"2024-10-30 19:37:13.000000000","message":"run Pure Storage CI","commit_id":"cb0e9842f24943ca1a6b6ee4d120a0dd17a24875"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"3c016d4b33066254e2613ce6ea9159ee7ecd0686","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1ad740a4_dc9a7f6a","updated":"2025-08-12 10:10:53.000000000","message":"run-DellEMC PowerStore CI","commit_id":"cb0e9842f24943ca1a6b6ee4d120a0dd17a24875"},{"author":{"_account_id":37786,"name":"Pavithra Mahadev","display_name":"Pavithra Mahadev","email":"pavithra_mahadev@dell.com","username":"pavithra_mahadev"},"change_message_id":"bded72b759e6e0881028fb5ed84fae9af2216069","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2b20c8da_94be5d91","updated":"2025-07-08 13:17:33.000000000","message":"run-DellEMC PowerStore CI","commit_id":"cb0e9842f24943ca1a6b6ee4d120a0dd17a24875"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"4387448fce5622a1e29bfc2e7303ee2bd0b5672f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"43f50c53_ac0e1d2a","updated":"2025-08-12 07:20:35.000000000","message":"run-DellEMC PowerStore CI","commit_id":"cb0e9842f24943ca1a6b6ee4d120a0dd17a24875"},{"author":{"_account_id":37786,"name":"Pavithra Mahadev","display_name":"Pavithra Mahadev","email":"pavithra_mahadev@dell.com","username":"pavithra_mahadev"},"change_message_id":"4254d0529d6b62d898580ae26cfa106fb45ff053","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"628b73f3_449c1eec","updated":"2025-07-15 13:15:50.000000000","message":"run-DellEMC PowerStore CI","commit_id":"cb0e9842f24943ca1a6b6ee4d120a0dd17a24875"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"03d59635465f43fd721b7edcda00562420327ca9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8ce3eacc_434f3638","updated":"2025-07-10 11:31:48.000000000","message":"run-DellEMC PowerStore CI","commit_id":"cb0e9842f24943ca1a6b6ee4d120a0dd17a24875"},{"author":{"_account_id":37786,"name":"Pavithra Mahadev","display_name":"Pavithra Mahadev","email":"pavithra_mahadev@dell.com","username":"pavithra_mahadev"},"change_message_id":"7f73b4e5d0b806e334067008c41c94aacc7dfa01","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9ce6db52_0c1ca29b","updated":"2025-07-09 09:27:16.000000000","message":"run-DellEMC PowerStore CI","commit_id":"cb0e9842f24943ca1a6b6ee4d120a0dd17a24875"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"0ef44a5455ccf9d6c5a6d857805934d05c899ca3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"dd1ee4a7_1f273571","updated":"2025-08-08 09:57:32.000000000","message":"run-DellEMC PowerStore CI","commit_id":"cb0e9842f24943ca1a6b6ee4d120a0dd17a24875"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"5418e9900a2f78bace09c743dda9d24f073e9af4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f378b48e_4e2b585e","updated":"2025-08-12 08:09:17.000000000","message":"run-DellEMC PowerStore CI","commit_id":"cb0e9842f24943ca1a6b6ee4d120a0dd17a24875"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"6028efc5f6a4bc58e4a3906aaf27bd0eb863a198","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a2b73fdd_918b4c32","updated":"2025-08-12 07:18:06.000000000","message":"un-DellEMC PowerStore CI","commit_id":"cb0e9842f24943ca1a6b6ee4d120a0dd17a24875"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"42d92bc8f4535a75c915dd779cbedb83cb9b8fc9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"dc6fc710_80f4a153","in_reply_to":"9ddf0304_618103bb","updated":"2025-09-03 18:05:01.000000000","message":"Signed-off-by is missing in the commit message.","commit_id":"cb0e9842f24943ca1a6b6ee4d120a0dd17a24875"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"061a9cb1324b28d26335919c28d59eb47a08b3d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8544e8ea_030dc21f","in_reply_to":"dc6fc710_80f4a153","updated":"2025-10-27 04:30:34.000000000","message":"Done","commit_id":"cb0e9842f24943ca1a6b6ee4d120a0dd17a24875"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"5c10b4a4cda2670acc9c572e1f760c7f834236d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"655e93c1_c5d6c3ab","updated":"2025-10-27 04:31:44.000000000","message":"Thanks for reviewing! Comments are resolved.","commit_id":"931c1dba51ff5fa4bcfd90524b56712e9bc1e801"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"e1cb56a93d342830ba1c11df033b858cb785c784","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"05501871_cee1af3b","updated":"2026-01-28 09:03:33.000000000","message":"run-DellEMC PowerStore CI","commit_id":"931c1dba51ff5fa4bcfd90524b56712e9bc1e801"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"219dbe9f42ea8e93878ef1e7d2b98e00cb0c7671","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"48587c92_6496116e","updated":"2026-01-28 12:27:51.000000000","message":"run-DellEMC PowerStore CI","commit_id":"931c1dba51ff5fa4bcfd90524b56712e9bc1e801"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"b567eef03fc00aa008e047ead02b28a54b404885","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5b40e3b3_62901424","updated":"2026-02-18 08:30:47.000000000","message":"run-DellEMC PowerStore CI","commit_id":"931c1dba51ff5fa4bcfd90524b56712e9bc1e801"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"3721a62adadba303be0ab8e67de2fbdafe1f252b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"60717840_3d4e2c21","updated":"2026-02-06 05:05:50.000000000","message":"run-DellEMC PowerStore CI","commit_id":"931c1dba51ff5fa4bcfd90524b56712e9bc1e801"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"996ddf0b630062d165d0824d07de0600b5aa1534","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ace4b683_261e6752","updated":"2026-02-18 08:31:48.000000000","message":"run-DellEMC PowerStore CI","commit_id":"931c1dba51ff5fa4bcfd90524b56712e9bc1e801"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"7f46eb1181ff18d8024ba76fb41226c59fbd70e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f0b3f4cf_65e92b2e","updated":"2026-02-13 06:22:00.000000000","message":"run-DellEMC PowerStore CI","commit_id":"931c1dba51ff5fa4bcfd90524b56712e9bc1e801"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"ced9e13d8983a1cace5e6802dcd3ec730975e705","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f798e673_79dd46df","updated":"2026-02-20 09:25:52.000000000","message":"run-DellEMC PowerStore CI","commit_id":"931c1dba51ff5fa4bcfd90524b56712e9bc1e801"}],"cinder/volume/drivers/dell_emc/powerstore/adapter.py":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"b92deb6ad3fc40251e710df35277f7e258bb8885","unresolved":true,"context_lines":[{"line_number":1154,"context_line":"        \"\"\"Get the target_wwns and the initiator target map."},{"line_number":1155,"context_line":""},{"line_number":1156,"context_line":"        :param connector: the connector object"},{"line_number":1157,"context_line":"        :returns: target_wwns -- list, init_targ_map -- dict"},{"line_number":1158,"context_line":"        \"\"\""},{"line_number":1159,"context_line":"        fc_targets \u003d self._get_fc_targets()"},{"line_number":1160,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"a98cca49_b03c2400","line":1157,"updated":"2025-09-03 18:02:31.000000000","message":"nit: The \"--\" to specify typing is really uncommon to me. I guess it would be easier to understand if you had specified that the return of this function is a Tuple containing the list of target wwns and the initiator target map","commit_id":"cb0e9842f24943ca1a6b6ee4d120a0dd17a24875"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"c17f5f467fde203e078191ac5480830e14a9b799","unresolved":false,"context_lines":[{"line_number":1154,"context_line":"        \"\"\"Get the target_wwns and the initiator target map."},{"line_number":1155,"context_line":""},{"line_number":1156,"context_line":"        :param connector: the connector object"},{"line_number":1157,"context_line":"        :returns: target_wwns -- list, init_targ_map -- dict"},{"line_number":1158,"context_line":"        \"\"\""},{"line_number":1159,"context_line":"        fc_targets \u003d self._get_fc_targets()"},{"line_number":1160,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"4fce9324_db79a21a","line":1157,"in_reply_to":"a98cca49_b03c2400","updated":"2025-10-27 04:30:15.000000000","message":"Done","commit_id":"cb0e9842f24943ca1a6b6ee4d120a0dd17a24875"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"b92deb6ad3fc40251e710df35277f7e258bb8885","unresolved":true,"context_lines":[{"line_number":1215,"context_line":"            if not mapped_volumes:"},{"line_number":1216,"context_line":"                target_wwns, init_targ_map \u003d self._get_initiator_target_map("},{"line_number":1217,"context_line":"                    connector)"},{"line_number":1218,"context_line":"                data \u003d {\u0027driver_volume_type\u0027: \u0027fibre_channel\u0027,"},{"line_number":1219,"context_line":"                        \u0027data\u0027: {\u0027target_wwn\u0027: target_wwns,"},{"line_number":1220,"context_line":"                                 \u0027initiator_target_map\u0027: init_targ_map}}"},{"line_number":1221,"context_line":"        fczm_utils.remove_fc_zone(data)"}],"source_content_type":"text/x-python","patch_set":6,"id":"897ae9cd_8eecf4dc","line":1218,"updated":"2025-09-03 18:02:31.000000000","message":"nit: line 1207 already sets driver_volume_type as \u0027fibre_channel\u0027, maybe you could just update the \"data\" dictionary in it instead?","commit_id":"cb0e9842f24943ca1a6b6ee4d120a0dd17a24875"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"c17f5f467fde203e078191ac5480830e14a9b799","unresolved":false,"context_lines":[{"line_number":1215,"context_line":"            if not mapped_volumes:"},{"line_number":1216,"context_line":"                target_wwns, init_targ_map \u003d self._get_initiator_target_map("},{"line_number":1217,"context_line":"                    connector)"},{"line_number":1218,"context_line":"                data \u003d {\u0027driver_volume_type\u0027: \u0027fibre_channel\u0027,"},{"line_number":1219,"context_line":"                        \u0027data\u0027: {\u0027target_wwn\u0027: target_wwns,"},{"line_number":1220,"context_line":"                                 \u0027initiator_target_map\u0027: init_targ_map}}"},{"line_number":1221,"context_line":"        fczm_utils.remove_fc_zone(data)"}],"source_content_type":"text/x-python","patch_set":6,"id":"73698e7c_8c6a279d","line":1218,"in_reply_to":"897ae9cd_8eecf4dc","updated":"2025-10-27 04:30:15.000000000","message":"Done","commit_id":"cb0e9842f24943ca1a6b6ee4d120a0dd17a24875"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"ce1858211814c7fac66a76a31d26861aa2c1e44c","unresolved":true,"context_lines":[{"line_number":1262,"context_line":"        fc_targets \u003d self._get_fc_targets()"},{"line_number":1263,"context_line":""},{"line_number":1264,"context_line":"        target_wwns, init_targ_map \u003d [], {}"},{"line_number":1265,"context_line":"        initiator_wwns \u003d connector[\u0027wwpns\u0027]"},{"line_number":1266,"context_line":"        if self.zonemanager_lookup_service:"},{"line_number":1267,"context_line":"            mapping \u003d ("},{"line_number":1268,"context_line":"                self.zonemanager_lookup_service."}],"source_content_type":"text/x-python","patch_set":10,"id":"1e5a6b0b_82695ce4","line":1265,"updated":"2026-03-06 15:42:01.000000000","message":"assumption is connection always present. I am thinking connection may not be available during force-detach and initialize connection. This will result in type error. This will be problem for upstream calls. better to introduce checks based on your tests.","commit_id":"f932b0b835533edebb7b1692ab8dc9865a3f79f4"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"83072b1451669d590638bd9e69befe8bca8d5409","unresolved":false,"context_lines":[{"line_number":1262,"context_line":"        fc_targets \u003d self._get_fc_targets()"},{"line_number":1263,"context_line":""},{"line_number":1264,"context_line":"        target_wwns, init_targ_map \u003d [], {}"},{"line_number":1265,"context_line":"        initiator_wwns \u003d connector[\u0027wwpns\u0027]"},{"line_number":1266,"context_line":"        if self.zonemanager_lookup_service:"},{"line_number":1267,"context_line":"            mapping \u003d ("},{"line_number":1268,"context_line":"                self.zonemanager_lookup_service."}],"source_content_type":"text/x-python","patch_set":10,"id":"91020f65_88b3881d","line":1265,"in_reply_to":"1e5a6b0b_82695ce4","updated":"2026-03-31 09:23:26.000000000","message":"Done","commit_id":"f932b0b835533edebb7b1692ab8dc9865a3f79f4"}]}