)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"9c9984ddff52dfb3be877af542db3dfb8008cc64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2cf7dd93_f81ee01e","updated":"2024-06-12 23:12:17.000000000","message":"Something is not right. The code looks good, I\u0027m fully onboard.\nHowever, as a test, I ran the new test over the old (unchanged) code,\nand it passed. So, the new test does nothing.\n\nEric, could you please look into this once you\u0027re back?\n\nI did this:\ntox -e py3 -- cinder.tests.unit.volume.drivers.test_rbd.RBDTestCase.test_get_manageable_volumes","commit_id":"425834086719972432ff18361e29f843484adf62"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"58eb47405c6d1787e8a3a190f377a254d8545e0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0da48a05_91149ca4","updated":"2024-06-05 12:11:06.000000000","message":"recheck\n\ntempest-integrated-storage nova-compute lost connectivity to sql server","commit_id":"425834086719972432ff18361e29f843484adf62"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"65e84fc556c3522077d3dff72eeb210d673be66a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"47df21c7_c536cb8c","in_reply_to":"2cf7dd93_f81ee01e","updated":"2024-07-08 14:21:54.000000000","message":"This was a problem in the unit tests, I\u0027ve fixed it.","commit_id":"425834086719972432ff18361e29f843484adf62"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"62589207e935b0c121f5b5bbb6ca7518495dc0a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0ff765f7_c4434437","updated":"2024-07-09 13:16:52.000000000","message":"Fix pep8 errors.","commit_id":"004b9a6f457802b057ce959a11790eaf63cb0c49"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"65e84fc556c3522077d3dff72eeb210d673be66a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0960fbfe_63f2f3c0","updated":"2024-07-08 14:21:54.000000000","message":"I expanded the scope of the patch a bit to have it handle any RBD exception here instead of only ImageNotFound.","commit_id":"004b9a6f457802b057ce959a11790eaf63cb0c49"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"20bc1fd424b2542824d37dbc5669c45252f28a6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f5a914ca_42066d3f","updated":"2024-07-09 11:36:18.000000000","message":"Its weird try-except behave like this with context managers but the code look legit.\nI was really surprised that the \"image\" which declared in the \"with\" block is still known at the except block (outside the with) but it works (at least in python3.8) where I tested it.","commit_id":"004b9a6f457802b057ce959a11790eaf63cb0c49"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"77222ba82995b34110718d29805bc6b4f1be8c52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"abaac03f_2879d74a","updated":"2024-07-08 15:53:13.000000000","message":"This looks fine to me now.","commit_id":"004b9a6f457802b057ce959a11790eaf63cb0c49"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"14862edc9789e443430b220b7ae5db91afcfc9fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d3561a2e_c2d3042e","updated":"2024-10-04 14:39:27.000000000","message":"LGTM.","commit_id":"7f49b41eefbbbe5b5b7f95b5d936ee9118861ba5"}],"cinder/tests/unit/volume/drivers/test_rbd.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e6378ae6e9533ddff4e04c233775d2ab5e76f09e","unresolved":true,"context_lines":[{"line_number":778,"context_line":"                                  8 * units.Gi]"},{"line_number":779,"context_line":"        mock_get_image_status.side_effect \u003d ["},{"line_number":780,"context_line":"            {\u0027watchers\u0027: []},"},{"line_number":781,"context_line":"            self.mock_rbd.ImageNotFound,"},{"line_number":782,"context_line":"            {\u0027watchers\u0027: []}]"},{"line_number":783,"context_line":"        res \u003d self.driver.get_manageable_volumes("},{"line_number":784,"context_line":"            cinder_vols, None, 1000, 0, [\u0027size\u0027], [\u0027asc\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"1c22f058_c1339c58","line":781,"updated":"2024-07-08 13:44:29.000000000","message":"I think this ImageNotFound exception needs to be returned from the self.mock_proxy (RBDVolumeProxy) instead of _get_image_status.","commit_id":"425834086719972432ff18361e29f843484adf62"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e63f49de3e3173a6b025444267f47a1c6fe95c11","unresolved":false,"context_lines":[{"line_number":778,"context_line":"                                  8 * units.Gi]"},{"line_number":779,"context_line":"        mock_get_image_status.side_effect \u003d ["},{"line_number":780,"context_line":"            {\u0027watchers\u0027: []},"},{"line_number":781,"context_line":"            self.mock_rbd.ImageNotFound,"},{"line_number":782,"context_line":"            {\u0027watchers\u0027: []}]"},{"line_number":783,"context_line":"        res \u003d self.driver.get_manageable_volumes("},{"line_number":784,"context_line":"            cinder_vols, None, 1000, 0, [\u0027size\u0027], [\u0027asc\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"0d9762e4_af3bf441","line":781,"in_reply_to":"1c22f058_c1339c58","updated":"2024-07-08 14:20:34.000000000","message":"Done","commit_id":"425834086719972432ff18361e29f843484adf62"}]}