)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0e6690b1548b8f8e53c5cf7c152cda122fedae25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f4075961_30711d43","updated":"2024-06-26 14:46:34.000000000","message":"LGTM, thanks for fixing this.  We should probably backport to all stable branches to keep things consistent.","commit_id":"9afa19e9c96831b319c53fd222d7b822e52da967"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"50b6b03b3b1c48ba0ad8972224a9ef424b9f31f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fe39d6ce_52c9c2fb","updated":"2024-08-02 01:30:13.000000000","message":"Pete\u0027s questions and responses are clarifying, looks good to me.  If SDK compatibility with older stable versions is necessary, backporting this to the active stable branches might be a good thing.","commit_id":"9afa19e9c96831b319c53fd222d7b822e52da967"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"b823bb85388313bfce183354c418e199c51c37c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b6ceb20a_0e2910f1","updated":"2024-07-03 15:02:51.000000000","message":"Wait a moment, the changelog says:\n\nResourceNotFound: 404: Client Error for url:\nhttp://127.0.0.1/volume/v3/default_types/12a1b5e507e7497db79707b0ddedf1a4,\n\nBut the code adds:\n\n\"/{project_id}/default-types/{id}\"\n\nto\n\nmapper.connect(\"default-types\", \"/default-types/{id}\",\n\nThat change cannot possibly make the above URL work, can it now?","commit_id":"9afa19e9c96831b319c53fd222d7b822e52da967"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"7d815bae71cac4b063055250bf5be411c6bd64e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"680e7da9_90bad43e","updated":"2024-08-02 05:56:30.000000000","message":"recheck tempest-integrated-storage","commit_id":"9afa19e9c96831b319c53fd222d7b822e52da967"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"140feb8f46d7f0c574e3326d0ea5c2f73c34ff8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"30b39c56_bf1f4abd","updated":"2024-08-02 07:18:47.000000000","message":"recheck unrelated image test failure in tempest-integrated-storage\n\ntempest.api.image.v2.test_images.ImportImagesTest.test_image_web_download_import\n\nTraceback (most recent call last):\n  File \"/opt/stack/tempest/tempest/api/image/v2/test_images.py\", line 137, in test_image_web_download_import\n    waiters.wait_for_image_imported_to_stores(self.client, image[\u0027id\u0027])\n  File \"/opt/stack/tempest/tempest/common/waiters.py\", line 285, in wait_for_image_imported_to_stores\n    raise exc_cls(message)\ntempest.lib.exceptions.TimeoutException: Request timed out\nDetails: (ImportImagesTest:test_image_web_download_import) Image e4388838-509c-406f-a628-29fb2d6bf552 failed to import on stores:","commit_id":"9afa19e9c96831b319c53fd222d7b822e52da967"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"15a9f633bc0ee496970afe69486402d93d166eaf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c272aa84_3ba03814","in_reply_to":"1e929fb3_d6d4084a","updated":"2024-07-03 16:53:33.000000000","message":"Sorry my bad, the change here is that we can include project ID in the url BEFORE the default-types part, so both of the formats work:\n\nwithout project ID (old): http://127.0.0.1/volume/v3/default-types\nwith project ID (new): http://127.0.0.1/volume/v3/\u003cproject_id\u003e/default-types\n\nThe URL that it will convert into is,\n\nwithout project ID: http://127.0.0.1/volume/v3/default_types/12a1b5e507e7497db79707b0ddedf1a4\n\nwith project ID: http://127.0.0.1/volume/v3/12a1b5e507e7497db79707b0ddedf1a4/default_types/12a1b5e507e7497db79707b0ddedf1a4\n\nit seems redundant to include project ID twice but that\u0027s the standard URL format with which SDK works and is also used with all other cinder APIs.","commit_id":"9afa19e9c96831b319c53fd222d7b822e52da967"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"963fac8889392f158ac6c4730f35c785171d4e38","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1e929fb3_d6d4084a","in_reply_to":"212d5a5d_5417745a","updated":"2024-07-03 16:06:54.000000000","message":"That\u0027s just absurd\n\nThe URL that you\u0027re routing is:\n\nhttp://127.0.0.1/volume/v3/12a1b5e507e7497db79707b0ddedf1a4/default_types/\n\nThe additional pattern is:\n\n\"/{project_id}/default-types/{id}\"\n\nThe URL that you pointed out is this:\n\nhttp://127.0.0.1/volume/v3/default_types/12a1b5e507e7497db79707b0ddedf1a4\n\nBut that is supported by the OLD pattern\n\n/default-types/{id}\n\nThis patch does nothing to help or hinder that!","commit_id":"9afa19e9c96831b319c53fd222d7b822e52da967"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d0481b44137b326d756da48a0009e1238f87e0d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"212d5a5d_5417745a","in_reply_to":"b6ceb20a_0e2910f1","updated":"2024-07-03 15:14:34.000000000","message":"Yes it does, and I\u0027ve tested it with the OSC[1] and SDK[2] patches.\n\nThe reason why it works is because, previously, we only accepted the default type API request without project ID (we did that to support RBAC which was never fully implemented), so we could only query default types with URL not including the project ID,\nexample: http://127.0.0.1/volume/v3/default_types\n\nNow we are adding support for including project IDs so any of the following URL will work\n\nwithout project ID: http://127.0.0.1/volume/v3/default_types\nwith project ID: http://127.0.0.1/volume/v3/default_types/12a1b5e507e7497db79707b0ddedf1a4\n\n[1] https://review.opendev.org/c/openstack/python-openstackclient/+/920465\n[2] https://review.opendev.org/c/openstack/openstacksdk/+/920464","commit_id":"9afa19e9c96831b319c53fd222d7b822e52da967"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"9259b9b88bd1c6fd41511561f686bd5b1becaf0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"70b91778_a81a6893","in_reply_to":"b6ceb20a_0e2910f1","updated":"2024-07-03 15:12:57.000000000","message":"Yes, it does! The loop at L213 creates duplicate router entries for the various default-types API URLs: one entry WITH the project_id, and another WITHOUT the ID. That\u0027s how we meet the 3.67mv requirement, in which inclusion of the project_id is optional.","commit_id":"9afa19e9c96831b319c53fd222d7b822e52da967"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"c83e60ba28442e079c060e8cdee2eecf33a4f95e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dd443239_b21f9dfd","in_reply_to":"c272aa84_3ba03814","updated":"2024-07-03 17:01:20.000000000","message":"Very well, that agrees with what I deduced by looking at the code.\nBut the changelog brings up a 404 caused by the old-pattern URL.\nIs there a possiblity that it was taken in some other context?\nAt the very least the changelog needs to match the code.","commit_id":"9afa19e9c96831b319c53fd222d7b822e52da967"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"86f35dc9cb831a6f5ec70346e983eaf5e1729d44","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"87585a83_6dcca20c","in_reply_to":"dd443239_b21f9dfd","updated":"2024-07-05 06:05:58.000000000","message":"If you are referring to the commit message with the changelog, i think it is accurate (however my response wasn\u0027t).\n\nit says SDK uses this URL (containing project ID)\nhttp://127.0.0.1/volume/v3/\u003cproject_id\u003e/default-types\n\nbut cinder API provides support for this URL (without project ID)\nhttp://127.0.0.1/volume/v3/default-types\n\nand we get a resource not found error while trying to hit this URL (without project ID between /v3 and /default-types)\nhttp://127.0.0.1/volume/v3/default_types/12a1b5e507e7497db79707b0ddedf1a4\n\nthe project ID in the end is a example for a POST request but we can have request with http://127.0.0.1/volume/v3/default_types for listing all default types.\n\nso i don\u0027t see anything wrong with the commit message.","commit_id":"9afa19e9c96831b319c53fd222d7b822e52da967"}]}