)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"faa150cf4a1300c7cbbd3ad5002daf842cde0383","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3ea59e1e_91481e40","updated":"2024-05-30 17:17:45.000000000","message":"Typo and formatting suggestion noted inline.\n\nNote to self when I re-review: the change to the config opts page works correctly.","commit_id":"0004d1f41d6381780304be3fc987efcfe97fa20b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9df056334d568031ed651d3939e42238a5b40466","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"aecfc5a6_609bf95b","updated":"2024-05-30 20:06:39.000000000","message":"Revisions LGTM.  Ninja-approving a documentation-only change.","commit_id":"06766dd34e15a6e90ae7e53a9a3edde8c153ebae"}],"doc/source/common/glossary.rst":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"faa150cf4a1300c7cbbd3ad5002daf842cde0383","unresolved":true,"context_lines":[{"line_number":30,"context_line":"        NQNs can follow one of two supported formats."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        The first format, used by organizations that own a domain, is"},{"line_number":33,"context_line":"        nqn.yyyy-mm.domain:identifier, where \u0027yyyy-mm\u0027 is th eyear and month"},{"line_number":34,"context_line":"        in which the domain was registered, \u0027domain\u0027 is the reversed domain"},{"line_number":35,"context_line":"        name of the issuing organization, and \u0027identifier\u0027 is an optional"},{"line_number":36,"context_line":"        string which makes each NQN unique under the same domain name. For"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dfcf1369_e6d6097a","line":33,"range":{"start_line":33,"start_character":58,"end_line":33,"end_character":66},"updated":"2024-05-30 17:17:45.000000000","message":"the year","commit_id":"0004d1f41d6381780304be3fc987efcfe97fa20b"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"0fc28b3494b5fe713c4e79a8d582e6a03a8d3f52","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        NQNs can follow one of two supported formats."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        The first format, used by organizations that own a domain, is"},{"line_number":33,"context_line":"        nqn.yyyy-mm.domain:identifier, where \u0027yyyy-mm\u0027 is th eyear and month"},{"line_number":34,"context_line":"        in which the domain was registered, \u0027domain\u0027 is the reversed domain"},{"line_number":35,"context_line":"        name of the issuing organization, and \u0027identifier\u0027 is an optional"},{"line_number":36,"context_line":"        string which makes each NQN unique under the same domain name. For"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3b59510a_ee385be5","line":33,"range":{"start_line":33,"start_character":58,"end_line":33,"end_character":66},"in_reply_to":"dfcf1369_e6d6097a","updated":"2024-05-30 17:30:42.000000000","message":"Done","commit_id":"0004d1f41d6381780304be3fc987efcfe97fa20b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"faa150cf4a1300c7cbbd3ad5002daf842cde0383","unresolved":true,"context_lines":[{"line_number":34,"context_line":"        in which the domain was registered, \u0027domain\u0027 is the reversed domain"},{"line_number":35,"context_line":"        name of the issuing organization, and \u0027identifier\u0027 is an optional"},{"line_number":36,"context_line":"        string which makes each NQN unique under the same domain name. For"},{"line_number":37,"context_line":"        example, \u0027nqn.2014-08.com.example:nvme:nvm-subsystem-sn-d78432\u0027."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        The second format is used to create unique identifiers when there is"},{"line_number":40,"context_line":"        not a naming authority or there is not a requirement for a human"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3ea7c538_6c389204","line":37,"updated":"2024-05-30 17:17:45.000000000","message":"I suggest using monospace to make the nqns easier to read.  It\u0027s difficult to because you have to work within the limitations of rst, but you can play around in this editor to try out some formatting (pre-loaded with this text; just hit the \"execute\" button):\n\nhttp://tpcg.io/_O7X1SQ\n\nWhatever you decide on as the best way to format this, you should probably update the IQN section with the same formatting.","commit_id":"0004d1f41d6381780304be3fc987efcfe97fa20b"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"0fc28b3494b5fe713c4e79a8d582e6a03a8d3f52","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        in which the domain was registered, \u0027domain\u0027 is the reversed domain"},{"line_number":35,"context_line":"        name of the issuing organization, and \u0027identifier\u0027 is an optional"},{"line_number":36,"context_line":"        string which makes each NQN unique under the same domain name. For"},{"line_number":37,"context_line":"        example, \u0027nqn.2014-08.com.example:nvme:nvm-subsystem-sn-d78432\u0027."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        The second format is used to create unique identifiers when there is"},{"line_number":40,"context_line":"        not a naming authority or there is not a requirement for a human"}],"source_content_type":"text/x-rst","patch_set":3,"id":"c1a995ef_343f7723","line":37,"in_reply_to":"3ea7c538_6c389204","updated":"2024-05-30 17:30:42.000000000","message":"Done","commit_id":"0004d1f41d6381780304be3fc987efcfe97fa20b"}]}
