)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"9601f6240ffe853dcfcb02f6d2fd247c8f45de3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8db82862_59a8194c","updated":"2024-06-11 11:46:05.000000000","message":"Please do a code review.","commit_id":"87afda67b8a02eff0796fcf52d44e7ac9f30620b"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"de8527bc918e6b28520197b535038f4b98baa0cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6b420e2d_f45cc0cf","updated":"2024-06-12 06:45:08.000000000","message":"Few minor comments inline","commit_id":"0f394b15801991a8fc3601637b08870b0cb165ba"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"b0bf3a00ed7c1da0bae13e72017e1e403d136a9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c0613e7f_0fdd745b","updated":"2024-06-17 09:34:30.000000000","message":"Code changes and UT look good. My comments have been addressed.\nZuul and DellEMC PowerStore CI have passed.","commit_id":"deaf467ace1b5b30abda25e982a3aa389853ea73"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"8856496a695f8f311d667aeb20b96b793b48cb5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"06dacdab_3738b576","updated":"2024-08-01 17:43:22.000000000","message":"Hello,\nzaitcev@kotori.zaitcev.us, rosmaita.fossdev@gmail.com,geguileo@redhat.com,rajatdhasmana@gmail.com.\nplease review this patch.","commit_id":"cd1707e862f385d1ada8928062734766917ef08a"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"7d1f847f4342db82421f97a9f46649b9915ab862","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"0930a233_474c39c2","updated":"2024-08-02 06:16:08.000000000","message":"Hi Nilesh,\nJust a suggestion: You may add your patch in \"Review Requests\" section of next cinder weekly meet.\nhttps://etherpad.opendev.org/p/cinder-dalmatian-meetings\n\nIt may help to receive attention from wider audience.","commit_id":"cd1707e862f385d1ada8928062734766917ef08a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"4a839c8c1d99ca6b10b8db39e22d014d3507973d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d777ad6d_46a21245","updated":"2024-08-02 04:46:42.000000000","message":"LGTM. My comments are addressed.","commit_id":"cd1707e862f385d1ada8928062734766917ef08a"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"b07e2f14e09104674aa56dbd38a5df96e8038781","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"78a5c93c_e07251a5","updated":"2024-08-19 05:00:01.000000000","message":"Team,\nPlease review the patch. I’ve been requesting reviews for a while now, so your feedback is much appreciated.","commit_id":"cd1707e862f385d1ada8928062734766917ef08a"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"2b440c3463f12d1ad793e96dd1998f0c73963500","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"3e889d53_ba8337c0","updated":"2024-08-02 06:29:10.000000000","message":"Thanks @raghavendra-uddhav.tilay@hpe.com\nI don\u0027t know about it. I will do it.","commit_id":"cd1707e862f385d1ada8928062734766917ef08a"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"cb0e143f32dfbe2fd160476d5d735f04719ae5aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c6f20ae8_9b52b9da","updated":"2024-07-30 09:53:24.000000000","message":"core team please do a code review","commit_id":"cd1707e862f385d1ada8928062734766917ef08a"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"bcc64c2ca43661ac7194b10d92b644ee29a01ff8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"117d40de_7da387c4","updated":"2024-07-26 14:06:17.000000000","message":"recheck","commit_id":"cd1707e862f385d1ada8928062734766917ef08a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"349d8f90d66f3678fb79825304c269a3df33d0f8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"98044612_85fe5c28","updated":"2024-08-29 00:02:19.000000000","message":"@nilesh.thathagar@dell.com\nAs to the file \u0027cinder/volume/drivers/dell_emc/powerstore/ps_exception.py\u0027,\nPowerStore is a brand name, and should not be represented by \u0027ps\u0027.\nAlso the file is in folder \u0027powerstore\u0027, file name \u0027exception.py\u0027 is fine.","commit_id":"934079c4f09e8d3687d57b7ad3aaf46c9859aef8"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"502cec7de5c92ed532ab8c5d3e3f83e3e8583b0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4485dadf_1ef69639","updated":"2024-08-21 14:06:27.000000000","message":"Ignore previous comment - generic volume groups and consistency groups are ok.","commit_id":"934079c4f09e8d3687d57b7ad3aaf46c9859aef8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e116482c0892c181e4ddb9691ed731aa1caabae5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4a959627_9c504343","updated":"2024-08-28 22:30:49.000000000","message":"Mostly looks good.  Primary issue is in ps_exception.py (but will be really quick to fix), the others are typos (but you might as well correct them when you push the revision).","commit_id":"934079c4f09e8d3687d57b7ad3aaf46c9859aef8"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"c64cbd41e545904956ccde28c60dd468632473be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"a7aa4464_ec179366","updated":"2024-08-28 04:30:23.000000000","message":"PowerStore-NFS is failing, and a bug report has been filed: https://bugs.launchpad.net/cinder/+bug/2073503.\" @rosmaita.fossdev@gmail.com is aware about it.","commit_id":"934079c4f09e8d3687d57b7ad3aaf46c9859aef8"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"84d3fba3026467bcc2642bd7388f1e933e163f0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"aabdf6b7_2bd5539a","updated":"2024-08-27 12:39:25.000000000","message":"Team, please review the code, code will freeze in the next 3 days.","commit_id":"934079c4f09e8d3687d57b7ad3aaf46c9859aef8"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"4720d4eeb4f6c4eaa2f048a9096fa622654b0508","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ec9c9b12_e70e7a9a","in_reply_to":"98044612_85fe5c28","updated":"2024-08-29 05:05:34.000000000","message":"Acknowledged","commit_id":"934079c4f09e8d3687d57b7ad3aaf46c9859aef8"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"4720d4eeb4f6c4eaa2f048a9096fa622654b0508","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"46694ac0_e9825548","updated":"2024-08-29 05:05:34.000000000","message":"Have updated patch according to review comments.\n@rosmaita.fossdev@gmail.com Please do a review.","commit_id":"3b4c9769018ab5df3d44356efb5fa9e41e0aef99"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d75f1e1ea209e215cdd5b934d871b9e718ce30f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"92b217c0_7de46099","updated":"2024-08-29 18:48:03.000000000","message":"Thanks Nilesh, few comments inline.","commit_id":"3b4c9769018ab5df3d44356efb5fa9e41e0aef99"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"ccb5d2b944590440aa8a63d13c76c91ba0451c7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"016cef91_bcf6e815","updated":"2024-08-29 07:49:08.000000000","message":"recheck cinder-plugin-ceph-tempest","commit_id":"3b4c9769018ab5df3d44356efb5fa9e41e0aef99"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"dd6b359e67c8fe4e4de1643b945bd36bcdc0fa70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"a0205c7e_0a588618","updated":"2024-08-30 09:56:02.000000000","message":"CI passed, approving.","commit_id":"bf52e877e46e55e2cfe2640b0aeb8add47672011"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8b13c372b7c1fef024da7db38807ed450ed0fd68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f209902d_54afb3ff","updated":"2024-08-29 21:38:06.000000000","message":"Revisions LGTM.","commit_id":"bf52e877e46e55e2cfe2640b0aeb8add47672011"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"a66546119e97d21c08859f35c8eb9e908ce97a3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"7b789d3e_dd793022","updated":"2024-08-29 19:33:01.000000000","message":"Thanks @rajatdhasmana@gmail.com for the review.\nI have updated patch for \"both\" key check-mark and provided inline comments.\nPlease check it.","commit_id":"bf52e877e46e55e2cfe2640b0aeb8add47672011"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"b3377df628d7de9740e7c21822b5b7c11b5777a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"c16488c8_16a5610f","updated":"2024-08-30 04:22:16.000000000","message":"Thanks @rajatdhasmana@gmail.com. There is problem in CI execution. E-lab team working on it. Once it gets fixed will let you know.","commit_id":"bf52e877e46e55e2cfe2640b0aeb8add47672011"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"a848b2aad3fded4d052a748ddf54c8be1df895bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"fcb406f3_329fbc69","updated":"2024-08-30 10:33:59.000000000","message":"recheck","commit_id":"bf52e877e46e55e2cfe2640b0aeb8add47672011"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"bd2932f3e57ae9d2eafe43a77778af1e747f8c65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"0c4e6f8b_0ccc3c00","updated":"2024-08-30 12:25:24.000000000","message":"recheck cinder-grenade-mn-sub-volbak - failure during devstack setup","commit_id":"bf52e877e46e55e2cfe2640b0aeb8add47672011"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"994351939c0852766fb4b607e2df425148051868","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"10162e00_6b35aae6","updated":"2024-08-30 02:33:57.000000000","message":"run-DellEMC PowerStore CI","commit_id":"bf52e877e46e55e2cfe2640b0aeb8add47672011"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"430408dcada7ec838eb84586595e731bcdc14090","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"6f925e4b_e4307bde","updated":"2024-08-30 06:35:57.000000000","message":"run-DellEMC PowerStore CI","commit_id":"bf52e877e46e55e2cfe2640b0aeb8add47672011"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"ef07937f0e052fb374c452e5c274205cf89e8102","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"ceca1d34_48617c6f","updated":"2024-08-30 05:42:41.000000000","message":"run-DellEMC PowerStore CI","commit_id":"bf52e877e46e55e2cfe2640b0aeb8add47672011"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1b5a1ea5e40cfeaf83b5381ef7d219046550af80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f50bb0bc_ec30006f","updated":"2024-08-30 04:19:07.000000000","message":"run-DellEMC PowerStore CI\n\nmy comments are addressed, LGTM. CI is failing, let\u0027s re-run it.","commit_id":"bf52e877e46e55e2cfe2640b0aeb8add47672011"}],"cinder/exception.py":[{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"94cfd92e19b8bba11fe0f7bc8ce6117856193294","unresolved":true,"context_lines":[{"line_number":1106,"context_line":""},{"line_number":1107,"context_line":""},{"line_number":1108,"context_line":"class QoSIORuleExists(Duplicate):"},{"line_number":1109,"context_line":"    message \u003d _(\u0027Qos I/O Rule %(name)s is already exists.\u0027)"},{"line_number":1110,"context_line":""},{"line_number":1111,"context_line":""},{"line_number":1112,"context_line":"class QoSPolicyExists(Duplicate):"}],"source_content_type":"text/x-python","patch_set":2,"id":"230bc22f_52c38795","line":1109,"updated":"2024-06-12 06:58:53.000000000","message":"QoS","commit_id":"0f394b15801991a8fc3601637b08870b0cb165ba"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"b904b7f1e07b59a5f1f3f0dccd7cda5b7f05cffb","unresolved":false,"context_lines":[{"line_number":1106,"context_line":""},{"line_number":1107,"context_line":""},{"line_number":1108,"context_line":"class QoSIORuleExists(Duplicate):"},{"line_number":1109,"context_line":"    message \u003d _(\u0027Qos I/O Rule %(name)s is already exists.\u0027)"},{"line_number":1110,"context_line":""},{"line_number":1111,"context_line":""},{"line_number":1112,"context_line":"class QoSPolicyExists(Duplicate):"}],"source_content_type":"text/x-python","patch_set":2,"id":"35a308c3_2319192d","line":1109,"in_reply_to":"230bc22f_52c38795","updated":"2024-06-12 08:09:38.000000000","message":"Done","commit_id":"0f394b15801991a8fc3601637b08870b0cb165ba"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"94cfd92e19b8bba11fe0f7bc8ce6117856193294","unresolved":true,"context_lines":[{"line_number":1110,"context_line":""},{"line_number":1111,"context_line":""},{"line_number":1112,"context_line":"class QoSPolicyExists(Duplicate):"},{"line_number":1113,"context_line":"    message \u003d _(\u0027Qos policy %(name)s is already exists.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5b0508b6_164f27df","line":1113,"updated":"2024-06-12 06:58:53.000000000","message":"QoS","commit_id":"0f394b15801991a8fc3601637b08870b0cb165ba"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"b904b7f1e07b59a5f1f3f0dccd7cda5b7f05cffb","unresolved":false,"context_lines":[{"line_number":1110,"context_line":""},{"line_number":1111,"context_line":""},{"line_number":1112,"context_line":"class QoSPolicyExists(Duplicate):"},{"line_number":1113,"context_line":"    message \u003d _(\u0027Qos policy %(name)s is already exists.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"0163d4c4_0bc9449f","line":1113,"in_reply_to":"5b0508b6_164f27df","updated":"2024-06-12 08:09:38.000000000","message":"Done","commit_id":"0f394b15801991a8fc3601637b08870b0cb165ba"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"bc2950f996c86b34a358189015d54a56deba0241","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"09b8049d_a8fa3222","line":1114,"range":{"start_line":1108,"start_character":0,"end_line":1114,"end_character":0},"updated":"2024-07-07 11:38:59.000000000","message":"Are these 2 exceptions common for all drivers or specific for Dell only?","commit_id":"deaf467ace1b5b30abda25e982a3aa389853ea73"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"c63364c29f327b57ce135d62fed96ba4272649e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ca5dab58_4c5dc92a","line":1114,"range":{"start_line":1108,"start_character":0,"end_line":1114,"end_character":0},"in_reply_to":"09b8049d_a8fa3222","updated":"2024-07-08 09:54:20.000000000","message":"It is specific to the Dell only.","commit_id":"deaf467ace1b5b30abda25e982a3aa389853ea73"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"ee8c2d0dc2e3a4bb0515276ec09eeae29bdb933d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"31593e31_9b74698f","line":1114,"range":{"start_line":1108,"start_character":0,"end_line":1114,"end_character":0},"in_reply_to":"268ad2b6_373c029f","updated":"2024-07-26 09:28:31.000000000","message":"Changed to DellPowerStore sepcific.","commit_id":"deaf467ace1b5b30abda25e982a3aa389853ea73"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"6690e15b839479381b5fbaed0cf96d15aacca1fb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"268ad2b6_373c029f","line":1114,"range":{"start_line":1108,"start_character":0,"end_line":1114,"end_character":0},"in_reply_to":"ca5dab58_4c5dc92a","updated":"2024-07-09 06:32:47.000000000","message":"IMO, it\u0027s better to rename those exceptions to \u0027DellPowerStoreQoSIORuleExists\u0027 and \u0027DellPowerStoreQoSPolicyExists\u0027 as they are Dell specific.","commit_id":"deaf467ace1b5b30abda25e982a3aa389853ea73"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"4d2f3fd634f20268b2f5b8cc16aa20b12f6386d6","unresolved":true,"context_lines":[{"line_number":1105,"context_line":"    safe \u003d True"},{"line_number":1106,"context_line":""},{"line_number":1107,"context_line":""},{"line_number":1108,"context_line":"class DellPowerStoreQoSIORuleExists(Duplicate):"},{"line_number":1109,"context_line":"    message \u003d _(\u0027QoS I/O Rule %(name)s is already exists.\u0027)"},{"line_number":1110,"context_line":""},{"line_number":1111,"context_line":""},{"line_number":1112,"context_line":"class DellPowerStoreQoSPolicyExists(Duplicate):"},{"line_number":1113,"context_line":"    message \u003d _(\u0027QoS policy %(name)s is already exists.\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"2c3d0505_297a4571","line":1113,"range":{"start_line":1108,"start_character":0,"end_line":1113,"end_character":57},"updated":"2024-08-20 11:41:04.000000000","message":"These should be defined in the driver code rather than added to the cinder-wide exceptions file.","commit_id":"cd1707e862f385d1ada8928062734766917ef08a"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"a8fd9bb14a80358d692c6ea9139fa2f4922efc33","unresolved":false,"context_lines":[{"line_number":1105,"context_line":"    safe \u003d True"},{"line_number":1106,"context_line":""},{"line_number":1107,"context_line":""},{"line_number":1108,"context_line":"class DellPowerStoreQoSIORuleExists(Duplicate):"},{"line_number":1109,"context_line":"    message \u003d _(\u0027QoS I/O Rule %(name)s is already exists.\u0027)"},{"line_number":1110,"context_line":""},{"line_number":1111,"context_line":""},{"line_number":1112,"context_line":"class DellPowerStoreQoSPolicyExists(Duplicate):"},{"line_number":1113,"context_line":"    message \u003d _(\u0027QoS policy %(name)s is already exists.\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"c0780778_10a745cc","line":1113,"range":{"start_line":1108,"start_character":0,"end_line":1113,"end_character":57},"in_reply_to":"2c3d0505_297a4571","updated":"2024-08-20 12:53:06.000000000","message":"Thanks for the code review, Eric. I have made changes.\n\nPlease review it.","commit_id":"cd1707e862f385d1ada8928062734766917ef08a"}],"cinder/tests/unit/volume/drivers/dell_emc/powerstore/test_client.py":[{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"94cfd92e19b8bba11fe0f7bc8ce6117856193294","unresolved":true,"context_lines":[{"line_number":229,"context_line":"                        \"severity\": \"Error\","},{"line_number":230,"context_line":"                        \"message_l10n\": \"The new policy name qos-policy-\""},{"line_number":231,"context_line":"                                        \"6b6e5489-4b5b-4468-a1f7-32cec2ffa3bf \""},{"line_number":232,"context_line":"                                        \"is in use. It must be unique \""},{"line_number":233,"context_line":"                                        \"regardless of character cases.\","},{"line_number":234,"context_line":"                        \"arguments\": ["},{"line_number":235,"context_line":"                            \"qos-policy-6b6e5489-4b5b-4468-a1f7-32cec2ffa3bf\""}],"source_content_type":"text/x-python","patch_set":2,"id":"2c2b203e_51925f5f","line":232,"updated":"2024-06-12 06:58:53.000000000","message":"is already in use.","commit_id":"0f394b15801991a8fc3601637b08870b0cb165ba"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"b904b7f1e07b59a5f1f3f0dccd7cda5b7f05cffb","unresolved":false,"context_lines":[{"line_number":229,"context_line":"                        \"severity\": \"Error\","},{"line_number":230,"context_line":"                        \"message_l10n\": \"The new policy name qos-policy-\""},{"line_number":231,"context_line":"                                        \"6b6e5489-4b5b-4468-a1f7-32cec2ffa3bf \""},{"line_number":232,"context_line":"                                        \"is in use. It must be unique \""},{"line_number":233,"context_line":"                                        \"regardless of character cases.\","},{"line_number":234,"context_line":"                        \"arguments\": ["},{"line_number":235,"context_line":"                            \"qos-policy-6b6e5489-4b5b-4468-a1f7-32cec2ffa3bf\""}],"source_content_type":"text/x-python","patch_set":2,"id":"226887b5_7904524f","line":232,"in_reply_to":"2c2b203e_51925f5f","updated":"2024-06-12 08:09:38.000000000","message":"This message is getting from PowerStore API. so, I keep it as it is.","commit_id":"0f394b15801991a8fc3601637b08870b0cb165ba"}],"cinder/volume/drivers/dell_emc/powerstore/adapter.py":[{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"94cfd92e19b8bba11fe0f7bc8ce6117856193294","unresolved":true,"context_lines":[{"line_number":1030,"context_line":""},{"line_number":1031,"context_line":"    def _create_or_update_volume_qos_policy(self, volume,"},{"line_number":1032,"context_line":"                                            provider_id, operation):"},{"line_number":1033,"context_line":"        \"\"\"Create or update volume qos policy"},{"line_number":1034,"context_line":""},{"line_number":1035,"context_line":"        @param volume: OpenStack volume object"},{"line_number":1036,"context_line":"        @param provider_id: Volume provider Id"}],"source_content_type":"text/x-python","patch_set":2,"id":"66ee075f_667c9423","line":1033,"updated":"2024-06-12 06:58:53.000000000","message":"QoS","commit_id":"0f394b15801991a8fc3601637b08870b0cb165ba"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"b904b7f1e07b59a5f1f3f0dccd7cda5b7f05cffb","unresolved":false,"context_lines":[{"line_number":1030,"context_line":""},{"line_number":1031,"context_line":"    def _create_or_update_volume_qos_policy(self, volume,"},{"line_number":1032,"context_line":"                                            provider_id, operation):"},{"line_number":1033,"context_line":"        \"\"\"Create or update volume qos policy"},{"line_number":1034,"context_line":""},{"line_number":1035,"context_line":"        @param volume: OpenStack volume object"},{"line_number":1036,"context_line":"        @param provider_id: Volume provider Id"}],"source_content_type":"text/x-python","patch_set":2,"id":"137fd5c0_50a8f999","line":1033,"in_reply_to":"66ee075f_667c9423","updated":"2024-06-12 08:09:38.000000000","message":"Done","commit_id":"0f394b15801991a8fc3601637b08870b0cb165ba"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"94cfd92e19b8bba11fe0f7bc8ce6117856193294","unresolved":true,"context_lines":[{"line_number":1050,"context_line":"                                                          None)"},{"line_number":1051,"context_line":""},{"line_number":1052,"context_line":"    def _check_qos_support(self):"},{"line_number":1053,"context_line":"        \"\"\"Check PowerStore array support qos or not"},{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":"        @return: Version is supported or not in boolean"},{"line_number":1056,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"0f44cfcf_354d1459","line":1053,"updated":"2024-06-12 06:58:53.000000000","message":"QoS","commit_id":"0f394b15801991a8fc3601637b08870b0cb165ba"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"b904b7f1e07b59a5f1f3f0dccd7cda5b7f05cffb","unresolved":false,"context_lines":[{"line_number":1050,"context_line":"                                                          None)"},{"line_number":1051,"context_line":""},{"line_number":1052,"context_line":"    def _check_qos_support(self):"},{"line_number":1053,"context_line":"        \"\"\"Check PowerStore array support qos or not"},{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":"        @return: Version is supported or not in boolean"},{"line_number":1056,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"e6811950_0ca898e5","line":1053,"in_reply_to":"0f44cfcf_354d1459","updated":"2024-06-12 08:09:38.000000000","message":"Done","commit_id":"0f394b15801991a8fc3601637b08870b0cb165ba"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"94cfd92e19b8bba11fe0f7bc8ce6117856193294","unresolved":true,"context_lines":[{"line_number":1074,"context_line":"           retries\u003d3,"},{"line_number":1075,"context_line":"           backoff_rate\u003d2)"},{"line_number":1076,"context_line":"    def _get_or_create_qos_policy(self, qos_specs):"},{"line_number":1077,"context_line":"        \"\"\"Get or create qos policy"},{"line_number":1078,"context_line":""},{"line_number":1079,"context_line":"        1. Create operation: It will verify if a QoS policy is created for the"},{"line_number":1080,"context_line":"        volume type. If not, it will create an I/O limit rule, establish"}],"source_content_type":"text/x-python","patch_set":2,"id":"e8a32c24_99697aac","line":1077,"updated":"2024-06-12 06:58:53.000000000","message":"QoS","commit_id":"0f394b15801991a8fc3601637b08870b0cb165ba"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"b904b7f1e07b59a5f1f3f0dccd7cda5b7f05cffb","unresolved":false,"context_lines":[{"line_number":1074,"context_line":"           retries\u003d3,"},{"line_number":1075,"context_line":"           backoff_rate\u003d2)"},{"line_number":1076,"context_line":"    def _get_or_create_qos_policy(self, qos_specs):"},{"line_number":1077,"context_line":"        \"\"\"Get or create qos policy"},{"line_number":1078,"context_line":""},{"line_number":1079,"context_line":"        1. Create operation: It will verify if a QoS policy is created for the"},{"line_number":1080,"context_line":"        volume type. If not, it will create an I/O limit rule, establish"}],"source_content_type":"text/x-python","patch_set":2,"id":"8a785963_2df515fe","line":1077,"in_reply_to":"e8a32c24_99697aac","updated":"2024-06-12 08:09:38.000000000","message":"Done","commit_id":"0f394b15801991a8fc3601637b08870b0cb165ba"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d75f1e1ea209e215cdd5b934d871b9e718ce30f0","unresolved":true,"context_lines":[{"line_number":1042,"context_line":"        volume_type_id \u003d volume[\"volume_type_id\"]"},{"line_number":1043,"context_line":"        specs \u003d volume_types.get_volume_type_qos_specs(volume_type_id)"},{"line_number":1044,"context_line":"        qos_specs \u003d specs[\u0027qos_specs\u0027]"},{"line_number":1045,"context_line":"        if (qos_specs is not None and qos_specs[\"consumer\"] \u003d\u003d \"back-end\""},{"line_number":1046,"context_line":"                and self._check_qos_support()):"},{"line_number":1047,"context_line":"            if operation \u003d\u003d utils.VOLUME_ATTACH_OPERATION:"},{"line_number":1048,"context_line":"                qos_policy_id \u003d self._get_or_create_qos_policy(qos_specs)"}],"source_content_type":"text/x-python","patch_set":11,"id":"a71c3072_2e20cc1a","line":1045,"range":{"start_line":1045,"start_character":38,"end_line":1045,"end_character":73},"updated":"2024-08-29 18:48:03.000000000","message":"we need to check against two keys here,\n1. \"back-end\"\n2. \"both\"","commit_id":"3b4c9769018ab5df3d44356efb5fa9e41e0aef99"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"a66546119e97d21c08859f35c8eb9e908ce97a3d","unresolved":false,"context_lines":[{"line_number":1042,"context_line":"        volume_type_id \u003d volume[\"volume_type_id\"]"},{"line_number":1043,"context_line":"        specs \u003d volume_types.get_volume_type_qos_specs(volume_type_id)"},{"line_number":1044,"context_line":"        qos_specs \u003d specs[\u0027qos_specs\u0027]"},{"line_number":1045,"context_line":"        if (qos_specs is not None and qos_specs[\"consumer\"] \u003d\u003d \"back-end\""},{"line_number":1046,"context_line":"                and self._check_qos_support()):"},{"line_number":1047,"context_line":"            if operation \u003d\u003d utils.VOLUME_ATTACH_OPERATION:"},{"line_number":1048,"context_line":"                qos_policy_id \u003d self._get_or_create_qos_policy(qos_specs)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9d584481_e46a62e1","line":1045,"range":{"start_line":1045,"start_character":38,"end_line":1045,"end_character":73},"in_reply_to":"a71c3072_2e20cc1a","updated":"2024-08-29 19:33:01.000000000","message":"Have added checkmark of \"both\" as well.","commit_id":"3b4c9769018ab5df3d44356efb5fa9e41e0aef99"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d75f1e1ea209e215cdd5b934d871b9e718ce30f0","unresolved":true,"context_lines":[{"line_number":1095,"context_line":"        io_rule_name \u003d \"io-rule-%s\" % qos_id"},{"line_number":1096,"context_line":"        specs \u003d qos_specs[\"specs\"]"},{"line_number":1097,"context_line":"        io_rule_params \u003d {"},{"line_number":1098,"context_line":"            \"type\": (specs[\"bandwidth_limit_type\"]"},{"line_number":1099,"context_line":"                     if \"bandwidth_limit_type\" in specs else None),"},{"line_number":1100,"context_line":"            \"max_iops\":"},{"line_number":1101,"context_line":"                int(specs[\"max_iops\"]) if \"max_iops\" in specs else None,"},{"line_number":1102,"context_line":"            \"max_bw\":"}],"source_content_type":"text/x-python","patch_set":11,"id":"9181192d_90b23af4","line":1099,"range":{"start_line":1098,"start_character":0,"end_line":1099,"end_character":67},"updated":"2024-08-29 18:48:03.000000000","message":"as per the docs, this is a mandatory filed so shouldn\u0027t we error out if this is not provided in the qos spec?","commit_id":"3b4c9769018ab5df3d44356efb5fa9e41e0aef99"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"a66546119e97d21c08859f35c8eb9e908ce97a3d","unresolved":false,"context_lines":[{"line_number":1095,"context_line":"        io_rule_name \u003d \"io-rule-%s\" % qos_id"},{"line_number":1096,"context_line":"        specs \u003d qos_specs[\"specs\"]"},{"line_number":1097,"context_line":"        io_rule_params \u003d {"},{"line_number":1098,"context_line":"            \"type\": (specs[\"bandwidth_limit_type\"]"},{"line_number":1099,"context_line":"                     if \"bandwidth_limit_type\" in specs else None),"},{"line_number":1100,"context_line":"            \"max_iops\":"},{"line_number":1101,"context_line":"                int(specs[\"max_iops\"]) if \"max_iops\" in specs else None,"},{"line_number":1102,"context_line":"            \"max_bw\":"}],"source_content_type":"text/x-python","patch_set":11,"id":"a184e0c5_d6a2633f","line":1099,"range":{"start_line":1098,"start_character":0,"end_line":1099,"end_character":67},"in_reply_to":"9181192d_90b23af4","updated":"2024-08-29 19:33:01.000000000","message":"There are two mandatory fields: bandwidth_limit_type and either max_iops or max_bw. Since all necessary validation is handled by the PowerStore backend (API), we have decided not to implement additional validation in Cinder. If any required fields are missing, the PowerStore API will return an error.","commit_id":"3b4c9769018ab5df3d44356efb5fa9e41e0aef99"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1b5a1ea5e40cfeaf83b5381ef7d219046550af80","unresolved":false,"context_lines":[{"line_number":1095,"context_line":"        io_rule_name \u003d \"io-rule-%s\" % qos_id"},{"line_number":1096,"context_line":"        specs \u003d qos_specs[\"specs\"]"},{"line_number":1097,"context_line":"        io_rule_params \u003d {"},{"line_number":1098,"context_line":"            \"type\": (specs[\"bandwidth_limit_type\"]"},{"line_number":1099,"context_line":"                     if \"bandwidth_limit_type\" in specs else None),"},{"line_number":1100,"context_line":"            \"max_iops\":"},{"line_number":1101,"context_line":"                int(specs[\"max_iops\"]) if \"max_iops\" in specs else None,"},{"line_number":1102,"context_line":"            \"max_bw\":"}],"source_content_type":"text/x-python","patch_set":11,"id":"b0f52f52_253c74b2","line":1099,"range":{"start_line":1098,"start_character":0,"end_line":1099,"end_character":67},"in_reply_to":"a184e0c5_d6a2633f","updated":"2024-08-30 04:19:07.000000000","message":"Ack, my idea was about \"failing fast\". if we have the fields in the volume type and we know required values are missing are missing, there is no point sending an API request to PowerStore to validate it since we are just delaying the failure. but since we at least have a place validating it, it can be done as an improvement later.","commit_id":"3b4c9769018ab5df3d44356efb5fa9e41e0aef99"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8b13c372b7c1fef024da7db38807ed450ed0fd68","unresolved":true,"context_lines":[{"line_number":1043,"context_line":"        specs \u003d volume_types.get_volume_type_qos_specs(volume_type_id)"},{"line_number":1044,"context_line":"        qos_specs \u003d specs[\u0027qos_specs\u0027]"},{"line_number":1045,"context_line":"        if (qos_specs is not None and (qos_specs[\"consumer\"] \u003d\u003d \"back-end\" or"},{"line_number":1046,"context_line":"                                       qos_specs[\"consumer\"] \u003d\u003d \"both\")"},{"line_number":1047,"context_line":"                and self._check_qos_support()):"},{"line_number":1048,"context_line":"            if operation \u003d\u003d utils.VOLUME_ATTACH_OPERATION:"},{"line_number":1049,"context_line":"                qos_policy_id \u003d self._get_or_create_qos_policy(qos_specs)"}],"source_content_type":"text/x-python","patch_set":12,"id":"4d755c78_11a5a8c2","line":1046,"range":{"start_line":1046,"start_character":64,"end_line":1046,"end_character":70},"updated":"2024-08-29 21:38:06.000000000","message":"this was a good catch by Rajat!","commit_id":"bf52e877e46e55e2cfe2640b0aeb8add47672011"}],"cinder/volume/drivers/dell_emc/powerstore/client.py":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"de8527bc918e6b28520197b535038f4b98baa0cd","unresolved":true,"context_lines":[{"line_number":848,"context_line":"            payload\u003dpolicy_params"},{"line_number":849,"context_line":"        )"},{"line_number":850,"context_line":"        if r.status_code not in self.ok_codes:"},{"line_number":851,"context_line":"            msg \u003d _(\"Failed to create PowerStore Qos \""},{"line_number":852,"context_line":"                    \"policy %s.\" % policy_params[\"name\"])"},{"line_number":853,"context_line":"            LOG.error(msg)"},{"line_number":854,"context_line":"            if (\"messages\" in response and"}],"source_content_type":"text/x-python","patch_set":2,"id":"8ea7643d_cda73338","line":851,"range":{"start_line":851,"start_character":49,"end_line":851,"end_character":52},"updated":"2024-06-12 06:45:08.000000000","message":"nit: QoS","commit_id":"0f394b15801991a8fc3601637b08870b0cb165ba"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"b904b7f1e07b59a5f1f3f0dccd7cda5b7f05cffb","unresolved":false,"context_lines":[{"line_number":848,"context_line":"            payload\u003dpolicy_params"},{"line_number":849,"context_line":"        )"},{"line_number":850,"context_line":"        if r.status_code not in self.ok_codes:"},{"line_number":851,"context_line":"            msg \u003d _(\"Failed to create PowerStore Qos \""},{"line_number":852,"context_line":"                    \"policy %s.\" % policy_params[\"name\"])"},{"line_number":853,"context_line":"            LOG.error(msg)"},{"line_number":854,"context_line":"            if (\"messages\" in response and"}],"source_content_type":"text/x-python","patch_set":2,"id":"6f31d2be_88dd2f15","line":851,"range":{"start_line":851,"start_character":49,"end_line":851,"end_character":52},"in_reply_to":"8ea7643d_cda73338","updated":"2024-06-12 08:09:38.000000000","message":"Done","commit_id":"0f394b15801991a8fc3601637b08870b0cb165ba"}],"cinder/volume/drivers/dell_emc/powerstore/driver.py":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"de8527bc918e6b28520197b535038f4b98baa0cd","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        1.2.2 - QoS (Quality of Service) support"},{"line_number":57,"context_line":"    \"\"\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    VERSION \u003d \"1.2.1\""},{"line_number":60,"context_line":"    VENDOR \u003d \"Dell EMC\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    # ThirdPartySystems wiki page"}],"source_content_type":"text/x-python","patch_set":2,"id":"b38e9b22_641a36e7","line":59,"range":{"start_line":59,"start_character":15,"end_line":59,"end_character":20},"updated":"2024-06-12 06:45:08.000000000","message":"nit: 1.2.2","commit_id":"0f394b15801991a8fc3601637b08870b0cb165ba"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"b904b7f1e07b59a5f1f3f0dccd7cda5b7f05cffb","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        1.2.2 - QoS (Quality of Service) support"},{"line_number":57,"context_line":"    \"\"\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    VERSION \u003d \"1.2.1\""},{"line_number":60,"context_line":"    VENDOR \u003d \"Dell EMC\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    # ThirdPartySystems wiki page"}],"source_content_type":"text/x-python","patch_set":2,"id":"4b14f67f_048aee6c","line":59,"range":{"start_line":59,"start_character":15,"end_line":59,"end_character":20},"in_reply_to":"b38e9b22_641a36e7","updated":"2024-06-12 08:09:38.000000000","message":"Done","commit_id":"0f394b15801991a8fc3601637b08870b0cb165ba"}],"cinder/volume/drivers/dell_emc/powerstore/ps_exception.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e116482c0892c181e4ddb9691ed731aa1caabae5","unresolved":true,"context_lines":[{"line_number":9,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":"from cinder.exception import Duplicate"},{"line_number":13,"context_line":"from cinder.i18n import _"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"172c9bb3_28be4fb6","line":12,"range":{"start_line":12,"start_character":29,"end_line":12,"end_character":38},"updated":"2024-08-28 22:30:49.000000000","message":"-1: In general, we want driver-specific exceptions to inherit from VolumeDriverException or VolumeBackendAPIException, which is what cinder will be looking for.","commit_id":"934079c4f09e8d3687d57b7ad3aaf46c9859aef8"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"4720d4eeb4f6c4eaa2f048a9096fa622654b0508","unresolved":false,"context_lines":[{"line_number":9,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":"from cinder.exception import Duplicate"},{"line_number":13,"context_line":"from cinder.i18n import _"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1ab09f14_6bb39666","line":12,"range":{"start_line":12,"start_character":29,"end_line":12,"end_character":38},"in_reply_to":"172c9bb3_28be4fb6","updated":"2024-08-29 05:05:34.000000000","message":"Got it. Thanks. Have changed according.","commit_id":"934079c4f09e8d3687d57b7ad3aaf46c9859aef8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e116482c0892c181e4ddb9691ed731aa1caabae5","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class DellPowerStoreQoSIORuleExists(Duplicate):"},{"line_number":17,"context_line":"    message \u003d _(\u0027QoS I/O Rule %(name)s is already exists.\u0027)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class DellPowerStoreQoSPolicyExists(Duplicate):"}],"source_content_type":"text/x-python","patch_set":10,"id":"12ad227c_c31b2039","line":17,"range":{"start_line":17,"start_character":39,"end_line":17,"end_character":41},"updated":"2024-08-28 22:30:49.000000000","message":"Don\u0027t need this \u0027is\u0027 here or at line 21.","commit_id":"934079c4f09e8d3687d57b7ad3aaf46c9859aef8"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"4720d4eeb4f6c4eaa2f048a9096fa622654b0508","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"class DellPowerStoreQoSIORuleExists(Duplicate):"},{"line_number":17,"context_line":"    message \u003d _(\u0027QoS I/O Rule %(name)s is already exists.\u0027)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class DellPowerStoreQoSPolicyExists(Duplicate):"}],"source_content_type":"text/x-python","patch_set":10,"id":"377833e5_33937259","line":17,"range":{"start_line":17,"start_character":39,"end_line":17,"end_character":41},"in_reply_to":"12ad227c_c31b2039","updated":"2024-08-29 05:05:34.000000000","message":"Done","commit_id":"934079c4f09e8d3687d57b7ad3aaf46c9859aef8"}],"doc/source/configuration/block-storage/drivers/dell-emc-powerstore-driver.rst":[{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"94cfd92e19b8bba11fe0f7bc8ce6117856193294","unresolved":true,"context_lines":[{"line_number":247,"context_line":"``max_iops``"},{"line_number":248,"context_line":"    Maximum I/O operations in either I/O operations per second (IOPS) or"},{"line_number":249,"context_line":"    I/O operations per second per GB.The specification of the type"},{"line_number":250,"context_line":"    attribute determines which measurement is used."},{"line_number":251,"context_line":"    If type is set to absolute,max_iops is specified in IOPS."},{"line_number":252,"context_line":"    If type is set to density, max_iops is specified in IOPS per GB."},{"line_number":253,"context_line":"    If both max_iops and max_bw are specified,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"0fbe616e_a64a152d","line":250,"updated":"2024-06-12 06:58:53.000000000","message":"Would replace measurement by metric","commit_id":"0f394b15801991a8fc3601637b08870b0cb165ba"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"b904b7f1e07b59a5f1f3f0dccd7cda5b7f05cffb","unresolved":false,"context_lines":[{"line_number":247,"context_line":"``max_iops``"},{"line_number":248,"context_line":"    Maximum I/O operations in either I/O operations per second (IOPS) or"},{"line_number":249,"context_line":"    I/O operations per second per GB.The specification of the type"},{"line_number":250,"context_line":"    attribute determines which measurement is used."},{"line_number":251,"context_line":"    If type is set to absolute,max_iops is specified in IOPS."},{"line_number":252,"context_line":"    If type is set to density, max_iops is specified in IOPS per GB."},{"line_number":253,"context_line":"    If both max_iops and max_bw are specified,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"b278df40_7dd8f84a","line":250,"in_reply_to":"0fbe616e_a64a152d","updated":"2024-06-12 08:09:38.000000000","message":"Done","commit_id":"0f394b15801991a8fc3601637b08870b0cb165ba"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"de8527bc918e6b28520197b535038f4b98baa0cd","unresolved":true,"context_lines":[{"line_number":248,"context_line":"    Maximum I/O operations in either I/O operations per second (IOPS) or"},{"line_number":249,"context_line":"    I/O operations per second per GB.The specification of the type"},{"line_number":250,"context_line":"    attribute determines which measurement is used."},{"line_number":251,"context_line":"    If type is set to absolute,max_iops is specified in IOPS."},{"line_number":252,"context_line":"    If type is set to density, max_iops is specified in IOPS per GB."},{"line_number":253,"context_line":"    If both max_iops and max_bw are specified,"},{"line_number":254,"context_line":"    the system will limit I/O if either value is exceeded."}],"source_content_type":"text/x-rst","patch_set":2,"id":"88dbd830_94413371","line":251,"range":{"start_line":251,"start_character":30,"end_line":251,"end_character":31},"updated":"2024-06-12 06:45:08.000000000","message":"nit: space can be added after comma","commit_id":"0f394b15801991a8fc3601637b08870b0cb165ba"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"b904b7f1e07b59a5f1f3f0dccd7cda5b7f05cffb","unresolved":false,"context_lines":[{"line_number":248,"context_line":"    Maximum I/O operations in either I/O operations per second (IOPS) or"},{"line_number":249,"context_line":"    I/O operations per second per GB.The specification of the type"},{"line_number":250,"context_line":"    attribute determines which measurement is used."},{"line_number":251,"context_line":"    If type is set to absolute,max_iops is specified in IOPS."},{"line_number":252,"context_line":"    If type is set to density, max_iops is specified in IOPS per GB."},{"line_number":253,"context_line":"    If both max_iops and max_bw are specified,"},{"line_number":254,"context_line":"    the system will limit I/O if either value is exceeded."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ca93718c_9afd41c3","line":251,"range":{"start_line":251,"start_character":30,"end_line":251,"end_character":31},"in_reply_to":"88dbd830_94413371","updated":"2024-06-12 08:09:38.000000000","message":"Done","commit_id":"0f394b15801991a8fc3601637b08870b0cb165ba"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"94cfd92e19b8bba11fe0f7bc8ce6117856193294","unresolved":true,"context_lines":[{"line_number":252,"context_line":"    If type is set to density, max_iops is specified in IOPS per GB."},{"line_number":253,"context_line":"    If both max_iops and max_bw are specified,"},{"line_number":254,"context_line":"    the system will limit I/O if either value is exceeded."},{"line_number":255,"context_line":"    The value must be within the range of 1 to 2147483646."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"``max_bw``"},{"line_number":258,"context_line":"    Maximum I/O bandwidth measured in either Kilobytes per second or Kilobytes"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ad35bf61_ef811ebc","line":255,"updated":"2024-06-12 06:58:53.000000000","message":"Default is unlimited?","commit_id":"0f394b15801991a8fc3601637b08870b0cb165ba"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"91eff0a8c7d1abeaf693c3b0cb139945bea9948f","unresolved":false,"context_lines":[{"line_number":252,"context_line":"    If type is set to density, max_iops is specified in IOPS per GB."},{"line_number":253,"context_line":"    If both max_iops and max_bw are specified,"},{"line_number":254,"context_line":"    the system will limit I/O if either value is exceeded."},{"line_number":255,"context_line":"    The value must be within the range of 1 to 2147483646."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"``max_bw``"},{"line_number":258,"context_line":"    Maximum I/O bandwidth measured in either Kilobytes per second or Kilobytes"}],"source_content_type":"text/x-rst","patch_set":2,"id":"615b7dd4_21979ea2","line":255,"in_reply_to":"ad35bf61_ef811ebc","updated":"2024-06-12 07:05:30.000000000","message":"Default is no value. If not provided it will set blank.","commit_id":"0f394b15801991a8fc3601637b08870b0cb165ba"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"de8527bc918e6b28520197b535038f4b98baa0cd","unresolved":true,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"``max_bw``"},{"line_number":258,"context_line":"    Maximum I/O bandwidth measured in either Kilobytes per second or Kilobytes"},{"line_number":259,"context_line":"    per second / per GB.The specification of the type attribute determines"},{"line_number":260,"context_line":"    which measurement is used. If type is set to absolute,max_bw is specified"},{"line_number":261,"context_line":"    in Kilobytes per second. If type is set to density max_bw is specified"},{"line_number":262,"context_line":"    in Kilobytes per second / per GB."}],"source_content_type":"text/x-rst","patch_set":2,"id":"f3aacbdd_008c124b","line":259,"range":{"start_line":259,"start_character":23,"end_line":259,"end_character":24},"updated":"2024-06-12 06:45:08.000000000","message":"nit: space required after full stop","commit_id":"0f394b15801991a8fc3601637b08870b0cb165ba"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"b904b7f1e07b59a5f1f3f0dccd7cda5b7f05cffb","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"``max_bw``"},{"line_number":258,"context_line":"    Maximum I/O bandwidth measured in either Kilobytes per second or Kilobytes"},{"line_number":259,"context_line":"    per second / per GB.The specification of the type attribute determines"},{"line_number":260,"context_line":"    which measurement is used. If type is set to absolute,max_bw is specified"},{"line_number":261,"context_line":"    in Kilobytes per second. If type is set to density max_bw is specified"},{"line_number":262,"context_line":"    in Kilobytes per second / per GB."}],"source_content_type":"text/x-rst","patch_set":2,"id":"82a6e1b0_9de60da2","line":259,"range":{"start_line":259,"start_character":23,"end_line":259,"end_character":24},"in_reply_to":"f3aacbdd_008c124b","updated":"2024-06-12 08:09:38.000000000","message":"Done","commit_id":"0f394b15801991a8fc3601637b08870b0cb165ba"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"94cfd92e19b8bba11fe0f7bc8ce6117856193294","unresolved":true,"context_lines":[{"line_number":257,"context_line":"``max_bw``"},{"line_number":258,"context_line":"    Maximum I/O bandwidth measured in either Kilobytes per second or Kilobytes"},{"line_number":259,"context_line":"    per second / per GB.The specification of the type attribute determines"},{"line_number":260,"context_line":"    which measurement is used. If type is set to absolute,max_bw is specified"},{"line_number":261,"context_line":"    in Kilobytes per second. If type is set to density max_bw is specified"},{"line_number":262,"context_line":"    in Kilobytes per second / per GB."},{"line_number":263,"context_line":"    If both max_iops and max_bw are specified,the system will"}],"source_content_type":"text/x-rst","patch_set":2,"id":"c105b777_6e57bff5","line":260,"updated":"2024-06-12 06:58:53.000000000","message":"Same","commit_id":"0f394b15801991a8fc3601637b08870b0cb165ba"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"91eff0a8c7d1abeaf693c3b0cb139945bea9948f","unresolved":false,"context_lines":[{"line_number":257,"context_line":"``max_bw``"},{"line_number":258,"context_line":"    Maximum I/O bandwidth measured in either Kilobytes per second or Kilobytes"},{"line_number":259,"context_line":"    per second / per GB.The specification of the type attribute determines"},{"line_number":260,"context_line":"    which measurement is used. If type is set to absolute,max_bw is specified"},{"line_number":261,"context_line":"    in Kilobytes per second. If type is set to density max_bw is specified"},{"line_number":262,"context_line":"    in Kilobytes per second / per GB."},{"line_number":263,"context_line":"    If both max_iops and max_bw are specified,the system will"}],"source_content_type":"text/x-rst","patch_set":2,"id":"b47f0e40_ee17df7a","line":260,"in_reply_to":"c105b777_6e57bff5","updated":"2024-06-12 07:05:30.000000000","message":"Default is no value. If not provided it will set blank.","commit_id":"0f394b15801991a8fc3601637b08870b0cb165ba"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"bc2950f996c86b34a358189015d54a56deba0241","unresolved":true,"context_lines":[{"line_number":246,"context_line":""},{"line_number":247,"context_line":"``max_iops``"},{"line_number":248,"context_line":"    Maximum I/O operations in either I/O operations per second (IOPS) or"},{"line_number":249,"context_line":"    I/O operations per second per GB.The specification of the type"},{"line_number":250,"context_line":"    attribute determines which metric is used."},{"line_number":251,"context_line":"    If type is set to absolute, max_iops is specified in IOPS."},{"line_number":252,"context_line":"    If type is set to density, max_iops is specified in IOPS per GB."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3ca39bae_6977ebad","line":249,"updated":"2024-07-07 11:38:59.000000000","message":"nit: need a space in \u0027GB.The\u0027","commit_id":"deaf467ace1b5b30abda25e982a3aa389853ea73"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"c63364c29f327b57ce135d62fed96ba4272649e5","unresolved":false,"context_lines":[{"line_number":246,"context_line":""},{"line_number":247,"context_line":"``max_iops``"},{"line_number":248,"context_line":"    Maximum I/O operations in either I/O operations per second (IOPS) or"},{"line_number":249,"context_line":"    I/O operations per second per GB.The specification of the type"},{"line_number":250,"context_line":"    attribute determines which metric is used."},{"line_number":251,"context_line":"    If type is set to absolute, max_iops is specified in IOPS."},{"line_number":252,"context_line":"    If type is set to density, max_iops is specified in IOPS per GB."}],"source_content_type":"text/x-rst","patch_set":3,"id":"ad2b8be4_c706356d","line":249,"in_reply_to":"3ca39bae_6977ebad","updated":"2024-07-08 09:54:20.000000000","message":"Done","commit_id":"deaf467ace1b5b30abda25e982a3aa389853ea73"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"bc2950f996c86b34a358189015d54a56deba0241","unresolved":true,"context_lines":[{"line_number":257,"context_line":"``max_bw``"},{"line_number":258,"context_line":"    Maximum I/O bandwidth measured in either Kilobytes per second or Kilobytes"},{"line_number":259,"context_line":"    per second / per GB. The specification of the type attribute determines"},{"line_number":260,"context_line":"    which measurement is used. If type is set to absolute,max_bw is specified"},{"line_number":261,"context_line":"    in Kilobytes per second. If type is set to density max_bw is specified"},{"line_number":262,"context_line":"    in Kilobytes per second / per GB."},{"line_number":263,"context_line":"    If both max_iops and max_bw are specified,the system will"}],"source_content_type":"text/x-rst","patch_set":3,"id":"95bd1e2b_55b9da68","line":260,"range":{"start_line":260,"start_character":49,"end_line":260,"end_character":64},"updated":"2024-07-07 11:38:59.000000000","message":"nit: need a space in \u0027absolute,max_bw\u0027","commit_id":"deaf467ace1b5b30abda25e982a3aa389853ea73"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"c63364c29f327b57ce135d62fed96ba4272649e5","unresolved":false,"context_lines":[{"line_number":257,"context_line":"``max_bw``"},{"line_number":258,"context_line":"    Maximum I/O bandwidth measured in either Kilobytes per second or Kilobytes"},{"line_number":259,"context_line":"    per second / per GB. The specification of the type attribute determines"},{"line_number":260,"context_line":"    which measurement is used. If type is set to absolute,max_bw is specified"},{"line_number":261,"context_line":"    in Kilobytes per second. If type is set to density max_bw is specified"},{"line_number":262,"context_line":"    in Kilobytes per second / per GB."},{"line_number":263,"context_line":"    If both max_iops and max_bw are specified,the system will"}],"source_content_type":"text/x-rst","patch_set":3,"id":"b38242e2_c1cae5c7","line":260,"range":{"start_line":260,"start_character":49,"end_line":260,"end_character":64},"in_reply_to":"95bd1e2b_55b9da68","updated":"2024-07-08 09:54:20.000000000","message":"Done.","commit_id":"deaf467ace1b5b30abda25e982a3aa389853ea73"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"bc2950f996c86b34a358189015d54a56deba0241","unresolved":true,"context_lines":[{"line_number":260,"context_line":"    which measurement is used. If type is set to absolute,max_bw is specified"},{"line_number":261,"context_line":"    in Kilobytes per second. If type is set to density max_bw is specified"},{"line_number":262,"context_line":"    in Kilobytes per second / per GB."},{"line_number":263,"context_line":"    If both max_iops and max_bw are specified,the system will"},{"line_number":264,"context_line":"    limit I/O if either value is exceeded."},{"line_number":265,"context_line":"    The value must be within the range of 2000 to 2147483646."},{"line_number":266,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"e1c2261e_3e095e65","line":263,"range":{"start_line":263,"start_character":36,"end_line":263,"end_character":49},"updated":"2024-07-07 11:38:59.000000000","message":"nit: need a space in \u0027specified,the\u0027","commit_id":"deaf467ace1b5b30abda25e982a3aa389853ea73"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"c63364c29f327b57ce135d62fed96ba4272649e5","unresolved":false,"context_lines":[{"line_number":260,"context_line":"    which measurement is used. If type is set to absolute,max_bw is specified"},{"line_number":261,"context_line":"    in Kilobytes per second. If type is set to density max_bw is specified"},{"line_number":262,"context_line":"    in Kilobytes per second / per GB."},{"line_number":263,"context_line":"    If both max_iops and max_bw are specified,the system will"},{"line_number":264,"context_line":"    limit I/O if either value is exceeded."},{"line_number":265,"context_line":"    The value must be within the range of 2000 to 2147483646."},{"line_number":266,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"73d796e6_03ad8002","line":263,"range":{"start_line":263,"start_character":36,"end_line":263,"end_character":49},"in_reply_to":"e1c2261e_3e095e65","updated":"2024-07-08 09:54:20.000000000","message":"Done.","commit_id":"deaf467ace1b5b30abda25e982a3aa389853ea73"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"bc2950f996c86b34a358189015d54a56deba0241","unresolved":true,"context_lines":[{"line_number":268,"context_line":"    Percentage indicating by how much the limit may be exceeded. If I/O"},{"line_number":269,"context_line":"    normally runs below the specified limit, then the volume or volume_group"},{"line_number":270,"context_line":"    will accumulate burst credits that can be used to exceed the limit for"},{"line_number":271,"context_line":"    a short period(a few seconds, but will not exceed the burst limit)."},{"line_number":272,"context_line":"    This burst percentage applies to both max_iops and max_bw and"},{"line_number":273,"context_line":"    is independent of the type setting."},{"line_number":274,"context_line":"    The value must be within the range of 0 to 100."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1097b55b_a2822029","line":271,"range":{"start_line":271,"start_character":12,"end_line":271,"end_character":19},"updated":"2024-07-07 11:38:59.000000000","message":"nit: need a space in \u0027period(\u0027","commit_id":"deaf467ace1b5b30abda25e982a3aa389853ea73"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"c63364c29f327b57ce135d62fed96ba4272649e5","unresolved":false,"context_lines":[{"line_number":268,"context_line":"    Percentage indicating by how much the limit may be exceeded. If I/O"},{"line_number":269,"context_line":"    normally runs below the specified limit, then the volume or volume_group"},{"line_number":270,"context_line":"    will accumulate burst credits that can be used to exceed the limit for"},{"line_number":271,"context_line":"    a short period(a few seconds, but will not exceed the burst limit)."},{"line_number":272,"context_line":"    This burst percentage applies to both max_iops and max_bw and"},{"line_number":273,"context_line":"    is independent of the type setting."},{"line_number":274,"context_line":"    The value must be within the range of 0 to 100."}],"source_content_type":"text/x-rst","patch_set":3,"id":"0ecad842_32dca3c9","line":271,"range":{"start_line":271,"start_character":12,"end_line":271,"end_character":19},"in_reply_to":"1097b55b_a2822029","updated":"2024-07-08 09:54:20.000000000","message":"Done.","commit_id":"deaf467ace1b5b30abda25e982a3aa389853ea73"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"bc2950f996c86b34a358189015d54a56deba0241","unresolved":true,"context_lines":[{"line_number":289,"context_line":"        This involves retyping the volume with the different QoS settings and migrating the volume to the new type."},{"line_number":290,"context_line":"    #. ``Modify Existing QoS Properties`` (Recommended):"},{"line_number":291,"context_line":"        This method entails changing the existing QoS properties and creating a new instance or image"},{"line_number":292,"context_line":"        volume to update the QoS policy in PowerStore.This will also update the QoS properties of existing attached volumes,"},{"line_number":293,"context_line":"        created with the same volume type."}],"source_content_type":"text/x-rst","patch_set":3,"id":"93526302_ee668c0e","line":292,"range":{"start_line":292,"start_character":43,"end_line":292,"end_character":58},"updated":"2024-07-07 11:38:59.000000000","message":"nit: need a space in \u0027PowerStore.This\u0027","commit_id":"deaf467ace1b5b30abda25e982a3aa389853ea73"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"c63364c29f327b57ce135d62fed96ba4272649e5","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        This involves retyping the volume with the different QoS settings and migrating the volume to the new type."},{"line_number":290,"context_line":"    #. ``Modify Existing QoS Properties`` (Recommended):"},{"line_number":291,"context_line":"        This method entails changing the existing QoS properties and creating a new instance or image"},{"line_number":292,"context_line":"        volume to update the QoS policy in PowerStore.This will also update the QoS properties of existing attached volumes,"},{"line_number":293,"context_line":"        created with the same volume type."}],"source_content_type":"text/x-rst","patch_set":3,"id":"739d9c8b_2f228c76","line":292,"range":{"start_line":292,"start_character":43,"end_line":292,"end_character":58},"in_reply_to":"93526302_ee668c0e","updated":"2024-07-08 09:54:20.000000000","message":"Done","commit_id":"deaf467ace1b5b30abda25e982a3aa389853ea73"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e116482c0892c181e4ddb9691ed731aa1caabae5","unresolved":true,"context_lines":[{"line_number":231,"context_line":"The PowerStore driver supports Quality of Service (QoS) by"},{"line_number":232,"context_line":"enabling the following capabilities:"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"``bandwidth_type``"},{"line_number":235,"context_line":"    The QoS bandwidth type. This type setting determines"},{"line_number":236,"context_line":"    how the max_iops and max_bw attributes are used."},{"line_number":237,"context_line":"    This has the following two values:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1c5de579_40c77bb6","line":234,"range":{"start_line":234,"start_character":2,"end_line":234,"end_character":16},"updated":"2024-08-28 22:30:49.000000000","message":"Shouldn\u0027t this be bandwidth_limit_type ?","commit_id":"934079c4f09e8d3687d57b7ad3aaf46c9859aef8"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"4720d4eeb4f6c4eaa2f048a9096fa622654b0508","unresolved":false,"context_lines":[{"line_number":231,"context_line":"The PowerStore driver supports Quality of Service (QoS) by"},{"line_number":232,"context_line":"enabling the following capabilities:"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"``bandwidth_type``"},{"line_number":235,"context_line":"    The QoS bandwidth type. This type setting determines"},{"line_number":236,"context_line":"    how the max_iops and max_bw attributes are used."},{"line_number":237,"context_line":"    This has the following two values:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"ec5b2a45_2aad35c8","line":234,"range":{"start_line":234,"start_character":2,"end_line":234,"end_character":16},"in_reply_to":"1c5de579_40c77bb6","updated":"2024-08-29 05:05:34.000000000","message":"Done","commit_id":"934079c4f09e8d3687d57b7ad3aaf46c9859aef8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e116482c0892c181e4ddb9691ed731aa1caabae5","unresolved":true,"context_lines":[{"line_number":242,"context_line":"    2. ``Density`` -  Limits specified are per GB,"},{"line_number":243,"context_line":"    e.g. I/O operations per second per GB."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    ``This property is mandatory when creating QoS``."},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"``max_iops``"},{"line_number":248,"context_line":"    Maximum I/O operations in either I/O operations per second (IOPS) or"}],"source_content_type":"text/x-rst","patch_set":10,"id":"75b481d8_7a961aff","line":245,"range":{"start_line":245,"start_character":4,"end_line":245,"end_character":52},"updated":"2024-08-28 22:30:49.000000000","message":"The double backticks make this render in monospace font.  Might be better to use ** for bold regular text, or possibly put it in a note (similar to line 229, but indented 4 spaces).","commit_id":"934079c4f09e8d3687d57b7ad3aaf46c9859aef8"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"4720d4eeb4f6c4eaa2f048a9096fa622654b0508","unresolved":false,"context_lines":[{"line_number":242,"context_line":"    2. ``Density`` -  Limits specified are per GB,"},{"line_number":243,"context_line":"    e.g. I/O operations per second per GB."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    ``This property is mandatory when creating QoS``."},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"``max_iops``"},{"line_number":248,"context_line":"    Maximum I/O operations in either I/O operations per second (IOPS) or"}],"source_content_type":"text/x-rst","patch_set":10,"id":"f1bf8d3a_6b716dd8","line":245,"range":{"start_line":245,"start_character":4,"end_line":245,"end_character":52},"in_reply_to":"75b481d8_7a961aff","updated":"2024-08-29 05:05:34.000000000","message":"Done","commit_id":"934079c4f09e8d3687d57b7ad3aaf46c9859aef8"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"6f7284b26527bd588f74b32bad6f5969d48c6d11","unresolved":true,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"``burst_percentage``"},{"line_number":268,"context_line":"    Percentage indicating by how much the limit may be exceeded. If I/O"},{"line_number":269,"context_line":"    normally runs below the specified limit, then the volume or volume_group"},{"line_number":270,"context_line":"    will accumulate burst credits that can be used to exceed the limit for"},{"line_number":271,"context_line":"    a short period (a few seconds, but will not exceed the burst limit)."},{"line_number":272,"context_line":"    This burst percentage applies to both max_iops and max_bw and"}],"source_content_type":"text/x-rst","patch_set":10,"id":"2ed8d3ba_984c6631","line":269,"range":{"start_line":269,"start_character":64,"end_line":269,"end_character":76},"updated":"2024-08-21 13:05:42.000000000","message":"I assume this is a PowerStore concept of multiple volumes, but Cinder QoS is a per volume setting, so this could be confusing.","commit_id":"934079c4f09e8d3687d57b7ad3aaf46c9859aef8"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"80ff5a915e45948f09e8be1debf82b988961c6e9","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"``burst_percentage``"},{"line_number":268,"context_line":"    Percentage indicating by how much the limit may be exceeded. If I/O"},{"line_number":269,"context_line":"    normally runs below the specified limit, then the volume or volume_group"},{"line_number":270,"context_line":"    will accumulate burst credits that can be used to exceed the limit for"},{"line_number":271,"context_line":"    a short period (a few seconds, but will not exceed the burst limit)."},{"line_number":272,"context_line":"    This burst percentage applies to both max_iops and max_bw and"}],"source_content_type":"text/x-rst","patch_set":10,"id":"c6dbfd5e_a623a634","line":269,"range":{"start_line":269,"start_character":64,"end_line":269,"end_character":76},"in_reply_to":"2ed8d3ba_984c6631","updated":"2024-08-21 13:13:18.000000000","message":"Hi Simon,\nI am not getting you. Cinder QoS concept is a per volume type not per a volume.","commit_id":"934079c4f09e8d3687d57b7ad3aaf46c9859aef8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d75f1e1ea209e215cdd5b934d871b9e718ce30f0","unresolved":true,"context_lines":[{"line_number":286,"context_line":".. note:: There are two approaches for updating QoS properties in PowerStore:"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    #. ``Retype the Volume``:"},{"line_number":289,"context_line":"        This involves retyping the volume with the different QoS settings and migrating the volume to the new type."},{"line_number":290,"context_line":"    #. ``Modify Existing QoS Properties`` (Recommended):"},{"line_number":291,"context_line":"        This method entails changing the existing QoS properties and creating a new instance or image"},{"line_number":292,"context_line":"        volume to update the QoS policy in PowerStore. This will also update the QoS properties of existing attached volumes,"}],"source_content_type":"text/x-rst","patch_set":11,"id":"9e4dbe89_cadbd989","line":289,"range":{"start_line":289,"start_character":8,"end_line":289,"end_character":115},"updated":"2024-08-29 18:48:03.000000000","message":"Have we checked that if we retype an attached volume from a non-QoS type to the QoS type, will it work? We should verify the workflow with\n1. available volume\n2. in-use (attached) volume\n\nTry to retype both volumes from non-QoS volume type to QoS volume type","commit_id":"3b4c9769018ab5df3d44356efb5fa9e41e0aef99"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1b5a1ea5e40cfeaf83b5381ef7d219046550af80","unresolved":false,"context_lines":[{"line_number":286,"context_line":".. note:: There are two approaches for updating QoS properties in PowerStore:"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    #. ``Retype the Volume``:"},{"line_number":289,"context_line":"        This involves retyping the volume with the different QoS settings and migrating the volume to the new type."},{"line_number":290,"context_line":"    #. ``Modify Existing QoS Properties`` (Recommended):"},{"line_number":291,"context_line":"        This method entails changing the existing QoS properties and creating a new instance or image"},{"line_number":292,"context_line":"        volume to update the QoS policy in PowerStore. This will also update the QoS properties of existing attached volumes,"}],"source_content_type":"text/x-rst","patch_set":11,"id":"8e5fa95e_d1cd1838","line":289,"range":{"start_line":289,"start_character":8,"end_line":289,"end_character":115},"in_reply_to":"54899e1b_3c25d550","updated":"2024-08-30 04:19:07.000000000","message":"Great!","commit_id":"3b4c9769018ab5df3d44356efb5fa9e41e0aef99"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"a66546119e97d21c08859f35c8eb9e908ce97a3d","unresolved":false,"context_lines":[{"line_number":286,"context_line":".. note:: There are two approaches for updating QoS properties in PowerStore:"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    #. ``Retype the Volume``:"},{"line_number":289,"context_line":"        This involves retyping the volume with the different QoS settings and migrating the volume to the new type."},{"line_number":290,"context_line":"    #. ``Modify Existing QoS Properties`` (Recommended):"},{"line_number":291,"context_line":"        This method entails changing the existing QoS properties and creating a new instance or image"},{"line_number":292,"context_line":"        volume to update the QoS policy in PowerStore. This will also update the QoS properties of existing attached volumes,"}],"source_content_type":"text/x-rst","patch_set":11,"id":"54899e1b_3c25d550","line":289,"range":{"start_line":289,"start_character":8,"end_line":289,"end_character":115},"in_reply_to":"9e4dbe89_cadbd989","updated":"2024-08-29 19:33:01.000000000","message":"Yes, I\u0027ve confirmed that in both cases, it will work as expected. It will create both the I/O rule and the QoS policy.","commit_id":"3b4c9769018ab5df3d44356efb5fa9e41e0aef99"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d75f1e1ea209e215cdd5b934d871b9e718ce30f0","unresolved":true,"context_lines":[{"line_number":288,"context_line":"    #. ``Retype the Volume``:"},{"line_number":289,"context_line":"        This involves retyping the volume with the different QoS settings and migrating the volume to the new type."},{"line_number":290,"context_line":"    #. ``Modify Existing QoS Properties`` (Recommended):"},{"line_number":291,"context_line":"        This method entails changing the existing QoS properties and creating a new instance or image"},{"line_number":292,"context_line":"        volume to update the QoS policy in PowerStore. This will also update the QoS properties of existing attached volumes,"},{"line_number":293,"context_line":"        created with the same volume type."}],"source_content_type":"text/x-rst","patch_set":11,"id":"d207e0d6_eedd5ff2","line":293,"range":{"start_line":291,"start_character":8,"end_line":293,"end_character":42},"updated":"2024-08-29 18:48:03.000000000","message":"IIUC, what we are saying here is that we can change the QoS property on the backend side and it will apply to both \u0027available\u0027 and \u0027in-use\u0027 volumes right?\nThe only concern i have with this is, if volume type doesn\u0027t have QoS associated and we apply QoS from backend side, will the inconsistency cause trouble somewhere in some operation workflow?","commit_id":"3b4c9769018ab5df3d44356efb5fa9e41e0aef99"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1b5a1ea5e40cfeaf83b5381ef7d219046550af80","unresolved":false,"context_lines":[{"line_number":288,"context_line":"    #. ``Retype the Volume``:"},{"line_number":289,"context_line":"        This involves retyping the volume with the different QoS settings and migrating the volume to the new type."},{"line_number":290,"context_line":"    #. ``Modify Existing QoS Properties`` (Recommended):"},{"line_number":291,"context_line":"        This method entails changing the existing QoS properties and creating a new instance or image"},{"line_number":292,"context_line":"        volume to update the QoS policy in PowerStore. This will also update the QoS properties of existing attached volumes,"},{"line_number":293,"context_line":"        created with the same volume type."}],"source_content_type":"text/x-rst","patch_set":11,"id":"16afbe21_7ab88c9c","line":293,"range":{"start_line":291,"start_character":8,"end_line":293,"end_character":42},"in_reply_to":"9b07e2a9_af481f2a","updated":"2024-08-30 04:19:07.000000000","message":"Case 2 is expected as we cannot modify a volume type if it has volumes using it.\nMy main concern was about the QoS being applied to the volume and Cinder not being aware about it, but if it\u0027s not an issue then sounds good to me.","commit_id":"3b4c9769018ab5df3d44356efb5fa9e41e0aef99"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"a66546119e97d21c08859f35c8eb9e908ce97a3d","unresolved":false,"context_lines":[{"line_number":288,"context_line":"    #. ``Retype the Volume``:"},{"line_number":289,"context_line":"        This involves retyping the volume with the different QoS settings and migrating the volume to the new type."},{"line_number":290,"context_line":"    #. ``Modify Existing QoS Properties`` (Recommended):"},{"line_number":291,"context_line":"        This method entails changing the existing QoS properties and creating a new instance or image"},{"line_number":292,"context_line":"        volume to update the QoS policy in PowerStore. This will also update the QoS properties of existing attached volumes,"},{"line_number":293,"context_line":"        created with the same volume type."}],"source_content_type":"text/x-rst","patch_set":11,"id":"9b07e2a9_af481f2a","line":293,"range":{"start_line":291,"start_character":8,"end_line":293,"end_character":42},"in_reply_to":"d207e0d6_eedd5ff2","updated":"2024-08-29 19:33:01.000000000","message":"1. If we change the QoS properties on the backend, the updates will only apply to in-use volumes when a user or customer creates a new instance or image volume with that volume type. The changes will not affect available volumes.\n2. If a volume type initially does not have QoS and QoS is applied later, it will only affect in-use volumes that are created after the QoS is applied.","commit_id":"3b4c9769018ab5df3d44356efb5fa9e41e0aef99"}],"releasenotes/notes/bp-dell-powerstore-qos-1532737fa1bb2664.yaml":[{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"bc2950f996c86b34a358189015d54a56deba0241","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerStore Driver: QoS (Quality of Service) support"},{"line_number":5,"context_line":"    Added QoS (Quality of Service) support for PowerStore 4.0"},{"line_number":6,"context_line":"    or later version."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d72e80c8_f524968f","line":4,"range":{"start_line":4,"start_character":28,"end_line":4,"end_character":60},"updated":"2024-07-07 11:38:59.000000000","message":"nit: please remove \u0027QoS (Quality of Service) support\u0027","commit_id":"deaf467ace1b5b30abda25e982a3aa389853ea73"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"c63364c29f327b57ce135d62fed96ba4272649e5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerStore Driver: QoS (Quality of Service) support"},{"line_number":5,"context_line":"    Added QoS (Quality of Service) support for PowerStore 4.0"},{"line_number":6,"context_line":"    or later version."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"2f9feb26_555ea7be","line":4,"range":{"start_line":4,"start_character":28,"end_line":4,"end_character":60},"in_reply_to":"d72e80c8_f524968f","updated":"2024-07-08 09:54:20.000000000","message":"Done","commit_id":"deaf467ace1b5b30abda25e982a3aa389853ea73"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"bc2950f996c86b34a358189015d54a56deba0241","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerStore Driver: QoS (Quality of Service) support"},{"line_number":5,"context_line":"    Added QoS (Quality of Service) support for PowerStore 4.0"},{"line_number":6,"context_line":"    or later version."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fc417039_269b6c96","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":21},"updated":"2024-07-07 11:38:59.000000000","message":"nit: version -\u003e versions ?","commit_id":"deaf467ace1b5b30abda25e982a3aa389853ea73"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"c63364c29f327b57ce135d62fed96ba4272649e5","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerStore Driver: QoS (Quality of Service) support"},{"line_number":5,"context_line":"    Added QoS (Quality of Service) support for PowerStore 4.0"},{"line_number":6,"context_line":"    or later version."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8dd22a97_213ffa47","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":21},"in_reply_to":"fc417039_269b6c96","updated":"2024-07-08 09:54:20.000000000","message":"Done","commit_id":"deaf467ace1b5b30abda25e982a3aa389853ea73"}]}