)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"46564dd69dfd67d0d95f8ddbfbca8250fa56c91c","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This bluprint is to add Cinder driver for ZTE Vstorage iSCSI arrays."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"DocImpact"},{"line_number":12,"context_line":"Implements: blueprint support zte vstorage driver"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I6aaf517df72903eb5cbd285a951a350fb987e242"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"455cce39_30dac0f7","line":12,"range":{"start_line":12,"start_character":22,"end_line":12,"end_character":49},"updated":"2024-07-01 09:11:05.000000000","message":"currently the link of blue-print is not working.\nIf this is changed to: support-zte-vstorage-driver\nthen the link would work","commit_id":"f1937684b42b4d8dd004e886cc7bd9129c7c3ad3"},{"author":{"_account_id":37070,"name":"陈希","display_name":"chen.xi14","email":"chen.xi14@zte.com.cn","username":"chen.xi14"},"change_message_id":"feeba11ad083f9fd94230a28d4d2fdbe19bc6a71","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This bluprint is to add Cinder driver for ZTE Vstorage iSCSI arrays."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"DocImpact"},{"line_number":12,"context_line":"Implements: blueprint support zte vstorage driver"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I6aaf517df72903eb5cbd285a951a350fb987e242"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9c437e7a_4e31d206","line":12,"range":{"start_line":12,"start_character":22,"end_line":12,"end_character":49},"in_reply_to":"455cce39_30dac0f7","updated":"2024-07-02 06:04:15.000000000","message":"Done","commit_id":"f1937684b42b4d8dd004e886cc7bd9129c7c3ad3"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"46564dd69dfd67d0d95f8ddbfbca8250fa56c91c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"42a24040_c5858272","updated":"2024-07-01 09:11:05.000000000","message":"1] A documentation file (.rst) should be added:\ndoc/source/configuration/block-storage/drivers/vstorage.rst\n\n2] A release note (.yaml) should be added:\nreleasenotes/notes/vstorage.yaml\n\n3] Below files would have to be updated:\ncinder/opts.py\ndoc/source/reference/support-matrix.ini\n\n4] Below links would help:\nhttps://docs.openstack.org/cinder/latest/contributor/new_driver_checklist.html\nhttps://wiki.openstack.org/wiki/Cinder/how-to-contribute-a-driver\n\n5] Minor comment inline","commit_id":"f1937684b42b4d8dd004e886cc7bd9129c7c3ad3"},{"author":{"_account_id":37070,"name":"陈希","display_name":"chen.xi14","email":"chen.xi14@zte.com.cn","username":"chen.xi14"},"change_message_id":"feeba11ad083f9fd94230a28d4d2fdbe19bc6a71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"70e1a264_b73f196d","updated":"2024-07-02 06:04:15.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"42cb8202e1c5fd7a0d62165081dd844c7f3a23f0"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"76bce67652296e5e4012c9f22fce02be30269fc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1253f3b4_b3640051","updated":"2024-07-05 04:52:40.000000000","message":"Forgot to vote","commit_id":"12cf31b35a18057089965518475d57d07215d51a"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"4f19a86c8e128e116e61d6b64d2bf0a881e55e57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"bdf7ebbd_a38fe8e7","updated":"2026-03-04 11:52:37.000000000","message":"Has https://review.opendev.org/c/openstack/cinder/+/969207 replaced this patch?","commit_id":"20b1b115e2d0484b2ac83fc58dce58572d6cfd53"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2065adebb4c0f90f726c57cd1ffdd23fccebabb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"7344d95d_90b0a894","updated":"2025-01-13 14:22:28.000000000","message":"I don\u0027t see any ZTE storage third party CI responding on this patch; please correct me if I\u0027m wrong.  The third party CI issue needs to be resolved because a new driver cannot be merged without it.  Because of that, core reviewers tend to de-prioritize reviews of new drivers without third party CI, or at least a notification that the CI setup is in progress, because there\u0027s no point reviewing code that isn\u0027t going to merge, given all the other open patches that can be reviewed.\n\nEric\u0027s comments on PS 11 about using common instead of custom options still apply.  You are not the first driver to encounter this; you may want to ask on the ML for suggestions of how other drivers have handled this (or poke around in git to see for yourself).","commit_id":"20b1b115e2d0484b2ac83fc58dce58572d6cfd53"}],"cinder/volume/drivers/zte/vstorage/vstorage.py":[{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"5d6e42061cd2cba825e2d655e8d8461c7fd3121b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2020 ZTE Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"346063da_d47fe7a8","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":32},"updated":"2024-07-05 04:52:10.000000000","message":"Should it be 2024?","commit_id":"12cf31b35a18057089965518475d57d07215d51a"},{"author":{"_account_id":37070,"name":"陈希","display_name":"chen.xi14","email":"chen.xi14@zte.com.cn","username":"chen.xi14"},"change_message_id":"65a35c5ef2e666f4698731f74ea3b61d9e33a314","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2020 ZTE Corporation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"f5ec2ec1_b6c466b5","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":32},"in_reply_to":"346063da_d47fe7a8","updated":"2024-08-01 02:25:33.000000000","message":"Done","commit_id":"12cf31b35a18057089965518475d57d07215d51a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"5d6e42061cd2cba825e2d655e8d8461c7fd3121b","unresolved":true,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"class VstorageDriver(driver.VolumeDriver):"},{"line_number":86,"context_line":"    VERSION \u003d \"1.1.0\""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":89,"context_line":"        super(VstorageDriver, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":8,"id":"110d7d74_34335033","line":86,"range":{"start_line":86,"start_character":4,"end_line":86,"end_character":11},"updated":"2024-07-05 04:52:10.000000000","message":"This driver needs a CI. Please refer to: https://wiki.openstack.org/wiki/Cinder/tested-3rdParty-drivers","commit_id":"12cf31b35a18057089965518475d57d07215d51a"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"5d6e42061cd2cba825e2d655e8d8461c7fd3121b","unresolved":true,"context_lines":[{"line_number":149,"context_line":"        }"},{"line_number":150,"context_line":"        self.RestClient \u003d b_client.RestClient(vstorage_mgmnt_info)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    # Started by AICoder, pid:b726bec9cfef4857bb96e7aeba9b795e"},{"line_number":153,"context_line":"    def get_volume_stats(self, refresh\u003dFalse):"},{"line_number":154,"context_line":"        \"\"\"Get volume status."},{"line_number":155,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"2cbe2b74_2eef57e9","line":152,"range":{"start_line":152,"start_character":4,"end_line":152,"end_character":11},"updated":"2024-07-05 04:52:10.000000000","message":"AICoder comments need to be removed.","commit_id":"12cf31b35a18057089965518475d57d07215d51a"},{"author":{"_account_id":37070,"name":"陈希","display_name":"chen.xi14","email":"chen.xi14@zte.com.cn","username":"chen.xi14"},"change_message_id":"65a35c5ef2e666f4698731f74ea3b61d9e33a314","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        }"},{"line_number":150,"context_line":"        self.RestClient \u003d b_client.RestClient(vstorage_mgmnt_info)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    # Started by AICoder, pid:b726bec9cfef4857bb96e7aeba9b795e"},{"line_number":153,"context_line":"    def get_volume_stats(self, refresh\u003dFalse):"},{"line_number":154,"context_line":"        \"\"\"Get volume status."},{"line_number":155,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"b5bf266e_1c13d4fe","line":152,"range":{"start_line":152,"start_character":4,"end_line":152,"end_character":11},"in_reply_to":"2cbe2b74_2eef57e9","updated":"2024-08-01 02:25:33.000000000","message":"Done","commit_id":"12cf31b35a18057089965518475d57d07215d51a"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b8bd47a3a3a40684283eb27c551fe85c75129e09","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    cfg.StrOpt(\u0027vstorage_user\u0027,"},{"line_number":45,"context_line":"               help\u003d\u0027vstorage_user\u0027),"},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027vstorage_pwd\u0027,"},{"line_number":47,"context_line":"               help\u003d\u0027vstorage_pwd\u0027),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027vstorage_gwnode_name\u0027,"},{"line_number":49,"context_line":"               help\u003d\u0027gwnode_name\u0027),"},{"line_number":50,"context_line":"    cfg.BoolOpt(\u0027vstorage_enable_delay_delete\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"f27207f4_28715045","line":47,"updated":"2024-08-27 15:03:13.000000000","message":"This needs secret\u003dTrue since it\u0027s a password.","commit_id":"12aeba57b7ddae4878529ef8f97de2b45ecdb49b"},{"author":{"_account_id":37070,"name":"陈希","display_name":"chen.xi14","email":"chen.xi14@zte.com.cn","username":"chen.xi14"},"change_message_id":"869d06d222e6c7e001e2d395c97e879eb3c2b4a5","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    cfg.StrOpt(\u0027vstorage_user\u0027,"},{"line_number":45,"context_line":"               help\u003d\u0027vstorage_user\u0027),"},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027vstorage_pwd\u0027,"},{"line_number":47,"context_line":"               help\u003d\u0027vstorage_pwd\u0027),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027vstorage_gwnode_name\u0027,"},{"line_number":49,"context_line":"               help\u003d\u0027gwnode_name\u0027),"},{"line_number":50,"context_line":"    cfg.BoolOpt(\u0027vstorage_enable_delay_delete\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"aaa2dedb_d9abf914","line":47,"in_reply_to":"f27207f4_28715045","updated":"2024-09-02 07:55:17.000000000","message":"Done","commit_id":"12aeba57b7ddae4878529ef8f97de2b45ecdb49b"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b8bd47a3a3a40684283eb27c551fe85c75129e09","unresolved":true,"context_lines":[{"line_number":50,"context_line":"    cfg.BoolOpt(\u0027vstorage_enable_delay_delete\u0027,"},{"line_number":51,"context_line":"                default\u003dFalse,"},{"line_number":52,"context_line":"                help\u003d\u0027enable delay delete volume\u0027),"},{"line_number":53,"context_line":"    cfg.BoolOpt(\u0027vstorage_driver_use_ssl\u0027,"},{"line_number":54,"context_line":"                default\u003dTrue,"},{"line_number":55,"context_line":"                help\u003d\u0027If True, use https for connection to backend storage,\u0027"},{"line_number":56,"context_line":"                     \u0027If False, use http for connection to backend storage.\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"e0055162_e8dfadb5","line":53,"updated":"2024-08-27 15:03:13.000000000","message":"Not needed, use existing driver_use_ssl option.","commit_id":"12aeba57b7ddae4878529ef8f97de2b45ecdb49b"},{"author":{"_account_id":37070,"name":"陈希","display_name":"chen.xi14","email":"chen.xi14@zte.com.cn","username":"chen.xi14"},"change_message_id":"869d06d222e6c7e001e2d395c97e879eb3c2b4a5","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    cfg.BoolOpt(\u0027vstorage_enable_delay_delete\u0027,"},{"line_number":51,"context_line":"                default\u003dFalse,"},{"line_number":52,"context_line":"                help\u003d\u0027enable delay delete volume\u0027),"},{"line_number":53,"context_line":"    cfg.BoolOpt(\u0027vstorage_driver_use_ssl\u0027,"},{"line_number":54,"context_line":"                default\u003dTrue,"},{"line_number":55,"context_line":"                help\u003d\u0027If True, use https for connection to backend storage,\u0027"},{"line_number":56,"context_line":"                     \u0027If False, use http for connection to backend storage.\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"51cd603a_9cc989dd","line":53,"in_reply_to":"e0055162_e8dfadb5","updated":"2024-09-02 07:55:17.000000000","message":"There should be no problem using like this. And it has already been commercialized. It is difficult to make changes","commit_id":"12aeba57b7ddae4878529ef8f97de2b45ecdb49b"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b8bd47a3a3a40684283eb27c551fe85c75129e09","unresolved":true,"context_lines":[{"line_number":62,"context_line":"                default\u003dFalse,"},{"line_number":63,"context_line":"                help\u003d\u0027If True, use two way authentication,\u0027"},{"line_number":64,"context_line":"                     \u0027If False, use one way authentication.\u0027),"},{"line_number":65,"context_line":"    cfg.StrOpt(\u0027vstorage_local_key_file_path\u0027,"},{"line_number":66,"context_line":"               default\u003dNone,"},{"line_number":67,"context_line":"               help\u003d\u0027local key file of SSL.\u0027),"},{"line_number":68,"context_line":"    cfg.StrOpt(\u0027vstorage_local_cert_file_path\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9464e0e7_46b3d036","line":65,"updated":"2024-08-27 15:03:13.000000000","message":"Not needed, use existing driver_ssl_cert_path.","commit_id":"12aeba57b7ddae4878529ef8f97de2b45ecdb49b"},{"author":{"_account_id":37070,"name":"陈希","display_name":"chen.xi14","email":"chen.xi14@zte.com.cn","username":"chen.xi14"},"change_message_id":"869d06d222e6c7e001e2d395c97e879eb3c2b4a5","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                default\u003dFalse,"},{"line_number":63,"context_line":"                help\u003d\u0027If True, use two way authentication,\u0027"},{"line_number":64,"context_line":"                     \u0027If False, use one way authentication.\u0027),"},{"line_number":65,"context_line":"    cfg.StrOpt(\u0027vstorage_local_key_file_path\u0027,"},{"line_number":66,"context_line":"               default\u003dNone,"},{"line_number":67,"context_line":"               help\u003d\u0027local key file of SSL.\u0027),"},{"line_number":68,"context_line":"    cfg.StrOpt(\u0027vstorage_local_cert_file_path\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"d631eb2b_6581a1fd","line":65,"in_reply_to":"9464e0e7_46b3d036","updated":"2024-09-02 07:55:17.000000000","message":"There should be no problem using like this. And it has already been commercialized. It is difficult to make changes","commit_id":"12aeba57b7ddae4878529ef8f97de2b45ecdb49b"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b8bd47a3a3a40684283eb27c551fe85c75129e09","unresolved":true,"context_lines":[{"line_number":318,"context_line":"            raise exception.CinderException(reason\u003dmsg)"},{"line_number":319,"context_line":"        for item in tgt_info:"},{"line_number":320,"context_line":"            target_iqns.append(item[\u0027iqn\u0027])"},{"line_number":321,"context_line":"            target_portals.append(\u0027%s:%s\u0027 % (item[\u0027ip\u0027], \u00273260\u0027))"},{"line_number":322,"context_line":"            target_luns.append(lun_id)"},{"line_number":323,"context_line":"        # Return iSCSI properties."},{"line_number":324,"context_line":"        properties \u003d {\u0027target_discovered\u0027: False,"}],"source_content_type":"text/x-python","patch_set":11,"id":"1d3de936_2e799a7e","line":321,"updated":"2024-08-27 15:03:13.000000000","message":"This will fail if using ipv6.","commit_id":"12aeba57b7ddae4878529ef8f97de2b45ecdb49b"},{"author":{"_account_id":37070,"name":"陈希","display_name":"chen.xi14","email":"chen.xi14@zte.com.cn","username":"chen.xi14"},"change_message_id":"869d06d222e6c7e001e2d395c97e879eb3c2b4a5","unresolved":false,"context_lines":[{"line_number":318,"context_line":"            raise exception.CinderException(reason\u003dmsg)"},{"line_number":319,"context_line":"        for item in tgt_info:"},{"line_number":320,"context_line":"            target_iqns.append(item[\u0027iqn\u0027])"},{"line_number":321,"context_line":"            target_portals.append(\u0027%s:%s\u0027 % (item[\u0027ip\u0027], \u00273260\u0027))"},{"line_number":322,"context_line":"            target_luns.append(lun_id)"},{"line_number":323,"context_line":"        # Return iSCSI properties."},{"line_number":324,"context_line":"        properties \u003d {\u0027target_discovered\u0027: False,"}],"source_content_type":"text/x-python","patch_set":11,"id":"d3ce0408_03dfc023","line":321,"in_reply_to":"1d3de936_2e799a7e","updated":"2024-09-02 07:55:17.000000000","message":"Done","commit_id":"12aeba57b7ddae4878529ef8f97de2b45ecdb49b"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8cb00f06cdd1a53680dcc49013852bd9e428a893","unresolved":true,"context_lines":[{"line_number":43,"context_line":"               help\u003d\u0027vstorage pool_name\u0027),"},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027vstorage_user\u0027,"},{"line_number":45,"context_line":"               help\u003d\u0027vstorage_user\u0027),"},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027vstorage_pwd\u0027, secret\u003dTrue,"},{"line_number":47,"context_line":"               help\u003d\u0027vstorage_pwd\u0027),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027vstorage_gwnode_name\u0027,"},{"line_number":49,"context_line":"               help\u003d\u0027gwnode_name\u0027),"}],"source_content_type":"text/x-python","patch_set":14,"id":"d53ddf3e_d12f9a51","line":46,"range":{"start_line":46,"start_character":16,"end_line":46,"end_character":28},"updated":"2026-03-02 19:26:56.000000000","message":"Would be better to name this \"vstorage_password\" for consistency with other drivers.","commit_id":"20b1b115e2d0484b2ac83fc58dce58572d6cfd53"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8cb00f06cdd1a53680dcc49013852bd9e428a893","unresolved":true,"context_lines":[{"line_number":49,"context_line":"               help\u003d\u0027gwnode_name\u0027),"},{"line_number":50,"context_line":"    cfg.BoolOpt(\u0027vstorage_enable_delay_delete\u0027,"},{"line_number":51,"context_line":"                default\u003dFalse,"},{"line_number":52,"context_line":"                help\u003d\u0027enable delay delete volume\u0027),"},{"line_number":53,"context_line":"    cfg.BoolOpt(\u0027vstorage_driver_use_ssl\u0027,"},{"line_number":54,"context_line":"                default\u003dTrue,"},{"line_number":55,"context_line":"                help\u003d\u0027If True, use https for connection to backend storage,\u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"bc785557_3e565caf","line":52,"updated":"2026-03-02 19:26:56.000000000","message":"What does this option do exactly?","commit_id":"20b1b115e2d0484b2ac83fc58dce58572d6cfd53"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8cb00f06cdd1a53680dcc49013852bd9e428a893","unresolved":true,"context_lines":[{"line_number":165,"context_line":"        if not self.token:"},{"line_number":166,"context_line":"            token \u003d self.RestClient.user_login()"},{"line_number":167,"context_line":"            if token:"},{"line_number":168,"context_line":"                LOG.info(_LI(\"Login success!\"))"},{"line_number":169,"context_line":"            else:"},{"line_number":170,"context_line":"                LOG.error(_LE(\"Login failed!\"))"},{"line_number":171,"context_line":"                raise exception.CinderException(\"Login failed!\")"}],"source_content_type":"text/x-python","patch_set":14,"id":"ebcc515f_a766c9ac","line":168,"range":{"start_line":168,"start_character":25,"end_line":168,"end_character":28},"updated":"2026-03-02 19:26:56.000000000","message":"_LI/_LE here is not needed, please remove.","commit_id":"20b1b115e2d0484b2ac83fc58dce58572d6cfd53"}],"cinder/volume/drivers/zte/vstorage/vstorage_client.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b8bd47a3a3a40684283eb27c551fe85c75129e09","unresolved":true,"context_lines":[{"line_number":21,"context_line":"from oslo_log import log as logging"},{"line_number":22,"context_line":"from oslo_utils import units"},{"line_number":23,"context_line":"import requests"},{"line_number":24,"context_line":"import six"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from cinder import context"},{"line_number":27,"context_line":"from cinder import exception"}],"source_content_type":"text/x-python","patch_set":11,"id":"b151cc00_85a03a8a","line":24,"updated":"2024-08-27 15:03:13.000000000","message":"remove","commit_id":"12aeba57b7ddae4878529ef8f97de2b45ecdb49b"},{"author":{"_account_id":37070,"name":"陈希","display_name":"chen.xi14","email":"chen.xi14@zte.com.cn","username":"chen.xi14"},"change_message_id":"869d06d222e6c7e001e2d395c97e879eb3c2b4a5","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from oslo_log import log as logging"},{"line_number":22,"context_line":"from oslo_utils import units"},{"line_number":23,"context_line":"import requests"},{"line_number":24,"context_line":"import six"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from cinder import context"},{"line_number":27,"context_line":"from cinder import exception"}],"source_content_type":"text/x-python","patch_set":11,"id":"c8e02277_2c1cc7c6","line":24,"in_reply_to":"b151cc00_85a03a8a","updated":"2024-09-02 07:55:17.000000000","message":"Done","commit_id":"12aeba57b7ddae4878529ef8f97de2b45ecdb49b"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b8bd47a3a3a40684283eb27c551fe85c75129e09","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    from cinder.i18n import _"},{"line_number":30,"context_line":"    from cinder.i18n import _LE"},{"line_number":31,"context_line":"    from cinder.i18n import _LI"},{"line_number":32,"context_line":"except Exception:"},{"line_number":33,"context_line":"    _LE \u003d _LI \u003d _"},{"line_number":34,"context_line":"from cinder import utils"},{"line_number":35,"context_line":"from cinder.volume.drivers.zte.vstorage import vstorage_pub"},{"line_number":36,"context_line":"from cinder.volume import qos_specs"}],"source_content_type":"text/x-python","patch_set":11,"id":"081ea9e1_5433a371","line":33,"range":{"start_line":32,"start_character":0,"end_line":33,"end_character":17},"updated":"2024-08-27 15:03:13.000000000","message":"try/except not needed, this is in-tree.","commit_id":"12aeba57b7ddae4878529ef8f97de2b45ecdb49b"},{"author":{"_account_id":37070,"name":"陈希","display_name":"chen.xi14","email":"chen.xi14@zte.com.cn","username":"chen.xi14"},"change_message_id":"869d06d222e6c7e001e2d395c97e879eb3c2b4a5","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    from cinder.i18n import _"},{"line_number":30,"context_line":"    from cinder.i18n import _LE"},{"line_number":31,"context_line":"    from cinder.i18n import _LI"},{"line_number":32,"context_line":"except Exception:"},{"line_number":33,"context_line":"    _LE \u003d _LI \u003d _"},{"line_number":34,"context_line":"from cinder import utils"},{"line_number":35,"context_line":"from cinder.volume.drivers.zte.vstorage import vstorage_pub"},{"line_number":36,"context_line":"from cinder.volume import qos_specs"}],"source_content_type":"text/x-python","patch_set":11,"id":"636cc8cd_acbc55ed","line":33,"range":{"start_line":32,"start_character":0,"end_line":33,"end_character":17},"in_reply_to":"081ea9e1_5433a371","updated":"2024-09-02 07:55:17.000000000","message":"We have also used this plugin in other environments. try/exceph is needed","commit_id":"12aeba57b7ddae4878529ef8f97de2b45ecdb49b"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b8bd47a3a3a40684283eb27c551fe85c75129e09","unresolved":true,"context_lines":[{"line_number":120,"context_line":"                res \u003d self._requests_request(request)"},{"line_number":121,"context_line":"            return res"},{"line_number":122,"context_line":"        except Exception as err:"},{"line_number":123,"context_line":"            exception_str \u003d six.text_type(err)"},{"line_number":124,"context_line":"            if \u0027401\u0027 in exception_str and \\"},{"line_number":125,"context_line":"                    \u0027api/v2/auth/tokens\u0027 not in request.url:"},{"line_number":126,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":11,"id":"eff601e6_2632110f","line":123,"range":{"start_line":123,"start_character":28,"end_line":123,"end_character":41},"updated":"2024-08-27 15:03:13.000000000","message":"No need for six, just use str().","commit_id":"12aeba57b7ddae4878529ef8f97de2b45ecdb49b"},{"author":{"_account_id":37070,"name":"陈希","display_name":"chen.xi14","email":"chen.xi14@zte.com.cn","username":"chen.xi14"},"change_message_id":"869d06d222e6c7e001e2d395c97e879eb3c2b4a5","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                res \u003d self._requests_request(request)"},{"line_number":121,"context_line":"            return res"},{"line_number":122,"context_line":"        except Exception as err:"},{"line_number":123,"context_line":"            exception_str \u003d six.text_type(err)"},{"line_number":124,"context_line":"            if \u0027401\u0027 in exception_str and \\"},{"line_number":125,"context_line":"                    \u0027api/v2/auth/tokens\u0027 not in request.url:"},{"line_number":126,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":11,"id":"a74c2c6a_bd3d8c8f","line":123,"range":{"start_line":123,"start_character":28,"end_line":123,"end_character":41},"in_reply_to":"eff601e6_2632110f","updated":"2024-09-02 07:55:17.000000000","message":"Done","commit_id":"12aeba57b7ddae4878529ef8f97de2b45ecdb49b"}]}