)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"8d378e5c0651ef12eafab41b077d156d7b8fc251","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"74eba383_2583fc6b","updated":"2024-12-18 14:38:34.000000000","message":"Core team please do a review once gets time","commit_id":"7f43ae364ee6f8328a2caf91e8a306ea8dd81e03"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"9bbb5699abe876b799c94ee550fd1c725c4d09d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"38419a66_902d462e","updated":"2025-01-22 14:05:38.000000000","message":"recheck","commit_id":"91e58f81c8d6e3a0814558762ba23a6bb44725b5"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"cb6d9a2f279878a517ff1499fc06e2c70366dc7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4c78e92f_7062e94c","updated":"2025-01-22 11:11:03.000000000","message":"recheck","commit_id":"91e58f81c8d6e3a0814558762ba23a6bb44725b5"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"1fe2cfe435e1bfc2ff3d970b44c2ba82515133f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"86144068_92c5c4b8","updated":"2025-01-22 08:31:12.000000000","message":"recheck","commit_id":"91e58f81c8d6e3a0814558762ba23a6bb44725b5"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"c99933c87702aac1a2c490ee2dd4c88c4521b84f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1e45ceb4_58ec19f2","updated":"2025-01-29 15:40:25.000000000","message":"Attached is the CI result into Launchpad: https://bugs.launchpad.net/os-brick/+bug/2095303","commit_id":"869ef3b905d704e523023535198613c22f3c59b5"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"d42ea850518bf4db1d926437938d3f4305a87e5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e454cd9b_2964644e","updated":"2025-01-29 15:42:30.000000000","message":"Since the PowerMax CI is currently down and will take some time to fix, I am attaching the local CI results to https://bugs.launchpad.net/os-brick/+bug/2095303 for your review of the patch.","commit_id":"869ef3b905d704e523023535198613c22f3c59b5"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"79f4c2621ca831f685c8440eba6839f1e68d45fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"16244028_e5c1ad3a","updated":"2025-01-29 15:15:45.000000000","message":"This is passing the Pure NVMe-TCP CI so looks like it is good","commit_id":"869ef3b905d704e523023535198613c22f3c59b5"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"f5d9be84e54921d441c0efbc1e6104d890e1531e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"417e1b9e_dba22fbe","updated":"2025-02-18 09:34:05.000000000","message":"run Pure Storage CI","commit_id":"869ef3b905d704e523023535198613c22f3c59b5"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"c88596a17bce7fe6db433ffd8a1245944afb59c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"20748874_6248a5eb","updated":"2025-03-08 16:08:10.000000000","message":"run-DellEMC PowerMax CI","commit_id":"869ef3b905d704e523023535198613c22f3c59b5"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"06fc373edc69b0549408e1a02ad0805ba8d273cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"33726f01_d3fb3c74","updated":"2025-03-08 16:16:58.000000000","message":"run-DellEMC PowerMax CI","commit_id":"869ef3b905d704e523023535198613c22f3c59b5"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"a52760e669edf6b95990b2bb01baf4be95e334af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a1bec7fa_717f9d57","updated":"2025-03-08 16:30:49.000000000","message":"run-DellEMC PowerMax CI","commit_id":"869ef3b905d704e523023535198613c22f3c59b5"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"6131d153e6d3f98d7b7f793e48cda235a198fe70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"cb32b7c5_1c1bd862","updated":"2025-03-08 16:46:41.000000000","message":"run-DellEMC PowerMax CI","commit_id":"869ef3b905d704e523023535198613c22f3c59b5"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"08a5734f615cf746d6be1e111ae12da20f8b0783","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2cc031a7_22c7fcb2","updated":"2025-03-08 17:25:30.000000000","message":"run-DellEMC PowerMax CI","commit_id":"36d854be8ceac3b10682e92db5b498dee86f4db2"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"773802bcb2c0fae91f7fb1f84c06e34ff757bc82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a324f9e1_7e12bd1c","updated":"2025-03-08 17:55:58.000000000","message":"run-DellEMC PowerMax CI","commit_id":"36d854be8ceac3b10682e92db5b498dee86f4db2"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"587d5df58f35e091fe576349e8e5ca17fc0ae9eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"34f7d73f_80f7f011","updated":"2025-07-24 08:50:07.000000000","message":"Hi @rosmaita.fossdev@gmail.com, @jobernar@redhat.com, @rajatdhasmana@gmail.com,\n\nThe Dell third-party CI is now back online. Could you please review this patch when you get a chance? It was created quite some time ago and would benefit from your feedback.\n\nThank you!","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"302affafa38f5058623f58d1dd44cb703390d7b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"80033068_6acc8ee6","updated":"2025-06-19 11:59:39.000000000","message":"recheck","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"1ccd338335de76b89503666fd998a32f5ccebf34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"de17f36c_e6cca271","updated":"2025-03-09 05:43:45.000000000","message":"recheck","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"8e015c1e77b2099ea7d51f2ed993bc18405aaae8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"286499ca_ae147721","updated":"2025-05-15 17:00:33.000000000","message":"run Pure Storage CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"1b4ab53edfb94f3bd32e9c7e03cef787fb813c02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2b5cd64f_c2f98a4c","updated":"2025-05-14 18:51:05.000000000","message":"run Pure Storage CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"0287ace9fcb970358b33b6b863b8f5d8ba3079dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"59dd7715_84ad7571","updated":"2025-05-14 18:39:58.000000000","message":"run Pure Storage CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"b164b422410fefd3fa89a13ad4b7470aba483dae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8e43a352_5fc2d4ec","updated":"2025-05-15 17:11:39.000000000","message":"run Pure Storage CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"211ef97a4b9c023a56e076ee494f77e09d82f48a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"955c320c_c9572d02","updated":"2025-05-15 16:20:39.000000000","message":"run Pure Storage CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"923f1ffee7ea25e805aea510d4c4fadaf530b5b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"99b791b3_51111e28","updated":"2025-05-15 15:38:26.000000000","message":"run Pure Storage CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"a5911f19f72d59d3b0e88c731fd2767de27c267c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ca9e83be_b8b68a23","updated":"2025-05-14 18:52:27.000000000","message":"run Pure Storage CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"aa79de63d23c9457d3f16c0a882a58db13e47f1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d147dcff_68f09aa8","updated":"2025-05-14 18:43:44.000000000","message":"run Pure Storage CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"494164835af4f7749b109a7991d91a36dbe6c90a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d49d8620_7fbe78c5","updated":"2025-05-15 16:08:44.000000000","message":"run Pure Storage CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"a2170675835f357c4b4c4975cb358146f21de831","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0100e0d1_b91edab1","updated":"2025-03-10 08:23:22.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"69e29ef279af477e9f19726a1a46f77469ae7169","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0819d3e8_ba22206e","updated":"2025-06-13 07:34:56.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"3180d06801a2dcd638a5c9012305fe8f13002e73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0d1b7218_0d2f7d74","updated":"2025-07-01 13:40:19.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"c9142bc0b47b966cd9659d84c4fb1a67ff5ae50b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"10176507_61e7af0e","updated":"2025-03-10 04:54:01.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"53e649c95914de9ca5dc504e60c1cd2a3e2ed0ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"11cebed5_a7744fca","updated":"2025-03-09 18:30:15.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"bae6f0724917eef6a7767c32ca5f475b4c10582a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"12d7b58b_53d1d548","updated":"2025-06-03 15:21:36.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"1e7c5ad440c224eb34f68dc80bad620816995e4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"18295e89_fa8ca7ac","updated":"2025-07-07 10:23:58.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"1083d8219960f539b882275f79bd21aaca0b8568","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1cb550e5_619077f1","updated":"2025-04-17 13:19:10.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"7387dced8ff41434d880f18d2424e5a5b44b8f42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1dd85685_a15db84b","updated":"2025-04-11 05:56:28.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"4025df847b1b83ca714581363b6014f05b119920","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2039e339_579184cf","updated":"2025-07-16 09:02:14.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"3a0336ba7ba827f86498b1303f79a5ff91504623","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"255a70e3_c602206e","updated":"2025-05-19 07:08:47.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"61823ee62eaa6cef9ccbc2e2e2ab9f3fceff6679","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"28e3bd97_dde166fd","updated":"2025-04-09 18:24:10.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"76255aa4a7ce709299fce17f1c706dc441f3f700","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"307547b9_5c63c23e","updated":"2025-06-25 04:36:15.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"8c5cbae200b67abcf814e6a3f1e8b12fbdc0bf6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"36cc50ce_822aa3cf","updated":"2025-04-17 16:15:12.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"b5ce5cf0f521505d7755284733bf15e7e9f477a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"399a30da_5d181d12","updated":"2025-06-30 11:53:44.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"10f283994f6eea37d21fc96a1f4294fa78885975","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3f23664b_a000fa7e","updated":"2025-03-10 05:10:01.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"e68aad9e842b90b29b2659002bc812b1c4ca61d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4e7fa0da_11317ca5","updated":"2025-05-19 14:23:22.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"06881a36537060bf258bf11e533995efc55d292d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4f26e54f_631d83a6","updated":"2025-04-16 07:12:26.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"455c07383805c407d5a9d68bc40eea454825e7fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"51532324_641bcf03","updated":"2025-04-17 10:03:49.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"c6245fa9d4b05b49281832d4015a0d4a87f53cd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5464108a_e54a8f3b","updated":"2025-03-09 18:37:19.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"e3d815fa9995233c6f7e42d9b05b05c86bdcf71c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6bcc81e3_8b92e66c","updated":"2025-04-16 07:17:11.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"b206bec7d66eee7582e63bee013aff2f39078b0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"710c3012_9f075eab","updated":"2025-04-16 16:06:33.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"9660ebf88a7600e2f5e9a3185e933f05ef9272b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"72e10f08_8c5fc188","updated":"2025-03-13 22:21:04.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"a222d7af3f5fe3b856556606768d1b1a2d838904","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"739004dc_8438dac0","updated":"2025-06-13 09:45:52.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"dc799390fc33af3383e3491a63c67f8d8aef3fbf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"73ff5621_4901c0ae","updated":"2025-03-09 18:16:34.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"b5f86270df548775f146a683dcd9f2a6807e5bdb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"841bb02c_5867453e","updated":"2025-04-02 06:44:28.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"f415f98c09bf5caa78a3d2c2c27364dcc491b51c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"90b378f2_805014a7","updated":"2025-04-10 10:29:07.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"609005dae39ec7c1930bd4b568c42c33c048feda","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"91e7600b_48e657da","updated":"2025-03-08 20:18:12.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"52309cc59c3680550e65c4e399682d6f5d8f8e79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9b8d2d2b_f5669ad5","updated":"2025-06-04 07:13:13.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"9ccf2c931e961c0921b54c9f7183a764f4d43500","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9e478c52_b07f42a8","updated":"2025-04-16 07:02:12.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"8f952cd91b10c11145b4a06465cb0e5822cd9b20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a9350d12_82203edf","updated":"2025-06-06 07:24:27.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"1b905725607130c194ec14d039157a822538b865","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b006c4ab_7a3c654a","updated":"2025-03-09 05:44:49.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"119eabf1e9f4a9935998d99793412a5b95d561fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b102d1db_6581e5ff","updated":"2025-06-17 09:05:42.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"4a19f4e7026e3b06255ec966ed44a1e0955ee3cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b5ba9949_e3890367","updated":"2025-03-28 08:23:23.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"ea4858c4cf7ff8bd941d88a1607bc54c11a54149","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"bbdec918_5487f409","updated":"2025-06-24 12:00:10.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"f94aab531cb476834390e537ff9067aa459c3785","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"bdea3c24_0adc2daa","updated":"2025-06-26 10:56:25.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"f3f2d1d128970776e5c8cebd8541be88ee415a0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c1946dda_63da35a9","updated":"2025-04-16 18:16:20.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"851807ed167adee527a36f8c59f70e49b1560459","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"cf623fe0_db56bbe2","updated":"2025-06-13 07:43:46.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"6d43eb5b0f83e7a4dfae24af746bf843b8e3b748","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d1f4b3b8_bc83dc85","updated":"2025-07-01 07:08:49.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"6ad4219209d7ebcf914fccc9dd55291dd29af821","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"df5099e4_459d5a3c","updated":"2025-03-28 08:16:25.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"43973ef1fc3acd7959b2966fdceb7279870d1ddb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e64d9e59_fcbc1f16","updated":"2025-04-15 12:46:34.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"86e58043b53e2d27327109de8e3f72f7c212cd2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e942f8ac_a26e4d62","updated":"2025-05-07 14:53:34.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"33125f19c0c6c1b4c05e747a8f380f3fc025a558","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ea238891_c1f0f552","updated":"2025-04-16 07:06:07.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"732c8211483c25ab41bd85e3924d4c09946721dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ef04cb67_5d85ed42","updated":"2025-07-01 08:51:05.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"63a09e230f0bc1e99db99f26b0af02fe58915f32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f186517d_aea30a6b","updated":"2025-04-07 15:08:28.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"8e192736ca660f76187f6ad01bd6739f900d7b3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"fc5a3dcc_e3e470e3","updated":"2025-05-07 12:32:18.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"fcc69268944715f9da70b3307b2fe445e8629eac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"fe4920bf_d9d24bd3","updated":"2025-06-28 12:17:20.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"dbcf5aa6073c237ade74619e58954b6c317d6357","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ffa65108_854c0166","updated":"2025-04-17 06:18:09.000000000","message":"run-DellEMC PowerMax CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"51f182c5b4fae5bbe3b087f0e0cb8cf0281f4dfd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1d911b0b_6c1eb84a","updated":"2025-04-08 18:05:33.000000000","message":"run-DellEMC PowerMax CI 1","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"7ecf1c03ef3a21b7bb67d7773bbc1d4324ab2ce5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2c6d9489_b5046290","updated":"2025-03-27 15:22:39.000000000","message":"run-DellEMC PowerMax CI 1","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"b7678828c07e4f657faf45261b06961845b5a2ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"56bb9a8f_c5e8245e","updated":"2025-04-08 11:57:05.000000000","message":"run-DellEMC PowerMax CI 1","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"c6a876e7cf557ee305602d02020c990fcfa660e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"94320632_4b6b2857","updated":"2025-03-27 12:04:18.000000000","message":"run-DellEMC PowerMax CI 1","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"0aadc43a69589fb2a11466a6d26e055ea983cdb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ab9f383f_41a9d24e","updated":"2025-03-19 21:22:56.000000000","message":"run-DellEMC PowerMax CI 1","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"baf2a3d162fdd073d75a1e71fc8b969717a90961","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"abc10c3d_3fcaca7e","updated":"2025-03-19 13:21:29.000000000","message":"run-DellEMC PowerMax CI 1","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"5f5050c81f3c7e72c861a05ef59c91fa5dfec7ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c94938df_0fdb9954","updated":"2025-04-08 08:30:55.000000000","message":"run-DellEMC PowerMax CI 1","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"5e814f0d02285e8b353fecb6e8d7dacce800a3e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"feaf3d08_3fc26f5d","updated":"2025-03-27 19:50:18.000000000","message":"run-DellEMC PowerMax CI 1","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"7ba456a4e6982a73a1be8fb5633f1e6540a3ba0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"da408cc5_9a0b1a9d","updated":"2025-04-15 17:24:59.000000000","message":"run-DellEMC PowerStore CI 1","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"f195db9ed9bf73b52995c59a0ce2f47b48f9ace3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1df06102_4b731e57","updated":"2025-06-04 12:52:03.000000000","message":"run-DellEMC Unity CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"67c258d89e91bd76f31d023b570bba4e7cf80977","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7d541913_74269404","updated":"2025-06-04 07:18:34.000000000","message":"run-DellEMC Unity CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"c7778d8104722ca7d4ffa4f378f56f1cb22e16d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"97c8393e_38cb12a7","updated":"2025-06-05 06:47:59.000000000","message":"run-DellEMC Unity CI","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0befbee10a06cc276f05bfd65aa7a4359c026a82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b47ab01c_7cd3829b","updated":"2025-08-22 02:39:53.000000000","message":"One strange log message noted inline, otherwise tests look good and i didn\u0027t see anything concerning in the code, and the powermax nvme CI is passing.  I will want to take another look, but I don\u0027t anticipate finding anything major.","commit_id":"acaa0b9f31f83f545b018c7daec2e75bfacd4d15"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"4ffb92f8547eda06788ae3e7586fc46e55988b0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"cdee4876_57ae207c","updated":"2025-07-24 15:43:29.000000000","message":"recheck tempest-slow-py3 got failed.","commit_id":"acaa0b9f31f83f545b018c7daec2e75bfacd4d15"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"3a8423c255997a6cbb6434ce21e096629e61d92f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"08f27c79_7d9e23aa","updated":"2025-08-20 17:29:01.000000000","message":"run-DellEMC PowerMax CI","commit_id":"acaa0b9f31f83f545b018c7daec2e75bfacd4d15"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"66e9ba52f12eee32671e2054c8aeba2db2ddf536","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"103d4791_b6bb0291","updated":"2025-07-25 08:07:11.000000000","message":"run-DellEMC PowerMax CI","commit_id":"acaa0b9f31f83f545b018c7daec2e75bfacd4d15"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"d31f4bf2c1896adbb715d38bc023960d2765dd9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1d4f5f48_45e1a34a","updated":"2025-08-09 05:07:17.000000000","message":"run-DellEMC PowerMax CI","commit_id":"acaa0b9f31f83f545b018c7daec2e75bfacd4d15"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"472d4382a3437e47bcd0b13fae777102571d8e5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"333cc19e_963d3e13","updated":"2025-07-24 17:11:22.000000000","message":"run-DellEMC PowerMax CI","commit_id":"acaa0b9f31f83f545b018c7daec2e75bfacd4d15"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"f273e0f351ed860f155b3c183b20de36f4d12612","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"345f144b_dae5cb16","updated":"2025-08-09 09:55:24.000000000","message":"run-DellEMC PowerMax CI","commit_id":"acaa0b9f31f83f545b018c7daec2e75bfacd4d15"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"75110b0742e3cd4b13ad91094383f4ebfd77745b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"4e2f535a_efe2c158","updated":"2025-08-20 16:47:45.000000000","message":"run-DellEMC PowerMax CI","commit_id":"acaa0b9f31f83f545b018c7daec2e75bfacd4d15"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"475b9cce865ddb31895a6e852e05d5e53a275e90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"562f913d_7c2f2caa","updated":"2025-07-26 19:50:51.000000000","message":"run-DellEMC PowerMax CI","commit_id":"acaa0b9f31f83f545b018c7daec2e75bfacd4d15"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"81c94a22c401b6ee43fd5bf16c82a51dc2892508","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"65edff0c_91122995","updated":"2025-08-21 05:11:34.000000000","message":"run-DellEMC PowerMax CI","commit_id":"acaa0b9f31f83f545b018c7daec2e75bfacd4d15"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"9b93346775c27f9697f16bac90faa8ac2a4d54b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"691e3afa_41ba15f0","updated":"2025-07-30 08:11:42.000000000","message":"run-DellEMC PowerMax CI","commit_id":"acaa0b9f31f83f545b018c7daec2e75bfacd4d15"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"4d0fb3358b3214ce6f8d05247e74fccadb7e1a83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"78634d8a_eea4e267","updated":"2025-07-25 04:36:29.000000000","message":"run-DellEMC PowerMax CI","commit_id":"acaa0b9f31f83f545b018c7daec2e75bfacd4d15"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"fc2176257c2b14e393cf1e54123597732f8ea906","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7ab43d55_03318956","updated":"2025-08-08 11:43:18.000000000","message":"run-DellEMC PowerMax CI","commit_id":"acaa0b9f31f83f545b018c7daec2e75bfacd4d15"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"7e62bf165993230c7de61ed7330e4ba1406d73b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8a5d4356_87ffeb95","updated":"2025-07-24 19:57:24.000000000","message":"run-DellEMC PowerMax CI","commit_id":"acaa0b9f31f83f545b018c7daec2e75bfacd4d15"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"27a508da0d88b6f2be87acee3f2c734d667176b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"950e0022_ad37fa36","updated":"2025-07-24 13:19:44.000000000","message":"run-DellEMC PowerMax CI","commit_id":"acaa0b9f31f83f545b018c7daec2e75bfacd4d15"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"65763944d087c60d4d7459f6377fb37dd011aa86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"958bcc38_f01404ca","updated":"2025-08-20 20:25:17.000000000","message":"run-DellEMC PowerMax CI","commit_id":"acaa0b9f31f83f545b018c7daec2e75bfacd4d15"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e5e6ddd56c1b2dc6f4fc303a228c345fbf334263","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"98a617b0_4f12ca29","updated":"2025-08-13 12:05:13.000000000","message":"run-DellEMC PowerMax CI","commit_id":"acaa0b9f31f83f545b018c7daec2e75bfacd4d15"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e73c87e11f7e32c8e928b2d5bc0cc8059d2a2bd4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9c20d468_fe915e8a","updated":"2025-08-20 16:21:02.000000000","message":"run-DellEMC PowerMax CI","commit_id":"acaa0b9f31f83f545b018c7daec2e75bfacd4d15"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"91587bfb963b0bfea2389d08a9385a8320cfc272","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"a1e9c583_dd29fdd1","updated":"2025-08-13 06:09:20.000000000","message":"run-DellEMC PowerMax CI","commit_id":"acaa0b9f31f83f545b018c7daec2e75bfacd4d15"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"a21031ff0f49f4d59a3acf2dae8f8a884ec05457","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"a6dbb15d_381dad77","updated":"2025-07-28 04:44:17.000000000","message":"run-DellEMC PowerMax CI","commit_id":"acaa0b9f31f83f545b018c7daec2e75bfacd4d15"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"a2149fd36fd9eb0299580e54c6c06175f624d9aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"aa2bd19f_de49fc0c","updated":"2025-08-20 12:59:53.000000000","message":"run-DellEMC PowerMax CI","commit_id":"acaa0b9f31f83f545b018c7daec2e75bfacd4d15"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"acf5197fd06e86e205251988cc5b63eca4575c39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b3277b0c_d29b49a5","updated":"2025-07-30 06:14:23.000000000","message":"run-DellEMC PowerMax CI","commit_id":"acaa0b9f31f83f545b018c7daec2e75bfacd4d15"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"b9014658dddeb5aa40302fb41e26286f01a65a1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b4025966_1d992c04","updated":"2025-08-08 11:02:45.000000000","message":"run-DellEMC PowerMax CI","commit_id":"acaa0b9f31f83f545b018c7daec2e75bfacd4d15"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"0edd288f18cbb0c8839c9bde6e0757d3d1078a88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b4e6449c_7f150871","updated":"2025-08-08 18:36:46.000000000","message":"run-DellEMC PowerMax CI","commit_id":"acaa0b9f31f83f545b018c7daec2e75bfacd4d15"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"cf08e07e1b32e4a86b76e395cc1a1732ddd1e241","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c72d6d2e_c1f4f4ea","updated":"2025-08-13 07:33:01.000000000","message":"run-DellEMC PowerMax CI","commit_id":"acaa0b9f31f83f545b018c7daec2e75bfacd4d15"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"ffccc8dfcf04a223ea041bf488bd355e3118e8c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f3dc6121_3c1dca83","updated":"2025-08-09 09:50:31.000000000","message":"run-DellEMC PowerMax CI","commit_id":"acaa0b9f31f83f545b018c7daec2e75bfacd4d15"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"087ae22f4c31afb29a64c82a4686f71d409b0b1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"31d46103_0dd7aefd","updated":"2025-08-23 11:56:56.000000000","message":"run-DellEMC PowerMax CI","commit_id":"fb18b6cd36cb772d4180801791eb9f931fd3edd7"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"a382d693535698b71f419ac61bb397afe03456a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"8f9233f1_02f6f65a","updated":"2025-08-22 11:31:39.000000000","message":"run-DellEMC PowerMax CI","commit_id":"fb18b6cd36cb772d4180801791eb9f931fd3edd7"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"f8c8d0b468b20b54e557e7a2914ee4f420bcc2a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"9e884df6_f86c79a9","updated":"2025-08-23 10:59:58.000000000","message":"run-DellEMC PowerMax CI","commit_id":"fb18b6cd36cb772d4180801791eb9f931fd3edd7"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"971d703c5a0ace86d8bd1893dcd08a576b0c0b80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"f44bf92b_4cc9eb97","updated":"2025-08-22 19:05:04.000000000","message":"run-DellEMC PowerMax CI","commit_id":"fb18b6cd36cb772d4180801791eb9f931fd3edd7"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"c228b82de5b6fb267b1908f3d4075b2321f045b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"f6dc0b9c_63916c83","updated":"2025-08-22 11:22:16.000000000","message":"run-DellEMC PowerMax CI","commit_id":"fb18b6cd36cb772d4180801791eb9f931fd3edd7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b923c02638382216f573057ee7de34428e7daaf4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"364b9d7d_529055ee","updated":"2025-08-26 14:37:10.000000000","message":"Revision LGTM; overall still looks good at a second look.","commit_id":"7a4f3fe14b4ec8cffc2c749bd83165a3c07d8daf"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"ba2aff58ad693a97fb44bc77514503262f57f79c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3e4acc9e_bbcf964e","updated":"2025-08-27 13:33:39.000000000","message":"Thanks @rosmaita.fossdev@gmail.com for the review.","commit_id":"7a4f3fe14b4ec8cffc2c749bd83165a3c07d8daf"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"3ee117b0165be47ef8c042155ff1fc2a3446db64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"8c0db772_9bb0e25d","updated":"2025-08-27 15:08:37.000000000","message":"The code and tests lgtm, but I want to point out the code seems to associate NVMe solely with NVMe-TCP. I guess that\u0027s OK, but consider how the code would need to be updated to support NVMe-FC. I don\u0027t know if that protocol is on the roadmap, but now would be the time to think about it.","commit_id":"7a4f3fe14b4ec8cffc2c749bd83165a3c07d8daf"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"ee336a195307728903da54d97383f8d0b35111d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"8608432d_558eb527","updated":"2025-08-26 08:50:00.000000000","message":"run-DellEMC PowerMax CI","commit_id":"7a4f3fe14b4ec8cffc2c749bd83165a3c07d8daf"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"b15b6e9e853d9eb23ae6a78ed7cbeefbb516c5f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"ffe8de6b_f9ea6763","in_reply_to":"8860496e_ee1cfc92","updated":"2025-08-27 15:19:02.000000000","message":"Hi Alan, thanks for the review! I’ll make the changes, or handle them in a follow-up patch if the core reviewers are fine with the current one.\n\nYes, simon said the same.","commit_id":"7a4f3fe14b4ec8cffc2c749bd83165a3c07d8daf"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f317b8507df03ec3136eea8e417326ce1ceaa3cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"8860496e_ee1cfc92","in_reply_to":"8c0db772_9bb0e25d","updated":"2025-08-27 15:11:18.000000000","message":"lol, I just spotted Simon\u0027s comment, which is virtually the same as mine. I don\u0027t think it\u0027s a matter for the core team to decide, rather it\u0027s something for the Dell team to decide depending on whether they will support NVMe-FC (or NVMe-ROCE) in the future.","commit_id":"7a4f3fe14b4ec8cffc2c749bd83165a3c07d8daf"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"10f89925189a9057e66b40a8b6dbbcd530cb7b24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"5cd76624_0c2360c4","updated":"2025-08-27 17:36:03.000000000","message":"Hi @abishop@redhat.com and @simon@purestorage.com\n\nChanged according to suggested also for the NVMe-FC also handled in case we develop in future.\n\n@rosmaita.fossdev@gmail.com please do a review","commit_id":"edceb5f6a5b1c84268a5a064a4b7585fc3f50213"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"af6933fbcd5e6c229d83c8b9fb78de94e364d628","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"34f6dc2c_09d62562","updated":"2025-08-27 17:36:24.000000000","message":"run-DellEMC PowerMax CI","commit_id":"edceb5f6a5b1c84268a5a064a4b7585fc3f50213"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"eb167566b9c3cf319fbdf018c5d86c476af4c595","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"29099140_69a02eaf","updated":"2025-08-27 18:07:32.000000000","message":"run-DellEMC PowerMax CI","commit_id":"16e6ecb0f31fed031aea42249510186dca9bf26e"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"f7c83db445c7b062ff76acb921735d5075174c92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"7025d76d_5318c736","updated":"2025-08-27 19:39:22.000000000","message":"@abishop@redhat.com I also though of same and updated also.","commit_id":"2e591d56b19bcb50b2335d61e7472a4da9d403fb"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"b955ee097c26859ba6cd3700afb1b25bb2770a93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"6c251968_012cd88b","updated":"2025-08-27 19:13:05.000000000","message":"@simon@purestorage.com update the changes. please do a review.","commit_id":"2e591d56b19bcb50b2335d61e7472a4da9d403fb"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d6534c6b57bf4061881ee01f1305bc6984946a04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"ae18fdbe_c0fa8cb6","updated":"2025-08-28 21:07:40.000000000","message":"Changes since my previous review look good, and the third-party CI and Zuul are green.","commit_id":"2e591d56b19bcb50b2335d61e7472a4da9d403fb"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"148dcd50ad2162e26d9914f4e7dbe7508ce49223","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"7372948b_6e70cd85","updated":"2025-08-27 19:15:56.000000000","message":"I don\u0027t want to hold up this review simply for the comments I have about the use of the lower() function when comparing protocol strings. Upvoting based on previous patches passing CI.","commit_id":"2e591d56b19bcb50b2335d61e7472a4da9d403fb"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"351eb8c84c5d351dbdb2356629892a242d30ee72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"f3737597_fa79caf2","updated":"2025-08-29 04:18:04.000000000","message":"Thanks @rosmaita.fossdev@gmail.com and @abishop@redhat.com for the review.","commit_id":"2e591d56b19bcb50b2335d61e7472a4da9d403fb"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"017b00f8913d02081c6b62aca94a51cbec8e092e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"168d0a62_000f11c1","updated":"2025-08-29 11:23:10.000000000","message":"Thanks! @rajatdhasmana@gmail.com for the review.\n\nWill create a follow up patch soon to address the review comments.","commit_id":"2e591d56b19bcb50b2335d61e7472a4da9d403fb"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6092e8d2f37bb400bfe1b4c3cba79906eae6ec9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"56dbf187_24b47b93","updated":"2025-08-29 10:58:56.000000000","message":"The nvme-tcp job is passing for dell powermax CI.\nI\u0027ve a few concerns inline which SHOULD be addressed as a followup since we are at deadline now hence moving ahead with the change.","commit_id":"2e591d56b19bcb50b2335d61e7472a4da9d403fb"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"89f4e04280c3e353647e5c81936373e6e01ca1b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"af1243a8_e690a1be","updated":"2025-08-28 04:46:01.000000000","message":"recheck","commit_id":"2e591d56b19bcb50b2335d61e7472a4da9d403fb"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"d152b02beb9bc3c50f5e55a664d3a3aeaa76d837","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"7e9c4e96_a9ff7596","updated":"2025-08-28 07:36:47.000000000","message":"recheck - cinder-tempest-plugin-lvm-lio-barbican failed","commit_id":"2e591d56b19bcb50b2335d61e7472a4da9d403fb"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"f4782f7044c88720bd20ce4ef0df5822642722e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"7c438176_29507cc3","updated":"2025-08-28 10:31:41.000000000","message":"recheck - grenade got failed.","commit_id":"2e591d56b19bcb50b2335d61e7472a4da9d403fb"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"9ce389102d43a124352ba461e90bc3d37ecf7683","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"5373877b_8b271fd8","updated":"2025-08-29 13:02:35.000000000","message":"recheck - openstack-tox-docs got failed in post_failure","commit_id":"2e591d56b19bcb50b2335d61e7472a4da9d403fb"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"329accd76375768857fe9f3b8432977adf900165","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"7cdaf8d7_6525be6d","updated":"2025-08-28 13:10:06.000000000","message":"recheck- grenade-skip-level-always got failed, random failure of job due to load on zuul.","commit_id":"2e591d56b19bcb50b2335d61e7472a4da9d403fb"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"7a86bc6cf45ce5f1971b2427dea056166a265b1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"1116b8d8_6030fcbf","updated":"2025-11-04 11:38:09.000000000","message":"run-DellEMC PowerMax CI","commit_id":"2e591d56b19bcb50b2335d61e7472a4da9d403fb"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"4e03a7ed99265cb470cf819059afd707a91b6ffb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"20f1f8ee_fd879571","updated":"2025-08-27 22:04:54.000000000","message":"run-DellEMC PowerMax CI","commit_id":"2e591d56b19bcb50b2335d61e7472a4da9d403fb"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"d317689c383902783fcc98fb18db28ba06e13ea7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"3e6f6946_f591f21f","updated":"2025-08-28 07:56:44.000000000","message":"run-DellEMC PowerMax CI","commit_id":"2e591d56b19bcb50b2335d61e7472a4da9d403fb"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"0e9d452dd39dac15afb9bee67676f7bd8d0bf8b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"69f47e53_a95097cf","updated":"2025-11-10 09:14:54.000000000","message":"run-DellEMC PowerMax CI","commit_id":"2e591d56b19bcb50b2335d61e7472a4da9d403fb"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"52fb7b5fb0148bafc7a6a10a911631240bcfc731","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"956746a0_c52ab26c","updated":"2025-08-28 04:53:57.000000000","message":"run-DellEMC PowerMax CI","commit_id":"2e591d56b19bcb50b2335d61e7472a4da9d403fb"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"82ce08a85569bdb1d8d2cf3e7ac5970a21dbdfc9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"b0001615_73186d30","updated":"2025-11-07 05:05:02.000000000","message":"run-DellEMC PowerMax CI","commit_id":"2e591d56b19bcb50b2335d61e7472a4da9d403fb"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"b58f48c6039ff7c959724373c7a48e1c9ee9f26d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"ba9539f9_85cfa927","updated":"2025-08-27 19:13:49.000000000","message":"run-DellEMC PowerMax CI","commit_id":"2e591d56b19bcb50b2335d61e7472a4da9d403fb"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"a0fa8c88fc5d389ac51e2f02c796c43799e6de1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"cd73a58c_b75e518e","updated":"2025-11-04 12:00:10.000000000","message":"run-DellEMC PowerMax CI","commit_id":"2e591d56b19bcb50b2335d61e7472a4da9d403fb"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"4fe3b1c42dd8c112eb6eafea0b19d9f61c8bed8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"df48e418_a12c2c16","updated":"2025-11-04 13:45:07.000000000","message":"run-DellEMC PowerMax CI","commit_id":"2e591d56b19bcb50b2335d61e7472a4da9d403fb"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"de0491342e8f6571f47bb012986da2bbaf4e99b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"34d4b14d_b172c0bf","in_reply_to":"7025d76d_5318c736","updated":"2025-08-27 19:51:19.000000000","message":"What I mean is you don\u0027t need to use lower() in the protocol string comparisons.","commit_id":"2e591d56b19bcb50b2335d61e7472a4da9d403fb"}],"cinder/volume/drivers/dell_emc/powermax/common.py":[{"author":{"_account_id":37888,"name":"Akshay Ranade","display_name":"Akshay Ranade","email":"akshay.ranade@ibm.com","username":"rakshay"},"change_message_id":"6a200def74785742ad142aa0353584a8f5706a46","unresolved":true,"context_lines":[{"line_number":7882,"context_line":"        :return: The NVMe Qualified Name (NQN) of the first discovered target,"},{"line_number":7883,"context_line":"          or None if no matching target is found."},{"line_number":7884,"context_line":"        \"\"\""},{"line_number":7885,"context_line":"        nvme_connector \u003d NVMeOFConnector(root_helper\u003dget_root_helper())"},{"line_number":7886,"context_line":"        for ip in ips:"},{"line_number":7887,"context_line":"            command \u003d [\u0027discover\u0027, \u0027-t\u0027, transport, \u0027-a\u0027,"},{"line_number":7888,"context_line":"                       ip[0], \u0027-s\u0027, 4420, \u0027-o\u0027, \u0027json\u0027]"}],"source_content_type":"text/x-python","patch_set":11,"id":"91d3df13_9e8d5ae8","line":7885,"updated":"2025-08-26 06:06:31.000000000","message":"is it possible to send connector as a parameter here instead of constructing for each call?","commit_id":"fb18b6cd36cb772d4180801791eb9f931fd3edd7"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"554a362d6d9ea3b9f16817f6c96deb38a5d0ef82","unresolved":false,"context_lines":[{"line_number":7882,"context_line":"        :return: The NVMe Qualified Name (NQN) of the first discovered target,"},{"line_number":7883,"context_line":"          or None if no matching target is found."},{"line_number":7884,"context_line":"        \"\"\""},{"line_number":7885,"context_line":"        nvme_connector \u003d NVMeOFConnector(root_helper\u003dget_root_helper())"},{"line_number":7886,"context_line":"        for ip in ips:"},{"line_number":7887,"context_line":"            command \u003d [\u0027discover\u0027, \u0027-t\u0027, transport, \u0027-a\u0027,"},{"line_number":7888,"context_line":"                       ip[0], \u0027-s\u0027, 4420, \u0027-o\u0027, \u0027json\u0027]"}],"source_content_type":"text/x-python","patch_set":11,"id":"892f5d28_c4db0bad","line":7885,"in_reply_to":"91d3df13_9e8d5ae8","updated":"2025-08-26 08:46:33.000000000","message":"Good point. Fixed.","commit_id":"fb18b6cd36cb772d4180801791eb9f931fd3edd7"},{"author":{"_account_id":37888,"name":"Akshay Ranade","display_name":"Akshay Ranade","email":"akshay.ranade@ibm.com","username":"rakshay"},"change_message_id":"6a200def74785742ad142aa0353584a8f5706a46","unresolved":true,"context_lines":[{"line_number":7885,"context_line":"        nvme_connector \u003d NVMeOFConnector(root_helper\u003dget_root_helper())"},{"line_number":7886,"context_line":"        for ip in ips:"},{"line_number":7887,"context_line":"            command \u003d [\u0027discover\u0027, \u0027-t\u0027, transport, \u0027-a\u0027,"},{"line_number":7888,"context_line":"                       ip[0], \u0027-s\u0027, 4420, \u0027-o\u0027, \u0027json\u0027]"},{"line_number":7889,"context_line":"            out, err \u003d nvme_connector.run_nvme_cli(command)"},{"line_number":7890,"context_line":"            if out is not None and len(out) \u003e 0:"},{"line_number":7891,"context_line":"                nvme_discover_result \u003d json.loads(out)"}],"source_content_type":"text/x-python","patch_set":11,"id":"8b44cc1f_4f7d2229","line":7888,"updated":"2025-08-26 06:06:31.000000000","message":"we are relying on default port here, can target be made to listen on custom one? we should define a constant for this.","commit_id":"fb18b6cd36cb772d4180801791eb9f931fd3edd7"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"554a362d6d9ea3b9f16817f6c96deb38a5d0ef82","unresolved":false,"context_lines":[{"line_number":7885,"context_line":"        nvme_connector \u003d NVMeOFConnector(root_helper\u003dget_root_helper())"},{"line_number":7886,"context_line":"        for ip in ips:"},{"line_number":7887,"context_line":"            command \u003d [\u0027discover\u0027, \u0027-t\u0027, transport, \u0027-a\u0027,"},{"line_number":7888,"context_line":"                       ip[0], \u0027-s\u0027, 4420, \u0027-o\u0027, \u0027json\u0027]"},{"line_number":7889,"context_line":"            out, err \u003d nvme_connector.run_nvme_cli(command)"},{"line_number":7890,"context_line":"            if out is not None and len(out) \u003e 0:"},{"line_number":7891,"context_line":"                nvme_discover_result \u003d json.loads(out)"}],"source_content_type":"text/x-python","patch_set":11,"id":"694c6c0f_482ae8bd","line":7888,"in_reply_to":"8b44cc1f_4f7d2229","updated":"2025-08-26 08:46:33.000000000","message":"yes only default port. created constant for the same.","commit_id":"fb18b6cd36cb772d4180801791eb9f931fd3edd7"},{"author":{"_account_id":37888,"name":"Akshay Ranade","display_name":"Akshay Ranade","email":"akshay.ranade@ibm.com","username":"rakshay"},"change_message_id":"6a200def74785742ad142aa0353584a8f5706a46","unresolved":true,"context_lines":[{"line_number":7886,"context_line":"        for ip in ips:"},{"line_number":7887,"context_line":"            command \u003d [\u0027discover\u0027, \u0027-t\u0027, transport, \u0027-a\u0027,"},{"line_number":7888,"context_line":"                       ip[0], \u0027-s\u0027, 4420, \u0027-o\u0027, \u0027json\u0027]"},{"line_number":7889,"context_line":"            out, err \u003d nvme_connector.run_nvme_cli(command)"},{"line_number":7890,"context_line":"            if out is not None and len(out) \u003e 0:"},{"line_number":7891,"context_line":"                nvme_discover_result \u003d json.loads(out)"},{"line_number":7892,"context_line":"                if \"records\" in nvme_discover_result:"}],"source_content_type":"text/x-python","patch_set":11,"id":"7c22f0a9_bda7b731","line":7889,"updated":"2025-08-26 06:06:31.000000000","message":"is \u0027out\u0027 guaranteed to be of Json type even if the cli fails?","commit_id":"fb18b6cd36cb772d4180801791eb9f931fd3edd7"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"eb9d8878517562257b54b48825a248908b83cd7c","unresolved":false,"context_lines":[{"line_number":7886,"context_line":"        for ip in ips:"},{"line_number":7887,"context_line":"            command \u003d [\u0027discover\u0027, \u0027-t\u0027, transport, \u0027-a\u0027,"},{"line_number":7888,"context_line":"                       ip[0], \u0027-s\u0027, 4420, \u0027-o\u0027, \u0027json\u0027]"},{"line_number":7889,"context_line":"            out, err \u003d nvme_connector.run_nvme_cli(command)"},{"line_number":7890,"context_line":"            if out is not None and len(out) \u003e 0:"},{"line_number":7891,"context_line":"                nvme_discover_result \u003d json.loads(out)"},{"line_number":7892,"context_line":"                if \"records\" in nvme_discover_result:"}],"source_content_type":"text/x-python","patch_set":11,"id":"d8255756_91123c60","line":7889,"in_reply_to":"457d0321_32d5bbbf","updated":"2025-08-26 10:33:36.000000000","message":"the out will be None in that case. not a string if any error is coming that will be in err.","commit_id":"fb18b6cd36cb772d4180801791eb9f931fd3edd7"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"554a362d6d9ea3b9f16817f6c96deb38a5d0ef82","unresolved":false,"context_lines":[{"line_number":7886,"context_line":"        for ip in ips:"},{"line_number":7887,"context_line":"            command \u003d [\u0027discover\u0027, \u0027-t\u0027, transport, \u0027-a\u0027,"},{"line_number":7888,"context_line":"                       ip[0], \u0027-s\u0027, 4420, \u0027-o\u0027, \u0027json\u0027]"},{"line_number":7889,"context_line":"            out, err \u003d nvme_connector.run_nvme_cli(command)"},{"line_number":7890,"context_line":"            if out is not None and len(out) \u003e 0:"},{"line_number":7891,"context_line":"                nvme_discover_result \u003d json.loads(out)"},{"line_number":7892,"context_line":"                if \"records\" in nvme_discover_result:"}],"source_content_type":"text/x-python","patch_set":11,"id":"c7842738_eca13492","line":7889,"in_reply_to":"7c22f0a9_bda7b731","updated":"2025-08-26 08:46:33.000000000","message":"if cli command fail, we will not get output or the operation will gets fail.","commit_id":"fb18b6cd36cb772d4180801791eb9f931fd3edd7"},{"author":{"_account_id":37888,"name":"Akshay Ranade","display_name":"Akshay Ranade","email":"akshay.ranade@ibm.com","username":"rakshay"},"change_message_id":"1f58f97cd64b1951d98a019a0b8bcd48a2aec557","unresolved":false,"context_lines":[{"line_number":7886,"context_line":"        for ip in ips:"},{"line_number":7887,"context_line":"            command \u003d [\u0027discover\u0027, \u0027-t\u0027, transport, \u0027-a\u0027,"},{"line_number":7888,"context_line":"                       ip[0], \u0027-s\u0027, 4420, \u0027-o\u0027, \u0027json\u0027]"},{"line_number":7889,"context_line":"            out, err \u003d nvme_connector.run_nvme_cli(command)"},{"line_number":7890,"context_line":"            if out is not None and len(out) \u003e 0:"},{"line_number":7891,"context_line":"                nvme_discover_result \u003d json.loads(out)"},{"line_number":7892,"context_line":"                if \"records\" in nvme_discover_result:"}],"source_content_type":"text/x-python","patch_set":11,"id":"457d0321_32d5bbbf","line":7889,"in_reply_to":"c7842738_eca13492","updated":"2025-08-26 09:38:09.000000000","message":"The \u0027out\u0027 can be of type string in case of error. Please make sure that we not trying to load such string as json, we will end up hitting jsondecoder exception.\nref: def  run_nvme_cli","commit_id":"fb18b6cd36cb772d4180801791eb9f931fd3edd7"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e3d0900d8691619428960b2d1f7eeded2ae786ba","unresolved":false,"context_lines":[{"line_number":7886,"context_line":"        for ip in ips:"},{"line_number":7887,"context_line":"            command \u003d [\u0027discover\u0027, \u0027-t\u0027, transport, \u0027-a\u0027,"},{"line_number":7888,"context_line":"                       ip[0], \u0027-s\u0027, 4420, \u0027-o\u0027, \u0027json\u0027]"},{"line_number":7889,"context_line":"            out, err \u003d nvme_connector.run_nvme_cli(command)"},{"line_number":7890,"context_line":"            if out is not None and len(out) \u003e 0:"},{"line_number":7891,"context_line":"                nvme_discover_result \u003d json.loads(out)"},{"line_number":7892,"context_line":"                if \"records\" in nvme_discover_result:"}],"source_content_type":"text/x-python","patch_set":11,"id":"22fe6acb_8588f856","line":7889,"in_reply_to":"d8255756_91123c60","updated":"2025-08-26 10:36:13.000000000","message":"If get any string in that case it should fail the operation, that should raise exception as well. so we can identify not getting proper response.","commit_id":"fb18b6cd36cb772d4180801791eb9f931fd3edd7"},{"author":{"_account_id":37888,"name":"Akshay Ranade","display_name":"Akshay Ranade","email":"akshay.ranade@ibm.com","username":"rakshay"},"change_message_id":"6a200def74785742ad142aa0353584a8f5706a46","unresolved":true,"context_lines":[{"line_number":7891,"context_line":"                nvme_discover_result \u003d json.loads(out)"},{"line_number":7892,"context_line":"                if \"records\" in nvme_discover_result:"},{"line_number":7893,"context_line":"                    for record in nvme_discover_result[\"records\"]:"},{"line_number":7894,"context_line":"                        if record[\"traddr\"] \u003d\u003d ip[0]:"},{"line_number":7895,"context_line":"                            return record[\"subnqn\"]"}],"source_content_type":"text/x-python","patch_set":11,"id":"d789338f_5f3920c6","line":7894,"updated":"2025-08-26 06:06:31.000000000","message":"from my experience of working with IPv6, comparing them as string directly is not a good idea. an IPv6 IP can be represented in two forms i.e. compressed or in full.\nplease make the necessary conversion before comparing.","commit_id":"fb18b6cd36cb772d4180801791eb9f931fd3edd7"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"554a362d6d9ea3b9f16817f6c96deb38a5d0ef82","unresolved":false,"context_lines":[{"line_number":7891,"context_line":"                nvme_discover_result \u003d json.loads(out)"},{"line_number":7892,"context_line":"                if \"records\" in nvme_discover_result:"},{"line_number":7893,"context_line":"                    for record in nvme_discover_result[\"records\"]:"},{"line_number":7894,"context_line":"                        if record[\"traddr\"] \u003d\u003d ip[0]:"},{"line_number":7895,"context_line":"                            return record[\"subnqn\"]"}],"source_content_type":"text/x-python","patch_set":11,"id":"680aac57_12a541fc","line":7894,"in_reply_to":"d789338f_5f3920c6","updated":"2025-08-26 08:46:33.000000000","message":"currently only considering ipv4.","commit_id":"fb18b6cd36cb772d4180801791eb9f931fd3edd7"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"148dcd50ad2162e26d9914f4e7dbe7508ce49223","unresolved":true,"context_lines":[{"line_number":1027,"context_line":"                        rep_extra_specs[utils.ARRAY], remote_port_group))"},{"line_number":1028,"context_line":"            device_info_dict[\u0027is_multipath\u0027] \u003d is_multipath"},{"line_number":1029,"context_line":""},{"line_number":1030,"context_line":"        if self.protocol.lower() \u003d\u003d \u0027nvme-tcp\u0027:"},{"line_number":1031,"context_line":"            ips \u003d self._find_nvme_target_ips("},{"line_number":1032,"context_line":"                extra_specs[utils.ARRAY],"},{"line_number":1033,"context_line":"                port_group_name)"}],"source_content_type":"text/x-python","patch_set":14,"id":"27d62d97_c27f8389","line":1030,"updated":"2025-08-27 19:15:56.000000000","message":"I realize L1020 uses the same lower() technique, but it doesn\u0027t see necessary and therefore I wouldn\u0027t continue the trend.\n\nAs far as I can tell, the \u0027protocol\u0027 field is hardcoded by the 3 driver classes, so you should be able to directly use utils.NVMEOF_TCP.","commit_id":"16e6ecb0f31fed031aea42249510186dca9bf26e"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"f7c83db445c7b062ff76acb921735d5075174c92","unresolved":false,"context_lines":[{"line_number":1027,"context_line":"                        rep_extra_specs[utils.ARRAY], remote_port_group))"},{"line_number":1028,"context_line":"            device_info_dict[\u0027is_multipath\u0027] \u003d is_multipath"},{"line_number":1029,"context_line":""},{"line_number":1030,"context_line":"        if self.protocol.lower() \u003d\u003d \u0027nvme-tcp\u0027:"},{"line_number":1031,"context_line":"            ips \u003d self._find_nvme_target_ips("},{"line_number":1032,"context_line":"                extra_specs[utils.ARRAY],"},{"line_number":1033,"context_line":"                port_group_name)"}],"source_content_type":"text/x-python","patch_set":14,"id":"d8d66c0e_aa2cd410","line":1030,"in_reply_to":"27d62d97_c27f8389","updated":"2025-08-27 19:39:22.000000000","message":"I think this is old one. I have already updated this.","commit_id":"16e6ecb0f31fed031aea42249510186dca9bf26e"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e09366eb2c6f66b34d791699c2e3a9ce40e37e69","unresolved":false,"context_lines":[{"line_number":1027,"context_line":"                        rep_extra_specs[utils.ARRAY], remote_port_group))"},{"line_number":1028,"context_line":"            device_info_dict[\u0027is_multipath\u0027] \u003d is_multipath"},{"line_number":1029,"context_line":""},{"line_number":1030,"context_line":"        if self.protocol.lower() \u003d\u003d \u0027nvme-tcp\u0027:"},{"line_number":1031,"context_line":"            ips \u003d self._find_nvme_target_ips("},{"line_number":1032,"context_line":"                extra_specs[utils.ARRAY],"},{"line_number":1033,"context_line":"                port_group_name)"}],"source_content_type":"text/x-python","patch_set":14,"id":"3282af57_6fc77f5c","line":1030,"in_reply_to":"a76a1bc1_5d7abe0c","updated":"2025-08-27 19:54:10.000000000","message":"Got it. thanks! Will update it if there is any review comments gets on this otherwise will take it in follow up patch.","commit_id":"16e6ecb0f31fed031aea42249510186dca9bf26e"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"de0491342e8f6571f47bb012986da2bbaf4e99b2","unresolved":true,"context_lines":[{"line_number":1027,"context_line":"                        rep_extra_specs[utils.ARRAY], remote_port_group))"},{"line_number":1028,"context_line":"            device_info_dict[\u0027is_multipath\u0027] \u003d is_multipath"},{"line_number":1029,"context_line":""},{"line_number":1030,"context_line":"        if self.protocol.lower() \u003d\u003d \u0027nvme-tcp\u0027:"},{"line_number":1031,"context_line":"            ips \u003d self._find_nvme_target_ips("},{"line_number":1032,"context_line":"                extra_specs[utils.ARRAY],"},{"line_number":1033,"context_line":"                port_group_name)"}],"source_content_type":"text/x-python","patch_set":14,"id":"a76a1bc1_5d7abe0c","line":1030,"in_reply_to":"d8d66c0e_aa2cd410","updated":"2025-08-27 19:51:19.000000000","message":"What I meant is you don\u0027t need to use lower() when comparing the protocol strings. Just do this:\n\n        if self.protocol \u003d\u003d cinder_constants.NVMEOF_TCP:","commit_id":"16e6ecb0f31fed031aea42249510186dca9bf26e"}],"cinder/volume/drivers/dell_emc/powermax/masking.py":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"148dcd50ad2162e26d9914f4e7dbe7508ce49223","unresolved":true,"context_lines":[{"line_number":1075,"context_line":"                         \"not supplied by OpenStack.\"))"},{"line_number":1076,"context_line":"                LOG.error(msg)"},{"line_number":1077,"context_line":"                raise exception.VolumeBackendAPIException(message\u003dmsg)"},{"line_number":1078,"context_line":"        elif self.protocol.lower() \u003d\u003d \"nvme-tcp\":"},{"line_number":1079,"context_line":"            if \u0027nqn\u0027 in connector and connector[\u0027nqn\u0027]:"},{"line_number":1080,"context_line":"                foundinitiatornames.append(connector[\u0027nqn\u0027]"},{"line_number":1081,"context_line":"                                           + \":\""}],"source_content_type":"text/x-python","patch_set":14,"id":"7718dbe1_0b5c301f","line":1078,"updated":"2025-08-27 19:15:56.000000000","message":"As I noted before, why not just use utils.NVMEOF_TCP and remove the lower()?","commit_id":"16e6ecb0f31fed031aea42249510186dca9bf26e"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"f7c83db445c7b062ff76acb921735d5075174c92","unresolved":false,"context_lines":[{"line_number":1075,"context_line":"                         \"not supplied by OpenStack.\"))"},{"line_number":1076,"context_line":"                LOG.error(msg)"},{"line_number":1077,"context_line":"                raise exception.VolumeBackendAPIException(message\u003dmsg)"},{"line_number":1078,"context_line":"        elif self.protocol.lower() \u003d\u003d \"nvme-tcp\":"},{"line_number":1079,"context_line":"            if \u0027nqn\u0027 in connector and connector[\u0027nqn\u0027]:"},{"line_number":1080,"context_line":"                foundinitiatornames.append(connector[\u0027nqn\u0027]"},{"line_number":1081,"context_line":"                                           + \":\""}],"source_content_type":"text/x-python","patch_set":14,"id":"59c4d495_e3b55233","line":1078,"in_reply_to":"7718dbe1_0b5c301f","updated":"2025-08-27 19:39:22.000000000","message":"I think this is old one. I have already updated this.","commit_id":"16e6ecb0f31fed031aea42249510186dca9bf26e"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"148dcd50ad2162e26d9914f4e7dbe7508ce49223","unresolved":true,"context_lines":[{"line_number":1112,"context_line":"        \"\"\""},{"line_number":1113,"context_line":"        ig_name \u003d None"},{"line_number":1114,"context_line":"        for initiator in initiator_names:"},{"line_number":1115,"context_line":"            if self.protocol.lower() \u003d\u003d \"nvme-tcp\":"},{"line_number":1116,"context_line":"                params \u003d {\u0027initiator_hba\u0027: initiator.rsplit(\":\", 1)}"},{"line_number":1117,"context_line":"            else:"},{"line_number":1118,"context_line":"                params \u003d {\u0027initiator_hba\u0027: initiator.lower()}"}],"source_content_type":"text/x-python","patch_set":14,"id":"e03e2adb_f2819109","line":1115,"updated":"2025-08-27 19:15:56.000000000","message":"utils.NVMEOF_TCP","commit_id":"16e6ecb0f31fed031aea42249510186dca9bf26e"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"f7c83db445c7b062ff76acb921735d5075174c92","unresolved":false,"context_lines":[{"line_number":1112,"context_line":"        \"\"\""},{"line_number":1113,"context_line":"        ig_name \u003d None"},{"line_number":1114,"context_line":"        for initiator in initiator_names:"},{"line_number":1115,"context_line":"            if self.protocol.lower() \u003d\u003d \"nvme-tcp\":"},{"line_number":1116,"context_line":"                params \u003d {\u0027initiator_hba\u0027: initiator.rsplit(\":\", 1)}"},{"line_number":1117,"context_line":"            else:"},{"line_number":1118,"context_line":"                params \u003d {\u0027initiator_hba\u0027: initiator.lower()}"}],"source_content_type":"text/x-python","patch_set":14,"id":"43d14b24_76375d25","line":1115,"in_reply_to":"e03e2adb_f2819109","updated":"2025-08-27 19:39:22.000000000","message":"I think this is old one. I have already updated this.","commit_id":"16e6ecb0f31fed031aea42249510186dca9bf26e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6092e8d2f37bb400bfe1b4c3cba79906eae6ec9c","unresolved":true,"context_lines":[{"line_number":1078,"context_line":"                raise exception.VolumeBackendAPIException(message\u003dmsg)"},{"line_number":1079,"context_line":"        elif self.protocol.lower() \u003d\u003d cinder_constants.NVMEOF_TCP.lower():"},{"line_number":1080,"context_line":"            if \u0027nqn\u0027 in connector and connector[\u0027nqn\u0027]:"},{"line_number":1081,"context_line":"                foundinitiatornames.append(connector[\u0027nqn\u0027]"},{"line_number":1082,"context_line":"                                           + \":\""},{"line_number":1083,"context_line":"                                           + str(connector."},{"line_number":1084,"context_line":"                                                 get(\u0027nvme_hostid\u0027))"},{"line_number":1085,"context_line":"                                           .replace(\"-\", \"\"))"},{"line_number":1086,"context_line":"                name \u003d \u0027nvme qualified name\u0027"},{"line_number":1087,"context_line":"            else:"},{"line_number":1088,"context_line":"                msg \u003d (_(\"NVMe/TCP is the protocol but nqn is \""}],"source_content_type":"text/x-python","patch_set":15,"id":"b6cb67c3_6b66d2dd","line":1085,"range":{"start_line":1081,"start_character":43,"end_line":1085,"end_character":60},"updated":"2025-08-29 10:58:56.000000000","message":"this part is really unreadable, and it looks like there is a potential bug here. If the nvme_hostid field is None then the appended value will be\n\n\"some-nqn:None\"\n\nThis should be written as,\n\n    \n    host_id \u003d connector.get(\u0027nvme_hostid\u0027))\n    if host_id:\n        host_id \u003d str(host_id).replace(\"-\", \"\")\n        initiator_name \u003d connector[\u0027nqn\u0027] + \":\" + host_id\n        foundinitiatornames.append(initiator_name)","commit_id":"2e591d56b19bcb50b2335d61e7472a4da9d403fb"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6092e8d2f37bb400bfe1b4c3cba79906eae6ec9c","unresolved":true,"context_lines":[{"line_number":1083,"context_line":"                                           + str(connector."},{"line_number":1084,"context_line":"                                                 get(\u0027nvme_hostid\u0027))"},{"line_number":1085,"context_line":"                                           .replace(\"-\", \"\"))"},{"line_number":1086,"context_line":"                name \u003d \u0027nvme qualified name\u0027"},{"line_number":1087,"context_line":"            else:"},{"line_number":1088,"context_line":"                msg \u003d (_(\"NVMe/TCP is the protocol but nqn is \""},{"line_number":1089,"context_line":"                         \"not supplied by OpenStack.\"))"}],"source_content_type":"text/x-python","patch_set":15,"id":"93149960_15d7814f","line":1086,"range":{"start_line":1086,"start_character":16,"end_line":1086,"end_character":44},"updated":"2025-08-29 10:58:56.000000000","message":"this looks like a leftover, remove this","commit_id":"2e591d56b19bcb50b2335d61e7472a4da9d403fb"}],"cinder/volume/drivers/dell_emc/powermax/nvme.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0befbee10a06cc276f05bfd65aa7a4359c026a82","unresolved":true,"context_lines":[{"line_number":109,"context_line":"            if (int(major_version) \u003c int(U4P_100_VERSION) or"},{"line_number":110,"context_line":"                (powermax_version.lower() !\u003d \"powermax_2500\" and"},{"line_number":111,"context_line":"                 powermax_version.lower() !\u003d \"powermax_8500\")):"},{"line_number":112,"context_line":"                LOG.info(\"This is called\")"},{"line_number":113,"context_line":"                msg \u003d ((\"Unisphere version %(running_version)s or \""},{"line_number":114,"context_line":"                        \"PowerMax version %(version)s \""},{"line_number":115,"context_line":"                       \"is not supported.\") %"}],"source_content_type":"text/x-python","patch_set":9,"id":"81b00b9c_11b12ee5","line":112,"range":{"start_line":112,"start_character":16,"end_line":112,"end_character":42},"updated":"2025-08-22 02:39:53.000000000","message":"Is this left over from development?","commit_id":"acaa0b9f31f83f545b018c7daec2e75bfacd4d15"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"94ec811e998570f2b1059f000863af2b017e32ef","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            if (int(major_version) \u003c int(U4P_100_VERSION) or"},{"line_number":110,"context_line":"                (powermax_version.lower() !\u003d \"powermax_2500\" and"},{"line_number":111,"context_line":"                 powermax_version.lower() !\u003d \"powermax_8500\")):"},{"line_number":112,"context_line":"                LOG.info(\"This is called\")"},{"line_number":113,"context_line":"                msg \u003d ((\"Unisphere version %(running_version)s or \""},{"line_number":114,"context_line":"                        \"PowerMax version %(version)s \""},{"line_number":115,"context_line":"                       \"is not supported.\") %"}],"source_content_type":"text/x-python","patch_set":9,"id":"18a517c6_713dc09a","line":112,"range":{"start_line":112,"start_character":16,"end_line":112,"end_character":42},"in_reply_to":"81b00b9c_11b12ee5","updated":"2025-08-22 08:07:39.000000000","message":"yes i missed it, fixed. thanks!","commit_id":"acaa0b9f31f83f545b018c7daec2e75bfacd4d15"},{"author":{"_account_id":37888,"name":"Akshay Ranade","display_name":"Akshay Ranade","email":"akshay.ranade@ibm.com","username":"rakshay"},"change_message_id":"6a200def74785742ad142aa0353584a8f5706a46","unresolved":true,"context_lines":[{"line_number":258,"context_line":"            for ip in ips:"},{"line_number":259,"context_line":"                target_portals.append((ip, 4420, \"tcp\"))"},{"line_number":260,"context_line":"        device_info[\u0027target_nqn\u0027] \u003d ("},{"line_number":261,"context_line":"            self.common.get_target_nqn(target_portals, \u0027tcp\u0027))"},{"line_number":262,"context_line":"        return {"},{"line_number":263,"context_line":"            \"driver_volume_type\": \"nvmeof\","},{"line_number":264,"context_line":"            \"data\": {"}],"source_content_type":"text/x-python","patch_set":11,"id":"972f8326_cfe22372","line":261,"updated":"2025-08-26 06:06:31.000000000","message":"why are we passing protocol again to the function when target_protocol already has it?","commit_id":"fb18b6cd36cb772d4180801791eb9f931fd3edd7"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"554a362d6d9ea3b9f16817f6c96deb38a5d0ef82","unresolved":false,"context_lines":[{"line_number":258,"context_line":"            for ip in ips:"},{"line_number":259,"context_line":"                target_portals.append((ip, 4420, \"tcp\"))"},{"line_number":260,"context_line":"        device_info[\u0027target_nqn\u0027] \u003d ("},{"line_number":261,"context_line":"            self.common.get_target_nqn(target_portals, \u0027tcp\u0027))"},{"line_number":262,"context_line":"        return {"},{"line_number":263,"context_line":"            \"driver_volume_type\": \"nvmeof\","},{"line_number":264,"context_line":"            \"data\": {"}],"source_content_type":"text/x-python","patch_set":11,"id":"c0cf9d26_3215a67c","line":261,"in_reply_to":"972f8326_cfe22372","updated":"2025-08-26 08:46:33.000000000","message":"good one. fixed.","commit_id":"fb18b6cd36cb772d4180801791eb9f931fd3edd7"}],"cinder/volume/drivers/dell_emc/powermax/nvme_tcp.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6092e8d2f37bb400bfe1b4c3cba79906eae6ec9c","unresolved":true,"context_lines":[{"line_number":87,"context_line":"        LOG.info(\"PowerMax version %(version)s\","},{"line_number":88,"context_line":"                 {\u0027version\u0027: powermax_version})"},{"line_number":89,"context_line":"        if not running_version or not major_version or not powermax_version:"},{"line_number":90,"context_line":"            LOG.warning(\"Unable to validate Unisphere instance \""},{"line_number":91,"context_line":"                        \"or PowerMax version.\")"},{"line_number":92,"context_line":"        else:"},{"line_number":93,"context_line":"            if (int(major_version) \u003c int(U4P_100_VERSION) or"},{"line_number":94,"context_line":"                (powermax_version.lower() !\u003d \"powermax_2500\" and"}],"source_content_type":"text/x-python","patch_set":15,"id":"d805fe27_1daec9ea","line":91,"range":{"start_line":90,"start_character":12,"end_line":91,"end_character":47},"updated":"2025-08-29 10:58:56.000000000","message":"If we are unable to validate the version, it can mean that we are running an unsupported version in which case also we should error out right? same as L#102","commit_id":"2e591d56b19bcb50b2335d61e7472a4da9d403fb"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6092e8d2f37bb400bfe1b4c3cba79906eae6ec9c","unresolved":true,"context_lines":[{"line_number":195,"context_line":"                (target_portals."},{"line_number":196,"context_line":"                 append((ip, utils.POWERMAX_NVME_TCP_PORT,"},{"line_number":197,"context_line":"                         utils.POWERMAX_NVME_TRANSPORT_PROTOCOL_TCP)))"},{"line_number":198,"context_line":"        device_info[\u0027target_nqn\u0027] \u003d ("},{"line_number":199,"context_line":"            self.common.get_target_nqn(target_portals,"},{"line_number":200,"context_line":"                                       self.nvme_connector))"},{"line_number":201,"context_line":"        return {"},{"line_number":202,"context_line":"            \"driver_volume_type\": \"nvmeof\","},{"line_number":203,"context_line":"            \"data\": {"}],"source_content_type":"text/x-python","patch_set":15,"id":"04afc7d8_469cfff2","line":200,"range":{"start_line":198,"start_character":8,"end_line":200,"end_character":60},"updated":"2025-08-29 10:58:56.000000000","message":"what\u0027s the purpose of putting this data inside the device_info dict when we just want to pass it as target_nqn value at L#205?","commit_id":"2e591d56b19bcb50b2335d61e7472a4da9d403fb"}],"cinder/volume/drivers/dell_emc/powermax/utils.py":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"c406ad4bd43cbe1c433afb073b833f170140c6cb","unresolved":true,"context_lines":[{"line_number":35,"context_line":"# SHARED CONSTANTS"},{"line_number":36,"context_line":"ISCSI \u003d \u0027iscsi\u0027"},{"line_number":37,"context_line":"FC \u003d \u0027fc\u0027"},{"line_number":38,"context_line":"NVME \u003d \u0027NVMe\u0027"},{"line_number":39,"context_line":"INTERVAL \u003d \u0027interval\u0027"},{"line_number":40,"context_line":"RETRIES \u003d \u0027retries\u0027"},{"line_number":41,"context_line":"VOLUME_ELEMENT_NAME_PREFIX \u003d \u0027OS-\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"d07d2a20_af61d3bb","line":38,"updated":"2025-08-27 13:56:38.000000000","message":"As this is only NVMe-TCP support and there is a potential for NVMe-FC in the future, then you should be more specific here.\nThat being said it would be better to reference the standard values provided in cinder.constants for all your protocols. Ref: https://github.com/openstack/cinder/blob/master/cinder/common/constants.py","commit_id":"7a4f3fe14b4ec8cffc2c749bd83165a3c07d8daf"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"10f89925189a9057e66b40a8b6dbbcd530cb7b24","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# SHARED CONSTANTS"},{"line_number":36,"context_line":"ISCSI \u003d \u0027iscsi\u0027"},{"line_number":37,"context_line":"FC \u003d \u0027fc\u0027"},{"line_number":38,"context_line":"NVME \u003d \u0027NVMe\u0027"},{"line_number":39,"context_line":"INTERVAL \u003d \u0027interval\u0027"},{"line_number":40,"context_line":"RETRIES \u003d \u0027retries\u0027"},{"line_number":41,"context_line":"VOLUME_ELEMENT_NAME_PREFIX \u003d \u0027OS-\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"ca38391b_288126bf","line":38,"in_reply_to":"31072519_68b6f756","updated":"2025-08-27 17:36:03.000000000","message":"changed according to it.","commit_id":"7a4f3fe14b4ec8cffc2c749bd83165a3c07d8daf"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"9cdde85abf2b0b971335ec715d13fb78969f4375","unresolved":true,"context_lines":[{"line_number":35,"context_line":"# SHARED CONSTANTS"},{"line_number":36,"context_line":"ISCSI \u003d \u0027iscsi\u0027"},{"line_number":37,"context_line":"FC \u003d \u0027fc\u0027"},{"line_number":38,"context_line":"NVME \u003d \u0027NVMe\u0027"},{"line_number":39,"context_line":"INTERVAL \u003d \u0027interval\u0027"},{"line_number":40,"context_line":"RETRIES \u003d \u0027retries\u0027"},{"line_number":41,"context_line":"VOLUME_ELEMENT_NAME_PREFIX \u003d \u0027OS-\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"31072519_68b6f756","line":38,"in_reply_to":"d07d2a20_af61d3bb","updated":"2025-08-27 14:40:40.000000000","message":"Thanks for the review, Simon! If a core reviewer can check it too, I’ll fix with that.","commit_id":"7a4f3fe14b4ec8cffc2c749bd83165a3c07d8daf"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"c0ffff5f54289c9fcca04e43f3cf0b00e38b92f8","unresolved":true,"context_lines":[{"line_number":35,"context_line":"# SHARED CONSTANTS"},{"line_number":36,"context_line":"ISCSI \u003d \u0027iscsi\u0027"},{"line_number":37,"context_line":"FC \u003d \u0027fc\u0027"},{"line_number":38,"context_line":"NVMEOF_TCP \u003d \u0027NVMe-TCP\u0027"},{"line_number":39,"context_line":"INTERVAL \u003d \u0027interval\u0027"},{"line_number":40,"context_line":"RETRIES \u003d \u0027retries\u0027"},{"line_number":41,"context_line":"VOLUME_ELEMENT_NAME_PREFIX \u003d \u0027OS-\u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"a186b1e8_a1db02b0","line":38,"updated":"2025-08-27 18:14:09.000000000","message":"I still think this should include the import from cinder common constants","commit_id":"16e6ecb0f31fed031aea42249510186dca9bf26e"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"b955ee097c26859ba6cd3700afb1b25bb2770a93","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# SHARED CONSTANTS"},{"line_number":36,"context_line":"ISCSI \u003d \u0027iscsi\u0027"},{"line_number":37,"context_line":"FC \u003d \u0027fc\u0027"},{"line_number":38,"context_line":"NVMEOF_TCP \u003d \u0027NVMe-TCP\u0027"},{"line_number":39,"context_line":"INTERVAL \u003d \u0027interval\u0027"},{"line_number":40,"context_line":"RETRIES \u003d \u0027retries\u0027"},{"line_number":41,"context_line":"VOLUME_ELEMENT_NAME_PREFIX \u003d \u0027OS-\u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"32358fdb_32ab1c94","line":38,"in_reply_to":"a186b1e8_a1db02b0","updated":"2025-08-27 19:13:05.000000000","message":"Done. Changed it.","commit_id":"16e6ecb0f31fed031aea42249510186dca9bf26e"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"c0ffff5f54289c9fcca04e43f3cf0b00e38b92f8","unresolved":true,"context_lines":[{"line_number":299,"context_line":"        \"\"\"Get short protocol type."},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        :param protocol: iscsi or fc or nvme"},{"line_number":302,"context_line":"        :returns: string -- \u0027I\u0027 for iscsi or \u0027F\u0027 for fc \u0027N\u0027 for nvme/tcp"},{"line_number":303,"context_line":"        \"\"\""},{"line_number":304,"context_line":"        if protocol.lower() \u003d\u003d ISCSI.lower():"},{"line_number":305,"context_line":"            return \u0027I\u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"24514286_d2c881f7","line":302,"updated":"2025-08-27 18:14:09.000000000","message":"nit: This should now say returns \u0027NT\u0027","commit_id":"16e6ecb0f31fed031aea42249510186dca9bf26e"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"b955ee097c26859ba6cd3700afb1b25bb2770a93","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        \"\"\"Get short protocol type."},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        :param protocol: iscsi or fc or nvme"},{"line_number":302,"context_line":"        :returns: string -- \u0027I\u0027 for iscsi or \u0027F\u0027 for fc \u0027N\u0027 for nvme/tcp"},{"line_number":303,"context_line":"        \"\"\""},{"line_number":304,"context_line":"        if protocol.lower() \u003d\u003d ISCSI.lower():"},{"line_number":305,"context_line":"            return \u0027I\u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"c5a7a387_2787106b","line":302,"in_reply_to":"24514286_d2c881f7","updated":"2025-08-27 19:13:05.000000000","message":"Done","commit_id":"16e6ecb0f31fed031aea42249510186dca9bf26e"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"148dcd50ad2162e26d9914f4e7dbe7508ce49223","unresolved":true,"context_lines":[{"line_number":305,"context_line":"            return \u0027I\u0027"},{"line_number":306,"context_line":"        elif protocol.lower() \u003d\u003d FC.lower():"},{"line_number":307,"context_line":"            return \u0027F\u0027"},{"line_number":308,"context_line":"        elif protocol.lower() \u003d\u003d NVMEOF_TCP.lower():"},{"line_number":309,"context_line":"            return \u0027NT\u0027"},{"line_number":310,"context_line":"        else:"},{"line_number":311,"context_line":"            return protocol"}],"source_content_type":"text/x-python","patch_set":14,"id":"efb57320_1761056d","line":308,"updated":"2025-08-27 19:15:56.000000000","message":"I feel that all of these lower() should be eliminated.","commit_id":"16e6ecb0f31fed031aea42249510186dca9bf26e"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"f7c83db445c7b062ff76acb921735d5075174c92","unresolved":false,"context_lines":[{"line_number":305,"context_line":"            return \u0027I\u0027"},{"line_number":306,"context_line":"        elif protocol.lower() \u003d\u003d FC.lower():"},{"line_number":307,"context_line":"            return \u0027F\u0027"},{"line_number":308,"context_line":"        elif protocol.lower() \u003d\u003d NVMEOF_TCP.lower():"},{"line_number":309,"context_line":"            return \u0027NT\u0027"},{"line_number":310,"context_line":"        else:"},{"line_number":311,"context_line":"            return protocol"}],"source_content_type":"text/x-python","patch_set":14,"id":"1cd7f162_49f94144","line":308,"in_reply_to":"efb57320_1761056d","updated":"2025-08-27 19:39:22.000000000","message":"I think this is old one. I have already updated this.","commit_id":"16e6ecb0f31fed031aea42249510186dca9bf26e"}],"doc/source/configuration/block-storage/drivers/dell-emc-powermax-driver.rst":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"d2b7efb02230d617ffeec052b3f935fafcb2239d","unresolved":true,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":".. note::"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    The powermax NVME-TCP supports for unisphere 10.x and later version."},{"line_number":137,"context_line":"    Additionally, the installation of the nvme-cli utility is required."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"15053125_a592d109","line":136,"range":{"start_line":136,"start_character":8,"end_line":136,"end_character":17},"updated":"2025-07-23 14:02:16.000000000","message":"Nit: Correct capitalization","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"0c8e1c13f8b50cf94760e82c57963fa6fcd06e83","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":".. note::"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    The powermax NVME-TCP supports for unisphere 10.x and later version."},{"line_number":137,"context_line":"    Additionally, the installation of the nvme-cli utility is required."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"7487ed9f_11e3458e","line":136,"range":{"start_line":136,"start_character":8,"end_line":136,"end_character":17},"in_reply_to":"15053125_a592d109","updated":"2025-07-24 13:20:01.000000000","message":"Done","commit_id":"61d31e4bde55ca7b8063ddb444bdaf4908a28ba6"}]}