)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"ab38719f224d18268bf8a5b60f2ce9dc00cc3477","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     vdhakad \u003cvrinda.dhakad@ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-08-19 13:20:03 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[SVf] Adding support for temporary volumegroup"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"[Storage Virtualize family] As part of Flashcopy 2.0 implementation,"},{"line_number":10,"context_line":"added support to create, update and delete temporary volumegroup to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f584ece6_10307e03","line":7,"updated":"2024-08-21 06:12:04.000000000","message":"The commit message should start with the vendor driver\ne.g IBM SVF Driver: ... The commit message.","commit_id":"5ce93b63a5ce06db7be5ae62d49a5f158711e7ce"},{"author":{"_account_id":36800,"name":"Vrinda Dhakad","display_name":"vdhakad","email":"vrinda.dhakad@ibm.com","username":"vdhakad"},"change_message_id":"2bccd66da15e946191deab33e23ce6600e89a41c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     vdhakad \u003cvrinda.dhakad@ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-08-19 13:20:03 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[SVf] Adding support for temporary volumegroup"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"[Storage Virtualize family] As part of Flashcopy 2.0 implementation,"},{"line_number":10,"context_line":"added support to create, update and delete temporary volumegroup to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fd75967_e60683a5","line":7,"in_reply_to":"f584ece6_10307e03","updated":"2025-01-02 06:58:44.000000000","message":"Done","commit_id":"5ce93b63a5ce06db7be5ae62d49a5f158711e7ce"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"ab38719f224d18268bf8a5b60f2ce9dc00cc3477","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[SVf] Adding support for temporary volumegroup"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"[Storage Virtualize family] As part of Flashcopy 2.0 implementation,"},{"line_number":10,"context_line":"added support to create, update and delete temporary volumegroup to"},{"line_number":11,"context_line":"allow user to create cinder group without creating a backing"},{"line_number":12,"context_line":"volumegroup on SVC."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"793c2961_bbf0cf15","line":10,"updated":"2024-08-21 06:12:04.000000000","message":"The message should be.. added support for creating, updating, and deleting temporary volume groups...","commit_id":"5ce93b63a5ce06db7be5ae62d49a5f158711e7ce"},{"author":{"_account_id":36800,"name":"Vrinda Dhakad","display_name":"vdhakad","email":"vrinda.dhakad@ibm.com","username":"vdhakad"},"change_message_id":"2bccd66da15e946191deab33e23ce6600e89a41c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[SVf] Adding support for temporary volumegroup"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"[Storage Virtualize family] As part of Flashcopy 2.0 implementation,"},{"line_number":10,"context_line":"added support to create, update and delete temporary volumegroup to"},{"line_number":11,"context_line":"allow user to create cinder group without creating a backing"},{"line_number":12,"context_line":"volumegroup on SVC."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f03d7f53_d6da6bae","line":10,"in_reply_to":"793c2961_bbf0cf15","updated":"2025-01-02 06:58:44.000000000","message":"they mean the same.","commit_id":"5ce93b63a5ce06db7be5ae62d49a5f158711e7ce"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3cf7325c7078042fa5e37327292f85204f61b577","unresolved":true,"context_lines":[{"line_number":10,"context_line":"added support to create, update and delete temporary volumegroup to"},{"line_number":11,"context_line":"allow user to create cinder group without creating a backing"},{"line_number":12,"context_line":"volumegroup on SVC."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: blueprint ibm-svf-volumegroup"},{"line_number":15,"context_line":"Change-Id: I7fb5f58b09a9835b51c168cea23dc5b5e4bb8c01"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"54d2cea9_f95acdc6","line":13,"updated":"2025-06-10 12:35:02.000000000","message":"I know you mentioned this somewhere on this review in a response to Simon, but it would be good to mention that the new option will be documented in a followup change so that reviewers don\u0027t tell you to mention it in the release note","commit_id":"1e785e8e15af3ab71714cd66c2c8ddcccd8c88f9"},{"author":{"_account_id":36800,"name":"Vrinda Dhakad","display_name":"vdhakad","email":"vrinda.dhakad@ibm.com","username":"vdhakad"},"change_message_id":"9def37f4c6bdd871dfa7b24bbef02560f9a682f0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"added support to create, update and delete temporary volumegroup to"},{"line_number":11,"context_line":"allow user to create cinder group without creating a backing"},{"line_number":12,"context_line":"volumegroup on SVC."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: blueprint ibm-svf-volumegroup"},{"line_number":15,"context_line":"Change-Id: I7fb5f58b09a9835b51c168cea23dc5b5e4bb8c01"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"d52141a5_b961085e","line":13,"in_reply_to":"54d2cea9_f95acdc6","updated":"2025-06-11 15:00:56.000000000","message":"Done","commit_id":"1e785e8e15af3ab71714cd66c2c8ddcccd8c88f9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"ab38719f224d18268bf8a5b60f2ce9dc00cc3477","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d583e00e_e92fe3d6","updated":"2024-08-21 06:12:04.000000000","message":"Some Inline Comments for Messaging.","commit_id":"5ce93b63a5ce06db7be5ae62d49a5f158711e7ce"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"02f6913d1b2d1780e14e534e89db13f31352c6b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a0d49215_8d56139f","updated":"2024-12-16 07:07:54.000000000","message":"recheck","commit_id":"d02c4e70d05d40e4c83712580e6d7cebac0444dd"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"3e6b067372f52d7b231a1b0538857c915d47fec4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e5c4b255_36cb603c","updated":"2024-12-26 08:52:53.000000000","message":"recheck","commit_id":"d02c4e70d05d40e4c83712580e6d7cebac0444dd"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"25e67a89228c3ead8fe1fd6cedf14fc2e974c5d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"95d7cffa_596b39f4","updated":"2025-01-08 08:52:15.000000000","message":"1] Couple of minor comments in UT code.\n\n2] Tried to access the below CI links:\nIt says: Page not found\n\nhttps://github.com/vp0410/IBM-Cinder-CI/tree/main/925450/7/iscsi.log\nhttps://github.com/vp0410/IBM-Cinder-CI/tree/main/925450/7/fc.log\n\n3] When CI result is reported; The IBM Storage CI says SUCCESS with links as follows:\n\nIBM-Storage-iSCSI-Log: https://github.com/vp0410/IBM-Cinder-CI/tree/main/${GERRIT_CHANGE_NUMBER}/${GERRIT_PATCHSET_NUMBER}/iscsi.log and\nIBM-Storage-FC-Log: https://github.com/vp0410/IBM-Cinder-CI/tree/main/${GERRIT_CHANGE_NUMBER}/${GERRIT_PATCHSET_NUMBER}/fc.log :\n\nWhile posting links, the GERRIT_CHANGE_NUMBER and GERRIT_PATCHSET_NUMBER should be replaced by actual values (here 925450 and 7 respectively).","commit_id":"0306943e43861fc20abf9b8b14cc8d08de8bff9e"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"217b19c2576d69b8952cb800e4cbc3b8b974a70a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"38bc72d0_cff43cee","updated":"2025-01-07 12:25:01.000000000","message":"IBM CI also passed. Good to go.","commit_id":"0306943e43861fc20abf9b8b14cc8d08de8bff9e"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"ee17b35d4ed6a7d992769be382f9d802284e5ea7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"049767e1_350afaac","updated":"2025-01-07 09:06:20.000000000","message":"This patch is required for the subsequent patches of this features.\n\nCode looks good to me.","commit_id":"0306943e43861fc20abf9b8b14cc8d08de8bff9e"},{"author":{"_account_id":36800,"name":"Vrinda Dhakad","display_name":"vdhakad","email":"vrinda.dhakad@ibm.com","username":"vdhakad"},"change_message_id":"135751984c2a13db739d581548e2be5c1105727a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"989a225f_4c00feb4","updated":"2025-01-06 07:11:52.000000000","message":"recheck","commit_id":"0306943e43861fc20abf9b8b14cc8d08de8bff9e"},{"author":{"_account_id":36800,"name":"Vrinda Dhakad","display_name":"vdhakad","email":"vrinda.dhakad@ibm.com","username":"vdhakad"},"change_message_id":"e728392fe4a91346d51bc742b98b8e8a585adf37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a0d11dc9_e016c0ad","updated":"2025-01-07 06:22:17.000000000","message":"recheck","commit_id":"0306943e43861fc20abf9b8b14cc8d08de8bff9e"},{"author":{"_account_id":36800,"name":"Vrinda Dhakad","display_name":"vdhakad","email":"vrinda.dhakad@ibm.com","username":"vdhakad"},"change_message_id":"edfa1ac1ca2e390194a545ca085e88fea8f96815","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"159a3b45_350d694a","updated":"2025-01-08 12:40:03.000000000","message":"@raghavendra-uddhav.tilay@hpe.com @nilesh.thathagar@dell.com I have addressed your comments, please review.","commit_id":"ce79411adc1b7d8d172740cc7107c19dbe96b101"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"34ef5cb97faa6eb4e4eddd8d894022da5def9529","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e3d09f63_574eddff","updated":"2025-01-10 08:31:35.000000000","message":"My comment in UT code has been addressed. Thanks.\nWill wait for CI and Zuul to get passed.","commit_id":"ce79411adc1b7d8d172740cc7107c19dbe96b101"},{"author":{"_account_id":36800,"name":"Vrinda Dhakad","display_name":"vdhakad","email":"vrinda.dhakad@ibm.com","username":"vdhakad"},"change_message_id":"5d183f53f4e1876ab24345f78bbd6d11d38d7713","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9dd8c337_c93d26d2","updated":"2025-03-12 09:37:11.000000000","message":"Adding core-reviewers.","commit_id":"4a32a9cfc6aafead1b683eb108cf317d1690d358"},{"author":{"_account_id":36800,"name":"Vrinda Dhakad","display_name":"vdhakad","email":"vrinda.dhakad@ibm.com","username":"vdhakad"},"change_message_id":"29de3c9f5cee2c1ce6e3e8b9a878210ee834538c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"e8224bbe_8d7961a6","updated":"2025-01-21 06:09:25.000000000","message":"Hi @prashkre,\n\nPlease check replies to your comments.","commit_id":"4a32a9cfc6aafead1b683eb108cf317d1690d358"},{"author":{"_account_id":37328,"name":"Nimesh Desai","display_name":"Nimesh Desai","email":"nimesh.desai@ibm.com","username":"nimeshdesai"},"change_message_id":"621a83b351b69eea3980c6f2ac62dc6ff75fc778","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"a224192b_dda72517","updated":"2025-01-14 09:03:21.000000000","message":"LGTM","commit_id":"4a32a9cfc6aafead1b683eb108cf317d1690d358"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"1083ba803576d83df91f927d7d7092eb308d3e6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f4b938d3_797bd935","updated":"2025-01-14 05:15:49.000000000","message":"LGTM","commit_id":"4a32a9cfc6aafead1b683eb108cf317d1690d358"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"9368b197f4daf0d454394ad6e025accd91a5adc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"60ae933b_0e5c9184","updated":"2025-01-14 03:06:03.000000000","message":"My comments were addressed in previous patchset. Now Zuul and CI have passed.","commit_id":"4a32a9cfc6aafead1b683eb108cf317d1690d358"},{"author":{"_account_id":36800,"name":"Vrinda Dhakad","display_name":"vdhakad","email":"vrinda.dhakad@ibm.com","username":"vdhakad"},"change_message_id":"44b405532f75898dd4539a6a6878a9809fb1814b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f649d3a6_286d0266","updated":"2025-04-29 06:05:01.000000000","message":"As discussed in last cinder meeting, I have updated release notes and mentioned removal of \u0027storwize_volume_group\u0027 configuration option.\n\nPlease review.\n\nThank you.","commit_id":"91e732a4687bb1883b0e062aa2d857d24c8194f1"},{"author":{"_account_id":36800,"name":"Vrinda Dhakad","display_name":"vdhakad","email":"vrinda.dhakad@ibm.com","username":"vdhakad"},"change_message_id":"304ca82dec858eb09e735747bb8e5214bded607d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"906a9ddd_4745e1d8","updated":"2025-04-29 08:37:38.000000000","message":"recheck","commit_id":"91e732a4687bb1883b0e062aa2d857d24c8194f1"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"3e3a57701bd52b70f9e712b512e7ccb8502ab3c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"a5c49b02_c70ca429","updated":"2025-04-30 14:51:24.000000000","message":"My concern is addressed","commit_id":"3b16c9c7cdba9a9b8d1313cef660fb355b02041c"},{"author":{"_account_id":36800,"name":"Vrinda Dhakad","display_name":"vdhakad","email":"vrinda.dhakad@ibm.com","username":"vdhakad"},"change_message_id":"69abcc2f204c3fe5ed76fddb556c5a08b2c1f9ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"4e6b8d11_889b922b","updated":"2025-05-14 08:06:51.000000000","message":"recheck","commit_id":"22f0292f489b82561397ba62a8080092266abb0f"},{"author":{"_account_id":36800,"name":"Vrinda Dhakad","display_name":"vdhakad","email":"vrinda.dhakad@ibm.com","username":"vdhakad"},"change_message_id":"2d48beb45cca1dc6004339c727536c30793bc961","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"5ec4c961_a026e066","updated":"2025-05-21 05:24:40.000000000","message":"recheck","commit_id":"22f0292f489b82561397ba62a8080092266abb0f"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"58e9fec9583c398647f509b010501a292ae315c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"9889fde1_5ef6d2ae","updated":"2025-05-20 09:11:18.000000000","message":"recheck","commit_id":"22f0292f489b82561397ba62a8080092266abb0f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3cf7325c7078042fa5e37327292f85204f61b577","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"85bf1949_31eda715","updated":"2025-06-10 12:35:02.000000000","message":"Still looking at the code \u0026 tests; left a few comments inline.","commit_id":"1e785e8e15af3ab71714cd66c2c8ddcccd8c88f9"},{"author":{"_account_id":36800,"name":"Vrinda Dhakad","display_name":"vdhakad","email":"vrinda.dhakad@ibm.com","username":"vdhakad"},"change_message_id":"9def37f4c6bdd871dfa7b24bbef02560f9a682f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"c2112b2e_58d7f31b","updated":"2025-06-11 15:00:56.000000000","message":"Hi Brian,\nThanks for the review. I have addressed your comments, let me know if you have any other feedback.","commit_id":"ae17158b4f74b983bde3a00b3a4bfdd523ae8986"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f6ba078d90e49d92d0b39dccc529345f915d5467","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"0f0f294d_48e0f636","updated":"2025-06-12 12:25:01.000000000","message":"Looks like the changes from PS24 got overwritten in the rebase to PS25:\nhttps://review.opendev.org/c/openstack/cinder/+/925450/24..25","commit_id":"11de9a28dd5ec5c6adf0bab9ae4fec093e56499b"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"253b54ead29dd7dc5ecf785492a59f35f5400d6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"ed2765e7_c5208e33","updated":"2025-07-09 08:59:38.000000000","message":"LGTM","commit_id":"8a49886066ae2ec85900ab4f4c4c37d5ffd8842b"},{"author":{"_account_id":37328,"name":"Nimesh Desai","display_name":"Nimesh Desai","email":"nimesh.desai@ibm.com","username":"nimeshdesai"},"change_message_id":"b55b8c6aa623f3576a7cf985685dc2cc7db11be5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"394246e7_21093a97","updated":"2025-08-05 06:37:30.000000000","message":"LGTM","commit_id":"33d97a7c668b0ae6f7798272c3ce17be85b5afb3"},{"author":{"_account_id":36800,"name":"Vrinda Dhakad","display_name":"vdhakad","email":"vrinda.dhakad@ibm.com","username":"vdhakad"},"change_message_id":"8ffdc31ce75a1f653d6fae21b4a4343cbc9213f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"96e58d56_06492af5","updated":"2025-07-29 04:26:57.000000000","message":"recheck","commit_id":"33d97a7c668b0ae6f7798272c3ce17be85b5afb3"},{"author":{"_account_id":36800,"name":"Vrinda Dhakad","display_name":"vdhakad","email":"vrinda.dhakad@ibm.com","username":"vdhakad"},"change_message_id":"048beadc503a21cf815ae1b2567ee87e51c04d19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"c91bf9da_456757de","updated":"2025-07-29 04:27:06.000000000","message":"run-IBM-CI","commit_id":"33d97a7c668b0ae6f7798272c3ce17be85b5afb3"},{"author":{"_account_id":36800,"name":"Vrinda Dhakad","display_name":"vdhakad","email":"vrinda.dhakad@ibm.com","username":"vdhakad"},"change_message_id":"c8656637b5e4f8d78ce57bf1c732985f87058e2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"54b8c81f_d908f749","updated":"2025-08-25 04:27:41.000000000","message":"recheck","commit_id":"43dfa492ba2202ba0278034887b712aedc78544e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9686550ef6111361f0239f195588f1a411b4ce56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"7787c789_5bb06279","updated":"2025-09-02 19:07:44.000000000","message":"Code \u0026 tests look OK.","commit_id":"9976a1969e36c25425308db5dc27f9fb9b366700"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"6148e336d4f72188df475819e78b784f9f4d38a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"36cdc53e_b705f077","updated":"2025-08-27 13:48:27.000000000","message":"OK","commit_id":"9976a1969e36c25425308db5dc27f9fb9b366700"},{"author":{"_account_id":37328,"name":"Nimesh Desai","display_name":"Nimesh Desai","email":"nimesh.desai@ibm.com","username":"nimeshdesai"},"change_message_id":"abba3a4354d475cc97b846d8715dc65ea2362b1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"e8ce8496_2fa0ba40","updated":"2025-09-03 11:15:01.000000000","message":"LGTM","commit_id":"7977b7b596dd0223e09da25bc694cd5d3f1ecf73"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9ac29913b35aea02ead77eb48e3b75b21bec2a42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"1e60e798_6ae5e4e3","updated":"2025-09-03 14:17:35.000000000","message":"Only change since my last review was to clean up an option\u0027s help text, so renewing my +2.","commit_id":"7977b7b596dd0223e09da25bc694cd5d3f1ecf73"},{"author":{"_account_id":36800,"name":"Vrinda Dhakad","display_name":"vdhakad","email":"vrinda.dhakad@ibm.com","username":"vdhakad"},"change_message_id":"e56e6d29c5970150ea123c3fe19a86c3b4242dc5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"bd196e86_7ed987dc","updated":"2025-09-03 10:10:57.000000000","message":"recheck","commit_id":"7977b7b596dd0223e09da25bc694cd5d3f1ecf73"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"416beda04f67b6a22b813742dcb6716b0f1fe3c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":46,"id":"4e9d0007_a7472891","updated":"2025-09-04 17:50:42.000000000","message":"looks good, +2 from Brian.","commit_id":"f6c6c4c272f86e3b1ace9d94f234045687e09064"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"c6d914792a1804ddc8d7ace44eb404cf3c4a55d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":46,"id":"d63b2404_02087802","updated":"2025-09-04 21:41:15.000000000","message":"recheck","commit_id":"f6c6c4c272f86e3b1ace9d94f234045687e09064"}],"cinder/tests/unit/volume/drivers/ibm/test_storwize_svc.py":[{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"b2f761ee32c6b936a6874257b9c8610e9e7354ee","unresolved":true,"context_lines":[{"line_number":7281,"context_line":"    def test_check_codelevel_for_temp_volumegroup_fail(self):"},{"line_number":7282,"context_line":"        code_level \u003d (8, 5, 2, 0)"},{"line_number":7283,"context_line":"        self.assertRaises(exception.VolumeDriverException,"},{"line_number":7284,"context_line":"                          self.driver._helpers.check_codelevel_for_temp_volumegroup,"},{"line_number":7285,"context_line":"                          code_level)"},{"line_number":7286,"context_line":""},{"line_number":7287,"context_line":"    def test_check_code_level_within_limit_true(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"973aabd0_0c59cb6f","line":7284,"updated":"2024-08-01 09:58:19.000000000","message":"Check for pep8 and flake8 errors on this.","commit_id":"7c02fdc68c3f305d67b6f6d34134c8911d7291d4"},{"author":{"_account_id":36800,"name":"Vrinda Dhakad","display_name":"vdhakad","email":"vrinda.dhakad@ibm.com","username":"vdhakad"},"change_message_id":"2040799c6aaea1a82592ab186d34dfb4c48666ca","unresolved":false,"context_lines":[{"line_number":7281,"context_line":"    def test_check_codelevel_for_temp_volumegroup_fail(self):"},{"line_number":7282,"context_line":"        code_level \u003d (8, 5, 2, 0)"},{"line_number":7283,"context_line":"        self.assertRaises(exception.VolumeDriverException,"},{"line_number":7284,"context_line":"                          self.driver._helpers.check_codelevel_for_temp_volumegroup,"},{"line_number":7285,"context_line":"                          code_level)"},{"line_number":7286,"context_line":""},{"line_number":7287,"context_line":"    def test_check_code_level_within_limit_true(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"b523deb4_5b287c25","line":7284,"in_reply_to":"973aabd0_0c59cb6f","updated":"2024-08-19 08:00:27.000000000","message":"Done","commit_id":"7c02fdc68c3f305d67b6f6d34134c8911d7291d4"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"b2f761ee32c6b936a6874257b9c8610e9e7354ee","unresolved":true,"context_lines":[{"line_number":7300,"context_line":"            min_level, max_level, code_level)"},{"line_number":7301,"context_line":"        self.assertFalse(result)"},{"line_number":7302,"context_line":""},{"line_number":7303,"context_line":"    @mock.patch.object(storwize_svc_common.StorwizeHelpers,"},{"line_number":7304,"context_line":"                       \u0027create_volumegroup\u0027)"},{"line_number":7305,"context_line":"    @mock.patch.object(storwize_svc_common.StorwizeHelpers,"},{"line_number":7306,"context_line":"                       \u0027delete_volumegroup\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"6653754c_57e168d2","line":7303,"updated":"2024-08-01 09:58:19.000000000","message":"Repeated line of code.","commit_id":"7c02fdc68c3f305d67b6f6d34134c8911d7291d4"},{"author":{"_account_id":36800,"name":"Vrinda Dhakad","display_name":"vdhakad","email":"vrinda.dhakad@ibm.com","username":"vdhakad"},"change_message_id":"2040799c6aaea1a82592ab186d34dfb4c48666ca","unresolved":false,"context_lines":[{"line_number":7300,"context_line":"            min_level, max_level, code_level)"},{"line_number":7301,"context_line":"        self.assertFalse(result)"},{"line_number":7302,"context_line":""},{"line_number":7303,"context_line":"    @mock.patch.object(storwize_svc_common.StorwizeHelpers,"},{"line_number":7304,"context_line":"                       \u0027create_volumegroup\u0027)"},{"line_number":7305,"context_line":"    @mock.patch.object(storwize_svc_common.StorwizeHelpers,"},{"line_number":7306,"context_line":"                       \u0027delete_volumegroup\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"371d7352_d0bf8c22","line":7303,"in_reply_to":"6653754c_57e168d2","updated":"2024-08-19 08:00:27.000000000","message":"Not repeated, this annotation is for next unit test function. Not actually part of current change.","commit_id":"7c02fdc68c3f305d67b6f6d34134c8911d7291d4"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"25e67a89228c3ead8fe1fd6cedf14fc2e974c5d4","unresolved":true,"context_lines":[{"line_number":7296,"context_line":"            min_level, max_level, code_level)"},{"line_number":7297,"context_line":"        self.assertTrue(result)"},{"line_number":7298,"context_line":""},{"line_number":7299,"context_line":"    def test_check_code_level_within_limit_false(self):"},{"line_number":7300,"context_line":"        code_level \u003d (8, 5, 4, 0)"},{"line_number":7301,"context_line":"        min_level \u003d (8, 5, 1, 0)"},{"line_number":7302,"context_line":"        max_level \u003d (8, 5, 3, 0)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ac05579_9a2cdc54","line":7299,"updated":"2025-01-08 08:52:15.000000000","message":"this function and previous one can be combined into single function using decorator;\nand code_level can be passed as argument.","commit_id":"0306943e43861fc20abf9b8b14cc8d08de8bff9e"},{"author":{"_account_id":36800,"name":"Vrinda Dhakad","display_name":"vdhakad","email":"vrinda.dhakad@ibm.com","username":"vdhakad"},"change_message_id":"edfa1ac1ca2e390194a545ca085e88fea8f96815","unresolved":false,"context_lines":[{"line_number":7296,"context_line":"            min_level, max_level, code_level)"},{"line_number":7297,"context_line":"        self.assertTrue(result)"},{"line_number":7298,"context_line":""},{"line_number":7299,"context_line":"    def test_check_code_level_within_limit_false(self):"},{"line_number":7300,"context_line":"        code_level \u003d (8, 5, 4, 0)"},{"line_number":7301,"context_line":"        min_level \u003d (8, 5, 1, 0)"},{"line_number":7302,"context_line":"        max_level \u003d (8, 5, 3, 0)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7056072d_4ea35a29","line":7299,"in_reply_to":"1ac05579_9a2cdc54","updated":"2025-01-08 12:40:03.000000000","message":"Done. I haven\u0027t used a decorator because didn\u0027t find any need. I have created a common test for both the scenarios.","commit_id":"0306943e43861fc20abf9b8b14cc8d08de8bff9e"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"25e67a89228c3ead8fe1fd6cedf14fc2e974c5d4","unresolved":true,"context_lines":[{"line_number":7448,"context_line":"    def test_storwize_create_and_delete_volumegroup_snapshot("},{"line_number":7449,"context_line":"            self, get_system_info):"},{"line_number":7450,"context_line":"        \"\"\"Test creation and deletion of volumegroup snapshot\"\"\""},{"line_number":7451,"context_line":"        fake_system_info \u003d {\u0027code_level\u0027: (8, 5, 1, 0),"},{"line_number":7452,"context_line":"                            \u0027system_name\u0027: \u0027storwize-svc-sim\u0027,"},{"line_number":7453,"context_line":"                            \u0027system_id\u0027: \u00270123456789ABCDEF\u0027}"},{"line_number":7454,"context_line":"        get_system_info.return_value \u003d fake_system_info"}],"source_content_type":"text/x-python","patch_set":7,"id":"1b1975e2_7ebc900e","line":7451,"range":{"start_line":7451,"start_character":43,"end_line":7451,"end_character":53},"updated":"2025-01-08 08:52:15.000000000","message":"this value 8,5,1,0 is being used at multiple places.\nit can be declared as constant.","commit_id":"0306943e43861fc20abf9b8b14cc8d08de8bff9e"},{"author":{"_account_id":36800,"name":"Vrinda Dhakad","display_name":"vdhakad","email":"vrinda.dhakad@ibm.com","username":"vdhakad"},"change_message_id":"edfa1ac1ca2e390194a545ca085e88fea8f96815","unresolved":false,"context_lines":[{"line_number":7448,"context_line":"    def test_storwize_create_and_delete_volumegroup_snapshot("},{"line_number":7449,"context_line":"            self, get_system_info):"},{"line_number":7450,"context_line":"        \"\"\"Test creation and deletion of volumegroup snapshot\"\"\""},{"line_number":7451,"context_line":"        fake_system_info \u003d {\u0027code_level\u0027: (8, 5, 1, 0),"},{"line_number":7452,"context_line":"                            \u0027system_name\u0027: \u0027storwize-svc-sim\u0027,"},{"line_number":7453,"context_line":"                            \u0027system_id\u0027: \u00270123456789ABCDEF\u0027}"},{"line_number":7454,"context_line":"        get_system_info.return_value \u003d fake_system_info"}],"source_content_type":"text/x-python","patch_set":7,"id":"de6ee964_67e68886","line":7451,"range":{"start_line":7451,"start_character":43,"end_line":7451,"end_character":53},"in_reply_to":"1b1975e2_7ebc900e","updated":"2025-01-08 12:40:03.000000000","message":"Ack. Replaced with constants","commit_id":"0306943e43861fc20abf9b8b14cc8d08de8bff9e"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"b2f761ee32c6b936a6874257b9c8610e9e7354ee","unresolved":true,"context_lines":[{"line_number":6340,"context_line":"                 \u0027 is %s\u0027, storwize_volume_group)"},{"line_number":6341,"context_line":""},{"line_number":6342,"context_line":"        if ("},{"line_number":6343,"context_line":"            volume_utils.is_group_a_type(group, \"volume_group_enabled\") or"},{"line_number":6344,"context_line":"            volume_utils.is_group_a_type("},{"line_number":6345,"context_line":"                group, \"temporary_volume_group_enabled\")):"},{"line_number":6346,"context_line":"            if storwize_volume_group:"}],"source_content_type":"text/x-python","patch_set":1,"id":"f4db3b64_78b194d3","line":6343,"updated":"2024-08-01 09:58:19.000000000","message":"This line can be moved to the previous line.","commit_id":"7c02fdc68c3f305d67b6f6d34134c8911d7291d4"},{"author":{"_account_id":36800,"name":"Vrinda Dhakad","display_name":"vdhakad","email":"vrinda.dhakad@ibm.com","username":"vdhakad"},"change_message_id":"2040799c6aaea1a82592ab186d34dfb4c48666ca","unresolved":false,"context_lines":[{"line_number":6340,"context_line":"                 \u0027 is %s\u0027, storwize_volume_group)"},{"line_number":6341,"context_line":""},{"line_number":6342,"context_line":"        if ("},{"line_number":6343,"context_line":"            volume_utils.is_group_a_type(group, \"volume_group_enabled\") or"},{"line_number":6344,"context_line":"            volume_utils.is_group_a_type("},{"line_number":6345,"context_line":"                group, \"temporary_volume_group_enabled\")):"},{"line_number":6346,"context_line":"            if storwize_volume_group:"}],"source_content_type":"text/x-python","patch_set":1,"id":"c2a272df_16a263c7","line":6343,"in_reply_to":"f4db3b64_78b194d3","updated":"2024-08-19 08:00:27.000000000","message":"Done","commit_id":"7c02fdc68c3f305d67b6f6d34134c8911d7291d4"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"d80aad6f885c9fef4ae4edee04245f3ee303a69f","unresolved":true,"context_lines":[{"line_number":172,"context_line":"                     \u0027or moving the primary volume from mirror to non-mirror \u0027"},{"line_number":173,"context_line":"                     \u0027with replication enabled. This option is valid for \u0027"},{"line_number":174,"context_line":"                     \u0027Storage Virtualize Family.\u0027),"},{"line_number":175,"context_line":"    cfg.BoolOpt(\u0027storwize_volume_group\u0027,"},{"line_number":176,"context_line":"                default\u003dFalse,"},{"line_number":177,"context_line":"                help\u003d\u0027Parameter to enable or disable Volume Group\u0027"},{"line_number":178,"context_line":"                     \u0027(True/False)\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"c309ec2b_178e88f6","side":"PARENT","line":175,"updated":"2025-03-12 14:40:37.000000000","message":"If this parameter is being removed/changed, then it should be noted in the documentation and/or the release note","commit_id":"25699617a1251d727a83e969fc27a16ce7b91f5b"},{"author":{"_account_id":36800,"name":"Vrinda Dhakad","display_name":"vdhakad","email":"vrinda.dhakad@ibm.com","username":"vdhakad"},"change_message_id":"e1f352955e3e0607278ff77c76dc676c4bb718b4","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                     \u0027or moving the primary volume from mirror to non-mirror \u0027"},{"line_number":173,"context_line":"                     \u0027with replication enabled. This option is valid for \u0027"},{"line_number":174,"context_line":"                     \u0027Storage Virtualize Family.\u0027),"},{"line_number":175,"context_line":"    cfg.BoolOpt(\u0027storwize_volume_group\u0027,"},{"line_number":176,"context_line":"                default\u003dFalse,"},{"line_number":177,"context_line":"                help\u003d\u0027Parameter to enable or disable Volume Group\u0027"},{"line_number":178,"context_line":"                     \u0027(True/False)\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"e99dcaba_b52c4785","side":"PARENT","line":175,"in_reply_to":"c309ec2b_178e88f6","updated":"2025-03-13 05:29:56.000000000","message":"Doc changes for this feature are covered under patch: https://review.opendev.org/c/openstack/cinder/+/929906\nI will address you comment in the doc patch, mentioning \u0027storwize_volume_group\u0027 is deprecated.","commit_id":"25699617a1251d727a83e969fc27a16ce7b91f5b"},{"author":{"_account_id":24005,"name":"prashkre","email":"prashkre@in.ibm.com","username":"prashkre"},"change_message_id":"b8f618105932dd3a4ba9fd25b52c2b966070bfdc","unresolved":true,"context_lines":[{"line_number":7283,"context_line":"                                    \"False. \") % {\u0027vol\u0027: volume.name})"},{"line_number":7284,"context_line":"                        model_update[\u0027status\u0027] \u003d fields.GroupStatus.ERROR"},{"line_number":7285,"context_line":"                        raise exception.InvalidInput(reason\u003dreason)"},{"line_number":7286,"context_line":"                    self._helpers.add_vdisk_to_volumegroup(vol_name,"},{"line_number":7287,"context_line":"                                                           volumegroup_id)"},{"line_number":7288,"context_line":"                    added_vols.append({\u0027id\u0027: volume.id,"},{"line_number":7289,"context_line":"                                       \u0027group_id\u0027: group.id})"}],"source_content_type":"text/x-python","patch_set":9,"id":"963d43ec_acc0c1b8","line":7286,"updated":"2025-01-18 13:37:53.000000000","message":"Let\u0027s say 3 volumes(vol1, vol2, vol3) being added to a volume group and only vol3\nhas legacy flash-copy mappings.\n\nIn above case, vol1 and vol2 are added to volume group at storwize but never updated in cinder DB and also group is set to ERROR, with this there is a inconsistency behavior of volumes are attached to volume group in storage but not in cinder.\n\nIt can be handled in one of the following ways.\n\n1. Validate all volumes don\u0027t have legacy FlashCopy mappings, then allow adding volumes to group.\n2. Otherwise rollback the added transactions by removing volumes from the group.","commit_id":"4a32a9cfc6aafead1b683eb108cf317d1690d358"},{"author":{"_account_id":36800,"name":"Vrinda Dhakad","display_name":"vdhakad","email":"vrinda.dhakad@ibm.com","username":"vdhakad"},"change_message_id":"29de3c9f5cee2c1ce6e3e8b9a878210ee834538c","unresolved":false,"context_lines":[{"line_number":7283,"context_line":"                                    \"False. \") % {\u0027vol\u0027: volume.name})"},{"line_number":7284,"context_line":"                        model_update[\u0027status\u0027] \u003d fields.GroupStatus.ERROR"},{"line_number":7285,"context_line":"                        raise exception.InvalidInput(reason\u003dreason)"},{"line_number":7286,"context_line":"                    self._helpers.add_vdisk_to_volumegroup(vol_name,"},{"line_number":7287,"context_line":"                                                           volumegroup_id)"},{"line_number":7288,"context_line":"                    added_vols.append({\u0027id\u0027: volume.id,"},{"line_number":7289,"context_line":"                                       \u0027group_id\u0027: group.id})"}],"source_content_type":"text/x-python","patch_set":9,"id":"c9436f6f_1f7a5377","line":7286,"in_reply_to":"963d43ec_acc0c1b8","updated":"2025-01-21 06:09:25.000000000","message":"Hi prashkre,\n\nYou\u0027re right and this is as per design. Checking if a volume has FlashCopy mappings is a time-heavy task. If a user has added 500 volumes to the group and only one has FC mapping, we still want remaining 499 volumes to get added to the group.\nAs for the error state, user can reset the status.","commit_id":"4a32a9cfc6aafead1b683eb108cf317d1690d358"},{"author":{"_account_id":24005,"name":"prashkre","email":"prashkre@in.ibm.com","username":"prashkre"},"change_message_id":"33d2823f82efa1365d18c51f96580bfe345bfff8","unresolved":true,"context_lines":[{"line_number":7301,"context_line":"                    added_vols.append({\u0027id\u0027: volume.id,"},{"line_number":7302,"context_line":"                                       \u0027group_id\u0027: group.id})"},{"line_number":7303,"context_line":"                    self._update_volumegroup_properties(context, volume, group)"},{"line_number":7304,"context_line":"                except exception.VolumeBackendAPIException as err:"},{"line_number":7305,"context_line":"                    model_update[\u0027status\u0027] \u003d fields.GroupStatus.ERROR"},{"line_number":7306,"context_line":"                    LOG.error(\"Failed to add the volume %(vol)s to \""},{"line_number":7307,"context_line":"                              \"group. Exception: %(exception)s.\","}],"source_content_type":"text/x-python","patch_set":9,"id":"2cdab9d3_17bd41eb","line":7304,"updated":"2025-01-21 05:36:57.000000000","message":"same issue reported at line# 7286 can be seen here","commit_id":"4a32a9cfc6aafead1b683eb108cf317d1690d358"},{"author":{"_account_id":36800,"name":"Vrinda Dhakad","display_name":"vdhakad","email":"vrinda.dhakad@ibm.com","username":"vdhakad"},"change_message_id":"29de3c9f5cee2c1ce6e3e8b9a878210ee834538c","unresolved":false,"context_lines":[{"line_number":7301,"context_line":"                    added_vols.append({\u0027id\u0027: volume.id,"},{"line_number":7302,"context_line":"                                       \u0027group_id\u0027: group.id})"},{"line_number":7303,"context_line":"                    self._update_volumegroup_properties(context, volume, group)"},{"line_number":7304,"context_line":"                except exception.VolumeBackendAPIException as err:"},{"line_number":7305,"context_line":"                    model_update[\u0027status\u0027] \u003d fields.GroupStatus.ERROR"},{"line_number":7306,"context_line":"                    LOG.error(\"Failed to add the volume %(vol)s to \""},{"line_number":7307,"context_line":"                              \"group. Exception: %(exception)s.\","}],"source_content_type":"text/x-python","patch_set":9,"id":"8e7998a7_ac9f76a7","line":7304,"in_reply_to":"2cdab9d3_17bd41eb","updated":"2025-01-21 06:09:25.000000000","message":"Replied in previous comment.","commit_id":"4a32a9cfc6aafead1b683eb108cf317d1690d358"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3cf7325c7078042fa5e37327292f85204f61b577","unresolved":true,"context_lines":[{"line_number":181,"context_line":"                help\u003d\u0027Parameter to allow or prevent volumes with legacy \u0027"},{"line_number":182,"context_line":"                     \u0027FlashCopy mappings to be part of volume_group_enabled \u0027"},{"line_number":183,"context_line":"                     \u0027and temporary_volume_group_enabled groups.\u0027"},{"line_number":184,"context_line":"                     \u0027(True/False)\u0027),"},{"line_number":185,"context_line":"]"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":22,"id":"3b3d1f89_66124268","line":184,"range":{"start_line":184,"start_character":22,"end_line":184,"end_character":34},"updated":"2025-06-10 12:35:02.000000000","message":"two things -- (1) don\u0027t really need (T/F) here, it\u0027s documented as a boolean option in the sample config file [0]; (2) you should have a space between the period on the previous line and the \u0027(\u0027 on this line.\n\n[0] https://cb0b324d2e1a3e0ab94c-5b4233ce682298a00859e3398b583332.ssl.cf5.rackcdn.com/openstack/54cc836a28e84c73acc384785ca9c338/docs/_static/cinder.conf.sample","commit_id":"1e785e8e15af3ab71714cd66c2c8ddcccd8c88f9"},{"author":{"_account_id":36800,"name":"Vrinda Dhakad","display_name":"vdhakad","email":"vrinda.dhakad@ibm.com","username":"vdhakad"},"change_message_id":"9def37f4c6bdd871dfa7b24bbef02560f9a682f0","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                help\u003d\u0027Parameter to allow or prevent volumes with legacy \u0027"},{"line_number":182,"context_line":"                     \u0027FlashCopy mappings to be part of volume_group_enabled \u0027"},{"line_number":183,"context_line":"                     \u0027and temporary_volume_group_enabled groups.\u0027"},{"line_number":184,"context_line":"                     \u0027(True/False)\u0027),"},{"line_number":185,"context_line":"]"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":22,"id":"27d33a30_92e3ff97","line":184,"range":{"start_line":184,"start_character":22,"end_line":184,"end_character":34},"in_reply_to":"3b3d1f89_66124268","updated":"2025-06-11 15:00:56.000000000","message":"Done","commit_id":"1e785e8e15af3ab71714cd66c2c8ddcccd8c88f9"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9686550ef6111361f0239f195588f1a411b4ce56","unresolved":true,"context_lines":[{"line_number":181,"context_line":"                help\u003d\u0027Parameter to allow or prevent volumes with legacy \u0027"},{"line_number":182,"context_line":"                     \u0027FlashCopy mappings to be part of volume_group_enabled \u0027"},{"line_number":183,"context_line":"                     \u0027and temporary_volume_group_enabled groups.\u0027"},{"line_number":184,"context_line":"                     \u0027(True/False)\u0027),"},{"line_number":185,"context_line":"]"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":25,"id":"61ee5b9d_96c37107","line":184,"updated":"2025-09-02 19:07:44.000000000","message":"My comment on PS 22 still applies here.","commit_id":"11de9a28dd5ec5c6adf0bab9ae4fec093e56499b"},{"author":{"_account_id":36800,"name":"Vrinda Dhakad","display_name":"vdhakad","email":"vrinda.dhakad@ibm.com","username":"vdhakad"},"change_message_id":"92e4d8dcc11164adb639f8bac7d2bdb6c4c59edb","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                help\u003d\u0027Parameter to allow or prevent volumes with legacy \u0027"},{"line_number":182,"context_line":"                     \u0027FlashCopy mappings to be part of volume_group_enabled \u0027"},{"line_number":183,"context_line":"                     \u0027and temporary_volume_group_enabled groups.\u0027"},{"line_number":184,"context_line":"                     \u0027(True/False)\u0027),"},{"line_number":185,"context_line":"]"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":25,"id":"6165e0cd_4b0872f9","line":184,"in_reply_to":"61ee5b9d_96c37107","updated":"2025-09-03 05:35:55.000000000","message":"Done","commit_id":"11de9a28dd5ec5c6adf0bab9ae4fec093e56499b"}],"releasenotes/notes/ibm-svf-support-for-temporary-volumegroup-3db871245b864a52.yaml":[{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"ab38719f224d18268bf8a5b60f2ce9dc00cc3477","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    IBM Storage Virtualize Family driver: Added support for create,"},{"line_number":5,"context_line":"    update and delete temporary volumegroup."},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3832e902_2935d7b4","line":4,"updated":"2024-08-21 06:12:04.000000000","message":"The message should be.. Added support for creating, updating, and deleting temporary volume groups.","commit_id":"5ce93b63a5ce06db7be5ae62d49a5f158711e7ce"},{"author":{"_account_id":36800,"name":"Vrinda Dhakad","display_name":"vdhakad","email":"vrinda.dhakad@ibm.com","username":"vdhakad"},"change_message_id":"2bccd66da15e946191deab33e23ce6600e89a41c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    IBM Storage Virtualize Family driver: Added support for create,"},{"line_number":5,"context_line":"    update and delete temporary volumegroup."},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3d2de712_fd9ca8d0","line":4,"in_reply_to":"3832e902_2935d7b4","updated":"2025-01-02 06:58:44.000000000","message":"they mean the same.","commit_id":"5ce93b63a5ce06db7be5ae62d49a5f158711e7ce"}]}