)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"82092af64675db98d23da2e4645fdecd81bc5c03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"68db6ef9_7f2a7485","updated":"2024-08-14 11:03:15.000000000","message":"run-storpoolci","commit_id":"872dec185e78e89e5b917562d7525827d0f82d20"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"670954a9f3eed87b2a12d334a8811474cae51e27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"013d756e_5b3143a8","updated":"2024-09-13 18:24:21.000000000","message":"run-storpoolci","commit_id":"4d9d0c1e79f9cd068cd4a45cbb8179ac23617c71"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"849dff0bbae48b124d19a2f7681634aee00d4ee1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"07013a21_9aec68a7","updated":"2024-08-19 10:00:32.000000000","message":"run-storpoolci","commit_id":"4d9d0c1e79f9cd068cd4a45cbb8179ac23617c71"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ad694a36bf8bc8a47b69165ba88ce3f07a92bfef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"03444c24_ec7a6557","updated":"2024-10-14 16:30:25.000000000","message":"Adding core folks to review.","commit_id":"4a6202cf68c0ce9d1da74cc46c7b7e7f4c52ab2f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"99073045b5d7638847a127cce3c33259e4db075c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d5979d79_f2c6d61c","updated":"2024-11-18 17:20:39.000000000","message":"run-storpoolci","commit_id":"4a6202cf68c0ce9d1da74cc46c7b7e7f4c52ab2f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8274fbdc350a1b905a26f3a264e23d353007b113","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"20448102_1c8d8bb5","updated":"2024-11-22 00:05:31.000000000","message":"I have a concern about the type of the \u0027id\u0027 field your using in your tests (see comment inline).  Otherwise, this looks fine.","commit_id":"16436e87fa2bfb985ffe13cc7e4b801f58f212e1"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"d3de62b2d45f5232fae61b156a5ebfa7a9461dd3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e053114a_f6461dc5","updated":"2024-11-20 08:31:08.000000000","message":"run-storpoolci","commit_id":"16436e87fa2bfb985ffe13cc7e4b801f58f212e1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8b6a84295e58abdb83480d27c6132ca91ce5927a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1f7c8e84_9a06a0db","updated":"2024-11-22 15:29:47.000000000","message":"LGTM.","commit_id":"d9e31ee7020e9d20fa256998645fc5a1d41ed5c0"}],"cinder/tests/unit/volume/drivers/test_storpool.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8274fbdc350a1b905a26f3a264e23d353007b113","unresolved":true,"context_lines":[{"line_number":329,"context_line":"        self.assertDictEqual({}, snapshots)"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        self.driver.create_volume({\u0027id\u0027: \u00271\u0027, \u0027name\u0027: \u0027v1\u0027, \u0027size\u0027: 1,"},{"line_number":332,"context_line":"                                   \u0027volume_type\u0027: {\u0027id\u0027: 1}})"},{"line_number":333,"context_line":"        self.assertCountEqual([volumeName(\u00271\u0027)], volumes.keys())"},{"line_number":334,"context_line":"        self.assertVolumeNames((\u00271\u0027,))"},{"line_number":335,"context_line":"        v \u003d volumes[volumeName(\u00271\u0027)]"}],"source_content_type":"text/x-python","patch_set":5,"id":"ea46f6e0_7e3c7c22","line":332,"range":{"start_line":332,"start_character":57,"end_line":332,"end_character":58},"updated":"2024-11-22 00:05:31.000000000","message":"Two things to think about here:\n- in cinder, the volume_type\u0027s id field is a string, not an integer; since ints and strings have different properties, it\u0027s probably better to use a string so that you don\u0027t have any code that depends on the id having integer properties\n- there are predefined volume_type ids you can use in the cinder.tests.unit.fake_constants module (you don\u0027t have to use them, but they may be handy","commit_id":"16436e87fa2bfb985ffe13cc7e4b801f58f212e1"},{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"91a52b512021080c93717aca70c1993c61a6e950","unresolved":false,"context_lines":[{"line_number":329,"context_line":"        self.assertDictEqual({}, snapshots)"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        self.driver.create_volume({\u0027id\u0027: \u00271\u0027, \u0027name\u0027: \u0027v1\u0027, \u0027size\u0027: 1,"},{"line_number":332,"context_line":"                                   \u0027volume_type\u0027: {\u0027id\u0027: 1}})"},{"line_number":333,"context_line":"        self.assertCountEqual([volumeName(\u00271\u0027)], volumes.keys())"},{"line_number":334,"context_line":"        self.assertVolumeNames((\u00271\u0027,))"},{"line_number":335,"context_line":"        v \u003d volumes[volumeName(\u00271\u0027)]"}],"source_content_type":"text/x-python","patch_set":5,"id":"fb1d8aaa_35be99dc","line":332,"range":{"start_line":332,"start_character":57,"end_line":332,"end_character":58},"in_reply_to":"ea46f6e0_7e3c7c22","updated":"2024-11-22 09:27:32.000000000","message":"Nice, I\u0027ve refactored the change to use the volume IDs in\n`cinder.tests.unit.fake_constants`. Thanks!","commit_id":"16436e87fa2bfb985ffe13cc7e4b801f58f212e1"}]}