)]}'
{".zuul.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"35b0713ecb9a36c478396e1703a64c7a9b17fad7","unresolved":true,"context_lines":[{"line_number":183,"context_line":"    vars:"},{"line_number":184,"context_line":"      # FIXME(sean-k-mooney) skip the test_image_formats for now"},{"line_number":185,"context_line":"      # as we have not configured this job correctly to run them"},{"line_number":186,"context_line":"      # check nova\u0027s nova-ceph-multistore job config"},{"line_number":187,"context_line":"      tempest_exclude_regex: (tempest.api.image.v2.test_images_formats)"},{"line_number":188,"context_line":"      configure_swap_size: 4096"},{"line_number":189,"context_line":"      devstack_localrc:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e4998416_1a18792e","line":186,"updated":"2024-08-15 21:10:34.000000000","message":"Pleas change the comment to something more like this:\n\n```\n# FIXME: change I29b1af0a4034decad to tempest added image format tests that\n# cannot pass in this job because the image data takes a optimized path that\n# bypasses nova\u0027s checks.  Until the nova team decides on a strategy to handle\n# this issue, we skip these tests.\n```","commit_id":"a4f15416882111e4aec7eb981a2e12a10d36b748"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"82ed25d1a2bb4860e0d3d8d2de0b1bf2637ec962","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    vars:"},{"line_number":184,"context_line":"      # FIXME(sean-k-mooney) skip the test_image_formats for now"},{"line_number":185,"context_line":"      # as we have not configured this job correctly to run them"},{"line_number":186,"context_line":"      # check nova\u0027s nova-ceph-multistore job config"},{"line_number":187,"context_line":"      tempest_exclude_regex: (tempest.api.image.v2.test_images_formats)"},{"line_number":188,"context_line":"      configure_swap_size: 4096"},{"line_number":189,"context_line":"      devstack_localrc:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"cdc04c78_7dbcb9c3","line":186,"in_reply_to":"e4998416_1a18792e","updated":"2024-08-16 06:39:37.000000000","message":"Done","commit_id":"a4f15416882111e4aec7eb981a2e12a10d36b748"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"35b0713ecb9a36c478396e1703a64c7a9b17fad7","unresolved":true,"context_lines":[{"line_number":184,"context_line":"      # FIXME(sean-k-mooney) skip the test_image_formats for now"},{"line_number":185,"context_line":"      # as we have not configured this job correctly to run them"},{"line_number":186,"context_line":"      # check nova\u0027s nova-ceph-multistore job config"},{"line_number":187,"context_line":"      tempest_exclude_regex: (tempest.api.image.v2.test_images_formats)"},{"line_number":188,"context_line":"      configure_swap_size: 4096"},{"line_number":189,"context_line":"      devstack_localrc:"},{"line_number":190,"context_line":"        CEPH_MIN_CLIENT_VERSION: \"mimic\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dd179317_21ce95c7","line":187,"range":{"start_line":187,"start_character":30,"end_line":187,"end_character":70},"updated":"2024-08-15 21:10:34.000000000","message":"I think we should be more specific with the regex to make it more clear what\u0027s going on:\n\n```\ntempest.api.image.v2.test_images_formats.ImagesFormatTest.test_compute_rejects\n```\n\nAlso, there\u0027s no telling when the FIXME will be addressed (since it depends on noticing something in another project), so this way if other, useful tests are added to that class, we won\u0027t skip them.","commit_id":"a4f15416882111e4aec7eb981a2e12a10d36b748"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"82ed25d1a2bb4860e0d3d8d2de0b1bf2637ec962","unresolved":false,"context_lines":[{"line_number":184,"context_line":"      # FIXME(sean-k-mooney) skip the test_image_formats for now"},{"line_number":185,"context_line":"      # as we have not configured this job correctly to run them"},{"line_number":186,"context_line":"      # check nova\u0027s nova-ceph-multistore job config"},{"line_number":187,"context_line":"      tempest_exclude_regex: (tempest.api.image.v2.test_images_formats)"},{"line_number":188,"context_line":"      configure_swap_size: 4096"},{"line_number":189,"context_line":"      devstack_localrc:"},{"line_number":190,"context_line":"        CEPH_MIN_CLIENT_VERSION: \"mimic\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7d1c4f59_967119a1","line":187,"range":{"start_line":187,"start_character":30,"end_line":187,"end_character":70},"in_reply_to":"dd179317_21ce95c7","updated":"2024-08-16 06:39:37.000000000","message":"Done","commit_id":"a4f15416882111e4aec7eb981a2e12a10d36b748"}],"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"35b0713ecb9a36c478396e1703a64c7a9b17fad7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fe42984a_c347cc14","line":16,"updated":"2024-08-15 21:10:34.000000000","message":"I think this needs to be more specific.  Something like:\n\nSkip image format detection tests for compute\n\nThe ImagesFormatTest was added to tempest to check that nova is correctly rejecting possibly malicious images.  In the cinder-plugin-ceph-tempest job, however, openstack is configured with an optimized storage path and hence nova doesn\u0027t examine the image (as it would do in the \"normal\" path), and the expected exceptions are not raised, leading to test failures.  So configure the cinder-plugin-ceph-tempest job to skip these tests until the nova team figures out how to handle this.\n\nThis patch is based on https://review.opendev.org/c/openstack/nova/+/926215","commit_id":"a4f15416882111e4aec7eb981a2e12a10d36b748"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"35b0713ecb9a36c478396e1703a64c7a9b17fad7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"33ea3841_7bcd3b30","updated":"2024-08-15 21:10:34.000000000","message":"Thanks for proposing this, Tobias!  See comments inline.  Raising the priority on this given that the cinder-plugin-ceph-tempest job has been failing since 2024-08-13 03:15:55","commit_id":"a4f15416882111e4aec7eb981a2e12a10d36b748"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d6ba6954ebee52a2d635373e2a17c008a908967c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"afd4116c_61a3a0e1","updated":"2024-08-16 14:33:32.000000000","message":"Makes sense to me, thanks for the quick revision.","commit_id":"c947967edf4e3240cdff9322623e46181da0c06e"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"d1d865f89e942dad363f8a014f1d34ac3cc9642e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"46b6c24e_5930ef16","updated":"2024-08-20 19:04:26.000000000","message":"Shouldn\u0027t we have set CONF.image.images_manifest_file to an empty/None value?","commit_id":"c947967edf4e3240cdff9322623e46181da0c06e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e73fb96915b4a647a19e3a9028a2457573c7d65f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"844adb22_e8718468","updated":"2024-08-16 14:37:46.000000000","message":"These are nova \u003c-\u003e glance tests so no issues skipping them here. LGTM.","commit_id":"c947967edf4e3240cdff9322623e46181da0c06e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a184c65e65b85de6065f8a15c37fd997faa07db0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4e1fb771_b23671bc","updated":"2024-08-16 11:20:58.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican - tempest.api.volume.test_volumes_actions.VolumesActionsTest.test_volume_upload - image disappeared","commit_id":"c947967edf4e3240cdff9322623e46181da0c06e"}]}
