)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"28fbea5299a453bc55d0ed98673c562a81c8c80d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0f047015_7238dfdc","line":37,"updated":"2024-08-20 10:15:51.000000000","message":"it is missing the cherry picked from commit d04db6fe8874525a34e44c63b4c7a81c468c7ef9 line","commit_id":"83399aceb0025b12baa0bcd82f04706cbda8d18c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"28fbea5299a453bc55d0ed98673c562a81c8c80d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7b29a76f_bd872bfe","updated":"2024-08-20 10:15:51.000000000","message":"the commit message is missing one line but I won\u0027t block the backport for it. code looks okay, my concerns can be addressed by replies, clean cherry pick to 2024.1. LGTM.","commit_id":"83399aceb0025b12baa0bcd82f04706cbda8d18c"}],"cinder/volume/drivers/hitachi/hbsd_common.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f76e516b79ac724d789cd6f46c8103a82c4c22b5","unresolved":true,"context_lines":[{"line_number":440,"context_line":"        return (\u0027label\u0027 in ldev_info"},{"line_number":441,"context_line":"                and _UUID_PATTERN.match(ldev_info[\u0027label\u0027])"},{"line_number":442,"context_line":"                and ldev_info[\u0027label\u0027] !\u003d ("},{"line_number":443,"context_line":"                    obj.name_id if hasattr(obj, \u0027name_id\u0027) else"},{"line_number":444,"context_line":"                    obj.id).replace(\u0027-\u0027, \u0027\u0027))"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"    def delete_volume(self, volume):"}],"source_content_type":"text/x-python","patch_set":1,"id":"0796fb84_157578a0","line":443,"range":{"start_line":443,"start_character":20,"end_line":443,"end_character":31},"updated":"2024-08-20 10:01:03.000000000","message":"does the name_id never contain dashes? it would\u0027ve been safe to do the replace here as well if any such case exists.","commit_id":"83399aceb0025b12baa0bcd82f04706cbda8d18c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f76e516b79ac724d789cd6f46c8103a82c4c22b5","unresolved":true,"context_lines":[{"line_number":441,"context_line":"                and _UUID_PATTERN.match(ldev_info[\u0027label\u0027])"},{"line_number":442,"context_line":"                and ldev_info[\u0027label\u0027] !\u003d ("},{"line_number":443,"context_line":"                    obj.name_id if hasattr(obj, \u0027name_id\u0027) else"},{"line_number":444,"context_line":"                    obj.id).replace(\u0027-\u0027, \u0027\u0027))"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"    def delete_volume(self, volume):"},{"line_number":447,"context_line":"        \"\"\"Delete the specified volume.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"537552e3_6a47ef38","line":444,"range":{"start_line":444,"start_character":28,"end_line":444,"end_character":44},"updated":"2024-08-20 10:01:03.000000000","message":"looks like this is done to support legacy snapshots since in new snapshots, we are doing this replacement during snap creation time","commit_id":"83399aceb0025b12baa0bcd82f04706cbda8d18c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f76e516b79ac724d789cd6f46c8103a82c4c22b5","unresolved":true,"context_lines":[{"line_number":1178,"context_line":"        return False"},{"line_number":1179,"context_line":""},{"line_number":1180,"context_line":"    def update_migrated_volume(self, new_volume):"},{"line_number":1181,"context_line":"        \"\"\"Return model update for migrated volume.\"\"\""},{"line_number":1182,"context_line":"        return {\u0027_name_id\u0027: new_volume.name_id,"},{"line_number":1183,"context_line":"                \u0027provider_location\u0027: new_volume.provider_location}"},{"line_number":1184,"context_line":""},{"line_number":1185,"context_line":"    def retype(self, ctxt, volume, new_type, diff, host):"},{"line_number":1186,"context_line":"        \"\"\"Retype the specified volume.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"6e16f873_744954b3","line":1183,"range":{"start_line":1181,"start_character":8,"end_line":1183,"end_character":66},"updated":"2024-08-20 10:01:03.000000000","message":"why we don\u0027t require to modify the ldev name now during migration?\nAlso this is already done by the generic implementation so why do we need to repeat it here? https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L4393-L4395","commit_id":"83399aceb0025b12baa0bcd82f04706cbda8d18c"}]}