)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3859d25c737bb3b6b98a6128e016adad353a46e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e23360ab_675f1c78","updated":"2024-11-15 17:02:19.000000000","message":"I guess we can do this, but I think the point of the TODO was to remove psutil as a cinder requirement.  I did that with https://review.opendev.org/c/openstack/cinder/+/916154 , but that patch hasn\u0027t gotten much attention.","commit_id":"ff242fdff1c27488928c3e111b1cbc1b36f04711"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8cdb24e4e14bbf47d792693e8523d803529822cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"49d410c4_9e332fad","updated":"2024-11-15 10:14:16.000000000","message":"LGTM","commit_id":"ff242fdff1c27488928c3e111b1cbc1b36f04711"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"157aa9c6daa3aa72c3fec517357d443aeb14c452","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5881341c_a02a3275","updated":"2024-11-20 13:09:43.000000000","message":"we should abandon this in favor of https://review.opendev.org/c/openstack/cinder/+/916154","commit_id":"ff242fdff1c27488928c3e111b1cbc1b36f04711"}],"cinder/image/image_utils.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8cdb24e4e14bbf47d792693e8523d803529822cc","unresolved":true,"context_lines":[{"line_number":1176,"context_line":"    if not os.path.isdir(dest):"},{"line_number":1177,"context_line":"        dest \u003d os.path.dirname(dest)"},{"line_number":1178,"context_line":""},{"line_number":1179,"context_line":"    free_space \u003d shutil.disk_usage(dest).free"},{"line_number":1180,"context_line":"    if free_space \u003c\u003d image_size:"},{"line_number":1181,"context_line":"        msg \u003d (\u0027There is no space on %(dest_dir)s to convert image. \u0027"},{"line_number":1182,"context_line":"               \u0027Requested: %(image_size)s, available: %(free_space)s.\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9d296a55_b600fc43","line":1179,"range":{"start_line":1179,"start_character":17,"end_line":1179,"end_character":23},"updated":"2024-11-15 10:14:16.000000000","message":"shutil is preferred more for file/directory tasks so I\u0027m in favor of this change\nIt also has similar output (except the percent usage but we only care about free disk)\n\n    \u003e\u003e\u003e psutil.disk_usage(\u0027/opt/stack\u0027)\n    sdiskusage(total\u003d41429692416, used\u003d39899172864, free\u003d1513742336, percent\u003d96.3)\n\n    \u003e\u003e\u003e shutil.disk_usage(\u0027/opt/stack\u0027)\n    usage(total\u003d41429692416, used\u003d39899213824, free\u003d1513701376)","commit_id":"ff242fdff1c27488928c3e111b1cbc1b36f04711"}]}