)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36396,"name":"Bryan Neumann","display_name":"Bryan Neumann","email":"bryan.neumann@dell.com","username":"bryanneumann","status":"Dell"},"change_message_id":"7fa06d2444ed515f7d39cd218ee6d372279e332f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c9ef7f76_f62597f4","updated":"2024-09-03 14:31:29.000000000","message":"Looks good to me, but the openstack-tox-pep8 test failed.","commit_id":"efc1bb7573fa60d9e724a9a1bab33a09a2164550"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"7cbc480f5590de289b681d73c30156e9ed05cd92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0884d398_e5485f8e","updated":"2024-09-09 05:14:58.000000000","message":"Thanks Brian.\nI will update UT to cover additional test data.","commit_id":"a616479653951b216e68564ccc5a0ef568938d8b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0eed5c1d69f15a49bc36c3afe00c01edb2983033","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d396fb06_9eeb9331","updated":"2024-09-06 21:24:25.000000000","message":"Thanks for posting this.  Everything looks good, but I think you need to improve the test data a bit because your data doesn\u0027t address all the possible input formats.  Otherwise, this looks fine.","commit_id":"a616479653951b216e68564ccc5a0ef568938d8b"}],"cinder/tests/unit/volume/drivers/hpe/test_nimble.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0eed5c1d69f15a49bc36c3afe00c01edb2983033","unresolved":true,"context_lines":[{"line_number":1284,"context_line":"        time_secs \u003d [(\u002701:05\u0027, 3900), (\u002701:02:15am\u0027, 3735),"},{"line_number":1285,"context_line":"                     (\u002703:07:20pm\u0027, 54440), (\u002700:00:00\u0027, 0),"},{"line_number":1286,"context_line":"                     (\u002712:59:59pm\u0027, 46799), (\u002723:59:59\u0027, 86399),"},{"line_number":1287,"context_line":"                     (\u002714:12\u0027, 51120)]"},{"line_number":1288,"context_line":"        for time, seconds in time_secs:"},{"line_number":1289,"context_line":"            ret_secs \u003d self.driver._time_to_secs(time)"},{"line_number":1290,"context_line":"            self.assertEqual(ret_secs, seconds)"}],"source_content_type":"text/x-python","patch_set":4,"id":"2f440d31_07808bfc","line":1287,"updated":"2024-09-06 21:24:25.000000000","message":"This is better, but you\u0027re not testing am/pm with minutes only, which your comment in the function says is possible.  Make sure you test at least the base stuff:\n\n```\nhh:mm\nhh:mmam\nhh:mmpm\nHH:mm\nhh:mm:ss\nhh:mm:ssam\nhh:mm:sspm\nHH:mm:ss\n```\n\nand then you can throw in some edge cases to show off that your function works as expected.","commit_id":"a616479653951b216e68564ccc5a0ef568938d8b"}]}