)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"9d8999665afdd8a77ad3de3ca2ab1301d930955a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"428edd95_023298f6","updated":"2024-09-10 16:59:57.000000000","message":"recheck instance timeout crash cirros","commit_id":"a575caa56703f38e4b5a9f59ca2d1e224245242f"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"3ed3268685bf4548e1168575d73d0f749cd363e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9fea7c89_6634fd69","updated":"2025-04-14 06:35:42.000000000","message":"I will rework this patch to be added on the backup volume summary so that we introduce both changes in a new microversion.","commit_id":"38d9005b74cd456d9c7b93428fbe08f821a4e833"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"1f8feb070619178c19fd9397c42b052ac4fe2633","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ff4ab801_7545445c","updated":"2025-02-12 10:34:17.000000000","message":"LGTM","commit_id":"38d9005b74cd456d9c7b93428fbe08f821a4e833"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7101cc237b19e6f162953ac3a231961e5a581a70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5e1f4850_4974a7b7","updated":"2025-04-11 14:56:13.000000000","message":"also requires a releasenote for the bug","commit_id":"38d9005b74cd456d9c7b93428fbe08f821a4e833"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e0f4c54103a8246e9e0655d77d53c3e65cb3142b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"32738f58_99e921bb","updated":"2025-04-11 14:48:01.000000000","message":"one concern inline otherwise looks good","commit_id":"38d9005b74cd456d9c7b93428fbe08f821a4e833"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"8111635dae874d077e7121cababeecd330528e51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"baa5eb8c_be67d884","updated":"2024-09-10 22:20:10.000000000","message":"recheck dependency changed","commit_id":"38d9005b74cd456d9c7b93428fbe08f821a4e833"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"9f80b535416a8b7c2b1de7100a4350bb94681b10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7087a6db_341bb923","updated":"2024-09-11 07:22:27.000000000","message":"recheck timeout test_resize_volume_backed_server_confirm","commit_id":"38d9005b74cd456d9c7b93428fbe08f821a4e833"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"cdf7c5a80f237d07adc26a3983d7c32d7ca6d227","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"e13c1045_c7179cc3","updated":"2025-04-15 12:28:52.000000000","message":"recheck tempest-integrated-storage timeout","commit_id":"b1c4e9b6634a155062d6c6aeb0d4ed52902ce7e0"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"88675d93dd002fbfd644d441c3ef371813685f88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"38478951_da9d59a1","updated":"2025-04-15 09:18:36.000000000","message":"recheck transient tempest.exceptions.VolumeResourceBuildErrorException: volume a8875ffd-33e0-4191-912a-f9041d509478 failed to build and is in ERROR status causing post_failure for job","commit_id":"b1c4e9b6634a155062d6c6aeb0d4ed52902ce7e0"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"ddceaa254ca565b19d0470f76484bda858e89224","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e0aca9df_a9eed6f5","updated":"2025-10-22 23:46:14.000000000","message":"I\u0027m in agreement that a 400 is better than a 500 re: the exception comment.\n\nOne small nitpick from me, but this patch otherwise looks good.","commit_id":"ed2270aba02f340e92178ab022d7399784512930"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"727ee7dfd50e2c3294860a7bb4c01a44810fa1c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"97df70d1_f2614e3f","updated":"2026-01-12 20:15:32.000000000","message":"LGTM","commit_id":"4212b075ef135d7cfe6f4a592be015eb7de3b13f"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"d82fab4e67d2766b365405e279d2ff39410aa329","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"4631d4aa_1dba552e","updated":"2026-02-19 08:54:47.000000000","message":"run-Quobyte CI","commit_id":"aa0bc3a1cdd2ce5671c25f2bf76bd236efc15649"}],"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e0f4c54103a8246e9e0655d77d53c3e65cb3142b","unresolved":true,"context_lines":[{"line_number":2781,"context_line":"        query \u003d _process_volume_filters(query, filters)"},{"line_number":2782,"context_line":""},{"line_number":2783,"context_line":"    if query is None:"},{"line_number":2784,"context_line":"        raise exception.Invalid()"},{"line_number":2785,"context_line":""},{"line_number":2786,"context_line":"    result \u003d query.first()"},{"line_number":2787,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"b35dc53c_eacf2475","line":2784,"range":{"start_line":2784,"start_character":8,"end_line":2784,"end_character":20},"updated":"2025-04-11 14:48:01.000000000","message":"Why do we want to raise here? The query value shouldn\u0027t be None but raising in a GET API would be pretty bad response for the user instead of returning an empty response.\nThe user can\u0027t do anything anyway if the query value turns out to be None.\nSo either, 1. remove this query check or 2. not raise here","commit_id":"38d9005b74cd456d9c7b93428fbe08f821a4e833"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"d01b53e7f2a5ac4f612c3b7ce97ccad9b166ff6e","unresolved":false,"context_lines":[{"line_number":2781,"context_line":"        query \u003d _process_volume_filters(query, filters)"},{"line_number":2782,"context_line":""},{"line_number":2783,"context_line":"    if query is None:"},{"line_number":2784,"context_line":"        raise exception.Invalid()"},{"line_number":2785,"context_line":""},{"line_number":2786,"context_line":"    result \u003d query.first()"},{"line_number":2787,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ca32ed4a_1515a494","line":2784,"range":{"start_line":2784,"start_character":8,"end_line":2784,"end_character":20},"in_reply_to":"b250c8c3_487305b5","updated":"2025-10-23 08:08:44.000000000","message":"Marking as resolved.","commit_id":"38d9005b74cd456d9c7b93428fbe08f821a4e833"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"f7837e084705cb9a0517c0e140b563f99811c8c0","unresolved":true,"context_lines":[{"line_number":2781,"context_line":"        query \u003d _process_volume_filters(query, filters)"},{"line_number":2782,"context_line":""},{"line_number":2783,"context_line":"    if query is None:"},{"line_number":2784,"context_line":"        raise exception.Invalid()"},{"line_number":2785,"context_line":""},{"line_number":2786,"context_line":"    result \u003d query.first()"},{"line_number":2787,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"b250c8c3_487305b5","line":2784,"range":{"start_line":2784,"start_character":8,"end_line":2784,"end_character":20},"in_reply_to":"b35dc53c_eacf2475","updated":"2025-04-14 06:32:53.000000000","message":"The ``_process_volume_filters()`` function returns None when passing an invalid filter thus setting ``query`` to None and we return an empty list, but that return value is invalid because in cinder/api/v3/volumes.py we expect a 3-value tuple and we error with a HTTP 500.\n\nThis instead, when a filter is invalid, raises an Invalid exception that causes the HTTP response to be HTTP 400 bad request instead when the filter is invalid.","commit_id":"38d9005b74cd456d9c7b93428fbe08f821a4e833"}],"cinder/volume/api.py":[{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"ddceaa254ca565b19d0470f76484bda858e89224","unresolved":true,"context_lines":[{"line_number":685,"context_line":"            self,"},{"line_number":686,"context_line":"            context: context.RequestContext,"},{"line_number":687,"context_line":"            filters: Optional[dict] \u003d None,"},{"line_number":688,"context_line":"            apply_filters: Optional[bool] \u003d False) -\u003e objects.VolumeList:"},{"line_number":689,"context_line":"        context.authorize(vol_policy.GET_ALL_POLICY)"},{"line_number":690,"context_line":""},{"line_number":691,"context_line":"        if filters is None:"}],"source_content_type":"text/x-python","patch_set":10,"id":"0473ef6f_538ab836","line":688,"updated":"2025-10-22 23:46:14.000000000","message":"Any reason why this defaults to false here, but in other places defaults to true? (api.py, volume.py) \n\nI\u0027m only commenting here as it\u0027s inconsistent, but maybe there\u0027s a reason for that.","commit_id":"ed2270aba02f340e92178ab022d7399784512930"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"8a5bda8c04218533e65384c9cc30ddfeafc0a330","unresolved":false,"context_lines":[{"line_number":685,"context_line":"            self,"},{"line_number":686,"context_line":"            context: context.RequestContext,"},{"line_number":687,"context_line":"            filters: Optional[dict] \u003d None,"},{"line_number":688,"context_line":"            apply_filters: Optional[bool] \u003d False) -\u003e objects.VolumeList:"},{"line_number":689,"context_line":"        context.authorize(vol_policy.GET_ALL_POLICY)"},{"line_number":690,"context_line":""},{"line_number":691,"context_line":"        if filters is None:"}],"source_content_type":"text/x-python","patch_set":10,"id":"d4f1e604_8d4e3d22","line":688,"in_reply_to":"0473ef6f_538ab836","updated":"2025-10-23 08:04:10.000000000","message":"Thanks for the review, if I recall correctly this is to not change the behaviour of the v2 API (which I don\u0027t we expose anymore?) and always pass apply_filters\u003dTrue in the v3 API if the microversion is \u003e\u003d the version this is changed in. So it looks like an inconsistency but is intentional IIRC.","commit_id":"ed2270aba02f340e92178ab022d7399784512930"}]}