)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":35429,"name":"Biser Milanov","email":"biser.milanov@storpool.com","username":"sp-bmilanov"},"change_message_id":"de47a3f7b8c489ca28b3c1d2bc359d00ffb3ab5f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This provides new API endpoints to interact with the volume type"},{"line_number":10,"context_line":"metadata."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: I9d1c75d25c2daac74d1e4f75d9e7cc96cbe56f66"},{"line_number":13,"context_line":"Change-Id: I99fc56a1f7a5af38714a6818a756d5ee44fbe85d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5e400db1_f1270d8d","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":53},"updated":"2024-10-15 11:45:15.000000000","message":"Nit: I am not sure if this `Depends-On` is required since the change ID is for the commit directly below this one in the relation chain.","commit_id":"7e39ca5b62883d749e3d5e1660de8c3028e182e5"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"19dea73bf54227fb0550a99961dde6a25051197b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":19,"id":"900704f0_85d2dc02","line":14,"updated":"2024-12-18 03:48:51.000000000","message":"I think it is worth adding Partial-Implements or Implements to refer to the blueprint this patch aims to implement.\n\nPartial-Implements: blueprint user-visible-information-in-volume-types","commit_id":"6f0e4c9ae834a51e1e88baec3b817e189131d446"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"19dea73bf54227fb0550a99961dde6a25051197b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"5645b15b_e8256f90","updated":"2024-12-18 03:48:51.000000000","message":"Hi Josephine! Thanks for working on this feature. It will take some time for me to go through all code changes but there are already a few things I would like to suggest. Please let me know if they make sense to you.","commit_id":"6f0e4c9ae834a51e1e88baec3b817e189131d446"}],"cinder/api/openstack/rest_api_version_history.rst":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"50139d0a082cd20f25a85e5bfaffe945c44ce333","unresolved":true,"context_lines":[{"line_number":542,"context_line":"to notify Cinder of success and error when handling a ``volume-extended``"},{"line_number":543,"context_line":"external server event."},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"3.71"},{"line_number":546,"context_line":"----"},{"line_number":547,"context_line":"Add a new metadata property to volume types. This has the following"},{"line_number":548,"context_line":"implications:"}],"source_content_type":"text/x-rst","patch_set":19,"id":"71245de8_ccfb2e70","line":545,"updated":"2024-12-18 05:42:14.000000000","message":"This should be 3.72","commit_id":"6f0e4c9ae834a51e1e88baec3b817e189131d446"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"50139d0a082cd20f25a85e5bfaffe945c44ce333","unresolved":true,"context_lines":[{"line_number":552,"context_line":"- A new API endpoint to delete a metadata key value pair is added:"},{"line_number":553,"context_line":"  ``/types/%s/metadata/%s``."},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"- API calls to create and update volume types have been updated to"},{"line_number":556,"context_line":"  also set the new ``metadata`` property."},{"line_number":557,"context_line":"- responses from API calls to create, update, show and list volume types have"},{"line_number":558,"context_line":"  been updated to integrate the new ``metadata`` property."}],"source_content_type":"text/x-rst","patch_set":19,"id":"034bdf34_b2da761b","line":555,"updated":"2024-12-18 05:42:14.000000000","message":"Please correct me if I\u0027m wrong but I believe setting metadata keys/values on volume type creation would require changing `cinder/api/contrib/types_manage.py` and `cinder/volume/volume_types.py` to process the metadata field from the request\u0027s body. Also the database API calls in `cinder/db/sqlalchemy/api.py` would need to be updated.","commit_id":"6f0e4c9ae834a51e1e88baec3b817e189131d446"},{"author":{"_account_id":28271,"name":"Josephine Seifert","email":"josephine.seifert@cloudandheat.com","username":"josei"},"change_message_id":"3372c9f853e6a90c5f97abf4188b1b69db55aa1e","unresolved":true,"context_lines":[{"line_number":552,"context_line":"- A new API endpoint to delete a metadata key value pair is added:"},{"line_number":553,"context_line":"  ``/types/%s/metadata/%s``."},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"- API calls to create and update volume types have been updated to"},{"line_number":556,"context_line":"  also set the new ``metadata`` property."},{"line_number":557,"context_line":"- responses from API calls to create, update, show and list volume types have"},{"line_number":558,"context_line":"  been updated to integrate the new ``metadata`` property."}],"source_content_type":"text/x-rst","patch_set":19,"id":"9acf7b92_0dada722","line":555,"in_reply_to":"034bdf34_b2da761b","updated":"2025-01-15 14:03:04.000000000","message":"You might be right. I tested the workflow only with the python-openstackclient, and it seems, that you can have one command there (`openstack volume type create --metadata ... TYPE-NAME`), but the metadata is added after the creation of the volume type in form of an update.\n\nUnfortunately I do not have time anymore to implement the way to have both done in the volume type create API request. :(","commit_id":"6f0e4c9ae834a51e1e88baec3b817e189131d446"}],"cinder/api/schemas/volume_types_metadata.py":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"84dd8e668ee2e47f9710dcf1c96eb07918cf2560","unresolved":true,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"\"\"\""},{"line_number":16,"context_line":"Schema for V3 types_extra_specs API."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"56e6aa13_9c839637","line":16,"updated":"2024-12-18 06:31:12.000000000","message":"s/types_extra_specs/volume_types_metadata/","commit_id":"6f0e4c9ae834a51e1e88baec3b817e189131d446"}],"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"19dea73bf54227fb0550a99961dde6a25051197b","unresolved":true,"context_lines":[{"line_number":3742,"context_line":"@handle_db_data_error"},{"line_number":3743,"context_line":"@main_context_manager.writer"},{"line_number":3744,"context_line":"def snapshot_create(context, values):"},{"line_number":3745,"context_line":"    values[\u0027snapshot_metadata\u0027] \u003d _metadata_refs("},{"line_number":3746,"context_line":"        values.get(\u0027metadata\u0027), models.SnapshotMetadata"},{"line_number":3747,"context_line":"    )"},{"line_number":3748,"context_line":"    if not values.get(\u0027id\u0027):"}],"source_content_type":"text/x-python","patch_set":19,"id":"73cb0e25_38b968e7","line":3745,"updated":"2024-12-18 03:48:51.000000000","message":"snapshot_create allows setting metadata on creation. I think it worth doing the same for volume types in sake of API consistency.\n\nIf I got it right, the possibility of setting metadata keys/values on volume type creation was mentioned in the spec [1].\n\n[1] https://review.opendev.org/c/openstack/cinder-specs/+/909195/11/specs/2024.2/user-visible-information-in-volume-types.rst#166","commit_id":"6f0e4c9ae834a51e1e88baec3b817e189131d446"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"19dea73bf54227fb0550a99961dde6a25051197b","unresolved":true,"context_lines":[{"line_number":4342,"context_line":"        pass"},{"line_number":4343,"context_line":""},{"line_number":4344,"context_line":"    try:"},{"line_number":4345,"context_line":"        values[\u0027extra_specs\u0027] \u003d _metadata_refs("},{"line_number":4346,"context_line":"            values.get(\u0027extra_specs\u0027),"},{"line_number":4347,"context_line":"            models.VolumeTypeExtraSpecs,"},{"line_number":4348,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":19,"id":"03254a87_b59c73c2","line":4345,"updated":"2024-12-18 03:48:51.000000000","message":"Considering extra_specs can be defined at volume type creation, wouldn\u0027t it worth adding the possibility to add volume_type_metadata entries as well? Other models such as Snapshots also allow setting metadata keys/values on creation so I believe adding the same possibility will contribute to maintain API calls consistent.\n\nIf I got it right, the possibility of setting metadata keys/values on volume type creation was mentioned in the spec [1].\n\n[1] https://review.opendev.org/c/openstack/cinder-specs/+/909195/11/specs/2024.2/user-visible-information-in-volume-types.rst#166","commit_id":"6f0e4c9ae834a51e1e88baec3b817e189131d446"}]}