)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f76370f1b330114e6389a31ebc7a27e127d1b156","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"31a4a70b_fd8f8f66","updated":"2024-10-16 19:47:32.000000000","message":"LGTM.","commit_id":"4aa75984cc5aecdaec0f7c818a4ffdfd0b25bd40"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"91bc22fbd15173aefe1200fd6af13b79ceb5be11","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"45c72b3f_ef6a3609","updated":"2024-10-16 12:53:25.000000000","message":"Maybe I\u0027m not testing this correctly, but I took an un-patched master, applied the change in cinder/texts/fixtures.py to it, and ran\n\n``tox -e py311 -- cinder.volume.drivers``\n\nand everything passed.  My understanding is that the \u0027fake_volume_id\u0027 fields in the powerstore and dataontap tests should have caused failures.  Or am I misunderstanding what this patch is doing?","commit_id":"4aa75984cc5aecdaec0f7c818a4ffdfd0b25bd40"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7955c888d6a2a0558ce8bbe03299a0e0ea8678b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1e48ce7b_f0149cf4","updated":"2025-07-22 02:39:32.000000000","message":"recheck","commit_id":"4aa75984cc5aecdaec0f7c818a4ffdfd0b25bd40"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4d9be4532267e9f5ad83b600254291ad0dcd318c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"766c7b5d_31494123","updated":"2025-09-06 12:35:11.000000000","message":"recheck","commit_id":"4aa75984cc5aecdaec0f7c818a4ffdfd0b25bd40"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"dc0867d682d8d5f38a718ad7f8afd55ee15f0c3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"edf67a30_165c8277","updated":"2025-07-31 02:34:46.000000000","message":"recheck","commit_id":"4aa75984cc5aecdaec0f7c818a4ffdfd0b25bd40"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"599c9396cd70fa291abe2f6c070e9ca29863c216","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f6a2a691_730639a9","updated":"2025-09-07 02:50:10.000000000","message":"recheck","commit_id":"4aa75984cc5aecdaec0f7c818a4ffdfd0b25bd40"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c4a2261cb7e3d47b595329a4550746da3eccc664","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ce49edb2_52c8608e","updated":"2025-07-31 12:01:35.000000000","message":"recheck This change does not touch tempest tests...","commit_id":"4aa75984cc5aecdaec0f7c818a4ffdfd0b25bd40"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"06579c2544594af29a14ab9445063ede644807f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e3557473_fc0a0e5e","updated":"2025-07-24 14:48:38.000000000","message":"recheck the failing jobs are all unrelated.","commit_id":"4aa75984cc5aecdaec0f7c818a4ffdfd0b25bd40"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e330b284376b32dbabb4229ec0bcfa01e09fc6bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cd47454b_bae1a71d","updated":"2025-07-20 15:53:16.000000000","message":"recheck to get fresh result with this rebased on current master","commit_id":"4aa75984cc5aecdaec0f7c818a4ffdfd0b25bd40"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6733b9db173c252ccad0784c88fa4fb0699457f5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4d5317ac_32606bd6","in_reply_to":"45c72b3f_ef6a3609","updated":"2024-10-16 13:04:44.000000000","message":"The command may run no tests because it does not match with any test code. Can you try this ?\n\n```\ntox -e py311 -- cinder.tests.unit.volume.drivers\n```\n\nI run unit tests with the only fixture change applied\n```\n$ git diff\ndiff --git a/cinder/tests/fixtures.py b/cinder/tests/fixtures.py\nindex 4221d6931..0e5eb57a6 100644\n--- a/cinder/tests/fixtures.py\n+++ b/cinder/tests/fixtures.py\n@@ -133,6 +133,11 @@ class WarningsFixture(fixtures.Fixture):\n         # this.\n         warnings.simplefilter(\u0027once\u0027, DeprecationWarning)\n \n+        # The UUIDFields emits a warning if the value is not a valid UUID.\n+        # Let\u0027s escalate that to an exception in the test to prevent adding\n+        # violations.\n+        warnings.filterwarnings(\u0027error\u0027, message\u003d\u0027.*invalid UUID.*\u0027)\n+\n         # NOTE(sdague): this remains an unresolved item around the way\n         # forward on is_admin, the deprecation is definitely really premature.\n         warnings.filterwarnings(\n```\n\nand see some tests actually fail.\n```\n\u003d\u003d\u003d\u003d\u003d\u003d\nTotals\n\u003d\u003d\u003d\u003d\u003d\u003d\nRan: 9623 tests in 148.1073 sec.\n - Passed: 9602\n - Skipped: 3\n - Expected Fail: 0\n - Unexpected Success: 0\n - Failed: 18\nSum of execute time for each test: 1562.6746 sec.\n```","commit_id":"4aa75984cc5aecdaec0f7c818a4ffdfd0b25bd40"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f76370f1b330114e6389a31ebc7a27e127d1b156","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dc690436_f707b682","in_reply_to":"4d5317ac_32606bd6","updated":"2024-10-16 19:47:32.000000000","message":"You are correct. That was an embarrassing mistake!  Works as expected when you run it correctly.","commit_id":"4aa75984cc5aecdaec0f7c818a4ffdfd0b25bd40"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"244a35d02ddbb50f12aee065e3fb6adcad3179a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a2854603_7e407773","in_reply_to":"dc690436_f707b682","updated":"2024-10-17 01:06:27.000000000","message":"np. Thanks for checking it :-D","commit_id":"4aa75984cc5aecdaec0f7c818a4ffdfd0b25bd40"}]}
