)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"fd26e4e7c50ffb8c4c1a49926f26ecc22f698b9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"13fce2de_b1c40bce","updated":"2024-09-26 09:37:58.000000000","message":"Unit test code can be added","commit_id":"f59eb8dc3acadcf2b6e83fad22eff5356e5dcbf7"},{"author":{"_account_id":36003,"name":"Amar Rajeev","display_name":"amar_rajeev","email":"Amar.Rajeev.Singuluri1@partner.ibm.com","username":"amar_rajeev"},"change_message_id":"e641269d8860307158464e2c5aebe91aad3fb595","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1756730d_0786a2a2","updated":"2024-10-23 05:40:54.000000000","message":"Hi @harsh.ailani@ibm.com\nPlease compare the comments addressed on https://review.opendev.org/c/openstack/cinder/+/926844/3.\nand make the changes over here as well","commit_id":"b7fec2f56660357b9596c4fb3da8b679b23d4a28"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"72a35c2af37545891522661d9612cdd22b8d8c49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ec37c753_5703c0db","in_reply_to":"1756730d_0786a2a2","updated":"2025-01-09 09:25:02.000000000","message":"Resolved.","commit_id":"b7fec2f56660357b9596c4fb3da8b679b23d4a28"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"bdae1432d3b711af2b7ab9f2c8c40219d7c40da7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"2eb5cc21_32f7c94c","updated":"2025-01-03 12:09:10.000000000","message":"recheck","commit_id":"14663910aaa8968e2cb389bb74582be4f86111dd"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"5cec534ec419bb2ac2c72e4d8360ad1d6fcf2b97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"4cbd83f3_8d67a0b7","updated":"2025-01-02 17:51:07.000000000","message":"recheck","commit_id":"14663910aaa8968e2cb389bb74582be4f86111dd"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"fd26e4e7c50ffb8c4c1a49926f26ecc22f698b9f","unresolved":true,"context_lines":[{"line_number":2390,"context_line":"            volumes_model_update \u003d self._get_volume_model_updates("},{"line_number":2391,"context_line":"                ctxt, targets, group[\u0027id\u0027], model_update[\u0027status\u0027])"},{"line_number":2392,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":2393,"context_line":"                LOG.error(\"Failed to create clone volumegroup.\""},{"line_number":2394,"context_line":"                          \"Exception: %s\", err)"},{"line_number":2395,"context_line":""},{"line_number":2396,"context_line":"        LOG.debug(\u0027Leave: create_volumegroup_from_source.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"2ffc44d8_7838deed","line":2393,"range":{"start_line":2393,"start_character":61,"end_line":2393,"end_character":63},"updated":"2024-09-26 09:37:58.000000000","message":"nit: space can be added after full stop","commit_id":"f59eb8dc3acadcf2b6e83fad22eff5356e5dcbf7"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"475eb2a402c166c754993228d6b8df2d7bbbbbdb","unresolved":false,"context_lines":[{"line_number":2390,"context_line":"            volumes_model_update \u003d self._get_volume_model_updates("},{"line_number":2391,"context_line":"                ctxt, targets, group[\u0027id\u0027], model_update[\u0027status\u0027])"},{"line_number":2392,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":2393,"context_line":"                LOG.error(\"Failed to create clone volumegroup.\""},{"line_number":2394,"context_line":"                          \"Exception: %s\", err)"},{"line_number":2395,"context_line":""},{"line_number":2396,"context_line":"        LOG.debug(\u0027Leave: create_volumegroup_from_source.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ce1c70c3_e65f64a7","line":2393,"range":{"start_line":2393,"start_character":61,"end_line":2393,"end_character":63},"in_reply_to":"2ffc44d8_7838deed","updated":"2024-09-30 16:10:29.000000000","message":"Acknowledged","commit_id":"f59eb8dc3acadcf2b6e83fad22eff5356e5dcbf7"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"7f8b1a23106570873651c515f731479d7ddc18a2","unresolved":true,"context_lines":[{"line_number":2393,"context_line":""},{"line_number":2394,"context_line":"            # Update SVC name for the corresponding clone volume in cinder DB"},{"line_number":2395,"context_line":"            svc_clone_volumes \u003d ("},{"line_number":2396,"context_line":"                self.get_volumes_in_volumegroup(clone_volumegroup_name))"},{"line_number":2397,"context_line":"            svc_clone_volumes_names \u003d ("},{"line_number":2398,"context_line":"                [volume[\"name\"] for volume in svc_clone_volumes])"},{"line_number":2399,"context_line":"            for svc_clone_volume_name in svc_clone_volumes_names:"}],"source_content_type":"text/x-python","patch_set":8,"id":"bc3b020a_66e26444","line":2396,"updated":"2024-11-14 05:11:25.000000000","message":"when we pass list_of_source_volumes we don\u0027t have to fetch the volumes from volume group","commit_id":"9df6d1d179bd5117cf1a796559a405a1bb097814"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"72a35c2af37545891522661d9612cdd22b8d8c49","unresolved":false,"context_lines":[{"line_number":2393,"context_line":""},{"line_number":2394,"context_line":"            # Update SVC name for the corresponding clone volume in cinder DB"},{"line_number":2395,"context_line":"            svc_clone_volumes \u003d ("},{"line_number":2396,"context_line":"                self.get_volumes_in_volumegroup(clone_volumegroup_name))"},{"line_number":2397,"context_line":"            svc_clone_volumes_names \u003d ("},{"line_number":2398,"context_line":"                [volume[\"name\"] for volume in svc_clone_volumes])"},{"line_number":2399,"context_line":"            for svc_clone_volume_name in svc_clone_volumes_names:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3c3a8c99_6bfae26d","line":2396,"in_reply_to":"bc3b020a_66e26444","updated":"2025-01-09 09:25:02.000000000","message":"These are the clone volumes that are created on the SVC which have different name than the list_of_source_volumes that are passed to this method. Hence we need to fetch those clone volumes which have the suffix added to them for the corresponding volumegroup.","commit_id":"9df6d1d179bd5117cf1a796559a405a1bb097814"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"7f8b1a23106570873651c515f731479d7ddc18a2","unresolved":true,"context_lines":[{"line_number":2398,"context_line":"                [volume[\"name\"] for volume in svc_clone_volumes])"},{"line_number":2399,"context_line":"            for svc_clone_volume_name in svc_clone_volumes_names:"},{"line_number":2400,"context_line":"                for source_volume, cinder_clone_volume in ("},{"line_number":2401,"context_line":"                    zip(list_of_source_volumes, cinder_clone_volumes)):"},{"line_number":2402,"context_line":"                    if svc_clone_volume_name.rsplit(\"-\", 1)[0] \u003d\u003d source_volume:"},{"line_number":2403,"context_line":"                        cinder_clone_volume[\u0027provider_id\u0027] \u003d svc_clone_volume_name"},{"line_number":2404,"context_line":"                        break"}],"source_content_type":"text/x-python","patch_set":8,"id":"899830ea_0471a9e3","line":2401,"updated":"2024-11-14 05:11:25.000000000","message":"Not clear ?","commit_id":"9df6d1d179bd5117cf1a796559a405a1bb097814"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"72a35c2af37545891522661d9612cdd22b8d8c49","unresolved":false,"context_lines":[{"line_number":2398,"context_line":"                [volume[\"name\"] for volume in svc_clone_volumes])"},{"line_number":2399,"context_line":"            for svc_clone_volume_name in svc_clone_volumes_names:"},{"line_number":2400,"context_line":"                for source_volume, cinder_clone_volume in ("},{"line_number":2401,"context_line":"                    zip(list_of_source_volumes, cinder_clone_volumes)):"},{"line_number":2402,"context_line":"                    if svc_clone_volume_name.rsplit(\"-\", 1)[0] \u003d\u003d source_volume:"},{"line_number":2403,"context_line":"                        cinder_clone_volume[\u0027provider_id\u0027] \u003d svc_clone_volume_name"},{"line_number":2404,"context_line":"                        break"}],"source_content_type":"text/x-python","patch_set":8,"id":"d2865ba1_4c713337","line":2401,"in_reply_to":"899830ea_0471a9e3","updated":"2025-01-09 09:25:02.000000000","message":"These code block is to map the cinder clone volume object to the SVC clone volume object as SVC is adding a suffix to the name of the clone volume.\nSource vol \u003d volume-abcd\nCinder clone-vol \u003d volume-efgh\n\nSVC Source vol \u003d volume-abcd\nSVC Clone vol \u003d volume-abcd-0\n\nNeed to map Cinder clone-vol (volume-efgh) with SVC Clone vol (volume-abcd-0)\n\nHence we are using the \u0027provider_id\u0027 for this purpose.","commit_id":"9df6d1d179bd5117cf1a796559a405a1bb097814"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"7f8b1a23106570873651c515f731479d7ddc18a2","unresolved":true,"context_lines":[{"line_number":2400,"context_line":"                for source_volume, cinder_clone_volume in ("},{"line_number":2401,"context_line":"                    zip(list_of_source_volumes, cinder_clone_volumes)):"},{"line_number":2402,"context_line":"                    if svc_clone_volume_name.rsplit(\"-\", 1)[0] \u003d\u003d source_volume:"},{"line_number":2403,"context_line":"                        cinder_clone_volume[\u0027provider_id\u0027] \u003d svc_clone_volume_name"},{"line_number":2404,"context_line":"                        break"},{"line_number":2405,"context_line":""},{"line_number":2406,"context_line":"            # Incase of temporary_volumegroup type, we do not need"}],"source_content_type":"text/x-python","patch_set":8,"id":"371e8580_d64eb721","line":2403,"updated":"2024-11-14 05:11:25.000000000","message":"why do we need this","commit_id":"9df6d1d179bd5117cf1a796559a405a1bb097814"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"72a35c2af37545891522661d9612cdd22b8d8c49","unresolved":false,"context_lines":[{"line_number":2400,"context_line":"                for source_volume, cinder_clone_volume in ("},{"line_number":2401,"context_line":"                    zip(list_of_source_volumes, cinder_clone_volumes)):"},{"line_number":2402,"context_line":"                    if svc_clone_volume_name.rsplit(\"-\", 1)[0] \u003d\u003d source_volume:"},{"line_number":2403,"context_line":"                        cinder_clone_volume[\u0027provider_id\u0027] \u003d svc_clone_volume_name"},{"line_number":2404,"context_line":"                        break"},{"line_number":2405,"context_line":""},{"line_number":2406,"context_line":"            # Incase of temporary_volumegroup type, we do not need"}],"source_content_type":"text/x-python","patch_set":8,"id":"bdd601b4_c47186d7","line":2403,"in_reply_to":"371e8580_d64eb721","updated":"2025-01-09 09:25:02.000000000","message":"These code block is to map the cinder clone volume object to the SVC clone volume object as SVC is adding a suffix to the name of the clone volume.\nSource vol \u003d volume-abcd\nCinder clone-vol \u003d volume-efgh\n\nSVC Source vol \u003d volume-abcd\nSVC Clone vol \u003d volume-abcd-0\n\nNeed to map Cinder clone-vol (volume-efgh) with SVC Clone vol (volume-abcd-0)\n\nHence we are using the \u0027provider_id\u0027 for this purpose.","commit_id":"9df6d1d179bd5117cf1a796559a405a1bb097814"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"7f8b1a23106570873651c515f731479d7ddc18a2","unresolved":true,"context_lines":[{"line_number":6601,"context_line":"            if group_snapshot and snapshots:"},{"line_number":6602,"context_line":"                # Get the SVC ID of the source-volumegroup-snapshot"},{"line_number":6603,"context_line":"                source_volumegroup_snapshot_svc_id \u003d ("},{"line_number":6604,"context_line":"                    snapshots[0].metadata[\u0027svc_volumegroup_snapshot_id\u0027])"},{"line_number":6605,"context_line":""},{"line_number":6606,"context_line":"                # Get the list of source volumes that are part of"},{"line_number":6607,"context_line":"                # the source-volumegroup"}],"source_content_type":"text/x-python","patch_set":8,"id":"dbf14c16_6b9ccce0","line":6604,"updated":"2024-11-14 05:11:25.000000000","message":"In the case of group snapshots why do we need to fetch the information from one of the entry of snapshot metadata.","commit_id":"9df6d1d179bd5117cf1a796559a405a1bb097814"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"72a35c2af37545891522661d9612cdd22b8d8c49","unresolved":false,"context_lines":[{"line_number":6601,"context_line":"            if group_snapshot and snapshots:"},{"line_number":6602,"context_line":"                # Get the SVC ID of the source-volumegroup-snapshot"},{"line_number":6603,"context_line":"                source_volumegroup_snapshot_svc_id \u003d ("},{"line_number":6604,"context_line":"                    snapshots[0].metadata[\u0027svc_volumegroup_snapshot_id\u0027])"},{"line_number":6605,"context_line":""},{"line_number":6606,"context_line":"                # Get the list of source volumes that are part of"},{"line_number":6607,"context_line":"                # the source-volumegroup"}],"source_content_type":"text/x-python","patch_set":8,"id":"7c33a2a8_d33fb431","line":6604,"in_reply_to":"dbf14c16_6b9ccce0","updated":"2025-01-09 09:25:02.000000000","message":"Group_snapshot object doesn\u0027t have the metadata field in DB. Hence we are storing the svc_volumegroup_snapshot_id in the individual volume-snapshot object.","commit_id":"9df6d1d179bd5117cf1a796559a405a1bb097814"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"7f8b1a23106570873651c515f731479d7ddc18a2","unresolved":true,"context_lines":[{"line_number":6609,"context_line":"                    objects.VolumeList.get_all_by_generic_group(context,"},{"line_number":6610,"context_line":"                                                                group_snapshot.group_id))"},{"line_number":6611,"context_line":"                list_of_source_volumes \u003d ("},{"line_number":6612,"context_line":"                    [\u0027volume-\u0027 + str(volume.id) for volume in source_volumes])"},{"line_number":6613,"context_line":""},{"line_number":6614,"context_line":"                # Get the name of clone-volumegroup"},{"line_number":6615,"context_line":"                clone_volumegroup_name \u003d self._get_volumegroup_name(group)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7289410b_47465e37","line":6612,"updated":"2024-11-14 05:11:25.000000000","message":"We should not rely on source volume naming convention using this method. Rather use the volume[name] field.","commit_id":"9df6d1d179bd5117cf1a796559a405a1bb097814"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"72a35c2af37545891522661d9612cdd22b8d8c49","unresolved":false,"context_lines":[{"line_number":6609,"context_line":"                    objects.VolumeList.get_all_by_generic_group(context,"},{"line_number":6610,"context_line":"                                                                group_snapshot.group_id))"},{"line_number":6611,"context_line":"                list_of_source_volumes \u003d ("},{"line_number":6612,"context_line":"                    [\u0027volume-\u0027 + str(volume.id) for volume in source_volumes])"},{"line_number":6613,"context_line":""},{"line_number":6614,"context_line":"                # Get the name of clone-volumegroup"},{"line_number":6615,"context_line":"                clone_volumegroup_name \u003d self._get_volumegroup_name(group)"}],"source_content_type":"text/x-python","patch_set":8,"id":"73804a96_fc503b20","line":6612,"in_reply_to":"7289410b_47465e37","updated":"2025-01-09 09:25:02.000000000","message":"Reesolved.","commit_id":"9df6d1d179bd5117cf1a796559a405a1bb097814"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"7f8b1a23106570873651c515f731479d7ddc18a2","unresolved":true,"context_lines":[{"line_number":6771,"context_line":"        elif volume_utils.is_group_a_type("},{"line_number":6772,"context_line":"                group_snapshot, \"volume_group_enabled\"):"},{"line_number":6773,"context_line":"            try:"},{"line_number":6774,"context_line":"                self._helpers.check_codelevel_for_volumegroup("},{"line_number":6775,"context_line":"                    self._state[\u0027code_level\u0027])"},{"line_number":6776,"context_line":"                params \u003d dict()"},{"line_number":6777,"context_line":"                # Use group_snapshot id as volumegroup name"}],"source_content_type":"text/x-python","patch_set":8,"id":"174a549b_84d16fd0","line":6774,"updated":"2024-11-14 05:11:25.000000000","message":"We should do this check once in the cinder driver initialization, instead of making this call for each request.\n_state[\u0027volume_group_enabled\u0027] \u003d true and then just use that at all the places, instead of doing comparison all time","commit_id":"9df6d1d179bd5117cf1a796559a405a1bb097814"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"72a35c2af37545891522661d9612cdd22b8d8c49","unresolved":false,"context_lines":[{"line_number":6771,"context_line":"        elif volume_utils.is_group_a_type("},{"line_number":6772,"context_line":"                group_snapshot, \"volume_group_enabled\"):"},{"line_number":6773,"context_line":"            try:"},{"line_number":6774,"context_line":"                self._helpers.check_codelevel_for_volumegroup("},{"line_number":6775,"context_line":"                    self._state[\u0027code_level\u0027])"},{"line_number":6776,"context_line":"                params \u003d dict()"},{"line_number":6777,"context_line":"                # Use group_snapshot id as volumegroup name"}],"source_content_type":"text/x-python","patch_set":8,"id":"779ce03c_4a3be1cd","line":6774,"in_reply_to":"174a549b_84d16fd0","updated":"2025-01-09 09:25:02.000000000","message":"Resolved.\n\nRemoved the code block as we are checking the code_level at the beginning of creating a volumegroup.","commit_id":"9df6d1d179bd5117cf1a796559a405a1bb097814"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"7f8b1a23106570873651c515f731479d7ddc18a2","unresolved":true,"context_lines":[{"line_number":2389,"context_line":"            # volumegroup-snapshot"},{"line_number":2390,"context_line":"            self.create_volumegroup("},{"line_number":2391,"context_line":"                clone_volumegroup_name, volumegroup_snapshot_svc_id)"},{"line_number":2392,"context_line":"            volumes_model_update \u003d self._get_volume_model_updates("},{"line_number":2393,"context_line":"                ctxt, cinder_clone_volumes, group[\u0027id\u0027],"},{"line_number":2394,"context_line":"                model_update[\u0027status\u0027])"},{"line_number":2395,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"df490648_79a1b102","line":2392,"updated":"2024-11-14 05:11:25.000000000","message":"Why do we need to perform volume model update here, this will mark all the clone volume as available, this should be handled in the API layers","commit_id":"b7fec2f56660357b9596c4fb3da8b679b23d4a28"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"72a35c2af37545891522661d9612cdd22b8d8c49","unresolved":false,"context_lines":[{"line_number":2389,"context_line":"            # volumegroup-snapshot"},{"line_number":2390,"context_line":"            self.create_volumegroup("},{"line_number":2391,"context_line":"                clone_volumegroup_name, volumegroup_snapshot_svc_id)"},{"line_number":2392,"context_line":"            volumes_model_update \u003d self._get_volume_model_updates("},{"line_number":2393,"context_line":"                ctxt, cinder_clone_volumes, group[\u0027id\u0027],"},{"line_number":2394,"context_line":"                model_update[\u0027status\u0027])"},{"line_number":2395,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"a7882350_f8c19c02","line":2392,"in_reply_to":"df490648_79a1b102","updated":"2025-01-09 09:25:02.000000000","message":"Resolved.","commit_id":"b7fec2f56660357b9596c4fb3da8b679b23d4a28"},{"author":{"_account_id":24005,"name":"prashkre","email":"prashkre@in.ibm.com","username":"prashkre"},"change_message_id":"f748449793d018490e2f390404f60b12d77799e7","unresolved":true,"context_lines":[{"line_number":2399,"context_line":"            svc_clone_volumes_names \u003d ("},{"line_number":2400,"context_line":"                [volume[\"name\"] for volume in svc_clone_volumes])"},{"line_number":2401,"context_line":"            for svc_clone_volume_name in svc_clone_volumes_names:"},{"line_number":2402,"context_line":"                for source_volume, cinder_clone_volume in ("},{"line_number":2403,"context_line":"                        zip(list_of_source_volumes, cinder_clone_volumes)):"},{"line_number":2404,"context_line":"                    if (svc_clone_volume_name.rsplit(\"-\", 1)[0] \u003d\u003d"},{"line_number":2405,"context_line":"                            source_volume):"}],"source_content_type":"text/x-python","patch_set":10,"id":"625b7797_5b6587f1","line":2402,"updated":"2024-11-20 04:34:59.000000000","message":"We need to avoid nested loops which degrade the performance of operations.","commit_id":"b7fec2f56660357b9596c4fb3da8b679b23d4a28"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"72a35c2af37545891522661d9612cdd22b8d8c49","unresolved":false,"context_lines":[{"line_number":2399,"context_line":"            svc_clone_volumes_names \u003d ("},{"line_number":2400,"context_line":"                [volume[\"name\"] for volume in svc_clone_volumes])"},{"line_number":2401,"context_line":"            for svc_clone_volume_name in svc_clone_volumes_names:"},{"line_number":2402,"context_line":"                for source_volume, cinder_clone_volume in ("},{"line_number":2403,"context_line":"                        zip(list_of_source_volumes, cinder_clone_volumes)):"},{"line_number":2404,"context_line":"                    if (svc_clone_volume_name.rsplit(\"-\", 1)[0] \u003d\u003d"},{"line_number":2405,"context_line":"                            source_volume):"}],"source_content_type":"text/x-python","patch_set":10,"id":"7fc59308_25fae385","line":2402,"in_reply_to":"625b7797_5b6587f1","updated":"2025-01-09 09:25:02.000000000","message":"Resolved.","commit_id":"b7fec2f56660357b9596c4fb3da8b679b23d4a28"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"7f8b1a23106570873651c515f731479d7ddc18a2","unresolved":true,"context_lines":[{"line_number":2403,"context_line":"                        zip(list_of_source_volumes, cinder_clone_volumes)):"},{"line_number":2404,"context_line":"                    if (svc_clone_volume_name.rsplit(\"-\", 1)[0] \u003d\u003d"},{"line_number":2405,"context_line":"                            source_volume):"},{"line_number":2406,"context_line":"                        cinder_clone_volume[\u0027provider_id\u0027] \u003d ("},{"line_number":2407,"context_line":"                            svc_clone_volume_name)"},{"line_number":2408,"context_line":"                        break"},{"line_number":2409,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"86823b3b_68a5c047","line":2406,"updated":"2024-11-14 05:11:25.000000000","message":"this has to be stored in the volume_model_update to be saved in the DB","commit_id":"b7fec2f56660357b9596c4fb3da8b679b23d4a28"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"92251afe04cf6641c379f34028b9dfe4870b4f52","unresolved":false,"context_lines":[{"line_number":2403,"context_line":"                        zip(list_of_source_volumes, cinder_clone_volumes)):"},{"line_number":2404,"context_line":"                    if (svc_clone_volume_name.rsplit(\"-\", 1)[0] \u003d\u003d"},{"line_number":2405,"context_line":"                            source_volume):"},{"line_number":2406,"context_line":"                        cinder_clone_volume[\u0027provider_id\u0027] \u003d ("},{"line_number":2407,"context_line":"                            svc_clone_volume_name)"},{"line_number":2408,"context_line":"                        break"},{"line_number":2409,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3da9fc66_9f4ce98d","line":2406,"in_reply_to":"86823b3b_68a5c047","updated":"2025-01-09 09:26:59.000000000","message":"Resolved.\nvolumes_model_update is passed in Line 2481","commit_id":"b7fec2f56660357b9596c4fb3da8b679b23d4a28"},{"author":{"_account_id":36003,"name":"Amar Rajeev","display_name":"amar_rajeev","email":"Amar.Rajeev.Singuluri1@partner.ibm.com","username":"amar_rajeev"},"change_message_id":"e641269d8860307158464e2c5aebe91aad3fb595","unresolved":true,"context_lines":[{"line_number":6629,"context_line":"                                source_volumegroup_snapshot_svc_id)))"},{"line_number":6630,"context_line":"                    # Update the clone-volumes with the clone-volumegroup name"},{"line_number":6631,"context_line":"                    for volume in volumes:"},{"line_number":6632,"context_line":"                        self._update_volumegroup_properties(context, volume,"},{"line_number":6633,"context_line":"                                                            group)"},{"line_number":6634,"context_line":"                except exception.VolumeBackendAPIException as err:"},{"line_number":6635,"context_line":"                    LOG.error(\"Failed to clone the volumegroup \""}],"source_content_type":"text/x-python","patch_set":10,"id":"9d81de8e_dec2a597","line":6632,"updated":"2024-10-23 05:40:54.000000000","message":"Input to _update_volumegroup_snapshot_properties can be volumes and iterate inside\n_update_volumegroup_snapshot_properties","commit_id":"b7fec2f56660357b9596c4fb3da8b679b23d4a28"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"72a35c2af37545891522661d9612cdd22b8d8c49","unresolved":false,"context_lines":[{"line_number":6629,"context_line":"                                source_volumegroup_snapshot_svc_id)))"},{"line_number":6630,"context_line":"                    # Update the clone-volumes with the clone-volumegroup name"},{"line_number":6631,"context_line":"                    for volume in volumes:"},{"line_number":6632,"context_line":"                        self._update_volumegroup_properties(context, volume,"},{"line_number":6633,"context_line":"                                                            group)"},{"line_number":6634,"context_line":"                except exception.VolumeBackendAPIException as err:"},{"line_number":6635,"context_line":"                    LOG.error(\"Failed to clone the volumegroup \""}],"source_content_type":"text/x-python","patch_set":10,"id":"8187a6e9_8c45421b","line":6632,"in_reply_to":"9d81de8e_dec2a597","updated":"2025-01-09 09:25:02.000000000","message":"Resolved.","commit_id":"b7fec2f56660357b9596c4fb3da8b679b23d4a28"},{"author":{"_account_id":36003,"name":"Amar Rajeev","display_name":"amar_rajeev","email":"Amar.Rajeev.Singuluri1@partner.ibm.com","username":"amar_rajeev"},"change_message_id":"e641269d8860307158464e2c5aebe91aad3fb595","unresolved":true,"context_lines":[{"line_number":6667,"context_line":"                        \u0027:\u0027.join(list_of_source_volumes))"},{"line_number":6668,"context_line":""},{"line_number":6669,"context_line":"                params[\"name\"] \u003d temp_volumegroup_snapshot_name"},{"line_number":6670,"context_line":"                params[\u0027retentiondays\u0027] \u003d \u00271\u0027"},{"line_number":6671,"context_line":"                try:"},{"line_number":6672,"context_line":"                    # Create a temporary group snapshot from the source group"},{"line_number":6673,"context_line":"                    volumegroup_temp_snapshot_svc_id \u003d ("}],"source_content_type":"text/x-python","patch_set":10,"id":"bff18a7e_9b2b6508","line":6670,"updated":"2024-10-23 05:40:54.000000000","message":"retentiondays --\u003e\u003e retentionminutes\n\nAPI create_grpup","commit_id":"b7fec2f56660357b9596c4fb3da8b679b23d4a28"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"72a35c2af37545891522661d9612cdd22b8d8c49","unresolved":false,"context_lines":[{"line_number":6667,"context_line":"                        \u0027:\u0027.join(list_of_source_volumes))"},{"line_number":6668,"context_line":""},{"line_number":6669,"context_line":"                params[\"name\"] \u003d temp_volumegroup_snapshot_name"},{"line_number":6670,"context_line":"                params[\u0027retentiondays\u0027] \u003d \u00271\u0027"},{"line_number":6671,"context_line":"                try:"},{"line_number":6672,"context_line":"                    # Create a temporary group snapshot from the source group"},{"line_number":6673,"context_line":"                    volumegroup_temp_snapshot_svc_id \u003d ("}],"source_content_type":"text/x-python","patch_set":10,"id":"1ab8ec3a_83ffcbce","line":6670,"in_reply_to":"bff18a7e_9b2b6508","updated":"2025-01-09 09:25:02.000000000","message":"Resolved.","commit_id":"b7fec2f56660357b9596c4fb3da8b679b23d4a28"}]}