)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"bf742c6296752d7cfc7ad2fb50f9f9301bebf6f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d1200fcb_92974e7b","updated":"2024-09-19 15:36:33.000000000","message":"Ugh. Noticed that this works with netaddr 1.0.0 but does not for netaddr 1.3.0 . Will dig into the problem further.","commit_id":"5c5c43ab087cf074bf05cbe69ec744084327e5c3"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a51e8ccb6601f471bb675213d9c8c4716dfb1790","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"45e02096_66b369a4","in_reply_to":"d1200fcb_92974e7b","updated":"2024-09-19 15:49:59.000000000","message":"Fixed the problem and verified the fix with netaddr 1.3.0 .","commit_id":"5c5c43ab087cf074bf05cbe69ec744084327e5c3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a14979d2b8f593e198d6a143772624685ec89b78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ca31e884_d618f596","updated":"2024-10-15 12:39:04.000000000","message":"Easy revision noted inline.","commit_id":"8aa470796eade6053acd941952dc7542a4685ab2"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8024f118af4b22a5253fe6deb044bfa3e7be82f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2836f80c_a6825564","updated":"2024-09-20 06:19:58.000000000","message":"Thanks, I checked it again and works, thanks. I abandon my patch (https://review.opendev.org/c/openstack/cinder/+/927382)","commit_id":"8aa470796eade6053acd941952dc7542a4685ab2"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"bbc0ff827153cbb46c52bcd182e23f9148cf751a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"67363ebc_5e5ad56e","updated":"2024-10-16 07:57:42.000000000","message":"recheck\npy312 failure seems not to be related","commit_id":"41a1954bff8e4522bc3685a07ebf456f544b103d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2ad2ffe937bc39d7bd9ad5ba863b43bb2951e04e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f142cf1e_9599ea90","updated":"2024-10-15 14:25:47.000000000","message":"recheck The failure in py312 appears occasionally. We may need to dig into it later.","commit_id":"41a1954bff8e4522bc3685a07ebf456f544b103d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"803213ee4db7e2061ce6b4b07798b508a986c328","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"56c10f1a_5e76970f","updated":"2024-10-21 12:14:12.000000000","message":"Revision LGTM.","commit_id":"be4e08c620ef8ceadfe0deec1411cc415e735ce8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"70f211f261ccf56d8a74c92288d4252c1c8d76cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"68f82640_34e0c524","updated":"2024-11-15 10:20:46.000000000","message":"don\u0027t see UTs breaking because of this but makes sense to mock it\n\nReferences:\n\ndatacore\nhttps://opendev.org/openstack/cinder/src/branch/master/cinder/volume/drivers/datacore/utils.py#L28\n\noslo.utils\nhttps://github.com/openstack/oslo.utils/blob/master/oslo_utils/netutils.py#L131","commit_id":"be4e08c620ef8ceadfe0deec1411cc415e735ce8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d77815225900c1def456e01d9740f257a38898cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e85900b1_cf5359d7","updated":"2024-10-21 08:37:29.000000000","message":"mypy job has been fixed by https://review.opendev.org/c/openstack/cinder/+/932422","commit_id":"be4e08c620ef8ceadfe0deec1411cc415e735ce8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9b5365931e15baab5934ea4a3fc4ee6706c2daa9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a4e29fa1_6a066f09","updated":"2024-10-23 14:58:09.000000000","message":"raising priority as this is blocking a requirements change","commit_id":"be4e08c620ef8ceadfe0deec1411cc415e735ce8"}],"cinder/tests/unit/volume/drivers/datacore/test_datacore_api.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a14979d2b8f593e198d6a143772624685ec89b78","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        #                 longer \"accept\" non string object and raises"},{"line_number":57,"context_line":"        #                 TypeError. Patch the method until we properly mock"},{"line_number":58,"context_line":"        #                 internal behavior to present valid address strings."},{"line_number":59,"context_line":"        patcher \u003d mock.patch.object(netutils, \u0027is_valid_ipv6\u0027)"},{"line_number":60,"context_line":"        self.addCleanup(patcher.stop)"},{"line_number":61,"context_line":"        self.mock_is_valid_ipv6 \u003d patcher.start()"},{"line_number":62,"context_line":"        self.mock_is_valid_ipv6.return_value \u003d False"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        self.client \u003d api.DataCoreClient(\u0027hostname\u0027, \u0027username\u0027, \u0027password\u0027, 1)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1001f314_eab985d0","line":61,"range":{"start_line":59,"start_character":0,"end_line":61,"end_character":49},"updated":"2024-10-15 12:39:04.000000000","message":"The cinder.tests.unit.test.TestCase class has a mock_object() method that does this (and returns a reference to the mock -- you can see it used in a lot of tests in test_volume_manager.py, for example).  I\u0027d prefer you to use the already defined method, mostly to set an example for other people working on cinder tests.","commit_id":"8aa470796eade6053acd941952dc7542a4685ab2"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e008d6d99a316344e842ca79ddfb3a8dbd94d5ed","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        #                 longer \"accept\" non string object and raises"},{"line_number":57,"context_line":"        #                 TypeError. Patch the method until we properly mock"},{"line_number":58,"context_line":"        #                 internal behavior to present valid address strings."},{"line_number":59,"context_line":"        patcher \u003d mock.patch.object(netutils, \u0027is_valid_ipv6\u0027)"},{"line_number":60,"context_line":"        self.addCleanup(patcher.stop)"},{"line_number":61,"context_line":"        self.mock_is_valid_ipv6 \u003d patcher.start()"},{"line_number":62,"context_line":"        self.mock_is_valid_ipv6.return_value \u003d False"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        self.client \u003d api.DataCoreClient(\u0027hostname\u0027, \u0027username\u0027, \u0027password\u0027, 1)"}],"source_content_type":"text/x-python","patch_set":3,"id":"d386a2fd_4a509d48","line":61,"range":{"start_line":59,"start_character":0,"end_line":61,"end_character":49},"in_reply_to":"1001f314_eab985d0","updated":"2024-10-15 13:09:23.000000000","message":"Ah that is definitely a good trick. Updated this according to the suggestion.","commit_id":"8aa470796eade6053acd941952dc7542a4685ab2"}]}