)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"b924b94fa61e2f5d9c46dbc79686228eb469b096","unresolved":true,"context_lines":[{"line_number":11,"context_line":"otherwise falls back to the equivalent ZAPI call."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The new REST client supports specifying a custom CA bundle or directory"},{"line_number":14,"context_line":"with netapp_ssl_cert_path, but this is not supported by the ZAPI client."},{"line_number":15,"context_line":"This is causing failures early in the initialisation of driver when"},{"line_number":16,"context_line":"calling get_ontapi_version()."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5ee0f92d_a380ef23","line":14,"range":{"start_line":14,"start_character":5,"end_line":14,"end_character":25},"updated":"2024-10-07 10:11:09.000000000","message":"query: in the code, everywhere \"ssl_cert_path\" is used.\nMay i know reason for specifying \"netapp_ssl_cert_path\" here and in line 18.\ni have very little knowledge of NetApp code; so i am asking.","commit_id":"a33442f4fc7f1d49132b227b5a48f48b69d6dacd"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"733f4f4369bb789e15eb1e00e4c7e91ca6cbb214","unresolved":false,"context_lines":[{"line_number":11,"context_line":"otherwise falls back to the equivalent ZAPI call."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The new REST client supports specifying a custom CA bundle or directory"},{"line_number":14,"context_line":"with netapp_ssl_cert_path, but this is not supported by the ZAPI client."},{"line_number":15,"context_line":"This is causing failures early in the initialisation of driver when"},{"line_number":16,"context_line":"calling get_ontapi_version()."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4b72bac1_374674ad","line":14,"range":{"start_line":14,"start_character":5,"end_line":14,"end_character":25},"in_reply_to":"5ee0f92d_a380ef23","updated":"2024-10-07 15:16:09.000000000","message":"ssl_cert_path is the name of the variable used internally in the driver. However, the configuration option used to initialise it is called netapp_ssl_cert_path.\n\nSee https://opendev.org/openstack/cinder/src/commit/774d784aca50c942545fde5512f7de73b1caa5be/cinder/volume/drivers/netapp/dataontap/utils/utils.py#L82","commit_id":"a33442f4fc7f1d49132b227b5a48f48b69d6dacd"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"b924b94fa61e2f5d9c46dbc79686228eb469b096","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"970e3fb3_015846a9","updated":"2024-10-07 10:11:09.000000000","message":"Code change looks good. Minor query inline.","commit_id":"a33442f4fc7f1d49132b227b5a48f48b69d6dacd"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"c62c22eb88b855f8f9ef4cb1a266e091148d81b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"321c29a7_a0caf6ca","updated":"2024-10-08 03:07:17.000000000","message":"Thanks Pierre. My query has been resolved. Zuul also passed.","commit_id":"7bf96924f60a6ac945ccbecbe5dfd07d655bb3c7"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"a7324e14e306d218236eeadb35f3eed360b9e701","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fc6acc30_8baf9dfc","updated":"2024-12-03 14:42:26.000000000","message":"We\u0027ve hit the same big on caracal today. I\u0027ve ported this patch to Caracal, and now the cinder-volume starts fine with a self-signed cert on backend.\n\nConsider this as a small 3rd-party verification of this patch.","commit_id":"7bf96924f60a6ac945ccbecbe5dfd07d655bb3c7"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"42c00a8b375af89c7678e88896fa8996f6f5c83e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"88c70851_c257f5a7","updated":"2024-10-07 19:22:31.000000000","message":"recheck\n\npython 3.12 unit test failed","commit_id":"7bf96924f60a6ac945ccbecbe5dfd07d655bb3c7"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"40e0f918dc95043f3e4d6122803e14e2a3c4d62d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fa2fb9cf_9dab68fa","updated":"2025-04-03 13:48:33.000000000","message":"@pierre@stackhpc.com given that https://review.opendev.org/c/openstack/cinder/+/942342 got merged I\u0027d think this patch has only to fix one single flaw there - which is that it allows for custom ca bundle only together with cert-based auth...","commit_id":"42b744d0a8bd4163a4185c201c21e356ca72e09b"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"c4387d75135da12b1bcc2b97c2c45d9b9eb050e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e8c486ed_468fce51","updated":"2026-02-20 07:10:30.000000000","message":"CA signed certificate works with existing implementation. Can you refer to this KB article about how to archive this https://kb.netapp.com/Cloud/OpenStack/OpenStack__How_to_enable_https_with_CA_signed_certs_for_Cinder . This patch is not required i am thinking.","commit_id":"392561e25ae70d779a97c4dd5bba39f4e1e439cd"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"52c574d6aad443c15c2d7204093dada5f08362b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7248d91c_8ecfe7ad","in_reply_to":"e8c486ed_468fce51","updated":"2026-02-20 13:57:55.000000000","message":"Thanks for your feedback. This was written before the NetApp driver had support for self-signed certificates. I will try the new implementation.","commit_id":"392561e25ae70d779a97c4dd5bba39f4e1e439cd"}],"cinder/volume/drivers/netapp/dataontap/client/api.py":[{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"515f776fd71b02cc8ec4f1aa1e5a0d1f170c0ceb","unresolved":true,"context_lines":[{"line_number":326,"context_line":"        raise NotImplementedError()"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    def _create_https_handler_with_cafile(self):"},{"line_number":329,"context_line":"        context \u003d ssl.create_default_context(cafile\u003dself._ssl_cert_path)"},{"line_number":330,"context_line":"        https_handler \u003d urllib.request.HTTPSHandler(context\u003dcontext)"},{"line_number":331,"context_line":"        return https_handler"},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"36dc0839_89e151af","line":329,"range":{"start_line":329,"start_character":45,"end_line":329,"end_character":71},"updated":"2025-04-07 15:41:56.000000000","message":"also, this won\u0027t work if ssl_cert_path is a directory (which in can be according to [0]), directory should be passed as `capath` argument [1-2]\n\n[0] https://opendev.org/openstack/cinder/src/commit/7cd582210b4f77b510069755e8aa6f4f7fa8cd5e/cinder/volume/drivers/netapp/options.py#L73-L74\n[1] https://docs.python.org/3/library/ssl.html#ssl.create_default_context\n[2] https://docs.python.org/3/library/ssl.html#ssl.SSLContext.load_verify_locations","commit_id":"42b744d0a8bd4163a4185c201c21e356ca72e09b"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"8dd154e930979e3614cf5e21489ee858b9ce20e2","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        raise NotImplementedError()"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    def _create_https_handler_with_cafile(self):"},{"line_number":329,"context_line":"        context \u003d ssl.create_default_context(cafile\u003dself._ssl_cert_path)"},{"line_number":330,"context_line":"        https_handler \u003d urllib.request.HTTPSHandler(context\u003dcontext)"},{"line_number":331,"context_line":"        return https_handler"},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9edb55a8_be142bdc","line":329,"range":{"start_line":329,"start_character":45,"end_line":329,"end_character":71},"in_reply_to":"36dc0839_89e151af","updated":"2025-04-08 14:16:08.000000000","message":"Done","commit_id":"42b744d0a8bd4163a4185c201c21e356ca72e09b"}],"releasenotes/notes/bug-2083706-netapp-zapi-ssl-cert-path-c333f63421f90f3b.yaml":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"b924b94fa61e2f5d9c46dbc79686228eb469b096","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp ONTAP driver `bug #2083706"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2083706\u003e`_: Fixed driver"},{"line_number":6,"context_line":"    initialisation error when using ``netapp_ssl_cert_path`` with new REST"},{"line_number":7,"context_line":"    client."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"cd7f5302_f6e26f21","line":6,"range":{"start_line":6,"start_character":38,"end_line":6,"end_character":58},"updated":"2024-10-07 10:11:09.000000000","message":"same query as mentioned in commit message","commit_id":"a33442f4fc7f1d49132b227b5a48f48b69d6dacd"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"733f4f4369bb789e15eb1e00e4c7e91ca6cbb214","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp ONTAP driver `bug #2083706"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2083706\u003e`_: Fixed driver"},{"line_number":6,"context_line":"    initialisation error when using ``netapp_ssl_cert_path`` with new REST"},{"line_number":7,"context_line":"    client."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"13947f99_08b51cfc","line":6,"range":{"start_line":6,"start_character":38,"end_line":6,"end_character":58},"in_reply_to":"cd7f5302_f6e26f21","updated":"2024-10-07 15:16:09.000000000","message":"For the release note, it is particularly important that we use the configuration option rather than internal variable which only developers may know.","commit_id":"a33442f4fc7f1d49132b227b5a48f48b69d6dacd"}]}
