)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"14de631ca70ad50e893e0b5410528213b3411ed9","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Nilesh Thathagar \u003cnilesh.thathagar@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-10-10 05:13:58 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dell PowerMax: Added exception handling after"},{"line_number":8,"context_line":"the masking view REST call."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Added exception handling after the masking view"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"18d52d99_e1c42274","line":7,"updated":"2024-10-11 05:51:40.000000000","message":"As per [1], there should be single blank line after the first line\n\n[1] https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"e96f1caa88be9f19ee63060636d1b38f7872bd79"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"36c8e52e8c0df352bda9f8fbf4fee13bd8067127","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nilesh Thathagar \u003cnilesh.thathagar@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-10-10 05:13:58 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dell PowerMax: Added exception handling after"},{"line_number":8,"context_line":"the masking view REST call."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Added exception handling after the masking view"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a157b014_706161c0","line":7,"in_reply_to":"18d52d99_e1c42274","updated":"2025-02-27 19:17:14.000000000","message":"Done","commit_id":"e96f1caa88be9f19ee63060636d1b38f7872bd79"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"34bf56e19bdeae7f9852220444d08a1c26094c21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d4e4a318_f091ba13","updated":"2024-10-09 11:46:04.000000000","message":"recheck","commit_id":"b4fc9c5942bbff63fde9f458e9e5e24a2e4f503e"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"14de631ca70ad50e893e0b5410528213b3411ed9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0ac1d36e_1b5d12fe","updated":"2024-10-11 05:51:40.000000000","message":"Code changes look good. Zuul has passed. The DellEMC PowerMax CI is yet to pass.\n\nMinor comment in commit message. It can be addressed later (when other reviewers provide feedback).","commit_id":"e96f1caa88be9f19ee63060636d1b38f7872bd79"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"18dd0672f3da64c8fdb7aa054d4fe7f1d54bdd46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"79609c6a_15a34f25","updated":"2025-02-26 19:11:47.000000000","message":"I\u0027m still hung up on the number of retries.  See comment inline.","commit_id":"e96f1caa88be9f19ee63060636d1b38f7872bd79"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"a849547d06f5006b126fdbbd3bc9269fe0f61921","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"01291d6a_f3eb8ffb","updated":"2024-10-10 07:15:45.000000000","message":"Please do a review.","commit_id":"e96f1caa88be9f19ee63060636d1b38f7872bd79"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fc7cf3ec0b5410bb369135fa0eed3b2633b1bf47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"554b4e76_79a01260","updated":"2025-02-06 02:27:09.000000000","message":"Question inline.","commit_id":"e96f1caa88be9f19ee63060636d1b38f7872bd79"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"3c1c33153f3806f04b11182da806362b0b0e423b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c7b2c931_b7fe61b3","updated":"2025-01-29 15:45:16.000000000","message":"Since the PowerMax CI is currently down and will take some time to fix, I am attaching the local CI results to https://bugs.launchpad.net/charm-cinder/+bug/2081742 for your review of the patch.","commit_id":"e96f1caa88be9f19ee63060636d1b38f7872bd79"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3cdf86bf115ccf86f38b3f7d03e7bdcd95cd5f90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"be4ef51c_f89fc91b","updated":"2025-02-26 18:53:45.000000000","message":"few comments inline, i hope the new condition added, when connection_info doesn\u0027t contain the masking view info, is the actual fix for the problem.","commit_id":"e96f1caa88be9f19ee63060636d1b38f7872bd79"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"7418e137a72ebe0aa9f0d839a10d7658de003b0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ce219111_be017f01","updated":"2024-12-19 04:37:50.000000000","message":"run-Dell PowerMax CI","commit_id":"e96f1caa88be9f19ee63060636d1b38f7872bd79"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"b2a9380128ab3320a967a98ea8b63f97aee004fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a7ab5577_206adf78","updated":"2024-10-10 08:09:44.000000000","message":"run-DellEMC PowerMax CI","commit_id":"e96f1caa88be9f19ee63060636d1b38f7872bd79"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"1555fb134b4385a740984d32517bc5411ad474a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fd4c7d8a_c6d097b2","updated":"2025-01-20 19:25:50.000000000","message":"run-DellEMC PowerMax CI","commit_id":"e96f1caa88be9f19ee63060636d1b38f7872bd79"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"36c8e52e8c0df352bda9f8fbf4fee13bd8067127","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dd6c22ac_9da954a6","updated":"2025-02-27 19:17:14.000000000","message":"Addressed all comments. Please do a review.","commit_id":"c05d12875fb989fc786b3c91a1ea1ce722d0f382"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"96ec2dbe500ccb5cbed659417ccc5eddc8d751c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"334315c2_b3fb5532","updated":"2025-02-27 22:03:00.000000000","message":"I think this may be OK as a short-term fix, but I\u0027m still worried that a long wait may introduce other problems.  But you know the performance characteristics of your backend better than I do, so please read my comments inline about a possible followup.","commit_id":"c05d12875fb989fc786b3c91a1ea1ce722d0f382"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"9b0cbb86c6cd57fd658a84670e3f38b84cd31f26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"71c7d400_1cc01f1b","updated":"2025-02-28 05:40:42.000000000","message":"Thanks Brian for review","commit_id":"c05d12875fb989fc786b3c91a1ea1ce722d0f382"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"51016dcc1a95fb36b1cc8113cb407a208f2fa226","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0efcb3d2_2a17c7e3","updated":"2025-02-28 09:55:24.000000000","message":"This looks much better, however, i still see this as a band aid for something fishy going on at the storage array side. It\u0027s good at least unblock the operations but much more important to see why a common request like getting the LUN ID takes so much time.\nSince the powermax CI is down and the previous PS was tested (minor changes from this one), this should be good to go.","commit_id":"c05d12875fb989fc786b3c91a1ea1ce722d0f382"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2711bae7cb55998e268f75636c79de6fe3655ee1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a5225f04_49f2fc68","updated":"2025-02-28 17:37:54.000000000","message":"cinder-plugin-ceph-tempest has failed due to the oom-reaper killing mysqld and causing db connection errors ... will have to recheck once Zuul posts results on this review","commit_id":"c05d12875fb989fc786b3c91a1ea1ce722d0f382"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"4fc707d03a9b712d1719b5dcbd98527bc317e14f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"76bb8f19_57f62a00","updated":"2025-03-01 06:29:21.000000000","message":"recheck","commit_id":"c05d12875fb989fc786b3c91a1ea1ce722d0f382"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"6133854f0fd546d0b3603586dcd6678b9d8e3571","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9f4d192f_47a9ef18","updated":"2025-03-01 13:45:41.000000000","message":"recheck","commit_id":"c05d12875fb989fc786b3c91a1ea1ce722d0f382"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"577e6107d5f541b48e452181266489e137b9ddb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7c1f402b_3979eda4","updated":"2025-03-01 10:50:15.000000000","message":"recheck\ncinder-plugin-ceph-tempest failed.","commit_id":"c05d12875fb989fc786b3c91a1ea1ce722d0f382"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"3fd23ece0a5ba50e70e681cf900ac20abaeb2435","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"edbe8ad8_b52320e0","updated":"2025-02-28 17:47:17.000000000","message":"recheck\ncinder-plugin-ceph-tempest failed.","commit_id":"c05d12875fb989fc786b3c91a1ea1ce722d0f382"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2ae7dfac23e4faf5e82cb3718307cbfaf0b612f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d668ce83_084b8010","updated":"2025-02-28 17:47:22.000000000","message":"recheck cinder-plugin-ceph-tempest - OOM killed mysqld","commit_id":"c05d12875fb989fc786b3c91a1ea1ce722d0f382"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6130666ac63a175ea5776ae17023fae802e1b724","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ea37ec1b_cf97bc91","updated":"2025-02-28 14:34:39.000000000","message":"recheck recheck tempest-integrated-storage - tempest.api.compute.volumes.test_attach_volume_negative.AttachVolumeNegativeTest.test_attach_attached_volume_to_same_server couldn\u0027t build the server","commit_id":"c05d12875fb989fc786b3c91a1ea1ce722d0f382"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f8f584e3e9a5f1107ce74ae27886a0b9a4330400","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"92f24aa6_22491689","updated":"2025-03-01 16:10:55.000000000","message":"recheck tempest-slow-py3 - test_server_connectivity_cold_migration had a problem with the instance; console dump in the log","commit_id":"c05d12875fb989fc786b3c91a1ea1ce722d0f382"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"c3ae4fdfc8db457ddc6b731532abd4d3c845f866","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"aa427c27_09df06ef","updated":"2025-02-28 09:59:01.000000000","message":"thanks, Rajat for the review. We will work with the platform team to reduce it as much as possible.","commit_id":"c05d12875fb989fc786b3c91a1ea1ce722d0f382"}],"cinder/volume/drivers/dell_emc/powermax/rest.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fc7cf3ec0b5410bb369135fa0eed3b2633b1bf47","unresolved":true,"context_lines":[{"line_number":1621,"context_line":"                self.delete_resource(array, SLOPROVISIONING,"},{"line_number":1622,"context_line":"                                     \"volume\", device_id)"},{"line_number":1623,"context_line":""},{"line_number":1624,"context_line":"    @retry(retry_exc_tuple, interval\u003d2, retries\u003d10)"},{"line_number":1625,"context_line":"    def find_mv_connections_for_vol(self, array, maskingview, device_id):"},{"line_number":1626,"context_line":"        \"\"\"Find the host_lun_id for a volume in a masking view."},{"line_number":1627,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"e1f9a7b6_78002d79","line":1624,"updated":"2025-02-06 02:27:09.000000000","message":"If I\u0027m calculating this correctly, you could be retrying for over half an hour ... is that reasonable?","commit_id":"e96f1caa88be9f19ee63060636d1b38f7872bd79"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"36c8e52e8c0df352bda9f8fbf4fee13bd8067127","unresolved":false,"context_lines":[{"line_number":1621,"context_line":"                self.delete_resource(array, SLOPROVISIONING,"},{"line_number":1622,"context_line":"                                     \"volume\", device_id)"},{"line_number":1623,"context_line":""},{"line_number":1624,"context_line":"    @retry(retry_exc_tuple, interval\u003d2, retries\u003d10)"},{"line_number":1625,"context_line":"    def find_mv_connections_for_vol(self, array, maskingview, device_id):"},{"line_number":1626,"context_line":"        \"\"\"Find the host_lun_id for a volume in a masking view."},{"line_number":1627,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5cd404d8_0964163d","line":1624,"in_reply_to":"2b2e25f5_ac58fab5","updated":"2025-02-27 19:17:14.000000000","message":"Updated the retry count based on trial and error.\nThe maximum observed retries reached the 8th attempt,\nso we have set it to 8 retries.","commit_id":"e96f1caa88be9f19ee63060636d1b38f7872bd79"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3cdf86bf115ccf86f38b3f7d03e7bdcd95cd5f90","unresolved":true,"context_lines":[{"line_number":1621,"context_line":"                self.delete_resource(array, SLOPROVISIONING,"},{"line_number":1622,"context_line":"                                     \"volume\", device_id)"},{"line_number":1623,"context_line":""},{"line_number":1624,"context_line":"    @retry(retry_exc_tuple, interval\u003d2, retries\u003d10)"},{"line_number":1625,"context_line":"    def find_mv_connections_for_vol(self, array, maskingview, device_id):"},{"line_number":1626,"context_line":"        \"\"\"Find the host_lun_id for a volume in a masking view."},{"line_number":1627,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"b333510a_027ed33d","line":1624,"in_reply_to":"91f851a2_f2dda605","updated":"2025-02-26 18:53:45.000000000","message":"For 10 retries it will be 34 mins and for 7 retries it will be 4 minutes which is a reasonable difference but still 4 minutes to return LUN for 1 attachment is considerably slow.","commit_id":"e96f1caa88be9f19ee63060636d1b38f7872bd79"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"18dd0672f3da64c8fdb7aa054d4fe7f1d54bdd46","unresolved":true,"context_lines":[{"line_number":1621,"context_line":"                self.delete_resource(array, SLOPROVISIONING,"},{"line_number":1622,"context_line":"                                     \"volume\", device_id)"},{"line_number":1623,"context_line":""},{"line_number":1624,"context_line":"    @retry(retry_exc_tuple, interval\u003d2, retries\u003d10)"},{"line_number":1625,"context_line":"    def find_mv_connections_for_vol(self, array, maskingview, device_id):"},{"line_number":1626,"context_line":"        \"\"\"Find the host_lun_id for a volume in a masking view."},{"line_number":1627,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"2b2e25f5_ac58fab5","line":1624,"in_reply_to":"b333510a_027ed33d","updated":"2025-02-26 19:11:47.000000000","message":"I\u0027ve been thinking about this, and I\u0027m still worried about the backend going down, and then you may have a bunch of threads waiting 34 minutes, which could cause resource issues.  Like Rajat pointed out, 4 minutes (7 retries) should be plenty of time.  I\u0027d even be OK with 8 retries, I guess, which would be about 8 1/2 minutes--if it hasn\u0027t responded by then, it\u0027s pretty unlikely you\u0027ll ever get a response.","commit_id":"e96f1caa88be9f19ee63060636d1b38f7872bd79"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"9b12f665d208161559b666012ec6fbd58757f05a","unresolved":true,"context_lines":[{"line_number":1621,"context_line":"                self.delete_resource(array, SLOPROVISIONING,"},{"line_number":1622,"context_line":"                                     \"volume\", device_id)"},{"line_number":1623,"context_line":""},{"line_number":1624,"context_line":"    @retry(retry_exc_tuple, interval\u003d2, retries\u003d10)"},{"line_number":1625,"context_line":"    def find_mv_connections_for_vol(self, array, maskingview, device_id):"},{"line_number":1626,"context_line":"        \"\"\"Find the host_lun_id for a volume in a masking view."},{"line_number":1627,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"91f851a2_f2dda605","line":1624,"in_reply_to":"e1f9a7b6_78002d79","updated":"2025-02-06 05:42:50.000000000","message":"Hi Brian,\n\nThanks for the update. Regarding retries, the response time varies—sometimes it succeeds in a single call, other times in two, and occasionally it takes up to six retries. Since there’s no fixed pattern for when we receive a response, I’ve set the retry value to 10 as a precaution and the six retries is occasionally it is not every we are getting.\n\nYes, waiting for more than half hour for the retries is not reasonable, but I\u0027m confident it won\u0027t take that long. The maximum should be the seventh call. I set it to 10 as a precaution.","commit_id":"e96f1caa88be9f19ee63060636d1b38f7872bd79"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3cdf86bf115ccf86f38b3f7d03e7bdcd95cd5f90","unresolved":true,"context_lines":[{"line_number":1652,"context_line":"                    if host_lun_id:"},{"line_number":1653,"context_line":"                        host_lun_id \u003d int(host_lun_id, 16)"},{"line_number":1654,"context_line":"                    else:"},{"line_number":1655,"context_line":"                        exception_message \u003d (_(\u0027Unable to get \u0027"},{"line_number":1656,"context_line":"                                               \u0027host_lun_address for device\u0027"},{"line_number":1657,"context_line":"                                               \u0027 %(dev)s on masking view\u0027"},{"line_number":1658,"context_line":"                                               \u0027 %(mv)s. Retrying...\u0027)"},{"line_number":1659,"context_line":"                                             % {\u0027dev\u0027: device_id,"},{"line_number":1660,"context_line":"                                                \u0027mv\u0027: maskingview})"},{"line_number":1661,"context_line":"                        LOG.warning(exception_message)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ab31d1e7_dc71f378","line":1658,"range":{"start_line":1655,"start_character":47,"end_line":1658,"end_character":69},"updated":"2025-02-26 18:53:45.000000000","message":"the formatting for these messages is really weird ...\nthe first line has space in the end\nthe third and fourth line have it in the beginning","commit_id":"e96f1caa88be9f19ee63060636d1b38f7872bd79"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"36c8e52e8c0df352bda9f8fbf4fee13bd8067127","unresolved":false,"context_lines":[{"line_number":1652,"context_line":"                    if host_lun_id:"},{"line_number":1653,"context_line":"                        host_lun_id \u003d int(host_lun_id, 16)"},{"line_number":1654,"context_line":"                    else:"},{"line_number":1655,"context_line":"                        exception_message \u003d (_(\u0027Unable to get \u0027"},{"line_number":1656,"context_line":"                                               \u0027host_lun_address for device\u0027"},{"line_number":1657,"context_line":"                                               \u0027 %(dev)s on masking view\u0027"},{"line_number":1658,"context_line":"                                               \u0027 %(mv)s. Retrying...\u0027)"},{"line_number":1659,"context_line":"                                             % {\u0027dev\u0027: device_id,"},{"line_number":1660,"context_line":"                                                \u0027mv\u0027: maskingview})"},{"line_number":1661,"context_line":"                        LOG.warning(exception_message)"}],"source_content_type":"text/x-python","patch_set":2,"id":"e20df10f_43cb6119","line":1658,"range":{"start_line":1655,"start_character":47,"end_line":1658,"end_character":69},"in_reply_to":"ab31d1e7_dc71f378","updated":"2025-02-27 19:17:14.000000000","message":"Have done proper formatting.","commit_id":"e96f1caa88be9f19ee63060636d1b38f7872bd79"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3cdf86bf115ccf86f38b3f7d03e7bdcd95cd5f90","unresolved":true,"context_lines":[{"line_number":1661,"context_line":"                        LOG.warning(exception_message)"},{"line_number":1662,"context_line":"                        raise exception.VolumeBackendAPIException("},{"line_number":1663,"context_line":"                            message\u003dexception_message)"},{"line_number":1664,"context_line":"                else:"},{"line_number":1665,"context_line":"                    exception_message \u003d (_(\"Unable to retrieve connection\""},{"line_number":1666,"context_line":"                                           \" information for volume %(vol)s \""},{"line_number":1667,"context_line":"                                           \"in masking view %(mv)s. \""}],"source_content_type":"text/x-python","patch_set":2,"id":"84bf281e_07cf7c99","line":1664,"range":{"start_line":1664,"start_character":16,"end_line":1664,"end_character":21},"updated":"2025-02-26 18:53:45.000000000","message":"so we were able to retrieve the connection info but not the maskingViewConnection inside it which wasn\u0027t handled before right?","commit_id":"e96f1caa88be9f19ee63060636d1b38f7872bd79"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"36c8e52e8c0df352bda9f8fbf4fee13bd8067127","unresolved":false,"context_lines":[{"line_number":1661,"context_line":"                        LOG.warning(exception_message)"},{"line_number":1662,"context_line":"                        raise exception.VolumeBackendAPIException("},{"line_number":1663,"context_line":"                            message\u003dexception_message)"},{"line_number":1664,"context_line":"                else:"},{"line_number":1665,"context_line":"                    exception_message \u003d (_(\"Unable to retrieve connection\""},{"line_number":1666,"context_line":"                                           \" information for volume %(vol)s \""},{"line_number":1667,"context_line":"                                           \"in masking view %(mv)s. \""}],"source_content_type":"text/x-python","patch_set":2,"id":"11e6e457_41485ab2","line":1664,"range":{"start_line":1664,"start_character":16,"end_line":1664,"end_character":21},"in_reply_to":"84bf281e_07cf7c99","updated":"2025-02-27 19:17:14.000000000","message":"yes correct.","commit_id":"e96f1caa88be9f19ee63060636d1b38f7872bd79"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3cdf86bf115ccf86f38b3f7d03e7bdcd95cd5f90","unresolved":true,"context_lines":[{"line_number":1662,"context_line":"                        raise exception.VolumeBackendAPIException("},{"line_number":1663,"context_line":"                            message\u003dexception_message)"},{"line_number":1664,"context_line":"                else:"},{"line_number":1665,"context_line":"                    exception_message \u003d (_(\"Unable to retrieve connection\""},{"line_number":1666,"context_line":"                                           \" information for volume %(vol)s \""},{"line_number":1667,"context_line":"                                           \"in masking view %(mv)s. \""},{"line_number":1668,"context_line":"                                           \"Retrying...\")"},{"line_number":1669,"context_line":"                                         % {\u0027vol\u0027: device_id,"},{"line_number":1670,"context_line":"                                            \u0027mv\u0027: maskingview})"},{"line_number":1671,"context_line":"                    LOG.warning(exception_message)"}],"source_content_type":"text/x-python","patch_set":2,"id":"249ac593_f6ed7d6f","line":1668,"range":{"start_line":1665,"start_character":43,"end_line":1668,"end_character":56},"updated":"2025-02-26 18:53:45.000000000","message":"this is again an instance of strange formatting,\nsecond line has a space in beginning\nthird line has space in the end\n\nAlso we are using double quotes here and above it\u0027s single quotes","commit_id":"e96f1caa88be9f19ee63060636d1b38f7872bd79"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"36c8e52e8c0df352bda9f8fbf4fee13bd8067127","unresolved":false,"context_lines":[{"line_number":1662,"context_line":"                        raise exception.VolumeBackendAPIException("},{"line_number":1663,"context_line":"                            message\u003dexception_message)"},{"line_number":1664,"context_line":"                else:"},{"line_number":1665,"context_line":"                    exception_message \u003d (_(\"Unable to retrieve connection\""},{"line_number":1666,"context_line":"                                           \" information for volume %(vol)s \""},{"line_number":1667,"context_line":"                                           \"in masking view %(mv)s. \""},{"line_number":1668,"context_line":"                                           \"Retrying...\")"},{"line_number":1669,"context_line":"                                         % {\u0027vol\u0027: device_id,"},{"line_number":1670,"context_line":"                                            \u0027mv\u0027: maskingview})"},{"line_number":1671,"context_line":"                    LOG.warning(exception_message)"}],"source_content_type":"text/x-python","patch_set":2,"id":"2e8fe948_1acbeba2","line":1668,"range":{"start_line":1665,"start_character":43,"end_line":1668,"end_character":56},"in_reply_to":"249ac593_f6ed7d6f","updated":"2025-02-27 19:17:14.000000000","message":"Have done proper formatting.","commit_id":"e96f1caa88be9f19ee63060636d1b38f7872bd79"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"96ec2dbe500ccb5cbed659417ccc5eddc8d751c5","unresolved":true,"context_lines":[{"line_number":1621,"context_line":"                self.delete_resource(array, SLOPROVISIONING,"},{"line_number":1622,"context_line":"                                     \"volume\", device_id)"},{"line_number":1623,"context_line":""},{"line_number":1624,"context_line":"    @retry(retry_exc_tuple, interval\u003d2, retries\u003d8)"},{"line_number":1625,"context_line":"    def find_mv_connections_for_vol(self, array, maskingview, device_id):"},{"line_number":1626,"context_line":"        \"\"\"Find the host_lun_id for a volume in a masking view."},{"line_number":1627,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"8a9fec76_0f490f2b","line":1624,"range":{"start_line":1624,"start_character":48,"end_line":1624,"end_character":49},"updated":"2025-02-27 22:03:00.000000000","message":"Wow, you have actually seen 8 retries? Are you comfortable with 8, or would you rather go to 9?\n\nI think the problem here is that the exponential backoff may not fit the performance profile of the PowerMax backend.  What I mean is, with interval\u003d2 and the default backoff_rate of 2, you\u0027re seeing:\n\n```\nretry:  1  elapsed time: 2 sec\nretry:  2  elapsed time: 6 sec\nretry:  3  elapsed time: 14 sec\nretry:  4  elapsed time: 30 sec\nretry:  5  elapsed time: 1.03 min\nretry:  6  elapsed time: 2.10 min\nretry:  7  elapsed time: 4.23 min\nretry:  8  elapsed time: 8.50 min\nretry:  9  elapsed time: 17.03 min\nretry: 10  elapsed time: 34.10 min\n```\n\nThat\u0027s a lot of time in between retries 7 and 8.  You can try playing with the interval and backoff_rate, but in order to get more tries between 4-8 minutes, you wind up increasing the waits at the beginning.  For example, with interval\u003d10, retries\u003d12, backoff_rate\u003d1.25:\n\n```\nretry:  1  elapsed time: 10.0 sec\nretry:  2  elapsed time: 22.5 sec\nretry:  3  elapsed time: 38.125 sec\nretry:  4  elapsed time: 57.65625 sec\nretry:  5  elapsed time: 1.37 min\nretry:  6  elapsed time: 1.88 min\nretry:  7  elapsed time: 2.51 min\nretry:  8  elapsed time: 3.31 min\nretry:  9  elapsed time: 4.30 min\nretry: 10  elapsed time: 5.54 min\nretry: 11  elapsed time: 7.09 min\nretry: 12  elapsed time: 9.03 min\n```\n\nSo if you have just 1 retry, you\u0027re waiting 10 seconds.  Maybe that\u0027s OK, it depends on the response time of the array; but you certainly don\u0027t want to increase the mode wait time just to get finer granularity for a few extreme cases, so I\u0027m not actually recommending this (unless it actually reflects how the array behaves).  I wonder if what you need is a different wait model that would allow you to make a few quick requests, and then space them out more (but not exponentially, or maybe exponentially but on a different curve).\n\nThe tenacity library that cinder.utils uses allows you create a \"wait chain\" that would allow you to do a few quick requests, then make the requests more slowly, but we haven\u0027t implemented an interface for that in the cinder.utils.retry function.\n\nI think this is worth looking into as a follow up, because I am really concerned that in an environment that is so busy that the array is taking \u003e 4 min to process your request, it\u0027s not good to allow a 17 (or 34 minute) wait.\n\nActually, to get back to my original question, I think you should leave this at 8 so that you can get your customer unstuck; 8 retries may not be enough for all cases, so if your customer is still seeing issues, that may be a good motivation to look more carefully into how to fix this.","commit_id":"c05d12875fb989fc786b3c91a1ea1ce722d0f382"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"9b0cbb86c6cd57fd658a84670e3f38b84cd31f26","unresolved":false,"context_lines":[{"line_number":1621,"context_line":"                self.delete_resource(array, SLOPROVISIONING,"},{"line_number":1622,"context_line":"                                     \"volume\", device_id)"},{"line_number":1623,"context_line":""},{"line_number":1624,"context_line":"    @retry(retry_exc_tuple, interval\u003d2, retries\u003d8)"},{"line_number":1625,"context_line":"    def find_mv_connections_for_vol(self, array, maskingview, device_id):"},{"line_number":1626,"context_line":"        \"\"\"Find the host_lun_id for a volume in a masking view."},{"line_number":1627,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"27210368_d77a97e2","line":1624,"range":{"start_line":1624,"start_character":48,"end_line":1624,"end_character":49},"in_reply_to":"8a9fec76_0f490f2b","updated":"2025-02-28 05:40:42.000000000","message":"Hi Brian thanks for the review comment.\nThe 8th retry is rare. Most of the requests taking between 2-5 retry. So for that 10 internal might not suite.","commit_id":"c05d12875fb989fc786b3c91a1ea1ce722d0f382"}],"releasenotes/notes/bug-2081742-dell-powermax-rest-api-hostlunid-ee22d0105c990ea0.yaml":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"51016dcc1a95fb36b1cc8113cb407a208f2fa226","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerMax Driver `bug #2081742"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2081742\u003e`_: The REST"},{"line_number":6,"context_line":"    API calls for the masking view connection do not return"},{"line_number":7,"context_line":"    the HostLUN ID immediately. To address this, an exception"},{"line_number":8,"context_line":"    has been added to implement a retry mechanism."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"908e4f0c_627785b9","line":6,"range":{"start_line":6,"start_character":46,"end_line":6,"end_character":48},"updated":"2025-02-28 09:55:24.000000000","message":"nit: does","commit_id":"c05d12875fb989fc786b3c91a1ea1ce722d0f382"}]}