)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"29a3da1b2a677774766e0e0680140157ddcb3a56","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Dell PowerFlex support for capacity reservation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Support for backend capacity reservation has been added."},{"line_number":10,"context_line":"he amount of reserved capacity is defined by the unsigned"},{"line_number":11,"context_line":"integer value of the `powerflex_reserved_percentage`"},{"line_number":12,"context_line":"configuration option, with a default value of `0`."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5e2fcbc7_3122b418","line":10,"updated":"2025-08-12 11:09:30.000000000","message":"Nit: The","commit_id":"392e6cfb86755cf98e06ce766975e797d6e3b7e9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":38284,"name":"Prasant Padhi","display_name":"Prasant Padhi","email":"prasant.padhi@dell.com","username":"prasant.padhi@dell.com"},"change_message_id":"c88e45e5b824b3580fdf9b86530e01a80d9d7149","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bcdd10fe_1d29f9d9","updated":"2025-08-19 04:24:19.000000000","message":"Hi Stanislav,\n\nThanks you for initiating a change to resolve \"Dell PowerFlex support for capacity reservation (933682)\". We are in the process of closing all the opened Launchpad defects on DellEmc Openstack drivers and hence trying to reach out to know when you are planning to close on this defect. Please let us know your input so that it helps us in deciding future course of action and planning.\n\nBest Regards,\nPrasant Padhi","commit_id":"392e6cfb86755cf98e06ce766975e797d6e3b7e9"},{"author":{"_account_id":38284,"name":"Prasant Padhi","display_name":"Prasant Padhi","email":"prasant.padhi@dell.com","username":"prasant.padhi@dell.com"},"change_message_id":"6cb4f2da5d076915e8570e3f8b0e3c5fe121eff2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"098d67fe_e1ec5ed2","updated":"2025-08-13 09:22:46.000000000","message":"The patch takes care of reading reserved_percentage from config. It should also validate and handle over provisioning scenarios when reserved_percentage is set to value \u003e 0.","commit_id":"392e6cfb86755cf98e06ce766975e797d6e3b7e9"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"e93c06e1af2a04dab1f8fe46a39bbf3ef419cb49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"48666b32_a15fe98a","updated":"2025-08-12 11:08:30.000000000","message":"Will reserve backend capacity be reported by cinder in any way?","commit_id":"392e6cfb86755cf98e06ce766975e797d6e3b7e9"}],"cinder/volume/drivers/dell_emc/powerflex/driver.py":[{"author":{"_account_id":38284,"name":"Prasant Padhi","display_name":"Prasant Padhi","email":"prasant.padhi@dell.com","username":"prasant.padhi@dell.com"},"change_message_id":"6cb4f2da5d076915e8570e3f8b0e3c5fe121eff2","unresolved":true,"context_lines":[{"line_number":209,"context_line":"        self.primary_client.do_setup()"},{"line_number":210,"context_line":"        self.secondary_client.do_setup()"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def check_for_setup_error(self):"},{"line_number":213,"context_line":"        client \u003d self._get_client()"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        # validate oversubscription ratio"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf353c40_9917f06f","line":212,"updated":"2025-08-13 09:22:46.000000000","message":"The driver should validate and handle over provisioning scenarios when reserved_percentage is set to value \u003e 0","commit_id":"392e6cfb86755cf98e06ce766975e797d6e3b7e9"},{"author":{"_account_id":38284,"name":"Prasant Padhi","display_name":"Prasant Padhi","email":"prasant.padhi@dell.com","username":"prasant.padhi@dell.com"},"change_message_id":"b5501ef5339494f32a127810db0a72d97df84363","unresolved":true,"context_lines":[{"line_number":209,"context_line":"        self.primary_client.do_setup()"},{"line_number":210,"context_line":"        self.secondary_client.do_setup()"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def check_for_setup_error(self):"},{"line_number":213,"context_line":"        client \u003d self._get_client()"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        # validate oversubscription ratio"}],"source_content_type":"text/x-python","patch_set":3,"id":"46306781_44451bd3","line":212,"in_reply_to":"1f6fe34e_423c24ef","updated":"2025-09-08 14:37:48.000000000","message":"https://docs.openstack.org/cinder/latest/admin/over-subscription.html#:~:text\u003dThe%20existing%20reserved_percentage%20flag%20is%20used%20to%20prevent%20over%20provisioning.%20This%20flag%20represents%20the%20percentage%20of%20the%20back%2Dend%20capacity%20that%20is%20reserved.\n\nI referred to the above documentation for this comment. The doc says, \"The existing reserved_percentage flag is used to prevent over provisioning.\"\nAs I understands, the implementation should prevent further provisoning of the storage as it reaches the value set in reserved_percentage.","commit_id":"392e6cfb86755cf98e06ce766975e797d6e3b7e9"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"e1a55eb74506f2296ea287888be61c2dc72371ca","unresolved":true,"context_lines":[{"line_number":209,"context_line":"        self.primary_client.do_setup()"},{"line_number":210,"context_line":"        self.secondary_client.do_setup()"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def check_for_setup_error(self):"},{"line_number":213,"context_line":"        client \u003d self._get_client()"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        # validate oversubscription ratio"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f6fe34e_423c24ef","line":212,"in_reply_to":"bf353c40_9917f06f","updated":"2025-08-26 19:34:11.000000000","message":"I don\u0027t know how this is supposed to work, because looking at a number of other drivers it seems like the value is simply reported in the stats. I haven\u0027t seen any instance where the driver itself is responsible for implementing/enforcing the value.","commit_id":"392e6cfb86755cf98e06ce766975e797d6e3b7e9"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"e1a55eb74506f2296ea287888be61c2dc72371ca","unresolved":true,"context_lines":[{"line_number":220,"context_line":"                   {\"ratio\": self.configuration.max_over_subscription_ratio,"},{"line_number":221,"context_line":"                    \"powerflex_ratio\": POWERFLEX_MAX_OVERSUBSCRIPTION_RATIO})"},{"line_number":222,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":223,"context_line":"        # validate reserved percentage value"},{"line_number":224,"context_line":"        if not (0 \u003c\u003d self.configuration.reserved_percentage \u003c\u003d 100):"},{"line_number":225,"context_line":"            msg \u003d (_(\"Reserved percentage is configured to %(res_percentage)d \""},{"line_number":226,"context_line":"                     \"while it has to be between 0% and 100%.\") %"}],"source_content_type":"text/x-python","patch_set":3,"id":"1c1eaaa6_901a9fb3","line":223,"updated":"2025-08-26 19:34:11.000000000","message":"This is not necessary, because olso is able to do this validation for you. See [1] for an example.\n\n[1] https://opendev.org/openstack/cinder/src/commit/630afc75b9bce138f6ca7a03a548eb0d6aa6c972/cinder/volume/driver.py#L51","commit_id":"392e6cfb86755cf98e06ce766975e797d6e3b7e9"}],"cinder/volume/drivers/dell_emc/powerflex/options.py":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"e1a55eb74506f2296ea287888be61c2dc72371ca","unresolved":true,"context_lines":[{"line_number":43,"context_line":"POWERFLEX_ALLOW_NON_PADDED_VOLUMES \u003d \"powerflex_allow_non_padded_volumes\""},{"line_number":44,"context_line":"POWERFLEX_ALLOW_MIGRATION_DURING_REBUILD \u003d ("},{"line_number":45,"context_line":"    \"powerflex_allow_migration_during_rebuild\")"},{"line_number":46,"context_line":"POWERFLEX_RESERVED_PERCENTAGE \u003d \"powerflex_reserved_percentage\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"deprecated_opts \u003d ["},{"line_number":49,"context_line":"    cfg.PortOpt(VXFLEXOS_REST_SERVER_PORT,"}],"source_content_type":"text/x-python","patch_set":3,"id":"21072b91_44e0da11","line":46,"updated":"2025-08-26 19:34:11.000000000","message":"Why do you need a specific powerflex option? You should be able to use the common option defined here [1].\n\n[1] https://opendev.org/openstack/cinder/src/commit/630afc75b9bce138f6ca7a03a548eb0d6aa6c972/cinder/volume/driver.py#L49","commit_id":"392e6cfb86755cf98e06ce766975e797d6e3b7e9"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"e93c06e1af2a04dab1f8fe46a39bbf3ef419cb49","unresolved":true,"context_lines":[{"line_number":161,"context_line":"    cfg.IntOpt(POWERFLEX_RESERVED_PERCENTAGE,"},{"line_number":162,"context_line":"               default\u003d0,"},{"line_number":163,"context_line":"               help\u003d\u0027The percentage of backend capacity \u0027"},{"line_number":164,"context_line":"                    \u0027is reserved (integer value).\u0027)"},{"line_number":165,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1645a340_74f33f8a","line":164,"updated":"2025-08-12 11:08:30.000000000","message":"to reserve rather than is reserved.","commit_id":"392e6cfb86755cf98e06ce766975e797d6e3b7e9"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"e1a55eb74506f2296ea287888be61c2dc72371ca","unresolved":true,"context_lines":[{"line_number":161,"context_line":"    cfg.IntOpt(POWERFLEX_RESERVED_PERCENTAGE,"},{"line_number":162,"context_line":"               default\u003d0,"},{"line_number":163,"context_line":"               help\u003d\u0027The percentage of backend capacity \u0027"},{"line_number":164,"context_line":"                    \u0027is reserved (integer value).\u0027)"},{"line_number":165,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"74870388_29ab0f4d","line":164,"in_reply_to":"1645a340_74f33f8a","updated":"2025-08-26 19:34:11.000000000","message":"I agree this is an awkward phrasing, and it\u0027s a copy of the original description added to the cinder code over a decade ago. However, as I noted above, I don\u0027t see why a powerflex version of the option is necessary. Other drivers simply use the common option [1]\n\n[1] https://opendev.org/openstack/cinder/src/commit/630afc75b9bce138f6ca7a03a548eb0d6aa6c972/cinder/volume/driver.py#L49","commit_id":"392e6cfb86755cf98e06ce766975e797d6e3b7e9"}],"doc/source/configuration/block-storage/drivers/dell-emc-powerflex-driver.rst":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"e1a55eb74506f2296ea287888be61c2dc72371ca","unresolved":true,"context_lines":[{"line_number":175,"context_line":"appears in the volume type regardless of the default provisioning type."},{"line_number":176,"context_line":"Maximum oversubscription value supported for PowerFlex is 10.0."},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Backend capacity reservation"},{"line_number":179,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"To configure the percentage of backend capacity reserved,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"e037c06d_e454125f","line":178,"updated":"2025-08-26 19:34:11.000000000","message":"I don\u0027t think it\u0027s necessary to add this to the driver doc if you switch to using the common \u0027reserved_percentage\u0027 option.","commit_id":"392e6cfb86755cf98e06ce766975e797d6e3b7e9"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"e93c06e1af2a04dab1f8fe46a39bbf3ef419cb49","unresolved":true,"context_lines":[{"line_number":178,"context_line":"Backend capacity reservation"},{"line_number":179,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"To configure the percentage of backend capacity reserved,"},{"line_number":182,"context_line":"add the following parameter under the separate section for PowerFlex:"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":".. code-block:: ini"}],"source_content_type":"text/x-rst","patch_set":3,"id":"881548fd_12d9266f","line":181,"updated":"2025-08-12 11:08:30.000000000","message":"reserved backend capacity","commit_id":"392e6cfb86755cf98e06ce766975e797d6e3b7e9"}],"releasenotes/notes/bp-dell-powerflex-11a0b2f327db99f4.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"e1a55eb74506f2296ea287888be61c2dc72371ca","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell PowerFlex driver:"},{"line_number":5,"context_line":"    Support for backend capacity reservation has been added."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6702ca4a_465d9558","line":2,"updated":"2025-08-26 19:34:11.000000000","message":"Since you reference a bug in the commit message, \"fixes\" seems more appropriate than listing this as a feature. And if it\u0027s a bug fix then the bug should be referenced in the release note.","commit_id":"392e6cfb86755cf98e06ce766975e797d6e3b7e9"}]}