)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bbb4d11e0ccfc90638ec198e4082c1137ff9ed63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b385a910_3f123d03","updated":"2024-11-05 18:16:05.000000000","message":"The patch looks good, I\u0027m unsure if this requires a release note or not since the main change was merged and released in Dalmatian and we are in epoxy now. But won\u0027t block the patch for that.","commit_id":"c42f04661705fc283991e54b104c84bf8cec6204"}],"cinder/image/image_utils.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bbb4d11e0ccfc90638ec198e4082c1137ff9ed63","unresolved":true,"context_lines":[{"line_number":1086,"context_line":"                  image_service: glance.GlanceImageService,"},{"line_number":1087,"context_line":"                  image_meta: dict,"},{"line_number":1088,"context_line":"                  volume_path: str,"},{"line_number":1089,"context_line":"                  volume_fd \u003d None,"},{"line_number":1090,"context_line":"                  volume_format: str \u003d \u0027raw\u0027,"},{"line_number":1091,"context_line":"                  run_as_root: bool \u003d True,"},{"line_number":1092,"context_line":"                  compress: bool \u003d True,"}],"source_content_type":"text/x-python","patch_set":1,"id":"6a82e3f5_dc5b087a","line":1089,"range":{"start_line":1089,"start_character":18,"end_line":1089,"end_character":34},"updated":"2024-11-05 18:16:05.000000000","message":"not related to this patch but ideally this should have been the last parameter.\nIf some caller is calling the upload_volume without the key\u003dvalue format, they might send volume_format into volume_fd.\n\nSomething like:\n\n    image_utils.upload_volume(ctxt, img_serv, img_meta, vol_path, vol_format, True, False ...)\n\nhere vol_format is passed to volume_fd.","commit_id":"c42f04661705fc283991e54b104c84bf8cec6204"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0d134c7984473139b5964bae707105cc0d5be7af","unresolved":true,"context_lines":[{"line_number":1086,"context_line":"                  image_service: glance.GlanceImageService,"},{"line_number":1087,"context_line":"                  image_meta: dict,"},{"line_number":1088,"context_line":"                  volume_path: str,"},{"line_number":1089,"context_line":"                  volume_fd \u003d None,"},{"line_number":1090,"context_line":"                  volume_format: str \u003d \u0027raw\u0027,"},{"line_number":1091,"context_line":"                  run_as_root: bool \u003d True,"},{"line_number":1092,"context_line":"                  compress: bool \u003d True,"}],"source_content_type":"text/x-python","patch_set":1,"id":"4cb9c322_752e8760","line":1089,"range":{"start_line":1089,"start_character":18,"end_line":1089,"end_character":34},"in_reply_to":"6a82e3f5_dc5b087a","updated":"2024-11-06 16:41:48.000000000","message":"This depends on what your expectations are about kwarg parameters, which are unfortunately ambiguous in python. Fortunately, modern python gives us ways to fix this.\n\nSee https://review.opendev.org/c/openstack/cinder/+/934257 as an example.","commit_id":"c42f04661705fc283991e54b104c84bf8cec6204"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bbb4d11e0ccfc90638ec198e4082c1137ff9ed63","unresolved":true,"context_lines":[{"line_number":1105,"context_line":"                      image_id, volume_format, image_meta[\u0027disk_format\u0027])"},{"line_number":1106,"context_line":"            if volume_fd is not None:"},{"line_number":1107,"context_line":"                image_service.update(context, image_id, {},"},{"line_number":1108,"context_line":"                                     tpool.Proxy(volume_fd),"},{"line_number":1109,"context_line":"                                     store_id\u003dstore_id,"},{"line_number":1110,"context_line":"                                     base_image_ref\u003dbase_image_ref)"},{"line_number":1111,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"33afee19_0b5848c9","line":1108,"range":{"start_line":1108,"start_character":37,"end_line":1108,"end_character":59},"updated":"2024-11-05 18:16:05.000000000","message":"so this is a new path introduced for the RBD driver (or other drivers that wants to leverage it).\nMakes sense to do because of librbd and also we have same code in the other upload path.","commit_id":"c42f04661705fc283991e54b104c84bf8cec6204"}]}