)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0012c9f9e8815f60f6d1a98bbe582aa742703f04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1240dd57_7ab5ddf9","updated":"2026-11-05 13:30:50.000000000","message":"Overall the change is good; I have one thing noted inline that I think should be addressed to prevent non-case-sensitivity from accumulating.  But it\u0027s a quick change.  Conceptually, this looks fine.","commit_id":"452b3856add1953469361d1aba364d347c0e9f27"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"dafa5917674065dc92494e8e20718adaf2acfbd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"82c175e7_2a6c40b5","updated":"2024-11-14 15:33:41.000000000","message":"This works for the purposes of the tests glance runs, but obviously could use a cinder-knowing eye. Can you have a look please?","commit_id":"452b3856add1953469361d1aba364d347c0e9f27"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"cb7427b9a5202de17033abded58fabc018356aeb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bd86a095_14506dfc","updated":"2026-11-11 13:18:21.000000000","message":"Important change to unblock glance for gpt disk format.","commit_id":"504d86e5d823b218bdcae699328a7736902a7450"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"febe1d521ce674bda0fb3ef5fb0b0c7ff31c68a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d008b932_7ab88db6","updated":"2026-11-05 14:53:43.000000000","message":"Revision LGTM.","commit_id":"504d86e5d823b218bdcae699328a7736902a7450"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"0c117796821bab6d750564384e88ed8ae75efbfd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e64a4e19_fb7e1d28","updated":"2026-11-06 14:34:27.000000000","message":"recheck","commit_id":"504d86e5d823b218bdcae699328a7736902a7450"}],"cinder/image/image_utils.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e7b459f800c0d90852058ad0c4e52350c5828c1e","unresolved":true,"context_lines":[{"line_number":825,"context_line":"            # We also use lower() here (though nowhere else) to be consistent"},{"line_number":826,"context_line":"            # with that change."},{"line_number":827,"context_line":"            pass"},{"line_number":828,"context_line":"        elif src_format.lower() \u003d\u003d \u0027gpt\u0027 and data.file_format \u003d\u003d \u0027raw\u0027:"},{"line_number":829,"context_line":"            # qemu-img does not distinguish between gpt and raw, so this is"},{"line_number":830,"context_line":"            # actually a match"},{"line_number":831,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":3,"id":"ce529717_7b7fb59b","line":828,"range":{"start_line":828,"start_character":13,"end_line":828,"end_character":40},"updated":"2026-10-28 02:21:13.000000000","message":"I guess I\u0027m unaware about the whole effort on glance side but it\u0027s pretty confusing to me that we now accept gpt as an image format.\nOn one hand, gpt seems to be the more trusted (compared to raw) to ensure that the disk contains a partition table and should be bootable\non the other hand, raw is the container and gpt is the content inside it so i thought gpt should be a separate format (not image format) since qcow2 can also hold gpt inside?\nOverall, I\u0027m unsure about this and maybe someone with more in depth understanding of the effort can do a better job at reviewing it.","commit_id":"452b3856add1953469361d1aba364d347c0e9f27"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0012c9f9e8815f60f6d1a98bbe582aa742703f04","unresolved":true,"context_lines":[{"line_number":825,"context_line":"            # We also use lower() here (though nowhere else) to be consistent"},{"line_number":826,"context_line":"            # with that change."},{"line_number":827,"context_line":"            pass"},{"line_number":828,"context_line":"        elif src_format.lower() \u003d\u003d \u0027gpt\u0027 and data.file_format \u003d\u003d \u0027raw\u0027:"},{"line_number":829,"context_line":"            # qemu-img does not distinguish between gpt and raw, so this is"},{"line_number":830,"context_line":"            # actually a match"},{"line_number":831,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":3,"id":"abff1619_278701cd","line":828,"range":{"start_line":828,"start_character":24,"end_line":828,"end_character":40},"updated":"2026-11-05 13:30:50.000000000","message":"This is kind of a nit, but also kind of not.  I don\u0027t think we should use .lower() here.  It\u0027s used at line 823 for (probably not very good) legacy reasons on the cinder side, but the Glance image schema defines the disk_format as an enum of lower-cased strings.  So I think we should recognize only \u0027gpt\u0027 here, as we do for everything except \u0027ami\u0027.\n\nI realize that this slightly complicates the unit test situation (though mostly in terms of comments; \u0027GPT\u0027 isn\u0027t actually tested).","commit_id":"452b3856add1953469361d1aba364d347c0e9f27"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8e299db32d093e32167bbdff015c4fc99b7ad5e4","unresolved":true,"context_lines":[{"line_number":825,"context_line":"            # We also use lower() here (though nowhere else) to be consistent"},{"line_number":826,"context_line":"            # with that change."},{"line_number":827,"context_line":"            pass"},{"line_number":828,"context_line":"        elif src_format.lower() \u003d\u003d \u0027gpt\u0027 and data.file_format \u003d\u003d \u0027raw\u0027:"},{"line_number":829,"context_line":"            # qemu-img does not distinguish between gpt and raw, so this is"},{"line_number":830,"context_line":"            # actually a match"},{"line_number":831,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":3,"id":"6561d11f_a962d941","line":828,"range":{"start_line":828,"start_character":13,"end_line":828,"end_character":40},"in_reply_to":"96941d22_49ca7d89","updated":"2026-10-28 19:51:46.000000000","message":"Ack, looks like glance already has the precedent of supporting different formats that are treated as raw (like iso and ami) so maybe this is fine","commit_id":"452b3856add1953469361d1aba364d347c0e9f27"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"01a7fd7ed5baa9ded771735c61bd47646fc8518b","unresolved":false,"context_lines":[{"line_number":825,"context_line":"            # We also use lower() here (though nowhere else) to be consistent"},{"line_number":826,"context_line":"            # with that change."},{"line_number":827,"context_line":"            pass"},{"line_number":828,"context_line":"        elif src_format.lower() \u003d\u003d \u0027gpt\u0027 and data.file_format \u003d\u003d \u0027raw\u0027:"},{"line_number":829,"context_line":"            # qemu-img does not distinguish between gpt and raw, so this is"},{"line_number":830,"context_line":"            # actually a match"},{"line_number":831,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":3,"id":"40034171_3aaa3953","line":828,"range":{"start_line":828,"start_character":24,"end_line":828,"end_character":40},"in_reply_to":"abff1619_278701cd","updated":"2026-11-05 14:34:42.000000000","message":"Done","commit_id":"452b3856add1953469361d1aba364d347c0e9f27"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"e0780055ce6cebb1afdd75ac36d12bad92aef5d5","unresolved":true,"context_lines":[{"line_number":825,"context_line":"            # We also use lower() here (though nowhere else) to be consistent"},{"line_number":826,"context_line":"            # with that change."},{"line_number":827,"context_line":"            pass"},{"line_number":828,"context_line":"        elif src_format.lower() \u003d\u003d \u0027gpt\u0027 and data.file_format \u003d\u003d \u0027raw\u0027:"},{"line_number":829,"context_line":"            # qemu-img does not distinguish between gpt and raw, so this is"},{"line_number":830,"context_line":"            # actually a match"},{"line_number":831,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":3,"id":"96941d22_49ca7d89","line":828,"range":{"start_line":828,"start_character":13,"end_line":828,"end_character":40},"in_reply_to":"ce529717_7b7fb59b","updated":"2026-10-28 05:49:09.000000000","message":"Thanks Rajat, fair question.\n\nSo disk_format\u003dgpt just means the image file is a plain disk that has a GPT partition table. qemu-img does not know the name gpt. It sees the file as raw, same as it does for an iso. So this patch tells Cinder to pass gpt to qemu as raw, and this check allows that match. Same idea as the ami check just above.\n\nIf the file is qcow2, and the disk inside it has a GPT table, the format stays qcow2. Glance looks at the file itself, not at what is packed inside another format.\n\nWe put this in disk_format because that is the field Nova and Cinder already use when they talk to qemu. It does not mean the image is safer than raw, or that it will boot. Glance still runs the safety checks.\n\nThe Glance side is https://review.opendev.org/c/openstack/glance/+/933601. This Cinder patch only teaches Cinder how to handle that format.","commit_id":"452b3856add1953469361d1aba364d347c0e9f27"}]}