)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"d038b0ced8ceed225a9ce6a1c9dd90fd296a17f7","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     donghunkimzack \u003cbigheadzacky@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-11-18 10:44:09 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Title: Fix PowerFlex volume size mismatch with volume cache"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When creating a volume from an uncached image with volume cache enabled,"},{"line_number":10,"context_line":"PowerFlex driver initially creates volume with image size and extends"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"0f55713c_e0399588","line":7,"updated":"2024-11-25 18:02:51.000000000","message":"Nit, no need to use \"Title: \" as this is the subject line, just the statement itself is sufficient.","commit_id":"57c53fbba6228c5729617e15ee771903464041c9"},{"author":{"_account_id":37469,"name":"DongHun, Kim","display_name":"DongHun, Kim","email":"bigheadzacky@gmail.com","username":"donghunkimzack"},"change_message_id":"e13a54aa39320d7152a271ec1a686b83d79c20e5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     donghunkimzack \u003cbigheadzacky@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-11-18 10:44:09 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Title: Fix PowerFlex volume size mismatch with volume cache"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When creating a volume from an uncached image with volume cache enabled,"},{"line_number":10,"context_line":"PowerFlex driver initially creates volume with image size and extends"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e5207d9f_b501469c","line":7,"in_reply_to":"0f55713c_e0399588","updated":"2024-11-26 03:18:55.000000000","message":"removed the title\nDone","commit_id":"57c53fbba6228c5729617e15ee771903464041c9"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"5a9877cf28c9161c45736738969f52ca5096e423","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     donghunkimzack \u003cbigheadzacky@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-12-18 09:56:26 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Title: Fix PowerFlex volume size mismatch with volume cache"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When creating a volume from an uncached image with volume cache enabled,"},{"line_number":10,"context_line":"PowerFlex driver initially creates volume with image size and extends"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"67542451_d6ecf5c3","line":7,"updated":"2025-01-12 18:02:09.000000000","message":"For future reference, you don\u0027t need to put \"Title:\" in the title.","commit_id":"844e5a88db1b26c9528852e86901da9db56ac085"},{"author":{"_account_id":37469,"name":"DongHun, Kim","display_name":"DongHun, Kim","email":"bigheadzacky@gmail.com","username":"donghunkimzack"},"change_message_id":"c841849ce665e4d2699e9daa544f78f83b76fac0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     donghunkimzack \u003cbigheadzacky@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-12-18 09:56:26 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Title: Fix PowerFlex volume size mismatch with volume cache"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When creating a volume from an uncached image with volume cache enabled,"},{"line_number":10,"context_line":"PowerFlex driver initially creates volume with image size and extends"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"8ed77877_d20d9728","line":7,"in_reply_to":"67542451_d6ecf5c3","updated":"2025-01-13 08:05:04.000000000","message":"Done","commit_id":"844e5a88db1b26c9528852e86901da9db56ac085"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"d038b0ced8ceed225a9ce6a1c9dd90fd296a17f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e3860996_2a2567de","updated":"2024-11-25 18:02:51.000000000","message":"This makes sense to me and I think the code is okay.  But, this is not an area I feel most comfortable in, saving approval for someone more qualified.","commit_id":"57c53fbba6228c5729617e15ee771903464041c9"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"dd33d3b488d5657f2dea7113cb08a584463b39a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b51bd588_598055ea","updated":"2024-12-17 12:18:12.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"6c6ced8672fff6114f8b382b1b3aaf0e0be6a8f8"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c9dbc96247e19b92d75ba96a534ac321f3a7d6b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f7ccee1e_668760d4","updated":"2024-12-18 01:19:44.000000000","message":"Thanks! I\u0027m assuming third party CI will (eventually) be good on this.","commit_id":"844e5a88db1b26c9528852e86901da9db56ac085"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"434177034c84f2864bc8b6a2a8ea7b254b972545","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9fa8b439_9b3bf926","updated":"2025-02-05 14:22:05.000000000","message":"Hi @Nilesh, could you please review this?","commit_id":"dd55ecf1ab597124e9035244668d41a158cbea7c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"9081189cb4a797367276e0d7aaca7776747450f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"de310942_586ff762","updated":"2025-06-03 10:59:48.000000000","message":"Hi, any chance that we can push this issue forward?","commit_id":"dd55ecf1ab597124e9035244668d41a158cbea7c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"72a61a1ca85495a502245173b678f7a9a0048a7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"62c15d8c_1d15750e","updated":"2025-02-11 10:09:42.000000000","message":"Please check my comments","commit_id":"dd55ecf1ab597124e9035244668d41a158cbea7c"},{"author":{"_account_id":37469,"name":"DongHun, Kim","display_name":"DongHun, Kim","email":"bigheadzacky@gmail.com","username":"donghunkimzack"},"change_message_id":"c841849ce665e4d2699e9daa544f78f83b76fac0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6dcb561b_b5d8a140","updated":"2025-01-13 08:05:04.000000000","message":"removed the title","commit_id":"dd55ecf1ab597124e9035244668d41a158cbea7c"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"f37c90afa32fdc3640cfa93785da8af741df5edc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e12f3761_1c0646ec","updated":"2025-02-05 14:35:45.000000000","message":"sure, will check it. thanks for creating a patch.","commit_id":"dd55ecf1ab597124e9035244668d41a158cbea7c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"6fdc71154d841374094f08e9efb1906afa6f92c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5e705706_4e37c062","updated":"2025-02-13 10:36:40.000000000","message":"thanks, we try to push our current issues in other way than","commit_id":"dd55ecf1ab597124e9035244668d41a158cbea7c"},{"author":{"_account_id":37469,"name":"DongHun, Kim","display_name":"DongHun, Kim","email":"bigheadzacky@gmail.com","username":"donghunkimzack"},"change_message_id":"7299de08d7867ff68cb1633ff6fdfe1c46342001","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c0ed7e0b_ebd403a6","in_reply_to":"62c15d8c_1d15750e","updated":"2025-02-13 05:06:26.000000000","message":"The issue you raised is based on a misinterpretation; I’ve detailed the actual cause in my comment.","commit_id":"dd55ecf1ab597124e9035244668d41a158cbea7c"}],"cinder/volume/drivers/dell_emc/powerflex/driver.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"91cdd6be85f4e2eef18fc64ff8d71ed41a0dd04d","unresolved":true,"context_lines":[{"line_number":836,"context_line":"            )"},{"line_number":837,"context_line":"            self._get_client(secondary\u003dTrue).extend_volume(remote_vol_id,"},{"line_number":838,"context_line":"                                                           volume_new_size)"},{"line_number":839,"context_line":"        self._get_client().extend_volume(volume.provider_id, volume_new_size)"},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"    def create_cloned_volume(self, volume, src_vref):"},{"line_number":842,"context_line":"        \"\"\"Create cloned volume on PowerFlex storage backend."}],"source_content_type":"text/x-python","patch_set":4,"id":"89c1bf9f_e9d2cf1a","line":839,"range":{"start_line":839,"start_character":19,"end_line":839,"end_character":20},"updated":"2025-02-05 15:32:43.000000000","message":"As powerflex allocates sizes dividable by 8 as I know here you can check if the new_size or the volume_new_size is the real new value for the volume, and return with it like:\nmodel_updates \u003d {\u0027size\u0027: new_size}\nif new_size !\u003d volume_new_size:\n    model_updates[\u0027size\u0027] \u003d volume_new_size\nreturn model_updates\nand in create_volume.py you can use this value to return with the good size.","commit_id":"dd55ecf1ab597124e9035244668d41a158cbea7c"},{"author":{"_account_id":37469,"name":"DongHun, Kim","display_name":"DongHun, Kim","email":"bigheadzacky@gmail.com","username":"donghunkimzack"},"change_message_id":"5fc5e59765263dedf8036cd4423212b5227ff174","unresolved":false,"context_lines":[{"line_number":836,"context_line":"            )"},{"line_number":837,"context_line":"            self._get_client(secondary\u003dTrue).extend_volume(remote_vol_id,"},{"line_number":838,"context_line":"                                                           volume_new_size)"},{"line_number":839,"context_line":"        self._get_client().extend_volume(volume.provider_id, volume_new_size)"},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"    def create_cloned_volume(self, volume, src_vref):"},{"line_number":842,"context_line":"        \"\"\"Create cloned volume on PowerFlex storage backend."}],"source_content_type":"text/x-python","patch_set":4,"id":"34c91e96_d62c6d13","line":839,"range":{"start_line":839,"start_character":19,"end_line":839,"end_character":20},"in_reply_to":"7e342d7e_ffb455e1","updated":"2025-02-13 05:07:07.000000000","message":"Done","commit_id":"dd55ecf1ab597124e9035244668d41a158cbea7c"},{"author":{"_account_id":37469,"name":"DongHun, Kim","display_name":"DongHun, Kim","email":"bigheadzacky@gmail.com","username":"donghunkimzack"},"change_message_id":"7299de08d7867ff68cb1633ff6fdfe1c46342001","unresolved":true,"context_lines":[{"line_number":836,"context_line":"            )"},{"line_number":837,"context_line":"            self._get_client(secondary\u003dTrue).extend_volume(remote_vol_id,"},{"line_number":838,"context_line":"                                                           volume_new_size)"},{"line_number":839,"context_line":"        self._get_client().extend_volume(volume.provider_id, volume_new_size)"},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"    def create_cloned_volume(self, volume, src_vref):"},{"line_number":842,"context_line":"        \"\"\"Create cloned volume on PowerFlex storage backend."}],"source_content_type":"text/x-python","patch_set":4,"id":"7e342d7e_ffb455e1","line":839,"range":{"start_line":839,"start_character":19,"end_line":839,"end_character":20},"in_reply_to":"89c1bf9f_e9d2cf1a","updated":"2025-02-13 05:06:26.000000000","message":"The reported issue is unrelated to PowerFlex’s 8GB allocation rule (which works as intended).  \nThe root cause lies in **volume creation with uncached images** when caching is enabled\n\n1. OpenStack initially creates a volume using the **image’s minimum size**\n   (not the user’s requested size).  \n2. If the user’s requested size differs, an `extend` operation adjusts the volume.  \n3. The **`model_updates` dictionary** fails to propagate the new size to OpenStack’s database during `extend`.  \n\nThis creates a mismatch between the **actual PowerFlex volume size** and **OpenStack’s recorded size**.  \nThe fix ensures `model_updates` reflects the final size post-extension.","commit_id":"dd55ecf1ab597124e9035244668d41a158cbea7c"}],"cinder/volume/flows/manager/create_volume.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"91cdd6be85f4e2eef18fc64ff8d71ed41a0dd04d","unresolved":true,"context_lines":[{"line_number":1055,"context_line":"            # letting it be raised further up the stack."},{"line_number":1056,"context_line":"            if volume.size !\u003d original_size:"},{"line_number":1057,"context_line":"                try:"},{"line_number":1058,"context_line":"                    self.driver.extend_volume(volume, original_size)"},{"line_number":1059,"context_line":"                finally:"},{"line_number":1060,"context_line":"                    volume.size \u003d original_size"},{"line_number":1061,"context_line":"                    volume.save()"},{"line_number":1062,"context_line":"                    if model_update:"},{"line_number":1063,"context_line":"                        model_update[\u0027size\u0027] \u003d original_size"},{"line_number":1064,"context_line":""},{"line_number":1065,"context_line":"        return model_update"},{"line_number":1066,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"eba72848_dd1dd8da","line":1063,"range":{"start_line":1058,"start_character":20,"end_line":1063,"end_character":60},"updated":"2025-02-05 15:32:43.000000000","message":"A I wrote in powerflex driver.py as comment if the extend_volume returns a model_update with the correct size you can use that here, as the allocated size can be different from original size in case of powerflex.","commit_id":"dd55ecf1ab597124e9035244668d41a158cbea7c"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"05e8c8be77b81d5fcb1b799ed2df360711527f7a","unresolved":true,"context_lines":[{"line_number":1060,"context_line":"                    volume.size \u003d original_size"},{"line_number":1061,"context_line":"                    volume.save()"},{"line_number":1062,"context_line":"                    if model_update:"},{"line_number":1063,"context_line":"                        model_update[\u0027size\u0027] \u003d original_size"},{"line_number":1064,"context_line":""},{"line_number":1065,"context_line":"        return model_update"},{"line_number":1066,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"cc0bcb8c_6e85d4ef","line":1063,"updated":"2025-02-14 16:30:45.000000000","message":"This seems problematic here.  forcing the size to original size? This can affect every driver in cinder.  I\u0027m not sure this is the right thing to do.","commit_id":"dd55ecf1ab597124e9035244668d41a158cbea7c"},{"author":{"_account_id":37469,"name":"DongHun, Kim","display_name":"DongHun, Kim","email":"bigheadzacky@gmail.com","username":"donghunkimzack"},"change_message_id":"5fc5e59765263dedf8036cd4423212b5227ff174","unresolved":false,"context_lines":[{"line_number":1055,"context_line":"            # letting it be raised further up the stack."},{"line_number":1056,"context_line":"            if volume.size !\u003d original_size:"},{"line_number":1057,"context_line":"                try:"},{"line_number":1058,"context_line":"                    self.driver.extend_volume(volume, original_size)"},{"line_number":1059,"context_line":"                finally:"},{"line_number":1060,"context_line":"                    volume.size \u003d original_size"},{"line_number":1061,"context_line":"                    volume.save()"},{"line_number":1062,"context_line":"                    if model_update:"},{"line_number":1063,"context_line":"                        model_update[\u0027size\u0027] \u003d original_size"},{"line_number":1064,"context_line":""},{"line_number":1065,"context_line":"        return model_update"},{"line_number":1066,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da67c323_2d3864ef","line":1063,"range":{"start_line":1058,"start_character":20,"end_line":1063,"end_character":60},"in_reply_to":"428e594b_e86a7ebf","updated":"2025-02-13 05:07:07.000000000","message":"Done","commit_id":"dd55ecf1ab597124e9035244668d41a158cbea7c"},{"author":{"_account_id":37469,"name":"DongHun, Kim","display_name":"DongHun, Kim","email":"bigheadzacky@gmail.com","username":"donghunkimzack"},"change_message_id":"88f5c92a7b3f8d8ef0f1b8038afa493414d7bf4c","unresolved":false,"context_lines":[{"line_number":1060,"context_line":"                    volume.size \u003d original_size"},{"line_number":1061,"context_line":"                    volume.save()"},{"line_number":1062,"context_line":"                    if model_update:"},{"line_number":1063,"context_line":"                        model_update[\u0027size\u0027] \u003d original_size"},{"line_number":1064,"context_line":""},{"line_number":1065,"context_line":"        return model_update"},{"line_number":1066,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5e813e6f_569af276","line":1063,"in_reply_to":"cc0bcb8c_6e85d4ef","updated":"2025-02-21 01:26:08.000000000","message":"If the volume is being extended, it\u0027s essential to update both the volume object and the database to ensure consistency. If this approach is problematic, perhaps the extend operation itself should be reconsidered.","commit_id":"dd55ecf1ab597124e9035244668d41a158cbea7c"},{"author":{"_account_id":37469,"name":"DongHun, Kim","display_name":"DongHun, Kim","email":"bigheadzacky@gmail.com","username":"donghunkimzack"},"change_message_id":"7299de08d7867ff68cb1633ff6fdfe1c46342001","unresolved":true,"context_lines":[{"line_number":1055,"context_line":"            # letting it be raised further up the stack."},{"line_number":1056,"context_line":"            if volume.size !\u003d original_size:"},{"line_number":1057,"context_line":"                try:"},{"line_number":1058,"context_line":"                    self.driver.extend_volume(volume, original_size)"},{"line_number":1059,"context_line":"                finally:"},{"line_number":1060,"context_line":"                    volume.size \u003d original_size"},{"line_number":1061,"context_line":"                    volume.save()"},{"line_number":1062,"context_line":"                    if model_update:"},{"line_number":1063,"context_line":"                        model_update[\u0027size\u0027] \u003d original_size"},{"line_number":1064,"context_line":""},{"line_number":1065,"context_line":"        return model_update"},{"line_number":1066,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"428e594b_e86a7ebf","line":1063,"range":{"start_line":1058,"start_character":20,"end_line":1063,"end_character":60},"in_reply_to":"eba72848_dd1dd8da","updated":"2025-02-13 05:06:26.000000000","message":"A deeper refactoring could improve size alignment but would require major code changes. This fix preserves existing structure while addressing the model_update gap in extend_volume, ensuring backward compatibility. It offers the simplest resolution for the current discrepancy.","commit_id":"dd55ecf1ab597124e9035244668d41a158cbea7c"}],"releasenotes/notes/bug-2088132-powerflex-volume-size-mismatch-3269b71c388d744b.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"dd33d3b488d5657f2dea7113cb08a584463b39a5","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed a volume size mismatch issue in the PowerFlex driver when creating"},{"line_number":5,"context_line":"    volumes from uncached images with volume cache enabled. Previously, when"},{"line_number":6,"context_line":"    a volume was created and then extended to match the requested size, the"},{"line_number":7,"context_line":"    final size was not properly updated in the model, resulting in a size"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"52a1cf26_307dd0eb","line":4,"updated":"2024-12-17 12:18:12.000000000","message":"If you do an update...\n\nThe Cinder release notes convention for bug fixes was to start with \"Bug #2088132: Fixed a volume size mismatch...\" with the bug reference being a link to the actual bug report, though it doesn\u0027t look like that has been strictly followed lately. Still, it would be nice to do if you have another reason for updating this review.","commit_id":"6c6ced8672fff6114f8b382b1b3aaf0e0be6a8f8"},{"author":{"_account_id":37469,"name":"DongHun, Kim","display_name":"DongHun, Kim","email":"bigheadzacky@gmail.com","username":"donghunkimzack"},"change_message_id":"2e0032e5a80e2d37ef15334781f9a961bb24c073","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed a volume size mismatch issue in the PowerFlex driver when creating"},{"line_number":5,"context_line":"    volumes from uncached images with volume cache enabled. Previously, when"},{"line_number":6,"context_line":"    a volume was created and then extended to match the requested size, the"},{"line_number":7,"context_line":"    final size was not properly updated in the model, resulting in a size"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"265c5349_cad500e1","line":4,"in_reply_to":"52a1cf26_307dd0eb","updated":"2024-12-18 01:01:36.000000000","message":"Thank you for pointing that out. As this is my first contribution, I wasn\u0027t fully aware of the conventions. I\u0027ve made the changes as you suggested.","commit_id":"6c6ced8672fff6114f8b382b1b3aaf0e0be6a8f8"}]}
