)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"0e3aaef0ea394bd00a38f23813537d9c876fc666","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Simon Dodsley \u003csimon@purestorage.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-11-29 19:15:49 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix: typo in pure driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #2083532"},{"line_number":10,"context_line":"Change-Id: Ib4788d13aa724d86d662442dae344ac0b365374e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f065c6e_b5013b23","line":7,"updated":"2024-12-20 02:57:21.000000000","message":"NIT: The fix itself is quite simple but impacts a core functionality (creating volumes). I suggest adding a paragraph describing what issue the patch intends to address. IMO copy-paste the release notes should be enough.","commit_id":"397848c3c971cf94efd0defa45849723dfddb69b"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"ed45a96fd572a6df2dfca7e0be903a9f19d1e42a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Simon Dodsley \u003csimon@purestorage.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-11-29 19:15:49 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix: typo in pure driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #2083532"},{"line_number":10,"context_line":"Change-Id: Ib4788d13aa724d86d662442dae344ac0b365374e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3d2acded_8e995f95","line":7,"in_reply_to":"7f065c6e_b5013b23","updated":"2024-12-20 15:04:18.000000000","message":"Done","commit_id":"397848c3c971cf94efd0defa45849723dfddb69b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"36cae20382eb7fe278bfd3b270b62978649c1ee0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ca0ce7f0_8cdacdf1","updated":"2024-12-20 17:05:17.000000000","message":"This is a simple change isolated to a single driver, and the patch adds unit tests. Looks like an appropriate backport.","commit_id":"77bf5a494a652992754a468a76e61bcf97d1c2e3"}],"cinder/tests/unit/volume/drivers/test_pure.py":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"1bd1c53f08cbaa043007d154aa0fa3f7249cd80e","unresolved":true,"context_lines":[{"line_number":4107,"context_line":"        mock_get_repl_type.return_value \u003d None"},{"line_number":4108,"context_line":""},{"line_number":4109,"context_line":"        self.driver.create_volume(vol)"},{"line_number":4110,"context_line":"        self.array.post_volumes.\\"},{"line_number":4111,"context_line":"            assert_called_with(names\u003d[vol_name],"},{"line_number":4112,"context_line":"                               with_default_protection\u003dFalse,"},{"line_number":4113,"context_line":"                               volume\u003dmock_data)"}],"source_content_type":"text/x-python","patch_set":1,"id":"b1c27318_cb19a1d6","line":4110,"updated":"2024-12-20 03:14:50.000000000","message":"NIT: A common practice is to use Parentheses instead of Backslashes for line continuation as described in the OpenStack code guidelines [1].\n\nhttps://docs.openstack.org/hacking/latest/user/hacking.html#general","commit_id":"397848c3c971cf94efd0defa45849723dfddb69b"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"ed45a96fd572a6df2dfca7e0be903a9f19d1e42a","unresolved":true,"context_lines":[{"line_number":4107,"context_line":"        mock_get_repl_type.return_value \u003d None"},{"line_number":4108,"context_line":""},{"line_number":4109,"context_line":"        self.driver.create_volume(vol)"},{"line_number":4110,"context_line":"        self.array.post_volumes.\\"},{"line_number":4111,"context_line":"            assert_called_with(names\u003d[vol_name],"},{"line_number":4112,"context_line":"                               with_default_protection\u003dFalse,"},{"line_number":4113,"context_line":"                               volume\u003dmock_data)"}],"source_content_type":"text/x-python","patch_set":1,"id":"b4845c2d_e51a5b47","line":4110,"in_reply_to":"b1c27318_cb19a1d6","updated":"2024-12-20 15:04:18.000000000","message":"Agreed, but this has been accepted into master so changing this here is sort of a waste of time as Epoxy won\u0027t have this fix and this backport is not going any further back.","commit_id":"397848c3c971cf94efd0defa45849723dfddb69b"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"29929c7e5b2f261d0e5cd53b7b933f043fbd3b07","unresolved":false,"context_lines":[{"line_number":4107,"context_line":"        mock_get_repl_type.return_value \u003d None"},{"line_number":4108,"context_line":""},{"line_number":4109,"context_line":"        self.driver.create_volume(vol)"},{"line_number":4110,"context_line":"        self.array.post_volumes.\\"},{"line_number":4111,"context_line":"            assert_called_with(names\u003d[vol_name],"},{"line_number":4112,"context_line":"                               with_default_protection\u003dFalse,"},{"line_number":4113,"context_line":"                               volume\u003dmock_data)"}],"source_content_type":"text/x-python","patch_set":1,"id":"75b3c274_14fc17fd","line":4110,"in_reply_to":"b4845c2d_e51a5b47","updated":"2024-12-23 14:21:55.000000000","message":"hey Simon, my bad I hadn\u0027t realized this was actually a backport. Yes, there is no benefit in making this change. I\u0027m marking it is a resolved.","commit_id":"397848c3c971cf94efd0defa45849723dfddb69b"}],"releasenotes/notes/pure-storage-driver-typo-a24d19021f25a4f8.yaml":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"e3432500fafb653e9dbf89a58739b1c82917a124","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #2083532 \u003chttps://bugs.launchpad.net/cinder/+bug/2083532\u003e`_:"},{"line_number":5,"context_line":"    [Pure Storage] Fixed creation of volumes with only IOPS qos."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"78cb51ce_8a087779","line":5,"updated":"2024-12-20 03:35:18.000000000","message":"It is common practice adding a trailing newline to all files. IIRC some checking scripts might fail in case a newline isn\u0027t added to the end of some files.","commit_id":"397848c3c971cf94efd0defa45849723dfddb69b"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"ed45a96fd572a6df2dfca7e0be903a9f19d1e42a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #2083532 \u003chttps://bugs.launchpad.net/cinder/+bug/2083532\u003e`_:"},{"line_number":5,"context_line":"    [Pure Storage] Fixed creation of volumes with only IOPS qos."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7be411f0_90127aca","line":5,"in_reply_to":"78cb51ce_8a087779","updated":"2024-12-20 15:04:18.000000000","message":"Done","commit_id":"397848c3c971cf94efd0defa45849723dfddb69b"}]}