)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"6865584f3e4f6bf606f2d2922b3a1a96751ec57f","unresolved":true,"context_lines":[{"line_number":13,"context_line":"errors in operations that requires checking for volume size"},{"line_number":14,"context_line":"consistency."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Such checks aims to prevent users from extending NFS volumes"},{"line_number":17,"context_line":"from within the virtual machine and outside of Cinder scope, by"},{"line_number":18,"context_line":"comparing the virtual size of the NFS image with its size stored"},{"line_number":19,"context_line":"in Cinder\u0027s database."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":30,"id":"99877b04_c176f447","line":16,"range":{"start_line":16,"start_character":12,"end_line":16,"end_character":16},"updated":"2025-12-19 15:28:30.000000000","message":"nit: aim","commit_id":"c68475a3d0dd54812f3618962c940fd70fd4b381"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"0440be5e63cec155bf1aa1b359455c1c3173ff72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c4641744_615f157b","updated":"2025-03-27 12:57:18.000000000","message":"recheck","commit_id":"625946e14869cd9812cacb4fe5a4112506185fea"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"7d660e5c88e23b6dfc978bcded824722dbf991dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"e9ab43b2_841714f8","updated":"2025-03-28 16:31:23.000000000","message":"recheck","commit_id":"b3e955bd2c16f719f93ef91a6875cede866cb3c4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f2b824faa01eda365a681d13d64b2908c3b2eb71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"e3334b1b_01103ea3","updated":"2025-05-30 14:36:05.000000000","message":"Code and tests LGTM.","commit_id":"541531746c46d1e58237606f9061048ceaeee20f"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"979b1e4d84d7298712ffb5dd345f3f7c3873ff17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"a62b34db_4c1032c5","updated":"2025-07-24 01:58:53.000000000","message":"Looks good to me.  Carrying over Brian\u0027s +2 as the last upload was a rebase.","commit_id":"d9d5ce5c5a0422e6d590fd5df7f3992c53bd9a99"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"03138756f04a35cd8140d8a2705f65ced89e437f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"e397ab16_2fec2db6","updated":"2025-10-16 04:37:41.000000000","message":"recheck","commit_id":"28e8f07bc52f0d1cf577e2d9a12c957dfbb9d2f7"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"ec868a230b07d01d789331f8fc7cedcba5be57b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"53794875_ff7c805f","updated":"2025-10-31 16:01:18.000000000","message":"-W: we have other patches in the relation chain that needs to be merged first.","commit_id":"1c08d330a6e4a467bae8437c4d1d0b2905e4a12e"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"0ed4116b83c67af85bcc2c08e2cae791a01e9fbc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"eaddc4d9_c868ad91","updated":"2025-11-06 07:53:02.000000000","message":"-W: hold until the patches in the relation chain are merged.","commit_id":"706ace384a02dcdce77ba96286c8552e8563fb8f"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"b0b93a34959a1b92d706766340062f04a082511b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"4a771ffa_e7e178d9","updated":"2025-11-06 14:56:10.000000000","message":"recheck","commit_id":"706ace384a02dcdce77ba96286c8552e8563fb8f"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"6865584f3e4f6bf606f2d2922b3a1a96751ec57f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"27f9e225_99e9700b","updated":"2025-12-19 15:28:30.000000000","message":"lgtm","commit_id":"c68475a3d0dd54812f3618962c940fd70fd4b381"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"111bf625a20db745102f2d0f6f0acd0e244004d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"48f021d1_b8e6930c","updated":"2025-12-19 17:50:35.000000000","message":"recheck","commit_id":"c68475a3d0dd54812f3618962c940fd70fd4b381"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"24281e2731eaed95d048bf8073e4816b07e96e27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"60e911d9_72339a02","updated":"2025-12-19 14:11:45.000000000","message":"recheck - want recheck quobyte results","commit_id":"c68475a3d0dd54812f3618962c940fd70fd4b381"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"8f8ab59d0af8e59e639855be9313cf99e73a2655","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"aa7a0bbb_e68d5b05","updated":"2025-12-16 11:12:51.000000000","message":"run-Quobyte CI","commit_id":"c68475a3d0dd54812f3618962c940fd70fd4b381"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"ec9fbcdcd848a093064aac803888ee75ebaee4cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"d894548c_2d367eae","updated":"2025-12-19 14:12:43.000000000","message":"run-Quobyte CI","commit_id":"c68475a3d0dd54812f3618962c940fd70fd4b381"}],"cinder/volume/drivers/nfs.py":[{"author":{"_account_id":37888,"name":"Akshay Ranade","display_name":"Akshay Ranade","email":"akshay.ranade@ibm.com","username":"rakshay"},"change_message_id":"479bd74b76b806c290b63d0642c527356aab08c6","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import binascii"},{"line_number":18,"context_line":"import errno"},{"line_number":19,"context_line":"import math"},{"line_number":20,"context_line":"import os"},{"line_number":21,"context_line":"import tempfile"},{"line_number":22,"context_line":"import time"}],"source_content_type":"text/x-python","patch_set":14,"id":"0de4e24b_dc2d168f","line":19,"range":{"start_line":19,"start_character":7,"end_line":19,"end_character":11},"updated":"2025-06-02 10:13:14.000000000","message":"why are we importing entire math module when we are only using ceil out of it at the moment?","commit_id":"541531746c46d1e58237606f9061048ceaeee20f"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"ed020756ebca97bd0377b8e2474e74074dbd32d9","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import binascii"},{"line_number":18,"context_line":"import errno"},{"line_number":19,"context_line":"import math"},{"line_number":20,"context_line":"import os"},{"line_number":21,"context_line":"import tempfile"},{"line_number":22,"context_line":"import time"}],"source_content_type":"text/x-python","patch_set":14,"id":"a940804c_6d5402f2","line":19,"range":{"start_line":19,"start_character":7,"end_line":19,"end_character":11},"in_reply_to":"0de4e24b_dc2d168f","updated":"2025-06-24 17:28:42.000000000","message":"Hi Akshay. Importing math entirely is the standard for all other modules in Cinder and does not differ from what we do with other built-in modules, such as the \"os\" or \"time\" libraries. Though I understand this could be contained, I don\u0027t see a problem or break of code style in importing the math library specifically.","commit_id":"541531746c46d1e58237606f9061048ceaeee20f"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"16d6618ed902706740a83a78df8dfc800dc28ade","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import binascii"},{"line_number":18,"context_line":"import errno"},{"line_number":19,"context_line":"import math"},{"line_number":20,"context_line":"import os"},{"line_number":21,"context_line":"import tempfile"},{"line_number":22,"context_line":"import time"}],"source_content_type":"text/x-python","patch_set":14,"id":"b117e507_35140b35","line":19,"range":{"start_line":19,"start_character":7,"end_line":19,"end_character":11},"in_reply_to":"a940804c_6d5402f2","updated":"2025-09-02 17:31:45.000000000","message":"Done","commit_id":"541531746c46d1e58237606f9061048ceaeee20f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f2b824faa01eda365a681d13d64b2908c3b2eb71","unresolved":true,"context_lines":[{"line_number":174,"context_line":"        # than the Cinder service. This prevents users from attaching a volume"},{"line_number":175,"context_line":"        # which virtual size has been extended from inside a virtual machine,"},{"line_number":176,"context_line":"        # by writing a modified qcow2 image to its block device."},{"line_number":177,"context_line":"        if virtual_size_gb \u003e volume.size:"},{"line_number":178,"context_line":"            LOG.error(\u0027The volume virtual_size does not match the size in \u0027"},{"line_number":179,"context_line":"                      \u0027cinder, aborting as we suspect an exploit. \u0027"},{"line_number":180,"context_line":"                      \u0027Virtual Size is %(vsize)s and real size is %(size)s\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"43a40bb9_ae922940","line":177,"updated":"2025-05-30 14:36:05.000000000","message":"Just adding a note here because I was reviewing this patch out of order and got confused.  That this small change will fix the issue makes sense given the parent patch changes whereby cinder is tracking the format in admin metadata, and making the _qemu_img_info() function format-aware.","commit_id":"541531746c46d1e58237606f9061048ceaeee20f"}]}