)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"9ab79f5f64d0f2690dcd54929b681160d8d7310c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a65e714a_d685512a","updated":"2025-02-28 18:36:18.000000000","message":"Simon, did you intend to submit direct to 2023.2?  We should see a cherry-picked field, no?","commit_id":"fe3235b5f8f9bff5b6070cbb85c98e4cc2e93819"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"0c47dcb32fb1b56a7e680166458140b3c384cf7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9578fcc4_7163ba56","in_reply_to":"a65e714a_d685512a","updated":"2025-02-28 18:41:56.000000000","message":"Major code change from 2024.1 as we changed the REST version used by the driver, so a cherrypick wouldn\u0027t work.","commit_id":"fe3235b5f8f9bff5b6070cbb85c98e4cc2e93819"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d0620b201de6b62c4d490ebc59e71e2db75f3d89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c09d8e75_4a228bdf","updated":"2025-04-11 12:43:39.000000000","message":"Replacement patch to stable/2024.1 is https://review.opendev.org/c/openstack/cinder/+/946788","commit_id":"8fb04d90f43fa9120125b5dbde51d6614646a020"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"a4fabe09e9133a372c46dcc08c22e37848529e89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b7734f2f_d0827bea","updated":"2025-04-09 14:29:31.000000000","message":"This has not been properly cherry-picked to reference the change in master and subsequent cherry-picks.  If this is just being submitted to stable/2023.2 then there needs to be note of that in the Commit message.","commit_id":"8fb04d90f43fa9120125b5dbde51d6614646a020"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"a6a2abeb1577f709f78802f8250ad30ed367ce3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e821f70a_e25f259a","updated":"2025-02-28 18:42:42.000000000","message":"To clarify for another reviewer, this is not a cherry pick because the code was changed completely in 2024.1, a separate patch will be submitted to master to address that.","commit_id":"8fb04d90f43fa9120125b5dbde51d6614646a020"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"cb105359fa5802d795b1b0b0b3eae6c831b0f929","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"508de1ce_83f7e309","in_reply_to":"b7734f2f_d0827bea","updated":"2025-04-09 14:43:48.000000000","message":"The codebase changed dramically from 2024.2, so any cherry-picks from master won\u0027t work.\nI guess we should have started this patch from 2024.1 and then backported to 2023.2.\nI\u0027ll abandon this patch an start from 2024.1 with apprpriate commit comments.","commit_id":"8fb04d90f43fa9120125b5dbde51d6614646a020"}],"cinder/volume/drivers/pure.py":[{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"4a54883acb486debc102318898e99b252727119a","unresolved":true,"context_lines":[{"line_number":770,"context_line":"        qos \u003d None"},{"line_number":771,"context_line":"        qos \u003d self._get_qos_settings(volume.volume_type)"},{"line_number":772,"context_line":"        if qos:"},{"line_number":773,"context_line":"            self.set_qos(current_array, vol_name, qos)"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"        return self._setup_volume(current_array, volume, vol_name)"},{"line_number":776,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"018ccf8e_a1e461bf","line":773,"updated":"2025-02-28 18:44:08.000000000","message":"If another patch is submitted, it could be nice to cover this with a unit test.","commit_id":"8fb04d90f43fa9120125b5dbde51d6614646a020"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"78c7c2e41b015c4ea30d51d8bdb926469bb27db2","unresolved":true,"context_lines":[{"line_number":770,"context_line":"        qos \u003d None"},{"line_number":771,"context_line":"        qos \u003d self._get_qos_settings(volume.volume_type)"},{"line_number":772,"context_line":"        if qos:"},{"line_number":773,"context_line":"            self.set_qos(current_array, vol_name, qos)"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"        return self._setup_volume(current_array, volume, vol_name)"},{"line_number":776,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"0358978c_82303d01","line":773,"in_reply_to":"018ccf8e_a1e461bf","updated":"2025-02-28 18:49:04.000000000","message":"We will do this for the patch to master","commit_id":"8fb04d90f43fa9120125b5dbde51d6614646a020"}]}