)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"6f8624d287160cbcb9e22f59beeb23aeceb37322","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     jayaanan \u003cjayaanand.borra@netapp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-04-22 11:52:15 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[NetApp]:Cinder support for self-signed transport"},{"line_number":8,"context_line":"Current NetApp Cinder driver is not supporting"},{"line_number":9,"context_line":"https transport using self-singed certificate."},{"line_number":10,"context_line":"This patch will enable transport using"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"03783d51_fed2dae4","line":7,"updated":"2025-04-22 18:14:38.000000000","message":"Need a line break added here to split the summary line from the rest of the commit message.","commit_id":"a412a1e447a87060c20aa1fa697c6ccf99d90152"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"920aac548e2632f8fb10a1253d5c9ee23ae52f70","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     jayaanan \u003cjayaanand.borra@netapp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-04-22 11:52:15 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[NetApp]:Cinder support for self-signed transport"},{"line_number":8,"context_line":"Current NetApp Cinder driver is not supporting"},{"line_number":9,"context_line":"https transport using self-singed certificate."},{"line_number":10,"context_line":"This patch will enable transport using"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"29781165_68ca1b0f","line":7,"in_reply_to":"03783d51_fed2dae4","updated":"2025-08-10 14:52:43.000000000","message":"Thank you! updated to split the summary line from rest","commit_id":"a412a1e447a87060c20aa1fa697c6ccf99d90152"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"b87c12a1cda2549cf192533631367caa5cd7dde2","unresolved":true,"context_lines":[{"line_number":10,"context_line":"https transport using self-singed certificate."},{"line_number":11,"context_line":"This patch will enable transport using"},{"line_number":12,"context_line":"self-signed certificate."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ia486448b85feba636effef609d79ef8e57a6d39a"},{"line_number":15,"context_line":"Signed-off-by: jayaanan \u003cjayaanand.borra@netapp.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"199b1aec_30c9b903","line":13,"updated":"2025-08-18 06:03:11.000000000","message":"missing blueprint details.","commit_id":"21a968ddde2bc0c0c29258897179691f4ef34c9e"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"b4fa2ed59f2762ad44b0b4dd2b2ba1ad31a0e85a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"https transport using self-singed certificate."},{"line_number":11,"context_line":"This patch will enable transport using"},{"line_number":12,"context_line":"self-signed certificate."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ia486448b85feba636effef609d79ef8e57a6d39a"},{"line_number":15,"context_line":"Signed-off-by: jayaanan \u003cjayaanand.borra@netapp.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"d710556b_73edbd7c","line":13,"in_reply_to":"199b1aec_30c9b903","updated":"2025-08-18 18:22:00.000000000","message":"Thank you!Nilesh... added blueprint details.","commit_id":"21a968ddde2bc0c0c29258897179691f4ef34c9e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f457a7428b1ac5915ac6a5cfae0120892390ef72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8a3551a9_7197cc81","updated":"2025-08-11 15:52:45.000000000","message":"In addition to my other comments, this needs a release note.","commit_id":"405d55a5648cdb0352717b742f329b6be7c36db5"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"920aac548e2632f8fb10a1253d5c9ee23ae52f70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2a06a2db_7eab9eec","updated":"2025-08-10 14:52:43.000000000","message":"Thank you! Harney for your comments. Addressed your suggestions. Please review again.","commit_id":"405d55a5648cdb0352717b742f329b6be7c36db5"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"252a1162c12beae6edff86d63ebcd6a223f61630","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"49f9db74_5380ecdc","updated":"2025-08-13 09:26:42.000000000","message":"Hi Alan, Thank you and really appreciate your detailed review. I re-worked logic to address your comments. please review again.","commit_id":"21a968ddde2bc0c0c29258897179691f4ef34c9e"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"b87c12a1cda2549cf192533631367caa5cd7dde2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7d4f624a_66155fc8","updated":"2025-08-18 06:03:11.000000000","message":"LGTM but CI result is not available and some inline comment.","commit_id":"21a968ddde2bc0c0c29258897179691f4ef34c9e"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"d7903bbbfbba0d5ba5bf8a3aba3fc47b7cf5ee0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ce215991_4a14f60a","updated":"2025-08-14 17:39:25.000000000","message":"Thank you! Alan for detailed review. I resolved your query regarding SSL context. Please review again.","commit_id":"21a968ddde2bc0c0c29258897179691f4ef34c9e"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d231fe19acea4260f532c5ad07948c688888cb51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"28092adb_e16a49c1","updated":"2025-08-14 14:06:27.000000000","message":"The code changes lgtm but you need to add a release note.","commit_id":"21a968ddde2bc0c0c29258897179691f4ef34c9e"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"508dbebe2d4f5029a845718702263b4f0947d372","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d69e4eb8_0265eb3f","updated":"2025-08-13 13:01:25.000000000","message":"recheck","commit_id":"21a968ddde2bc0c0c29258897179691f4ef34c9e"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"b4fa2ed59f2762ad44b0b4dd2b2ba1ad31a0e85a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d7f26959_06707035","in_reply_to":"28092adb_e16a49c1","updated":"2025-08-18 18:22:00.000000000","message":"Thank you! Alan, Added release notes to this feature.","commit_id":"21a968ddde2bc0c0c29258897179691f4ef34c9e"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"eefc5bf16279344caf95de93a6b71352bb8ef081","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a893be96_577d6e09","updated":"2025-08-19 04:05:48.000000000","message":"LGTM my comments are addressed.","commit_id":"431614e406d59672a550f89e5efff6a730efe6c6"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"b4fa2ed59f2762ad44b0b4dd2b2ba1ad31a0e85a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"86a170dc_9786b282","updated":"2025-08-18 18:22:00.000000000","message":"Thank you! Alan and Nilesh for your review comments. addressed suggested comments. Please review again.","commit_id":"431614e406d59672a550f89e5efff6a730efe6c6"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"2c4f87ccd96967da655315193d85bbf12c172c8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0a5e81c8_ac1a8eb5","updated":"2025-08-20 16:19:56.000000000","message":"LGTM but CI result is not available.","commit_id":"73062549457e05b2f783f37da3f6ed3f05449b9a"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"992fe0a130797a203b2720d4cb9c785229ca6f0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4d3897c4_7ed596d5","updated":"2025-08-19 13:33:41.000000000","message":"Thank you!Alan, can you please review again. addressed review comments.","commit_id":"73062549457e05b2f783f37da3f6ed3f05449b9a"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"1227e577d499758c381a62c5e39842b6fe4c979a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"915734ca_e6390891","updated":"2025-08-20 05:04:18.000000000","message":"recheck ceph tests are failing. not related to my changes.","commit_id":"73062549457e05b2f783f37da3f6ed3f05449b9a"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"3b34dcc9f7af9cd12318a4381817f167724e7ca5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"107b3caf_1812e32e","updated":"2025-08-26 18:08:58.000000000","message":"LGTM","commit_id":"a35be72ad84dd48d6d4cd2f5c4bb2d11e81cb5b4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"cbc3cc1a1564d1030dbd3a18fea3f8261a0ab38f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"e9efa629_d5cdfc8b","updated":"2025-08-26 20:55:13.000000000","message":"Question inline. -1 just to get your attention; ping me in IRC to drop it if it doesn\u0027t make sense.","commit_id":"a35be72ad84dd48d6d4cd2f5c4bb2d11e81cb5b4"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"0635b14c1670e1ed364d163947090402d38f1f7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"68d9a509_b4e606b1","updated":"2025-08-25 07:55:53.000000000","message":"Thank you! Alan, remove extra space as suggested. Please review again.","commit_id":"a35be72ad84dd48d6d4cd2f5c4bb2d11e81cb5b4"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"ad8056dfc5f49f95cf31e6e05af76d590e6879e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"db49e5de_237cc6ea","updated":"2025-08-27 14:47:13.000000000","message":"Forgot to vote.","commit_id":"f0db4b3282fb847cf4eff095b65a12022ebdd23e"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"b02a08b11241dbbbfe68c383f41074b4276a39a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"321099fb_32701c73","updated":"2025-08-27 14:46:57.000000000","message":"LGTM.","commit_id":"f0db4b3282fb847cf4eff095b65a12022ebdd23e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3acad768d03b49c1a61260f4c14b9dd854b3f4f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"0df70732_b6ec985b","updated":"2025-08-27 12:34:50.000000000","message":"My concern has been addressed; code \u0026 tests LGTM.","commit_id":"f0db4b3282fb847cf4eff095b65a12022ebdd23e"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"e83146fc2ecbbe6a042037bb402f77f40427d188","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"361a1e0d_8078eb25","updated":"2025-08-27 12:25:47.000000000","message":"Thank you! Brain, Update release notes to address your review comments. please review again.","commit_id":"f0db4b3282fb847cf4eff095b65a12022ebdd23e"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"8f1fa26bff9e0686d28fb35b2781234c8c045980","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ef213922_34fe4d66","updated":"2025-08-29 18:07:00.000000000","message":"CI passed from Rajat\u0027s request, FC is failing for all netapp patches, they are working on it.  This looks ok to me.","commit_id":"d3d91d9a13f8266c3ac2489859ce14545792bd26"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"67ad00088169fe609e41cd0aa6e383085f74ff0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"e6d83393_76685d5f","updated":"2025-08-29 11:51:10.000000000","message":"Change from PS10 was to resolve a merge conflict with I9ba421df169247298a.  Looks good, so renewing my +2.","commit_id":"d3d91d9a13f8266c3ac2489859ce14545792bd26"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"7408ea1af185b589097fa59a4f158eeb26a9c4ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"83981169_3bc551a6","updated":"2025-08-28 19:15:22.000000000","message":"Hi @abishop@redhat.com,rosmaita.fossdev@gmail.com,nilesh.thathagar@dell.com and anoop.shukla@netapp.com,\n\nI re-based my changes to resolve merge conflicts. No code changes are done. Can you please check this PR again. I really appreciate your time.\n\nThank you!\nJayaanand.","commit_id":"d3d91d9a13f8266c3ac2489859ce14545792bd26"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"bb9a73cbe2472da79aa7c076df8a6606ee1f0d83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"924f5464_2da66880","updated":"2025-08-29 04:22:35.000000000","message":"Looks good.","commit_id":"d3d91d9a13f8266c3ac2489859ce14545792bd26"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1c754c6bd9cc38d0cc45beae30406b41d3402ca4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"aec25b4e_bffaf699","updated":"2025-08-29 18:06:02.000000000","message":"NetApp CI has reported. The FCP job is failing but the iSCSI and NVMe-TCP are passing which is enough to validate this patch. LGTM.","commit_id":"d3d91d9a13f8266c3ac2489859ce14545792bd26"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"f4126375e092f942c700ad7a1a9ff797b513df14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"45126ff0_bb8b3be6","updated":"2025-08-29 04:38:02.000000000","message":"recheck","commit_id":"d3d91d9a13f8266c3ac2489859ce14545792bd26"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"19f329a5f22c4db9666b0c1691faca429185ff04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"7d7ca8d6_051e7788","updated":"2025-08-29 15:09:59.000000000","message":"run-NetApp CI","commit_id":"d3d91d9a13f8266c3ac2489859ce14545792bd26"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6258dba7bd9ddff23b1479bb434fa21bde73134f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0f7817b3_f3e17d5a","updated":"2025-08-29 15:08:54.000000000","message":"the ssl ca path config was added in [1] but looks like this patch is trying to enable it for the legacy (ZAPI) path apart from the REST and ASS r2 path which already have \"ssl_cert_path\u003dconfig.netapp_ssl_cert_path\".\nThe CI hasn\u0027t run on this patch since PS3 and last time also it failed so I\u0027m skeptical about if the CI is working on this one.\n\n\n[1] https://opendev.org/openstack/cinder/commit/4775ca93706f58cd1aa8739c35408fd75040302e","commit_id":"d3d91d9a13f8266c3ac2489859ce14545792bd26"}],"cinder/volume/drivers/netapp/dataontap/client/api.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"6f8624d287160cbcb9e22f59beeb23aeceb37322","unresolved":true,"context_lines":[{"line_number":317,"context_line":"            ssl_context \u003d ssl.create_default_context(cafile\u003dself._ssl_verify)"},{"line_number":318,"context_line":"        elif self._ssl_verify is True:  # Use system CA roots"},{"line_number":319,"context_line":"            ssl_context \u003d ssl.create_default_context()"},{"line_number":320,"context_line":"        else:  # Disable SSL verification (not recommended for production)"},{"line_number":321,"context_line":"            ssl_context \u003d ssl._create_unverified_context()"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        https_handler \u003d urllib.request.HTTPSHandler(context\u003dssl_context)"}],"source_content_type":"text/x-python","patch_set":3,"id":"d607e589_a73514f5","line":320,"updated":"2025-04-22 18:14:38.000000000","message":"Since this isn\u0027t recommended for production and would generally be considered unsafe, why not add a netapp option that allows use of self-signed certs that defaults to off?","commit_id":"a412a1e447a87060c20aa1fa697c6ccf99d90152"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"920aac548e2632f8fb10a1253d5c9ee23ae52f70","unresolved":false,"context_lines":[{"line_number":317,"context_line":"            ssl_context \u003d ssl.create_default_context(cafile\u003dself._ssl_verify)"},{"line_number":318,"context_line":"        elif self._ssl_verify is True:  # Use system CA roots"},{"line_number":319,"context_line":"            ssl_context \u003d ssl.create_default_context()"},{"line_number":320,"context_line":"        else:  # Disable SSL verification (not recommended for production)"},{"line_number":321,"context_line":"            ssl_context \u003d ssl._create_unverified_context()"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        https_handler \u003d urllib.request.HTTPSHandler(context\u003dssl_context)"}],"source_content_type":"text/x-python","patch_set":3,"id":"edf9fca4_07932846","line":320,"in_reply_to":"d607e589_a73514f5","updated":"2025-08-10 14:52:43.000000000","message":"Thank you! After your comment, we went back and found that this requirement is from single customer and rest of the customer deployments are done without self-signed certificates. Also, NetApp documentation is not recommending self-signed certificate for transport. Sorry for the confusion. removed this comment.","commit_id":"a412a1e447a87060c20aa1fa697c6ccf99d90152"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f457a7428b1ac5915ac6a5cfae0120892390ef72","unresolved":true,"context_lines":[{"line_number":94,"context_line":"        if ssl_cert_path is not None:"},{"line_number":95,"context_line":"            self._ssl_verify \u003d ssl_cert_path"},{"line_number":96,"context_line":"        else:"},{"line_number":97,"context_line":"            self._ssl_verify \u003d True"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        LOG.debug(\u0027Using NetApp controller: %s\u0027, self._host)"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"2f483807_d031f259","line":97,"updated":"2025-08-11 15:52:45.000000000","message":"This needs a comment to explain how/why the field can be either a string or boolean, and the significance of it being True. \n\nL320 suggests the value might also be False, so how does that work? The \u0027netapp_ssl_cert_path\u0027 is a StrOpt with no default value, so I can\u0027t see how L320 will ever be reached.","commit_id":"405d55a5648cdb0352717b742f329b6be7c36db5"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"252a1162c12beae6edff86d63ebcd6a223f61630","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        if ssl_cert_path is not None:"},{"line_number":95,"context_line":"            self._ssl_verify \u003d ssl_cert_path"},{"line_number":96,"context_line":"        else:"},{"line_number":97,"context_line":"            self._ssl_verify \u003d True"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        LOG.debug(\u0027Using NetApp controller: %s\u0027, self._host)"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"cddadf39_c9a60ca3","line":97,"in_reply_to":"2f483807_d031f259","updated":"2025-08-13 09:26:42.000000000","message":"Thank you! Alan for detailed review. we lost track after multiple iterations. reworked on logic to simplify the code.","commit_id":"405d55a5648cdb0352717b742f329b6be7c36db5"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f457a7428b1ac5915ac6a5cfae0120892390ef72","unresolved":true,"context_lines":[{"line_number":317,"context_line":"            ssl_context \u003d ssl.create_default_context(cafile\u003dself._ssl_verify)"},{"line_number":318,"context_line":"        elif self._ssl_verify is True:  # Use system CA roots"},{"line_number":319,"context_line":"            ssl_context \u003d ssl.create_default_context()"},{"line_number":320,"context_line":"        else:  # Disable SSL verification"},{"line_number":321,"context_line":"            ssl_context \u003d ssl._create_unverified_context()"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        https_handler \u003d urllib.request.HTTPSHandler(context\u003dssl_context)"}],"source_content_type":"text/x-python","patch_set":4,"id":"8d03a23b_ba7eebd2","line":320,"updated":"2025-08-11 15:52:45.000000000","message":"Given what happens on L97, how does this logic work?","commit_id":"405d55a5648cdb0352717b742f329b6be7c36db5"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"252a1162c12beae6edff86d63ebcd6a223f61630","unresolved":false,"context_lines":[{"line_number":317,"context_line":"            ssl_context \u003d ssl.create_default_context(cafile\u003dself._ssl_verify)"},{"line_number":318,"context_line":"        elif self._ssl_verify is True:  # Use system CA roots"},{"line_number":319,"context_line":"            ssl_context \u003d ssl.create_default_context()"},{"line_number":320,"context_line":"        else:  # Disable SSL verification"},{"line_number":321,"context_line":"            ssl_context \u003d ssl._create_unverified_context()"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        https_handler \u003d urllib.request.HTTPSHandler(context\u003dssl_context)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1082687b_86251200","line":320,"in_reply_to":"8d03a23b_ba7eebd2","updated":"2025-08-13 09:26:42.000000000","message":"Thank you! Alan for detailed review. we lost track after multiple iterations. reworked on logic to simplify the code.","commit_id":"405d55a5648cdb0352717b742f329b6be7c36db5"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d231fe19acea4260f532c5ad07948c688888cb51","unresolved":true,"context_lines":[{"line_number":313,"context_line":"            ssl_context \u003d ("},{"line_number":314,"context_line":"                ssl.create_default_context(cafile\u003dself._ssl_cert_path))"},{"line_number":315,"context_line":"        else:  # Disable SSL verification"},{"line_number":316,"context_line":"            ssl_context \u003d ssl._create_unverified_context()"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        https_handler \u003d urllib.request.HTTPSHandler(context\u003dssl_context)"},{"line_number":319,"context_line":"        opener \u003d urllib.request.build_opener(auth_handler, https_handler)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5e02d27e_957025b2","line":316,"updated":"2025-08-14 14:06:27.000000000","message":"I believe this is critical code that adds support for self signed certs. If no cert path is provided, you create a self-signed context. Is my understanding correct?","commit_id":"21a968ddde2bc0c0c29258897179691f4ef34c9e"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"d7903bbbfbba0d5ba5bf8a3aba3fc47b7cf5ee0b","unresolved":false,"context_lines":[{"line_number":313,"context_line":"            ssl_context \u003d ("},{"line_number":314,"context_line":"                ssl.create_default_context(cafile\u003dself._ssl_cert_path))"},{"line_number":315,"context_line":"        else:  # Disable SSL verification"},{"line_number":316,"context_line":"            ssl_context \u003d ssl._create_unverified_context()"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        https_handler \u003d urllib.request.HTTPSHandler(context\u003dssl_context)"},{"line_number":319,"context_line":"        opener \u003d urllib.request.build_opener(auth_handler, https_handler)"}],"source_content_type":"text/x-python","patch_set":5,"id":"004406a2_f9ca48bd","line":316,"in_reply_to":"5e02d27e_957025b2","updated":"2025-08-14 17:39:25.000000000","message":"Thank you! Alan, when no cert path is provided netapp_ssl_cert_path and _ssl_cert_path are set to None and unverified_context will be created and Cinder pool will be initialize without issue. i tested this with LOGs. please not my findings.\n\ncinder-volume.log:ERROR cinder.volume.drivers.netapp.dataontap.client.api [None req-c2bdeb41-48aa-4b31-8fe2-ab99205416a2 None None] _ssl_cert_path is None\ncinder-volume.log:ERROR cinder.volume.drivers.netapp.dataontap.client.api [None req-c2bdeb41-48aa-4b31-8fe2-ab99205416a2 None None] _create_unverified_context\n\nand my code for above log informaiton\n\n        LOG.error(\"_ssl_cert_path is %s\", self._ssl_cert_path)\n        # Create an SSL context based on _ssl_cert_path\n        if isinstance(self._ssl_cert_path, str):  # with cert path\n            LOG.error(\"create_default_context\")\n            ssl_context \u003d (\n                ssl.create_default_context(cafile\u003dself._ssl_cert_path))\n        else:  # Disable SSL verification\n            LOG.error(\"_create_unverified_context\")\n            ssl_context \u003d ssl._create_unverified_context()\npool is initialized well","commit_id":"21a968ddde2bc0c0c29258897179691f4ef34c9e"}],"releasenotes/notes/bp-netapp-self-signed-https-support-cb30081d4465acd1.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"a1b1c0e9b7dda8294dc7b3b06f5e751c52abe9a4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp ONTAP driver: Added support for self-signed certificate"},{"line_number":5,"context_line":"    support for HTTPS transport for management communication between"},{"line_number":6,"context_line":"    Cinder and NetApp ONTAP."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"45638020_357a7dfa","line":4,"range":{"start_line":4,"start_character":25,"end_line":4,"end_character":38},"updated":"2025-08-18 18:42:29.000000000","message":"This is a good description, but I wonder if you should mention how admins take advantage of the feature. They might expect they have to configure something, so it would be useful to state a self-signed certificate is automatically generated when the \u0027ssl_cert_path\u0027 is left blank.","commit_id":"431614e406d59672a550f89e5efff6a730efe6c6"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"992fe0a130797a203b2720d4cb9c785229ca6f0a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp ONTAP driver: Added support for self-signed certificate"},{"line_number":5,"context_line":"    support for HTTPS transport for management communication between"},{"line_number":6,"context_line":"    Cinder and NetApp ONTAP."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"2b913175_f059e922","line":4,"range":{"start_line":4,"start_character":25,"end_line":4,"end_character":38},"in_reply_to":"45638020_357a7dfa","updated":"2025-08-19 13:33:41.000000000","message":"Thank you! Added details for admins to use this feature.","commit_id":"431614e406d59672a550f89e5efff6a730efe6c6"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"1f01fe2ed9167e89062aacde763422138b8ab9b2","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    NetApp ONTAP driver: Added support for self-signed certificate"},{"line_number":5,"context_line":"    support for HTTPS transport for management communication between"},{"line_number":6,"context_line":"    Cinder and NetApp ONTAP."},{"line_number":7,"context_line":"    "},{"line_number":8,"context_line":"    ONTAP (NetApp ONTAP) utilizes default self-signed certificates"},{"line_number":9,"context_line":"    for HTTPS communication. These certificates are generated"},{"line_number":10,"context_line":"    automatically during the initial setup or deployment of ONTAP."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"b6206614_621c0519","line":7,"updated":"2025-08-20 15:02:54.000000000","message":"This update to the note is good because it clarifies how to actually use the self signed certificate. The procedure is a bit cumbersome, but I understand it\u0027s not a commonly requested feature for admins using the HPE driver.\n\nI don\u0027t know if this extra whitespace on L7 is a problem, but I\u0027ll upvote the patch.","commit_id":"73062549457e05b2f783f37da3f6ed3f05449b9a"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"0635b14c1670e1ed364d163947090402d38f1f7f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    NetApp ONTAP driver: Added support for self-signed certificate"},{"line_number":5,"context_line":"    support for HTTPS transport for management communication between"},{"line_number":6,"context_line":"    Cinder and NetApp ONTAP."},{"line_number":7,"context_line":"    "},{"line_number":8,"context_line":"    ONTAP (NetApp ONTAP) utilizes default self-signed certificates"},{"line_number":9,"context_line":"    for HTTPS communication. These certificates are generated"},{"line_number":10,"context_line":"    automatically during the initial setup or deployment of ONTAP."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"454e1e74_a734c3be","line":7,"in_reply_to":"b6206614_621c0519","updated":"2025-08-25 07:55:53.000000000","message":"Thank you! Alan, removed unwanted space. Can you please review again.","commit_id":"73062549457e05b2f783f37da3f6ed3f05449b9a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"cbc3cc1a1564d1030dbd3a18fea3f8261a0ab38f","unresolved":true,"context_lines":[{"line_number":11,"context_line":"    To enable secure HTTPS communication in Cinder, administrators"},{"line_number":12,"context_line":"    must extract the self-signed certificate using tools such as"},{"line_number":13,"context_line":"    openssl or curl to obtain the .PEM file and configure it via"},{"line_number":14,"context_line":"    ssl_cert_path. When ssl_cert_path is not provided, Cinder falls"},{"line_number":15,"context_line":"    back to HTTP communication with ONTAP for management operations."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"0b3646ec_7318a830","line":15,"range":{"start_line":14,"start_character":19,"end_line":15,"end_character":68},"updated":"2025-08-26 20:55:13.000000000","message":"From what I see in dataontap/client/api.py, this doesn\u0027t seem correct.  It uses an unverified ssl context, which would still use the https ports but won\u0027t validate the certificate.  At least I think that\u0027s what\u0027s going on.","commit_id":"a35be72ad84dd48d6d4cd2f5c4bb2d11e81cb5b4"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"e83146fc2ecbbe6a042037bb402f77f40427d188","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    To enable secure HTTPS communication in Cinder, administrators"},{"line_number":12,"context_line":"    must extract the self-signed certificate using tools such as"},{"line_number":13,"context_line":"    openssl or curl to obtain the .PEM file and configure it via"},{"line_number":14,"context_line":"    ssl_cert_path. When ssl_cert_path is not provided, Cinder falls"},{"line_number":15,"context_line":"    back to HTTP communication with ONTAP for management operations."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"662a6ad7_01f48a8e","line":15,"range":{"start_line":14,"start_character":19,"end_line":15,"end_character":68},"in_reply_to":"0b3646ec_7318a830","updated":"2025-08-27 12:25:47.000000000","message":"Thank you! Brain, Looked into unverified_context code and understood functionality. Updated release notes to reflect workflows when ssl_cert_path is present and missing.","commit_id":"a35be72ad84dd48d6d4cd2f5c4bb2d11e81cb5b4"}]}