)]}'
{"cinder/image/image_utils.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3e6dfdabe9dbf83f35535d70bd8a4ff9733b9575","unresolved":true,"context_lines":[{"line_number":951,"context_line":"    LOG.debug(f\u0027Copying image from {src} to volume {dest} - size: {size}\u0027)"},{"line_number":952,"context_line":"    if (isinstance(src, str) and isinstance(dest, str)):"},{"line_number":953,"context_line":"        if os.path.dirname(src) \u003d\u003d os.path.dirname(dest):"},{"line_number":954,"context_line":"            utils.execute(\u0027mv\u0027, src, dest, run_as_root\u003drun_as_root)"},{"line_number":955,"context_line":"            return"},{"line_number":956,"context_line":"    image_size_m \u003d math.ceil(float(size) / units.Mi)"},{"line_number":957,"context_line":"    volume_utils.copy_volume(src, dest, image_size_m, blocksize)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f04a003_8bea9605","line":954,"updated":"2025-05-14 12:26:32.000000000","message":"This changes a method which is called \"copy\" into a move in some cases -- this will introduce a good bit of confusion and is pretty likely to result in some surprising bugs.  If we think it\u0027s useful to make this a \"mv\" I don\u0027t think it should be done this way.","commit_id":"50a2f0e9dd8c88bcc09ccca55a97558bbe032102"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"dbcaa46089549ac7b81a98234429b6d1750b35b9","unresolved":true,"context_lines":[{"line_number":951,"context_line":"    LOG.debug(f\u0027Copying image from {src} to volume {dest} - size: {size}\u0027)"},{"line_number":952,"context_line":"    if (isinstance(src, str) and isinstance(dest, str)):"},{"line_number":953,"context_line":"        if os.path.dirname(src) \u003d\u003d os.path.dirname(dest):"},{"line_number":954,"context_line":"            utils.execute(\u0027mv\u0027, src, dest, run_as_root\u003drun_as_root)"},{"line_number":955,"context_line":"            return"},{"line_number":956,"context_line":"    image_size_m \u003d math.ceil(float(size) / units.Mi)"},{"line_number":957,"context_line":"    volume_utils.copy_volume(src, dest, image_size_m, blocksize)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7cc109bd_b58d29f0","line":954,"in_reply_to":"3f04a003_8bea9605","updated":"2025-08-27 11:49:34.000000000","message":"I somehow struggle to think of more efficient way of achieving similar goal - not waste diskspace when there is no need for it.","commit_id":"50a2f0e9dd8c88bcc09ccca55a97558bbe032102"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"cebebc3ec1dc7954ed51776e289556623d5ec2b9","unresolved":true,"context_lines":[{"line_number":951,"context_line":"    LOG.debug(f\u0027Copying image from {src} to volume {dest} - size: {size}\u0027)"},{"line_number":952,"context_line":"    if (isinstance(src, str) and isinstance(dest, str)):"},{"line_number":953,"context_line":"        if os.path.dirname(src) \u003d\u003d os.path.dirname(dest):"},{"line_number":954,"context_line":"            utils.execute(\u0027mv\u0027, src, dest, run_as_root\u003drun_as_root)"},{"line_number":955,"context_line":"            return"},{"line_number":956,"context_line":"    image_size_m \u003d math.ceil(float(size) / units.Mi)"},{"line_number":957,"context_line":"    volume_utils.copy_volume(src, dest, image_size_m, blocksize)"}],"source_content_type":"text/x-python","patch_set":2,"id":"68bb8b92_e724f90d","line":954,"in_reply_to":"7cc109bd_b58d29f0","updated":"2025-08-27 12:02:20.000000000","message":"I\u0027ve renamed the method to reduce confusion at least... But if you have some idea - I\u0027m very open to check on implementation.\n\nAs while my example mentions 50GB image, for Windows it\u0027s \"normal\" to do such operations with 250Gb images as well, which becomes not only extremely time consuming, but also when it\u0027s done several times in parallel - become very problematic.","commit_id":"50a2f0e9dd8c88bcc09ccca55a97558bbe032102"}]}