)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"72d16e28a05906ff6c606f40863c0a61748ee45f","unresolved":true,"context_lines":[{"line_number":33,"context_line":"1. initialize connection function is invoked."},{"line_number":34,"context_line":"2. using trunk iSCSI ip 172.28.50.151, create lun invoked."},{"line_number":35,"context_line":"3. With vlan ip 172.28.50.151, it again tries to create lun."},{"line_number":36,"context_line":"4. And this fails because LUN is already created (with same ip)"},{"line_number":37,"context_line":"in step 2."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Extract from cinder-volume log:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"2b19d032_4bdfa8cc","line":36,"updated":"2025-06-03 15:39:14.000000000","message":"Do we have a launchpad bug open for this issue? If not, I think it would be worth creating one and referencing it in this change as Closes-Bug #\u003cbug-number\u003e.","commit_id":"2f8c363310491fdf9a2ad3e537ed8bf93eb8ad03"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"4a5622536de47140646852f515f73bbb0e6055ce","unresolved":false,"context_lines":[{"line_number":33,"context_line":"1. initialize connection function is invoked."},{"line_number":34,"context_line":"2. using trunk iSCSI ip 172.28.50.151, create lun invoked."},{"line_number":35,"context_line":"3. With vlan ip 172.28.50.151, it again tries to create lun."},{"line_number":36,"context_line":"4. And this fails because LUN is already created (with same ip)"},{"line_number":37,"context_line":"in step 2."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Extract from cinder-volume log:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"102a44f5_d6fe9e49","line":36,"in_reply_to":"2b19d032_4bdfa8cc","updated":"2025-06-04 03:24:13.000000000","message":"Done","commit_id":"2f8c363310491fdf9a2ad3e537ed8bf93eb8ad03"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"72d16e28a05906ff6c606f40863c0a61748ee45f","unresolved":true,"context_lines":[{"line_number":44,"context_line":"While processing vlan ip, check if its same as iSCSI ip."},{"line_number":45,"context_line":"If so, skip the lun creation."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Change-Id: I582c27d8d8a8e22d03b2d68152cb467a6db606bc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"c7379dfb_52dd59ff","line":47,"updated":"2025-06-03 15:39:14.000000000","message":"This patch is missing the releasenotes. Below some examples:\n\nhttps://review.opendev.org/c/openstack/cinder/+/946995/7/releasenotes/notes/fix-nfs-vol-from-snapshot-654a07d25a33bf7d.yaml\nhttps://review.opendev.org/c/openstack/cinder/+/948039/1/releasenotes/notes/pure_clone_qos_fix-a2a13311e94247db.yaml","commit_id":"2f8c363310491fdf9a2ad3e537ed8bf93eb8ad03"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"4a5622536de47140646852f515f73bbb0e6055ce","unresolved":false,"context_lines":[{"line_number":44,"context_line":"While processing vlan ip, check if its same as iSCSI ip."},{"line_number":45,"context_line":"If so, skip the lun creation."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Change-Id: I582c27d8d8a8e22d03b2d68152cb467a6db606bc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"13192330_81df80df","line":47,"in_reply_to":"c7379dfb_52dd59ff","updated":"2025-06-04 03:24:13.000000000","message":"Done","commit_id":"2f8c363310491fdf9a2ad3e537ed8bf93eb8ad03"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"408aa9e9881303d26e9bdb3277e90159b1aca4e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d90d69ce_a7e18d36","updated":"2025-05-28 16:05:43.000000000","message":"Comments inline about the logging; otherwise, LGTM.  The -1 is to get your attention; I won\u0027t insist on changing the logging if you think it\u0027s fine as is.","commit_id":"d66e31bffadd7a22050f9365e2cf1a6f6a070850"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"4cbcc592df70526a6082490820e88db8aee039fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b1758418_252d8096","updated":"2025-05-27 15:44:22.000000000","message":"Thank you Jon","commit_id":"d66e31bffadd7a22050f9365e2cf1a6f6a070850"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"92639865f4af75a5a38b30d8f66c31590ef13a4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f2468c9a_d19888ab","updated":"2025-05-27 14:36:59.000000000","message":"This looks okay to me.  I\u0027m not sure a version bump is necessary since it\u0027s a small bug fix, but either way I think it\u0027s fine.","commit_id":"d66e31bffadd7a22050f9365e2cf1a6f6a070850"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"e74aea07f0a836e56ae925574f5bbd741edf1a13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6641e74f_9a532908","updated":"2025-05-29 04:15:20.000000000","message":"Ack comments","commit_id":"63c7821914768fbc09d089db59951b6189cbd50d"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"55be99a6ed75a7ba17a196ab488f412eac1dfa9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"eba8ad2b_3d5544d0","updated":"2025-05-29 04:14:03.000000000","message":"Thank you Brian.\ni tried to address comments.","commit_id":"63c7821914768fbc09d089db59951b6189cbd50d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5c2d359b334fce6a65b99e807743eb5f09a569ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4d3ba2ac_1375d89f","updated":"2025-05-30 12:32:30.000000000","message":"As far as I can tell, the code is doing what the commit message says, but what I\u0027m missing out on is why this change is being made and why vlun reuse is OK in this situation?  Could you please either explain more in the commit message, or if that would get too verbose, file a bug explaining the change.  Thanks!","commit_id":"f760b23d0e75acf5b190e82f6f7d918c834b0ce9"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"13261f5bd90a0fadc417da4b19cf2a9470766d54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a584f8f9_8cd21a55","updated":"2025-05-29 15:01:10.000000000","message":"Hi Brian,\ni will check CI.\nin the meanwhile, it would be great to know your feedback please.\nThanks","commit_id":"f760b23d0e75acf5b190e82f6f7d918c834b0ce9"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"82fe30a08d78ee0967959525feec4b3c62f4f78d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"318e08b4_5b5db635","updated":"2025-05-29 12:14:29.000000000","message":"recheck grenade-skip-level-always timed_out","commit_id":"f760b23d0e75acf5b190e82f6f7d918c834b0ce9"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"eefd0e365acfebb7c3faa5566bd8423d93680197","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"dbf4a81c_1856d595","updated":"2025-05-29 08:25:29.000000000","message":"recheck tempest-integrated-storage-ubuntu-jammy","commit_id":"f760b23d0e75acf5b190e82f6f7d918c834b0ce9"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"5a609b4f3f903ce97e0b6919e29148eb2ce65b57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8077cbac_2be69b7b","updated":"2025-05-29 15:31:19.000000000","message":"run-HPE Storage CI","commit_id":"f760b23d0e75acf5b190e82f6f7d918c834b0ce9"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"ac8541edc6dcf7e37fe2ff65782834610c3460fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8cee2096_2740d48c","updated":"2025-05-29 10:28:03.000000000","message":"run-HPE Storage CI","commit_id":"f760b23d0e75acf5b190e82f6f7d918c834b0ce9"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"37f90ff4954fca9fdec7e76b4cfe5f2ae18a42b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8fbb771d_36e837d2","updated":"2025-05-29 12:20:17.000000000","message":"run-HPE Storage CI","commit_id":"f760b23d0e75acf5b190e82f6f7d918c834b0ce9"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"165051da11aa58402ecdff7f8331345b03364a6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9e29651a_f123f92b","updated":"2025-05-29 06:29:59.000000000","message":"run-HPE Storage CI","commit_id":"f760b23d0e75acf5b190e82f6f7d918c834b0ce9"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a3c97f27eff9ef95c9fa0cc267c5b799db552053","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ab5e0462_8a27fce0","updated":"2025-06-03 15:40:18.000000000","message":"Fernando is right, you really should have a bug filed for this (especially if you will want to backport it).","commit_id":"2f8c363310491fdf9a2ad3e537ed8bf93eb8ad03"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"c1f156b86fda8f396a1da9426f757fab2d822a00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"23566813_562d274e","updated":"2025-05-30 15:36:23.000000000","message":"Hi Brian,\ni updated commit message and replied inline to the query.\nRequest your feedback. Thanks.","commit_id":"2f8c363310491fdf9a2ad3e537ed8bf93eb8ad03"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"a2d5f8fe68138673ca1c76c7ac019ad08cd72712","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"da9c4ee1_7ec41668","updated":"2025-06-03 15:26:04.000000000","message":"Looks good to me","commit_id":"2f8c363310491fdf9a2ad3e537ed8bf93eb8ad03"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"7c29f476ffb953398bd7ad54109dd5bc10f6012d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6597e309_f7e40ace","updated":"2025-06-03 16:19:36.000000000","message":"Thanks Brian and Fernando","commit_id":"2f8c363310491fdf9a2ad3e537ed8bf93eb8ad03"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"50845792e471bbed259e93b9994ae13aa666a11b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"13054c7e_7a14d4b5","updated":"2025-06-03 15:39:08.000000000","message":"Thanks Simon","commit_id":"2f8c363310491fdf9a2ad3e537ed8bf93eb8ad03"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"bd07c10f782e488c5a070f1b34da9c4bd29be96c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"328a1768_926e1218","updated":"2025-06-03 15:39:17.000000000","message":"Thanks for updating the commit message, now it\u0027s clear this is not just an optimization, but addresses a design flaw.","commit_id":"2f8c363310491fdf9a2ad3e537ed8bf93eb8ad03"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"bc1963b00185ba236050ebb75be376cd333558e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4e1a15e6_be170976","updated":"2025-06-03 04:04:42.000000000","message":"hi Brian/Jon,\n\nwe have a RH customer waiting for this fix.\nOnce it gets merged into master, it needs to be cherry picked into RHOSO 18.\nSo, its little urgent for us.\n\nLooking forward to your feedback.\nAppreciate your support.","commit_id":"2f8c363310491fdf9a2ad3e537ed8bf93eb8ad03"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"3587cb7be1c5ecf80bf7a182963e9699151fb5fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8ad456a9_d1b2899c","updated":"2025-05-31 09:08:47.000000000","message":"recheck devstack-plugin-nfs-tempest-full","commit_id":"2f8c363310491fdf9a2ad3e537ed8bf93eb8ad03"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"37a1a7f48d9e523124450c5a4302537a7b588c6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"920db7e7_f85eabb5","updated":"2025-05-31 03:12:15.000000000","message":"recheck tempest-integrated-storage-ubuntu-jammy","commit_id":"2f8c363310491fdf9a2ad3e537ed8bf93eb8ad03"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"8201b30b93b0bf9f800e481554265afc37a21b0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"fa9c1165_9697e197","updated":"2025-06-04 18:32:44.000000000","message":"+1 from Alan and +2 from Brian, looks good to me.","commit_id":"255ccd6c6cc6c64b154d9fea7fc9020e80bb4766"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"4a5622536de47140646852f515f73bbb0e6055ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"497fc5b6_5331408d","updated":"2025-06-04 03:24:13.000000000","message":"Added launchpad bug and release notes.","commit_id":"255ccd6c6cc6c64b154d9fea7fc9020e80bb4766"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9d33543506a707c5626169e62034e333f8a31016","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"be04ee1c_a2307ae9","updated":"2025-06-04 14:44:50.000000000","message":"Everything looks in order.","commit_id":"255ccd6c6cc6c64b154d9fea7fc9020e80bb4766"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"0c5cbf548a7591a9b0fdbc55b0c63bc7167c0103","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c39bf986_791beb12","updated":"2025-06-04 12:35:45.000000000","message":"Thank you Alan","commit_id":"255ccd6c6cc6c64b154d9fea7fc9020e80bb4766"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"2ce55cbd62232956689fe82d736e0bba635ca63d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5182fbd4_290e83d2","updated":"2025-06-04 15:29:35.000000000","message":"Thank you Brian","commit_id":"255ccd6c6cc6c64b154d9fea7fc9020e80bb4766"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"1d4192eb8c3aa17f54a0e74c7180c87ac2a9333d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4e01783e_855663b9","updated":"2025-06-05 03:43:05.000000000","message":"Thank you Brian, Jon, Alan and Simon. The patch has merged.","commit_id":"255ccd6c6cc6c64b154d9fea7fc9020e80bb4766"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"9f3d7a69e0224ae2c7dc0bd42d4d5ac3931f6ffa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"dda7094b_02bf4e42","updated":"2025-06-05 03:43:38.000000000","message":"Thank you Fernando","commit_id":"255ccd6c6cc6c64b154d9fea7fc9020e80bb4766"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"6c9e4f9fae17d90098158f1f9ae78a1b00f12914","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"66ffd262_efe68f63","updated":"2025-06-04 20:11:10.000000000","message":"recheck\n\nUnrelated cinder-plugin-ceph-tempest failure","commit_id":"255ccd6c6cc6c64b154d9fea7fc9020e80bb4766"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"7278f40bca5dbe2db7c0bc59d9cf9cc180062f4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"fc855575_e06f4164","updated":"2025-06-04 07:38:39.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican","commit_id":"255ccd6c6cc6c64b154d9fea7fc9020e80bb4766"}],"cinder/volume/drivers/hpe/hpe_3par_iscsi.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"408aa9e9881303d26e9bdb3277e90159b1aca4e1","unresolved":true,"context_lines":[{"line_number":331,"context_line":"        for port in ready_ports:"},{"line_number":332,"context_line":"            iscsi_ip \u003d port[\u0027IPAddr\u0027]"},{"line_number":333,"context_line":"            if iscsi_ip in target_portal_ips:"},{"line_number":334,"context_line":"                LOG.debug(\"for iscsi ip: %(ip)s, create vlun\","},{"line_number":335,"context_line":"                          {\u0027ip\u0027: iscsi_ip})"},{"line_number":336,"context_line":"                lun_id \u003d ("},{"line_number":337,"context_line":"                    self._vlun_create_or_use_existing("},{"line_number":338,"context_line":"                        volume, common, host, iscsi_ips,"}],"source_content_type":"text/x-python","patch_set":3,"id":"a9b9ffa5_4c153f7e","line":335,"range":{"start_line":334,"start_character":16,"end_line":335,"end_character":43},"updated":"2025-05-28 16:05:43.000000000","message":"This debug message is misleading because you won\u0027t create the vlun if it already exists.  If you really want to log this, it might be better to move the logging to the appropriate place in _vlun_create_or_use_existing().","commit_id":"d66e31bffadd7a22050f9365e2cf1a6f6a070850"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"55be99a6ed75a7ba17a196ab488f412eac1dfa9a","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        for port in ready_ports:"},{"line_number":332,"context_line":"            iscsi_ip \u003d port[\u0027IPAddr\u0027]"},{"line_number":333,"context_line":"            if iscsi_ip in target_portal_ips:"},{"line_number":334,"context_line":"                LOG.debug(\"for iscsi ip: %(ip)s, create vlun\","},{"line_number":335,"context_line":"                          {\u0027ip\u0027: iscsi_ip})"},{"line_number":336,"context_line":"                lun_id \u003d ("},{"line_number":337,"context_line":"                    self._vlun_create_or_use_existing("},{"line_number":338,"context_line":"                        volume, common, host, iscsi_ips,"}],"source_content_type":"text/x-python","patch_set":3,"id":"6c066e9a_22429c8c","line":335,"range":{"start_line":334,"start_character":16,"end_line":335,"end_character":43},"in_reply_to":"a9b9ffa5_4c153f7e","updated":"2025-05-29 04:14:03.000000000","message":"Done","commit_id":"d66e31bffadd7a22050f9365e2cf1a6f6a070850"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"408aa9e9881303d26e9bdb3277e90159b1aca4e1","unresolved":true,"context_lines":[{"line_number":348,"context_line":""},{"line_number":349,"context_line":"            if \u0027iSCSIVlans\u0027 in port:"},{"line_number":350,"context_line":"                LOG.debug(\"iSCSIVlans: %(vlans)s\","},{"line_number":351,"context_line":"                          {\u0027vlans\u0027: port[\u0027iSCSIVlans\u0027]})"},{"line_number":352,"context_line":"                for vip in port[\u0027iSCSIVlans\u0027]:"},{"line_number":353,"context_line":"                    vlan_ip \u003d vip[\u0027IPAddr\u0027]"},{"line_number":354,"context_line":"                    # if vlan_ip is in cinder.conf and"}],"source_content_type":"text/x-python","patch_set":3,"id":"8c54170e_b8c21c2b","line":351,"updated":"2025-05-28 16:05:43.000000000","message":"I don\u0027t know if it matters, but you\u0027re not saying which port you\u0027re looking at when you dump this list of vlans.","commit_id":"d66e31bffadd7a22050f9365e2cf1a6f6a070850"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"55be99a6ed75a7ba17a196ab488f412eac1dfa9a","unresolved":true,"context_lines":[{"line_number":348,"context_line":""},{"line_number":349,"context_line":"            if \u0027iSCSIVlans\u0027 in port:"},{"line_number":350,"context_line":"                LOG.debug(\"iSCSIVlans: %(vlans)s\","},{"line_number":351,"context_line":"                          {\u0027vlans\u0027: port[\u0027iSCSIVlans\u0027]})"},{"line_number":352,"context_line":"                for vip in port[\u0027iSCSIVlans\u0027]:"},{"line_number":353,"context_line":"                    vlan_ip \u003d vip[\u0027IPAddr\u0027]"},{"line_number":354,"context_line":"                    # if vlan_ip is in cinder.conf and"}],"source_content_type":"text/x-python","patch_set":3,"id":"b2f8f708_6fe226b5","line":351,"in_reply_to":"8c54170e_b8c21c2b","updated":"2025-05-29 04:14:03.000000000","message":"during debug, it is better to have complete information.","commit_id":"d66e31bffadd7a22050f9365e2cf1a6f6a070850"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"e74aea07f0a836e56ae925574f5bbd741edf1a13","unresolved":false,"context_lines":[{"line_number":348,"context_line":""},{"line_number":349,"context_line":"            if \u0027iSCSIVlans\u0027 in port:"},{"line_number":350,"context_line":"                LOG.debug(\"iSCSIVlans: %(vlans)s\","},{"line_number":351,"context_line":"                          {\u0027vlans\u0027: port[\u0027iSCSIVlans\u0027]})"},{"line_number":352,"context_line":"                for vip in port[\u0027iSCSIVlans\u0027]:"},{"line_number":353,"context_line":"                    vlan_ip \u003d vip[\u0027IPAddr\u0027]"},{"line_number":354,"context_line":"                    # if vlan_ip is in cinder.conf and"}],"source_content_type":"text/x-python","patch_set":3,"id":"a96251cf_50addd85","line":351,"in_reply_to":"b2f8f708_6fe226b5","updated":"2025-05-29 04:15:20.000000000","message":"Acknowledged","commit_id":"d66e31bffadd7a22050f9365e2cf1a6f6a070850"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"408aa9e9881303d26e9bdb3277e90159b1aca4e1","unresolved":true,"context_lines":[{"line_number":356,"context_line":"                    # only then proceed with lun creation"},{"line_number":357,"context_line":"                    if vlan_ip in target_portal_ips and vlan_ip !\u003d iscsi_ip:"},{"line_number":358,"context_line":"                        LOG.debug(\"for vlan ip: %(ip)s, create vlun\","},{"line_number":359,"context_line":"                                  {\u0027ip\u0027: vlan_ip})"},{"line_number":360,"context_line":"                        lun_id \u003d ("},{"line_number":361,"context_line":"                            self._vlun_create_or_use_existing("},{"line_number":362,"context_line":"                                volume, common, host, iscsi_ips,"}],"source_content_type":"text/x-python","patch_set":3,"id":"66246654_fb03668a","line":359,"updated":"2025-05-28 16:05:43.000000000","message":"Same comment as line 335.","commit_id":"d66e31bffadd7a22050f9365e2cf1a6f6a070850"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"55be99a6ed75a7ba17a196ab488f412eac1dfa9a","unresolved":false,"context_lines":[{"line_number":356,"context_line":"                    # only then proceed with lun creation"},{"line_number":357,"context_line":"                    if vlan_ip in target_portal_ips and vlan_ip !\u003d iscsi_ip:"},{"line_number":358,"context_line":"                        LOG.debug(\"for vlan ip: %(ip)s, create vlun\","},{"line_number":359,"context_line":"                                  {\u0027ip\u0027: vlan_ip})"},{"line_number":360,"context_line":"                        lun_id \u003d ("},{"line_number":361,"context_line":"                            self._vlun_create_or_use_existing("},{"line_number":362,"context_line":"                                volume, common, host, iscsi_ips,"}],"source_content_type":"text/x-python","patch_set":3,"id":"cfe92af3_b60aa9a2","line":359,"in_reply_to":"66246654_fb03668a","updated":"2025-05-29 04:14:03.000000000","message":"Done","commit_id":"d66e31bffadd7a22050f9365e2cf1a6f6a070850"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5c2d359b334fce6a65b99e807743eb5f09a569ce","unresolved":true,"context_lines":[{"line_number":331,"context_line":"        for port in ready_ports:"},{"line_number":332,"context_line":"            iscsi_ip \u003d port[\u0027IPAddr\u0027]"},{"line_number":333,"context_line":"            if iscsi_ip in target_portal_ips:"},{"line_number":334,"context_line":"                LOG.debug(\"for iscsi ip: %(ip)s, create vlun or use existing\","},{"line_number":335,"context_line":"                          {\u0027ip\u0027: iscsi_ip})"},{"line_number":336,"context_line":"                lun_id \u003d ("},{"line_number":337,"context_line":"                    self._vlun_create_or_use_existing("}],"source_content_type":"text/x-python","patch_set":5,"id":"f75e8ded_483e437e","line":334,"updated":"2025-05-30 12:32:30.000000000","message":"All this is telling you is that you took the \"if\" branch here.  Maybe that\u0027s all you want to know, but it seems like it would be useful to know for debugging purposes if a vlun was created for this ip, or if you\u0027re reusing an existing one (and if so, which one).  That\u0027s why I suggested moving this into the _vlun_create_or_use_existing() function.  But maybe that function is called in other places where such logging would be excessive (or maybe that info isn\u0027t really useful to you).  Feel free to tell me that the logging is fine as it is; i just wanted one more chance for you to think about it.","commit_id":"f760b23d0e75acf5b190e82f6f7d918c834b0ce9"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"c1f156b86fda8f396a1da9426f757fab2d822a00","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        for port in ready_ports:"},{"line_number":332,"context_line":"            iscsi_ip \u003d port[\u0027IPAddr\u0027]"},{"line_number":333,"context_line":"            if iscsi_ip in target_portal_ips:"},{"line_number":334,"context_line":"                LOG.debug(\"for iscsi ip: %(ip)s, create vlun or use existing\","},{"line_number":335,"context_line":"                          {\u0027ip\u0027: iscsi_ip})"},{"line_number":336,"context_line":"                lun_id \u003d ("},{"line_number":337,"context_line":"                    self._vlun_create_or_use_existing("}],"source_content_type":"text/x-python","patch_set":5,"id":"067b5043_20bc97b3","line":334,"in_reply_to":"f75e8ded_483e437e","updated":"2025-05-30 15:36:23.000000000","message":"We are fine with current log messages.\nIf lun is created, we see below log message in cinder-volume log.\n\nMay 29 09:15:55 bay02 cinder-volume[2678426]: #033[00;32mDEBUG hpe3parclient.http [#033[01;36mreq-67cf1f2e-0614-4cfd-a9e1-dca91bc22323 req-28cad1f3-83f7-4977-a764-ead178bf61fc #033[00;36madmin None#033[00;32m] #033[01;35m#033[00;32mREQ BODY: {\"volumeName\": \"osv-tJ3ZM9jcQmuL0yTcdYGzrw\", \"hostname\": \"bay02\", \"portPos\": {\"node\": 0, \"slot\": 4, \"cardPort\": 2}, \"autoLun\": true, \"maxAutoLun\": 0, \"lun\": 0}\n\nThis is sufficient for us to know if new lun is created.","commit_id":"f760b23d0e75acf5b190e82f6f7d918c834b0ce9"}]}