)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"c95eb44ec6698ef95476981e4aacbd9db1f6c762","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"051485f2_78977331","updated":"2025-06-02 22:55:12.000000000","message":"run Pure Storage CI","commit_id":"98a74901691bd3e3a98a56f4f7a8ac3009a9bede"},{"author":{"_account_id":36132,"name":"Cuiye Liu","display_name":"Cherry","email":"cuiye.liu@dell.com","username":"cuiyeliu"},"change_message_id":"c337a7214c796a33b95d78c1c39e1447ba4e7bc7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fa2641d5_03150547","updated":"2025-07-24 02:50:02.000000000","message":"LGTM","commit_id":"465e4b39869c214fcc56c9a26b25640b5bf32b20"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"475e40b244a9c27cee04e26a109ffb46115f13c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"21e497e9_65896f96","updated":"2025-07-23 09:26:49.000000000","message":"LGTM also zuul and CI got passed.","commit_id":"465e4b39869c214fcc56c9a26b25640b5bf32b20"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"8117a4f0221dfb8fe211490a9fbe6722c3208fde","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f927075b_71536092","updated":"2025-09-05 13:28:04.000000000","message":"Looks good to me","commit_id":"465e4b39869c214fcc56c9a26b25640b5bf32b20"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"3e1c3765a93c4049fd1fedcad89815942866e9ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6085e108_70dee806","updated":"2025-09-04 18:30:58.000000000","message":"Seems reasonable, code looks okay.","commit_id":"465e4b39869c214fcc56c9a26b25640b5bf32b20"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"eda61a1b317591efa6a0fd583187ccadbdac9e2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fe8b9639_6ff447b2","updated":"2025-09-04 14:08:48.000000000","message":"Signed-off-by is missing in the commit message.","commit_id":"465e4b39869c214fcc56c9a26b25640b5bf32b20"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"bd0f37af3714b32b4ed5cd6d636ef2fde790c58e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6a736a71_d5758cde","updated":"2025-09-04 14:09:57.000000000","message":"hi Simon, is there a open bug for this issue?","commit_id":"465e4b39869c214fcc56c9a26b25640b5bf32b20"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d7715e8581fb2fd633905149116c0727b9ea4e82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d49212c2_51bda602","updated":"2025-09-08 21:07:34.000000000","message":"one question inline, maybe we are always taking the \"else:\" route without noticing but the check doesn\u0027t seem to match what os-brick returns (which is also wrong).","commit_id":"465e4b39869c214fcc56c9a26b25640b5bf32b20"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"184f056ffcf41d00edefb29f569c8d693411e122","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a3a61535_c5ab9232","in_reply_to":"1614d080_73355c84","updated":"2025-09-04 14:58:53.000000000","message":"ack","commit_id":"465e4b39869c214fcc56c9a26b25640b5bf32b20"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"2d441f9965e584793ea7533dfe4c91fdfac5d50c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3aaa70f4_c5db2e3e","in_reply_to":"51e4b603_2a37b51c","updated":"2025-09-04 14:52:52.000000000","message":"Makes sense, thanks for the clarification, removing the -1","commit_id":"465e4b39869c214fcc56c9a26b25640b5bf32b20"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"c3cd073836d6aff0fe511dde4b77fc36b0870831","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1614d080_73355c84","in_reply_to":"6a736a71_d5758cde","updated":"2025-09-04 14:20:09.000000000","message":"This is not really a bug, but an enhancement, so no bug-report required","commit_id":"465e4b39869c214fcc56c9a26b25640b5bf32b20"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"c3cd073836d6aff0fe511dde4b77fc36b0870831","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"51e4b603_2a37b51c","in_reply_to":"fe8b9639_6ff447b2","updated":"2025-09-04 14:20:09.000000000","message":"signoff not required for patches that passed zuul prior to the signoff requirement. If it was required for all we would have to recheck every patch in openstack pre-requirement - not feasable","commit_id":"465e4b39869c214fcc56c9a26b25640b5bf32b20"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"015c386a0b10a65c6a0ec4aa482013ab476c1df4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"25a125e1_ad630918","updated":"2025-09-10 15:38:42.000000000","message":"LGTM","commit_id":"59e4faefec7292eebd35fa3e2dc87dcf8551f253"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"e1f4db56fcbdbc29892afec3832297705eac6044","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8fce9d8a_6be5275a","updated":"2025-09-10 19:08:34.000000000","message":"recheck","commit_id":"59e4faefec7292eebd35fa3e2dc87dcf8551f253"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"b990a4514f3a2f2c5e924ac6578a9d187d50dc21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e43e450d_876caf48","updated":"2025-09-10 21:41:34.000000000","message":"recheck","commit_id":"59e4faefec7292eebd35fa3e2dc87dcf8551f253"}],"cinder/volume/drivers/pure.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d7715e8581fb2fd633905149116c0727b9ea4e82","unresolved":true,"context_lines":[{"line_number":2541,"context_line":"    def _generate_purity_host_name(connector):"},{"line_number":2542,"context_line":"        \"\"\"Return a valid Purity host name based on the name passed in.\"\"\""},{"line_number":2543,"context_line":"        name \u003d connector[\"host\"]"},{"line_number":2544,"context_line":"        if \"system_uuid\" in connector:"},{"line_number":2545,"context_line":"            system_id \u003d str(connector[\"system_uuid\"]).replace(\"-\", \"\")"},{"line_number":2546,"context_line":"        else:"},{"line_number":2547,"context_line":"            system_id \u003d uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":3,"id":"24d26f97_f0f26770","line":2544,"range":{"start_line":2544,"start_character":8,"end_line":2544,"end_character":38},"updated":"2025-09-08 21:07:34.000000000","message":"does this work? I can see that the system uuid has a \"space\" in between rather than an \"underscore\"[1] which looks like a potential bug anyway\n\n[1] https://github.com/openstack/os-brick/blob/master/os_brick/initiator/connectors/nvmeof.py#L811","commit_id":"465e4b39869c214fcc56c9a26b25640b5bf32b20"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4fc7e7c79752da29efa6312d07e8ea196277e2cd","unresolved":true,"context_lines":[{"line_number":2541,"context_line":"    def _generate_purity_host_name(connector):"},{"line_number":2542,"context_line":"        \"\"\"Return a valid Purity host name based on the name passed in.\"\"\""},{"line_number":2543,"context_line":"        name \u003d connector[\"host\"]"},{"line_number":2544,"context_line":"        if \"system_uuid\" in connector:"},{"line_number":2545,"context_line":"            system_id \u003d str(connector[\"system_uuid\"]).replace(\"-\", \"\")"},{"line_number":2546,"context_line":"        else:"},{"line_number":2547,"context_line":"            system_id \u003d uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":3,"id":"68a37ad7_d0c8e2ff","line":2544,"range":{"start_line":2544,"start_character":8,"end_line":2544,"end_character":38},"in_reply_to":"24d26f97_f0f26770","updated":"2025-09-08 21:22:48.000000000","message":"Maybe can test against [1] and see if it works as expected\n\n[1] https://review.opendev.org/c/openstack/os-brick/+/960205","commit_id":"465e4b39869c214fcc56c9a26b25640b5bf32b20"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"d7816029232078c04890ff2e107b08ca02c4e800","unresolved":true,"context_lines":[{"line_number":2541,"context_line":"    def _generate_purity_host_name(connector):"},{"line_number":2542,"context_line":"        \"\"\"Return a valid Purity host name based on the name passed in.\"\"\""},{"line_number":2543,"context_line":"        name \u003d connector[\"host\"]"},{"line_number":2544,"context_line":"        if \"system_uuid\" in connector:"},{"line_number":2545,"context_line":"            system_id \u003d str(connector[\"system_uuid\"]).replace(\"-\", \"\")"},{"line_number":2546,"context_line":"        else:"},{"line_number":2547,"context_line":"            system_id \u003d uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":3,"id":"7fb5d0a7_e3c00730","line":2544,"range":{"start_line":2544,"start_character":8,"end_line":2544,"end_character":38},"in_reply_to":"68a37ad7_d0c8e2ff","updated":"2025-09-10 14:13:27.000000000","message":"this is a typo - should be `system uuid` - this is the value provided by os-brick and used by other drivers,","commit_id":"465e4b39869c214fcc56c9a26b25640b5bf32b20"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"1c54735f41a25d0e2503a9ca23d62409892ad532","unresolved":false,"context_lines":[{"line_number":2541,"context_line":"    def _generate_purity_host_name(connector):"},{"line_number":2542,"context_line":"        \"\"\"Return a valid Purity host name based on the name passed in.\"\"\""},{"line_number":2543,"context_line":"        name \u003d connector[\"host\"]"},{"line_number":2544,"context_line":"        if \"system_uuid\" in connector:"},{"line_number":2545,"context_line":"            system_id \u003d str(connector[\"system_uuid\"]).replace(\"-\", \"\")"},{"line_number":2546,"context_line":"        else:"},{"line_number":2547,"context_line":"            system_id \u003d uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":3,"id":"fc476db1_5b5b1f60","line":2544,"range":{"start_line":2544,"start_character":8,"end_line":2544,"end_character":38},"in_reply_to":"7fb5d0a7_e3c00730","updated":"2025-09-10 14:13:59.000000000","message":".","commit_id":"465e4b39869c214fcc56c9a26b25640b5bf32b20"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"015c386a0b10a65c6a0ec4aa482013ab476c1df4","unresolved":false,"context_lines":[{"line_number":2541,"context_line":"    def _generate_purity_host_name(connector):"},{"line_number":2542,"context_line":"        \"\"\"Return a valid Purity host name based on the name passed in.\"\"\""},{"line_number":2543,"context_line":"        name \u003d connector[\"host\"]"},{"line_number":2544,"context_line":"        if \"system_uuid\" in connector:"},{"line_number":2545,"context_line":"            system_id \u003d str(connector[\"system_uuid\"]).replace(\"-\", \"\")"},{"line_number":2546,"context_line":"        else:"},{"line_number":2547,"context_line":"            system_id \u003d uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":3,"id":"8806b090_e48d1854","line":2544,"range":{"start_line":2544,"start_character":8,"end_line":2544,"end_character":38},"in_reply_to":"fc476db1_5b5b1f60","updated":"2025-09-10 15:38:42.000000000","message":"Given that the RSD and infinidat drivers are using this convention, no reason to block this patch for it","commit_id":"465e4b39869c214fcc56c9a26b25640b5bf32b20"}]}